ethtool: pse-pd: Fix double word in comments
[linux-block.git] / net / ethtool / pause.c
index a8c113d244db9c4e13f089ddb40e3d390f620148..6657d0b888d83a0cc4c02254aaafc1f9bd43b0bf 100644 (file)
@@ -5,8 +5,12 @@
 
 struct pause_req_info {
        struct ethnl_req_info           base;
+       enum ethtool_mac_stats_src      src;
 };
 
+#define PAUSE_REQINFO(__req_base) \
+       container_of(__req_base, struct pause_req_info, base)
+
 struct pause_reply_data {
        struct ethnl_reply_data         base;
        struct ethtool_pauseparam       pauseparam;
@@ -19,13 +23,40 @@ struct pause_reply_data {
 const struct nla_policy ethnl_pause_get_policy[] = {
        [ETHTOOL_A_PAUSE_HEADER]                =
                NLA_POLICY_NESTED(ethnl_header_policy_stats),
+       [ETHTOOL_A_PAUSE_STATS_SRC]             =
+               NLA_POLICY_MAX(NLA_U32, ETHTOOL_MAC_STATS_SRC_PMAC),
 };
 
+static int pause_parse_request(struct ethnl_req_info *req_base,
+                              struct nlattr **tb,
+                              struct netlink_ext_ack *extack)
+{
+       enum ethtool_mac_stats_src src = ETHTOOL_MAC_STATS_SRC_AGGREGATE;
+       struct pause_req_info *req_info = PAUSE_REQINFO(req_base);
+
+       if (tb[ETHTOOL_A_PAUSE_STATS_SRC]) {
+               if (!(req_base->flags & ETHTOOL_FLAG_STATS)) {
+                       NL_SET_ERR_MSG_MOD(extack,
+                                          "ETHTOOL_FLAG_STATS must be set when requesting a source of stats");
+                       return -EINVAL;
+               }
+
+               src = nla_get_u32(tb[ETHTOOL_A_PAUSE_STATS_SRC]);
+       }
+
+       req_info->src = src;
+
+       return 0;
+}
+
 static int pause_prepare_data(const struct ethnl_req_info *req_base,
                              struct ethnl_reply_data *reply_base,
                              struct genl_info *info)
 {
+       const struct pause_req_info *req_info = PAUSE_REQINFO(req_base);
+       struct netlink_ext_ack *extack = info ? info->extack : NULL;
        struct pause_reply_data *data = PAUSE_REPDATA(reply_base);
+       enum ethtool_mac_stats_src src = req_info->src;
        struct net_device *dev = reply_base->dev;
        int ret;
 
@@ -34,14 +65,26 @@ static int pause_prepare_data(const struct ethnl_req_info *req_base,
 
        ethtool_stats_init((u64 *)&data->pausestat,
                           sizeof(data->pausestat) / 8);
+       data->pausestat.src = src;
 
        ret = ethnl_ops_begin(dev);
        if (ret < 0)
                return ret;
+
+       if ((src == ETHTOOL_MAC_STATS_SRC_EMAC ||
+            src == ETHTOOL_MAC_STATS_SRC_PMAC) &&
+           !__ethtool_dev_mm_supported(dev)) {
+               NL_SET_ERR_MSG_MOD(extack,
+                                  "Device does not support MAC merge layer");
+               ethnl_ops_complete(dev);
+               return -EOPNOTSUPP;
+       }
+
        dev->ethtool_ops->get_pauseparam(dev, &data->pauseparam);
        if (req_base->flags & ETHTOOL_FLAG_STATS &&
            dev->ethtool_ops->get_pause_stats)
                dev->ethtool_ops->get_pause_stats(dev, &data->pausestat);
+
        ethnl_ops_complete(dev);
 
        return 0;
@@ -56,6 +99,7 @@ static int pause_reply_size(const struct ethnl_req_info *req_base,
 
        if (req_base->flags & ETHTOOL_FLAG_STATS)
                n += nla_total_size(0) +        /* _PAUSE_STATS */
+                    nla_total_size(sizeof(u32)) + /* _PAUSE_STATS_SRC */
                     nla_total_size_64bit(sizeof(u64)) * ETHTOOL_PAUSE_STAT_CNT;
        return n;
 }
@@ -77,6 +121,9 @@ static int pause_put_stats(struct sk_buff *skb,
        const u16 pad = ETHTOOL_A_PAUSE_STAT_PAD;
        struct nlattr *nest;
 
+       if (nla_put_u32(skb, ETHTOOL_A_PAUSE_STATS_SRC, pause_stats->src))
+               return -EMSGSIZE;
+
        nest = nla_nest_start(skb, ETHTOOL_A_PAUSE_STATS);
        if (!nest)
                return -EMSGSIZE;
@@ -114,18 +161,6 @@ static int pause_fill_reply(struct sk_buff *skb,
        return 0;
 }
 
-const struct ethnl_request_ops ethnl_pause_request_ops = {
-       .request_cmd            = ETHTOOL_MSG_PAUSE_GET,
-       .reply_cmd              = ETHTOOL_MSG_PAUSE_GET_REPLY,
-       .hdr_attr               = ETHTOOL_A_PAUSE_HEADER,
-       .req_info_size          = sizeof(struct pause_req_info),
-       .reply_data_size        = sizeof(struct pause_reply_data),
-
-       .prepare_data           = pause_prepare_data,
-       .reply_size             = pause_reply_size,
-       .fill_reply             = pause_fill_reply,
-};
-
 /* PAUSE_SET */
 
 const struct nla_policy ethnl_pause_set_policy[] = {
@@ -136,51 +171,49 @@ const struct nla_policy ethnl_pause_set_policy[] = {
        [ETHTOOL_A_PAUSE_TX]                    = { .type = NLA_U8 },
 };
 
-int ethnl_set_pause(struct sk_buff *skb, struct genl_info *info)
+static int
+ethnl_set_pause_validate(struct ethnl_req_info *req_info,
+                        struct genl_info *info)
 {
+       const struct ethtool_ops *ops = req_info->dev->ethtool_ops;
+
+       return ops->get_pauseparam && ops->set_pauseparam ? 1 : -EOPNOTSUPP;
+}
+
+static int
+ethnl_set_pause(struct ethnl_req_info *req_info, struct genl_info *info)
+{
+       struct net_device *dev = req_info->dev;
        struct ethtool_pauseparam params = {};
-       struct ethnl_req_info req_info = {};
        struct nlattr **tb = info->attrs;
-       const struct ethtool_ops *ops;
-       struct net_device *dev;
        bool mod = false;
        int ret;
 
-       ret = ethnl_parse_header_dev_get(&req_info,
-                                        tb[ETHTOOL_A_PAUSE_HEADER],
-                                        genl_info_net(info), info->extack,
-                                        true);
-       if (ret < 0)
-               return ret;
-       dev = req_info.dev;
-       ops = dev->ethtool_ops;
-       ret = -EOPNOTSUPP;
-       if (!ops->get_pauseparam || !ops->set_pauseparam)
-               goto out_dev;
-
-       rtnl_lock();
-       ret = ethnl_ops_begin(dev);
-       if (ret < 0)
-               goto out_rtnl;
-       ops->get_pauseparam(dev, &params);
+       dev->ethtool_ops->get_pauseparam(dev, &params);
 
        ethnl_update_bool32(&params.autoneg, tb[ETHTOOL_A_PAUSE_AUTONEG], &mod);
        ethnl_update_bool32(&params.rx_pause, tb[ETHTOOL_A_PAUSE_RX], &mod);
        ethnl_update_bool32(&params.tx_pause, tb[ETHTOOL_A_PAUSE_TX], &mod);
-       ret = 0;
        if (!mod)
-               goto out_ops;
+               return 0;
 
        ret = dev->ethtool_ops->set_pauseparam(dev, &params);
-       if (ret < 0)
-               goto out_ops;
-       ethtool_notify(dev, ETHTOOL_MSG_PAUSE_NTF, NULL);
-
-out_ops:
-       ethnl_ops_complete(dev);
-out_rtnl:
-       rtnl_unlock();
-out_dev:
-       ethnl_parse_header_dev_put(&req_info);
-       return ret;
+       return ret < 0 ? ret : 1;
 }
+
+const struct ethnl_request_ops ethnl_pause_request_ops = {
+       .request_cmd            = ETHTOOL_MSG_PAUSE_GET,
+       .reply_cmd              = ETHTOOL_MSG_PAUSE_GET_REPLY,
+       .hdr_attr               = ETHTOOL_A_PAUSE_HEADER,
+       .req_info_size          = sizeof(struct pause_req_info),
+       .reply_data_size        = sizeof(struct pause_reply_data),
+
+       .parse_request          = pause_parse_request,
+       .prepare_data           = pause_prepare_data,
+       .reply_size             = pause_reply_size,
+       .fill_reply             = pause_fill_reply,
+
+       .set_validate           = ethnl_set_pause_validate,
+       .set                    = ethnl_set_pause,
+       .set_ntf_cmd            = ETHTOOL_MSG_PAUSE_NTF,
+};