iowatcher: Add bounds checking in find_step
[blktrace.git] / iowatcher / plot.c
index ce8fab86399f5aa8e37faee9d511c89e0674528b..d486f293fc2bdf3103853c11346568cca2fa2c39 100644 (file)
@@ -12,7 +12,7 @@
  *
  *  You should have received a copy of the GNU General Public License
  *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  *
  *  Parts of this file were imported from Jens Axboe's blktrace sources (also GPL)
  */
@@ -34,8 +34,9 @@
 #include "plot.h"
 
 static int io_graph_scale = 8;
-static int graph_width = 600;
-static int graph_height = 150;
+static int graph_width = 700;
+static int graph_height = 250;
+static int graph_circle_extra = 30;
 static int graph_inner_x_margin = 2;
 static int graph_inner_y_margin = 2;
 static int graph_tick_len = 5;
@@ -65,7 +66,68 @@ static int rolling_avg_secs = 0;
 static int line_len = 1024;
 static char line[1024];
 
-struct graph_line_data *alloc_line_data(int seconds, int stop_seconds)
+static int final_height = 0;
+static int final_width = 0;
+
+static char *colors[] = {
+       "blue", "darkgreen",
+       "red",
+       "darkviolet",
+       "orange",
+       "aqua",
+       "brown", "#00FF00",
+       "yellow", "coral",
+       "black", "darkred",
+       "fuchsia", "crimson",
+       NULL };
+
+extern unsigned int longest_proc_name;
+
+char *pick_color(void)
+{
+       static int color_index;
+       char *ret = colors[color_index];
+
+       if (!ret) {
+               color_index = 0;
+               ret = colors[color_index];
+       }
+       color_index++;
+       return ret;
+}
+
+char *pick_fio_color(void)
+{
+       static int fio_color_index;
+       char *ret = colors[fio_color_index];
+
+       if (!ret) {
+               fio_color_index = 0;
+               ret = colors[fio_color_index];
+       }
+       fio_color_index += 2;
+       return ret;
+}
+
+static int cpu_color_index;
+
+char *pick_cpu_color(void)
+{
+       char *ret = colors[cpu_color_index];
+       if (!ret) {
+               cpu_color_index = 0;
+               ret = colors[cpu_color_index];
+       }
+       cpu_color_index++;
+       return ret;
+}
+
+void reset_cpu_color(void)
+{
+       cpu_color_index = 0;
+}
+
+struct graph_line_data *alloc_line_data(int min_seconds, int max_seconds, int stop_seconds)
 {
        int size = sizeof(struct graph_line_data) + (stop_seconds + 1) * sizeof(struct graph_line_pair);
        struct graph_line_data *gld;
@@ -75,7 +137,8 @@ struct graph_line_data *alloc_line_data(int seconds, int stop_seconds)
                fprintf(stderr, "Unable to allocate memory for graph data\n");
                exit(1);
        }
-       gld->seconds = seconds;
+       gld->min_seconds = min_seconds;
+       gld->max_seconds = max_seconds;
        gld->stop_seconds = stop_seconds;
        return gld;
 }
@@ -86,7 +149,7 @@ void free_line_data(struct graph_line_data *gld)
        free(gld);
 }
 
-struct graph_dot_data *alloc_dot_data(int seconds, u64 max_offset, int stop_seconds)
+struct graph_dot_data *alloc_dot_data(int min_seconds, int max_seconds, u64 min_offset, u64 max_offset, int stop_seconds, char *color, char *label)
 {
        int size;
        int arr_size;
@@ -100,18 +163,26 @@ struct graph_dot_data *alloc_dot_data(int seconds, u64 max_offset, int stop_seco
        arr_size = (rows + 1) * cols;
 
        /* the number of bytes */
-       arr_size /= 8;
+       arr_size = (arr_size + 7) / 8;
 
        gdd = calloc(1, size + arr_size);
        if (!gdd) {
                fprintf(stderr, "Unable to allocate memory for graph data\n");
                exit(1);
        }
-       gdd->seconds = seconds;
+       gdd->min_seconds = min_seconds;
+       gdd->max_seconds = max_seconds;
        gdd->stop_seconds = stop_seconds;
        gdd->rows = rows;
        gdd->cols = cols;
+       gdd->min_offset = min_offset;
        gdd->max_offset = max_offset;
+       gdd->color = color;
+       gdd->label = label;
+
+       if (strlen(label) > longest_proc_name)
+               longest_proc_name = strlen(label);
+
        return gdd;
 }
 
@@ -122,9 +193,8 @@ void free_dot_data(struct graph_dot_data *gdd)
 
 void set_gdd_bit(struct graph_dot_data *gdd, u64 offset, double bytes, double time)
 {
-       double bytes_per_row = (double)gdd->max_offset / gdd->rows;
-
-       double secs_per_col = (double)gdd->seconds / gdd->cols;
+       double bytes_per_row = (double)(gdd->max_offset - gdd->min_offset + 1) / gdd->rows;
+       double secs_per_col = (double)(gdd->max_seconds - gdd->min_seconds) / gdd->cols;
        double col;
        double row;
        int col_int;
@@ -134,14 +204,13 @@ void set_gdd_bit(struct graph_dot_data *gdd, u64 offset, double bytes, double ti
        int bit_mod;
        double mod = bytes_per_row;
 
-       if (offset > gdd->max_offset)
+       if (offset > gdd->max_offset || offset < gdd->min_offset)
                return;
-
        gdd->total_ios++;
        time = time / 1000000000.0;
-       while (bytes > 0) {
-               row = (double)offset / bytes_per_row;
-               col = time / secs_per_col;
+       while (bytes > 0 && offset <= gdd->max_offset) {
+               row = (double)(offset - gdd->min_offset) / bytes_per_row;
+               col = (time - gdd->min_seconds) / secs_per_col;
 
                col_int = floor(col);
                row_int = floor(row);
@@ -210,7 +279,8 @@ static double rolling_avg(struct graph_line_pair *data, int index, int distance)
 
 void write_svg_header(int fd)
 {
-       char *header = "<svg  xmlns=\"http://www.w3.org/2000/svg\"\nxmlns:xlink=\"http://www.w3.org/1999/xlink\">\n";
+       char *spaces = "                                                    \n";
+       char *header = "<svg  xmlns=\"http://www.w3.org/2000/svg\">\n";
        char *filter1 ="<filter id=\"shadow\">\n "
                "<feOffset result=\"offOut\" in=\"SourceAlpha\" dx=\"4\" dy=\"4\" />\n "
                "<feGaussianBlur result=\"blurOut\" in=\"offOut\" stdDeviation=\"2\" />\n "
@@ -230,8 +300,15 @@ void write_svg_header(int fd)
                "</filter>\n";
        char *defs_start = "<defs>\n";
        char *defs_close = "</defs>\n";
+       final_width = 0;
+       final_height = 0;
 
        write(fd, header, strlen(header));
+       /* write a bunch of spaces so we can stuff in the width and height later */
+       write(fd, spaces, strlen(spaces));
+       write(fd, spaces, strlen(spaces));
+       write(fd, spaces, strlen(spaces));
+
        write(fd, defs_start, strlen(defs_start));
        write(fd, filter1, strlen(filter1));
        write(fd, filter2, strlen(filter2));
@@ -300,7 +377,6 @@ static int axis_x_off(int x)
        return (int)axis_x_off_double(x);
 }
 
-
 /*
  * this draws a backing rectangle for the plot and it
  * also creates a new svg element so our offsets can
@@ -312,32 +388,43 @@ void setup_axis(struct plot *plot)
        int len;
        int fd = plot->fd;
        int bump_height = tick_font_size * 3 + axis_label_font_size;
+       int local_legend_width = legend_width;
 
+       if (plot->no_legend)
+               local_legend_width = 0;
 
-       plot->total_width = axis_x_off(graph_width) + graph_left_pad / 2 + legend_width;
+       plot->total_width = axis_x_off(graph_width) + graph_left_pad / 2 + local_legend_width;
        plot->total_height = axis_y() + tick_label_pad + tick_font_size;
 
        if (plot->add_xlabel)
                plot->total_height += bump_height;
 
        /* backing rect */
-       snprintf(line, line_len, "<rect x=\"0\" y=\"%d\" width=\"%d\" "
+       snprintf(line, line_len, "<rect x=\"%d\" y=\"%d\" width=\"%d\" "
                 "height=\"%d\" fill=\"white\" stroke=\"none\"/>",
+                plot->start_x_offset,
                plot->start_y_offset, plot->total_width + 40,
                plot->total_height + 20);
        len = strlen(line);
        write(fd, line, len);
-       snprintf(line, line_len, "<rect x=\"15\" y=\"%d\" width=\"%d\" "
+
+       snprintf(line, line_len, "<rect x=\"%d\" y=\"%d\" width=\"%d\" "
                 "filter=\"url(#shadow)\" "
                 "height=\"%d\" fill=\"white\" stroke=\"none\"/>",
+                plot->start_x_offset + 15,
                plot->start_y_offset, plot->total_width, plot->total_height);
        len = strlen(line);
        write(fd, line, len);
        plot->total_height += 20;
+       plot->total_width += 20;
 
+       if (plot->total_height + plot->start_y_offset > final_height)
+               final_height = plot->total_height + plot->start_y_offset;
+       if (plot->start_x_offset + plot->total_width + 40 > final_width)
+               final_width = plot->start_x_offset + plot->total_width + 40;
 
        /* create an svg object for all our coords to be relative against */
-       snprintf(line, line_len, "<svg x=\"%d\" y=\"%d\" style=\"enable-background:new\">\n", plot->start_x_offset, plot->start_y_offset);
+       snprintf(line, line_len, "<svg x=\"%d\" y=\"%d\">\n", plot->start_x_offset, plot->start_y_offset);
        write(fd, line, strlen(line));
 
        snprintf(line, 1024, "<path d=\"M%d %d h %d V %d H %d Z\" stroke=\"black\" stroke-width=\"2\" fill=\"none\"/>\n",
@@ -352,6 +439,55 @@ void setup_axis(struct plot *plot)
        }
 }
 
+/*
+ * this draws a backing rectangle for the plot and it
+ * also creates a new svg element so our offsets can
+ * be relative to this one plot.
+ */
+void setup_axis_spindle(struct plot *plot)
+{
+       int len;
+       int fd = plot->fd;
+       int bump_height = tick_font_size * 3 + axis_label_font_size;
+
+       legend_x_off = -60;
+
+       plot->total_width = axis_x_off(graph_width) + legend_width;
+       plot->total_height = axis_y() + tick_label_pad + tick_font_size;
+
+       if (plot->add_xlabel)
+               plot->total_height += bump_height;
+
+       /* backing rect */
+       snprintf(line, line_len, "<rect x=\"%d\" y=\"%d\" width=\"%d\" "
+                "height=\"%d\" fill=\"white\" stroke=\"none\"/>",
+                plot->start_x_offset,
+               plot->start_y_offset, plot->total_width + 10,
+               plot->total_height + 20);
+       len = strlen(line);
+       write(fd, line, len);
+
+       snprintf(line, line_len, "<rect x=\"%d\" y=\"%d\" width=\"%d\" "
+                "filter=\"url(#shadow)\" "
+                "height=\"%d\" fill=\"white\" stroke=\"none\"/>",
+                plot->start_x_offset + 15,
+               plot->start_y_offset, plot->total_width - 30,
+               plot->total_height);
+       len = strlen(line);
+       write(fd, line, len);
+       plot->total_height += 20;
+
+       if (plot->total_height + plot->start_y_offset > final_height)
+               final_height = plot->total_height + plot->start_y_offset;
+       if (plot->start_x_offset + plot->total_width + 40 > final_width)
+               final_width = plot->start_x_offset + plot->total_width + 40;
+
+       /* create an svg object for all our coords to be relative against */
+       snprintf(line, line_len, "<svg x=\"%d\" y=\"%d\">\n", plot->start_x_offset, plot->start_y_offset);
+       write(fd, line, strlen(line));
+
+}
+
 /* draw a plot title.  This should be done only once,
  * and it bumps the plot width/height numbers by
  * what it draws.
@@ -382,14 +518,36 @@ void set_plot_title(struct plot *plot, char *title)
        write(fd, line, len);
 }
 
+#define TICK_MINI_STEPS 3
+
+static double find_step(double first, double last, int num_ticks)
+{
+       int mini_step[TICK_MINI_STEPS] = { 1, 2, 5 };
+       int cur_mini_step = 0;
+       double step = (last - first) / num_ticks;
+       double log10 = log(10);
+
+       /* Round to power of 10 */
+       step = exp(floor(log(step) / log10) * log10);
+       /* Scale down step to provide enough ticks */
+       while (cur_mini_step < TICK_MINI_STEPS
+              && (last - first) / (step * mini_step[cur_mini_step]) > num_ticks)
+               cur_mini_step++;
+
+       if (cur_mini_step > 0)
+               step *= mini_step[cur_mini_step - 1];
+
+       return step;
+}
+
 /*
  * create evenly spread out ticks along the xaxis.  if tick only is set
  * this just makes the ticks, otherwise it labels each tick as it goes
  */
 void set_xticks(struct plot *plot, int num_ticks, int first, int last)
 {
-       int pixels_per_tick = graph_width / num_ticks;
-       int step = (last - first) / num_ticks;
+       int pixels_per_tick;
+       double step;
        int i;
        int tick_y = axis_y_off(graph_tick_len) + graph_inner_y_margin;
        int tick_x = axis_x();
@@ -400,6 +558,14 @@ void set_xticks(struct plot *plot, int num_ticks, int first, int last)
        char *middle = "middle";
        char *start = "start";
 
+       step = find_step(first, last, num_ticks);
+       /*
+        * We don't want last two ticks to be too close together so subtract
+        * 20% of the step from the interval
+        */
+       num_ticks = (double)(last - first - step / 5) / step + 1;
+       pixels_per_tick = graph_width * step / (double)(last - first);
+
        for (i = 0; i < num_ticks; i++) {
                char *anchor;
                if (i != 0) {
@@ -412,19 +578,32 @@ void set_xticks(struct plot *plot, int num_ticks, int first, int last)
                }
 
                if (!tick_only) {
-                       snprintf(line, line_len, "<text x=\"%d\" y=\"%d\" font-family=\"%s\" font-size=\"%d\" "
-                               "fill=\"black\" style=\"text-anchor: %s\">%d</text>\n",
-                               tick_x, text_y, font_family, tick_font_size, anchor, step * i);
+                       if (step >= 1)
+                               snprintf(line, line_len, "<text x=\"%d\" y=\"%d\" font-family=\"%s\" font-size=\"%d\" "
+                                       "fill=\"black\" style=\"text-anchor: %s\">%d</text>\n",
+                                       tick_x, text_y, font_family, tick_font_size, anchor,
+                                       (int)(first + step * i));
+                       else
+                               snprintf(line, line_len, "<text x=\"%d\" y=\"%d\" font-family=\"%s\" font-size=\"%d\" "
+                                       "fill=\"black\" style=\"text-anchor: %s\">%.2f</text>\n",
+                                       tick_x, text_y, font_family, tick_font_size, anchor,
+                                       first + step * i);
                        write(plot->fd, line, strlen(line));
                }
                tick_x += pixels_per_tick;
        }
 
        if (!tick_only) {
-               snprintf(line, line_len, "<text x=\"%d\" y=\"%d\" font-family=\"%s\" font-size=\"%d\" "
-                       "fill=\"black\" style=\"text-anchor: middle\">%d</text>\n",
-                       axis_x_off(graph_width - 2),
-                       text_y, font_family, tick_font_size, last);
+               if (step >= 1)
+                       snprintf(line, line_len, "<text x=\"%d\" y=\"%d\" font-family=\"%s\" font-size=\"%d\" "
+                               "fill=\"black\" style=\"text-anchor: middle\">%d</text>\n",
+                               axis_x_off(graph_width - 2),
+                               text_y, font_family, tick_font_size, last);
+               else
+                       snprintf(line, line_len, "<text x=\"%d\" y=\"%d\" font-family=\"%s\" font-size=\"%d\" "
+                               "fill=\"black\" style=\"text-anchor: middle\">%.2f</text>\n",
+                               axis_x_off(graph_width - 2),
+                               text_y, font_family, tick_font_size, (double)last);
                write(plot->fd, line, strlen(line));
        }
 }
@@ -490,7 +669,7 @@ void set_yticks(struct plot *plot, int num_ticks, int first, int last, char *uni
                         "fill=\"black\" style=\"text-anchor: %s\">%d%s</text>\n",
                        text_x,
                        axis_y_off(tick_y - tick_font_size / 2),
-                       font_family, tick_font_size, anchor, step * i, units);
+                       font_family, tick_font_size, anchor, first + step * i, units);
                write(plot->fd, line, strlen(line));
                tick_y += pixels_per_tick;
        }
@@ -524,8 +703,10 @@ static void close_svg(int fd)
 int close_plot(struct plot *plot)
 {
        close_svg(plot->fd);
-       plot->start_y_offset += plot->total_height;
-       plot->add_xlabel = 0;
+       if (plot->direction == PLOT_DOWN)
+               plot->start_y_offset += plot->total_height;
+       else if (plot->direction == PLOT_ACROSS)
+               plot->start_x_offset += plot->total_width;
        return 0;
 }
 
@@ -541,12 +722,34 @@ struct plot *alloc_plot(void)
        return plot;
 }
 
+int close_plot_file(struct plot *plot)
+{
+       int ret;
+       ret = lseek(plot->fd, 0, SEEK_SET);
+       if (ret == (off_t)-1) {
+               perror("seek");
+               exit(1);
+       }
+       final_width = ((final_width  + 1) / 2) * 2;
+       final_height = ((final_height  + 1) / 2) * 2;
+       snprintf(line, line_len, "<svg  xmlns=\"http://www.w3.org/2000/svg\" "
+                "width=\"%d\" height=\"%d\">\n",
+                final_width, final_height);
+       write(plot->fd, line, strlen(line));
+       snprintf(line, line_len, "<rect x=\"0\" y=\"0\" width=\"%d\" "
+                "height=\"%d\" fill=\"white\"/>\n", final_width, final_height);
+       write(plot->fd, line, strlen(line));
+       close(plot->fd);
+       plot->fd = 0;
+       return 0;
+}
+
 void set_plot_output(struct plot *plot, char *filename)
 {
        int fd;
 
        if (plot->fd)
-               close(plot->fd);
+               close_plot_file(plot);
        fd = open(filename, O_CREAT | O_TRUNC | O_WRONLY, 0600);
        if (fd < 0) {
                fprintf(stderr, "Unable to open output file %s err %s\n", filename, strerror(errno));
@@ -602,35 +805,81 @@ void scale_line_graph_time(u64 *max, char **units)
        *max /= div;
 }
 
-int svg_line_graph(struct plot *plot, struct graph_line_data *gld, char *color)
+int svg_line_graph(struct plot *plot, struct graph_line_data *gld, char *color, int thresh1, int thresh2)
 {
        int i;
        double val;
+       double avg;
        int rolling;
        int fd = plot->fd;
        char *start = "<path d=\"";
        double yscale = ((double)gld->max) / graph_height;
-       double xscale = (double)(gld->seconds - 1) / graph_width;
+       double xscale = (double)(gld->max_seconds - gld->min_seconds - 1) / graph_width;
        char c = 'M';
        double x;
+       int printed_header = 0;
+       int printed_lines = 0;
 
-       if (rolling_avg_secs)
+       if (thresh1 && thresh2)
+               rolling = 0;
+       else if (rolling_avg_secs)
                rolling = rolling_avg_secs;
        else
-               rolling = gld->stop_seconds / 25;
+               rolling = (gld->stop_seconds - gld->min_seconds) / 25;
 
-       write(fd, start, strlen(start));
-       for (i = 0; i < gld->stop_seconds; i++) {
-               val = rolling_avg(gld->data, i, rolling);
-               val = val / yscale;
-               x = (double)i / xscale;
-               snprintf(line, line_len, "%c %d %d ", c, axis_x_off(x), axis_y_off(val));
+       for (i = gld->min_seconds; i < gld->stop_seconds; i++) {
+               avg = rolling_avg(gld->data, i, rolling);
+               if (yscale == 0)
+                       val = 0;
+               else
+                       val = avg / yscale;
+
+               if (val > graph_height)
+                       val = graph_height;
+               if (val < 0)
+                       val = 0;
+
+               x = (double)(i - gld->min_seconds) / xscale;
+               if (!thresh1 && !thresh2) {
+
+                       if (!printed_header) {
+                               write(fd, start, strlen(start));
+                               printed_header = 1;
+                       }
+
+                       /* in full line mode, everything in the graph is connected */
+                       snprintf(line, line_len, "%c %d %d ", c, axis_x_off(x), axis_y_off(val));
+                       c = 'L';
+                       write(fd, line, strlen(line));
+                       printed_lines = 1;
+               } else if (avg > thresh1 || avg > thresh2) {
+                       int len = 10;
+                       if (!printed_header) {
+                               write(fd, start, strlen(start));
+                               printed_header = 1;
+                       }
+
+                       /* otherwise, we just print a bar up there to show this one data point */
+                       if (i >= gld->stop_seconds - 2)
+                               len = -10;
+
+                       /*
+                        * we don't use the rolling averages here to show high
+                        * points in the data
+                        */
+                       snprintf(line, line_len, "M %d %d h %d ", axis_x_off(x),
+                                axis_y_off(val), len);
+                       write(fd, line, strlen(line));
+                       printed_lines = 1;
+               }
 
-               c = 'L';
+       }
+       if (printed_lines) {
+               snprintf(line, line_len, "\" fill=\"none\" stroke=\"%s\" stroke-width=\"2\"/>\n", color);
                write(fd, line, strlen(line));
        }
-       snprintf(line, line_len, "\" fill=\"none\" stroke=\"%s\" stroke-width=\"2\"/>\n", color);
-       write(fd, line, strlen(line));
+       if (plot->timeline)
+               svg_write_time_line(plot, plot->timeline);
 
        return 0;
 }
@@ -644,60 +893,132 @@ void svg_write_time_line(struct plot *plot, int col)
        write(plot->fd, line, strlen(line));
 }
 
-static int svg_add_io(int fd, double row, double col, double width, double height, char *color, float alpha)
+static int svg_add_io(int fd, double row, double col, double width, double height, char *color)
 {
        float rx = 0;
 
        snprintf(line, line_len, "<rect x=\"%.2f\" y=\"%.2f\" width=\"%.1f\" height=\"%.1f\" "
-                "rx=\"%.2f\" style=\"stroke:none;fill:%s;stroke-width:0;opacity:%.2f\"/>\n",
-                axis_x_off_double(col), axis_y_off_double(row), width, height, rx, color, alpha);
+                "rx=\"%.2f\" style=\"stroke:none;fill:%s;stroke-width:0\"/>\n",
+                axis_x_off_double(col), axis_y_off_double(row), width, height, rx, color);
        return write(fd, line, strlen(line));
 }
 
-int svg_io_graph_movie_array(struct plot *plot, struct plot_history *ph, float alpha)
+int svg_io_graph_movie_array(struct plot *plot, struct pid_plot_history *pph)
 {
        double cell_index;
        double movie_row;
        double movie_col;
        int i;
 
-       for (i = 0; i < ph->num_used; i++) {
-               cell_index = ph->history[i];
+       for (i = 0; i < pph->num_used; i++) {
+               cell_index = pph->history[i];
                movie_row = floor(cell_index / graph_width);
                movie_col = cell_index - movie_row * graph_width;
-               svg_add_io(plot->fd, movie_row, movie_col, 4, 4, ph->color, alpha);
+               svg_add_io(plot->fd, movie_row, movie_col, 4, 4, pph->color);
+       }
+       return 0;
+}
+
+static float spindle_steps = 0;
+
+void rewind_spindle_steps(int num)
+{
+       spindle_steps -= num * 0.01;
+}
+
+int svg_io_graph_movie_array_spindle(struct plot *plot, struct pid_plot_history *pph)
+{
+       double cell_index;
+       int i;
+       int num_circles = 0;
+       double cells_per_circle;
+       double circle_num;
+       double degrees_per_cell;
+       double rot;
+       double center_x;
+       double center_y;
+       double graph_width_extra = graph_width + graph_circle_extra;
+       double graph_height_extra = graph_height + graph_circle_extra;
+       double radius;;
+
+       if (graph_width_extra > graph_height_extra)
+               graph_width_extra = graph_height_extra;
+
+       if (graph_width_extra < graph_height_extra)
+               graph_height_extra = graph_width_extra;
+
+       radius = graph_width_extra;
+
+       center_x = axis_x_off_double(graph_width_extra / 2);
+       center_y = axis_y_off_double(graph_height_extra / 2);
+
+       snprintf(line, line_len, "<g transform=\"rotate(%.4f, %.2f, %.2f)\"> "
+                "<circle cx=\"%.2f\" cy=\"%.2f\" "
+                "stroke=\"black\" stroke-width=\"6\" "
+                "r=\"%.2f\" fill=\"none\"/>\n",
+                spindle_steps * 1.2, center_x, center_y, center_x, center_y, graph_width_extra / 2);
+       write(plot->fd, line, strlen(line));
+       snprintf(line, line_len, "<circle cx=\"%.2f\" cy=\"%.2f\" "
+               "stroke=\"none\" fill=\"red\" r=\"%.2f\"/>\n</g>\n",
+               axis_x_off_double(graph_width_extra), center_y, 4.5);
+       write(plot->fd, line, strlen(line));
+       spindle_steps += 0.01;
+
+       radius = floor(radius / 2);
+       num_circles = radius / 4 - 3;
+       cells_per_circle = pph->history_max / num_circles;
+       degrees_per_cell = 360 / cells_per_circle;
+
+       for (i = 0; i < pph->num_used; i++) {
+               cell_index = pph->history[i];
+               circle_num = floor(cell_index / cells_per_circle);
+               rot = cell_index - circle_num * cells_per_circle;
+               circle_num = num_circles - circle_num;
+               radius = circle_num * 4;
+
+               rot = rot * degrees_per_cell;
+               rot -= spindle_steps;
+               snprintf(line, line_len, "<path transform=\"rotate(%.4f, %.2f, %.2f)\" "
+                        "d=\"M %.2f %.2f a %.2f %.2f 0 0 1 0 5\" "
+                        "stroke=\"%s\" stroke-width=\"4\"/>\n",
+                        -rot, center_x, center_y,
+                        axis_x_off_double(graph_width_extra / 2 + radius) + 8, center_y,
+                        radius, radius, pph->color);
+
+               write(plot->fd, line, strlen(line));
        }
        return 0;
 }
 
-static int add_plot_history(struct plot_history *ph, double val)
+static int add_plot_history(struct pid_plot_history *pph, double val)
 {
-       if (ph->num_used == ph->history_len) {
-               ph->history = realloc(ph->history,
-                                     (ph->history_len + 4096) * sizeof(double));
-               if (!ph->history) {
+       if (pph->num_used == pph->history_len) {
+               pph->history_len += 4096;
+               pph->history = realloc(pph->history,
+                                      pph->history_len * sizeof(double));
+               if (!pph->history) {
                        perror("Unable to allocate memory");
                        exit(1);
                }
-               ph->history_len += 4096;
        }
-       ph->history[ph->num_used++] = val;
+       pph->history[pph->num_used++] = val;
        return 0;
 }
 
-int svg_io_graph_movie(struct graph_dot_data *gdd, struct plot_history *ph, int col)
+int svg_io_graph_movie(struct graph_dot_data *gdd, struct pid_plot_history *pph, int col)
 {
        int row = 0;
        int arr_index;
        unsigned char val;
        int bit_index;
        int bit_mod;
-       double blocks_per_row = gdd->max_offset / gdd->rows;
-       double movie_blocks_per_cell = gdd->max_offset / (graph_width * graph_height);
+       double blocks_per_row = (gdd->max_offset - gdd->min_offset + 1) / gdd->rows;
+       double movie_blocks_per_cell = (gdd->max_offset - gdd->min_offset + 1) / (graph_width * graph_height);
        double cell_index;
        int margin_orig = graph_inner_y_margin;
 
        graph_inner_y_margin += 5;
+       pph->history_max = (gdd->max_offset - gdd->min_offset + 1) / movie_blocks_per_cell;
 
        for (row = gdd->rows - 1; row >= 0; row--) {
                bit_index = row * gdd->cols + col;
@@ -714,14 +1035,14 @@ int svg_io_graph_movie(struct graph_dot_data *gdd, struct plot_history *ph, int
                        /* a cell number in the graph */
                        cell_index /= movie_blocks_per_cell;
 
-                       add_plot_history(ph, cell_index);
+                       add_plot_history(pph, cell_index);
                }
        }
        graph_inner_y_margin = margin_orig;
        return 0;
 }
 
-int svg_io_graph(struct plot *plot, struct graph_dot_data *gdd, char *color)
+int svg_io_graph(struct plot *plot, struct graph_dot_data *gdd)
 {
        int fd = plot->fd;;
        int col = 0;
@@ -741,7 +1062,7 @@ int svg_io_graph(struct plot *plot, struct graph_dot_data *gdd, char *color)
                                continue;
                        val = gdd->data[arr_index];
                        if (val & (1 << bit_mod))
-                               svg_add_io(fd, floor(row / io_graph_scale), col, 1.5, 1.5, color, 1.0);
+                               svg_add_io(fd, floor(row / io_graph_scale), col, 1.5, 1.5, gdd->color);
                }
        }
        return 0;