[PATCH] fio: add 'directory' and 'numjobs' options
[disktools.git] / fio.c
diff --git a/fio.c b/fio.c
index b46c01c625fb745753dc67ad24b97d041ce6ca3a..5b01012091d54d8f8a807bbb85eb6b575ba69221 100644 (file)
--- a/fio.c
+++ b/fio.c
 #include <semaphore.h>
 #include <sys/ipc.h>
 #include <sys/shm.h>
+#include <sys/ioctl.h>
 #include <asm/unistd.h>
 #include <asm/types.h>
 #include <asm/bitops.h>
 
+#include "arch.h"
 #include "list.h"
 #include "md5.h"
 
-#define MAX_JOBS       (1024)
-
-/*
- * assume we don't have _get either, if _set isn't defined
- */
-#ifndef __NR_ioprio_set
-#if defined(__i386__)
-#define __NR_ioprio_set                289
-#define __NR_ioprio_get                290
-#elif defined(__powerpc__) || defined(__powerpc64__)
-#define __NR_ioprio_set                273
-#define __NR_ioprio_get                274
-#elif defined(__x86_64__)
-#define __NR_ioprio_set                251
-#define __NR_ioprio_get                252
-#elif defined(__ia64__)
-#define __NR_ioprio_set                1274
-#define __NR_ioprio_get                1275
-#elif defined(__alpha__)
-#define __NR_ioprio_set                442
-#define __NR_ioprio_get                443
-#elif defined(__s390x__) || defined(__s390__)
-#define __NR_ioprio_set                282
-#define __NR_ioprio_get                283
-#else
-#error "Unsupported arch"
-#endif
+#ifndef BLKGETSIZE64
+#define BLKGETSIZE64   _IOR(0x12,114,size_t)
 #endif
 
-#ifndef __NR_fadvise64
-#if defined(__i386__)
-#define __NR_fadvise64         250
-#elif defined(__powerpc__) || defined(__powerpc64__)
-#define __NR_fadvise64         233
-#elif defined(__x86_64__)
-#define __NR_fadvise64         221
-#elif defined(__ia64__)
-#define __NR_fadvise64         1234
-#elif defined(__alpha__)
-#define __NR_fadvise64         413
-#elif defined(__s390x__) || defined(__s390__)
-#define __NR_fadvise64         253
-#else
-#error "Unsupported arch"
-#endif
-#endif
+#define MAX_JOBS       (1024)
 
 static int ioprio_set(int which, int who, int ioprio)
 {
@@ -121,7 +82,7 @@ enum {
 #define MASK   (4095)
 
 #define DEF_BS         (4096)
-#define DEF_TIMEOUT    (30)
+#define DEF_TIMEOUT    (0)
 #define DEF_RATE_CYCLE (1000)
 #define DEF_ODIRECT    (1)
 #define DEF_SEQUENTIAL (1)
@@ -136,6 +97,8 @@ enum {
 #define DEF_CREATE_FSYNC       (1)
 #define DEF_LOOPS      (1)
 #define DEF_VERIFY     (0)
+#define DEF_STONEWALL  (0)
+#define DEF_NUMJOBS    (1)
 
 #define ALIGN(buf)     (char *) (((unsigned long) (buf) + MASK) & ~(MASK))
 
@@ -225,14 +188,17 @@ struct verify_header {
 };
 
 #define td_read(td)            ((td)->ddir == DDIR_READ)
-#define should_fsync(td)       (!td_read(td) && !(td)->odirect)
+#define td_write(td)           ((td)->ddir == DDIR_WRITE)
+#define should_fsync(td)       (td_write(td) && !(td)->odirect)
 
 #define BLOCKS_PER_MAP         (8 * sizeof(long))
-#define RAND_MAP_IDX(sector)   ((sector) / BLOCKS_PER_MAP)
-#define RAND_MAP_BIT(sector)   ((sector) & (BLOCKS_PER_MAP - 1))
+#define TO_MAP_BLOCK(td, b)    ((b) - ((td)->file_offset / (td)->min_bs))
+#define RAND_MAP_IDX(td, b)    (TO_MAP_BLOCK(td, b) / BLOCKS_PER_MAP)
+#define RAND_MAP_BIT(td, b)    (TO_MAP_BLOCK(td, b) & (BLOCKS_PER_MAP - 1))
 
 struct thread_data {
        char file_name[256];
+       char directory[256];
        int thread_number;
        int error;
        int fd;
@@ -265,6 +231,8 @@ struct thread_data {
        unsigned int sync_io;
        unsigned int mem_type;
        unsigned int verify;
+       unsigned int stonewall;
+       unsigned int numjobs;
        cpu_set_t cpumask;
 
        struct drand48_data bsrange_state;
@@ -317,6 +285,8 @@ struct thread_data {
        struct io_log *bw_log;
 
        struct timeval start;
+       struct rusage ru_start;
+       struct rusage ru_end;
 
        struct list_head io_hist_list;
 };
@@ -392,6 +362,14 @@ static unsigned long utime_since(struct timeval *s, struct timeval *e)
        return sec + usec;
 }
 
+static unsigned long utime_since_now(struct timeval *s)
+{
+       struct timeval t;
+
+       gettimeofday(&t, NULL);
+       return utime_since(s, &t);
+}
+
 static unsigned long mtime_since(struct timeval *s, struct timeval *e)
 {
        double sec, usec;
@@ -424,8 +402,8 @@ static inline unsigned long msec_now(struct timeval *s)
 
 static int random_map_free(struct thread_data *td, unsigned long long block)
 {
-       unsigned int idx = RAND_MAP_IDX(block);
-       unsigned int bit = RAND_MAP_BIT(block);
+       unsigned int idx = RAND_MAP_IDX(td, block);
+       unsigned int bit = RAND_MAP_BIT(td, block);
 
        return (td->file_map[idx] & (1UL << bit)) == 0;
 }
@@ -460,8 +438,8 @@ static void mark_random_map(struct thread_data *td, struct io_u *io_u)
                if (!random_map_free(td, block))
                        break;
 
-               idx = RAND_MAP_IDX(block);
-               bit = RAND_MAP_BIT(block);
+               idx = RAND_MAP_IDX(td, block);
+               bit = RAND_MAP_BIT(td, block);
 
                assert(idx < td->num_maps);
 
@@ -476,7 +454,7 @@ static void mark_random_map(struct thread_data *td, struct io_u *io_u)
 
 static int get_next_offset(struct thread_data *td, unsigned long long *offset)
 {
-       unsigned long long b;
+       unsigned long long b, rb;
        long r;
 
        if (!td->sequential) {
@@ -486,8 +464,9 @@ static int get_next_offset(struct thread_data *td, unsigned long long *offset)
                do {
                        lrand48_r(&td->random_state, &r);
                        b = ((max_blocks - 1) * r / (RAND_MAX+1.0));
+                       rb = b + (td->file_offset / td->min_bs);
                        loops--;
-               } while (!random_map_free(td, b) && loops);
+               } while (!random_map_free(td, rb) && loops);
 
                if (!loops) {
                        if (get_next_free_block(td, &b))
@@ -497,6 +476,9 @@ static int get_next_offset(struct thread_data *td, unsigned long long *offset)
                b = td->last_bytes / td->min_bs;
 
        *offset = (b * td->min_bs) + td->file_offset;
+       if (*offset > td->file_size)
+               return 1;
+
        return 0;
 }
 
@@ -578,18 +560,35 @@ static void add_bw_sample(struct thread_data *td)
        td->stat_io_bytes = td->this_io_bytes;
 }
 
+/*
+ * busy looping version for the last few usec
+ */
+static void __usec_sleep(int usec)
+{
+       struct timeval start;
+
+       gettimeofday(&start, NULL);
+       while (utime_since_now(&start) < usec)
+                __asm__ __volatile__("rep;nop": : :"memory");
+}
+
 static void usec_sleep(int usec)
 {
        struct timespec req = { .tv_sec = 0, .tv_nsec = usec * 1000 };
        struct timespec rem;
 
        do {
+               if (usec < 5000) {
+                       __usec_sleep(usec);
+                       break;
+               }
                rem.tv_sec = rem.tv_nsec = 0;
                nanosleep(&req, &rem);
                if (!rem.tv_nsec)
                        break;
 
                req.tv_nsec = rem.tv_nsec;
+               usec = rem.tv_nsec * 1000;
        } while (1);
 }
 
@@ -653,6 +652,8 @@ static int check_min_rate(struct thread_data *td, struct timeval *now)
 
 static inline int runtime_exceeded(struct thread_data *td, struct timeval *t)
 {
+       if (!td->timeout)
+               return 0;
        if (mtime_since(&td->start, t) >= td->timeout * 1000)
                return 1;
 
@@ -768,8 +769,10 @@ static struct io_u *get_io_u(struct thread_data *td)
        if (!io_u)
                return NULL;
 
-       if (get_next_offset(td, &io_u->offset))
+       if (get_next_offset(td, &io_u->offset)) {
+               put_io_u(td, io_u);
                return NULL;
+       }
 
        io_u->buflen = get_next_buflen(td);
        if (!io_u->buflen) {
@@ -777,8 +780,8 @@ static struct io_u *get_io_u(struct thread_data *td)
                return NULL;
        }
 
-       if (io_u->buflen + io_u->offset > td->io_size)
-               io_u->buflen = td->io_size - io_u->offset;
+       if (io_u->buflen + io_u->offset > td->file_size)
+               io_u->buflen = td->file_size - io_u->offset;
 
        if (!td->sequential)
                mark_random_map(td, io_u);
@@ -961,7 +964,7 @@ static void do_sync_io(struct thread_data *td)
                        break;
                }
 
-               if (!td_read(td))
+               if (td_write(td))
                        log_io_piece(td, io_u);
 
                td->io_blocks++;
@@ -1005,6 +1008,20 @@ static void do_sync_io(struct thread_data *td)
                fsync(td->fd);
 }
 
+static int io_u_getevents(struct thread_data *td, int min, int max,
+                         struct timespec *t)
+{
+       int r;
+
+       do {
+               r = io_getevents(td->aio_ctx, min, max, td->aio_events, t);
+               if (r != -EAGAIN && r != -EINTR)
+                       break;
+       } while (1);
+
+       return r;
+}
+
 static int io_u_queue(struct thread_data *td, struct io_u *io_u)
 {
        struct iocb *iocb = &io_u->iocb;
@@ -1014,9 +1031,9 @@ static int io_u_queue(struct thread_data *td, struct io_u *io_u)
                ret = io_submit(td->aio_ctx, 1, &iocb);
                if (ret == 1)
                        return 0;
-               else if (ret == EAGAIN)
+               else if (ret == -EAGAIN)
                        usleep(100);
-               else if (ret == EINTR)
+               else if (ret == -EINTR)
                        continue;
                else
                        break;
@@ -1049,7 +1066,7 @@ static int ios_completed(struct thread_data *td, int nr)
                add_clat_sample(td, msec);
                add_bw_sample(td);
 
-               if (!td_read(td))
+               if (td_write(td))
                        log_io_piece(td, io_u);
 
                bytes_done += io_u->buflen;
@@ -1069,7 +1086,7 @@ static void cleanup_pending_aio(struct thread_data *td)
        /*
         * get immediately available events, if any
         */
-       r = io_getevents(td->aio_ctx, 0, td->cur_depth, td->aio_events, &ts);
+       r = io_u_getevents(td, 0, td->cur_depth, &ts);
        if (r > 0)
                ios_completed(td, r);
 
@@ -1085,7 +1102,7 @@ static void cleanup_pending_aio(struct thread_data *td)
        }
 
        if (td->cur_depth) {
-               r = io_getevents(td->aio_ctx, td->cur_depth, td->cur_depth, td->aio_events, NULL);
+               r = io_u_getevents(td, td->cur_depth, td->cur_depth, NULL);
                if (r > 0)
                        ios_completed(td, r);
        }
@@ -1145,7 +1162,7 @@ static void do_async_verify(struct thread_data *td)
                if (async_do_verify(td, &v_io_u))
                        break;
 
-               ret = io_getevents(td->aio_ctx, 1, 1, td->aio_events, NULL);
+               ret = io_u_getevents(td, 1, 1, NULL);
                if (ret != 1) {
                        if (ret < 0)
                                td->error = ret;
@@ -1210,9 +1227,9 @@ static void do_async_io(struct thread_data *td)
                        min_evts = 1;
                }
 
-               ret = io_getevents(td->aio_ctx, min_evts, td->cur_depth, td->aio_events, timeout);
+               ret = io_u_getevents(td, min_evts, td->cur_depth, timeout);
                if (ret < 0) {
-                       td->error = errno;
+                       td->error = ret;
                        break;
                } else if (!ret)
                        continue;
@@ -1382,7 +1399,7 @@ static int create_file(struct thread_data *td)
        /*
         * unless specifically asked for overwrite, let normal io extend it
         */
-       if (!td_read(td) && !td->overwrite)
+       if (td_write(td) && !td->overwrite)
                return 0;
 
        if (!td->file_size) {
@@ -1399,6 +1416,11 @@ static int create_file(struct thread_data *td)
                return 1;
        }
 
+       if (ftruncate(td->fd, td->file_size) == -1) {
+               td->error = errno;
+               return 1;
+       }
+
        td->io_size = td->file_size;
        b = malloc(td->max_bs);
        memset(b, 0, td->max_bs);
@@ -1443,9 +1465,58 @@ static int file_exists(struct thread_data *td)
        return errno != ENOENT;
 }
 
-static int setup_file(struct thread_data *td)
+static int get_file_size(struct thread_data *td)
 {
+       size_t bytes = 0;
        struct stat st;
+
+       if (fstat(td->fd, &st) == -1) {
+               td->error = errno;
+               return 1;
+       }
+
+       /*
+        * if block device, get size via BLKGETSIZE64 ioctl. try that as well
+        * if this is a link, fall back to st.st_size if it fails
+        */
+       if (S_ISBLK(st.st_mode) || S_ISLNK(st.st_mode)) {
+               if (ioctl(td->fd, BLKGETSIZE64, &bytes)) {
+                       if (S_ISBLK(st.st_mode)) {
+                               td->error = errno;
+                               return 1;
+                       } else
+                               bytes = st.st_size;
+               }
+       } else
+               bytes = st.st_size;
+
+       if (td_read(td)) {
+               if (td->file_size > bytes)
+                       bytes = td->file_size;
+       } else {
+               if (!td->file_size)
+                       td->file_size = 1024 * 1024 * 1024;
+
+               bytes = td->file_size;
+       }
+
+       if (td->file_offset > bytes) {
+               fprintf(stderr, "Client%d: offset larger than length\n", td->thread_number);
+               return 1;
+       }
+
+       td->io_size = bytes - td->file_offset;
+       if (td->io_size == 0) {
+               fprintf(stderr, "Client%d: no io blocks\n", td->thread_number);
+               td->error = EINVAL;
+               return 1;
+       }
+
+       return 0;
+}
+
+static int setup_file(struct thread_data *td)
+{
        int flags = 0;
 
        if (!file_exists(td)) {
@@ -1480,35 +1551,16 @@ static int setup_file(struct thread_data *td)
                return 1;
        }
 
-       if (td_read(td)) {
-               if (fstat(td->fd, &st) == -1) {
-                       td->error = errno;
-                       return 1;
-               }
-
-               if (td->file_size > st.st_size)
-                       st.st_size = td->file_size;
-       } else {
-               if (!td->file_size)
-                       td->file_size = 1024 * 1024 * 1024;
-
-               st.st_size = td->file_size;
-       }
-
-       if (td->file_offset > st.st_size) {
-               fprintf(stderr, "Client%d: offset larger than length\n", td->thread_number);
+       if (get_file_size(td))
                return 1;
-       }
 
-       td->io_size = st.st_size - td->file_offset;
-       if (td->io_size == 0) {
-               fprintf(stderr, "Client%d: no io blocks\n", td->thread_number);
-               td->error = EINVAL;
+       if (td_write(td) && ftruncate(td->fd, td->file_size) == -1) {
+               td->error = errno;
                return 1;
        }
 
        if (td->invalidate_cache) {
-               if (fadvise(td->fd, 0, st.st_size, POSIX_FADV_DONTNEED) < 0) {
+               if (fadvise(td->fd, td->file_offset, td->file_size, POSIX_FADV_DONTNEED) < 0) {
                        td->error = errno;
                        return 1;
                }
@@ -1579,6 +1631,8 @@ static void *thread_main(int shm_id, int offset, char *argv[])
 
        gettimeofday(&td->start, NULL);
 
+       getrusage(RUSAGE_SELF, &td->ru_start);
+
        while (td->loops--) {
                gettimeofday(&td->stat_sample_time, NULL);
 
@@ -1611,6 +1665,7 @@ static void *thread_main(int shm_id, int offset, char *argv[])
        }
 
        td->runtime = mtime_since_now(&td->start);
+       getrusage(RUSAGE_SELF, &td->ru_end);
        ret = 0;
 
        if (td->bw_log)
@@ -1669,8 +1724,8 @@ static int calc_lat(struct io_stat *is, unsigned long *min, unsigned long *max,
 static void show_thread_status(struct thread_data *td)
 {
        int prio, prio_class;
-       unsigned long min, max, bw = 0;
-       double mean, dev;
+       unsigned long min, max, bw = 0, ctx;
+       double mean, dev, usr_cpu, sys_cpu;
 
        if (!td->io_bytes && !td->error)
                return;
@@ -1689,6 +1744,23 @@ static void show_thread_status(struct thread_data *td)
                printf("  clat (msec): min=%5lu, max=%5lu, avg=%5.02f, dev=%5.02f\n", min, max, mean, dev);
        if (calc_lat(&td->bw_stat, &min, &max, &mean, &dev))
                printf("  bw (KiB/s) : min=%5lu, max=%5lu, avg=%5.02f, dev=%5.02f\n", min, max, mean, dev);
+
+       if (td->runtime) {
+               unsigned long t;
+
+               t = mtime_since(&td->ru_start.ru_utime, &td->ru_end.ru_utime);
+               usr_cpu = (double) t * 100 / (double) td->runtime;
+
+               t = mtime_since(&td->ru_start.ru_stime, &td->ru_end.ru_stime);
+               sys_cpu = (double) t * 100 / (double) td->runtime;
+       } else {
+               usr_cpu = 0;
+               sys_cpu = 0;
+       }
+
+       ctx = td->ru_end.ru_nvcsw + td->ru_end.ru_nivcsw - (td->ru_start.ru_nvcsw + td->ru_start.ru_nivcsw);
+
+       printf("  cpu        : usr=%3.2f%%, sys=%3.2f%%, ctx=%lu\n", usr_cpu, sys_cpu, ctx);
 }
 
 static int setup_rate(struct thread_data *td)
@@ -1709,7 +1781,7 @@ static int setup_rate(struct thread_data *td)
        return 0;
 }
 
-static struct thread_data *get_new_job(int global)
+static struct thread_data *get_new_job(int global, struct thread_data *parent)
 {
        struct thread_data *td;
 
@@ -1721,38 +1793,42 @@ static struct thread_data *get_new_job(int global)
        td = &threads[thread_number++];
        memset(td, 0, sizeof(*td));
 
+       sprintf(td->directory, ".");
+
        td->fd = -1;
        td->thread_number = thread_number;
 
-       td->ddir = def_thread.ddir;
-       td->ioprio = def_thread.ioprio;
-       td->sequential = def_thread.sequential;
-       td->bs = def_thread.bs;
-       td->min_bs = def_thread.min_bs;
-       td->max_bs = def_thread.max_bs;
-       td->odirect = def_thread.odirect;
-       td->thinktime = def_thread.thinktime;
-       td->fsync_blocks = def_thread.fsync_blocks;
-       td->start_delay = def_thread.start_delay;
-       td->timeout = def_thread.timeout;
-       td->use_aio = def_thread.use_aio;
-       td->create_file = def_thread.create_file;
-       td->overwrite = def_thread.overwrite;
-       td->invalidate_cache = def_thread.invalidate_cache;
-       td->file_size = def_thread.file_size;
-       td->file_offset = def_thread.file_offset;
-       td->rate = def_thread.rate;
-       td->ratemin = def_thread.ratemin;
-       td->ratecycle = def_thread.ratecycle;
-       td->aio_depth = def_thread.aio_depth;
-       td->sync_io = def_thread.sync_io;
-       td->mem_type = def_thread.mem_type;
-       td->bw_avg_time = def_thread.bw_avg_time;
-       td->create_serialize = def_thread.create_serialize;
-       td->create_fsync = def_thread.create_fsync;
-       td->loops = def_thread.loops;
-       td->verify = def_thread.verify;
-       memcpy(&td->cpumask, &def_thread.cpumask, sizeof(td->cpumask));
+       td->ddir = parent->ddir;
+       td->ioprio = parent->ioprio;
+       td->sequential = parent->sequential;
+       td->bs = parent->bs;
+       td->min_bs = parent->min_bs;
+       td->max_bs = parent->max_bs;
+       td->odirect = parent->odirect;
+       td->thinktime = parent->thinktime;
+       td->fsync_blocks = parent->fsync_blocks;
+       td->start_delay = parent->start_delay;
+       td->timeout = parent->timeout;
+       td->use_aio = parent->use_aio;
+       td->create_file = parent->create_file;
+       td->overwrite = parent->overwrite;
+       td->invalidate_cache = parent->invalidate_cache;
+       td->file_size = parent->file_size;
+       td->file_offset = parent->file_offset;
+       td->rate = parent->rate;
+       td->ratemin = parent->ratemin;
+       td->ratecycle = parent->ratecycle;
+       td->aio_depth = parent->aio_depth;
+       td->sync_io = parent->sync_io;
+       td->mem_type = parent->mem_type;
+       td->bw_avg_time = parent->bw_avg_time;
+       td->create_serialize = parent->create_serialize;
+       td->create_fsync = parent->create_fsync;
+       td->loops = parent->loops;
+       td->verify = parent->verify;
+       td->stonewall = parent->stonewall;
+       td->numjobs = parent->numjobs;
+       memcpy(&td->cpumask, &parent->cpumask, sizeof(td->cpumask));
 
        return td;
 }
@@ -1763,13 +1839,15 @@ static void put_job(struct thread_data *td)
        thread_number--;
 }
 
-static int add_job(struct thread_data *td, const char *filename, int prioclass,
+static int add_job(struct thread_data *td, const char *jobname, int prioclass,
                   int prio)
 {
+       int numjobs;
+
        if (td == &def_thread)
                return 0;
 
-       strcpy(td->file_name, filename);
+       sprintf(td->file_name, "%s/%s.%d", td->directory, jobname, td->thread_number);
        sem_init(&td->mutex, 1, 0);
        td->ioprio = (prioclass << IOPRIO_CLASS_SHIFT) | prio;
 
@@ -1790,15 +1868,36 @@ static int add_job(struct thread_data *td, const char *filename, int prioclass,
                td->verify = 0;
 
        if (setup_rate(td))
-               return -1;
+               goto err;
 
        if (write_lat_log)
                setup_log(&td->lat_log);
        if (write_bw_log)
                setup_log(&td->bw_log);
 
-       printf("Client%d: file=%s, rw=%d, prio=%d/%d, seq=%d, odir=%d, bs=%d-%d, rate=%d, aio=%d, aio_depth=%d\n", td->thread_number, filename, td->ddir, prioclass, prio, td->sequential, td->odirect, td->min_bs, td->max_bs, td->rate, td->use_aio, td->aio_depth);
+       printf("Client%d: rw=%d, prio=%d/%d, seq=%d, odir=%d, bs=%d-%d, rate=%d, aio=%d, aio_depth=%d\n", td->thread_number, td->ddir, prioclass, prio, td->sequential, td->odirect, td->min_bs, td->max_bs, td->rate, td->use_aio, td->aio_depth);
+
+       /*
+        * recurse add identical jobs, clear numjobs and stonewall options
+        * as they don't apply to sub-jobs
+        */
+       numjobs = td->numjobs;
+       while (--numjobs) {
+               struct thread_data *td_new = get_new_job(0, td);
+
+               if (!td_new)
+                       break;
+
+               td_new->numjobs = 1;
+               td_new->stonewall = 0;
+
+               if (add_job(td_new, jobname, prioclass, prio))
+                       break;
+       }
        return 0;
+err:
+       put_job(td);
+       return -1;
 }
 
 static void fill_cpu_mask(cpu_set_t cpumask, int cpu)
@@ -1875,6 +1974,25 @@ static int check_str(char *p, char *name, char *option)
        return 1;
 }
 
+static int check_strstore(char *p, char *name, char *dest)
+{
+       char *s = strstr(p, name);
+
+       if (!s)
+               return 1;
+
+       s = strstr(p, "=");
+       if (!s)
+               return 1;
+
+       s++;
+       while (isblank(*s))
+               s++;
+
+       strcpy(dest, s);
+       return 0;
+}
+
 static int check_range(char *p, char *name, unsigned long *s, unsigned long *e)
 {
        char str[128];
@@ -1965,7 +2083,7 @@ static int parse_jobs_ini(char *file)
 
                name[strlen(name) - 1] = '\0';
 
-               td = get_new_job(global);
+               td = get_new_job(global, &def_thread);
                if (!td)
                        break;
 
@@ -2059,6 +2177,10 @@ static int parse_jobs_ini(char *file)
                                fgetpos(f, &off);
                                continue;
                        }
+                       if (!check_int(p, "numjobs", &td->numjobs)) {
+                               fgetpos(f, &off);
+                               continue;
+                       }
                        if (!check_range(p, "bsrange", &ul1, &ul2)) {
                                if (ul1 & 511)
                                        printf("bad min block size, must be a multiple of 512\n");
@@ -2087,6 +2209,11 @@ static int parse_jobs_ini(char *file)
                                fgetpos(f, &off);
                                continue;
                        }
+                       if (!check_strstore(p, "directory", td->directory)) {
+                               printf("got dir %s\n", td->directory);
+                               fgetpos(f, &off);
+                               continue;
+                       }
                        if (!check_str(p, "mem", "malloc")) {
                                td->mem_type = MEM_MALLOC;
                                fgetpos(f, &off);
@@ -2127,12 +2254,17 @@ static int parse_jobs_ini(char *file)
                                fgetpos(f, &off);
                                continue;
                        }
+                       if (!strncmp(p, "stonewall", 9)) {
+                               td->stonewall = 1;
+                               fgetpos(f, &off);
+                               continue;
+                       }
                        printf("Client%d: bad option %s\n",td->thread_number,p);
                }
                fsetpos(f, &off);
 
                if (add_job(td, name, prioclass, prio))
-                       put_job(td);
+                       break;
        }
 
        free(string);
@@ -2230,7 +2362,17 @@ static void check_str_update(struct thread_data *td, int n, int t, int m)
                        c = 'E';
                        break;
                case TD_RUNNING:
-                       c = '+';
+                       if (td_read(td)) {
+                               if (td->sequential)
+                                       c = 'R';
+                               else
+                                       c = 'r';
+                       } else {
+                               if (td->sequential)
+                                       c = 'W';
+                               else
+                                       c = 'w';
+                       }
                        break;
                case TD_VERIFYING:
                        c = 'V';
@@ -2282,7 +2424,7 @@ static void run_threads(char *argv[])
        struct timeval genesis;
        struct thread_data *td;
        unsigned long spent;
-       int i, todo, nr_running, m_rate, t_rate;
+       int i, todo, nr_running, m_rate, t_rate, nr_started;
 
        printf("Starting %d threads\n", thread_number);
        fflush(stdout);
@@ -2291,6 +2433,7 @@ static void run_threads(char *argv[])
 
        todo = thread_number;
        nr_running = 0;
+       nr_started = 0;
        m_rate = t_rate = 0;
 
        for (i = 0; i < thread_number; i++) {
@@ -2338,10 +2481,14 @@ static void run_threads(char *argv[])
                                        continue;
                        }
 
+                       if (td->stonewall && (nr_started || nr_running))
+                               break;
+
                        td_set_runstate(td, TD_CREATED);
                        check_str_update(td, nr_running, t_rate, m_rate);
                        sem_init(&startup_sem, 1, 1);
                        todo--;
+                       nr_started++;
 
                        if (fork())
                                sem_wait(&startup_sem);
@@ -2362,6 +2509,7 @@ static void run_threads(char *argv[])
 
                        td_set_runstate(td, TD_RUNNING);
                        nr_running++;
+                       nr_started--;
                        m_rate += td->ratemin;
                        t_rate += td->rate;
                        check_str_update(td, nr_running, t_rate, m_rate);
@@ -2371,11 +2519,8 @@ static void run_threads(char *argv[])
                for (i = 0; i < thread_number; i++) {
                        struct thread_data *td = &threads[i];
 
-                       if (td->runstate == TD_RUNNING)
-                               run_str[td->thread_number - 1] = '+';
-                       else if (td->runstate == TD_VERIFYING)
-                               run_str[td->thread_number - 1] = 'V';
-                       else
+                       if (td->runstate != TD_RUNNING &&
+                           td->runstate != TD_VERIFYING)
                                continue;
 
                        check_str_update(td, nr_running, t_rate, m_rate);
@@ -2462,6 +2607,8 @@ int main(int argc, char *argv[])
        def_thread.create_fsync = DEF_CREATE_FSYNC;
        def_thread.loops = DEF_LOOPS;
        def_thread.verify = DEF_VERIFY;
+       def_thread.stonewall = DEF_STONEWALL;
+       def_thread.numjobs = DEF_NUMJOBS;
 
        i = parse_options(argc, argv);