usb: gadget: udc: mv_udc_core: remove usage of list iterator past the loop body

[linux-block.git] / drivers / usb / gadget / udc / mv_udc_core.c

diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c
index b6d34dda028b6d7c7750f41b687075072bca1462..fdb17d86cd65603eaeade50a636d0e78a91980dd 100644 (file)
--- a/drivers/usb/gadget/udc/mv_udc_core.c
+++ b/drivers/usb/gadget/udc/mv_udc_core.c
@@ -771,7 +771,7 @@ static void mv_prime_ep(struct mv_ep *ep, struct mv_req *req)
 static int mv_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
 {
        struct mv_ep *ep = container_of(_ep, struct mv_ep, ep);
-       struct mv_req *req;
+       struct mv_req *req = NULL, *iter;
        struct mv_udc *udc = ep->udc;
        unsigned long flags;
        int stopped, ret = 0;
@@ -793,11 +793,13 @@ static int mv_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
        writel(epctrlx, &udc->op_regs->epctrlx[ep->ep_num]);
 
        /* make sure it's actually queued on this endpoint */
-       list_for_each_entry(req, &ep->queue, queue) {
-               if (&req->req == _req)
-                       break;
+       list_for_each_entry(iter, &ep->queue, queue) {
+               if (&iter->req != _req)
+                       continue;
+               req = iter;
+               break;
        }
-       if (&req->req != _req) {
+       if (!req) {
                ret = -EINVAL;
                goto out;
        }