target: move node ACL allocation to core code
[linux-2.6-block.git] / drivers / target / tcm_fc / tfc_conf.c
index efdcb9663a1a699520d3543b544ebac5c34ad860..8da159352315f1f455aadbc53c1c394ff6d66871 100644 (file)
@@ -48,7 +48,7 @@
 
 #include "tcm_fc.h"
 
-struct target_fabric_configfs *ft_configfs;
+static const struct target_core_fabric_ops ft_fabric_ops;
 
 static LIST_HEAD(ft_wwn_list);
 DEFINE_MUTEX(ft_lport_lock);
@@ -198,48 +198,17 @@ static struct configfs_attribute *ft_nacl_base_attrs[] = {
  * Add ACL for an initiator.  The ACL is named arbitrarily.
  * The port_name and/or node_name are attributes.
  */
-static struct se_node_acl *ft_add_acl(
-       struct se_portal_group *se_tpg,
-       struct config_group *group,
-       const char *name)
+static int ft_init_nodeacl(struct se_node_acl *nacl, const char *name)
 {
-       struct ft_node_acl *acl;
-       struct ft_tpg *tpg;
+       struct ft_node_acl *acl =
+               container_of(nacl, struct ft_node_acl, se_node_acl);
        u64 wwpn;
-       u32 q_depth;
-
-       pr_debug("add acl %s\n", name);
-       tpg = container_of(se_tpg, struct ft_tpg, se_tpg);
 
        if (ft_parse_wwn(name, &wwpn, 1) < 0)
-               return ERR_PTR(-EINVAL);
+               return -EINVAL;
 
-       acl = kzalloc(sizeof(struct ft_node_acl), GFP_KERNEL);
-       if (!acl)
-               return ERR_PTR(-ENOMEM);
        acl->node_auth.port_name = wwpn;
-
-       q_depth = 32;           /* XXX bogus default - get from tpg? */
-       return core_tpg_add_initiator_node_acl(&tpg->se_tpg,
-                               &acl->se_node_acl, name, q_depth);
-}
-
-static void ft_del_acl(struct se_node_acl *se_acl)
-{
-       struct se_portal_group *se_tpg = se_acl->se_tpg;
-       struct ft_tpg *tpg;
-       struct ft_node_acl *acl = container_of(se_acl,
-                               struct ft_node_acl, se_node_acl);
-
-       pr_debug("del acl %s\n",
-               config_item_name(&se_acl->acl_group.cg_item));
-
-       tpg = container_of(se_tpg, struct ft_tpg, se_tpg);
-       pr_debug("del acl %p se_acl %p tpg %p se_tpg %p\n",
-                   acl, se_acl, tpg, &tpg->se_tpg);
-
-       core_tpg_del_initiator_node_acl(&tpg->se_tpg, se_acl, 1);
-       kfree(acl);
+       return 0;
 }
 
 struct ft_node_acl *ft_acl_get(struct ft_tpg *tpg, struct fc_rport_priv *rdata)
@@ -267,29 +236,6 @@ struct ft_node_acl *ft_acl_get(struct ft_tpg *tpg, struct fc_rport_priv *rdata)
        return found;
 }
 
-static struct se_node_acl *ft_tpg_alloc_fabric_acl(struct se_portal_group *se_tpg)
-{
-       struct ft_node_acl *acl;
-
-       acl = kzalloc(sizeof(*acl), GFP_KERNEL);
-       if (!acl) {
-               pr_err("Unable to allocate struct ft_node_acl\n");
-               return NULL;
-       }
-       pr_debug("acl %p\n", acl);
-       return &acl->se_node_acl;
-}
-
-static void ft_tpg_release_fabric_acl(struct se_portal_group *se_tpg,
-                                     struct se_node_acl *se_acl)
-{
-       struct ft_node_acl *acl = container_of(se_acl,
-                               struct ft_node_acl, se_node_acl);
-
-       pr_debug("acl %p\n", acl);
-       kfree(acl);
-}
-
 /*
  * local_port port_group (tpg) ops.
  */
@@ -337,7 +283,7 @@ static struct se_portal_group *ft_add_tpg(
                return NULL;
        }
 
-       ret = core_tpg_register(&ft_configfs->tf_ops, wwn, &tpg->se_tpg,
+       ret = core_tpg_register(&ft_fabric_ops, wwn, &tpg->se_tpg,
                                tpg, TRANSPORT_TPG_TYPE_NORMAL);
        if (ret < 0) {
                destroy_workqueue(wq);
@@ -486,11 +432,6 @@ static u16 ft_get_tag(struct se_portal_group *se_tpg)
        return tpg->index;
 }
 
-static u32 ft_get_default_depth(struct se_portal_group *se_tpg)
-{
-       return 1;
-}
-
 static int ft_check_false(struct se_portal_group *se_tpg)
 {
        return 0;
@@ -507,12 +448,14 @@ static u32 ft_tpg_get_inst_index(struct se_portal_group *se_tpg)
        return tpg->index;
 }
 
-static struct target_core_fabric_ops ft_fabric_ops = {
+static const struct target_core_fabric_ops ft_fabric_ops = {
+       .module =                       THIS_MODULE,
+       .name =                         "fc",
+       .node_acl_size =                sizeof(struct ft_node_acl),
        .get_fabric_name =              ft_get_fabric_name,
        .get_fabric_proto_ident =       fc_get_fabric_proto_ident,
        .tpg_get_wwn =                  ft_get_fabric_wwn,
        .tpg_get_tag =                  ft_get_tag,
-       .tpg_get_default_depth =        ft_get_default_depth,
        .tpg_get_pr_transport_id =      fc_get_pr_transport_id,
        .tpg_get_pr_transport_id_len =  fc_get_pr_transport_id_len,
        .tpg_parse_pr_out_transport_id = fc_parse_pr_out_transport_id,
@@ -520,8 +463,6 @@ static struct target_core_fabric_ops ft_fabric_ops = {
        .tpg_check_demo_mode_cache =    ft_check_false,
        .tpg_check_demo_mode_write_protect = ft_check_false,
        .tpg_check_prod_mode_write_protect = ft_check_false,
-       .tpg_alloc_fabric_acl =         ft_tpg_alloc_fabric_acl,
-       .tpg_release_fabric_acl =       ft_tpg_release_fabric_acl,
        .tpg_get_inst_index =           ft_tpg_get_inst_index,
        .check_stop_free =              ft_check_stop_free,
        .release_cmd =                  ft_release_cmd,
@@ -546,68 +487,11 @@ static struct target_core_fabric_ops ft_fabric_ops = {
        .fabric_drop_wwn =              &ft_del_wwn,
        .fabric_make_tpg =              &ft_add_tpg,
        .fabric_drop_tpg =              &ft_del_tpg,
-       .fabric_post_link =             NULL,
-       .fabric_pre_unlink =            NULL,
-       .fabric_make_np =               NULL,
-       .fabric_drop_np =               NULL,
-       .fabric_make_nodeacl =          &ft_add_acl,
-       .fabric_drop_nodeacl =          &ft_del_acl,
-};
-
-static int ft_register_configfs(void)
-{
-       struct target_fabric_configfs *fabric;
-       int ret;
-
-       /*
-        * Register the top level struct config_item_type with TCM core
-        */
-       fabric = target_fabric_configfs_init(THIS_MODULE, "fc");
-       if (IS_ERR(fabric)) {
-               pr_err("%s: target_fabric_configfs_init() failed!\n",
-                      __func__);
-               return PTR_ERR(fabric);
-       }
-       fabric->tf_ops = ft_fabric_ops;
-
-       /*
-        * Setup default attribute lists for various fabric->tf_cit_tmpl
-        */
-       fabric->tf_cit_tmpl.tfc_wwn_cit.ct_attrs = ft_wwn_attrs;
-       fabric->tf_cit_tmpl.tfc_tpg_base_cit.ct_attrs = NULL;
-       fabric->tf_cit_tmpl.tfc_tpg_attrib_cit.ct_attrs = NULL;
-       fabric->tf_cit_tmpl.tfc_tpg_param_cit.ct_attrs = NULL;
-       fabric->tf_cit_tmpl.tfc_tpg_np_base_cit.ct_attrs = NULL;
-       fabric->tf_cit_tmpl.tfc_tpg_nacl_base_cit.ct_attrs =
-                                                   ft_nacl_base_attrs;
-       fabric->tf_cit_tmpl.tfc_tpg_nacl_attrib_cit.ct_attrs = NULL;
-       fabric->tf_cit_tmpl.tfc_tpg_nacl_auth_cit.ct_attrs = NULL;
-       fabric->tf_cit_tmpl.tfc_tpg_nacl_param_cit.ct_attrs = NULL;
-       /*
-        * register the fabric for use within TCM
-        */
-       ret = target_fabric_configfs_register(fabric);
-       if (ret < 0) {
-               pr_debug("target_fabric_configfs_register() for"
-                           " FC Target failed!\n");
-               target_fabric_configfs_free(fabric);
-               return -1;
-       }
-
-       /*
-        * Setup our local pointer to *fabric.
-        */
-       ft_configfs = fabric;
-       return 0;
-}
+       .fabric_init_nodeacl =          &ft_init_nodeacl,
 
-static void ft_deregister_configfs(void)
-{
-       if (!ft_configfs)
-               return;
-       target_fabric_configfs_deregister(ft_configfs);
-       ft_configfs = NULL;
-}
+       .tfc_wwn_attrs                  = ft_wwn_attrs,
+       .tfc_tpg_nacl_base_attrs        = ft_nacl_base_attrs,
+};
 
 static struct notifier_block ft_notifier = {
        .notifier_call = ft_lport_notify
@@ -615,15 +499,24 @@ static struct notifier_block ft_notifier = {
 
 static int __init ft_init(void)
 {
-       if (ft_register_configfs())
-               return -1;
-       if (fc_fc4_register_provider(FC_TYPE_FCP, &ft_prov)) {
-               ft_deregister_configfs();
-               return -1;
-       }
+       int ret;
+
+       ret = target_register_template(&ft_fabric_ops);
+       if (ret)
+               goto out;
+
+       ret = fc_fc4_register_provider(FC_TYPE_FCP, &ft_prov);
+       if (ret)
+               goto out_unregister_template;
+
        blocking_notifier_chain_register(&fc_lport_notifier_head, &ft_notifier);
        fc_lport_iterate(ft_lport_add, NULL);
        return 0;
+
+out_unregister_template:
+       target_unregister_template(&ft_fabric_ops);
+out:
+       return ret;
 }
 
 static void __exit ft_exit(void)
@@ -632,7 +525,7 @@ static void __exit ft_exit(void)
                                           &ft_notifier);
        fc_fc4_deregister_provider(FC_TYPE_FCP, &ft_prov);
        fc_lport_iterate(ft_lport_del, NULL);
-       ft_deregister_configfs();
+       target_unregister_template(&ft_fabric_ops);
        synchronize_rcu();
 }