[SCSI] libfc: combine name server registration request functions
[linux-2.6-block.git] / drivers / scsi / libfc / fc_lport.c
index 807f5b3e4efe28006134623c5636f42636223033..dfea6c572dfb827007f66cd0330906e10ccdbc00 100644 (file)
@@ -108,8 +108,7 @@ static void fc_lport_error(struct fc_lport *, struct fc_frame *);
 static void fc_lport_enter_reset(struct fc_lport *);
 static void fc_lport_enter_flogi(struct fc_lport *);
 static void fc_lport_enter_dns(struct fc_lport *);
-static void fc_lport_enter_rpn_id(struct fc_lport *);
-static void fc_lport_enter_rft_id(struct fc_lport *);
+static void fc_lport_enter_ns(struct fc_lport *, enum fc_lport_state);
 static void fc_lport_enter_scr(struct fc_lport *);
 static void fc_lport_enter_ready(struct fc_lport *);
 static void fc_lport_enter_logo(struct fc_lport *);
@@ -118,7 +117,9 @@ static const char *fc_lport_state_names[] = {
        [LPORT_ST_DISABLED] = "disabled",
        [LPORT_ST_FLOGI] =    "FLOGI",
        [LPORT_ST_DNS] =      "dNS",
-       [LPORT_ST_RPN_ID] =   "RPN_ID",
+       [LPORT_ST_RNN_ID] =   "RNN_ID",
+       [LPORT_ST_RSNN_NN] =  "RSNN_NN",
+       [LPORT_ST_RSPN_ID] =  "RSPN_ID",
        [LPORT_ST_RFT_ID] =   "RFT_ID",
        [LPORT_ST_SCR] =      "SCR",
        [LPORT_ST_READY] =    "Ready",
@@ -153,7 +154,7 @@ static void fc_lport_rport_callback(struct fc_lport *lport,
        case RPORT_EV_READY:
                if (lport->state == LPORT_ST_DNS) {
                        lport->dns_rp = rdata;
-                       fc_lport_enter_rpn_id(lport);
+                       fc_lport_enter_ns(lport, LPORT_ST_RNN_ID);
                } else {
                        FC_LPORT_DBG(lport, "Received an READY event "
                                     "on port (%6x) for the directory "
@@ -965,7 +966,9 @@ static void fc_lport_error(struct fc_lport *lport, struct fc_frame *fp)
                        case LPORT_ST_DISABLED:
                        case LPORT_ST_READY:
                        case LPORT_ST_RESET:
-                       case LPORT_ST_RPN_ID:
+                       case LPORT_ST_RNN_ID:
+                       case LPORT_ST_RSNN_NN:
+                       case LPORT_ST_RSPN_ID:
                        case LPORT_ST_RFT_ID:
                        case LPORT_ST_SCR:
                        case LPORT_ST_DNS:
@@ -979,9 +982,9 @@ static void fc_lport_error(struct fc_lport *lport, struct fc_frame *fp)
 }
 
 /**
- * fc_lport_rft_id_resp() - Handle response to Register Fibre
- *                         Channel Types by ID (RPN_ID) request
- * @sp: current sequence in RPN_ID exchange
+ * fc_lport_ns_resp() - Handle response to a name server
+ *                     registration exchange
+ * @sp: current sequence in exchange
  * @fp: response frame
  * @lp_arg: Fibre Channel host port instance
  *
@@ -989,23 +992,23 @@ static void fc_lport_error(struct fc_lport *lport, struct fc_frame *fp)
  * held, but it will lock, call an _enter_* function or fc_lport_error
  * and then unlock the lport.
  */
-static void fc_lport_rft_id_resp(struct fc_seq *sp, struct fc_frame *fp,
-                                void *lp_arg)
+static void fc_lport_ns_resp(struct fc_seq *sp, struct fc_frame *fp,
+                            void *lp_arg)
 {
        struct fc_lport *lport = lp_arg;
        struct fc_frame_header *fh;
        struct fc_ct_hdr *ct;
 
-       FC_LPORT_DBG(lport, "Received a RFT_ID %s\n", fc_els_resp_type(fp));
+       FC_LPORT_DBG(lport, "Received a ns %s\n", fc_els_resp_type(fp));
 
        if (fp == ERR_PTR(-FC_EX_CLOSED))
                return;
 
        mutex_lock(&lport->lp_mutex);
 
-       if (lport->state != LPORT_ST_RFT_ID) {
-               FC_LPORT_DBG(lport, "Received a RFT_ID response, but in state "
-                            "%s\n", fc_lport_state(lport));
+       if (lport->state < LPORT_ST_RNN_ID || lport->state > LPORT_ST_RFT_ID) {
+               FC_LPORT_DBG(lport, "Received a name server response, "
+                                   "but in state %s\n", fc_lport_state(lport));
                if (IS_ERR(fp))
                        goto err;
                goto out;
@@ -1023,63 +1026,25 @@ static void fc_lport_rft_id_resp(struct fc_seq *sp, struct fc_frame *fp,
            ct->ct_fs_type == FC_FST_DIR &&
            ct->ct_fs_subtype == FC_NS_SUBTYPE &&
            ntohs(ct->ct_cmd) == FC_FS_ACC)
-               fc_lport_enter_scr(lport);
-       else
-               fc_lport_error(lport, fp);
-out:
-       fc_frame_free(fp);
-err:
-       mutex_unlock(&lport->lp_mutex);
-}
-
-/**
- * fc_lport_rpn_id_resp() - Handle response to Register Port
- *                         Name by ID (RPN_ID) request
- * @sp: current sequence in RPN_ID exchange
- * @fp: response frame
- * @lp_arg: Fibre Channel host port instance
- *
- * Locking Note: This function will be called without the lport lock
- * held, but it will lock, call an _enter_* function or fc_lport_error
- * and then unlock the lport.
- */
-static void fc_lport_rpn_id_resp(struct fc_seq *sp, struct fc_frame *fp,
-                                void *lp_arg)
-{
-       struct fc_lport *lport = lp_arg;
-       struct fc_frame_header *fh;
-       struct fc_ct_hdr *ct;
-
-       FC_LPORT_DBG(lport, "Received a RPN_ID %s\n", fc_els_resp_type(fp));
-
-       if (fp == ERR_PTR(-FC_EX_CLOSED))
-               return;
-
-       mutex_lock(&lport->lp_mutex);
-
-       if (lport->state != LPORT_ST_RPN_ID) {
-               FC_LPORT_DBG(lport, "Received a RPN_ID response, but in state "
-                            "%s\n", fc_lport_state(lport));
-               if (IS_ERR(fp))
-                       goto err;
-               goto out;
-       }
-
-       if (IS_ERR(fp)) {
-               fc_lport_error(lport, fp);
-               goto err;
-       }
-
-       fh = fc_frame_header_get(fp);
-       ct = fc_frame_payload_get(fp, sizeof(*ct));
-       if (fh && ct && fh->fh_type == FC_TYPE_CT &&
-           ct->ct_fs_type == FC_FST_DIR &&
-           ct->ct_fs_subtype == FC_NS_SUBTYPE &&
-           ntohs(ct->ct_cmd) == FC_FS_ACC)
-               fc_lport_enter_rft_id(lport);
+               switch (lport->state) {
+               case LPORT_ST_RNN_ID:
+                       fc_lport_enter_ns(lport, LPORT_ST_RSNN_NN);
+                       break;
+               case LPORT_ST_RSNN_NN:
+                       fc_lport_enter_ns(lport, LPORT_ST_RSPN_ID);
+                       break;
+               case LPORT_ST_RSPN_ID:
+                       fc_lport_enter_ns(lport, LPORT_ST_RFT_ID);
+                       break;
+               case LPORT_ST_RFT_ID:
+                       fc_lport_enter_scr(lport);
+                       break;
+               default:
+                       /* should have already been caught by state checks */
+                       break;
+               }
        else
                fc_lport_error(lport, fp);
-
 out:
        fc_frame_free(fp);
 err:
@@ -1162,76 +1127,67 @@ static void fc_lport_enter_scr(struct fc_lport *lport)
 }
 
 /**
- * fc_lport_enter_rft_id() - Register FC4-types with the name server
+ * fc_lport_enter_ns() - register some object with the name server
  * @lport: Fibre Channel local port to register
  *
  * Locking Note: The lport lock is expected to be held before calling
  * this routine.
  */
-static void fc_lport_enter_rft_id(struct fc_lport *lport)
+static void fc_lport_enter_ns(struct fc_lport *lport, enum fc_lport_state state)
 {
        struct fc_frame *fp;
-       struct fc_ns_fts *lps;
-       int i;
+       enum fc_ns_req cmd;
+       int size = sizeof(struct fc_ct_hdr);
+       size_t len;
 
-       FC_LPORT_DBG(lport, "Entered RFT_ID state from %s state\n",
+       FC_LPORT_DBG(lport, "Entered %s state from %s state\n",
+                    fc_lport_state_names[state],
                     fc_lport_state(lport));
 
-       fc_lport_state_enter(lport, LPORT_ST_RFT_ID);
+       fc_lport_state_enter(lport, state);
 
-       lps = &lport->fcts;
-       i = sizeof(lps->ff_type_map) / sizeof(lps->ff_type_map[0]);
-       while (--i >= 0)
-               if (ntohl(lps->ff_type_map[i]) != 0)
-                       break;
-       if (i < 0) {
-               /* nothing to register, move on to SCR */
-               fc_lport_enter_scr(lport);
+       switch (state) {
+       case LPORT_ST_RNN_ID:
+               cmd = FC_NS_RNN_ID;
+               size += sizeof(struct fc_ns_rn_id);
+               break;
+       case LPORT_ST_RSNN_NN:
+               len = strnlen(fc_host_symbolic_name(lport->host), 255);
+               /* if there is no symbolic name, skip to RFT_ID */
+               if (!len)
+                       return fc_lport_enter_ns(lport, LPORT_ST_RFT_ID);
+               cmd = FC_NS_RSNN_NN;
+               size += sizeof(struct fc_ns_rsnn) + len;
+               break;
+       case LPORT_ST_RSPN_ID:
+               len = strnlen(fc_host_symbolic_name(lport->host), 255);
+               /* if there is no symbolic name, skip to RFT_ID */
+               if (!len)
+                       return fc_lport_enter_ns(lport, LPORT_ST_RFT_ID);
+               cmd = FC_NS_RSPN_ID;
+               size += sizeof(struct fc_ns_rspn) + len;
+               break;
+       case LPORT_ST_RFT_ID:
+               cmd = FC_NS_RFT_ID;
+               size += sizeof(struct fc_ns_rft);
+               break;
+       default:
+               fc_lport_error(lport, NULL);
                return;
        }
 
-       fp = fc_frame_alloc(lport, sizeof(struct fc_ct_hdr) +
-                           sizeof(struct fc_ns_rft));
+       fp = fc_frame_alloc(lport, size);
        if (!fp) {
                fc_lport_error(lport, fp);
                return;
        }
 
-       if (!lport->tt.elsct_send(lport, FC_FID_DIR_SERV, fp, FC_NS_RFT_ID,
-                                 fc_lport_rft_id_resp,
+       if (!lport->tt.elsct_send(lport, FC_FID_DIR_SERV, fp, cmd,
+                                 fc_lport_ns_resp,
                                  lport, lport->e_d_tov))
                fc_lport_error(lport, fp);
 }
 
-/**
- * fc_rport_enter_rft_id() - Register port name with the name server
- * @lport: Fibre Channel local port to register
- *
- * Locking Note: The lport lock is expected to be held before calling
- * this routine.
- */
-static void fc_lport_enter_rpn_id(struct fc_lport *lport)
-{
-       struct fc_frame *fp;
-
-       FC_LPORT_DBG(lport, "Entered RPN_ID state from %s state\n",
-                    fc_lport_state(lport));
-
-       fc_lport_state_enter(lport, LPORT_ST_RPN_ID);
-
-       fp = fc_frame_alloc(lport, sizeof(struct fc_ct_hdr) +
-                           sizeof(struct fc_ns_rn_id));
-       if (!fp) {
-               fc_lport_error(lport, fp);
-               return;
-       }
-
-       if (!lport->tt.elsct_send(lport, FC_FID_DIR_SERV, fp, FC_NS_RPN_ID,
-                                 fc_lport_rpn_id_resp,
-                                 lport, lport->e_d_tov))
-               fc_lport_error(lport, NULL);
-}
-
 static struct fc_rport_operations fc_lport_rport_ops = {
        .event_callback = fc_lport_rport_callback,
 };
@@ -1293,11 +1249,11 @@ static void fc_lport_timeout(struct work_struct *work)
        case LPORT_ST_DNS:
                fc_lport_enter_dns(lport);
                break;
-       case LPORT_ST_RPN_ID:
-               fc_lport_enter_rpn_id(lport);
-               break;
+       case LPORT_ST_RNN_ID:
+       case LPORT_ST_RSNN_NN:
+       case LPORT_ST_RSPN_ID:
        case LPORT_ST_RFT_ID:
-               fc_lport_enter_rft_id(lport);
+               fc_lport_enter_ns(lport, lport->state);
                break;
        case LPORT_ST_SCR:
                fc_lport_enter_scr(lport);