Merge tag 'drm-intel-next-2018-02-21' of git://anongit.freedesktop.org/drm/drm-intel...
[linux-2.6-block.git] / drivers / gpu / drm / amd / display / amdgpu_dm / amdgpu_dm.c
index b7254a29b34a16791cc477d932490cf625e57941..246fff33c7bf556e9ca228b0ad4025aa84a582c3 100644 (file)
@@ -61,7 +61,8 @@
 
 #include "dcn/dcn_1_0_offset.h"
 #include "dcn/dcn_1_0_sh_mask.h"
-#include "soc15ip.h"
+#include "soc15_hw_ip.h"
+#include "vega10_ip_offset.h"
 
 #include "soc15_common.h"
 #endif
@@ -319,6 +320,7 @@ static void dm_crtc_high_irq(void *interrupt_params)
                crtc_index = acrtc->crtc_id;
 
        drm_handle_vblank(adev->ddev, crtc_index);
+       amdgpu_dm_crtc_handle_crc_irq(&acrtc->base);
 }
 
 static int dm_set_clockgating_state(void *handle,
@@ -345,23 +347,43 @@ static void hotplug_notify_work_func(struct work_struct *work)
 }
 
 #if defined(CONFIG_DRM_AMD_DC_FBC)
-#include "dal_asic_id.h"
 /* Allocate memory for FBC compressed data  */
-/* TODO: Dynamic allocation */
-#define AMDGPU_FBC_SIZE    (3840 * 2160 * 4)
-
-static void amdgpu_dm_initialize_fbc(struct amdgpu_device *adev)
+static void amdgpu_dm_fbc_init(struct drm_connector *connector)
 {
-       int r;
+       struct drm_device *dev = connector->dev;
+       struct amdgpu_device *adev = dev->dev_private;
        struct dm_comressor_info *compressor = &adev->dm.compressor;
+       struct amdgpu_dm_connector *aconn = to_amdgpu_dm_connector(connector);
+       struct drm_display_mode *mode;
+       unsigned long max_size = 0;
+
+       if (adev->dm.dc->fbc_compressor == NULL)
+               return;
+
+       if (aconn->dc_link->connector_signal != SIGNAL_TYPE_EDP)
+               return;
+
+       if (compressor->bo_ptr)
+               return;
+
 
-       if (!compressor->bo_ptr) {
-               r = amdgpu_bo_create_kernel(adev, AMDGPU_FBC_SIZE, PAGE_SIZE,
-                               AMDGPU_GEM_DOMAIN_VRAM, &compressor->bo_ptr,
-                               &compressor->gpu_addr, &compressor->cpu_addr);
+       list_for_each_entry(mode, &connector->modes, head) {
+               if (max_size < mode->htotal * mode->vtotal)
+                       max_size = mode->htotal * mode->vtotal;
+       }
+
+       if (max_size) {
+               int r = amdgpu_bo_create_kernel(adev, max_size * 4, PAGE_SIZE,
+                           AMDGPU_GEM_DOMAIN_VRAM, &compressor->bo_ptr,
+                           &compressor->gpu_addr, &compressor->cpu_addr);
 
                if (r)
-                       DRM_ERROR("DM: Failed to initialize fbc\n");
+                       DRM_ERROR("DM: Failed to initialize FBC\n");
+               else {
+                       adev->dm.dc->ctx->fbc_gpu_addr = compressor->gpu_addr;
+                       DRM_INFO("DM: FBC alloc %lu\n", max_size*4);
+               }
+
        }
 
 }
@@ -381,12 +403,6 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
        /* Zero all the fields */
        memset(&init_data, 0, sizeof(init_data));
 
-       /* initialize DAL's lock (for SYNC context use) */
-       spin_lock_init(&adev->dm.dal_lock);
-
-       /* initialize DAL's mutex */
-       mutex_init(&adev->dm.dal_mutex);
-
        if(amdgpu_dm_irq_init(adev)) {
                DRM_ERROR("amdgpu: failed to initialize DM IRQ support.\n");
                goto error;
@@ -397,7 +413,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
        init_data.asic_id.pci_revision_id = adev->rev_id;
        init_data.asic_id.hw_internal_rev = adev->external_rev_id;
 
-       init_data.asic_id.vram_width = adev->mc.vram_width;
+       init_data.asic_id.vram_width = adev->gmc.vram_width;
        /* TODO: initialize init_data.asic_id.vram_type here!!!! */
        init_data.asic_id.atombios_base_address =
                adev->mode_info.atom_context->bios;
@@ -422,11 +438,14 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
        else
                init_data.log_mask = DC_MIN_LOG_MASK;
 
-#if defined(CONFIG_DRM_AMD_DC_FBC)
-       if (adev->family == FAMILY_CZ)
-               amdgpu_dm_initialize_fbc(adev);
-       init_data.fbc_gpu_addr = adev->dm.compressor.gpu_addr;
-#endif
+       /*
+        * TODO debug why this doesn't work on Raven
+        */
+       if (adev->flags & AMD_IS_APU &&
+           adev->asic_type >= CHIP_CARRIZO &&
+           adev->asic_type < CHIP_RAVEN)
+               init_data.flags.gpu_vm_support = true;
+
        /* Display Core create. */
        adev->dm.dc = dc_create(&init_data);
 
@@ -447,6 +466,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
                DRM_DEBUG_DRIVER("amdgpu: freesync_module init done %p.\n",
                                adev->dm.freesync_module);
 
+       amdgpu_dm_init_color_mod();
+
        if (amdgpu_dm_initialize_drm_device(adev)) {
                DRM_ERROR(
                "amdgpu: failed to initialize sw for display support.\n");
@@ -540,9 +561,9 @@ static int detect_mst_link_for_all_connectors(struct drm_device *dev)
 
 static int dm_late_init(void *handle)
 {
-       struct drm_device *dev = ((struct amdgpu_device *)handle)->ddev;
+       struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
-       return detect_mst_link_for_all_connectors(dev);
+       return detect_mst_link_for_all_connectors(adev->ddev);
 }
 
 static void s3_handle_mst(struct drm_device *dev, bool suspend)
@@ -629,11 +650,13 @@ static int dm_resume(void *handle)
 {
        struct amdgpu_device *adev = handle;
        struct amdgpu_display_manager *dm = &adev->dm;
+       int ret = 0;
 
        /* power on hardware */
        dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D0);
 
-       return 0;
+       ret = amdgpu_dm_display_resume(adev);
+       return ret;
 }
 
 int amdgpu_dm_display_resume(struct amdgpu_device *adev)
@@ -791,7 +814,7 @@ dm_atomic_state_alloc_free(struct drm_atomic_state *state)
 }
 
 static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = {
-       .fb_create = amdgpu_user_framebuffer_create,
+       .fb_create = amdgpu_display_user_framebuffer_create,
        .output_poll_changed = drm_fb_helper_output_poll_changed,
        .atomic_check = amdgpu_dm_atomic_check,
        .atomic_commit = amdgpu_dm_atomic_commit,
@@ -1279,9 +1302,9 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
        /* indicate support of immediate flip */
        adev->ddev->mode_config.async_page_flip = true;
 
-       adev->ddev->mode_config.fb_base = adev->mc.aper_base;
+       adev->ddev->mode_config.fb_base = adev->gmc.aper_base;
 
-       r = amdgpu_modeset_create_props(adev);
+       r = amdgpu_display_modeset_create_props(adev);
        if (r)
                return r;
 
@@ -1538,7 +1561,6 @@ static int amdgpu_notify_freesync(struct drm_device *dev, void *data,
 static const struct amdgpu_display_funcs dm_display_funcs = {
        .bandwidth_update = dm_bandwidth_update, /* called unconditionally */
        .vblank_get_counter = dm_vblank_get_counter,/* called unconditionally */
-       .vblank_wait = NULL,
        .backlight_set_level =
                dm_set_backlight_level,/* called unconditionally */
        .backlight_get_level =
@@ -1589,8 +1611,6 @@ static int dm_early_init(void *handle)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
-       adev->ddev->driver->driver_features |= DRIVER_ATOMIC;
-
        switch (adev->asic_type) {
        case CHIP_BONAIRE:
        case CHIP_HAWAII:
@@ -1924,32 +1944,6 @@ static int fill_plane_attributes_from_fb(struct amdgpu_device *adev,
 
 }
 
-static void fill_gamma_from_crtc_state(const struct drm_crtc_state *crtc_state,
-                                      struct dc_plane_state *plane_state)
-{
-       int i;
-       struct dc_gamma *gamma;
-       struct drm_color_lut *lut =
-                       (struct drm_color_lut *) crtc_state->gamma_lut->data;
-
-       gamma = dc_create_gamma();
-
-       if (gamma == NULL) {
-               WARN_ON(1);
-               return;
-       }
-
-       gamma->type = GAMMA_RGB_256;
-       gamma->num_entries = GAMMA_RGB_256_ENTRIES;
-       for (i = 0; i < GAMMA_RGB_256_ENTRIES; i++) {
-               gamma->entries.red[i] = dal_fixed31_32_from_int(lut[i].red);
-               gamma->entries.green[i] = dal_fixed31_32_from_int(lut[i].green);
-               gamma->entries.blue[i] = dal_fixed31_32_from_int(lut[i].blue);
-       }
-
-       plane_state->gamma_correction = gamma;
-}
-
 static int fill_plane_attributes(struct amdgpu_device *adev,
                                 struct dc_plane_state *dc_plane_state,
                                 struct drm_plane_state *plane_state,
@@ -1977,14 +1971,13 @@ static int fill_plane_attributes(struct amdgpu_device *adev,
        if (input_tf == NULL)
                return -ENOMEM;
 
-       input_tf->type = TF_TYPE_PREDEFINED;
-       input_tf->tf = TRANSFER_FUNCTION_SRGB;
-
        dc_plane_state->in_transfer_func = input_tf;
 
-       /* In case of gamma set, update gamma value */
-       if (crtc_state->gamma_lut)
-               fill_gamma_from_crtc_state(crtc_state, dc_plane_state);
+       /*
+        * Always set input transfer function, since plane state is refreshed
+        * every time.
+        */
+       ret = amdgpu_dm_set_degamma_lut(crtc_state, dc_plane_state);
 
        return ret;
 }
@@ -2010,30 +2003,32 @@ static void update_stream_scaling_settings(const struct drm_display_mode *mode,
        dst.width = stream->timing.h_addressable;
        dst.height = stream->timing.v_addressable;
 
-       rmx_type = dm_state->scaling;
-       if (rmx_type == RMX_ASPECT || rmx_type == RMX_OFF) {
-               if (src.width * dst.height <
-                               src.height * dst.width) {
-                       /* height needs less upscaling/more downscaling */
-                       dst.width = src.width *
-                                       dst.height / src.height;
-               } else {
-                       /* width needs less upscaling/more downscaling */
-                       dst.height = src.height *
-                                       dst.width / src.width;
+       if (dm_state) {
+               rmx_type = dm_state->scaling;
+               if (rmx_type == RMX_ASPECT || rmx_type == RMX_OFF) {
+                       if (src.width * dst.height <
+                                       src.height * dst.width) {
+                               /* height needs less upscaling/more downscaling */
+                               dst.width = src.width *
+                                               dst.height / src.height;
+                       } else {
+                               /* width needs less upscaling/more downscaling */
+                               dst.height = src.height *
+                                               dst.width / src.width;
+                       }
+               } else if (rmx_type == RMX_CENTER) {
+                       dst = src;
                }
-       } else if (rmx_type == RMX_CENTER) {
-               dst = src;
-       }
 
-       dst.x = (stream->timing.h_addressable - dst.width) / 2;
-       dst.y = (stream->timing.v_addressable - dst.height) / 2;
+               dst.x = (stream->timing.h_addressable - dst.width) / 2;
+               dst.y = (stream->timing.v_addressable - dst.height) / 2;
 
-       if (dm_state->underscan_enable) {
-               dst.x += dm_state->underscan_hborder / 2;
-               dst.y += dm_state->underscan_vborder / 2;
-               dst.width -= dm_state->underscan_hborder;
-               dst.height -= dm_state->underscan_vborder;
+               if (dm_state->underscan_enable) {
+                       dst.x += dm_state->underscan_hborder / 2;
+                       dst.y += dm_state->underscan_vborder / 2;
+                       dst.width -= dm_state->underscan_hborder;
+                       dst.height -= dm_state->underscan_vborder;
+               }
        }
 
        stream->src = src;
@@ -2322,7 +2317,7 @@ static void set_master_stream(struct dc_stream_state *stream_set[],
                }
        }
        for (j = 0;  j < stream_count; j++) {
-               if (stream_set[j] && j != master_stream)
+               if (stream_set[j])
                        stream_set[j]->triggered_crtc_reset.event_source = stream_set[master_stream];
        }
 }
@@ -2358,12 +2353,7 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
 
        if (aconnector == NULL) {
                DRM_ERROR("aconnector is NULL!\n");
-               goto drm_connector_null;
-       }
-
-       if (dm_state == NULL) {
-               DRM_ERROR("dm_state is NULL!\n");
-               goto dm_state_null;
+               return stream;
        }
 
        drm_connector = &aconnector->base;
@@ -2375,18 +2365,18 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
                 */
                if (aconnector->mst_port) {
                        dm_dp_mst_dc_sink_create(drm_connector);
-                       goto mst_dc_sink_create_done;
+                       return stream;
                }
 
                if (create_fake_sink(aconnector))
-                       goto stream_create_fail;
+                       return stream;
        }
 
        stream = dc_create_stream_for_sink(aconnector->dc_sink);
 
        if (stream == NULL) {
                DRM_ERROR("Failed to create stream for sink!\n");
-               goto stream_create_fail;
+               return stream;
        }
 
        list_for_each_entry(preferred_mode, &aconnector->base.modes, head) {
@@ -2412,9 +2402,12 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
        } else {
                decide_crtc_timing_for_drm_display_mode(
                                &mode, preferred_mode,
-                               dm_state->scaling != RMX_OFF);
+                               dm_state ? (dm_state->scaling != RMX_OFF) : false);
        }
 
+       if (!dm_state)
+               drm_mode_set_crtcinfo(&mode, 0);
+
        fill_stream_properties_from_drm_display_mode(stream,
                        &mode, &aconnector->base);
        update_stream_scaling_settings(&mode, dm_state, stream);
@@ -2424,10 +2417,8 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
                drm_connector,
                aconnector->dc_sink);
 
-stream_create_fail:
-dm_state_null:
-drm_connector_null:
-mst_dc_sink_create_done:
+       update_stream_signal(stream);
+
        return stream;
 }
 
@@ -2504,6 +2495,7 @@ static const struct drm_crtc_funcs amdgpu_dm_crtc_funcs = {
        .page_flip = drm_atomic_helper_page_flip,
        .atomic_duplicate_state = dm_crtc_duplicate_state,
        .atomic_destroy_state = dm_crtc_destroy_state,
+       .set_crc_source = amdgpu_dm_crtc_set_crc_source,
 };
 
 static enum drm_connector_status
@@ -2779,6 +2771,7 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
        /* TODO: Unhardcode stream count */
        struct dc_stream_state *stream;
        struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
+       enum dc_status dc_result = DC_OK;
 
        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) ||
                        (mode->flags & DRM_MODE_FLAG_DBLSCAN))
@@ -2798,21 +2791,22 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector *connector,
                goto fail;
        }
 
-       stream = dc_create_stream_for_sink(dc_sink);
+       stream = create_stream_for_sink(aconnector, mode, NULL);
        if (stream == NULL) {
                DRM_ERROR("Failed to create stream for sink!\n");
                goto fail;
        }
 
-       drm_mode_set_crtcinfo(mode, 0);
-       fill_stream_properties_from_drm_display_mode(stream, mode, connector);
-
-       stream->src.width = mode->hdisplay;
-       stream->src.height = mode->vdisplay;
-       stream->dst = stream->src;
+       dc_result = dc_validate_stream(adev->dm.dc, stream);
 
-       if (dc_validate_stream(adev->dm.dc, stream) == DC_OK)
+       if (dc_result == DC_OK)
                result = MODE_OK;
+       else
+               DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
+                             mode->vdisplay,
+                             mode->hdisplay,
+                             mode->clock,
+                             dc_result);
 
        dc_stream_release(stream);
 
@@ -2954,11 +2948,13 @@ static int dm_plane_helper_prepare_fb(struct drm_plane *plane,
 {
        struct amdgpu_framebuffer *afb;
        struct drm_gem_object *obj;
+       struct amdgpu_device *adev;
        struct amdgpu_bo *rbo;
        uint64_t chroma_addr = 0;
-       int r;
        struct dm_plane_state *dm_plane_state_new, *dm_plane_state_old;
        unsigned int awidth;
+       uint32_t domain;
+       int r;
 
        dm_plane_state_old = to_dm_plane_state(plane->state);
        dm_plane_state_new = to_dm_plane_state(new_state);
@@ -2972,12 +2968,17 @@ static int dm_plane_helper_prepare_fb(struct drm_plane *plane,
 
        obj = afb->obj;
        rbo = gem_to_amdgpu_bo(obj);
+       adev = amdgpu_ttm_adev(rbo->tbo.bdev);
        r = amdgpu_bo_reserve(rbo, false);
        if (unlikely(r != 0))
                return r;
 
-       r = amdgpu_bo_pin(rbo, AMDGPU_GEM_DOMAIN_VRAM, &afb->address);
+       if (plane->type != DRM_PLANE_TYPE_CURSOR)
+               domain = amdgpu_display_framebuffer_domains(adev);
+       else
+               domain = AMDGPU_GEM_DOMAIN_VRAM;
 
+       r = amdgpu_bo_pin(rbo, domain, &afb->address);
 
        amdgpu_bo_unreserve(rbo);
 
@@ -3190,7 +3191,9 @@ static int amdgpu_dm_crtc_init(struct amdgpu_display_manager *dm,
        acrtc->base.enabled = false;
 
        dm->adev->mode_info.crtcs[crtc_index] = acrtc;
-       drm_mode_crtc_set_gamma_size(&acrtc->base, 256);
+       drm_crtc_enable_color_mgmt(&acrtc->base, MAX_COLOR_LUT_ENTRIES,
+                                  true, MAX_COLOR_LUT_ENTRIES);
+       drm_mode_crtc_set_gamma_size(&acrtc->base, MAX_COLOR_LUT_ENTRIES);
 
        return 0;
 
@@ -3366,9 +3369,12 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)
        struct edid *edid = amdgpu_dm_connector->edid;
 
        encoder = helper->best_encoder(connector);
-
        amdgpu_dm_connector_ddc_get_modes(connector, edid);
        amdgpu_dm_connector_add_common_modes(encoder, connector);
+
+#if defined(CONFIG_DRM_AMD_DC_FBC)
+       amdgpu_dm_fbc_init(connector);
+#endif
        return amdgpu_dm_connector->num_modes;
 }
 
@@ -3641,7 +3647,7 @@ static void manage_dm_interrupts(struct amdgpu_device *adev,
         * constant is the same as PFLIP
         */
        int irq_type =
-               amdgpu_crtc_idx_to_irq_type(
+               amdgpu_display_crtc_idx_to_irq_type(
                        adev,
                        acrtc->crtc_id);
 
@@ -3860,9 +3866,9 @@ static void amdgpu_dm_do_flip(struct drm_crtc *crtc,
         * targeted by the flip
         */
        while ((acrtc->enabled &&
-               (amdgpu_get_crtc_scanoutpos(adev->ddev, acrtc->crtc_id, 0,
-                                       &vpos, &hpos, NULL, NULL,
-                                       &crtc->hwmode)
+               (amdgpu_display_get_crtc_scanoutpos(adev->ddev, acrtc->crtc_id,
+                                                   0, &vpos, &hpos, NULL,
+                                                   NULL, &crtc->hwmode)
                 & (DRM_SCANOUTPOS_VALID | DRM_SCANOUTPOS_IN_VBLANK)) ==
                (DRM_SCANOUTPOS_VALID | DRM_SCANOUTPOS_IN_VBLANK) &&
                (int)(target_vblank -
@@ -4603,6 +4609,30 @@ next_crtc:
                /* Release extra reference */
                if (new_stream)
                         dc_stream_release(new_stream);
+
+               /*
+                * We want to do dc stream updates that do not require a
+                * full modeset below.
+                */
+               if (!enable || !aconnector || modereset_required(new_crtc_state))
+                       continue;
+               /*
+                * Given above conditions, the dc state cannot be NULL because:
+                * 1. We're attempting to enable a CRTC. Which has a...
+                * 2. Valid connector attached, and
+                * 3. User does not want to reset it (disable or mark inactive,
+                *    which can happen on a CRTC that's already disabled).
+                * => It currently exists.
+                */
+               BUG_ON(dm_new_crtc_state->stream == NULL);
+
+               /* Color managment settings */
+               if (dm_new_crtc_state->base.color_mgmt_changed) {
+                       ret = amdgpu_dm_set_regamma_lut(dm_new_crtc_state);
+                       if (ret)
+                               goto fail;
+                       amdgpu_dm_set_ctm(dm_new_crtc_state);
+               }
        }
 
        return ret;
@@ -4711,7 +4741,6 @@ static int dm_update_planes_state(struct dc *dc,
                        if (ret)
                                return ret;
 
-
                        if (!dc_add_plane_to_context(
                                        dc,
                                        dm_new_crtc_state->stream,