projects
/
fio.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Drop the only local variable declaration within a for-loop (C99)
[fio.git]
/
idletime.c
diff --git
a/idletime.c
b/idletime.c
index c0bc0bfce19675e311fcbd7394540b02a7010eba..4c00d80df692590b6b8b62a57bd9af2fa528dcd2 100644
(file)
--- a/
idletime.c
+++ b/
idletime.c
@@
-43,16
+43,26
@@
static double calibrate_unit(unsigned char *data)
return tunit / CALIBRATE_SCALE;
}
return tunit / CALIBRATE_SCALE;
}
+static void free_cpu_affinity(struct idle_prof_thread *ipt)
+{
+#if defined(FIO_HAVE_CPU_AFFINITY)
+ fio_cpuset_exit(&ipt->cpu_mask);
+#endif
+}
+
static int set_cpu_affinity(struct idle_prof_thread *ipt)
{
#if defined(FIO_HAVE_CPU_AFFINITY)
static int set_cpu_affinity(struct idle_prof_thread *ipt)
{
#if defined(FIO_HAVE_CPU_AFFINITY)
- os_cpu_mask_t cpu_mask;
+ if (fio_cpuset_init(&ipt->cpu_mask)) {
+ log_err("fio: cpuset init failed\n");
+ return -1;
+ }
- memset(&cpu_mask, 0, sizeof(cpu_mask));
- fio_cpu_set(&cpu_mask, ipt->cpu);
+ fio_cpu_set(&ipt->cpu_mask, ipt->cpu);
- if (fio_setaffinity(gettid(), cpu_mask)) {
+ if (fio_setaffinity(gettid(),
ipt->
cpu_mask)) {
log_err("fio: fio_setaffinity failed\n");
log_err("fio: fio_setaffinity failed\n");
+ fio_cpuset_exit(&ipt->cpu_mask);
return -1;
}
return -1;
}
@@
-73,8
+83,10
@@
static void *idle_prof_thread_fn(void *data)
pthread_mutex_lock(&ipt->init_lock);
/* exit if any other thread failed to start */
pthread_mutex_lock(&ipt->init_lock);
/* exit if any other thread failed to start */
- if (ipc.status == IDLE_PROF_STATUS_ABORT)
+ if (ipc.status == IDLE_PROF_STATUS_ABORT) {
+ pthread_mutex_unlock(&ipt->init_lock);
return NULL;
return NULL;
+ }
retval = set_cpu_affinity(ipt);
if (retval == -1) {
retval = set_cpu_affinity(ipt);
if (retval == -1) {
@@
-96,7
+108,7
@@
static void *idle_prof_thread_fn(void *data)
if (retval == -1) {
ipt->state = TD_EXITED;
pthread_mutex_unlock(&ipt->init_lock);
if (retval == -1) {
ipt->state = TD_EXITED;
pthread_mutex_unlock(&ipt->init_lock);
-
return NULL
;
+
goto do_exit
;
}
ipt->state = TD_INITIALIZED;
}
ipt->state = TD_INITIALIZED;
@@
-109,12
+121,16
@@
static void *idle_prof_thread_fn(void *data)
pthread_mutex_lock(&ipt->start_lock);
/* exit if other threads failed to initialize */
pthread_mutex_lock(&ipt->start_lock);
/* exit if other threads failed to initialize */
- if (ipc.status == IDLE_PROF_STATUS_ABORT)
- return NULL;
+ if (ipc.status == IDLE_PROF_STATUS_ABORT) {
+ pthread_mutex_unlock(&ipt->start_lock);
+ goto do_exit;
+ }
/* exit if we are doing calibration only */
/* exit if we are doing calibration only */
- if (ipc.status == IDLE_PROF_STATUS_CALI_STOP)
- return NULL;
+ if (ipc.status == IDLE_PROF_STATUS_CALI_STOP) {
+ pthread_mutex_unlock(&ipt->start_lock);
+ goto do_exit;
+ }
fio_gettime(&ipt->tps, NULL);
ipt->state = TD_RUNNING;
fio_gettime(&ipt->tps, NULL);
ipt->state = TD_RUNNING;
@@
-137,6
+153,8
@@
idle_prof_done:
ipt->state = TD_EXITED;
pthread_mutex_unlock(&ipt->start_lock);
ipt->state = TD_EXITED;
pthread_mutex_unlock(&ipt->start_lock);
+do_exit:
+ free_cpu_affinity(ipt);
return NULL;
}
return NULL;
}
@@
-242,7
+260,7
@@
void fio_idle_prof_init(void)
if ((ret = pthread_detach(ipt->thread))) {
/* log error and let the thread spin */
if ((ret = pthread_detach(ipt->thread))) {
/* log error and let the thread spin */
- log_err("fio: pthread_deta
t
ch %s\n", strerror(ret));
+ log_err("fio: pthread_detach %s\n", strerror(ret));
}
}
}
}
@@
-336,7
+354,10
@@
void fio_idle_prof_stop(void)
/* calculate idleness */
if (ipc.cali_mean != 0.0) {
runt = utime_since(&ipt->tps, &ipt->tpe);
/* calculate idleness */
if (ipc.cali_mean != 0.0) {
runt = utime_since(&ipt->tps, &ipt->tpe);
- ipt->idleness = ipt->loops * ipc.cali_mean / runt;
+ if (runt)
+ ipt->idleness = ipt->loops * ipc.cali_mean / runt;
+ else
+ ipt->idleness = 0.0;
} else
ipt->idleness = 0.0;
}
} else
ipt->idleness = 0.0;
}
@@
-407,7
+428,7
@@
int fio_idle_prof_parse_opt(const char *args)
fio_idle_prof_init();
fio_idle_prof_start();
fio_idle_prof_stop();
fio_idle_prof_init();
fio_idle_prof_start();
fio_idle_prof_stop();
- show_idle_prof_stats(FIO_OUTPUT_NORMAL, NULL);
+ show_idle_prof_stats(FIO_OUTPUT_NORMAL, NULL
, NULL
);
return 1;
} else if (strcmp("system", args) == 0) {
ipc.opt = IDLE_PROF_OPT_SYSTEM;
return 1;
} else if (strcmp("system", args) == 0) {
ipc.opt = IDLE_PROF_OPT_SYSTEM;
@@
-425,7
+446,8
@@
int fio_idle_prof_parse_opt(const char *args)
#endif
}
#endif
}
-void show_idle_prof_stats(int output, struct json_object *parent)
+void show_idle_prof_stats(int output, struct json_object *parent,
+ struct buf_output *out)
{
int i, nr_cpus = ipc.nr_cpus;
struct json_object *tmp;
{
int i, nr_cpus = ipc.nr_cpus;
struct json_object *tmp;
@@
-433,23
+455,23
@@
void show_idle_prof_stats(int output, struct json_object *parent)
if (output == FIO_OUTPUT_NORMAL) {
if (ipc.opt > IDLE_PROF_OPT_CALI)
if (output == FIO_OUTPUT_NORMAL) {
if (ipc.opt > IDLE_PROF_OPT_CALI)
- log_
info(
"\nCPU idleness:\n");
+ log_
buf(out,
"\nCPU idleness:\n");
else if (ipc.opt == IDLE_PROF_OPT_CALI)
else if (ipc.opt == IDLE_PROF_OPT_CALI)
- log_
info(
"CPU idleness:\n");
+ log_
buf(out,
"CPU idleness:\n");
if (ipc.opt >= IDLE_PROF_OPT_SYSTEM)
if (ipc.opt >= IDLE_PROF_OPT_SYSTEM)
- log_
info(
" system: %3.2f%%\n", fio_idle_prof_cpu_stat(-1));
+ log_
buf(out,
" system: %3.2f%%\n", fio_idle_prof_cpu_stat(-1));
if (ipc.opt == IDLE_PROF_OPT_PERCPU) {
if (ipc.opt == IDLE_PROF_OPT_PERCPU) {
- log_
info(
" percpu: %3.2f%%", fio_idle_prof_cpu_stat(0));
+ log_
buf(out,
" percpu: %3.2f%%", fio_idle_prof_cpu_stat(0));
for (i = 1; i < nr_cpus; i++)
for (i = 1; i < nr_cpus; i++)
- log_
info(
", %3.2f%%", fio_idle_prof_cpu_stat(i));
- log_
info(
"\n");
+ log_
buf(out,
", %3.2f%%", fio_idle_prof_cpu_stat(i));
+ log_
buf(out,
"\n");
}
if (ipc.opt >= IDLE_PROF_OPT_CALI) {
}
if (ipc.opt >= IDLE_PROF_OPT_CALI) {
- log_
info(
" unit work: mean=%3.2fus,", ipc.cali_mean);
- log_
info(
" stddev=%3.2f\n", ipc.cali_stddev);
+ log_
buf(out,
" unit work: mean=%3.2fus,", ipc.cali_mean);
+ log_
buf(out,
" stddev=%3.2f\n", ipc.cali_stddev);
}
/* dynamic mem allocations can now be freed */
}
/* dynamic mem allocations can now be freed */
@@
-459,7
+481,7
@@
void show_idle_prof_stats(int output, struct json_object *parent)
return;
}
return;
}
- if ((ipc.opt != IDLE_PROF_OPT_NONE) && (output
==
FIO_OUTPUT_JSON)) {
+ if ((ipc.opt != IDLE_PROF_OPT_NONE) && (output
&
FIO_OUTPUT_JSON)) {
if (!parent)
return;
if (!parent)
return;