target: use stringify.h instead of own definition
[linux-2.6-block.git] / drivers / target / iscsi / iscsi_target_nego.c
1 /*******************************************************************************
2  * This file contains main functions related to iSCSI Parameter negotiation.
3  *
4  * (c) Copyright 2007-2013 Datera, Inc.
5  *
6  * Author: Nicholas A. Bellinger <nab@linux-iscsi.org>
7  *
8  * This program is free software; you can redistribute it and/or modify
9  * it under the terms of the GNU General Public License as published by
10  * the Free Software Foundation; either version 2 of the License, or
11  * (at your option) any later version.
12  *
13  * This program is distributed in the hope that it will be useful,
14  * but WITHOUT ANY WARRANTY; without even the implied warranty of
15  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
16  * GNU General Public License for more details.
17  ******************************************************************************/
18
19 #include <linux/ctype.h>
20 #include <scsi/iscsi_proto.h>
21 #include <target/target_core_base.h>
22 #include <target/target_core_fabric.h>
23 #include <target/iscsi/iscsi_transport.h>
24
25 #include <target/iscsi/iscsi_target_core.h>
26 #include "iscsi_target_parameters.h"
27 #include "iscsi_target_login.h"
28 #include "iscsi_target_nego.h"
29 #include "iscsi_target_tpg.h"
30 #include "iscsi_target_util.h"
31 #include "iscsi_target.h"
32 #include "iscsi_target_auth.h"
33
34 #define MAX_LOGIN_PDUS  7
35 #define TEXT_LEN        4096
36
37 void convert_null_to_semi(char *buf, int len)
38 {
39         int i;
40
41         for (i = 0; i < len; i++)
42                 if (buf[i] == '\0')
43                         buf[i] = ';';
44 }
45
46 static int strlen_semi(char *buf)
47 {
48         int i = 0;
49
50         while (buf[i] != '\0') {
51                 if (buf[i] == ';')
52                         return i;
53                 i++;
54         }
55
56         return -1;
57 }
58
59 int extract_param(
60         const char *in_buf,
61         const char *pattern,
62         unsigned int max_length,
63         char *out_buf,
64         unsigned char *type)
65 {
66         char *ptr;
67         int len;
68
69         if (!in_buf || !pattern || !out_buf || !type)
70                 return -1;
71
72         ptr = strstr(in_buf, pattern);
73         if (!ptr)
74                 return -1;
75
76         ptr = strstr(ptr, "=");
77         if (!ptr)
78                 return -1;
79
80         ptr += 1;
81         if (*ptr == '0' && (*(ptr+1) == 'x' || *(ptr+1) == 'X')) {
82                 ptr += 2; /* skip 0x */
83                 *type = HEX;
84         } else
85                 *type = DECIMAL;
86
87         len = strlen_semi(ptr);
88         if (len < 0)
89                 return -1;
90
91         if (len >= max_length) {
92                 pr_err("Length of input: %d exceeds max_length:"
93                         " %d\n", len, max_length);
94                 return -1;
95         }
96         memcpy(out_buf, ptr, len);
97         out_buf[len] = '\0';
98
99         return 0;
100 }
101
102 static u32 iscsi_handle_authentication(
103         struct iscsi_conn *conn,
104         char *in_buf,
105         char *out_buf,
106         int in_length,
107         int *out_length,
108         unsigned char *authtype)
109 {
110         struct iscsi_session *sess = conn->sess;
111         struct iscsi_node_auth *auth;
112         struct iscsi_node_acl *iscsi_nacl;
113         struct iscsi_portal_group *iscsi_tpg;
114         struct se_node_acl *se_nacl;
115
116         if (!sess->sess_ops->SessionType) {
117                 /*
118                  * For SessionType=Normal
119                  */
120                 se_nacl = conn->sess->se_sess->se_node_acl;
121                 if (!se_nacl) {
122                         pr_err("Unable to locate struct se_node_acl for"
123                                         " CHAP auth\n");
124                         return -1;
125                 }
126                 iscsi_nacl = container_of(se_nacl, struct iscsi_node_acl,
127                                 se_node_acl);
128                 if (!iscsi_nacl) {
129                         pr_err("Unable to locate struct iscsi_node_acl for"
130                                         " CHAP auth\n");
131                         return -1;
132                 }
133
134                 if (se_nacl->dynamic_node_acl) {
135                         iscsi_tpg = container_of(se_nacl->se_tpg,
136                                         struct iscsi_portal_group, tpg_se_tpg);
137
138                         auth = &iscsi_tpg->tpg_demo_auth;
139                 } else {
140                         iscsi_nacl = container_of(se_nacl, struct iscsi_node_acl,
141                                                   se_node_acl);
142
143                         auth = &iscsi_nacl->node_auth;
144                 }
145         } else {
146                 /*
147                  * For SessionType=Discovery
148                  */
149                 auth = &iscsit_global->discovery_acl.node_auth;
150         }
151
152         if (strstr("CHAP", authtype))
153                 strcpy(conn->sess->auth_type, "CHAP");
154         else
155                 strcpy(conn->sess->auth_type, NONE);
156
157         if (strstr("None", authtype))
158                 return 1;
159 #ifdef CANSRP
160         else if (strstr("SRP", authtype))
161                 return srp_main_loop(conn, auth, in_buf, out_buf,
162                                 &in_length, out_length);
163 #endif
164         else if (strstr("CHAP", authtype))
165                 return chap_main_loop(conn, auth, in_buf, out_buf,
166                                 &in_length, out_length);
167         else if (strstr("SPKM1", authtype))
168                 return 2;
169         else if (strstr("SPKM2", authtype))
170                 return 2;
171         else if (strstr("KRB5", authtype))
172                 return 2;
173         else
174                 return 2;
175 }
176
177 static void iscsi_remove_failed_auth_entry(struct iscsi_conn *conn)
178 {
179         kfree(conn->auth_protocol);
180 }
181
182 int iscsi_target_check_login_request(
183         struct iscsi_conn *conn,
184         struct iscsi_login *login)
185 {
186         int req_csg, req_nsg;
187         u32 payload_length;
188         struct iscsi_login_req *login_req;
189
190         login_req = (struct iscsi_login_req *) login->req;
191         payload_length = ntoh24(login_req->dlength);
192
193         switch (login_req->opcode & ISCSI_OPCODE_MASK) {
194         case ISCSI_OP_LOGIN:
195                 break;
196         default:
197                 pr_err("Received unknown opcode 0x%02x.\n",
198                                 login_req->opcode & ISCSI_OPCODE_MASK);
199                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
200                                 ISCSI_LOGIN_STATUS_INIT_ERR);
201                 return -1;
202         }
203
204         if ((login_req->flags & ISCSI_FLAG_LOGIN_CONTINUE) &&
205             (login_req->flags & ISCSI_FLAG_LOGIN_TRANSIT)) {
206                 pr_err("Login request has both ISCSI_FLAG_LOGIN_CONTINUE"
207                         " and ISCSI_FLAG_LOGIN_TRANSIT set, protocol error.\n");
208                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
209                                 ISCSI_LOGIN_STATUS_INIT_ERR);
210                 return -1;
211         }
212
213         req_csg = ISCSI_LOGIN_CURRENT_STAGE(login_req->flags);
214         req_nsg = ISCSI_LOGIN_NEXT_STAGE(login_req->flags);
215
216         if (req_csg != login->current_stage) {
217                 pr_err("Initiator unexpectedly changed login stage"
218                         " from %d to %d, login failed.\n", login->current_stage,
219                         req_csg);
220                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
221                                 ISCSI_LOGIN_STATUS_INIT_ERR);
222                 return -1;
223         }
224
225         if ((req_nsg == 2) || (req_csg >= 2) ||
226            ((login_req->flags & ISCSI_FLAG_LOGIN_TRANSIT) &&
227             (req_nsg <= req_csg))) {
228                 pr_err("Illegal login_req->flags Combination, CSG: %d,"
229                         " NSG: %d, ISCSI_FLAG_LOGIN_TRANSIT: %d.\n", req_csg,
230                         req_nsg, (login_req->flags & ISCSI_FLAG_LOGIN_TRANSIT));
231                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
232                                 ISCSI_LOGIN_STATUS_INIT_ERR);
233                 return -1;
234         }
235
236         if ((login_req->max_version != login->version_max) ||
237             (login_req->min_version != login->version_min)) {
238                 pr_err("Login request changed Version Max/Nin"
239                         " unexpectedly to 0x%02x/0x%02x, protocol error\n",
240                         login_req->max_version, login_req->min_version);
241                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
242                                 ISCSI_LOGIN_STATUS_INIT_ERR);
243                 return -1;
244         }
245
246         if (memcmp(login_req->isid, login->isid, 6) != 0) {
247                 pr_err("Login request changed ISID unexpectedly,"
248                                 " protocol error.\n");
249                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
250                                 ISCSI_LOGIN_STATUS_INIT_ERR);
251                 return -1;
252         }
253
254         if (login_req->itt != login->init_task_tag) {
255                 pr_err("Login request changed ITT unexpectedly to"
256                         " 0x%08x, protocol error.\n", login_req->itt);
257                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
258                                 ISCSI_LOGIN_STATUS_INIT_ERR);
259                 return -1;
260         }
261
262         if (payload_length > MAX_KEY_VALUE_PAIRS) {
263                 pr_err("Login request payload exceeds default"
264                         " MaxRecvDataSegmentLength: %u, protocol error.\n",
265                                 MAX_KEY_VALUE_PAIRS);
266                 return -1;
267         }
268
269         return 0;
270 }
271
272 static int iscsi_target_check_first_request(
273         struct iscsi_conn *conn,
274         struct iscsi_login *login)
275 {
276         struct iscsi_param *param = NULL;
277         struct se_node_acl *se_nacl;
278
279         login->first_request = 0;
280
281         list_for_each_entry(param, &conn->param_list->param_list, p_list) {
282                 if (!strncmp(param->name, SESSIONTYPE, 11)) {
283                         if (!IS_PSTATE_ACCEPTOR(param)) {
284                                 pr_err("SessionType key not received"
285                                         " in first login request.\n");
286                                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
287                                         ISCSI_LOGIN_STATUS_MISSING_FIELDS);
288                                 return -1;
289                         }
290                         if (!strncmp(param->value, DISCOVERY, 9))
291                                 return 0;
292                 }
293
294                 if (!strncmp(param->name, INITIATORNAME, 13)) {
295                         if (!IS_PSTATE_ACCEPTOR(param)) {
296                                 if (!login->leading_connection)
297                                         continue;
298
299                                 pr_err("InitiatorName key not received"
300                                         " in first login request.\n");
301                                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
302                                         ISCSI_LOGIN_STATUS_MISSING_FIELDS);
303                                 return -1;
304                         }
305
306                         /*
307                          * For non-leading connections, double check that the
308                          * received InitiatorName matches the existing session's
309                          * struct iscsi_node_acl.
310                          */
311                         if (!login->leading_connection) {
312                                 se_nacl = conn->sess->se_sess->se_node_acl;
313                                 if (!se_nacl) {
314                                         pr_err("Unable to locate"
315                                                 " struct se_node_acl\n");
316                                         iscsit_tx_login_rsp(conn,
317                                                         ISCSI_STATUS_CLS_INITIATOR_ERR,
318                                                         ISCSI_LOGIN_STATUS_TGT_NOT_FOUND);
319                                         return -1;
320                                 }
321
322                                 if (strcmp(param->value,
323                                                 se_nacl->initiatorname)) {
324                                         pr_err("Incorrect"
325                                                 " InitiatorName: %s for this"
326                                                 " iSCSI Initiator Node.\n",
327                                                 param->value);
328                                         iscsit_tx_login_rsp(conn,
329                                                         ISCSI_STATUS_CLS_INITIATOR_ERR,
330                                                         ISCSI_LOGIN_STATUS_TGT_NOT_FOUND);
331                                         return -1;
332                                 }
333                         }
334                 }
335         }
336
337         return 0;
338 }
339
340 static int iscsi_target_do_tx_login_io(struct iscsi_conn *conn, struct iscsi_login *login)
341 {
342         u32 padding = 0;
343         struct iscsi_login_rsp *login_rsp;
344
345         login_rsp = (struct iscsi_login_rsp *) login->rsp;
346
347         login_rsp->opcode               = ISCSI_OP_LOGIN_RSP;
348         hton24(login_rsp->dlength, login->rsp_length);
349         memcpy(login_rsp->isid, login->isid, 6);
350         login_rsp->tsih                 = cpu_to_be16(login->tsih);
351         login_rsp->itt                  = login->init_task_tag;
352         login_rsp->statsn               = cpu_to_be32(conn->stat_sn++);
353         login_rsp->exp_cmdsn            = cpu_to_be32(conn->sess->exp_cmd_sn);
354         login_rsp->max_cmdsn            = cpu_to_be32((u32) atomic_read(&conn->sess->max_cmd_sn));
355
356         pr_debug("Sending Login Response, Flags: 0x%02x, ITT: 0x%08x,"
357                 " ExpCmdSN; 0x%08x, MaxCmdSN: 0x%08x, StatSN: 0x%08x, Length:"
358                 " %u\n", login_rsp->flags, (__force u32)login_rsp->itt,
359                 ntohl(login_rsp->exp_cmdsn), ntohl(login_rsp->max_cmdsn),
360                 ntohl(login_rsp->statsn), login->rsp_length);
361
362         padding = ((-login->rsp_length) & 3);
363
364         if (conn->conn_transport->iscsit_put_login_tx(conn, login,
365                                         login->rsp_length + padding) < 0)
366                 return -1;
367
368         login->rsp_length               = 0;
369
370         return 0;
371 }
372
373 static void iscsi_target_sk_data_ready(struct sock *sk)
374 {
375         struct iscsi_conn *conn = sk->sk_user_data;
376         bool rc;
377
378         pr_debug("Entering iscsi_target_sk_data_ready: conn: %p\n", conn);
379
380         write_lock_bh(&sk->sk_callback_lock);
381         if (!sk->sk_user_data) {
382                 write_unlock_bh(&sk->sk_callback_lock);
383                 return;
384         }
385         if (!test_bit(LOGIN_FLAGS_READY, &conn->login_flags)) {
386                 write_unlock_bh(&sk->sk_callback_lock);
387                 pr_debug("Got LOGIN_FLAGS_READY=0, conn: %p >>>>\n", conn);
388                 return;
389         }
390         if (test_bit(LOGIN_FLAGS_CLOSED, &conn->login_flags)) {
391                 write_unlock_bh(&sk->sk_callback_lock);
392                 pr_debug("Got LOGIN_FLAGS_CLOSED=1, conn: %p >>>>\n", conn);
393                 return;
394         }
395         if (test_and_set_bit(LOGIN_FLAGS_READ_ACTIVE, &conn->login_flags)) {
396                 write_unlock_bh(&sk->sk_callback_lock);
397                 pr_debug("Got LOGIN_FLAGS_READ_ACTIVE=1, conn: %p >>>>\n", conn);
398                 return;
399         }
400
401         rc = schedule_delayed_work(&conn->login_work, 0);
402         if (!rc) {
403                 pr_debug("iscsi_target_sk_data_ready, schedule_delayed_work"
404                          " got false\n");
405         }
406         write_unlock_bh(&sk->sk_callback_lock);
407 }
408
409 static void iscsi_target_sk_state_change(struct sock *);
410
411 static void iscsi_target_set_sock_callbacks(struct iscsi_conn *conn)
412 {
413         struct sock *sk;
414
415         if (!conn->sock)
416                 return;
417
418         sk = conn->sock->sk;
419         pr_debug("Entering iscsi_target_set_sock_callbacks: conn: %p\n", conn);
420
421         write_lock_bh(&sk->sk_callback_lock);
422         sk->sk_user_data = conn;
423         conn->orig_data_ready = sk->sk_data_ready;
424         conn->orig_state_change = sk->sk_state_change;
425         sk->sk_data_ready = iscsi_target_sk_data_ready;
426         sk->sk_state_change = iscsi_target_sk_state_change;
427         write_unlock_bh(&sk->sk_callback_lock);
428
429         sk->sk_sndtimeo = TA_LOGIN_TIMEOUT * HZ;
430         sk->sk_rcvtimeo = TA_LOGIN_TIMEOUT * HZ;
431 }
432
433 static void iscsi_target_restore_sock_callbacks(struct iscsi_conn *conn)
434 {
435         struct sock *sk;
436
437         if (!conn->sock)
438                 return;
439
440         sk = conn->sock->sk;
441         pr_debug("Entering iscsi_target_restore_sock_callbacks: conn: %p\n", conn);
442
443         write_lock_bh(&sk->sk_callback_lock);
444         if (!sk->sk_user_data) {
445                 write_unlock_bh(&sk->sk_callback_lock);
446                 return;
447         }
448         sk->sk_user_data = NULL;
449         sk->sk_data_ready = conn->orig_data_ready;
450         sk->sk_state_change = conn->orig_state_change;
451         write_unlock_bh(&sk->sk_callback_lock);
452
453         sk->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT;
454         sk->sk_rcvtimeo = MAX_SCHEDULE_TIMEOUT;
455 }
456
457 static int iscsi_target_do_login(struct iscsi_conn *, struct iscsi_login *);
458
459 static bool iscsi_target_sk_state_check(struct sock *sk)
460 {
461         if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) {
462                 pr_debug("iscsi_target_sk_state_check: TCP_CLOSE_WAIT|TCP_CLOSE,"
463                         "returning FALSE\n");
464                 return false;
465         }
466         return true;
467 }
468
469 static void iscsi_target_login_drop(struct iscsi_conn *conn, struct iscsi_login *login)
470 {
471         struct iscsi_np *np = login->np;
472         bool zero_tsih = login->zero_tsih;
473
474         iscsi_remove_failed_auth_entry(conn);
475         iscsi_target_nego_release(conn);
476         iscsi_target_login_sess_out(conn, np, zero_tsih, true);
477 }
478
479 static void iscsi_target_login_timeout(unsigned long data)
480 {
481         struct iscsi_conn *conn = (struct iscsi_conn *)data;
482
483         pr_debug("Entering iscsi_target_login_timeout >>>>>>>>>>>>>>>>>>>\n");
484
485         if (conn->login_kworker) {
486                 pr_debug("Sending SIGINT to conn->login_kworker %s/%d\n",
487                          conn->login_kworker->comm, conn->login_kworker->pid);
488                 send_sig(SIGINT, conn->login_kworker, 1);
489         }
490 }
491
492 static void iscsi_target_do_login_rx(struct work_struct *work)
493 {
494         struct iscsi_conn *conn = container_of(work,
495                                 struct iscsi_conn, login_work.work);
496         struct iscsi_login *login = conn->login;
497         struct iscsi_np *np = login->np;
498         struct iscsi_portal_group *tpg = conn->tpg;
499         struct iscsi_tpg_np *tpg_np = conn->tpg_np;
500         struct timer_list login_timer;
501         int rc, zero_tsih = login->zero_tsih;
502         bool state;
503
504         pr_debug("entering iscsi_target_do_login_rx, conn: %p, %s:%d\n",
505                         conn, current->comm, current->pid);
506
507         spin_lock(&tpg->tpg_state_lock);
508         state = (tpg->tpg_state == TPG_STATE_ACTIVE);
509         spin_unlock(&tpg->tpg_state_lock);
510
511         if (!state) {
512                 pr_debug("iscsi_target_do_login_rx: tpg_state != TPG_STATE_ACTIVE\n");
513                 iscsi_target_restore_sock_callbacks(conn);
514                 iscsi_target_login_drop(conn, login);
515                 iscsit_deaccess_np(np, tpg, tpg_np);
516                 return;
517         }
518
519         if (conn->sock) {
520                 struct sock *sk = conn->sock->sk;
521
522                 read_lock_bh(&sk->sk_callback_lock);
523                 state = iscsi_target_sk_state_check(sk);
524                 read_unlock_bh(&sk->sk_callback_lock);
525
526                 if (!state) {
527                         pr_debug("iscsi_target_do_login_rx, TCP state CLOSE\n");
528                         iscsi_target_restore_sock_callbacks(conn);
529                         iscsi_target_login_drop(conn, login);
530                         iscsit_deaccess_np(np, tpg, tpg_np);
531                         return;
532                 }
533         }
534
535         conn->login_kworker = current;
536         allow_signal(SIGINT);
537
538         init_timer(&login_timer);
539         login_timer.expires = (get_jiffies_64() + TA_LOGIN_TIMEOUT * HZ);
540         login_timer.data = (unsigned long)conn;
541         login_timer.function = iscsi_target_login_timeout;
542         add_timer(&login_timer);
543         pr_debug("Starting login_timer for %s/%d\n", current->comm, current->pid);
544
545         rc = conn->conn_transport->iscsit_get_login_rx(conn, login);
546         del_timer_sync(&login_timer);
547         flush_signals(current);
548         conn->login_kworker = NULL;
549
550         if (rc < 0) {
551                 iscsi_target_restore_sock_callbacks(conn);
552                 iscsi_target_login_drop(conn, login);
553                 iscsit_deaccess_np(np, tpg, tpg_np);
554                 return;
555         }
556
557         pr_debug("iscsi_target_do_login_rx after rx_login_io, %p, %s:%d\n",
558                         conn, current->comm, current->pid);
559
560         rc = iscsi_target_do_login(conn, login);
561         if (rc < 0) {
562                 iscsi_target_restore_sock_callbacks(conn);
563                 iscsi_target_login_drop(conn, login);
564                 iscsit_deaccess_np(np, tpg, tpg_np);
565         } else if (!rc) {
566                 if (conn->sock) {
567                         struct sock *sk = conn->sock->sk;
568
569                         write_lock_bh(&sk->sk_callback_lock);
570                         clear_bit(LOGIN_FLAGS_READ_ACTIVE, &conn->login_flags);
571                         write_unlock_bh(&sk->sk_callback_lock);
572                 }
573         } else if (rc == 1) {
574                 iscsi_target_nego_release(conn);
575                 iscsi_post_login_handler(np, conn, zero_tsih);
576                 iscsit_deaccess_np(np, tpg, tpg_np);
577         }
578 }
579
580 static void iscsi_target_do_cleanup(struct work_struct *work)
581 {
582         struct iscsi_conn *conn = container_of(work,
583                                 struct iscsi_conn, login_cleanup_work.work);
584         struct sock *sk = conn->sock->sk;
585         struct iscsi_login *login = conn->login;
586         struct iscsi_np *np = login->np;
587         struct iscsi_portal_group *tpg = conn->tpg;
588         struct iscsi_tpg_np *tpg_np = conn->tpg_np;
589
590         pr_debug("Entering iscsi_target_do_cleanup\n");
591
592         cancel_delayed_work_sync(&conn->login_work);
593         conn->orig_state_change(sk);
594
595         iscsi_target_restore_sock_callbacks(conn);
596         iscsi_target_login_drop(conn, login);
597         iscsit_deaccess_np(np, tpg, tpg_np);
598
599         pr_debug("iscsi_target_do_cleanup done()\n");
600 }
601
602 static void iscsi_target_sk_state_change(struct sock *sk)
603 {
604         struct iscsi_conn *conn;
605         void (*orig_state_change)(struct sock *);
606         bool state;
607
608         pr_debug("Entering iscsi_target_sk_state_change\n");
609
610         write_lock_bh(&sk->sk_callback_lock);
611         conn = sk->sk_user_data;
612         if (!conn) {
613                 write_unlock_bh(&sk->sk_callback_lock);
614                 return;
615         }
616         orig_state_change = conn->orig_state_change;
617
618         if (!test_bit(LOGIN_FLAGS_READY, &conn->login_flags)) {
619                 pr_debug("Got LOGIN_FLAGS_READY=0 sk_state_change conn: %p\n",
620                          conn);
621                 write_unlock_bh(&sk->sk_callback_lock);
622                 orig_state_change(sk);
623                 return;
624         }
625         if (test_bit(LOGIN_FLAGS_READ_ACTIVE, &conn->login_flags)) {
626                 pr_debug("Got LOGIN_FLAGS_READ_ACTIVE=1 sk_state_change"
627                          " conn: %p\n", conn);
628                 write_unlock_bh(&sk->sk_callback_lock);
629                 orig_state_change(sk);
630                 return;
631         }
632         if (test_and_set_bit(LOGIN_FLAGS_CLOSED, &conn->login_flags)) {
633                 pr_debug("Got LOGIN_FLAGS_CLOSED=1 sk_state_change conn: %p\n",
634                          conn);
635                 write_unlock_bh(&sk->sk_callback_lock);
636                 orig_state_change(sk);
637                 return;
638         }
639
640         state = iscsi_target_sk_state_check(sk);
641         write_unlock_bh(&sk->sk_callback_lock);
642
643         pr_debug("iscsi_target_sk_state_change: state: %d\n", state);
644
645         if (!state) {
646                 pr_debug("iscsi_target_sk_state_change got failed state\n");
647                 schedule_delayed_work(&conn->login_cleanup_work, 0);
648                 return;
649         }
650         orig_state_change(sk);
651 }
652
653 /*
654  *      NOTE: We check for existing sessions or connections AFTER the initiator
655  *      has been successfully authenticated in order to protect against faked
656  *      ISID/TSIH combinations.
657  */
658 static int iscsi_target_check_for_existing_instances(
659         struct iscsi_conn *conn,
660         struct iscsi_login *login)
661 {
662         if (login->checked_for_existing)
663                 return 0;
664
665         login->checked_for_existing = 1;
666
667         if (!login->tsih)
668                 return iscsi_check_for_session_reinstatement(conn);
669         else
670                 return iscsi_login_post_auth_non_zero_tsih(conn, login->cid,
671                                 login->initial_exp_statsn);
672 }
673
674 static int iscsi_target_do_authentication(
675         struct iscsi_conn *conn,
676         struct iscsi_login *login)
677 {
678         int authret;
679         u32 payload_length;
680         struct iscsi_param *param;
681         struct iscsi_login_req *login_req;
682         struct iscsi_login_rsp *login_rsp;
683
684         login_req = (struct iscsi_login_req *) login->req;
685         login_rsp = (struct iscsi_login_rsp *) login->rsp;
686         payload_length = ntoh24(login_req->dlength);
687
688         param = iscsi_find_param_from_key(AUTHMETHOD, conn->param_list);
689         if (!param)
690                 return -1;
691
692         authret = iscsi_handle_authentication(
693                         conn,
694                         login->req_buf,
695                         login->rsp_buf,
696                         payload_length,
697                         &login->rsp_length,
698                         param->value);
699         switch (authret) {
700         case 0:
701                 pr_debug("Received OK response"
702                 " from LIO Authentication, continuing.\n");
703                 break;
704         case 1:
705                 pr_debug("iSCSI security negotiation"
706                         " completed successfully.\n");
707                 login->auth_complete = 1;
708                 if ((login_req->flags & ISCSI_FLAG_LOGIN_NEXT_STAGE1) &&
709                     (login_req->flags & ISCSI_FLAG_LOGIN_TRANSIT)) {
710                         login_rsp->flags |= (ISCSI_FLAG_LOGIN_NEXT_STAGE1 |
711                                              ISCSI_FLAG_LOGIN_TRANSIT);
712                         login->current_stage = 1;
713                 }
714                 return iscsi_target_check_for_existing_instances(
715                                 conn, login);
716         case 2:
717                 pr_err("Security negotiation"
718                         " failed.\n");
719                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
720                                 ISCSI_LOGIN_STATUS_AUTH_FAILED);
721                 return -1;
722         default:
723                 pr_err("Received unknown error %d from LIO"
724                                 " Authentication\n", authret);
725                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
726                                 ISCSI_LOGIN_STATUS_TARGET_ERROR);
727                 return -1;
728         }
729
730         return 0;
731 }
732
733 static int iscsi_target_handle_csg_zero(
734         struct iscsi_conn *conn,
735         struct iscsi_login *login)
736 {
737         int ret;
738         u32 payload_length;
739         struct iscsi_param *param;
740         struct iscsi_login_req *login_req;
741         struct iscsi_login_rsp *login_rsp;
742
743         login_req = (struct iscsi_login_req *) login->req;
744         login_rsp = (struct iscsi_login_rsp *) login->rsp;
745         payload_length = ntoh24(login_req->dlength);
746
747         param = iscsi_find_param_from_key(AUTHMETHOD, conn->param_list);
748         if (!param)
749                 return -1;
750
751         ret = iscsi_decode_text_input(
752                         PHASE_SECURITY|PHASE_DECLARATIVE,
753                         SENDER_INITIATOR|SENDER_RECEIVER,
754                         login->req_buf,
755                         payload_length,
756                         conn);
757         if (ret < 0)
758                 return -1;
759
760         if (ret > 0) {
761                 if (login->auth_complete) {
762                         pr_err("Initiator has already been"
763                                 " successfully authenticated, but is still"
764                                 " sending %s keys.\n", param->value);
765                         iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
766                                         ISCSI_LOGIN_STATUS_INIT_ERR);
767                         return -1;
768                 }
769
770                 goto do_auth;
771         } else if (!payload_length) {
772                 pr_err("Initiator sent zero length security payload,"
773                        " login failed\n");
774                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
775                                     ISCSI_LOGIN_STATUS_AUTH_FAILED);
776                 return -1;
777         }
778
779         if (login->first_request)
780                 if (iscsi_target_check_first_request(conn, login) < 0)
781                         return -1;
782
783         ret = iscsi_encode_text_output(
784                         PHASE_SECURITY|PHASE_DECLARATIVE,
785                         SENDER_TARGET,
786                         login->rsp_buf,
787                         &login->rsp_length,
788                         conn->param_list);
789         if (ret < 0)
790                 return -1;
791
792         if (!iscsi_check_negotiated_keys(conn->param_list)) {
793                 if (conn->tpg->tpg_attrib.authentication &&
794                     !strncmp(param->value, NONE, 4)) {
795                         pr_err("Initiator sent AuthMethod=None but"
796                                 " Target is enforcing iSCSI Authentication,"
797                                         " login failed.\n");
798                         iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
799                                         ISCSI_LOGIN_STATUS_AUTH_FAILED);
800                         return -1;
801                 }
802
803                 if (conn->tpg->tpg_attrib.authentication &&
804                     !login->auth_complete)
805                         return 0;
806
807                 if (strncmp(param->value, NONE, 4) && !login->auth_complete)
808                         return 0;
809
810                 if ((login_req->flags & ISCSI_FLAG_LOGIN_NEXT_STAGE1) &&
811                     (login_req->flags & ISCSI_FLAG_LOGIN_TRANSIT)) {
812                         login_rsp->flags |= ISCSI_FLAG_LOGIN_NEXT_STAGE1 |
813                                             ISCSI_FLAG_LOGIN_TRANSIT;
814                         login->current_stage = 1;
815                 }
816         }
817
818         return 0;
819 do_auth:
820         return iscsi_target_do_authentication(conn, login);
821 }
822
823 static int iscsi_target_handle_csg_one(struct iscsi_conn *conn, struct iscsi_login *login)
824 {
825         int ret;
826         u32 payload_length;
827         struct iscsi_login_req *login_req;
828         struct iscsi_login_rsp *login_rsp;
829
830         login_req = (struct iscsi_login_req *) login->req;
831         login_rsp = (struct iscsi_login_rsp *) login->rsp;
832         payload_length = ntoh24(login_req->dlength);
833
834         ret = iscsi_decode_text_input(
835                         PHASE_OPERATIONAL|PHASE_DECLARATIVE,
836                         SENDER_INITIATOR|SENDER_RECEIVER,
837                         login->req_buf,
838                         payload_length,
839                         conn);
840         if (ret < 0) {
841                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
842                                 ISCSI_LOGIN_STATUS_INIT_ERR);
843                 return -1;
844         }
845
846         if (login->first_request)
847                 if (iscsi_target_check_first_request(conn, login) < 0)
848                         return -1;
849
850         if (iscsi_target_check_for_existing_instances(conn, login) < 0)
851                 return -1;
852
853         ret = iscsi_encode_text_output(
854                         PHASE_OPERATIONAL|PHASE_DECLARATIVE,
855                         SENDER_TARGET,
856                         login->rsp_buf,
857                         &login->rsp_length,
858                         conn->param_list);
859         if (ret < 0) {
860                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
861                                 ISCSI_LOGIN_STATUS_INIT_ERR);
862                 return -1;
863         }
864
865         if (!login->auth_complete &&
866              conn->tpg->tpg_attrib.authentication) {
867                 pr_err("Initiator is requesting CSG: 1, has not been"
868                          " successfully authenticated, and the Target is"
869                         " enforcing iSCSI Authentication, login failed.\n");
870                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
871                                 ISCSI_LOGIN_STATUS_AUTH_FAILED);
872                 return -1;
873         }
874
875         if (!iscsi_check_negotiated_keys(conn->param_list))
876                 if ((login_req->flags & ISCSI_FLAG_LOGIN_NEXT_STAGE3) &&
877                     (login_req->flags & ISCSI_FLAG_LOGIN_TRANSIT))
878                         login_rsp->flags |= ISCSI_FLAG_LOGIN_NEXT_STAGE3 |
879                                             ISCSI_FLAG_LOGIN_TRANSIT;
880
881         return 0;
882 }
883
884 static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *login)
885 {
886         int pdu_count = 0;
887         struct iscsi_login_req *login_req;
888         struct iscsi_login_rsp *login_rsp;
889
890         login_req = (struct iscsi_login_req *) login->req;
891         login_rsp = (struct iscsi_login_rsp *) login->rsp;
892
893         while (1) {
894                 if (++pdu_count > MAX_LOGIN_PDUS) {
895                         pr_err("MAX_LOGIN_PDUS count reached.\n");
896                         iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
897                                         ISCSI_LOGIN_STATUS_TARGET_ERROR);
898                         return -1;
899                 }
900
901                 switch (ISCSI_LOGIN_CURRENT_STAGE(login_req->flags)) {
902                 case 0:
903                         login_rsp->flags &= ~ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK;
904                         if (iscsi_target_handle_csg_zero(conn, login) < 0)
905                                 return -1;
906                         break;
907                 case 1:
908                         login_rsp->flags |= ISCSI_FLAG_LOGIN_CURRENT_STAGE1;
909                         if (iscsi_target_handle_csg_one(conn, login) < 0)
910                                 return -1;
911                         if (login_rsp->flags & ISCSI_FLAG_LOGIN_TRANSIT) {
912                                 login->tsih = conn->sess->tsih;
913                                 login->login_complete = 1;
914                                 iscsi_target_restore_sock_callbacks(conn);
915                                 if (iscsi_target_do_tx_login_io(conn,
916                                                 login) < 0)
917                                         return -1;
918                                 return 1;
919                         }
920                         break;
921                 default:
922                         pr_err("Illegal CSG: %d received from"
923                                 " Initiator, protocol error.\n",
924                                 ISCSI_LOGIN_CURRENT_STAGE(login_req->flags));
925                         break;
926                 }
927
928                 if (iscsi_target_do_tx_login_io(conn, login) < 0)
929                         return -1;
930
931                 if (login_rsp->flags & ISCSI_FLAG_LOGIN_TRANSIT) {
932                         login_rsp->flags &= ~ISCSI_FLAG_LOGIN_TRANSIT;
933                         login_rsp->flags &= ~ISCSI_FLAG_LOGIN_NEXT_STAGE_MASK;
934                 }
935                 break;
936         }
937
938         if (conn->sock) {
939                 struct sock *sk = conn->sock->sk;
940                 bool state;
941
942                 read_lock_bh(&sk->sk_callback_lock);
943                 state = iscsi_target_sk_state_check(sk);
944                 read_unlock_bh(&sk->sk_callback_lock);
945
946                 if (!state) {
947                         pr_debug("iscsi_target_do_login() failed state for"
948                                  " conn: %p\n", conn);
949                         return -1;
950                 }
951         }
952
953         return 0;
954 }
955
956 static void iscsi_initiatorname_tolower(
957         char *param_buf)
958 {
959         char *c;
960         u32 iqn_size = strlen(param_buf), i;
961
962         for (i = 0; i < iqn_size; i++) {
963                 c = &param_buf[i];
964                 if (!isupper(*c))
965                         continue;
966
967                 *c = tolower(*c);
968         }
969 }
970
971 /*
972  * Processes the first Login Request..
973  */
974 int iscsi_target_locate_portal(
975         struct iscsi_np *np,
976         struct iscsi_conn *conn,
977         struct iscsi_login *login)
978 {
979         char *i_buf = NULL, *s_buf = NULL, *t_buf = NULL;
980         char *tmpbuf, *start = NULL, *end = NULL, *key, *value;
981         struct iscsi_session *sess = conn->sess;
982         struct iscsi_tiqn *tiqn;
983         struct iscsi_tpg_np *tpg_np = NULL;
984         struct iscsi_login_req *login_req;
985         struct se_node_acl *se_nacl;
986         u32 payload_length, queue_depth = 0;
987         int sessiontype = 0, ret = 0, tag_num, tag_size;
988
989         INIT_DELAYED_WORK(&conn->login_work, iscsi_target_do_login_rx);
990         INIT_DELAYED_WORK(&conn->login_cleanup_work, iscsi_target_do_cleanup);
991         iscsi_target_set_sock_callbacks(conn);
992
993         login->np = np;
994
995         login_req = (struct iscsi_login_req *) login->req;
996         payload_length = ntoh24(login_req->dlength);
997
998         tmpbuf = kzalloc(payload_length + 1, GFP_KERNEL);
999         if (!tmpbuf) {
1000                 pr_err("Unable to allocate memory for tmpbuf.\n");
1001                 return -1;
1002         }
1003
1004         memcpy(tmpbuf, login->req_buf, payload_length);
1005         tmpbuf[payload_length] = '\0';
1006         start = tmpbuf;
1007         end = (start + payload_length);
1008
1009         /*
1010          * Locate the initial keys expected from the Initiator node in
1011          * the first login request in order to progress with the login phase.
1012          */
1013         while (start < end) {
1014                 if (iscsi_extract_key_value(start, &key, &value) < 0) {
1015                         ret = -1;
1016                         goto out;
1017                 }
1018
1019                 if (!strncmp(key, "InitiatorName", 13))
1020                         i_buf = value;
1021                 else if (!strncmp(key, "SessionType", 11))
1022                         s_buf = value;
1023                 else if (!strncmp(key, "TargetName", 10))
1024                         t_buf = value;
1025
1026                 start += strlen(key) + strlen(value) + 2;
1027         }
1028         /*
1029          * See 5.3.  Login Phase.
1030          */
1031         if (!i_buf) {
1032                 pr_err("InitiatorName key not received"
1033                         " in first login request.\n");
1034                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
1035                         ISCSI_LOGIN_STATUS_MISSING_FIELDS);
1036                 ret = -1;
1037                 goto out;
1038         }
1039         /*
1040          * Convert the incoming InitiatorName to lowercase following
1041          * RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs
1042          * are NOT case sensitive.
1043          */
1044         iscsi_initiatorname_tolower(i_buf);
1045
1046         if (!s_buf) {
1047                 if (!login->leading_connection)
1048                         goto get_target;
1049
1050                 pr_err("SessionType key not received"
1051                         " in first login request.\n");
1052                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
1053                         ISCSI_LOGIN_STATUS_MISSING_FIELDS);
1054                 ret = -1;
1055                 goto out;
1056         }
1057
1058         /*
1059          * Use default portal group for discovery sessions.
1060          */
1061         sessiontype = strncmp(s_buf, DISCOVERY, 9);
1062         if (!sessiontype) {
1063                 conn->tpg = iscsit_global->discovery_tpg;
1064                 if (!login->leading_connection)
1065                         goto get_target;
1066
1067                 sess->sess_ops->SessionType = 1;
1068                 /*
1069                  * Setup crc32c modules from libcrypto
1070                  */
1071                 if (iscsi_login_setup_crypto(conn) < 0) {
1072                         pr_err("iscsi_login_setup_crypto() failed\n");
1073                         ret = -1;
1074                         goto out;
1075                 }
1076                 /*
1077                  * Serialize access across the discovery struct iscsi_portal_group to
1078                  * process login attempt.
1079                  */
1080                 if (iscsit_access_np(np, conn->tpg) < 0) {
1081                         iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
1082                                 ISCSI_LOGIN_STATUS_SVC_UNAVAILABLE);
1083                         ret = -1;
1084                         goto out;
1085                 }
1086                 ret = 0;
1087                 goto alloc_tags;
1088         }
1089
1090 get_target:
1091         if (!t_buf) {
1092                 pr_err("TargetName key not received"
1093                         " in first login request while"
1094                         " SessionType=Normal.\n");
1095                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
1096                         ISCSI_LOGIN_STATUS_MISSING_FIELDS);
1097                 ret = -1;
1098                 goto out;
1099         }
1100
1101         /*
1102          * Locate Target IQN from Storage Node.
1103          */
1104         tiqn = iscsit_get_tiqn_for_login(t_buf);
1105         if (!tiqn) {
1106                 pr_err("Unable to locate Target IQN: %s in"
1107                         " Storage Node\n", t_buf);
1108                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
1109                                 ISCSI_LOGIN_STATUS_SVC_UNAVAILABLE);
1110                 ret = -1;
1111                 goto out;
1112         }
1113         pr_debug("Located Storage Object: %s\n", tiqn->tiqn);
1114
1115         /*
1116          * Locate Target Portal Group from Storage Node.
1117          */
1118         conn->tpg = iscsit_get_tpg_from_np(tiqn, np, &tpg_np);
1119         if (!conn->tpg) {
1120                 pr_err("Unable to locate Target Portal Group"
1121                                 " on %s\n", tiqn->tiqn);
1122                 iscsit_put_tiqn_for_login(tiqn);
1123                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
1124                                 ISCSI_LOGIN_STATUS_SVC_UNAVAILABLE);
1125                 ret = -1;
1126                 goto out;
1127         }
1128         conn->tpg_np = tpg_np;
1129         pr_debug("Located Portal Group Object: %hu\n", conn->tpg->tpgt);
1130         /*
1131          * Setup crc32c modules from libcrypto
1132          */
1133         if (iscsi_login_setup_crypto(conn) < 0) {
1134                 pr_err("iscsi_login_setup_crypto() failed\n");
1135                 kref_put(&tpg_np->tpg_np_kref, iscsit_login_kref_put);
1136                 iscsit_put_tiqn_for_login(tiqn);
1137                 conn->tpg = NULL;
1138                 ret = -1;
1139                 goto out;
1140         }
1141         /*
1142          * Serialize access across the struct iscsi_portal_group to
1143          * process login attempt.
1144          */
1145         if (iscsit_access_np(np, conn->tpg) < 0) {
1146                 kref_put(&tpg_np->tpg_np_kref, iscsit_login_kref_put);
1147                 iscsit_put_tiqn_for_login(tiqn);
1148                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
1149                                 ISCSI_LOGIN_STATUS_SVC_UNAVAILABLE);
1150                 conn->tpg = NULL;
1151                 ret = -1;
1152                 goto out;
1153         }
1154
1155         /*
1156          * conn->sess->node_acl will be set when the referenced
1157          * struct iscsi_session is located from received ISID+TSIH in
1158          * iscsi_login_non_zero_tsih_s2().
1159          */
1160         if (!login->leading_connection) {
1161                 ret = 0;
1162                 goto out;
1163         }
1164
1165         /*
1166          * This value is required in iscsi_login_zero_tsih_s2()
1167          */
1168         sess->sess_ops->SessionType = 0;
1169
1170         /*
1171          * Locate incoming Initiator IQN reference from Storage Node.
1172          */
1173         sess->se_sess->se_node_acl = core_tpg_check_initiator_node_acl(
1174                         &conn->tpg->tpg_se_tpg, i_buf);
1175         if (!sess->se_sess->se_node_acl) {
1176                 pr_err("iSCSI Initiator Node: %s is not authorized to"
1177                         " access iSCSI target portal group: %hu.\n",
1178                                 i_buf, conn->tpg->tpgt);
1179                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_INITIATOR_ERR,
1180                                 ISCSI_LOGIN_STATUS_TGT_FORBIDDEN);
1181                 ret = -1;
1182                 goto out;
1183         }
1184         se_nacl = sess->se_sess->se_node_acl;
1185         queue_depth = se_nacl->queue_depth;
1186         /*
1187          * Setup pre-allocated tags based upon allowed per NodeACL CmdSN
1188          * depth for non immediate commands, plus extra tags for immediate
1189          * commands.
1190          *
1191          * Also enforce a ISCSIT_MIN_TAGS to prevent unnecessary contention
1192          * in per-cpu-ida tag allocation logic + small queue_depth.
1193          */
1194 alloc_tags:
1195         tag_num = max_t(u32, ISCSIT_MIN_TAGS, queue_depth);
1196         tag_num = (tag_num * 2) + ISCSIT_EXTRA_TAGS;
1197         tag_size = sizeof(struct iscsi_cmd) + conn->conn_transport->priv_size;
1198
1199         ret = transport_alloc_session_tags(sess->se_sess, tag_num, tag_size);
1200         if (ret < 0) {
1201                 iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
1202                                     ISCSI_LOGIN_STATUS_NO_RESOURCES);
1203                 ret = -1;
1204         }
1205 out:
1206         kfree(tmpbuf);
1207         return ret;
1208 }
1209
1210 int iscsi_target_start_negotiation(
1211         struct iscsi_login *login,
1212         struct iscsi_conn *conn)
1213 {
1214         int ret;
1215
1216         ret = iscsi_target_do_login(conn, login);
1217         if (!ret) {
1218                 if (conn->sock) {
1219                         struct sock *sk = conn->sock->sk;
1220
1221                         write_lock_bh(&sk->sk_callback_lock);
1222                         set_bit(LOGIN_FLAGS_READY, &conn->login_flags);
1223                         write_unlock_bh(&sk->sk_callback_lock);
1224                 }
1225         } else if (ret < 0) {
1226                 cancel_delayed_work_sync(&conn->login_work);
1227                 cancel_delayed_work_sync(&conn->login_cleanup_work);
1228                 iscsi_target_restore_sock_callbacks(conn);
1229                 iscsi_remove_failed_auth_entry(conn);
1230         }
1231         if (ret != 0)
1232                 iscsi_target_nego_release(conn);
1233
1234         return ret;
1235 }
1236
1237 void iscsi_target_nego_release(struct iscsi_conn *conn)
1238 {
1239         struct iscsi_login *login = conn->conn_login;
1240
1241         if (!login)
1242                 return;
1243
1244         kfree(login->req_buf);
1245         kfree(login->rsp_buf);
1246         kfree(login);
1247
1248         conn->conn_login = NULL;
1249 }