Commit | Line | Data |
---|---|---|
736ec752 JJ |
1 | /* |
2 | * AppArmor security module | |
3 | * | |
4 | * This file contains AppArmor functions for unpacking policy loaded from | |
5 | * userspace. | |
6 | * | |
7 | * Copyright (C) 1998-2008 Novell/SUSE | |
8 | * Copyright 2009-2010 Canonical Ltd. | |
9 | * | |
10 | * This program is free software; you can redistribute it and/or | |
11 | * modify it under the terms of the GNU General Public License as | |
12 | * published by the Free Software Foundation, version 2 of the | |
13 | * License. | |
14 | * | |
d410fa4e | 15 | * AppArmor uses a serialized binary format for loading policy. To find |
26fccd9e | 16 | * policy format documentation see Documentation/admin-guide/LSM/apparmor.rst |
736ec752 JJ |
17 | * All policy is validated before it is used. |
18 | */ | |
19 | ||
20 | #include <asm/unaligned.h> | |
21 | #include <linux/ctype.h> | |
22 | #include <linux/errno.h> | |
23 | ||
24 | #include "include/apparmor.h" | |
25 | #include "include/audit.h" | |
d8889d49 | 26 | #include "include/cred.h" |
f8eb8a13 | 27 | #include "include/crypto.h" |
736ec752 | 28 | #include "include/match.h" |
637f688d | 29 | #include "include/path.h" |
736ec752 JJ |
30 | #include "include/policy.h" |
31 | #include "include/policy_unpack.h" | |
736ec752 | 32 | |
474d6b75 | 33 | #define K_ABI_MASK 0x3ff |
5ebfb128 | 34 | #define FORCE_COMPLAIN_FLAG 0x800 |
474d6b75 JJ |
35 | #define VERSION_LT(X, Y) (((X) & K_ABI_MASK) < ((Y) & K_ABI_MASK)) |
36 | #define VERSION_GT(X, Y) (((X) & K_ABI_MASK) > ((Y) & K_ABI_MASK)) | |
37 | ||
38 | #define v5 5 /* base version */ | |
39 | #define v6 6 /* per entry policydb mediation check */ | |
56974a6f JJ |
40 | #define v7 7 |
41 | #define v8 8 /* full network masking */ | |
5ebfb128 | 42 | |
736ec752 JJ |
43 | /* |
44 | * The AppArmor interface treats data as a type byte followed by the | |
45 | * actual data. The interface has the notion of a a named entry | |
46 | * which has a name (AA_NAME typecode followed by name string) followed by | |
47 | * the entries typecode and data. Named types allow for optional | |
48 | * elements and extensions to be added and tested for without breaking | |
49 | * backwards compatibility. | |
50 | */ | |
51 | ||
52 | enum aa_code { | |
53 | AA_U8, | |
54 | AA_U16, | |
55 | AA_U32, | |
56 | AA_U64, | |
57 | AA_NAME, /* same as string except it is items name */ | |
58 | AA_STRING, | |
59 | AA_BLOB, | |
60 | AA_STRUCT, | |
61 | AA_STRUCTEND, | |
62 | AA_LIST, | |
63 | AA_LISTEND, | |
64 | AA_ARRAY, | |
65 | AA_ARRAYEND, | |
66 | }; | |
67 | ||
68 | /* | |
69 | * aa_ext is the read of the buffer containing the serialized profile. The | |
70 | * data is copied into a kernel buffer in apparmorfs and then handed off to | |
71 | * the unpack routines. | |
72 | */ | |
73 | struct aa_ext { | |
74 | void *start; | |
75 | void *end; | |
76 | void *pos; /* pointer to current position in the buffer */ | |
77 | u32 version; | |
78 | }; | |
79 | ||
80 | /* audit callback for unpack fields */ | |
81 | static void audit_cb(struct audit_buffer *ab, void *va) | |
82 | { | |
83 | struct common_audit_data *sa = va; | |
ef88a7ac JJ |
84 | |
85 | if (aad(sa)->iface.ns) { | |
86 | audit_log_format(ab, " ns="); | |
87 | audit_log_untrustedstring(ab, aad(sa)->iface.ns); | |
88 | } | |
2410aa96 | 89 | if (aad(sa)->name) { |
736ec752 | 90 | audit_log_format(ab, " name="); |
2410aa96 | 91 | audit_log_untrustedstring(ab, aad(sa)->name); |
736ec752 | 92 | } |
ef88a7ac JJ |
93 | if (aad(sa)->iface.pos) |
94 | audit_log_format(ab, " offset=%ld", aad(sa)->iface.pos); | |
736ec752 JJ |
95 | } |
96 | ||
97 | /** | |
98 | * audit_iface - do audit message for policy unpacking/load/replace/remove | |
99 | * @new: profile if it has been allocated (MAYBE NULL) | |
04dc715e | 100 | * @ns_name: name of the ns the profile is to be loaded to (MAY BE NULL) |
736ec752 JJ |
101 | * @name: name of the profile being manipulated (MAYBE NULL) |
102 | * @info: any extra info about the failure (MAYBE NULL) | |
b1b4bc2e | 103 | * @e: buffer position info |
736ec752 JJ |
104 | * @error: error code |
105 | * | |
106 | * Returns: %0 or error | |
107 | */ | |
04dc715e JJ |
108 | static int audit_iface(struct aa_profile *new, const char *ns_name, |
109 | const char *name, const char *info, struct aa_ext *e, | |
110 | int error) | |
736ec752 | 111 | { |
637f688d | 112 | struct aa_profile *profile = labels_profile(aa_current_raw_label()); |
ef88a7ac | 113 | DEFINE_AUDIT_DATA(sa, LSM_AUDIT_DATA_NONE, NULL); |
b1b4bc2e | 114 | if (e) |
ef88a7ac JJ |
115 | aad(&sa)->iface.pos = e->pos - e->start; |
116 | aad(&sa)->iface.ns = ns_name; | |
117 | if (new) | |
2410aa96 | 118 | aad(&sa)->name = new->base.hname; |
ef88a7ac | 119 | else |
2410aa96 | 120 | aad(&sa)->name = name; |
ef88a7ac JJ |
121 | aad(&sa)->info = info; |
122 | aad(&sa)->error = error; | |
736ec752 | 123 | |
ef88a7ac | 124 | return aa_audit(AUDIT_APPARMOR_STATUS, profile, &sa, audit_cb); |
736ec752 JJ |
125 | } |
126 | ||
5d5182ca JJ |
127 | void __aa_loaddata_update(struct aa_loaddata *data, long revision) |
128 | { | |
129 | AA_BUG(!data); | |
130 | AA_BUG(!data->ns); | |
131 | AA_BUG(!data->dents[AAFS_LOADDATA_REVISION]); | |
132 | AA_BUG(!mutex_is_locked(&data->ns->lock)); | |
133 | AA_BUG(data->revision > revision); | |
134 | ||
135 | data->revision = revision; | |
136 | d_inode(data->dents[AAFS_LOADDATA_DIR])->i_mtime = | |
137 | current_time(d_inode(data->dents[AAFS_LOADDATA_DIR])); | |
138 | d_inode(data->dents[AAFS_LOADDATA_REVISION])->i_mtime = | |
139 | current_time(d_inode(data->dents[AAFS_LOADDATA_REVISION])); | |
140 | } | |
141 | ||
142 | bool aa_rawdata_eq(struct aa_loaddata *l, struct aa_loaddata *r) | |
143 | { | |
144 | if (l->size != r->size) | |
145 | return false; | |
146 | if (aa_g_hash_policy && memcmp(l->hash, r->hash, aa_hash_size()) != 0) | |
147 | return false; | |
148 | return memcmp(l->data, r->data, r->size) == 0; | |
149 | } | |
150 | ||
151 | /* | |
152 | * need to take the ns mutex lock which is NOT safe most places that | |
153 | * put_loaddata is called, so we have to delay freeing it | |
154 | */ | |
155 | static void do_loaddata_free(struct work_struct *work) | |
156 | { | |
157 | struct aa_loaddata *d = container_of(work, struct aa_loaddata, work); | |
158 | struct aa_ns *ns = aa_get_ns(d->ns); | |
159 | ||
160 | if (ns) { | |
feb3c766 | 161 | mutex_lock_nested(&ns->lock, ns->level); |
5d5182ca JJ |
162 | __aa_fs_remove_rawdata(d); |
163 | mutex_unlock(&ns->lock); | |
164 | aa_put_ns(ns); | |
165 | } | |
166 | ||
167 | kzfree(d->hash); | |
a6a52579 JJ |
168 | kzfree(d->name); |
169 | kvfree(d->data); | |
170 | kzfree(d); | |
5d5182ca JJ |
171 | } |
172 | ||
5ac8c355 JJ |
173 | void aa_loaddata_kref(struct kref *kref) |
174 | { | |
175 | struct aa_loaddata *d = container_of(kref, struct aa_loaddata, count); | |
176 | ||
177 | if (d) { | |
5d5182ca JJ |
178 | INIT_WORK(&d->work, do_loaddata_free); |
179 | schedule_work(&d->work); | |
5ac8c355 JJ |
180 | } |
181 | } | |
182 | ||
5d5182ca JJ |
183 | struct aa_loaddata *aa_loaddata_alloc(size_t size) |
184 | { | |
a6a52579 | 185 | struct aa_loaddata *d; |
5d5182ca | 186 | |
a6a52579 | 187 | d = kzalloc(sizeof(*d), GFP_KERNEL); |
5d5182ca JJ |
188 | if (d == NULL) |
189 | return ERR_PTR(-ENOMEM); | |
a6a52579 JJ |
190 | d->data = kvzalloc(size, GFP_KERNEL); |
191 | if (!d->data) { | |
192 | kfree(d); | |
193 | return ERR_PTR(-ENOMEM); | |
194 | } | |
5d5182ca JJ |
195 | kref_init(&d->count); |
196 | INIT_LIST_HEAD(&d->list); | |
197 | ||
198 | return d; | |
199 | } | |
200 | ||
736ec752 JJ |
201 | /* test if read will be in packed data bounds */ |
202 | static bool inbounds(struct aa_ext *e, size_t size) | |
203 | { | |
204 | return (size <= e->end - e->pos); | |
205 | } | |
206 | ||
8e51f908 MG |
207 | static void *kvmemdup(const void *src, size_t len) |
208 | { | |
209 | void *p = kvmalloc(len, GFP_KERNEL); | |
210 | ||
211 | if (p) | |
212 | memcpy(p, src, len); | |
213 | return p; | |
214 | } | |
215 | ||
736ec752 JJ |
216 | /** |
217 | * aa_u16_chunck - test and do bounds checking for a u16 size based chunk | |
218 | * @e: serialized data read head (NOT NULL) | |
219 | * @chunk: start address for chunk of data (NOT NULL) | |
220 | * | |
221 | * Returns: the size of chunk found with the read head at the end of the chunk. | |
222 | */ | |
223 | static size_t unpack_u16_chunk(struct aa_ext *e, char **chunk) | |
224 | { | |
225 | size_t size = 0; | |
226 | ||
227 | if (!inbounds(e, sizeof(u16))) | |
228 | return 0; | |
2c17cd36 JJ |
229 | size = le16_to_cpu(get_unaligned((__le16 *) e->pos)); |
230 | e->pos += sizeof(__le16); | |
736ec752 JJ |
231 | if (!inbounds(e, size)) |
232 | return 0; | |
233 | *chunk = e->pos; | |
234 | e->pos += size; | |
235 | return size; | |
236 | } | |
237 | ||
238 | /* unpack control byte */ | |
239 | static bool unpack_X(struct aa_ext *e, enum aa_code code) | |
240 | { | |
241 | if (!inbounds(e, 1)) | |
242 | return 0; | |
243 | if (*(u8 *) e->pos != code) | |
244 | return 0; | |
245 | e->pos++; | |
246 | return 1; | |
247 | } | |
248 | ||
249 | /** | |
250 | * unpack_nameX - check is the next element is of type X with a name of @name | |
251 | * @e: serialized data extent information (NOT NULL) | |
252 | * @code: type code | |
253 | * @name: name to match to the serialized element. (MAYBE NULL) | |
254 | * | |
255 | * check that the next serialized data element is of type X and has a tag | |
256 | * name @name. If @name is specified then there must be a matching | |
257 | * name element in the stream. If @name is NULL any name element will be | |
258 | * skipped and only the typecode will be tested. | |
259 | * | |
260 | * Returns 1 on success (both type code and name tests match) and the read | |
261 | * head is advanced past the headers | |
262 | * | |
263 | * Returns: 0 if either match fails, the read head does not move | |
264 | */ | |
265 | static bool unpack_nameX(struct aa_ext *e, enum aa_code code, const char *name) | |
266 | { | |
267 | /* | |
268 | * May need to reset pos if name or type doesn't match | |
269 | */ | |
270 | void *pos = e->pos; | |
271 | /* | |
272 | * Check for presence of a tagname, and if present name size | |
273 | * AA_NAME tag value is a u16. | |
274 | */ | |
275 | if (unpack_X(e, AA_NAME)) { | |
276 | char *tag = NULL; | |
277 | size_t size = unpack_u16_chunk(e, &tag); | |
278 | /* if a name is specified it must match. otherwise skip tag */ | |
279 | if (name && (!size || strcmp(name, tag))) | |
280 | goto fail; | |
281 | } else if (name) { | |
282 | /* if a name is specified and there is no name tag fail */ | |
283 | goto fail; | |
284 | } | |
285 | ||
286 | /* now check if type code matches */ | |
287 | if (unpack_X(e, code)) | |
288 | return 1; | |
289 | ||
290 | fail: | |
291 | e->pos = pos; | |
292 | return 0; | |
293 | } | |
294 | ||
9caafbe2 MG |
295 | static bool unpack_u8(struct aa_ext *e, u8 *data, const char *name) |
296 | { | |
297 | if (unpack_nameX(e, AA_U8, name)) { | |
298 | if (!inbounds(e, sizeof(u8))) | |
299 | return 0; | |
300 | if (data) | |
301 | *data = get_unaligned((u8 *)e->pos); | |
302 | e->pos += sizeof(u8); | |
303 | return 1; | |
304 | } | |
305 | return 0; | |
306 | } | |
307 | ||
736ec752 JJ |
308 | static bool unpack_u32(struct aa_ext *e, u32 *data, const char *name) |
309 | { | |
310 | if (unpack_nameX(e, AA_U32, name)) { | |
311 | if (!inbounds(e, sizeof(u32))) | |
312 | return 0; | |
313 | if (data) | |
2c17cd36 | 314 | *data = le32_to_cpu(get_unaligned((__le32 *) e->pos)); |
736ec752 JJ |
315 | e->pos += sizeof(u32); |
316 | return 1; | |
317 | } | |
318 | return 0; | |
319 | } | |
320 | ||
321 | static bool unpack_u64(struct aa_ext *e, u64 *data, const char *name) | |
322 | { | |
323 | if (unpack_nameX(e, AA_U64, name)) { | |
324 | if (!inbounds(e, sizeof(u64))) | |
325 | return 0; | |
326 | if (data) | |
2c17cd36 | 327 | *data = le64_to_cpu(get_unaligned((__le64 *) e->pos)); |
736ec752 JJ |
328 | e->pos += sizeof(u64); |
329 | return 1; | |
330 | } | |
331 | return 0; | |
332 | } | |
333 | ||
334 | static size_t unpack_array(struct aa_ext *e, const char *name) | |
335 | { | |
336 | if (unpack_nameX(e, AA_ARRAY, name)) { | |
337 | int size; | |
338 | if (!inbounds(e, sizeof(u16))) | |
339 | return 0; | |
2c17cd36 | 340 | size = (int)le16_to_cpu(get_unaligned((__le16 *) e->pos)); |
736ec752 JJ |
341 | e->pos += sizeof(u16); |
342 | return size; | |
343 | } | |
344 | return 0; | |
345 | } | |
346 | ||
347 | static size_t unpack_blob(struct aa_ext *e, char **blob, const char *name) | |
348 | { | |
349 | if (unpack_nameX(e, AA_BLOB, name)) { | |
350 | u32 size; | |
351 | if (!inbounds(e, sizeof(u32))) | |
352 | return 0; | |
2c17cd36 | 353 | size = le32_to_cpu(get_unaligned((__le32 *) e->pos)); |
736ec752 JJ |
354 | e->pos += sizeof(u32); |
355 | if (inbounds(e, (size_t) size)) { | |
356 | *blob = e->pos; | |
357 | e->pos += size; | |
358 | return size; | |
359 | } | |
360 | } | |
361 | return 0; | |
362 | } | |
363 | ||
364 | static int unpack_str(struct aa_ext *e, const char **string, const char *name) | |
365 | { | |
366 | char *src_str; | |
367 | size_t size = 0; | |
368 | void *pos = e->pos; | |
369 | *string = NULL; | |
370 | if (unpack_nameX(e, AA_STRING, name)) { | |
371 | size = unpack_u16_chunk(e, &src_str); | |
372 | if (size) { | |
373 | /* strings are null terminated, length is size - 1 */ | |
374 | if (src_str[size - 1] != 0) | |
375 | goto fail; | |
376 | *string = src_str; | |
377 | } | |
378 | } | |
379 | return size; | |
380 | ||
381 | fail: | |
382 | e->pos = pos; | |
383 | return 0; | |
384 | } | |
385 | ||
386 | static int unpack_strdup(struct aa_ext *e, char **string, const char *name) | |
387 | { | |
388 | const char *tmp; | |
389 | void *pos = e->pos; | |
390 | int res = unpack_str(e, &tmp, name); | |
391 | *string = NULL; | |
392 | ||
393 | if (!res) | |
394 | return 0; | |
395 | ||
396 | *string = kmemdup(tmp, res, GFP_KERNEL); | |
397 | if (!*string) { | |
398 | e->pos = pos; | |
399 | return 0; | |
400 | } | |
401 | ||
402 | return res; | |
403 | } | |
404 | ||
736ec752 JJ |
405 | |
406 | /** | |
407 | * unpack_dfa - unpack a file rule dfa | |
408 | * @e: serialized data extent information (NOT NULL) | |
409 | * | |
410 | * returns dfa or ERR_PTR or NULL if no dfa | |
411 | */ | |
412 | static struct aa_dfa *unpack_dfa(struct aa_ext *e) | |
413 | { | |
414 | char *blob = NULL; | |
415 | size_t size; | |
416 | struct aa_dfa *dfa = NULL; | |
417 | ||
418 | size = unpack_blob(e, &blob, "aadfa"); | |
419 | if (size) { | |
420 | /* | |
421 | * The dfa is aligned with in the blob to 8 bytes | |
422 | * from the beginning of the stream. | |
dd51c848 | 423 | * alignment adjust needed by dfa unpack |
736ec752 | 424 | */ |
dd51c848 JJ |
425 | size_t sz = blob - (char *) e->start - |
426 | ((e->pos - e->start) & 7); | |
736ec752 JJ |
427 | size_t pad = ALIGN(sz, 8) - sz; |
428 | int flags = TO_ACCEPT1_FLAG(YYTD_DATA32) | | |
abbf8734 | 429 | TO_ACCEPT2_FLAG(YYTD_DATA32) | DFA_FLAG_VERIFY_STATES; |
736ec752 JJ |
430 | dfa = aa_dfa_unpack(blob + pad, size - pad, flags); |
431 | ||
432 | if (IS_ERR(dfa)) | |
433 | return dfa; | |
434 | ||
736ec752 JJ |
435 | } |
436 | ||
437 | return dfa; | |
736ec752 JJ |
438 | } |
439 | ||
440 | /** | |
441 | * unpack_trans_table - unpack a profile transition table | |
442 | * @e: serialized data extent information (NOT NULL) | |
443 | * @profile: profile to add the accept table to (NOT NULL) | |
444 | * | |
25985edc | 445 | * Returns: 1 if table successfully unpacked |
736ec752 JJ |
446 | */ |
447 | static bool unpack_trans_table(struct aa_ext *e, struct aa_profile *profile) | |
448 | { | |
19fe43a5 | 449 | void *saved_pos = e->pos; |
736ec752 JJ |
450 | |
451 | /* exec table is optional */ | |
452 | if (unpack_nameX(e, AA_STRUCT, "xtable")) { | |
453 | int i, size; | |
454 | ||
455 | size = unpack_array(e, NULL); | |
456 | /* currently 4 exec bits and entries 0-3 are reserved iupcx */ | |
457 | if (size > 16 - 4) | |
458 | goto fail; | |
6396bb22 | 459 | profile->file.trans.table = kcalloc(size, sizeof(char *), |
736ec752 JJ |
460 | GFP_KERNEL); |
461 | if (!profile->file.trans.table) | |
462 | goto fail; | |
463 | ||
464 | profile->file.trans.size = size; | |
465 | for (i = 0; i < size; i++) { | |
466 | char *str; | |
5379a331 | 467 | int c, j, pos, size2 = unpack_strdup(e, &str, NULL); |
736ec752 JJ |
468 | /* unpack_strdup verifies that the last character is |
469 | * null termination byte. | |
470 | */ | |
7ee95850 | 471 | if (!size2) |
736ec752 JJ |
472 | goto fail; |
473 | profile->file.trans.table[i] = str; | |
474 | /* verify that name doesn't start with space */ | |
475 | if (isspace(*str)) | |
476 | goto fail; | |
477 | ||
478 | /* count internal # of internal \0 */ | |
5379a331 JJ |
479 | for (c = j = 0; j < size2 - 1; j++) { |
480 | if (!str[j]) { | |
481 | pos = j; | |
736ec752 | 482 | c++; |
5379a331 | 483 | } |
736ec752 JJ |
484 | } |
485 | if (*str == ':') { | |
5379a331 JJ |
486 | /* first character after : must be valid */ |
487 | if (!str[1]) | |
488 | goto fail; | |
736ec752 JJ |
489 | /* beginning with : requires an embedded \0, |
490 | * verify that exactly 1 internal \0 exists | |
491 | * trailing \0 already verified by unpack_strdup | |
5379a331 JJ |
492 | * |
493 | * convert \0 back to : for label_parse | |
736ec752 | 494 | */ |
5379a331 JJ |
495 | if (c == 1) |
496 | str[pos] = ':'; | |
497 | else if (c > 1) | |
736ec752 JJ |
498 | goto fail; |
499 | } else if (c) | |
500 | /* fail - all other cases with embedded \0 */ | |
501 | goto fail; | |
502 | } | |
503 | if (!unpack_nameX(e, AA_ARRAYEND, NULL)) | |
504 | goto fail; | |
505 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
506 | goto fail; | |
507 | } | |
508 | return 1; | |
509 | ||
510 | fail: | |
511 | aa_free_domain_entries(&profile->file.trans); | |
19fe43a5 | 512 | e->pos = saved_pos; |
736ec752 JJ |
513 | return 0; |
514 | } | |
515 | ||
8e51f908 MG |
516 | static bool unpack_xattrs(struct aa_ext *e, struct aa_profile *profile) |
517 | { | |
518 | void *pos = e->pos; | |
519 | ||
520 | if (unpack_nameX(e, AA_STRUCT, "xattrs")) { | |
521 | int i, size; | |
522 | ||
523 | size = unpack_array(e, NULL); | |
524 | profile->xattr_count = size; | |
73f488cd | 525 | profile->xattrs = kcalloc(size, sizeof(char *), GFP_KERNEL); |
8e51f908 MG |
526 | if (!profile->xattrs) |
527 | goto fail; | |
528 | for (i = 0; i < size; i++) { | |
529 | if (!unpack_strdup(e, &profile->xattrs[i], NULL)) | |
530 | goto fail; | |
531 | } | |
532 | if (!unpack_nameX(e, AA_ARRAYEND, NULL)) | |
533 | goto fail; | |
534 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
535 | goto fail; | |
536 | } | |
537 | ||
8e51f908 MG |
538 | return 1; |
539 | ||
540 | fail: | |
541 | e->pos = pos; | |
542 | return 0; | |
543 | } | |
544 | ||
9caafbe2 MG |
545 | static bool unpack_secmark(struct aa_ext *e, struct aa_profile *profile) |
546 | { | |
547 | void *pos = e->pos; | |
548 | int i, size; | |
549 | ||
550 | if (unpack_nameX(e, AA_STRUCT, "secmark")) { | |
551 | size = unpack_array(e, NULL); | |
552 | ||
553 | profile->secmark = kcalloc(size, sizeof(struct aa_secmark), | |
554 | GFP_KERNEL); | |
555 | if (!profile->secmark) | |
556 | goto fail; | |
557 | ||
558 | profile->secmark_count = size; | |
559 | ||
560 | for (i = 0; i < size; i++) { | |
561 | if (!unpack_u8(e, &profile->secmark[i].audit, NULL)) | |
562 | goto fail; | |
563 | if (!unpack_u8(e, &profile->secmark[i].deny, NULL)) | |
564 | goto fail; | |
565 | if (!unpack_strdup(e, &profile->secmark[i].label, NULL)) | |
566 | goto fail; | |
567 | } | |
568 | if (!unpack_nameX(e, AA_ARRAYEND, NULL)) | |
569 | goto fail; | |
570 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
571 | goto fail; | |
572 | } | |
573 | ||
574 | return 1; | |
575 | ||
576 | fail: | |
577 | if (profile->secmark) { | |
578 | for (i = 0; i < size; i++) | |
579 | kfree(profile->secmark[i].label); | |
580 | kfree(profile->secmark); | |
581 | profile->secmark_count = 0; | |
582 | } | |
583 | ||
584 | e->pos = pos; | |
585 | return 0; | |
586 | } | |
587 | ||
736ec752 JJ |
588 | static bool unpack_rlimits(struct aa_ext *e, struct aa_profile *profile) |
589 | { | |
590 | void *pos = e->pos; | |
591 | ||
592 | /* rlimits are optional */ | |
593 | if (unpack_nameX(e, AA_STRUCT, "rlimits")) { | |
594 | int i, size; | |
595 | u32 tmp = 0; | |
596 | if (!unpack_u32(e, &tmp, NULL)) | |
597 | goto fail; | |
598 | profile->rlimits.mask = tmp; | |
599 | ||
600 | size = unpack_array(e, NULL); | |
601 | if (size > RLIM_NLIMITS) | |
602 | goto fail; | |
603 | for (i = 0; i < size; i++) { | |
7ee95850 | 604 | u64 tmp2 = 0; |
736ec752 | 605 | int a = aa_map_resource(i); |
7ee95850 | 606 | if (!unpack_u64(e, &tmp2, NULL)) |
736ec752 | 607 | goto fail; |
7ee95850 | 608 | profile->rlimits.limits[a].rlim_max = tmp2; |
736ec752 JJ |
609 | } |
610 | if (!unpack_nameX(e, AA_ARRAYEND, NULL)) | |
611 | goto fail; | |
612 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
613 | goto fail; | |
614 | } | |
615 | return 1; | |
616 | ||
617 | fail: | |
618 | e->pos = pos; | |
619 | return 0; | |
620 | } | |
621 | ||
e025be0f WH |
622 | static u32 strhash(const void *data, u32 len, u32 seed) |
623 | { | |
624 | const char * const *key = data; | |
625 | ||
626 | return jhash(*key, strlen(*key), seed); | |
627 | } | |
628 | ||
629 | static int datacmp(struct rhashtable_compare_arg *arg, const void *obj) | |
630 | { | |
631 | const struct aa_data *data = obj; | |
632 | const char * const *key = arg->key; | |
633 | ||
634 | return strcmp(data->key, *key); | |
635 | } | |
636 | ||
736ec752 JJ |
637 | /** |
638 | * unpack_profile - unpack a serialized profile | |
639 | * @e: serialized data extent information (NOT NULL) | |
640 | * | |
641 | * NOTE: unpack profile sets audit struct if there is a failure | |
642 | */ | |
04dc715e | 643 | static struct aa_profile *unpack_profile(struct aa_ext *e, char **ns_name) |
736ec752 JJ |
644 | { |
645 | struct aa_profile *profile = NULL; | |
04dc715e | 646 | const char *tmpname, *tmpns = NULL, *name = NULL; |
2410aa96 | 647 | const char *info = "failed to unpack profile"; |
80c094a4 | 648 | size_t ns_len; |
e025be0f WH |
649 | struct rhashtable_params params = { 0 }; |
650 | char *key = NULL; | |
651 | struct aa_data *data; | |
ad5ff3db | 652 | int i, error = -EPROTO; |
736ec752 JJ |
653 | kernel_cap_t tmpcap; |
654 | u32 tmp; | |
655 | ||
04dc715e JJ |
656 | *ns_name = NULL; |
657 | ||
736ec752 JJ |
658 | /* check that we have the right struct being passed */ |
659 | if (!unpack_nameX(e, AA_STRUCT, "profile")) | |
660 | goto fail; | |
661 | if (!unpack_str(e, &name, NULL)) | |
662 | goto fail; | |
04dc715e JJ |
663 | if (*name == '\0') |
664 | goto fail; | |
665 | ||
666 | tmpname = aa_splitn_fqname(name, strlen(name), &tmpns, &ns_len); | |
667 | if (tmpns) { | |
668 | *ns_name = kstrndup(tmpns, ns_len, GFP_KERNEL); | |
2410aa96 JJ |
669 | if (!*ns_name) { |
670 | info = "out of memory"; | |
04dc715e | 671 | goto fail; |
2410aa96 | 672 | } |
04dc715e JJ |
673 | name = tmpname; |
674 | } | |
736ec752 | 675 | |
637f688d | 676 | profile = aa_alloc_profile(name, NULL, GFP_KERNEL); |
736ec752 JJ |
677 | if (!profile) |
678 | return ERR_PTR(-ENOMEM); | |
679 | ||
680 | /* profile renaming is optional */ | |
681 | (void) unpack_str(e, &profile->rename, "rename"); | |
682 | ||
556d0be7 JJ |
683 | /* attachment string is optional */ |
684 | (void) unpack_str(e, &profile->attach, "attach"); | |
685 | ||
736ec752 JJ |
686 | /* xmatch is optional and may be NULL */ |
687 | profile->xmatch = unpack_dfa(e); | |
688 | if (IS_ERR(profile->xmatch)) { | |
689 | error = PTR_ERR(profile->xmatch); | |
690 | profile->xmatch = NULL; | |
2410aa96 | 691 | info = "bad xmatch"; |
736ec752 JJ |
692 | goto fail; |
693 | } | |
694 | /* xmatch_len is not optional if xmatch is set */ | |
695 | if (profile->xmatch) { | |
2410aa96 JJ |
696 | if (!unpack_u32(e, &tmp, NULL)) { |
697 | info = "missing xmatch len"; | |
736ec752 | 698 | goto fail; |
2410aa96 | 699 | } |
736ec752 JJ |
700 | profile->xmatch_len = tmp; |
701 | } | |
702 | ||
72c8a768 JJ |
703 | /* disconnected attachment string is optional */ |
704 | (void) unpack_str(e, &profile->disconnected, "disconnected"); | |
705 | ||
736ec752 | 706 | /* per profile debug flags (complain, audit) */ |
2410aa96 JJ |
707 | if (!unpack_nameX(e, AA_STRUCT, "flags")) { |
708 | info = "profile missing flags"; | |
736ec752 | 709 | goto fail; |
2410aa96 JJ |
710 | } |
711 | info = "failed to unpack profile flags"; | |
736ec752 JJ |
712 | if (!unpack_u32(e, &tmp, NULL)) |
713 | goto fail; | |
03816507 | 714 | if (tmp & PACKED_FLAG_HAT) |
637f688d | 715 | profile->label.flags |= FLAG_HAT; |
736ec752 JJ |
716 | if (!unpack_u32(e, &tmp, NULL)) |
717 | goto fail; | |
5ebfb128 | 718 | if (tmp == PACKED_MODE_COMPLAIN || (e->version & FORCE_COMPLAIN_FLAG)) |
736ec752 | 719 | profile->mode = APPARMOR_COMPLAIN; |
03816507 JJ |
720 | else if (tmp == PACKED_MODE_KILL) |
721 | profile->mode = APPARMOR_KILL; | |
722 | else if (tmp == PACKED_MODE_UNCONFINED) | |
723 | profile->mode = APPARMOR_UNCONFINED; | |
736ec752 JJ |
724 | if (!unpack_u32(e, &tmp, NULL)) |
725 | goto fail; | |
726 | if (tmp) | |
727 | profile->audit = AUDIT_ALL; | |
728 | ||
729 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
730 | goto fail; | |
731 | ||
732 | /* path_flags is optional */ | |
733 | if (unpack_u32(e, &profile->path_flags, "path_flags")) | |
637f688d JJ |
734 | profile->path_flags |= profile->label.flags & |
735 | PATH_MEDIATE_DELETED; | |
736ec752 JJ |
736 | else |
737 | /* set a default value if path_flags field is not present */ | |
637f688d | 738 | profile->path_flags = PATH_MEDIATE_DELETED; |
736ec752 | 739 | |
2410aa96 | 740 | info = "failed to unpack profile capabilities"; |
736ec752 JJ |
741 | if (!unpack_u32(e, &(profile->caps.allow.cap[0]), NULL)) |
742 | goto fail; | |
743 | if (!unpack_u32(e, &(profile->caps.audit.cap[0]), NULL)) | |
744 | goto fail; | |
745 | if (!unpack_u32(e, &(profile->caps.quiet.cap[0]), NULL)) | |
746 | goto fail; | |
747 | if (!unpack_u32(e, &tmpcap.cap[0], NULL)) | |
748 | goto fail; | |
749 | ||
2410aa96 | 750 | info = "failed to unpack upper profile capabilities"; |
736ec752 JJ |
751 | if (unpack_nameX(e, AA_STRUCT, "caps64")) { |
752 | /* optional upper half of 64 bit caps */ | |
753 | if (!unpack_u32(e, &(profile->caps.allow.cap[1]), NULL)) | |
754 | goto fail; | |
755 | if (!unpack_u32(e, &(profile->caps.audit.cap[1]), NULL)) | |
756 | goto fail; | |
757 | if (!unpack_u32(e, &(profile->caps.quiet.cap[1]), NULL)) | |
758 | goto fail; | |
759 | if (!unpack_u32(e, &(tmpcap.cap[1]), NULL)) | |
760 | goto fail; | |
761 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
762 | goto fail; | |
763 | } | |
764 | ||
2410aa96 | 765 | info = "failed to unpack extended profile capabilities"; |
736ec752 JJ |
766 | if (unpack_nameX(e, AA_STRUCT, "capsx")) { |
767 | /* optional extended caps mediation mask */ | |
768 | if (!unpack_u32(e, &(profile->caps.extended.cap[0]), NULL)) | |
769 | goto fail; | |
770 | if (!unpack_u32(e, &(profile->caps.extended.cap[1]), NULL)) | |
771 | goto fail; | |
cdbd2884 JJ |
772 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) |
773 | goto fail; | |
736ec752 JJ |
774 | } |
775 | ||
8e51f908 MG |
776 | if (!unpack_xattrs(e, profile)) { |
777 | info = "failed to unpack profile xattrs"; | |
778 | goto fail; | |
779 | } | |
780 | ||
2410aa96 JJ |
781 | if (!unpack_rlimits(e, profile)) { |
782 | info = "failed to unpack profile rlimits"; | |
736ec752 | 783 | goto fail; |
2410aa96 | 784 | } |
736ec752 | 785 | |
9caafbe2 MG |
786 | if (!unpack_secmark(e, profile)) { |
787 | info = "failed to unpack profile secmark rules"; | |
788 | goto fail; | |
789 | } | |
790 | ||
ad5ff3db JJ |
791 | if (unpack_nameX(e, AA_STRUCT, "policydb")) { |
792 | /* generic policy dfa - optional and may be NULL */ | |
2410aa96 | 793 | info = "failed to unpack policydb"; |
ad5ff3db JJ |
794 | profile->policy.dfa = unpack_dfa(e); |
795 | if (IS_ERR(profile->policy.dfa)) { | |
796 | error = PTR_ERR(profile->policy.dfa); | |
797 | profile->policy.dfa = NULL; | |
798 | goto fail; | |
5f20fdfe JJ |
799 | } else if (!profile->policy.dfa) { |
800 | error = -EPROTO; | |
801 | goto fail; | |
ad5ff3db JJ |
802 | } |
803 | if (!unpack_u32(e, &profile->policy.start[0], "start")) | |
804 | /* default start state */ | |
805 | profile->policy.start[0] = DFA_START; | |
806 | /* setup class index */ | |
807 | for (i = AA_CLASS_FILE; i <= AA_CLASS_LAST; i++) { | |
808 | profile->policy.start[i] = | |
809 | aa_dfa_next(profile->policy.dfa, | |
810 | profile->policy.start[0], | |
811 | i); | |
812 | } | |
813 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) | |
814 | goto fail; | |
11c236b8 JJ |
815 | } else |
816 | profile->policy.dfa = aa_get_dfa(nulldfa); | |
ad5ff3db | 817 | |
736ec752 JJ |
818 | /* get file rules */ |
819 | profile->file.dfa = unpack_dfa(e); | |
820 | if (IS_ERR(profile->file.dfa)) { | |
821 | error = PTR_ERR(profile->file.dfa); | |
822 | profile->file.dfa = NULL; | |
2410aa96 | 823 | info = "failed to unpack profile file rules"; |
736ec752 | 824 | goto fail; |
6604d4c1 JJ |
825 | } else if (profile->file.dfa) { |
826 | if (!unpack_u32(e, &profile->file.start, "dfa_start")) | |
827 | /* default start state */ | |
828 | profile->file.start = DFA_START; | |
829 | } else if (profile->policy.dfa && | |
830 | profile->policy.start[AA_CLASS_FILE]) { | |
831 | profile->file.dfa = aa_get_dfa(profile->policy.dfa); | |
832 | profile->file.start = profile->policy.start[AA_CLASS_FILE]; | |
11c236b8 JJ |
833 | } else |
834 | profile->file.dfa = aa_get_dfa(nulldfa); | |
736ec752 | 835 | |
2410aa96 JJ |
836 | if (!unpack_trans_table(e, profile)) { |
837 | info = "failed to unpack profile transition table"; | |
736ec752 | 838 | goto fail; |
2410aa96 | 839 | } |
736ec752 | 840 | |
e025be0f | 841 | if (unpack_nameX(e, AA_STRUCT, "data")) { |
2410aa96 | 842 | info = "out of memory"; |
e025be0f WH |
843 | profile->data = kzalloc(sizeof(*profile->data), GFP_KERNEL); |
844 | if (!profile->data) | |
845 | goto fail; | |
846 | ||
847 | params.nelem_hint = 3; | |
848 | params.key_len = sizeof(void *); | |
849 | params.key_offset = offsetof(struct aa_data, key); | |
850 | params.head_offset = offsetof(struct aa_data, head); | |
851 | params.hashfn = strhash; | |
852 | params.obj_cmpfn = datacmp; | |
853 | ||
2410aa96 JJ |
854 | if (rhashtable_init(profile->data, ¶ms)) { |
855 | info = "failed to init key, value hash table"; | |
e025be0f | 856 | goto fail; |
2410aa96 | 857 | } |
e025be0f WH |
858 | |
859 | while (unpack_strdup(e, &key, NULL)) { | |
860 | data = kzalloc(sizeof(*data), GFP_KERNEL); | |
861 | if (!data) { | |
862 | kzfree(key); | |
863 | goto fail; | |
864 | } | |
865 | ||
866 | data->key = key; | |
867 | data->size = unpack_blob(e, &data->data, NULL); | |
868 | data->data = kvmemdup(data->data, data->size); | |
869 | if (data->size && !data->data) { | |
870 | kzfree(data->key); | |
871 | kzfree(data); | |
872 | goto fail; | |
873 | } | |
874 | ||
875 | rhashtable_insert_fast(profile->data, &data->head, | |
876 | profile->data->p); | |
877 | } | |
878 | ||
2410aa96 JJ |
879 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) { |
880 | info = "failed to unpack end of key, value data table"; | |
e025be0f | 881 | goto fail; |
2410aa96 | 882 | } |
e025be0f WH |
883 | } |
884 | ||
2410aa96 JJ |
885 | if (!unpack_nameX(e, AA_STRUCTEND, NULL)) { |
886 | info = "failed to unpack end of profile"; | |
736ec752 | 887 | goto fail; |
2410aa96 | 888 | } |
736ec752 JJ |
889 | |
890 | return profile; | |
891 | ||
892 | fail: | |
893 | if (profile) | |
894 | name = NULL; | |
895 | else if (!name) | |
896 | name = "unknown"; | |
2410aa96 | 897 | audit_iface(profile, NULL, name, info, e, error); |
8651e1d6 | 898 | aa_free_profile(profile); |
736ec752 JJ |
899 | |
900 | return ERR_PTR(error); | |
901 | } | |
902 | ||
903 | /** | |
904 | * verify_head - unpack serialized stream header | |
905 | * @e: serialized data read head (NOT NULL) | |
dd51c848 | 906 | * @required: whether the header is required or optional |
736ec752 JJ |
907 | * @ns: Returns - namespace if one is specified else NULL (NOT NULL) |
908 | * | |
909 | * Returns: error or 0 if header is good | |
910 | */ | |
dd51c848 | 911 | static int verify_header(struct aa_ext *e, int required, const char **ns) |
736ec752 JJ |
912 | { |
913 | int error = -EPROTONOSUPPORT; | |
dd51c848 JJ |
914 | const char *name = NULL; |
915 | *ns = NULL; | |
916 | ||
736ec752 JJ |
917 | /* get the interface version */ |
918 | if (!unpack_u32(e, &e->version, "version")) { | |
dd51c848 | 919 | if (required) { |
04dc715e | 920 | audit_iface(NULL, NULL, NULL, "invalid profile format", |
dd51c848 JJ |
921 | e, error); |
922 | return error; | |
923 | } | |
736ec752 JJ |
924 | } |
925 | ||
474d6b75 JJ |
926 | /* Check that the interface version is currently supported. |
927 | * if not specified use previous version | |
928 | * Mask off everything that is not kernel abi version | |
929 | */ | |
86aea56f | 930 | if (VERSION_LT(e->version, v5) || VERSION_GT(e->version, v7)) { |
04dc715e | 931 | audit_iface(NULL, NULL, NULL, "unsupported interface version", |
474d6b75 JJ |
932 | e, error); |
933 | return error; | |
934 | } | |
dd51c848 | 935 | |
736ec752 | 936 | /* read the namespace if present */ |
dd51c848 | 937 | if (unpack_str(e, &name, "namespace")) { |
04dc715e JJ |
938 | if (*name == '\0') { |
939 | audit_iface(NULL, NULL, NULL, "invalid namespace name", | |
940 | e, error); | |
941 | return error; | |
942 | } | |
dd51c848 | 943 | if (*ns && strcmp(*ns, name)) |
04dc715e JJ |
944 | audit_iface(NULL, NULL, NULL, "invalid ns change", e, |
945 | error); | |
dd51c848 JJ |
946 | else if (!*ns) |
947 | *ns = name; | |
948 | } | |
736ec752 JJ |
949 | |
950 | return 0; | |
951 | } | |
952 | ||
953 | static bool verify_xindex(int xindex, int table_size) | |
954 | { | |
955 | int index, xtype; | |
956 | xtype = xindex & AA_X_TYPE_MASK; | |
957 | index = xindex & AA_X_INDEX_MASK; | |
23ca7b64 | 958 | if (xtype == AA_X_TABLE && index >= table_size) |
736ec752 JJ |
959 | return 0; |
960 | return 1; | |
961 | } | |
962 | ||
963 | /* verify dfa xindexes are in range of transition tables */ | |
964 | static bool verify_dfa_xindex(struct aa_dfa *dfa, int table_size) | |
965 | { | |
966 | int i; | |
967 | for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) { | |
968 | if (!verify_xindex(dfa_user_xindex(dfa, i), table_size)) | |
969 | return 0; | |
970 | if (!verify_xindex(dfa_other_xindex(dfa, i), table_size)) | |
971 | return 0; | |
972 | } | |
973 | return 1; | |
974 | } | |
975 | ||
976 | /** | |
977 | * verify_profile - Do post unpack analysis to verify profile consistency | |
978 | * @profile: profile to verify (NOT NULL) | |
979 | * | |
980 | * Returns: 0 if passes verification else error | |
981 | */ | |
982 | static int verify_profile(struct aa_profile *profile) | |
983 | { | |
abbf8734 JJ |
984 | if (profile->file.dfa && |
985 | !verify_dfa_xindex(profile->file.dfa, | |
986 | profile->file.trans.size)) { | |
04dc715e | 987 | audit_iface(profile, NULL, NULL, "Invalid named transition", |
abbf8734 JJ |
988 | NULL, -EPROTO); |
989 | return -EPROTO; | |
736ec752 JJ |
990 | } |
991 | ||
992 | return 0; | |
993 | } | |
994 | ||
dd51c848 JJ |
995 | void aa_load_ent_free(struct aa_load_ent *ent) |
996 | { | |
997 | if (ent) { | |
998 | aa_put_profile(ent->rename); | |
999 | aa_put_profile(ent->old); | |
1000 | aa_put_profile(ent->new); | |
04dc715e | 1001 | kfree(ent->ns_name); |
dd51c848 JJ |
1002 | kzfree(ent); |
1003 | } | |
1004 | } | |
1005 | ||
1006 | struct aa_load_ent *aa_load_ent_alloc(void) | |
1007 | { | |
1008 | struct aa_load_ent *ent = kzalloc(sizeof(*ent), GFP_KERNEL); | |
1009 | if (ent) | |
1010 | INIT_LIST_HEAD(&ent->list); | |
1011 | return ent; | |
1012 | } | |
1013 | ||
736ec752 | 1014 | /** |
dd51c848 | 1015 | * aa_unpack - unpack packed binary profile(s) data loaded from user space |
736ec752 | 1016 | * @udata: user data copied to kmem (NOT NULL) |
dd51c848 | 1017 | * @lh: list to place unpacked profiles in a aa_repl_ws |
736ec752 JJ |
1018 | * @ns: Returns namespace profile is in if specified else NULL (NOT NULL) |
1019 | * | |
dd51c848 JJ |
1020 | * Unpack user data and return refcounted allocated profile(s) stored in |
1021 | * @lh in order of discovery, with the list chain stored in base.list | |
1022 | * or error | |
736ec752 | 1023 | * |
dd51c848 | 1024 | * Returns: profile(s) on @lh else error pointer if fails to unpack |
736ec752 | 1025 | */ |
5ac8c355 JJ |
1026 | int aa_unpack(struct aa_loaddata *udata, struct list_head *lh, |
1027 | const char **ns) | |
736ec752 | 1028 | { |
dd51c848 | 1029 | struct aa_load_ent *tmp, *ent; |
736ec752 JJ |
1030 | struct aa_profile *profile = NULL; |
1031 | int error; | |
1032 | struct aa_ext e = { | |
5ac8c355 JJ |
1033 | .start = udata->data, |
1034 | .end = udata->data + udata->size, | |
1035 | .pos = udata->data, | |
736ec752 JJ |
1036 | }; |
1037 | ||
dd51c848 JJ |
1038 | *ns = NULL; |
1039 | while (e.pos < e.end) { | |
04dc715e | 1040 | char *ns_name = NULL; |
f8eb8a13 | 1041 | void *start; |
dd51c848 JJ |
1042 | error = verify_header(&e, e.pos == e.start, ns); |
1043 | if (error) | |
1044 | goto fail; | |
736ec752 | 1045 | |
f8eb8a13 | 1046 | start = e.pos; |
04dc715e | 1047 | profile = unpack_profile(&e, &ns_name); |
dd51c848 JJ |
1048 | if (IS_ERR(profile)) { |
1049 | error = PTR_ERR(profile); | |
1050 | goto fail; | |
1051 | } | |
1052 | ||
1053 | error = verify_profile(profile); | |
f8eb8a13 JJ |
1054 | if (error) |
1055 | goto fail_profile; | |
1056 | ||
31f75bfe JJ |
1057 | if (aa_g_hash_policy) |
1058 | error = aa_calc_profile_hash(profile, e.version, start, | |
6059f71f | 1059 | e.pos - start); |
f8eb8a13 JJ |
1060 | if (error) |
1061 | goto fail_profile; | |
dd51c848 JJ |
1062 | |
1063 | ent = aa_load_ent_alloc(); | |
1064 | if (!ent) { | |
1065 | error = -ENOMEM; | |
f8eb8a13 | 1066 | goto fail_profile; |
dd51c848 | 1067 | } |
736ec752 | 1068 | |
dd51c848 | 1069 | ent->new = profile; |
04dc715e | 1070 | ent->ns_name = ns_name; |
dd51c848 | 1071 | list_add_tail(&ent->list, lh); |
736ec752 | 1072 | } |
5ac8c355 | 1073 | udata->abi = e.version & K_ABI_MASK; |
31f75bfe JJ |
1074 | if (aa_g_hash_policy) { |
1075 | udata->hash = aa_calc_hash(udata->data, udata->size); | |
1076 | if (IS_ERR(udata->hash)) { | |
1077 | error = PTR_ERR(udata->hash); | |
1078 | udata->hash = NULL; | |
1079 | goto fail; | |
1080 | } | |
5ac8c355 | 1081 | } |
dd51c848 JJ |
1082 | return 0; |
1083 | ||
f8eb8a13 JJ |
1084 | fail_profile: |
1085 | aa_put_profile(profile); | |
1086 | ||
dd51c848 JJ |
1087 | fail: |
1088 | list_for_each_entry_safe(ent, tmp, lh, list) { | |
1089 | list_del_init(&ent->list); | |
1090 | aa_load_ent_free(ent); | |
1091 | } | |
1092 | ||
1093 | return error; | |
736ec752 | 1094 | } |