Commit | Line | Data |
---|---|---|
6fcd5f2c JL |
1 | /// If list_for_each_entry, etc complete a traversal of the list, the iterator |
2 | /// variable ends up pointing to an address at an offset from the list head, | |
3 | /// and not a meaningful structure. Thus this value should not be used after | |
4 | /// the end of the iterator. | |
5 | //#False positives arise when there is a goto in the iterator and the | |
6 | //#reported reference is at the label of this goto. Some flag tests | |
7 | //#may also cause a report to be a false positive. | |
8 | /// | |
9 | // Confidence: Moderate | |
10 | // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. | |
11 | // Copyright: (C) 2012 Gilles Muller, INRIA/LIP6. GPLv2. | |
12 | // URL: http://coccinelle.lip6.fr/ | |
13 | // Comments: | |
93f14468 | 14 | // Options: --no-includes --include-headers |
6fcd5f2c JL |
15 | |
16 | virtual context | |
17 | virtual org | |
18 | virtual report | |
19 | ||
20 | @r exists@ | |
21 | identifier c,member; | |
22 | expression E,x; | |
23 | iterator name list_for_each_entry; | |
24 | iterator name list_for_each_entry_reverse; | |
25 | iterator name list_for_each_entry_continue; | |
26 | iterator name list_for_each_entry_continue_reverse; | |
27 | iterator name list_for_each_entry_from; | |
28 | iterator name list_for_each_entry_safe; | |
29 | iterator name list_for_each_entry_safe_continue; | |
30 | iterator name list_for_each_entry_safe_from; | |
31 | iterator name list_for_each_entry_safe_reverse; | |
32 | iterator name hlist_for_each_entry; | |
33 | iterator name hlist_for_each_entry_continue; | |
34 | iterator name hlist_for_each_entry_from; | |
35 | iterator name hlist_for_each_entry_safe; | |
36 | statement S; | |
37 | position p1,p2; | |
dc7884f3 | 38 | type T; |
6fcd5f2c JL |
39 | @@ |
40 | ||
41 | ( | |
42 | list_for_each_entry@p1(c,...,member) { ... when != break; | |
43 | when forall | |
44 | when strict | |
45 | } | |
46 | | | |
47 | list_for_each_entry_reverse@p1(c,...,member) { ... when != break; | |
48 | when forall | |
49 | when strict | |
50 | } | |
51 | | | |
52 | list_for_each_entry_continue@p1(c,...,member) { ... when != break; | |
53 | when forall | |
54 | when strict | |
55 | } | |
56 | | | |
57 | list_for_each_entry_continue_reverse@p1(c,...,member) { ... when != break; | |
58 | when forall | |
59 | when strict | |
60 | } | |
61 | | | |
62 | list_for_each_entry_from@p1(c,...,member) { ... when != break; | |
63 | when forall | |
64 | when strict | |
65 | } | |
66 | | | |
67 | list_for_each_entry_safe@p1(c,...,member) { ... when != break; | |
68 | when forall | |
69 | when strict | |
70 | } | |
71 | | | |
72 | list_for_each_entry_safe_continue@p1(c,...,member) { ... when != break; | |
73 | when forall | |
74 | when strict | |
75 | } | |
76 | | | |
77 | list_for_each_entry_safe_from@p1(c,...,member) { ... when != break; | |
78 | when forall | |
79 | when strict | |
80 | } | |
81 | | | |
82 | list_for_each_entry_safe_reverse@p1(c,...,member) { ... when != break; | |
83 | when forall | |
84 | when strict | |
85 | } | |
86 | ) | |
87 | ... | |
88 | ( | |
89 | list_for_each_entry(c,...) S | |
90 | | | |
91 | list_for_each_entry_reverse(c,...) S | |
92 | | | |
93 | list_for_each_entry_continue(c,...) S | |
94 | | | |
95 | list_for_each_entry_continue_reverse(c,...) S | |
96 | | | |
97 | list_for_each_entry_from(c,...) S | |
98 | | | |
99 | list_for_each_entry_safe(c,...) S | |
100 | | | |
101 | list_for_each_entry_safe(x,c,...) S | |
102 | | | |
103 | list_for_each_entry_safe_continue(c,...) S | |
104 | | | |
105 | list_for_each_entry_safe_continue(x,c,...) S | |
106 | | | |
107 | list_for_each_entry_safe_from(c,...) S | |
108 | | | |
109 | list_for_each_entry_safe_from(x,c,...) S | |
110 | | | |
111 | list_for_each_entry_safe_reverse(c,...) S | |
112 | | | |
113 | list_for_each_entry_safe_reverse(x,c,...) S | |
114 | | | |
115 | hlist_for_each_entry(c,...) S | |
116 | | | |
117 | hlist_for_each_entry_continue(c,...) S | |
118 | | | |
119 | hlist_for_each_entry_from(c,...) S | |
120 | | | |
121 | hlist_for_each_entry_safe(c,...) S | |
122 | | | |
123 | list_remove_head(x,c,...) | |
124 | | | |
125 | sizeof(<+...c...+>) | |
126 | | | |
1b669e71 | 127 | &c->member |
6fcd5f2c | 128 | | |
dc7884f3 JL |
129 | T c; |
130 | | | |
6fcd5f2c JL |
131 | c = E |
132 | | | |
133 | *c@p2 | |
134 | ) | |
135 | ||
136 | @script:python depends on org@ | |
137 | p1 << r.p1; | |
138 | p2 << r.p2; | |
139 | @@ | |
140 | ||
141 | cocci.print_main("invalid iterator index reference",p2) | |
142 | cocci.print_secs("iterator",p1) | |
143 | ||
144 | @script:python depends on report@ | |
145 | p1 << r.p1; | |
146 | p2 << r.p2; | |
147 | @@ | |
148 | ||
149 | msg = "ERROR: invalid reference to the index variable of the iterator on line %s" % (p1[0].line) | |
150 | coccilib.report.print_report(p2[0], msg) |