net: bridge: add support for raw sysfs port options
[linux-2.6-block.git] / net / bridge / br_if.c
CommitLineData
1da177e4
LT
1/*
2 * Userspace interface
3 * Linux ethernet bridge
4 *
5 * Authors:
6 * Lennert Buytenhek <buytenh@gnu.org>
7 *
1da177e4
LT
8 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License
10 * as published by the Free Software Foundation; either version
11 * 2 of the License, or (at your option) any later version.
12 */
13
14#include <linux/kernel.h>
15#include <linux/netdevice.h>
77f98598 16#include <linux/etherdevice.h>
c06ee961 17#include <linux/netpoll.h>
1da177e4
LT
18#include <linux/ethtool.h>
19#include <linux/if_arp.h>
20#include <linux/module.h>
21#include <linux/init.h>
22#include <linux/rtnetlink.h>
46f25dff 23#include <linux/if_ether.h>
5a0e3ad6 24#include <linux/slab.h>
c6e970a0 25#include <net/dsa.h>
1da177e4 26#include <net/sock.h>
407af329 27#include <linux/if_vlan.h>
56607386 28#include <net/switchdev.h>
705e0dea 29#include <net/net_namespace.h>
1da177e4
LT
30
31#include "br_private.h"
32
33/*
34 * Determine initial path cost based on speed.
35 * using recommendations from 802.1d standard
36 *
61a44b9c 37 * Since driver might sleep need to not be holding any locks.
1da177e4 38 */
4433f420 39static int port_cost(struct net_device *dev)
1da177e4 40{
702b26a2 41 struct ethtool_link_ksettings ecmd;
b4a488d1 42
702b26a2
DD
43 if (!__ethtool_get_link_ksettings(dev, &ecmd)) {
44 switch (ecmd.base.speed) {
fa3df928
JP
45 case SPEED_10000:
46 return 2;
47 case SPEED_1000:
48 return 4;
49 case SPEED_100:
50 return 19;
51 case SPEED_10:
52 return 100;
1da177e4
LT
53 }
54 }
55
56 /* Old silly heuristics based on name */
57 if (!strncmp(dev->name, "lec", 3))
58 return 7;
59
60 if (!strncmp(dev->name, "plip", 4))
61 return 2500;
62
63 return 100; /* assume old 10Mbps */
64}
65
4433f420 66
1a81a2e0 67/* Check for port carrier transitions. */
faa1cd82 68void br_port_carrier_check(struct net_bridge_port *p, bool *notified)
4433f420 69{
269def7c
SH
70 struct net_device *dev = p->dev;
71 struct net_bridge *br = p->br;
6e86b890 72
8f3359bd 73 if (!(p->flags & BR_ADMIN_COST) &&
74 netif_running(dev) && netif_oper_up(dev))
6e86b890
SH
75 p->path_cost = port_cost(dev);
76
faa1cd82 77 *notified = false;
aa7c6e5f 78 if (!netif_running(br->dev))
79 return;
80
81 spin_lock_bh(&br->lock);
576eb625 82 if (netif_running(dev) && netif_oper_up(dev)) {
faa1cd82 83 if (p->state == BR_STATE_DISABLED) {
aa7c6e5f 84 br_stp_enable_port(p);
faa1cd82
NA
85 *notified = true;
86 }
aa7c6e5f 87 } else {
faa1cd82 88 if (p->state != BR_STATE_DISABLED) {
aa7c6e5f 89 br_stp_disable_port(p);
faa1cd82
NA
90 *notified = true;
91 }
4433f420 92 }
aa7c6e5f 93 spin_unlock_bh(&br->lock);
4433f420
SH
94}
95
2796d0c6
VY
96static void br_port_set_promisc(struct net_bridge_port *p)
97{
98 int err = 0;
99
100 if (br_promisc_port(p))
101 return;
102
103 err = dev_set_promiscuity(p->dev, 1);
104 if (err)
105 return;
106
107 br_fdb_unsync_static(p->br, p);
108 p->flags |= BR_PROMISC;
109}
110
111static void br_port_clear_promisc(struct net_bridge_port *p)
112{
113 int err;
114
115 /* Check if the port is already non-promisc or if it doesn't
116 * support UNICAST filtering. Without unicast filtering support
117 * we'll end up re-enabling promisc mode anyway, so just check for
118 * it here.
119 */
120 if (!br_promisc_port(p) || !(p->dev->priv_flags & IFF_UNICAST_FLT))
121 return;
122
123 /* Since we'll be clearing the promisc mode, program the port
124 * first so that we don't have interruption in traffic.
125 */
126 err = br_fdb_sync_static(p->br, p);
127 if (err)
128 return;
129
130 dev_set_promiscuity(p->dev, -1);
131 p->flags &= ~BR_PROMISC;
132}
133
134/* When a port is added or removed or when certain port flags
135 * change, this function is called to automatically manage
136 * promiscuity setting of all the bridge ports. We are always called
137 * under RTNL so can skip using rcu primitives.
138 */
139void br_manage_promisc(struct net_bridge *br)
140{
141 struct net_bridge_port *p;
142 bool set_all = false;
143
144 /* If vlan filtering is disabled or bridge interface is placed
145 * into promiscuous mode, place all ports in promiscuous mode.
146 */
1f51445a 147 if ((br->dev->flags & IFF_PROMISC) || !br_vlan_enabled(br->dev))
2796d0c6
VY
148 set_all = true;
149
150 list_for_each_entry(p, &br->port_list, list) {
151 if (set_all) {
152 br_port_set_promisc(p);
153 } else {
154 /* If the number of auto-ports is <= 1, then all other
155 * ports will have their output configuration
156 * statically specified through fdbs. Since ingress
157 * on the auto-port becomes forwarding/egress to other
158 * ports and egress configuration is statically known,
159 * we can say that ingress configuration of the
160 * auto-port is also statically known.
161 * This lets us disable promiscuous mode and write
162 * this config to hw.
163 */
e0a47d1f
TM
164 if (br->auto_cnt == 0 ||
165 (br->auto_cnt == 1 && br_auto_port(p)))
2796d0c6
VY
166 br_port_clear_promisc(p);
167 else
168 br_port_set_promisc(p);
169 }
170 }
171}
172
e028e4b8
VY
173static void nbp_update_port_count(struct net_bridge *br)
174{
175 struct net_bridge_port *p;
176 u32 cnt = 0;
177
178 list_for_each_entry(p, &br->port_list, list) {
179 if (br_auto_port(p))
180 cnt++;
181 }
2796d0c6
VY
182 if (br->auto_cnt != cnt) {
183 br->auto_cnt = cnt;
184 br_manage_promisc(br);
185 }
186}
187
188static void nbp_delete_promisc(struct net_bridge_port *p)
189{
025559ee 190 /* If port is currently promiscuous, unset promiscuity.
2796d0c6
VY
191 * Otherwise, it is a static port so remove all addresses
192 * from it.
193 */
194 dev_set_allmulti(p->dev, -1);
195 if (br_promisc_port(p))
196 dev_set_promiscuity(p->dev, -1);
197 else
198 br_fdb_unsync_static(p->br, p);
e028e4b8
VY
199}
200
bab1deea
SH
201static void release_nbp(struct kobject *kobj)
202{
203 struct net_bridge_port *p
204 = container_of(kobj, struct net_bridge_port, kobj);
205 kfree(p);
206}
207
705e0dea
TH
208static void brport_get_ownership(struct kobject *kobj, kuid_t *uid, kgid_t *gid)
209{
210 struct net_bridge_port *p = kobj_to_brport(kobj);
211
212 net_ns_get_ownership(dev_net(p->dev), uid, gid);
213}
214
bab1deea
SH
215static struct kobj_type brport_ktype = {
216#ifdef CONFIG_SYSFS
217 .sysfs_ops = &brport_sysfs_ops,
218#endif
219 .release = release_nbp,
705e0dea 220 .get_ownership = brport_get_ownership,
bab1deea
SH
221};
222
1da177e4
LT
223static void destroy_nbp(struct net_bridge_port *p)
224{
225 struct net_device *dev = p->dev;
226
1da177e4
LT
227 p->br = NULL;
228 p->dev = NULL;
229 dev_put(dev);
230
bab1deea 231 kobject_put(&p->kobj);
1da177e4
LT
232}
233
234static void destroy_nbp_rcu(struct rcu_head *head)
235{
236 struct net_bridge_port *p =
237 container_of(head, struct net_bridge_port, rcu);
238 destroy_nbp(p);
239}
240
45493d47
PA
241static unsigned get_max_headroom(struct net_bridge *br)
242{
243 unsigned max_headroom = 0;
244 struct net_bridge_port *p;
245
246 list_for_each_entry(p, &br->port_list, list) {
247 unsigned dev_headroom = netdev_get_fwd_headroom(p->dev);
248
249 if (dev_headroom > max_headroom)
250 max_headroom = dev_headroom;
251 }
252
253 return max_headroom;
254}
255
256static void update_headroom(struct net_bridge *br, int new_hr)
257{
258 struct net_bridge_port *p;
259
260 list_for_each_entry(p, &br->port_list, list)
261 netdev_set_rx_headroom(p->dev, new_hr);
262
263 br->dev->needed_headroom = new_hr;
264}
265
3f4cfc2d
SH
266/* Delete port(interface) from bridge is done in two steps.
267 * via RCU. First step, marks device as down. That deletes
268 * all the timers and stops new packets from flowing through.
269 *
270 * Final cleanup doesn't occur until after all CPU's finished
271 * processing packets.
272 *
273 * Protected from multiple admin operations by RTNL mutex
274 */
1da177e4
LT
275static void del_nbp(struct net_bridge_port *p)
276{
277 struct net_bridge *br = p->br;
278 struct net_device *dev = p->dev;
279
b3bcb72e 280 sysfs_remove_link(br->ifobj, p->dev->name);
bab1deea 281
2796d0c6 282 nbp_delete_promisc(p);
1da177e4
LT
283
284 spin_lock_bh(&br->lock);
285 br_stp_disable_port(p);
286 spin_unlock_bh(&br->lock);
287
92899063 288 br_ifinfo_notify(RTM_DELLINK, NULL, p);
b86c4503 289
1da177e4 290 list_del_rcu(&p->list);
45493d47
PA
291 if (netdev_get_fwd_headroom(dev) == br->dev->needed_headroom)
292 update_headroom(br, get_max_headroom(br));
293 netdev_reset_rx_headroom(dev);
1da177e4 294
f409d0ed 295 nbp_vlan_flush(p);
1ea2d020 296 br_fdb_delete_by_port(br, p, 0, 1);
56607386
JP
297 switchdev_deferred_process();
298
e028e4b8
VY
299 nbp_update_port_count(br);
300
0f49579a
JP
301 netdev_upper_dev_unlink(dev, br->dev);
302
f350a0a8
JP
303 dev->priv_flags &= ~IFF_BRIDGE_PORT;
304
ab95bfe0 305 netdev_rx_handler_unregister(dev);
b3f1be4b 306
3fe2d7c7
HX
307 br_multicast_del_port(p);
308
125a12cc 309 kobject_uevent(&p->kobj, KOBJ_REMOVE);
bab1deea
SH
310 kobject_del(&p->kobj);
311
91d2c34a
HX
312 br_netpoll_disable(p);
313
1da177e4
LT
314 call_rcu(&p->rcu, destroy_nbp_rcu);
315}
316
1ce5cce8 317/* Delete bridge device */
318void br_dev_delete(struct net_device *dev, struct list_head *head)
1da177e4 319{
1ce5cce8 320 struct net_bridge *br = netdev_priv(dev);
1da177e4
LT
321 struct net_bridge_port *p, *n;
322
323 list_for_each_entry_safe(p, n, &br->port_list, list) {
1da177e4
LT
324 del_nbp(p);
325 }
326
821f1b21
RP
327 br_recalculate_neigh_suppress_enabled(br);
328
1ea2d020 329 br_fdb_delete_by_port(br, NULL, 0, 1);
f8730420 330
f7cdee8a 331 cancel_delayed_work_sync(&br->gc_work);
1da177e4
LT
332
333 br_sysfs_delbr(br->dev);
8c56ba05 334 unregister_netdevice_queue(br->dev, head);
1da177e4
LT
335}
336
1da177e4
LT
337/* find an available port number */
338static int find_portno(struct net_bridge *br)
339{
340 int index;
341 struct net_bridge_port *p;
342 unsigned long *inuse;
343
3b781fa1 344 inuse = kcalloc(BITS_TO_LONGS(BR_MAX_PORTS), sizeof(unsigned long),
1da177e4
LT
345 GFP_KERNEL);
346 if (!inuse)
347 return -ENOMEM;
348
1da177e4
LT
349 set_bit(0, inuse); /* zero is reserved */
350 list_for_each_entry(p, &br->port_list, list) {
351 set_bit(p->port_no, inuse);
352 }
353 index = find_first_zero_bit(inuse, BR_MAX_PORTS);
354 kfree(inuse);
355
356 return (index >= BR_MAX_PORTS) ? -EXFULL : index;
357}
358
4433f420 359/* called with RTNL but without bridge lock */
9d6f229f 360static struct net_bridge_port *new_nbp(struct net_bridge *br,
4433f420 361 struct net_device *dev)
1da177e4 362{
1da177e4 363 struct net_bridge_port *p;
1080ab95 364 int index, err;
9d6f229f 365
1da177e4
LT
366 index = find_portno(br);
367 if (index < 0)
368 return ERR_PTR(index);
369
cee48541 370 p = kzalloc(sizeof(*p), GFP_KERNEL);
1da177e4
LT
371 if (p == NULL)
372 return ERR_PTR(-ENOMEM);
373
1da177e4
LT
374 p->br = br;
375 dev_hold(dev);
376 p->dev = dev;
4433f420 377 p->path_cost = port_cost(dev);
9d6f229f 378 p->priority = 0x8000 >> BR_PORT_BITS;
1da177e4 379 p->port_no = index;
99f906e9 380 p->flags = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
1da177e4 381 br_init_port(p);
775dd692 382 br_set_state(p, BR_STATE_DISABLED);
d32439c0 383 br_stp_port_timer_init(p);
1080ab95
NA
384 err = br_multicast_add_port(p);
385 if (err) {
386 dev_put(dev);
387 kfree(p);
388 p = ERR_PTR(err);
389 }
1da177e4
LT
390
391 return p;
392}
393
4aa678ba 394int br_add_bridge(struct net *net, const char *name)
1da177e4
LT
395{
396 struct net_device *dev;
11f3a6bd 397 int res;
1da177e4 398
c835a677 399 dev = alloc_netdev(sizeof(struct net_bridge), name, NET_NAME_UNKNOWN,
bb900b27 400 br_dev_setup);
401
9d6f229f 402 if (!dev)
1da177e4
LT
403 return -ENOMEM;
404
bb900b27 405 dev_net_set(dev, net);
149ddd83 406 dev->rtnl_link_ops = &br_link_ops;
e340a90e 407
11f3a6bd
ED
408 res = register_netdev(dev);
409 if (res)
410 free_netdev(dev);
411 return res;
1da177e4
LT
412}
413
4aa678ba 414int br_del_bridge(struct net *net, const char *name)
1da177e4
LT
415{
416 struct net_device *dev;
417 int ret = 0;
418
419 rtnl_lock();
4aa678ba 420 dev = __dev_get_by_name(net, name);
9d6f229f 421 if (dev == NULL)
1da177e4
LT
422 ret = -ENXIO; /* Could not find device */
423
424 else if (!(dev->priv_flags & IFF_EBRIDGE)) {
425 /* Attempt to delete non bridge device! */
426 ret = -EPERM;
427 }
428
429 else if (dev->flags & IFF_UP) {
430 /* Not shutdown yet. */
431 ret = -EBUSY;
9d6f229f 432 }
1da177e4 433
9d6f229f 434 else
1ce5cce8 435 br_dev_delete(dev, NULL);
1da177e4
LT
436
437 rtnl_unlock();
438 return ret;
439}
440
804b854d
NA
441/* MTU of the bridge pseudo-device: ETH_DATA_LEN or the minimum of the ports */
442static int br_mtu_min(const struct net_bridge *br)
1da177e4
LT
443{
444 const struct net_bridge_port *p;
f40aa233 445 int ret_mtu = 0;
1da177e4 446
804b854d
NA
447 list_for_each_entry(p, &br->port_list, list)
448 if (!ret_mtu || ret_mtu > p->dev->mtu)
f40aa233 449 ret_mtu = p->dev->mtu;
1da177e4 450
f40aa233 451 return ret_mtu ? ret_mtu : ETH_DATA_LEN;
419d14af
CW
452}
453
804b854d
NA
454void br_mtu_auto_adjust(struct net_bridge *br)
455{
456 ASSERT_RTNL();
457
458 /* if the bridge MTU was manually configured don't mess with it */
459 if (br->mtu_set_by_user)
460 return;
461
462 /* change to the minimum MTU and clear the flag which was set by
463 * the bridge ndo_change_mtu callback
464 */
465 dev_set_mtu(br->dev, br_mtu_min(br));
466 br->mtu_set_by_user = false;
467}
468
ae74f100
ED
469static void br_set_gso_limits(struct net_bridge *br)
470{
471 unsigned int gso_max_size = GSO_MAX_SIZE;
472 u16 gso_max_segs = GSO_MAX_SEGS;
473 const struct net_bridge_port *p;
474
475 list_for_each_entry(p, &br->port_list, list) {
476 gso_max_size = min(gso_max_size, p->dev->gso_max_size);
477 gso_max_segs = min(gso_max_segs, p->dev->gso_max_segs);
478 }
479 br->dev->gso_max_size = gso_max_size;
480 br->dev->gso_max_segs = gso_max_segs;
481}
482
81d35307
SH
483/*
484 * Recomputes features using slave's features
485 */
c8f44aff
MM
486netdev_features_t br_features_recompute(struct net_bridge *br,
487 netdev_features_t features)
81d35307
SH
488{
489 struct net_bridge_port *p;
c8f44aff 490 netdev_features_t mask;
81d35307 491
b63365a2 492 if (list_empty(&br->port_list))
c4d27ef9 493 return features;
b63365a2 494
c4d27ef9 495 mask = features;
b63365a2 496 features &= ~NETIF_F_ONE_FOR_ALL;
81d35307
SH
497
498 list_for_each_entry(p, &br->port_list, list) {
b63365a2
HX
499 features = netdev_increment_features(features,
500 p->dev->features, mask);
81d35307 501 }
f902e881 502 features = netdev_add_tso_features(features, mask);
81d35307 503
c4d27ef9 504 return features;
81d35307
SH
505}
506
1da177e4 507/* called with RTNL */
ca752be0
DA
508int br_add_if(struct net_bridge *br, struct net_device *dev,
509 struct netlink_ext_ack *extack)
1da177e4
LT
510{
511 struct net_bridge_port *p;
512 int err = 0;
45493d47 513 unsigned br_hr, dev_hr;
edf947f1 514 bool changed_addr;
1da177e4 515
8db0a2ee
FF
516 /* Don't allow bridging non-ethernet like devices, or DSA-enabled
517 * master network devices since the bridge layer rx_handler prevents
518 * the DSA fake ethertype handler to be invoked, so we do not strip off
519 * the DSA switch tag protocol header and the bridge layer just return
520 * RX_HANDLER_CONSUMED, stopping RX processing for these frames.
521 */
1056bd51 522 if ((dev->flags & IFF_LOOPBACK) ||
77f98598 523 dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN ||
8db0a2ee
FF
524 !is_valid_ether_addr(dev->dev_addr) ||
525 netdev_uses_dsa(dev))
1da177e4
LT
526 return -EINVAL;
527
1056bd51 528 /* No bridging of bridges */
ca752be0
DA
529 if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit) {
530 NL_SET_ERR_MSG(extack,
531 "Can not enslave a bridge to a bridge");
1da177e4 532 return -ELOOP;
ca752be0 533 }
1da177e4 534
e8238fc2
HL
535 /* Device has master upper dev */
536 if (netdev_master_upper_dev_get(dev))
1da177e4
LT
537 return -EBUSY;
538
ad4bb6f8 539 /* No bridging devices that dislike that (e.g. wireless) */
ca752be0
DA
540 if (dev->priv_flags & IFF_DONT_BRIDGE) {
541 NL_SET_ERR_MSG(extack,
542 "Device does not allow enslaving to a bridge");
ad4bb6f8 543 return -EOPNOTSUPP;
ca752be0 544 }
ad4bb6f8 545
bab1deea
SH
546 p = new_nbp(br, dev);
547 if (IS_ERR(p))
1da177e4
LT
548 return PTR_ERR(p);
549
bb8ed630
AW
550 call_netdevice_notifiers(NETDEV_JOIN, dev);
551
2796d0c6 552 err = dev_set_allmulti(dev, 1);
bc3f9076
WC
553 if (err)
554 goto put_back;
555
e32cc736
GKH
556 err = kobject_init_and_add(&p->kobj, &brport_ktype, &(dev->dev.kobj),
557 SYSFS_BRIDGE_PORT_ATTR);
bab1deea
SH
558 if (err)
559 goto err1;
1da177e4 560
bab1deea
SH
561 err = br_sysfs_addif(p);
562 if (err)
563 goto err2;
1da177e4 564
a8779ec1 565 err = br_netpoll_enable(p);
93d8bf9f 566 if (err)
91d2c34a
HX
567 goto err3;
568
0f49579a 569 err = netdev_rx_handler_register(dev, br_handle_frame, p);
ab95bfe0 570 if (err)
9b1536c4 571 goto err4;
f350a0a8 572
0f49579a
JP
573 dev->priv_flags |= IFF_BRIDGE_PORT;
574
ca752be0 575 err = netdev_master_upper_dev_link(dev, br->dev, NULL, NULL, extack);
afc6151a 576 if (err)
9b1536c4 577 goto err5;
afc6151a 578
6bc506b4
IS
579 err = nbp_switchdev_mark_set(p);
580 if (err)
581 goto err6;
582
0187bdfb 583 dev_disable_lro(dev);
bab1deea
SH
584
585 list_add_rcu(&p->list, &br->port_list);
586
e028e4b8
VY
587 nbp_update_port_count(br);
588
c4d27ef9
MM
589 netdev_update_features(br->dev);
590
45493d47
PA
591 br_hr = br->dev->needed_headroom;
592 dev_hr = netdev_get_fwd_headroom(dev);
593 if (br_hr < dev_hr)
594 update_headroom(br, dev_hr);
595 else
596 netdev_set_rx_headroom(dev, br_hr);
fd094808 597
a4b816d8
TM
598 if (br_fdb_insert(br, p, dev->dev_addr, 0))
599 netdev_err(dev, "failed insert local address bridge forwarding table\n");
600
08474cc1
ER
601 err = nbp_vlan_init(p);
602 if (err) {
5be5a2df 603 netdev_err(dev, "failed to initialize vlan filtering on this port\n");
6bc506b4 604 goto err7;
08474cc1 605 }
5be5a2df 606
bab1deea 607 spin_lock_bh(&br->lock);
edf947f1 608 changed_addr = br_stp_recalculate_bridge_id(br);
de79059e 609
576eb625 610 if (netif_running(dev) && netif_oper_up(dev) &&
de79059e
AS
611 (br->dev->flags & IFF_UP))
612 br_stp_enable_port(p);
bab1deea
SH
613 spin_unlock_bh(&br->lock);
614
92899063 615 br_ifinfo_notify(RTM_NEWLINK, NULL, p);
b86c4503 616
edf947f1 617 if (changed_addr)
56139fc5 618 call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
edf947f1 619
804b854d 620 br_mtu_auto_adjust(br);
ae74f100 621 br_set_gso_limits(br);
269def7c 622
bab1deea 623 kobject_uevent(&p->kobj, KOBJ_ADD);
1da177e4 624
bab1deea 625 return 0;
afc6151a 626
6bc506b4 627err7:
08474cc1
ER
628 list_del_rcu(&p->list);
629 br_fdb_delete_by_port(br, p, 0, 1);
630 nbp_update_port_count(br);
6bc506b4 631err6:
08474cc1 632 netdev_upper_dev_unlink(dev, br->dev);
9b1536c4 633err5:
0f49579a
JP
634 dev->priv_flags &= ~IFF_BRIDGE_PORT;
635 netdev_rx_handler_unregister(dev);
9b1536c4
G
636err4:
637 br_netpoll_disable(p);
91d2c34a
HX
638err3:
639 sysfs_remove_link(br->ifobj, p->dev->name);
bab1deea 640err2:
c587aea9 641 kobject_put(&p->kobj);
30df94f8 642 p = NULL; /* kobject_put frees */
77f98598 643err1:
019ee792 644 dev_set_allmulti(dev, -1);
43af8532
VL
645put_back:
646 dev_put(dev);
bc3f9076 647 kfree(p);
1da177e4
LT
648 return err;
649}
650
651/* called with RTNL */
652int br_del_if(struct net_bridge *br, struct net_device *dev)
653{
f350a0a8 654 struct net_bridge_port *p;
9be6dd65 655 bool changed_addr;
f350a0a8 656
ec1e5610 657 p = br_port_get_rtnl(dev);
b5ed54e9 658 if (!p || p->br != br)
1da177e4
LT
659 return -EINVAL;
660
d30362c0
AW
661 /* Since more than one interface can be attached to a bridge,
662 * there still maybe an alternate path for netconsole to use;
663 * therefore there is no reason for a NETDEV_RELEASE event.
664 */
1da177e4
LT
665 del_nbp(p);
666
804b854d 667 br_mtu_auto_adjust(br);
ae74f100 668 br_set_gso_limits(br);
4c906c27 669
1da177e4 670 spin_lock_bh(&br->lock);
9be6dd65 671 changed_addr = br_stp_recalculate_bridge_id(br);
1da177e4
LT
672 spin_unlock_bh(&br->lock);
673
9be6dd65
AW
674 if (changed_addr)
675 call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
676
c4d27ef9
MM
677 netdev_update_features(br->dev);
678
1da177e4
LT
679 return 0;
680}
e028e4b8
VY
681
682void br_port_flags_change(struct net_bridge_port *p, unsigned long mask)
683{
684 struct net_bridge *br = p->br;
685
686 if (mask & BR_AUTO_MASK)
687 nbp_update_port_count(br);
821f1b21
RP
688
689 if (mask & BR_NEIGH_SUPPRESS)
690 br_recalculate_neigh_suppress_enabled(br);
e028e4b8 691}