Commit | Line | Data |
---|---|---|
1da177e4 LT |
1 | /* |
2 | * Userspace interface | |
3 | * Linux ethernet bridge | |
4 | * | |
5 | * Authors: | |
6 | * Lennert Buytenhek <buytenh@gnu.org> | |
7 | * | |
1da177e4 LT |
8 | * This program is free software; you can redistribute it and/or |
9 | * modify it under the terms of the GNU General Public License | |
10 | * as published by the Free Software Foundation; either version | |
11 | * 2 of the License, or (at your option) any later version. | |
12 | */ | |
13 | ||
14 | #include <linux/kernel.h> | |
15 | #include <linux/netdevice.h> | |
77f98598 | 16 | #include <linux/etherdevice.h> |
c06ee961 | 17 | #include <linux/netpoll.h> |
1da177e4 LT |
18 | #include <linux/ethtool.h> |
19 | #include <linux/if_arp.h> | |
20 | #include <linux/module.h> | |
21 | #include <linux/init.h> | |
22 | #include <linux/rtnetlink.h> | |
46f25dff | 23 | #include <linux/if_ether.h> |
5a0e3ad6 | 24 | #include <linux/slab.h> |
1da177e4 | 25 | #include <net/sock.h> |
407af329 | 26 | #include <linux/if_vlan.h> |
1da177e4 LT |
27 | |
28 | #include "br_private.h" | |
29 | ||
30 | /* | |
31 | * Determine initial path cost based on speed. | |
32 | * using recommendations from 802.1d standard | |
33 | * | |
61a44b9c | 34 | * Since driver might sleep need to not be holding any locks. |
1da177e4 | 35 | */ |
4433f420 | 36 | static int port_cost(struct net_device *dev) |
1da177e4 | 37 | { |
fa3df928 | 38 | struct ethtool_cmd ecmd; |
b4a488d1 | 39 | |
4bc71cb9 | 40 | if (!__ethtool_get_settings(dev, &ecmd)) { |
fa3df928 JP |
41 | switch (ethtool_cmd_speed(&ecmd)) { |
42 | case SPEED_10000: | |
43 | return 2; | |
44 | case SPEED_1000: | |
45 | return 4; | |
46 | case SPEED_100: | |
47 | return 19; | |
48 | case SPEED_10: | |
49 | return 100; | |
1da177e4 LT |
50 | } |
51 | } | |
52 | ||
53 | /* Old silly heuristics based on name */ | |
54 | if (!strncmp(dev->name, "lec", 3)) | |
55 | return 7; | |
56 | ||
57 | if (!strncmp(dev->name, "plip", 4)) | |
58 | return 2500; | |
59 | ||
60 | return 100; /* assume old 10Mbps */ | |
61 | } | |
62 | ||
4433f420 | 63 | |
1a81a2e0 | 64 | /* Check for port carrier transitions. */ |
269def7c | 65 | void br_port_carrier_check(struct net_bridge_port *p) |
4433f420 | 66 | { |
269def7c SH |
67 | struct net_device *dev = p->dev; |
68 | struct net_bridge *br = p->br; | |
6e86b890 | 69 | |
8f3359bd | 70 | if (!(p->flags & BR_ADMIN_COST) && |
71 | netif_running(dev) && netif_oper_up(dev)) | |
6e86b890 SH |
72 | p->path_cost = port_cost(dev); |
73 | ||
aa7c6e5f | 74 | if (!netif_running(br->dev)) |
75 | return; | |
76 | ||
77 | spin_lock_bh(&br->lock); | |
576eb625 | 78 | if (netif_running(dev) && netif_oper_up(dev)) { |
aa7c6e5f | 79 | if (p->state == BR_STATE_DISABLED) |
80 | br_stp_enable_port(p); | |
81 | } else { | |
82 | if (p->state != BR_STATE_DISABLED) | |
83 | br_stp_disable_port(p); | |
4433f420 | 84 | } |
aa7c6e5f | 85 | spin_unlock_bh(&br->lock); |
4433f420 SH |
86 | } |
87 | ||
2796d0c6 VY |
88 | static void br_port_set_promisc(struct net_bridge_port *p) |
89 | { | |
90 | int err = 0; | |
91 | ||
92 | if (br_promisc_port(p)) | |
93 | return; | |
94 | ||
95 | err = dev_set_promiscuity(p->dev, 1); | |
96 | if (err) | |
97 | return; | |
98 | ||
99 | br_fdb_unsync_static(p->br, p); | |
100 | p->flags |= BR_PROMISC; | |
101 | } | |
102 | ||
103 | static void br_port_clear_promisc(struct net_bridge_port *p) | |
104 | { | |
105 | int err; | |
106 | ||
107 | /* Check if the port is already non-promisc or if it doesn't | |
108 | * support UNICAST filtering. Without unicast filtering support | |
109 | * we'll end up re-enabling promisc mode anyway, so just check for | |
110 | * it here. | |
111 | */ | |
112 | if (!br_promisc_port(p) || !(p->dev->priv_flags & IFF_UNICAST_FLT)) | |
113 | return; | |
114 | ||
115 | /* Since we'll be clearing the promisc mode, program the port | |
116 | * first so that we don't have interruption in traffic. | |
117 | */ | |
118 | err = br_fdb_sync_static(p->br, p); | |
119 | if (err) | |
120 | return; | |
121 | ||
122 | dev_set_promiscuity(p->dev, -1); | |
123 | p->flags &= ~BR_PROMISC; | |
124 | } | |
125 | ||
126 | /* When a port is added or removed or when certain port flags | |
127 | * change, this function is called to automatically manage | |
128 | * promiscuity setting of all the bridge ports. We are always called | |
129 | * under RTNL so can skip using rcu primitives. | |
130 | */ | |
131 | void br_manage_promisc(struct net_bridge *br) | |
132 | { | |
133 | struct net_bridge_port *p; | |
134 | bool set_all = false; | |
135 | ||
136 | /* If vlan filtering is disabled or bridge interface is placed | |
137 | * into promiscuous mode, place all ports in promiscuous mode. | |
138 | */ | |
139 | if ((br->dev->flags & IFF_PROMISC) || !br_vlan_enabled(br)) | |
140 | set_all = true; | |
141 | ||
142 | list_for_each_entry(p, &br->port_list, list) { | |
143 | if (set_all) { | |
144 | br_port_set_promisc(p); | |
145 | } else { | |
146 | /* If the number of auto-ports is <= 1, then all other | |
147 | * ports will have their output configuration | |
148 | * statically specified through fdbs. Since ingress | |
149 | * on the auto-port becomes forwarding/egress to other | |
150 | * ports and egress configuration is statically known, | |
151 | * we can say that ingress configuration of the | |
152 | * auto-port is also statically known. | |
153 | * This lets us disable promiscuous mode and write | |
154 | * this config to hw. | |
155 | */ | |
e0a47d1f TM |
156 | if (br->auto_cnt == 0 || |
157 | (br->auto_cnt == 1 && br_auto_port(p))) | |
2796d0c6 VY |
158 | br_port_clear_promisc(p); |
159 | else | |
160 | br_port_set_promisc(p); | |
161 | } | |
162 | } | |
163 | } | |
164 | ||
e028e4b8 VY |
165 | static void nbp_update_port_count(struct net_bridge *br) |
166 | { | |
167 | struct net_bridge_port *p; | |
168 | u32 cnt = 0; | |
169 | ||
170 | list_for_each_entry(p, &br->port_list, list) { | |
171 | if (br_auto_port(p)) | |
172 | cnt++; | |
173 | } | |
2796d0c6 VY |
174 | if (br->auto_cnt != cnt) { |
175 | br->auto_cnt = cnt; | |
176 | br_manage_promisc(br); | |
177 | } | |
178 | } | |
179 | ||
180 | static void nbp_delete_promisc(struct net_bridge_port *p) | |
181 | { | |
025559ee | 182 | /* If port is currently promiscuous, unset promiscuity. |
2796d0c6 VY |
183 | * Otherwise, it is a static port so remove all addresses |
184 | * from it. | |
185 | */ | |
186 | dev_set_allmulti(p->dev, -1); | |
187 | if (br_promisc_port(p)) | |
188 | dev_set_promiscuity(p->dev, -1); | |
189 | else | |
190 | br_fdb_unsync_static(p->br, p); | |
e028e4b8 VY |
191 | } |
192 | ||
bab1deea SH |
193 | static void release_nbp(struct kobject *kobj) |
194 | { | |
195 | struct net_bridge_port *p | |
196 | = container_of(kobj, struct net_bridge_port, kobj); | |
197 | kfree(p); | |
198 | } | |
199 | ||
200 | static struct kobj_type brport_ktype = { | |
201 | #ifdef CONFIG_SYSFS | |
202 | .sysfs_ops = &brport_sysfs_ops, | |
203 | #endif | |
204 | .release = release_nbp, | |
205 | }; | |
206 | ||
1da177e4 LT |
207 | static void destroy_nbp(struct net_bridge_port *p) |
208 | { | |
209 | struct net_device *dev = p->dev; | |
210 | ||
1da177e4 LT |
211 | p->br = NULL; |
212 | p->dev = NULL; | |
213 | dev_put(dev); | |
214 | ||
bab1deea | 215 | kobject_put(&p->kobj); |
1da177e4 LT |
216 | } |
217 | ||
218 | static void destroy_nbp_rcu(struct rcu_head *head) | |
219 | { | |
220 | struct net_bridge_port *p = | |
221 | container_of(head, struct net_bridge_port, rcu); | |
222 | destroy_nbp(p); | |
223 | } | |
224 | ||
3f4cfc2d SH |
225 | /* Delete port(interface) from bridge is done in two steps. |
226 | * via RCU. First step, marks device as down. That deletes | |
227 | * all the timers and stops new packets from flowing through. | |
228 | * | |
229 | * Final cleanup doesn't occur until after all CPU's finished | |
230 | * processing packets. | |
231 | * | |
232 | * Protected from multiple admin operations by RTNL mutex | |
233 | */ | |
1da177e4 LT |
234 | static void del_nbp(struct net_bridge_port *p) |
235 | { | |
236 | struct net_bridge *br = p->br; | |
237 | struct net_device *dev = p->dev; | |
238 | ||
b3bcb72e | 239 | sysfs_remove_link(br->ifobj, p->dev->name); |
bab1deea | 240 | |
2796d0c6 | 241 | nbp_delete_promisc(p); |
1da177e4 LT |
242 | |
243 | spin_lock_bh(&br->lock); | |
244 | br_stp_disable_port(p); | |
245 | spin_unlock_bh(&br->lock); | |
246 | ||
b86c4503 SH |
247 | br_ifinfo_notify(RTM_DELLINK, p); |
248 | ||
1da177e4 LT |
249 | list_del_rcu(&p->list); |
250 | ||
2796d0c6 | 251 | nbp_vlan_flush(p); |
1ea2d020 | 252 | br_fdb_delete_by_port(br, p, 0, 1); |
e028e4b8 VY |
253 | nbp_update_port_count(br); |
254 | ||
0f49579a JP |
255 | netdev_upper_dev_unlink(dev, br->dev); |
256 | ||
f350a0a8 JP |
257 | dev->priv_flags &= ~IFF_BRIDGE_PORT; |
258 | ||
ab95bfe0 | 259 | netdev_rx_handler_unregister(dev); |
b3f1be4b | 260 | |
3fe2d7c7 HX |
261 | br_multicast_del_port(p); |
262 | ||
125a12cc | 263 | kobject_uevent(&p->kobj, KOBJ_REMOVE); |
bab1deea SH |
264 | kobject_del(&p->kobj); |
265 | ||
91d2c34a HX |
266 | br_netpoll_disable(p); |
267 | ||
1da177e4 LT |
268 | call_rcu(&p->rcu, destroy_nbp_rcu); |
269 | } | |
270 | ||
1ce5cce8 | 271 | /* Delete bridge device */ |
272 | void br_dev_delete(struct net_device *dev, struct list_head *head) | |
1da177e4 | 273 | { |
1ce5cce8 | 274 | struct net_bridge *br = netdev_priv(dev); |
1da177e4 LT |
275 | struct net_bridge_port *p, *n; |
276 | ||
277 | list_for_each_entry_safe(p, n, &br->port_list, list) { | |
1da177e4 LT |
278 | del_nbp(p); |
279 | } | |
280 | ||
1ea2d020 | 281 | br_fdb_delete_by_port(br, NULL, 0, 1); |
f8730420 | 282 | |
b4e09b29 | 283 | br_vlan_flush(br); |
e10177ab | 284 | br_multicast_dev_del(br); |
1da177e4 LT |
285 | del_timer_sync(&br->gc_timer); |
286 | ||
287 | br_sysfs_delbr(br->dev); | |
8c56ba05 | 288 | unregister_netdevice_queue(br->dev, head); |
1da177e4 LT |
289 | } |
290 | ||
1da177e4 LT |
291 | /* find an available port number */ |
292 | static int find_portno(struct net_bridge *br) | |
293 | { | |
294 | int index; | |
295 | struct net_bridge_port *p; | |
296 | unsigned long *inuse; | |
297 | ||
3b781fa1 | 298 | inuse = kcalloc(BITS_TO_LONGS(BR_MAX_PORTS), sizeof(unsigned long), |
1da177e4 LT |
299 | GFP_KERNEL); |
300 | if (!inuse) | |
301 | return -ENOMEM; | |
302 | ||
1da177e4 LT |
303 | set_bit(0, inuse); /* zero is reserved */ |
304 | list_for_each_entry(p, &br->port_list, list) { | |
305 | set_bit(p->port_no, inuse); | |
306 | } | |
307 | index = find_first_zero_bit(inuse, BR_MAX_PORTS); | |
308 | kfree(inuse); | |
309 | ||
310 | return (index >= BR_MAX_PORTS) ? -EXFULL : index; | |
311 | } | |
312 | ||
4433f420 | 313 | /* called with RTNL but without bridge lock */ |
9d6f229f | 314 | static struct net_bridge_port *new_nbp(struct net_bridge *br, |
4433f420 | 315 | struct net_device *dev) |
1da177e4 LT |
316 | { |
317 | int index; | |
318 | struct net_bridge_port *p; | |
9d6f229f | 319 | |
1da177e4 LT |
320 | index = find_portno(br); |
321 | if (index < 0) | |
322 | return ERR_PTR(index); | |
323 | ||
cee48541 | 324 | p = kzalloc(sizeof(*p), GFP_KERNEL); |
1da177e4 LT |
325 | if (p == NULL) |
326 | return ERR_PTR(-ENOMEM); | |
327 | ||
1da177e4 LT |
328 | p->br = br; |
329 | dev_hold(dev); | |
330 | p->dev = dev; | |
4433f420 | 331 | p->path_cost = port_cost(dev); |
9d6f229f | 332 | p->priority = 0x8000 >> BR_PORT_BITS; |
1da177e4 | 333 | p->port_no = index; |
2796d0c6 | 334 | p->flags = BR_LEARNING | BR_FLOOD; |
1da177e4 | 335 | br_init_port(p); |
775dd692 | 336 | br_set_state(p, BR_STATE_DISABLED); |
d32439c0 | 337 | br_stp_port_timer_init(p); |
3fe2d7c7 | 338 | br_multicast_add_port(p); |
1da177e4 LT |
339 | |
340 | return p; | |
341 | } | |
342 | ||
4aa678ba | 343 | int br_add_bridge(struct net *net, const char *name) |
1da177e4 LT |
344 | { |
345 | struct net_device *dev; | |
11f3a6bd | 346 | int res; |
1da177e4 | 347 | |
c835a677 | 348 | dev = alloc_netdev(sizeof(struct net_bridge), name, NET_NAME_UNKNOWN, |
bb900b27 | 349 | br_dev_setup); |
350 | ||
9d6f229f | 351 | if (!dev) |
1da177e4 LT |
352 | return -ENOMEM; |
353 | ||
bb900b27 | 354 | dev_net_set(dev, net); |
149ddd83 | 355 | dev->rtnl_link_ops = &br_link_ops; |
e340a90e | 356 | |
11f3a6bd ED |
357 | res = register_netdev(dev); |
358 | if (res) | |
359 | free_netdev(dev); | |
360 | return res; | |
1da177e4 LT |
361 | } |
362 | ||
4aa678ba | 363 | int br_del_bridge(struct net *net, const char *name) |
1da177e4 LT |
364 | { |
365 | struct net_device *dev; | |
366 | int ret = 0; | |
367 | ||
368 | rtnl_lock(); | |
4aa678ba | 369 | dev = __dev_get_by_name(net, name); |
9d6f229f | 370 | if (dev == NULL) |
1da177e4 LT |
371 | ret = -ENXIO; /* Could not find device */ |
372 | ||
373 | else if (!(dev->priv_flags & IFF_EBRIDGE)) { | |
374 | /* Attempt to delete non bridge device! */ | |
375 | ret = -EPERM; | |
376 | } | |
377 | ||
378 | else if (dev->flags & IFF_UP) { | |
379 | /* Not shutdown yet. */ | |
380 | ret = -EBUSY; | |
9d6f229f | 381 | } |
1da177e4 | 382 | |
9d6f229f | 383 | else |
1ce5cce8 | 384 | br_dev_delete(dev, NULL); |
1da177e4 LT |
385 | |
386 | rtnl_unlock(); | |
387 | return ret; | |
388 | } | |
389 | ||
46f25dff | 390 | /* MTU of the bridge pseudo-device: ETH_DATA_LEN or the minimum of the ports */ |
1da177e4 LT |
391 | int br_min_mtu(const struct net_bridge *br) |
392 | { | |
393 | const struct net_bridge_port *p; | |
394 | int mtu = 0; | |
395 | ||
396 | ASSERT_RTNL(); | |
397 | ||
398 | if (list_empty(&br->port_list)) | |
46f25dff | 399 | mtu = ETH_DATA_LEN; |
1da177e4 LT |
400 | else { |
401 | list_for_each_entry(p, &br->port_list, list) { | |
402 | if (!mtu || p->dev->mtu < mtu) | |
403 | mtu = p->dev->mtu; | |
404 | } | |
405 | } | |
406 | return mtu; | |
407 | } | |
408 | ||
81d35307 SH |
409 | /* |
410 | * Recomputes features using slave's features | |
411 | */ | |
c8f44aff MM |
412 | netdev_features_t br_features_recompute(struct net_bridge *br, |
413 | netdev_features_t features) | |
81d35307 SH |
414 | { |
415 | struct net_bridge_port *p; | |
c8f44aff | 416 | netdev_features_t mask; |
81d35307 | 417 | |
b63365a2 | 418 | if (list_empty(&br->port_list)) |
c4d27ef9 | 419 | return features; |
b63365a2 | 420 | |
c4d27ef9 | 421 | mask = features; |
b63365a2 | 422 | features &= ~NETIF_F_ONE_FOR_ALL; |
81d35307 SH |
423 | |
424 | list_for_each_entry(p, &br->port_list, list) { | |
b63365a2 HX |
425 | features = netdev_increment_features(features, |
426 | p->dev->features, mask); | |
81d35307 | 427 | } |
f902e881 | 428 | features = netdev_add_tso_features(features, mask); |
81d35307 | 429 | |
c4d27ef9 | 430 | return features; |
81d35307 SH |
431 | } |
432 | ||
1da177e4 LT |
433 | /* called with RTNL */ |
434 | int br_add_if(struct net_bridge *br, struct net_device *dev) | |
435 | { | |
436 | struct net_bridge_port *p; | |
437 | int err = 0; | |
edf947f1 | 438 | bool changed_addr; |
1da177e4 | 439 | |
8db0a2ee FF |
440 | /* Don't allow bridging non-ethernet like devices, or DSA-enabled |
441 | * master network devices since the bridge layer rx_handler prevents | |
442 | * the DSA fake ethertype handler to be invoked, so we do not strip off | |
443 | * the DSA switch tag protocol header and the bridge layer just return | |
444 | * RX_HANDLER_CONSUMED, stopping RX processing for these frames. | |
445 | */ | |
1056bd51 | 446 | if ((dev->flags & IFF_LOOPBACK) || |
77f98598 | 447 | dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN || |
8db0a2ee FF |
448 | !is_valid_ether_addr(dev->dev_addr) || |
449 | netdev_uses_dsa(dev)) | |
1da177e4 LT |
450 | return -EINVAL; |
451 | ||
1056bd51 | 452 | /* No bridging of bridges */ |
00829823 | 453 | if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit) |
1da177e4 LT |
454 | return -ELOOP; |
455 | ||
1056bd51 | 456 | /* Device is already being bridged */ |
f350a0a8 | 457 | if (br_port_exists(dev)) |
1da177e4 LT |
458 | return -EBUSY; |
459 | ||
ad4bb6f8 JB |
460 | /* No bridging devices that dislike that (e.g. wireless) */ |
461 | if (dev->priv_flags & IFF_DONT_BRIDGE) | |
462 | return -EOPNOTSUPP; | |
463 | ||
bab1deea SH |
464 | p = new_nbp(br, dev); |
465 | if (IS_ERR(p)) | |
1da177e4 LT |
466 | return PTR_ERR(p); |
467 | ||
bb8ed630 AW |
468 | call_netdevice_notifiers(NETDEV_JOIN, dev); |
469 | ||
2796d0c6 | 470 | err = dev_set_allmulti(dev, 1); |
bc3f9076 WC |
471 | if (err) |
472 | goto put_back; | |
473 | ||
e32cc736 GKH |
474 | err = kobject_init_and_add(&p->kobj, &brport_ktype, &(dev->dev.kobj), |
475 | SYSFS_BRIDGE_PORT_ATTR); | |
bab1deea SH |
476 | if (err) |
477 | goto err1; | |
1da177e4 | 478 | |
bab1deea SH |
479 | err = br_sysfs_addif(p); |
480 | if (err) | |
481 | goto err2; | |
1da177e4 | 482 | |
a8779ec1 | 483 | err = br_netpoll_enable(p); |
93d8bf9f | 484 | if (err) |
91d2c34a HX |
485 | goto err3; |
486 | ||
0f49579a | 487 | err = netdev_rx_handler_register(dev, br_handle_frame, p); |
ab95bfe0 | 488 | if (err) |
9b1536c4 | 489 | goto err4; |
f350a0a8 | 490 | |
0f49579a JP |
491 | dev->priv_flags |= IFF_BRIDGE_PORT; |
492 | ||
493 | err = netdev_master_upper_dev_link(dev, br->dev); | |
afc6151a | 494 | if (err) |
9b1536c4 | 495 | goto err5; |
afc6151a | 496 | |
0187bdfb | 497 | dev_disable_lro(dev); |
bab1deea SH |
498 | |
499 | list_add_rcu(&p->list, &br->port_list); | |
500 | ||
e028e4b8 VY |
501 | nbp_update_port_count(br); |
502 | ||
c4d27ef9 MM |
503 | netdev_update_features(br->dev); |
504 | ||
fd094808 FF |
505 | if (br->dev->needed_headroom < dev->needed_headroom) |
506 | br->dev->needed_headroom = dev->needed_headroom; | |
507 | ||
a4b816d8 TM |
508 | if (br_fdb_insert(br, p, dev->dev_addr, 0)) |
509 | netdev_err(dev, "failed insert local address bridge forwarding table\n"); | |
510 | ||
5be5a2df VY |
511 | if (nbp_vlan_init(p)) |
512 | netdev_err(dev, "failed to initialize vlan filtering on this port\n"); | |
513 | ||
bab1deea | 514 | spin_lock_bh(&br->lock); |
edf947f1 | 515 | changed_addr = br_stp_recalculate_bridge_id(br); |
de79059e | 516 | |
576eb625 | 517 | if (netif_running(dev) && netif_oper_up(dev) && |
de79059e AS |
518 | (br->dev->flags & IFF_UP)) |
519 | br_stp_enable_port(p); | |
bab1deea SH |
520 | spin_unlock_bh(&br->lock); |
521 | ||
b86c4503 SH |
522 | br_ifinfo_notify(RTM_NEWLINK, p); |
523 | ||
edf947f1 | 524 | if (changed_addr) |
56139fc5 | 525 | call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev); |
edf947f1 | 526 | |
bab1deea | 527 | dev_set_mtu(br->dev, br_min_mtu(br)); |
269def7c | 528 | |
bab1deea | 529 | kobject_uevent(&p->kobj, KOBJ_ADD); |
1da177e4 | 530 | |
bab1deea | 531 | return 0; |
afc6151a | 532 | |
9b1536c4 | 533 | err5: |
0f49579a JP |
534 | dev->priv_flags &= ~IFF_BRIDGE_PORT; |
535 | netdev_rx_handler_unregister(dev); | |
9b1536c4 G |
536 | err4: |
537 | br_netpoll_disable(p); | |
91d2c34a HX |
538 | err3: |
539 | sysfs_remove_link(br->ifobj, p->dev->name); | |
bab1deea | 540 | err2: |
c587aea9 | 541 | kobject_put(&p->kobj); |
30df94f8 | 542 | p = NULL; /* kobject_put frees */ |
77f98598 | 543 | err1: |
019ee792 | 544 | dev_set_allmulti(dev, -1); |
43af8532 VL |
545 | put_back: |
546 | dev_put(dev); | |
bc3f9076 | 547 | kfree(p); |
1da177e4 LT |
548 | return err; |
549 | } | |
550 | ||
551 | /* called with RTNL */ | |
552 | int br_del_if(struct net_bridge *br, struct net_device *dev) | |
553 | { | |
f350a0a8 | 554 | struct net_bridge_port *p; |
9be6dd65 | 555 | bool changed_addr; |
f350a0a8 | 556 | |
ec1e5610 | 557 | p = br_port_get_rtnl(dev); |
b5ed54e9 | 558 | if (!p || p->br != br) |
1da177e4 LT |
559 | return -EINVAL; |
560 | ||
d30362c0 AW |
561 | /* Since more than one interface can be attached to a bridge, |
562 | * there still maybe an alternate path for netconsole to use; | |
563 | * therefore there is no reason for a NETDEV_RELEASE event. | |
564 | */ | |
1da177e4 LT |
565 | del_nbp(p); |
566 | ||
4c906c27 VV |
567 | dev_set_mtu(br->dev, br_min_mtu(br)); |
568 | ||
1da177e4 | 569 | spin_lock_bh(&br->lock); |
9be6dd65 | 570 | changed_addr = br_stp_recalculate_bridge_id(br); |
1da177e4 LT |
571 | spin_unlock_bh(&br->lock); |
572 | ||
9be6dd65 AW |
573 | if (changed_addr) |
574 | call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev); | |
575 | ||
c4d27ef9 MM |
576 | netdev_update_features(br->dev); |
577 | ||
1da177e4 LT |
578 | return 0; |
579 | } | |
e028e4b8 VY |
580 | |
581 | void br_port_flags_change(struct net_bridge_port *p, unsigned long mask) | |
582 | { | |
583 | struct net_bridge *br = p->br; | |
584 | ||
585 | if (mask & BR_AUTO_MASK) | |
586 | nbp_update_port_count(br); | |
587 | } |