selftests: bpf: add trivial JSET tests
[linux-block.git] / kernel / bpf / verifier.c
CommitLineData
51580e79 1/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
969bf05e 2 * Copyright (c) 2016 Facebook
fd978bf7 3 * Copyright (c) 2018 Covalent IO, Inc. http://covalent.io
51580e79
AS
4 *
5 * This program is free software; you can redistribute it and/or
6 * modify it under the terms of version 2 of the GNU General Public
7 * License as published by the Free Software Foundation.
8 *
9 * This program is distributed in the hope that it will be useful, but
10 * WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * General Public License for more details.
13 */
838e9690 14#include <uapi/linux/btf.h>
51580e79
AS
15#include <linux/kernel.h>
16#include <linux/types.h>
17#include <linux/slab.h>
18#include <linux/bpf.h>
838e9690 19#include <linux/btf.h>
58e2af8b 20#include <linux/bpf_verifier.h>
51580e79
AS
21#include <linux/filter.h>
22#include <net/netlink.h>
23#include <linux/file.h>
24#include <linux/vmalloc.h>
ebb676da 25#include <linux/stringify.h>
cc8b0b92
AS
26#include <linux/bsearch.h>
27#include <linux/sort.h>
c195651e 28#include <linux/perf_event.h>
d9762e84 29#include <linux/ctype.h>
51580e79 30
f4ac7e0b
JK
31#include "disasm.h"
32
00176a34
JK
33static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
34#define BPF_PROG_TYPE(_id, _name) \
35 [_id] = & _name ## _verifier_ops,
36#define BPF_MAP_TYPE(_id, _ops)
37#include <linux/bpf_types.h>
38#undef BPF_PROG_TYPE
39#undef BPF_MAP_TYPE
40};
41
51580e79
AS
42/* bpf_check() is a static code analyzer that walks eBPF program
43 * instruction by instruction and updates register/stack state.
44 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
45 *
46 * The first pass is depth-first-search to check that the program is a DAG.
47 * It rejects the following programs:
48 * - larger than BPF_MAXINSNS insns
49 * - if loop is present (detected via back-edge)
50 * - unreachable insns exist (shouldn't be a forest. program = one function)
51 * - out of bounds or malformed jumps
52 * The second pass is all possible path descent from the 1st insn.
53 * Since it's analyzing all pathes through the program, the length of the
eba38a96 54 * analysis is limited to 64k insn, which may be hit even if total number of
51580e79
AS
55 * insn is less then 4K, but there are too many branches that change stack/regs.
56 * Number of 'branches to be analyzed' is limited to 1k
57 *
58 * On entry to each instruction, each register has a type, and the instruction
59 * changes the types of the registers depending on instruction semantics.
60 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
61 * copied to R1.
62 *
63 * All registers are 64-bit.
64 * R0 - return register
65 * R1-R5 argument passing registers
66 * R6-R9 callee saved registers
67 * R10 - frame pointer read-only
68 *
69 * At the start of BPF program the register R1 contains a pointer to bpf_context
70 * and has type PTR_TO_CTX.
71 *
72 * Verifier tracks arithmetic operations on pointers in case:
73 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
74 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
75 * 1st insn copies R10 (which has FRAME_PTR) type into R1
76 * and 2nd arithmetic instruction is pattern matched to recognize
77 * that it wants to construct a pointer to some element within stack.
78 * So after 2nd insn, the register R1 has type PTR_TO_STACK
79 * (and -20 constant is saved for further stack bounds checking).
80 * Meaning that this reg is a pointer to stack plus known immediate constant.
81 *
f1174f77 82 * Most of the time the registers have SCALAR_VALUE type, which
51580e79 83 * means the register has some value, but it's not a valid pointer.
f1174f77 84 * (like pointer plus pointer becomes SCALAR_VALUE type)
51580e79
AS
85 *
86 * When verifier sees load or store instructions the type of base register
c64b7983
JS
87 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK, PTR_TO_SOCKET. These are
88 * four pointer types recognized by check_mem_access() function.
51580e79
AS
89 *
90 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
91 * and the range of [ptr, ptr + map's value_size) is accessible.
92 *
93 * registers used to pass values to function calls are checked against
94 * function argument constraints.
95 *
96 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
97 * It means that the register type passed to this function must be
98 * PTR_TO_STACK and it will be used inside the function as
99 * 'pointer to map element key'
100 *
101 * For example the argument constraints for bpf_map_lookup_elem():
102 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
103 * .arg1_type = ARG_CONST_MAP_PTR,
104 * .arg2_type = ARG_PTR_TO_MAP_KEY,
105 *
106 * ret_type says that this function returns 'pointer to map elem value or null'
107 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
108 * 2nd argument should be a pointer to stack, which will be used inside
109 * the helper function as a pointer to map element key.
110 *
111 * On the kernel side the helper function looks like:
112 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
113 * {
114 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
115 * void *key = (void *) (unsigned long) r2;
116 * void *value;
117 *
118 * here kernel can access 'key' and 'map' pointers safely, knowing that
119 * [key, key + map->key_size) bytes are valid and were initialized on
120 * the stack of eBPF program.
121 * }
122 *
123 * Corresponding eBPF program may look like:
124 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
125 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
126 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
127 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
128 * here verifier looks at prototype of map_lookup_elem() and sees:
129 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
130 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
131 *
132 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
133 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
134 * and were initialized prior to this call.
135 * If it's ok, then verifier allows this BPF_CALL insn and looks at
136 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
137 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
138 * returns ether pointer to map value or NULL.
139 *
140 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
141 * insn, the register holding that pointer in the true branch changes state to
142 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
143 * branch. See check_cond_jmp_op().
144 *
145 * After the call R0 is set to return type of the function and registers R1-R5
146 * are set to NOT_INIT to indicate that they are no longer readable.
fd978bf7
JS
147 *
148 * The following reference types represent a potential reference to a kernel
149 * resource which, after first being allocated, must be checked and freed by
150 * the BPF program:
151 * - PTR_TO_SOCKET_OR_NULL, PTR_TO_SOCKET
152 *
153 * When the verifier sees a helper call return a reference type, it allocates a
154 * pointer id for the reference and stores it in the current function state.
155 * Similar to the way that PTR_TO_MAP_VALUE_OR_NULL is converted into
156 * PTR_TO_MAP_VALUE, PTR_TO_SOCKET_OR_NULL becomes PTR_TO_SOCKET when the type
157 * passes through a NULL-check conditional. For the branch wherein the state is
158 * changed to CONST_IMM, the verifier releases the reference.
6acc9b43
JS
159 *
160 * For each helper function that allocates a reference, such as
161 * bpf_sk_lookup_tcp(), there is a corresponding release function, such as
162 * bpf_sk_release(). When a reference type passes into the release function,
163 * the verifier also releases the reference. If any unchecked or unreleased
164 * reference remains at the end of the program, the verifier rejects it.
51580e79
AS
165 */
166
17a52670 167/* verifier_state + insn_idx are pushed to stack when branch is encountered */
58e2af8b 168struct bpf_verifier_stack_elem {
17a52670
AS
169 /* verifer state is 'st'
170 * before processing instruction 'insn_idx'
171 * and after processing instruction 'prev_insn_idx'
172 */
58e2af8b 173 struct bpf_verifier_state st;
17a52670
AS
174 int insn_idx;
175 int prev_insn_idx;
58e2af8b 176 struct bpf_verifier_stack_elem *next;
cbd35700
AS
177};
178
8e17c1b1 179#define BPF_COMPLEXITY_LIMIT_INSNS 131072
07016151 180#define BPF_COMPLEXITY_LIMIT_STACK 1024
ceefbc96 181#define BPF_COMPLEXITY_LIMIT_STATES 64
07016151 182
c93552c4
DB
183#define BPF_MAP_PTR_UNPRIV 1UL
184#define BPF_MAP_PTR_POISON ((void *)((0xeB9FUL << 1) + \
185 POISON_POINTER_DELTA))
186#define BPF_MAP_PTR(X) ((struct bpf_map *)((X) & ~BPF_MAP_PTR_UNPRIV))
187
188static bool bpf_map_ptr_poisoned(const struct bpf_insn_aux_data *aux)
189{
190 return BPF_MAP_PTR(aux->map_state) == BPF_MAP_PTR_POISON;
191}
192
193static bool bpf_map_ptr_unpriv(const struct bpf_insn_aux_data *aux)
194{
195 return aux->map_state & BPF_MAP_PTR_UNPRIV;
196}
197
198static void bpf_map_ptr_store(struct bpf_insn_aux_data *aux,
199 const struct bpf_map *map, bool unpriv)
200{
201 BUILD_BUG_ON((unsigned long)BPF_MAP_PTR_POISON & BPF_MAP_PTR_UNPRIV);
202 unpriv |= bpf_map_ptr_unpriv(aux);
203 aux->map_state = (unsigned long)map |
204 (unpriv ? BPF_MAP_PTR_UNPRIV : 0UL);
205}
fad73a1a 206
33ff9823
DB
207struct bpf_call_arg_meta {
208 struct bpf_map *map_ptr;
435faee1 209 bool raw_mode;
36bbef52 210 bool pkt_access;
435faee1
DB
211 int regno;
212 int access_size;
849fa506
YS
213 s64 msize_smax_value;
214 u64 msize_umax_value;
fd978bf7 215 int ptr_id;
33ff9823
DB
216};
217
cbd35700
AS
218static DEFINE_MUTEX(bpf_verifier_lock);
219
d9762e84
MKL
220static const struct bpf_line_info *
221find_linfo(const struct bpf_verifier_env *env, u32 insn_off)
222{
223 const struct bpf_line_info *linfo;
224 const struct bpf_prog *prog;
225 u32 i, nr_linfo;
226
227 prog = env->prog;
228 nr_linfo = prog->aux->nr_linfo;
229
230 if (!nr_linfo || insn_off >= prog->len)
231 return NULL;
232
233 linfo = prog->aux->linfo;
234 for (i = 1; i < nr_linfo; i++)
235 if (insn_off < linfo[i].insn_off)
236 break;
237
238 return &linfo[i - 1];
239}
240
77d2e05a
MKL
241void bpf_verifier_vlog(struct bpf_verifier_log *log, const char *fmt,
242 va_list args)
cbd35700 243{
a2a7d570 244 unsigned int n;
cbd35700 245
a2a7d570 246 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
a2a7d570
JK
247
248 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
249 "verifier log line truncated - local buffer too short\n");
250
251 n = min(log->len_total - log->len_used - 1, n);
252 log->kbuf[n] = '\0';
253
254 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
255 log->len_used += n;
256 else
257 log->ubuf = NULL;
cbd35700 258}
abe08840
JO
259
260/* log_level controls verbosity level of eBPF verifier.
261 * bpf_verifier_log_write() is used to dump the verification trace to the log,
262 * so the user can figure out what's wrong with the program
430e68d1 263 */
abe08840
JO
264__printf(2, 3) void bpf_verifier_log_write(struct bpf_verifier_env *env,
265 const char *fmt, ...)
266{
267 va_list args;
268
77d2e05a
MKL
269 if (!bpf_verifier_log_needed(&env->log))
270 return;
271
abe08840 272 va_start(args, fmt);
77d2e05a 273 bpf_verifier_vlog(&env->log, fmt, args);
abe08840
JO
274 va_end(args);
275}
276EXPORT_SYMBOL_GPL(bpf_verifier_log_write);
277
278__printf(2, 3) static void verbose(void *private_data, const char *fmt, ...)
279{
77d2e05a 280 struct bpf_verifier_env *env = private_data;
abe08840
JO
281 va_list args;
282
77d2e05a
MKL
283 if (!bpf_verifier_log_needed(&env->log))
284 return;
285
abe08840 286 va_start(args, fmt);
77d2e05a 287 bpf_verifier_vlog(&env->log, fmt, args);
abe08840
JO
288 va_end(args);
289}
cbd35700 290
d9762e84
MKL
291static const char *ltrim(const char *s)
292{
293 while (isspace(*s))
294 s++;
295
296 return s;
297}
298
299__printf(3, 4) static void verbose_linfo(struct bpf_verifier_env *env,
300 u32 insn_off,
301 const char *prefix_fmt, ...)
302{
303 const struct bpf_line_info *linfo;
304
305 if (!bpf_verifier_log_needed(&env->log))
306 return;
307
308 linfo = find_linfo(env, insn_off);
309 if (!linfo || linfo == env->prev_linfo)
310 return;
311
312 if (prefix_fmt) {
313 va_list args;
314
315 va_start(args, prefix_fmt);
316 bpf_verifier_vlog(&env->log, prefix_fmt, args);
317 va_end(args);
318 }
319
320 verbose(env, "%s\n",
321 ltrim(btf_name_by_offset(env->prog->aux->btf,
322 linfo->line_off)));
323
324 env->prev_linfo = linfo;
325}
326
de8f3a83
DB
327static bool type_is_pkt_pointer(enum bpf_reg_type type)
328{
329 return type == PTR_TO_PACKET ||
330 type == PTR_TO_PACKET_META;
331}
332
840b9615
JS
333static bool reg_type_may_be_null(enum bpf_reg_type type)
334{
fd978bf7
JS
335 return type == PTR_TO_MAP_VALUE_OR_NULL ||
336 type == PTR_TO_SOCKET_OR_NULL;
337}
338
339static bool type_is_refcounted(enum bpf_reg_type type)
340{
341 return type == PTR_TO_SOCKET;
342}
343
344static bool type_is_refcounted_or_null(enum bpf_reg_type type)
345{
346 return type == PTR_TO_SOCKET || type == PTR_TO_SOCKET_OR_NULL;
347}
348
349static bool reg_is_refcounted(const struct bpf_reg_state *reg)
350{
351 return type_is_refcounted(reg->type);
352}
353
354static bool reg_is_refcounted_or_null(const struct bpf_reg_state *reg)
355{
356 return type_is_refcounted_or_null(reg->type);
357}
358
359static bool arg_type_is_refcounted(enum bpf_arg_type type)
360{
361 return type == ARG_PTR_TO_SOCKET;
362}
363
364/* Determine whether the function releases some resources allocated by another
365 * function call. The first reference type argument will be assumed to be
366 * released by release_reference().
367 */
368static bool is_release_function(enum bpf_func_id func_id)
369{
6acc9b43 370 return func_id == BPF_FUNC_sk_release;
840b9615
JS
371}
372
17a52670
AS
373/* string representation of 'enum bpf_reg_type' */
374static const char * const reg_type_str[] = {
375 [NOT_INIT] = "?",
f1174f77 376 [SCALAR_VALUE] = "inv",
17a52670
AS
377 [PTR_TO_CTX] = "ctx",
378 [CONST_PTR_TO_MAP] = "map_ptr",
379 [PTR_TO_MAP_VALUE] = "map_value",
380 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
17a52670 381 [PTR_TO_STACK] = "fp",
969bf05e 382 [PTR_TO_PACKET] = "pkt",
de8f3a83 383 [PTR_TO_PACKET_META] = "pkt_meta",
969bf05e 384 [PTR_TO_PACKET_END] = "pkt_end",
d58e468b 385 [PTR_TO_FLOW_KEYS] = "flow_keys",
c64b7983
JS
386 [PTR_TO_SOCKET] = "sock",
387 [PTR_TO_SOCKET_OR_NULL] = "sock_or_null",
17a52670
AS
388};
389
8efea21d
EC
390static char slot_type_char[] = {
391 [STACK_INVALID] = '?',
392 [STACK_SPILL] = 'r',
393 [STACK_MISC] = 'm',
394 [STACK_ZERO] = '0',
395};
396
4e92024a
AS
397static void print_liveness(struct bpf_verifier_env *env,
398 enum bpf_reg_liveness live)
399{
9242b5f5 400 if (live & (REG_LIVE_READ | REG_LIVE_WRITTEN | REG_LIVE_DONE))
4e92024a
AS
401 verbose(env, "_");
402 if (live & REG_LIVE_READ)
403 verbose(env, "r");
404 if (live & REG_LIVE_WRITTEN)
405 verbose(env, "w");
9242b5f5
AS
406 if (live & REG_LIVE_DONE)
407 verbose(env, "D");
4e92024a
AS
408}
409
f4d7e40a
AS
410static struct bpf_func_state *func(struct bpf_verifier_env *env,
411 const struct bpf_reg_state *reg)
412{
413 struct bpf_verifier_state *cur = env->cur_state;
414
415 return cur->frame[reg->frameno];
416}
417
61bd5218 418static void print_verifier_state(struct bpf_verifier_env *env,
f4d7e40a 419 const struct bpf_func_state *state)
17a52670 420{
f4d7e40a 421 const struct bpf_reg_state *reg;
17a52670
AS
422 enum bpf_reg_type t;
423 int i;
424
f4d7e40a
AS
425 if (state->frameno)
426 verbose(env, " frame%d:", state->frameno);
17a52670 427 for (i = 0; i < MAX_BPF_REG; i++) {
1a0dc1ac
AS
428 reg = &state->regs[i];
429 t = reg->type;
17a52670
AS
430 if (t == NOT_INIT)
431 continue;
4e92024a
AS
432 verbose(env, " R%d", i);
433 print_liveness(env, reg->live);
434 verbose(env, "=%s", reg_type_str[t]);
f1174f77
EC
435 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
436 tnum_is_const(reg->var_off)) {
437 /* reg->off should be 0 for SCALAR_VALUE */
61bd5218 438 verbose(env, "%lld", reg->var_off.value + reg->off);
f4d7e40a
AS
439 if (t == PTR_TO_STACK)
440 verbose(env, ",call_%d", func(env, reg)->callsite);
f1174f77 441 } else {
61bd5218 442 verbose(env, "(id=%d", reg->id);
f1174f77 443 if (t != SCALAR_VALUE)
61bd5218 444 verbose(env, ",off=%d", reg->off);
de8f3a83 445 if (type_is_pkt_pointer(t))
61bd5218 446 verbose(env, ",r=%d", reg->range);
f1174f77
EC
447 else if (t == CONST_PTR_TO_MAP ||
448 t == PTR_TO_MAP_VALUE ||
449 t == PTR_TO_MAP_VALUE_OR_NULL)
61bd5218 450 verbose(env, ",ks=%d,vs=%d",
f1174f77
EC
451 reg->map_ptr->key_size,
452 reg->map_ptr->value_size);
7d1238f2
EC
453 if (tnum_is_const(reg->var_off)) {
454 /* Typically an immediate SCALAR_VALUE, but
455 * could be a pointer whose offset is too big
456 * for reg->off
457 */
61bd5218 458 verbose(env, ",imm=%llx", reg->var_off.value);
7d1238f2
EC
459 } else {
460 if (reg->smin_value != reg->umin_value &&
461 reg->smin_value != S64_MIN)
61bd5218 462 verbose(env, ",smin_value=%lld",
7d1238f2
EC
463 (long long)reg->smin_value);
464 if (reg->smax_value != reg->umax_value &&
465 reg->smax_value != S64_MAX)
61bd5218 466 verbose(env, ",smax_value=%lld",
7d1238f2
EC
467 (long long)reg->smax_value);
468 if (reg->umin_value != 0)
61bd5218 469 verbose(env, ",umin_value=%llu",
7d1238f2
EC
470 (unsigned long long)reg->umin_value);
471 if (reg->umax_value != U64_MAX)
61bd5218 472 verbose(env, ",umax_value=%llu",
7d1238f2
EC
473 (unsigned long long)reg->umax_value);
474 if (!tnum_is_unknown(reg->var_off)) {
475 char tn_buf[48];
f1174f77 476
7d1238f2 477 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 478 verbose(env, ",var_off=%s", tn_buf);
7d1238f2 479 }
f1174f77 480 }
61bd5218 481 verbose(env, ")");
f1174f77 482 }
17a52670 483 }
638f5b90 484 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
8efea21d
EC
485 char types_buf[BPF_REG_SIZE + 1];
486 bool valid = false;
487 int j;
488
489 for (j = 0; j < BPF_REG_SIZE; j++) {
490 if (state->stack[i].slot_type[j] != STACK_INVALID)
491 valid = true;
492 types_buf[j] = slot_type_char[
493 state->stack[i].slot_type[j]];
494 }
495 types_buf[BPF_REG_SIZE] = 0;
496 if (!valid)
497 continue;
498 verbose(env, " fp%d", (-i - 1) * BPF_REG_SIZE);
499 print_liveness(env, state->stack[i].spilled_ptr.live);
500 if (state->stack[i].slot_type[0] == STACK_SPILL)
4e92024a 501 verbose(env, "=%s",
638f5b90 502 reg_type_str[state->stack[i].spilled_ptr.type]);
8efea21d
EC
503 else
504 verbose(env, "=%s", types_buf);
17a52670 505 }
fd978bf7
JS
506 if (state->acquired_refs && state->refs[0].id) {
507 verbose(env, " refs=%d", state->refs[0].id);
508 for (i = 1; i < state->acquired_refs; i++)
509 if (state->refs[i].id)
510 verbose(env, ",%d", state->refs[i].id);
511 }
61bd5218 512 verbose(env, "\n");
17a52670
AS
513}
514
84dbf350
JS
515#define COPY_STATE_FN(NAME, COUNT, FIELD, SIZE) \
516static int copy_##NAME##_state(struct bpf_func_state *dst, \
517 const struct bpf_func_state *src) \
518{ \
519 if (!src->FIELD) \
520 return 0; \
521 if (WARN_ON_ONCE(dst->COUNT < src->COUNT)) { \
522 /* internal bug, make state invalid to reject the program */ \
523 memset(dst, 0, sizeof(*dst)); \
524 return -EFAULT; \
525 } \
526 memcpy(dst->FIELD, src->FIELD, \
527 sizeof(*src->FIELD) * (src->COUNT / SIZE)); \
528 return 0; \
638f5b90 529}
fd978bf7
JS
530/* copy_reference_state() */
531COPY_STATE_FN(reference, acquired_refs, refs, 1)
84dbf350
JS
532/* copy_stack_state() */
533COPY_STATE_FN(stack, allocated_stack, stack, BPF_REG_SIZE)
534#undef COPY_STATE_FN
535
536#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE) \
537static int realloc_##NAME##_state(struct bpf_func_state *state, int size, \
538 bool copy_old) \
539{ \
540 u32 old_size = state->COUNT; \
541 struct bpf_##NAME##_state *new_##FIELD; \
542 int slot = size / SIZE; \
543 \
544 if (size <= old_size || !size) { \
545 if (copy_old) \
546 return 0; \
547 state->COUNT = slot * SIZE; \
548 if (!size && old_size) { \
549 kfree(state->FIELD); \
550 state->FIELD = NULL; \
551 } \
552 return 0; \
553 } \
554 new_##FIELD = kmalloc_array(slot, sizeof(struct bpf_##NAME##_state), \
555 GFP_KERNEL); \
556 if (!new_##FIELD) \
557 return -ENOMEM; \
558 if (copy_old) { \
559 if (state->FIELD) \
560 memcpy(new_##FIELD, state->FIELD, \
561 sizeof(*new_##FIELD) * (old_size / SIZE)); \
562 memset(new_##FIELD + old_size / SIZE, 0, \
563 sizeof(*new_##FIELD) * (size - old_size) / SIZE); \
564 } \
565 state->COUNT = slot * SIZE; \
566 kfree(state->FIELD); \
567 state->FIELD = new_##FIELD; \
568 return 0; \
569}
fd978bf7
JS
570/* realloc_reference_state() */
571REALLOC_STATE_FN(reference, acquired_refs, refs, 1)
84dbf350
JS
572/* realloc_stack_state() */
573REALLOC_STATE_FN(stack, allocated_stack, stack, BPF_REG_SIZE)
574#undef REALLOC_STATE_FN
638f5b90
AS
575
576/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
577 * make it consume minimal amount of memory. check_stack_write() access from
f4d7e40a 578 * the program calls into realloc_func_state() to grow the stack size.
84dbf350
JS
579 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
580 * which realloc_stack_state() copies over. It points to previous
581 * bpf_verifier_state which is never reallocated.
638f5b90 582 */
fd978bf7
JS
583static int realloc_func_state(struct bpf_func_state *state, int stack_size,
584 int refs_size, bool copy_old)
638f5b90 585{
fd978bf7
JS
586 int err = realloc_reference_state(state, refs_size, copy_old);
587 if (err)
588 return err;
589 return realloc_stack_state(state, stack_size, copy_old);
590}
591
592/* Acquire a pointer id from the env and update the state->refs to include
593 * this new pointer reference.
594 * On success, returns a valid pointer id to associate with the register
595 * On failure, returns a negative errno.
638f5b90 596 */
fd978bf7 597static int acquire_reference_state(struct bpf_verifier_env *env, int insn_idx)
638f5b90 598{
fd978bf7
JS
599 struct bpf_func_state *state = cur_func(env);
600 int new_ofs = state->acquired_refs;
601 int id, err;
602
603 err = realloc_reference_state(state, state->acquired_refs + 1, true);
604 if (err)
605 return err;
606 id = ++env->id_gen;
607 state->refs[new_ofs].id = id;
608 state->refs[new_ofs].insn_idx = insn_idx;
638f5b90 609
fd978bf7
JS
610 return id;
611}
612
613/* release function corresponding to acquire_reference_state(). Idempotent. */
614static int __release_reference_state(struct bpf_func_state *state, int ptr_id)
615{
616 int i, last_idx;
617
618 if (!ptr_id)
619 return -EFAULT;
620
621 last_idx = state->acquired_refs - 1;
622 for (i = 0; i < state->acquired_refs; i++) {
623 if (state->refs[i].id == ptr_id) {
624 if (last_idx && i != last_idx)
625 memcpy(&state->refs[i], &state->refs[last_idx],
626 sizeof(*state->refs));
627 memset(&state->refs[last_idx], 0, sizeof(*state->refs));
628 state->acquired_refs--;
638f5b90 629 return 0;
638f5b90 630 }
638f5b90 631 }
fd978bf7
JS
632 return -EFAULT;
633}
634
635/* variation on the above for cases where we expect that there must be an
636 * outstanding reference for the specified ptr_id.
637 */
638static int release_reference_state(struct bpf_verifier_env *env, int ptr_id)
639{
640 struct bpf_func_state *state = cur_func(env);
641 int err;
642
643 err = __release_reference_state(state, ptr_id);
644 if (WARN_ON_ONCE(err != 0))
645 verbose(env, "verifier internal error: can't release reference\n");
646 return err;
647}
648
649static int transfer_reference_state(struct bpf_func_state *dst,
650 struct bpf_func_state *src)
651{
652 int err = realloc_reference_state(dst, src->acquired_refs, false);
653 if (err)
654 return err;
655 err = copy_reference_state(dst, src);
656 if (err)
657 return err;
638f5b90
AS
658 return 0;
659}
660
f4d7e40a
AS
661static void free_func_state(struct bpf_func_state *state)
662{
5896351e
AS
663 if (!state)
664 return;
fd978bf7 665 kfree(state->refs);
f4d7e40a
AS
666 kfree(state->stack);
667 kfree(state);
668}
669
1969db47
AS
670static void free_verifier_state(struct bpf_verifier_state *state,
671 bool free_self)
638f5b90 672{
f4d7e40a
AS
673 int i;
674
675 for (i = 0; i <= state->curframe; i++) {
676 free_func_state(state->frame[i]);
677 state->frame[i] = NULL;
678 }
1969db47
AS
679 if (free_self)
680 kfree(state);
638f5b90
AS
681}
682
683/* copy verifier state from src to dst growing dst stack space
684 * when necessary to accommodate larger src stack
685 */
f4d7e40a
AS
686static int copy_func_state(struct bpf_func_state *dst,
687 const struct bpf_func_state *src)
638f5b90
AS
688{
689 int err;
690
fd978bf7
JS
691 err = realloc_func_state(dst, src->allocated_stack, src->acquired_refs,
692 false);
693 if (err)
694 return err;
695 memcpy(dst, src, offsetof(struct bpf_func_state, acquired_refs));
696 err = copy_reference_state(dst, src);
638f5b90
AS
697 if (err)
698 return err;
638f5b90
AS
699 return copy_stack_state(dst, src);
700}
701
f4d7e40a
AS
702static int copy_verifier_state(struct bpf_verifier_state *dst_state,
703 const struct bpf_verifier_state *src)
704{
705 struct bpf_func_state *dst;
706 int i, err;
707
708 /* if dst has more stack frames then src frame, free them */
709 for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
710 free_func_state(dst_state->frame[i]);
711 dst_state->frame[i] = NULL;
712 }
713 dst_state->curframe = src->curframe;
f4d7e40a
AS
714 for (i = 0; i <= src->curframe; i++) {
715 dst = dst_state->frame[i];
716 if (!dst) {
717 dst = kzalloc(sizeof(*dst), GFP_KERNEL);
718 if (!dst)
719 return -ENOMEM;
720 dst_state->frame[i] = dst;
721 }
722 err = copy_func_state(dst, src->frame[i]);
723 if (err)
724 return err;
725 }
726 return 0;
727}
728
638f5b90
AS
729static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
730 int *insn_idx)
731{
732 struct bpf_verifier_state *cur = env->cur_state;
733 struct bpf_verifier_stack_elem *elem, *head = env->head;
734 int err;
17a52670
AS
735
736 if (env->head == NULL)
638f5b90 737 return -ENOENT;
17a52670 738
638f5b90
AS
739 if (cur) {
740 err = copy_verifier_state(cur, &head->st);
741 if (err)
742 return err;
743 }
744 if (insn_idx)
745 *insn_idx = head->insn_idx;
17a52670 746 if (prev_insn_idx)
638f5b90
AS
747 *prev_insn_idx = head->prev_insn_idx;
748 elem = head->next;
1969db47 749 free_verifier_state(&head->st, false);
638f5b90 750 kfree(head);
17a52670
AS
751 env->head = elem;
752 env->stack_size--;
638f5b90 753 return 0;
17a52670
AS
754}
755
58e2af8b
JK
756static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
757 int insn_idx, int prev_insn_idx)
17a52670 758{
638f5b90 759 struct bpf_verifier_state *cur = env->cur_state;
58e2af8b 760 struct bpf_verifier_stack_elem *elem;
638f5b90 761 int err;
17a52670 762
638f5b90 763 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
17a52670
AS
764 if (!elem)
765 goto err;
766
17a52670
AS
767 elem->insn_idx = insn_idx;
768 elem->prev_insn_idx = prev_insn_idx;
769 elem->next = env->head;
770 env->head = elem;
771 env->stack_size++;
1969db47
AS
772 err = copy_verifier_state(&elem->st, cur);
773 if (err)
774 goto err;
07016151 775 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
61bd5218 776 verbose(env, "BPF program is too complex\n");
17a52670
AS
777 goto err;
778 }
779 return &elem->st;
780err:
5896351e
AS
781 free_verifier_state(env->cur_state, true);
782 env->cur_state = NULL;
17a52670 783 /* pop all elements and return */
638f5b90 784 while (!pop_stack(env, NULL, NULL));
17a52670
AS
785 return NULL;
786}
787
788#define CALLER_SAVED_REGS 6
789static const int caller_saved[CALLER_SAVED_REGS] = {
790 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
791};
792
f1174f77
EC
793static void __mark_reg_not_init(struct bpf_reg_state *reg);
794
b03c9f9f
EC
795/* Mark the unknown part of a register (variable offset or scalar value) as
796 * known to have the value @imm.
797 */
798static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
799{
a9c676bc
AS
800 /* Clear id, off, and union(map_ptr, range) */
801 memset(((u8 *)reg) + sizeof(reg->type), 0,
802 offsetof(struct bpf_reg_state, var_off) - sizeof(reg->type));
b03c9f9f
EC
803 reg->var_off = tnum_const(imm);
804 reg->smin_value = (s64)imm;
805 reg->smax_value = (s64)imm;
806 reg->umin_value = imm;
807 reg->umax_value = imm;
808}
809
f1174f77
EC
810/* Mark the 'variable offset' part of a register as zero. This should be
811 * used only on registers holding a pointer type.
812 */
813static void __mark_reg_known_zero(struct bpf_reg_state *reg)
a9789ef9 814{
b03c9f9f 815 __mark_reg_known(reg, 0);
f1174f77 816}
a9789ef9 817
cc2b14d5
AS
818static void __mark_reg_const_zero(struct bpf_reg_state *reg)
819{
820 __mark_reg_known(reg, 0);
cc2b14d5
AS
821 reg->type = SCALAR_VALUE;
822}
823
61bd5218
JK
824static void mark_reg_known_zero(struct bpf_verifier_env *env,
825 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
826{
827 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 828 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
f1174f77
EC
829 /* Something bad happened, let's kill all regs */
830 for (regno = 0; regno < MAX_BPF_REG; regno++)
831 __mark_reg_not_init(regs + regno);
832 return;
833 }
834 __mark_reg_known_zero(regs + regno);
835}
836
de8f3a83
DB
837static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
838{
839 return type_is_pkt_pointer(reg->type);
840}
841
842static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
843{
844 return reg_is_pkt_pointer(reg) ||
845 reg->type == PTR_TO_PACKET_END;
846}
847
848/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
849static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
850 enum bpf_reg_type which)
851{
852 /* The register can already have a range from prior markings.
853 * This is fine as long as it hasn't been advanced from its
854 * origin.
855 */
856 return reg->type == which &&
857 reg->id == 0 &&
858 reg->off == 0 &&
859 tnum_equals_const(reg->var_off, 0);
860}
861
b03c9f9f
EC
862/* Attempts to improve min/max values based on var_off information */
863static void __update_reg_bounds(struct bpf_reg_state *reg)
864{
865 /* min signed is max(sign bit) | min(other bits) */
866 reg->smin_value = max_t(s64, reg->smin_value,
867 reg->var_off.value | (reg->var_off.mask & S64_MIN));
868 /* max signed is min(sign bit) | max(other bits) */
869 reg->smax_value = min_t(s64, reg->smax_value,
870 reg->var_off.value | (reg->var_off.mask & S64_MAX));
871 reg->umin_value = max(reg->umin_value, reg->var_off.value);
872 reg->umax_value = min(reg->umax_value,
873 reg->var_off.value | reg->var_off.mask);
874}
875
876/* Uses signed min/max values to inform unsigned, and vice-versa */
877static void __reg_deduce_bounds(struct bpf_reg_state *reg)
878{
879 /* Learn sign from signed bounds.
880 * If we cannot cross the sign boundary, then signed and unsigned bounds
881 * are the same, so combine. This works even in the negative case, e.g.
882 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
883 */
884 if (reg->smin_value >= 0 || reg->smax_value < 0) {
885 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
886 reg->umin_value);
887 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
888 reg->umax_value);
889 return;
890 }
891 /* Learn sign from unsigned bounds. Signed bounds cross the sign
892 * boundary, so we must be careful.
893 */
894 if ((s64)reg->umax_value >= 0) {
895 /* Positive. We can't learn anything from the smin, but smax
896 * is positive, hence safe.
897 */
898 reg->smin_value = reg->umin_value;
899 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
900 reg->umax_value);
901 } else if ((s64)reg->umin_value < 0) {
902 /* Negative. We can't learn anything from the smax, but smin
903 * is negative, hence safe.
904 */
905 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
906 reg->umin_value);
907 reg->smax_value = reg->umax_value;
908 }
909}
910
911/* Attempts to improve var_off based on unsigned min/max information */
912static void __reg_bound_offset(struct bpf_reg_state *reg)
913{
914 reg->var_off = tnum_intersect(reg->var_off,
915 tnum_range(reg->umin_value,
916 reg->umax_value));
917}
918
919/* Reset the min/max bounds of a register */
920static void __mark_reg_unbounded(struct bpf_reg_state *reg)
921{
922 reg->smin_value = S64_MIN;
923 reg->smax_value = S64_MAX;
924 reg->umin_value = 0;
925 reg->umax_value = U64_MAX;
926}
927
f1174f77
EC
928/* Mark a register as having a completely unknown (scalar) value. */
929static void __mark_reg_unknown(struct bpf_reg_state *reg)
930{
a9c676bc
AS
931 /*
932 * Clear type, id, off, and union(map_ptr, range) and
933 * padding between 'type' and union
934 */
935 memset(reg, 0, offsetof(struct bpf_reg_state, var_off));
f1174f77 936 reg->type = SCALAR_VALUE;
f1174f77 937 reg->var_off = tnum_unknown;
f4d7e40a 938 reg->frameno = 0;
b03c9f9f 939 __mark_reg_unbounded(reg);
f1174f77
EC
940}
941
61bd5218
JK
942static void mark_reg_unknown(struct bpf_verifier_env *env,
943 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
944{
945 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 946 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
19ceb417
AS
947 /* Something bad happened, let's kill all regs except FP */
948 for (regno = 0; regno < BPF_REG_FP; regno++)
f1174f77
EC
949 __mark_reg_not_init(regs + regno);
950 return;
951 }
952 __mark_reg_unknown(regs + regno);
953}
954
955static void __mark_reg_not_init(struct bpf_reg_state *reg)
956{
957 __mark_reg_unknown(reg);
958 reg->type = NOT_INIT;
959}
960
61bd5218
JK
961static void mark_reg_not_init(struct bpf_verifier_env *env,
962 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
963{
964 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 965 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
19ceb417
AS
966 /* Something bad happened, let's kill all regs except FP */
967 for (regno = 0; regno < BPF_REG_FP; regno++)
f1174f77
EC
968 __mark_reg_not_init(regs + regno);
969 return;
970 }
971 __mark_reg_not_init(regs + regno);
a9789ef9
DB
972}
973
61bd5218 974static void init_reg_state(struct bpf_verifier_env *env,
f4d7e40a 975 struct bpf_func_state *state)
17a52670 976{
f4d7e40a 977 struct bpf_reg_state *regs = state->regs;
17a52670
AS
978 int i;
979
dc503a8a 980 for (i = 0; i < MAX_BPF_REG; i++) {
61bd5218 981 mark_reg_not_init(env, regs, i);
dc503a8a 982 regs[i].live = REG_LIVE_NONE;
679c782d 983 regs[i].parent = NULL;
dc503a8a 984 }
17a52670
AS
985
986 /* frame pointer */
f1174f77 987 regs[BPF_REG_FP].type = PTR_TO_STACK;
61bd5218 988 mark_reg_known_zero(env, regs, BPF_REG_FP);
f4d7e40a 989 regs[BPF_REG_FP].frameno = state->frameno;
17a52670
AS
990
991 /* 1st arg to a function */
992 regs[BPF_REG_1].type = PTR_TO_CTX;
61bd5218 993 mark_reg_known_zero(env, regs, BPF_REG_1);
6760bf2d
DB
994}
995
f4d7e40a
AS
996#define BPF_MAIN_FUNC (-1)
997static void init_func_state(struct bpf_verifier_env *env,
998 struct bpf_func_state *state,
999 int callsite, int frameno, int subprogno)
1000{
1001 state->callsite = callsite;
1002 state->frameno = frameno;
1003 state->subprogno = subprogno;
1004 init_reg_state(env, state);
1005}
1006
17a52670
AS
1007enum reg_arg_type {
1008 SRC_OP, /* register is used as source operand */
1009 DST_OP, /* register is used as destination operand */
1010 DST_OP_NO_MARK /* same as above, check only, don't mark */
1011};
1012
cc8b0b92
AS
1013static int cmp_subprogs(const void *a, const void *b)
1014{
9c8105bd
JW
1015 return ((struct bpf_subprog_info *)a)->start -
1016 ((struct bpf_subprog_info *)b)->start;
cc8b0b92
AS
1017}
1018
1019static int find_subprog(struct bpf_verifier_env *env, int off)
1020{
9c8105bd 1021 struct bpf_subprog_info *p;
cc8b0b92 1022
9c8105bd
JW
1023 p = bsearch(&off, env->subprog_info, env->subprog_cnt,
1024 sizeof(env->subprog_info[0]), cmp_subprogs);
cc8b0b92
AS
1025 if (!p)
1026 return -ENOENT;
9c8105bd 1027 return p - env->subprog_info;
cc8b0b92
AS
1028
1029}
1030
1031static int add_subprog(struct bpf_verifier_env *env, int off)
1032{
1033 int insn_cnt = env->prog->len;
1034 int ret;
1035
1036 if (off >= insn_cnt || off < 0) {
1037 verbose(env, "call to invalid destination\n");
1038 return -EINVAL;
1039 }
1040 ret = find_subprog(env, off);
1041 if (ret >= 0)
1042 return 0;
4cb3d99c 1043 if (env->subprog_cnt >= BPF_MAX_SUBPROGS) {
cc8b0b92
AS
1044 verbose(env, "too many subprograms\n");
1045 return -E2BIG;
1046 }
9c8105bd
JW
1047 env->subprog_info[env->subprog_cnt++].start = off;
1048 sort(env->subprog_info, env->subprog_cnt,
1049 sizeof(env->subprog_info[0]), cmp_subprogs, NULL);
cc8b0b92
AS
1050 return 0;
1051}
1052
1053static int check_subprogs(struct bpf_verifier_env *env)
1054{
1055 int i, ret, subprog_start, subprog_end, off, cur_subprog = 0;
9c8105bd 1056 struct bpf_subprog_info *subprog = env->subprog_info;
cc8b0b92
AS
1057 struct bpf_insn *insn = env->prog->insnsi;
1058 int insn_cnt = env->prog->len;
1059
f910cefa
JW
1060 /* Add entry function. */
1061 ret = add_subprog(env, 0);
1062 if (ret < 0)
1063 return ret;
1064
cc8b0b92
AS
1065 /* determine subprog starts. The end is one before the next starts */
1066 for (i = 0; i < insn_cnt; i++) {
1067 if (insn[i].code != (BPF_JMP | BPF_CALL))
1068 continue;
1069 if (insn[i].src_reg != BPF_PSEUDO_CALL)
1070 continue;
1071 if (!env->allow_ptr_leaks) {
1072 verbose(env, "function calls to other bpf functions are allowed for root only\n");
1073 return -EPERM;
1074 }
cc8b0b92
AS
1075 ret = add_subprog(env, i + insn[i].imm + 1);
1076 if (ret < 0)
1077 return ret;
1078 }
1079
4cb3d99c
JW
1080 /* Add a fake 'exit' subprog which could simplify subprog iteration
1081 * logic. 'subprog_cnt' should not be increased.
1082 */
1083 subprog[env->subprog_cnt].start = insn_cnt;
1084
cc8b0b92
AS
1085 if (env->log.level > 1)
1086 for (i = 0; i < env->subprog_cnt; i++)
9c8105bd 1087 verbose(env, "func#%d @%d\n", i, subprog[i].start);
cc8b0b92
AS
1088
1089 /* now check that all jumps are within the same subprog */
4cb3d99c
JW
1090 subprog_start = subprog[cur_subprog].start;
1091 subprog_end = subprog[cur_subprog + 1].start;
cc8b0b92
AS
1092 for (i = 0; i < insn_cnt; i++) {
1093 u8 code = insn[i].code;
1094
1095 if (BPF_CLASS(code) != BPF_JMP)
1096 goto next;
1097 if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
1098 goto next;
1099 off = i + insn[i].off + 1;
1100 if (off < subprog_start || off >= subprog_end) {
1101 verbose(env, "jump out of range from insn %d to %d\n", i, off);
1102 return -EINVAL;
1103 }
1104next:
1105 if (i == subprog_end - 1) {
1106 /* to avoid fall-through from one subprog into another
1107 * the last insn of the subprog should be either exit
1108 * or unconditional jump back
1109 */
1110 if (code != (BPF_JMP | BPF_EXIT) &&
1111 code != (BPF_JMP | BPF_JA)) {
1112 verbose(env, "last insn is not an exit or jmp\n");
1113 return -EINVAL;
1114 }
1115 subprog_start = subprog_end;
4cb3d99c
JW
1116 cur_subprog++;
1117 if (cur_subprog < env->subprog_cnt)
9c8105bd 1118 subprog_end = subprog[cur_subprog + 1].start;
cc8b0b92
AS
1119 }
1120 }
1121 return 0;
1122}
1123
679c782d
EC
1124/* Parentage chain of this register (or stack slot) should take care of all
1125 * issues like callee-saved registers, stack slot allocation time, etc.
1126 */
f4d7e40a 1127static int mark_reg_read(struct bpf_verifier_env *env,
679c782d
EC
1128 const struct bpf_reg_state *state,
1129 struct bpf_reg_state *parent)
f4d7e40a
AS
1130{
1131 bool writes = parent == state->parent; /* Observe write marks */
dc503a8a
EC
1132
1133 while (parent) {
1134 /* if read wasn't screened by an earlier write ... */
679c782d 1135 if (writes && state->live & REG_LIVE_WRITTEN)
dc503a8a 1136 break;
9242b5f5
AS
1137 if (parent->live & REG_LIVE_DONE) {
1138 verbose(env, "verifier BUG type %s var_off %lld off %d\n",
1139 reg_type_str[parent->type],
1140 parent->var_off.value, parent->off);
1141 return -EFAULT;
1142 }
dc503a8a 1143 /* ... then we depend on parent's value */
679c782d 1144 parent->live |= REG_LIVE_READ;
dc503a8a
EC
1145 state = parent;
1146 parent = state->parent;
f4d7e40a 1147 writes = true;
dc503a8a 1148 }
f4d7e40a 1149 return 0;
dc503a8a
EC
1150}
1151
1152static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
17a52670
AS
1153 enum reg_arg_type t)
1154{
f4d7e40a
AS
1155 struct bpf_verifier_state *vstate = env->cur_state;
1156 struct bpf_func_state *state = vstate->frame[vstate->curframe];
1157 struct bpf_reg_state *regs = state->regs;
dc503a8a 1158
17a52670 1159 if (regno >= MAX_BPF_REG) {
61bd5218 1160 verbose(env, "R%d is invalid\n", regno);
17a52670
AS
1161 return -EINVAL;
1162 }
1163
1164 if (t == SRC_OP) {
1165 /* check whether register used as source operand can be read */
1166 if (regs[regno].type == NOT_INIT) {
61bd5218 1167 verbose(env, "R%d !read_ok\n", regno);
17a52670
AS
1168 return -EACCES;
1169 }
679c782d
EC
1170 /* We don't need to worry about FP liveness because it's read-only */
1171 if (regno != BPF_REG_FP)
1172 return mark_reg_read(env, &regs[regno],
1173 regs[regno].parent);
17a52670
AS
1174 } else {
1175 /* check whether register used as dest operand can be written to */
1176 if (regno == BPF_REG_FP) {
61bd5218 1177 verbose(env, "frame pointer is read only\n");
17a52670
AS
1178 return -EACCES;
1179 }
dc503a8a 1180 regs[regno].live |= REG_LIVE_WRITTEN;
17a52670 1181 if (t == DST_OP)
61bd5218 1182 mark_reg_unknown(env, regs, regno);
17a52670
AS
1183 }
1184 return 0;
1185}
1186
1be7f75d
AS
1187static bool is_spillable_regtype(enum bpf_reg_type type)
1188{
1189 switch (type) {
1190 case PTR_TO_MAP_VALUE:
1191 case PTR_TO_MAP_VALUE_OR_NULL:
1192 case PTR_TO_STACK:
1193 case PTR_TO_CTX:
969bf05e 1194 case PTR_TO_PACKET:
de8f3a83 1195 case PTR_TO_PACKET_META:
969bf05e 1196 case PTR_TO_PACKET_END:
d58e468b 1197 case PTR_TO_FLOW_KEYS:
1be7f75d 1198 case CONST_PTR_TO_MAP:
c64b7983
JS
1199 case PTR_TO_SOCKET:
1200 case PTR_TO_SOCKET_OR_NULL:
1be7f75d
AS
1201 return true;
1202 default:
1203 return false;
1204 }
1205}
1206
cc2b14d5
AS
1207/* Does this register contain a constant zero? */
1208static bool register_is_null(struct bpf_reg_state *reg)
1209{
1210 return reg->type == SCALAR_VALUE && tnum_equals_const(reg->var_off, 0);
1211}
1212
17a52670
AS
1213/* check_stack_read/write functions track spill/fill of registers,
1214 * stack boundary and alignment are checked in check_mem_access()
1215 */
61bd5218 1216static int check_stack_write(struct bpf_verifier_env *env,
f4d7e40a 1217 struct bpf_func_state *state, /* func where register points to */
af86ca4e 1218 int off, int size, int value_regno, int insn_idx)
17a52670 1219{
f4d7e40a 1220 struct bpf_func_state *cur; /* state of the current function */
638f5b90 1221 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
f4d7e40a 1222 enum bpf_reg_type type;
638f5b90 1223
f4d7e40a 1224 err = realloc_func_state(state, round_up(slot + 1, BPF_REG_SIZE),
fd978bf7 1225 state->acquired_refs, true);
638f5b90
AS
1226 if (err)
1227 return err;
9c399760
AS
1228 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
1229 * so it's aligned access and [off, off + size) are within stack limits
1230 */
638f5b90
AS
1231 if (!env->allow_ptr_leaks &&
1232 state->stack[spi].slot_type[0] == STACK_SPILL &&
1233 size != BPF_REG_SIZE) {
1234 verbose(env, "attempt to corrupt spilled pointer on stack\n");
1235 return -EACCES;
1236 }
17a52670 1237
f4d7e40a 1238 cur = env->cur_state->frame[env->cur_state->curframe];
17a52670 1239 if (value_regno >= 0 &&
f4d7e40a 1240 is_spillable_regtype((type = cur->regs[value_regno].type))) {
17a52670
AS
1241
1242 /* register containing pointer is being spilled into stack */
9c399760 1243 if (size != BPF_REG_SIZE) {
61bd5218 1244 verbose(env, "invalid size of register spill\n");
17a52670
AS
1245 return -EACCES;
1246 }
1247
f4d7e40a
AS
1248 if (state != cur && type == PTR_TO_STACK) {
1249 verbose(env, "cannot spill pointers to stack into stack frame of the caller\n");
1250 return -EINVAL;
1251 }
1252
17a52670 1253 /* save register state */
f4d7e40a 1254 state->stack[spi].spilled_ptr = cur->regs[value_regno];
638f5b90 1255 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
17a52670 1256
af86ca4e
AS
1257 for (i = 0; i < BPF_REG_SIZE; i++) {
1258 if (state->stack[spi].slot_type[i] == STACK_MISC &&
1259 !env->allow_ptr_leaks) {
1260 int *poff = &env->insn_aux_data[insn_idx].sanitize_stack_off;
1261 int soff = (-spi - 1) * BPF_REG_SIZE;
1262
1263 /* detected reuse of integer stack slot with a pointer
1264 * which means either llvm is reusing stack slot or
1265 * an attacker is trying to exploit CVE-2018-3639
1266 * (speculative store bypass)
1267 * Have to sanitize that slot with preemptive
1268 * store of zero.
1269 */
1270 if (*poff && *poff != soff) {
1271 /* disallow programs where single insn stores
1272 * into two different stack slots, since verifier
1273 * cannot sanitize them
1274 */
1275 verbose(env,
1276 "insn %d cannot access two stack slots fp%d and fp%d",
1277 insn_idx, *poff, soff);
1278 return -EINVAL;
1279 }
1280 *poff = soff;
1281 }
638f5b90 1282 state->stack[spi].slot_type[i] = STACK_SPILL;
af86ca4e 1283 }
9c399760 1284 } else {
cc2b14d5
AS
1285 u8 type = STACK_MISC;
1286
679c782d
EC
1287 /* regular write of data into stack destroys any spilled ptr */
1288 state->stack[spi].spilled_ptr.type = NOT_INIT;
0bae2d4d
JW
1289 /* Mark slots as STACK_MISC if they belonged to spilled ptr. */
1290 if (state->stack[spi].slot_type[0] == STACK_SPILL)
1291 for (i = 0; i < BPF_REG_SIZE; i++)
1292 state->stack[spi].slot_type[i] = STACK_MISC;
9c399760 1293
cc2b14d5
AS
1294 /* only mark the slot as written if all 8 bytes were written
1295 * otherwise read propagation may incorrectly stop too soon
1296 * when stack slots are partially written.
1297 * This heuristic means that read propagation will be
1298 * conservative, since it will add reg_live_read marks
1299 * to stack slots all the way to first state when programs
1300 * writes+reads less than 8 bytes
1301 */
1302 if (size == BPF_REG_SIZE)
1303 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
1304
1305 /* when we zero initialize stack slots mark them as such */
1306 if (value_regno >= 0 &&
1307 register_is_null(&cur->regs[value_regno]))
1308 type = STACK_ZERO;
1309
0bae2d4d 1310 /* Mark slots affected by this stack write. */
9c399760 1311 for (i = 0; i < size; i++)
638f5b90 1312 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
cc2b14d5 1313 type;
17a52670
AS
1314 }
1315 return 0;
1316}
1317
61bd5218 1318static int check_stack_read(struct bpf_verifier_env *env,
f4d7e40a
AS
1319 struct bpf_func_state *reg_state /* func where register points to */,
1320 int off, int size, int value_regno)
17a52670 1321{
f4d7e40a
AS
1322 struct bpf_verifier_state *vstate = env->cur_state;
1323 struct bpf_func_state *state = vstate->frame[vstate->curframe];
638f5b90
AS
1324 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
1325 u8 *stype;
17a52670 1326
f4d7e40a 1327 if (reg_state->allocated_stack <= slot) {
638f5b90
AS
1328 verbose(env, "invalid read from stack off %d+0 size %d\n",
1329 off, size);
1330 return -EACCES;
1331 }
f4d7e40a 1332 stype = reg_state->stack[spi].slot_type;
17a52670 1333
638f5b90 1334 if (stype[0] == STACK_SPILL) {
9c399760 1335 if (size != BPF_REG_SIZE) {
61bd5218 1336 verbose(env, "invalid size of register spill\n");
17a52670
AS
1337 return -EACCES;
1338 }
9c399760 1339 for (i = 1; i < BPF_REG_SIZE; i++) {
638f5b90 1340 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
61bd5218 1341 verbose(env, "corrupted spill memory\n");
17a52670
AS
1342 return -EACCES;
1343 }
1344 }
1345
dc503a8a 1346 if (value_regno >= 0) {
17a52670 1347 /* restore register state from stack */
f4d7e40a 1348 state->regs[value_regno] = reg_state->stack[spi].spilled_ptr;
2f18f62e
AS
1349 /* mark reg as written since spilled pointer state likely
1350 * has its liveness marks cleared by is_state_visited()
1351 * which resets stack/reg liveness for state transitions
1352 */
1353 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
dc503a8a 1354 }
679c782d
EC
1355 mark_reg_read(env, &reg_state->stack[spi].spilled_ptr,
1356 reg_state->stack[spi].spilled_ptr.parent);
17a52670
AS
1357 return 0;
1358 } else {
cc2b14d5
AS
1359 int zeros = 0;
1360
17a52670 1361 for (i = 0; i < size; i++) {
cc2b14d5
AS
1362 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_MISC)
1363 continue;
1364 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_ZERO) {
1365 zeros++;
1366 continue;
17a52670 1367 }
cc2b14d5
AS
1368 verbose(env, "invalid read from stack off %d+%d size %d\n",
1369 off, i, size);
1370 return -EACCES;
1371 }
679c782d
EC
1372 mark_reg_read(env, &reg_state->stack[spi].spilled_ptr,
1373 reg_state->stack[spi].spilled_ptr.parent);
cc2b14d5
AS
1374 if (value_regno >= 0) {
1375 if (zeros == size) {
1376 /* any size read into register is zero extended,
1377 * so the whole register == const_zero
1378 */
1379 __mark_reg_const_zero(&state->regs[value_regno]);
1380 } else {
1381 /* have read misc data from the stack */
1382 mark_reg_unknown(env, state->regs, value_regno);
1383 }
1384 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
17a52670 1385 }
17a52670
AS
1386 return 0;
1387 }
1388}
1389
1390/* check read/write into map element returned by bpf_map_lookup_elem() */
f1174f77 1391static int __check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
9fd29c08 1392 int size, bool zero_size_allowed)
17a52670 1393{
638f5b90
AS
1394 struct bpf_reg_state *regs = cur_regs(env);
1395 struct bpf_map *map = regs[regno].map_ptr;
17a52670 1396
9fd29c08
YS
1397 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
1398 off + size > map->value_size) {
61bd5218 1399 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
17a52670
AS
1400 map->value_size, off, size);
1401 return -EACCES;
1402 }
1403 return 0;
1404}
1405
f1174f77
EC
1406/* check read/write into a map element with possible variable offset */
1407static int check_map_access(struct bpf_verifier_env *env, u32 regno,
9fd29c08 1408 int off, int size, bool zero_size_allowed)
dbcfe5f7 1409{
f4d7e40a
AS
1410 struct bpf_verifier_state *vstate = env->cur_state;
1411 struct bpf_func_state *state = vstate->frame[vstate->curframe];
dbcfe5f7
GB
1412 struct bpf_reg_state *reg = &state->regs[regno];
1413 int err;
1414
f1174f77
EC
1415 /* We may have adjusted the register to this map value, so we
1416 * need to try adding each of min_value and max_value to off
1417 * to make sure our theoretical access will be safe.
dbcfe5f7 1418 */
61bd5218
JK
1419 if (env->log.level)
1420 print_verifier_state(env, state);
dbcfe5f7
GB
1421 /* The minimum value is only important with signed
1422 * comparisons where we can't assume the floor of a
1423 * value is 0. If we are using signed variables for our
1424 * index'es we need to make sure that whatever we use
1425 * will have a set floor within our range.
1426 */
b03c9f9f 1427 if (reg->smin_value < 0) {
61bd5218 1428 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
dbcfe5f7
GB
1429 regno);
1430 return -EACCES;
1431 }
9fd29c08
YS
1432 err = __check_map_access(env, regno, reg->smin_value + off, size,
1433 zero_size_allowed);
dbcfe5f7 1434 if (err) {
61bd5218
JK
1435 verbose(env, "R%d min value is outside of the array range\n",
1436 regno);
dbcfe5f7
GB
1437 return err;
1438 }
1439
b03c9f9f
EC
1440 /* If we haven't set a max value then we need to bail since we can't be
1441 * sure we won't do bad things.
1442 * If reg->umax_value + off could overflow, treat that as unbounded too.
dbcfe5f7 1443 */
b03c9f9f 1444 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
61bd5218 1445 verbose(env, "R%d unbounded memory access, make sure to bounds check any array access into a map\n",
dbcfe5f7
GB
1446 regno);
1447 return -EACCES;
1448 }
9fd29c08
YS
1449 err = __check_map_access(env, regno, reg->umax_value + off, size,
1450 zero_size_allowed);
f1174f77 1451 if (err)
61bd5218
JK
1452 verbose(env, "R%d max value is outside of the array range\n",
1453 regno);
f1174f77 1454 return err;
dbcfe5f7
GB
1455}
1456
969bf05e
AS
1457#define MAX_PACKET_OFF 0xffff
1458
58e2af8b 1459static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
3a0af8fd
TG
1460 const struct bpf_call_arg_meta *meta,
1461 enum bpf_access_type t)
4acf6c0b 1462{
36bbef52 1463 switch (env->prog->type) {
5d66fa7d 1464 /* Program types only with direct read access go here! */
3a0af8fd
TG
1465 case BPF_PROG_TYPE_LWT_IN:
1466 case BPF_PROG_TYPE_LWT_OUT:
004d4b27 1467 case BPF_PROG_TYPE_LWT_SEG6LOCAL:
2dbb9b9e 1468 case BPF_PROG_TYPE_SK_REUSEPORT:
5d66fa7d 1469 case BPF_PROG_TYPE_FLOW_DISSECTOR:
d5563d36 1470 case BPF_PROG_TYPE_CGROUP_SKB:
3a0af8fd
TG
1471 if (t == BPF_WRITE)
1472 return false;
7e57fbb2 1473 /* fallthrough */
5d66fa7d
DB
1474
1475 /* Program types with direct read + write access go here! */
36bbef52
DB
1476 case BPF_PROG_TYPE_SCHED_CLS:
1477 case BPF_PROG_TYPE_SCHED_ACT:
4acf6c0b 1478 case BPF_PROG_TYPE_XDP:
3a0af8fd 1479 case BPF_PROG_TYPE_LWT_XMIT:
8a31db56 1480 case BPF_PROG_TYPE_SK_SKB:
4f738adb 1481 case BPF_PROG_TYPE_SK_MSG:
36bbef52
DB
1482 if (meta)
1483 return meta->pkt_access;
1484
1485 env->seen_direct_write = true;
4acf6c0b
BB
1486 return true;
1487 default:
1488 return false;
1489 }
1490}
1491
f1174f77 1492static int __check_packet_access(struct bpf_verifier_env *env, u32 regno,
9fd29c08 1493 int off, int size, bool zero_size_allowed)
969bf05e 1494{
638f5b90 1495 struct bpf_reg_state *regs = cur_regs(env);
58e2af8b 1496 struct bpf_reg_state *reg = &regs[regno];
969bf05e 1497
9fd29c08
YS
1498 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
1499 (u64)off + size > reg->range) {
61bd5218 1500 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
d91b28ed 1501 off, size, regno, reg->id, reg->off, reg->range);
969bf05e
AS
1502 return -EACCES;
1503 }
1504 return 0;
1505}
1506
f1174f77 1507static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
9fd29c08 1508 int size, bool zero_size_allowed)
f1174f77 1509{
638f5b90 1510 struct bpf_reg_state *regs = cur_regs(env);
f1174f77
EC
1511 struct bpf_reg_state *reg = &regs[regno];
1512 int err;
1513
1514 /* We may have added a variable offset to the packet pointer; but any
1515 * reg->range we have comes after that. We are only checking the fixed
1516 * offset.
1517 */
1518
1519 /* We don't allow negative numbers, because we aren't tracking enough
1520 * detail to prove they're safe.
1521 */
b03c9f9f 1522 if (reg->smin_value < 0) {
61bd5218 1523 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
f1174f77
EC
1524 regno);
1525 return -EACCES;
1526 }
9fd29c08 1527 err = __check_packet_access(env, regno, off, size, zero_size_allowed);
f1174f77 1528 if (err) {
61bd5218 1529 verbose(env, "R%d offset is outside of the packet\n", regno);
f1174f77
EC
1530 return err;
1531 }
e647815a
JW
1532
1533 /* __check_packet_access has made sure "off + size - 1" is within u16.
1534 * reg->umax_value can't be bigger than MAX_PACKET_OFF which is 0xffff,
1535 * otherwise find_good_pkt_pointers would have refused to set range info
1536 * that __check_packet_access would have rejected this pkt access.
1537 * Therefore, "off + reg->umax_value + size - 1" won't overflow u32.
1538 */
1539 env->prog->aux->max_pkt_offset =
1540 max_t(u32, env->prog->aux->max_pkt_offset,
1541 off + reg->umax_value + size - 1);
1542
f1174f77
EC
1543 return err;
1544}
1545
1546/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
31fd8581 1547static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
19de99f7 1548 enum bpf_access_type t, enum bpf_reg_type *reg_type)
17a52670 1549{
f96da094
DB
1550 struct bpf_insn_access_aux info = {
1551 .reg_type = *reg_type,
1552 };
31fd8581 1553
4f9218aa 1554 if (env->ops->is_valid_access &&
5e43f899 1555 env->ops->is_valid_access(off, size, t, env->prog, &info)) {
f96da094
DB
1556 /* A non zero info.ctx_field_size indicates that this field is a
1557 * candidate for later verifier transformation to load the whole
1558 * field and then apply a mask when accessed with a narrower
1559 * access than actual ctx access size. A zero info.ctx_field_size
1560 * will only allow for whole field access and rejects any other
1561 * type of narrower access.
31fd8581 1562 */
23994631 1563 *reg_type = info.reg_type;
31fd8581 1564
4f9218aa 1565 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
32bbe007
AS
1566 /* remember the offset of last byte accessed in ctx */
1567 if (env->prog->aux->max_ctx_offset < off + size)
1568 env->prog->aux->max_ctx_offset = off + size;
17a52670 1569 return 0;
32bbe007 1570 }
17a52670 1571
61bd5218 1572 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
17a52670
AS
1573 return -EACCES;
1574}
1575
d58e468b
PP
1576static int check_flow_keys_access(struct bpf_verifier_env *env, int off,
1577 int size)
1578{
1579 if (size < 0 || off < 0 ||
1580 (u64)off + size > sizeof(struct bpf_flow_keys)) {
1581 verbose(env, "invalid access to flow keys off=%d size=%d\n",
1582 off, size);
1583 return -EACCES;
1584 }
1585 return 0;
1586}
1587
c64b7983
JS
1588static int check_sock_access(struct bpf_verifier_env *env, u32 regno, int off,
1589 int size, enum bpf_access_type t)
1590{
1591 struct bpf_reg_state *regs = cur_regs(env);
1592 struct bpf_reg_state *reg = &regs[regno];
1593 struct bpf_insn_access_aux info;
1594
1595 if (reg->smin_value < 0) {
1596 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
1597 regno);
1598 return -EACCES;
1599 }
1600
1601 if (!bpf_sock_is_valid_access(off, size, t, &info)) {
1602 verbose(env, "invalid bpf_sock access off=%d size=%d\n",
1603 off, size);
1604 return -EACCES;
1605 }
1606
1607 return 0;
1608}
1609
4cabc5b1
DB
1610static bool __is_pointer_value(bool allow_ptr_leaks,
1611 const struct bpf_reg_state *reg)
1be7f75d 1612{
4cabc5b1 1613 if (allow_ptr_leaks)
1be7f75d
AS
1614 return false;
1615
f1174f77 1616 return reg->type != SCALAR_VALUE;
1be7f75d
AS
1617}
1618
2a159c6f
DB
1619static struct bpf_reg_state *reg_state(struct bpf_verifier_env *env, int regno)
1620{
1621 return cur_regs(env) + regno;
1622}
1623
4cabc5b1
DB
1624static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
1625{
2a159c6f 1626 return __is_pointer_value(env->allow_ptr_leaks, reg_state(env, regno));
4cabc5b1
DB
1627}
1628
f37a8cb8
DB
1629static bool is_ctx_reg(struct bpf_verifier_env *env, int regno)
1630{
2a159c6f 1631 const struct bpf_reg_state *reg = reg_state(env, regno);
f37a8cb8 1632
fd978bf7
JS
1633 return reg->type == PTR_TO_CTX ||
1634 reg->type == PTR_TO_SOCKET;
f37a8cb8
DB
1635}
1636
ca369602
DB
1637static bool is_pkt_reg(struct bpf_verifier_env *env, int regno)
1638{
2a159c6f 1639 const struct bpf_reg_state *reg = reg_state(env, regno);
ca369602
DB
1640
1641 return type_is_pkt_pointer(reg->type);
1642}
1643
4b5defde
DB
1644static bool is_flow_key_reg(struct bpf_verifier_env *env, int regno)
1645{
1646 const struct bpf_reg_state *reg = reg_state(env, regno);
1647
1648 /* Separate to is_ctx_reg() since we still want to allow BPF_ST here. */
1649 return reg->type == PTR_TO_FLOW_KEYS;
1650}
1651
61bd5218
JK
1652static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
1653 const struct bpf_reg_state *reg,
d1174416 1654 int off, int size, bool strict)
969bf05e 1655{
f1174f77 1656 struct tnum reg_off;
e07b98d9 1657 int ip_align;
d1174416
DM
1658
1659 /* Byte size accesses are always allowed. */
1660 if (!strict || size == 1)
1661 return 0;
1662
e4eda884
DM
1663 /* For platforms that do not have a Kconfig enabling
1664 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
1665 * NET_IP_ALIGN is universally set to '2'. And on platforms
1666 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
1667 * to this code only in strict mode where we want to emulate
1668 * the NET_IP_ALIGN==2 checking. Therefore use an
1669 * unconditional IP align value of '2'.
e07b98d9 1670 */
e4eda884 1671 ip_align = 2;
f1174f77
EC
1672
1673 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
1674 if (!tnum_is_aligned(reg_off, size)) {
1675 char tn_buf[48];
1676
1677 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218
JK
1678 verbose(env,
1679 "misaligned packet access off %d+%s+%d+%d size %d\n",
f1174f77 1680 ip_align, tn_buf, reg->off, off, size);
969bf05e
AS
1681 return -EACCES;
1682 }
79adffcd 1683
969bf05e
AS
1684 return 0;
1685}
1686
61bd5218
JK
1687static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
1688 const struct bpf_reg_state *reg,
f1174f77
EC
1689 const char *pointer_desc,
1690 int off, int size, bool strict)
79adffcd 1691{
f1174f77
EC
1692 struct tnum reg_off;
1693
1694 /* Byte size accesses are always allowed. */
1695 if (!strict || size == 1)
1696 return 0;
1697
1698 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
1699 if (!tnum_is_aligned(reg_off, size)) {
1700 char tn_buf[48];
1701
1702 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 1703 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
f1174f77 1704 pointer_desc, tn_buf, reg->off, off, size);
79adffcd
DB
1705 return -EACCES;
1706 }
1707
969bf05e
AS
1708 return 0;
1709}
1710
e07b98d9 1711static int check_ptr_alignment(struct bpf_verifier_env *env,
ca369602
DB
1712 const struct bpf_reg_state *reg, int off,
1713 int size, bool strict_alignment_once)
79adffcd 1714{
ca369602 1715 bool strict = env->strict_alignment || strict_alignment_once;
f1174f77 1716 const char *pointer_desc = "";
d1174416 1717
79adffcd
DB
1718 switch (reg->type) {
1719 case PTR_TO_PACKET:
de8f3a83
DB
1720 case PTR_TO_PACKET_META:
1721 /* Special case, because of NET_IP_ALIGN. Given metadata sits
1722 * right in front, treat it the very same way.
1723 */
61bd5218 1724 return check_pkt_ptr_alignment(env, reg, off, size, strict);
d58e468b
PP
1725 case PTR_TO_FLOW_KEYS:
1726 pointer_desc = "flow keys ";
1727 break;
f1174f77
EC
1728 case PTR_TO_MAP_VALUE:
1729 pointer_desc = "value ";
1730 break;
1731 case PTR_TO_CTX:
1732 pointer_desc = "context ";
1733 break;
1734 case PTR_TO_STACK:
1735 pointer_desc = "stack ";
a5ec6ae1
JH
1736 /* The stack spill tracking logic in check_stack_write()
1737 * and check_stack_read() relies on stack accesses being
1738 * aligned.
1739 */
1740 strict = true;
f1174f77 1741 break;
c64b7983
JS
1742 case PTR_TO_SOCKET:
1743 pointer_desc = "sock ";
1744 break;
79adffcd 1745 default:
f1174f77 1746 break;
79adffcd 1747 }
61bd5218
JK
1748 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
1749 strict);
79adffcd
DB
1750}
1751
f4d7e40a
AS
1752static int update_stack_depth(struct bpf_verifier_env *env,
1753 const struct bpf_func_state *func,
1754 int off)
1755{
9c8105bd 1756 u16 stack = env->subprog_info[func->subprogno].stack_depth;
f4d7e40a
AS
1757
1758 if (stack >= -off)
1759 return 0;
1760
1761 /* update known max for given subprogram */
9c8105bd 1762 env->subprog_info[func->subprogno].stack_depth = -off;
70a87ffe
AS
1763 return 0;
1764}
f4d7e40a 1765
70a87ffe
AS
1766/* starting from main bpf function walk all instructions of the function
1767 * and recursively walk all callees that given function can call.
1768 * Ignore jump and exit insns.
1769 * Since recursion is prevented by check_cfg() this algorithm
1770 * only needs a local stack of MAX_CALL_FRAMES to remember callsites
1771 */
1772static int check_max_stack_depth(struct bpf_verifier_env *env)
1773{
9c8105bd
JW
1774 int depth = 0, frame = 0, idx = 0, i = 0, subprog_end;
1775 struct bpf_subprog_info *subprog = env->subprog_info;
70a87ffe 1776 struct bpf_insn *insn = env->prog->insnsi;
70a87ffe
AS
1777 int ret_insn[MAX_CALL_FRAMES];
1778 int ret_prog[MAX_CALL_FRAMES];
f4d7e40a 1779
70a87ffe
AS
1780process_func:
1781 /* round up to 32-bytes, since this is granularity
1782 * of interpreter stack size
1783 */
9c8105bd 1784 depth += round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
70a87ffe 1785 if (depth > MAX_BPF_STACK) {
f4d7e40a 1786 verbose(env, "combined stack size of %d calls is %d. Too large\n",
70a87ffe 1787 frame + 1, depth);
f4d7e40a
AS
1788 return -EACCES;
1789 }
70a87ffe 1790continue_func:
4cb3d99c 1791 subprog_end = subprog[idx + 1].start;
70a87ffe
AS
1792 for (; i < subprog_end; i++) {
1793 if (insn[i].code != (BPF_JMP | BPF_CALL))
1794 continue;
1795 if (insn[i].src_reg != BPF_PSEUDO_CALL)
1796 continue;
1797 /* remember insn and function to return to */
1798 ret_insn[frame] = i + 1;
9c8105bd 1799 ret_prog[frame] = idx;
70a87ffe
AS
1800
1801 /* find the callee */
1802 i = i + insn[i].imm + 1;
9c8105bd
JW
1803 idx = find_subprog(env, i);
1804 if (idx < 0) {
70a87ffe
AS
1805 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1806 i);
1807 return -EFAULT;
1808 }
70a87ffe
AS
1809 frame++;
1810 if (frame >= MAX_CALL_FRAMES) {
1811 WARN_ONCE(1, "verifier bug. Call stack is too deep\n");
1812 return -EFAULT;
1813 }
1814 goto process_func;
1815 }
1816 /* end of for() loop means the last insn of the 'subprog'
1817 * was reached. Doesn't matter whether it was JA or EXIT
1818 */
1819 if (frame == 0)
1820 return 0;
9c8105bd 1821 depth -= round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
70a87ffe
AS
1822 frame--;
1823 i = ret_insn[frame];
9c8105bd 1824 idx = ret_prog[frame];
70a87ffe 1825 goto continue_func;
f4d7e40a
AS
1826}
1827
19d28fbd 1828#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
1829static int get_callee_stack_depth(struct bpf_verifier_env *env,
1830 const struct bpf_insn *insn, int idx)
1831{
1832 int start = idx + insn->imm + 1, subprog;
1833
1834 subprog = find_subprog(env, start);
1835 if (subprog < 0) {
1836 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1837 start);
1838 return -EFAULT;
1839 }
9c8105bd 1840 return env->subprog_info[subprog].stack_depth;
1ea47e01 1841}
19d28fbd 1842#endif
1ea47e01 1843
58990d1f
DB
1844static int check_ctx_reg(struct bpf_verifier_env *env,
1845 const struct bpf_reg_state *reg, int regno)
1846{
1847 /* Access to ctx or passing it to a helper is only allowed in
1848 * its original, unmodified form.
1849 */
1850
1851 if (reg->off) {
1852 verbose(env, "dereference of modified ctx ptr R%d off=%d disallowed\n",
1853 regno, reg->off);
1854 return -EACCES;
1855 }
1856
1857 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
1858 char tn_buf[48];
1859
1860 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
1861 verbose(env, "variable ctx access var_off=%s disallowed\n", tn_buf);
1862 return -EACCES;
1863 }
1864
1865 return 0;
1866}
1867
0c17d1d2
JH
1868/* truncate register to smaller size (in bytes)
1869 * must be called with size < BPF_REG_SIZE
1870 */
1871static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
1872{
1873 u64 mask;
1874
1875 /* clear high bits in bit representation */
1876 reg->var_off = tnum_cast(reg->var_off, size);
1877
1878 /* fix arithmetic bounds */
1879 mask = ((u64)1 << (size * 8)) - 1;
1880 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
1881 reg->umin_value &= mask;
1882 reg->umax_value &= mask;
1883 } else {
1884 reg->umin_value = 0;
1885 reg->umax_value = mask;
1886 }
1887 reg->smin_value = reg->umin_value;
1888 reg->smax_value = reg->umax_value;
1889}
1890
17a52670
AS
1891/* check whether memory at (regno + off) is accessible for t = (read | write)
1892 * if t==write, value_regno is a register which value is stored into memory
1893 * if t==read, value_regno is a register which will receive the value from memory
1894 * if t==write && value_regno==-1, some unknown value is stored into memory
1895 * if t==read && value_regno==-1, don't care what we read from memory
1896 */
ca369602
DB
1897static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno,
1898 int off, int bpf_size, enum bpf_access_type t,
1899 int value_regno, bool strict_alignment_once)
17a52670 1900{
638f5b90
AS
1901 struct bpf_reg_state *regs = cur_regs(env);
1902 struct bpf_reg_state *reg = regs + regno;
f4d7e40a 1903 struct bpf_func_state *state;
17a52670
AS
1904 int size, err = 0;
1905
1906 size = bpf_size_to_bytes(bpf_size);
1907 if (size < 0)
1908 return size;
1909
f1174f77 1910 /* alignment checks will add in reg->off themselves */
ca369602 1911 err = check_ptr_alignment(env, reg, off, size, strict_alignment_once);
969bf05e
AS
1912 if (err)
1913 return err;
17a52670 1914
f1174f77
EC
1915 /* for access checks, reg->off is just part of off */
1916 off += reg->off;
1917
1918 if (reg->type == PTR_TO_MAP_VALUE) {
1be7f75d
AS
1919 if (t == BPF_WRITE && value_regno >= 0 &&
1920 is_pointer_value(env, value_regno)) {
61bd5218 1921 verbose(env, "R%d leaks addr into map\n", value_regno);
1be7f75d
AS
1922 return -EACCES;
1923 }
48461135 1924
9fd29c08 1925 err = check_map_access(env, regno, off, size, false);
17a52670 1926 if (!err && t == BPF_READ && value_regno >= 0)
638f5b90 1927 mark_reg_unknown(env, regs, value_regno);
17a52670 1928
1a0dc1ac 1929 } else if (reg->type == PTR_TO_CTX) {
f1174f77 1930 enum bpf_reg_type reg_type = SCALAR_VALUE;
19de99f7 1931
1be7f75d
AS
1932 if (t == BPF_WRITE && value_regno >= 0 &&
1933 is_pointer_value(env, value_regno)) {
61bd5218 1934 verbose(env, "R%d leaks addr into ctx\n", value_regno);
1be7f75d
AS
1935 return -EACCES;
1936 }
f1174f77 1937
58990d1f
DB
1938 err = check_ctx_reg(env, reg, regno);
1939 if (err < 0)
1940 return err;
1941
31fd8581 1942 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type);
969bf05e 1943 if (!err && t == BPF_READ && value_regno >= 0) {
f1174f77 1944 /* ctx access returns either a scalar, or a
de8f3a83
DB
1945 * PTR_TO_PACKET[_META,_END]. In the latter
1946 * case, we know the offset is zero.
f1174f77
EC
1947 */
1948 if (reg_type == SCALAR_VALUE)
638f5b90 1949 mark_reg_unknown(env, regs, value_regno);
f1174f77 1950 else
638f5b90 1951 mark_reg_known_zero(env, regs,
61bd5218 1952 value_regno);
638f5b90 1953 regs[value_regno].type = reg_type;
969bf05e 1954 }
17a52670 1955
f1174f77
EC
1956 } else if (reg->type == PTR_TO_STACK) {
1957 /* stack accesses must be at a fixed offset, so that we can
1958 * determine what type of data were returned.
1959 * See check_stack_read().
1960 */
1961 if (!tnum_is_const(reg->var_off)) {
1962 char tn_buf[48];
1963
1964 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 1965 verbose(env, "variable stack access var_off=%s off=%d size=%d",
f1174f77
EC
1966 tn_buf, off, size);
1967 return -EACCES;
1968 }
1969 off += reg->var_off.value;
17a52670 1970 if (off >= 0 || off < -MAX_BPF_STACK) {
61bd5218
JK
1971 verbose(env, "invalid stack off=%d size=%d\n", off,
1972 size);
17a52670
AS
1973 return -EACCES;
1974 }
8726679a 1975
f4d7e40a
AS
1976 state = func(env, reg);
1977 err = update_stack_depth(env, state, off);
1978 if (err)
1979 return err;
8726679a 1980
638f5b90 1981 if (t == BPF_WRITE)
61bd5218 1982 err = check_stack_write(env, state, off, size,
af86ca4e 1983 value_regno, insn_idx);
638f5b90 1984 else
61bd5218
JK
1985 err = check_stack_read(env, state, off, size,
1986 value_regno);
de8f3a83 1987 } else if (reg_is_pkt_pointer(reg)) {
3a0af8fd 1988 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
61bd5218 1989 verbose(env, "cannot write into packet\n");
969bf05e
AS
1990 return -EACCES;
1991 }
4acf6c0b
BB
1992 if (t == BPF_WRITE && value_regno >= 0 &&
1993 is_pointer_value(env, value_regno)) {
61bd5218
JK
1994 verbose(env, "R%d leaks addr into packet\n",
1995 value_regno);
4acf6c0b
BB
1996 return -EACCES;
1997 }
9fd29c08 1998 err = check_packet_access(env, regno, off, size, false);
969bf05e 1999 if (!err && t == BPF_READ && value_regno >= 0)
638f5b90 2000 mark_reg_unknown(env, regs, value_regno);
d58e468b
PP
2001 } else if (reg->type == PTR_TO_FLOW_KEYS) {
2002 if (t == BPF_WRITE && value_regno >= 0 &&
2003 is_pointer_value(env, value_regno)) {
2004 verbose(env, "R%d leaks addr into flow keys\n",
2005 value_regno);
2006 return -EACCES;
2007 }
2008
2009 err = check_flow_keys_access(env, off, size);
2010 if (!err && t == BPF_READ && value_regno >= 0)
2011 mark_reg_unknown(env, regs, value_regno);
c64b7983
JS
2012 } else if (reg->type == PTR_TO_SOCKET) {
2013 if (t == BPF_WRITE) {
2014 verbose(env, "cannot write into socket\n");
2015 return -EACCES;
2016 }
2017 err = check_sock_access(env, regno, off, size, t);
2018 if (!err && value_regno >= 0)
2019 mark_reg_unknown(env, regs, value_regno);
17a52670 2020 } else {
61bd5218
JK
2021 verbose(env, "R%d invalid mem access '%s'\n", regno,
2022 reg_type_str[reg->type]);
17a52670
AS
2023 return -EACCES;
2024 }
969bf05e 2025
f1174f77 2026 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
638f5b90 2027 regs[value_regno].type == SCALAR_VALUE) {
f1174f77 2028 /* b/h/w load zero-extends, mark upper bits as known 0 */
0c17d1d2 2029 coerce_reg_to_size(&regs[value_regno], size);
969bf05e 2030 }
17a52670
AS
2031 return err;
2032}
2033
31fd8581 2034static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
17a52670 2035{
17a52670
AS
2036 int err;
2037
2038 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
2039 insn->imm != 0) {
61bd5218 2040 verbose(env, "BPF_XADD uses reserved fields\n");
17a52670
AS
2041 return -EINVAL;
2042 }
2043
2044 /* check src1 operand */
dc503a8a 2045 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
2046 if (err)
2047 return err;
2048
2049 /* check src2 operand */
dc503a8a 2050 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
2051 if (err)
2052 return err;
2053
6bdf6abc 2054 if (is_pointer_value(env, insn->src_reg)) {
61bd5218 2055 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
6bdf6abc
DB
2056 return -EACCES;
2057 }
2058
ca369602 2059 if (is_ctx_reg(env, insn->dst_reg) ||
4b5defde
DB
2060 is_pkt_reg(env, insn->dst_reg) ||
2061 is_flow_key_reg(env, insn->dst_reg)) {
ca369602 2062 verbose(env, "BPF_XADD stores into R%d %s is not allowed\n",
2a159c6f
DB
2063 insn->dst_reg,
2064 reg_type_str[reg_state(env, insn->dst_reg)->type]);
f37a8cb8
DB
2065 return -EACCES;
2066 }
2067
17a52670 2068 /* check whether atomic_add can read the memory */
31fd8581 2069 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
ca369602 2070 BPF_SIZE(insn->code), BPF_READ, -1, true);
17a52670
AS
2071 if (err)
2072 return err;
2073
2074 /* check whether atomic_add can write into the same memory */
31fd8581 2075 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
ca369602 2076 BPF_SIZE(insn->code), BPF_WRITE, -1, true);
17a52670
AS
2077}
2078
2079/* when register 'regno' is passed into function that will read 'access_size'
2080 * bytes from that pointer, make sure that it's within stack boundary
f1174f77
EC
2081 * and all elements of stack are initialized.
2082 * Unlike most pointer bounds-checking functions, this one doesn't take an
2083 * 'off' argument, so it has to add in reg->off itself.
17a52670 2084 */
58e2af8b 2085static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
435faee1
DB
2086 int access_size, bool zero_size_allowed,
2087 struct bpf_call_arg_meta *meta)
17a52670 2088{
2a159c6f 2089 struct bpf_reg_state *reg = reg_state(env, regno);
f4d7e40a 2090 struct bpf_func_state *state = func(env, reg);
638f5b90 2091 int off, i, slot, spi;
17a52670 2092
914cb781 2093 if (reg->type != PTR_TO_STACK) {
f1174f77 2094 /* Allow zero-byte read from NULL, regardless of pointer type */
8e2fe1d9 2095 if (zero_size_allowed && access_size == 0 &&
914cb781 2096 register_is_null(reg))
8e2fe1d9
DB
2097 return 0;
2098
61bd5218 2099 verbose(env, "R%d type=%s expected=%s\n", regno,
914cb781 2100 reg_type_str[reg->type],
8e2fe1d9 2101 reg_type_str[PTR_TO_STACK]);
17a52670 2102 return -EACCES;
8e2fe1d9 2103 }
17a52670 2104
f1174f77 2105 /* Only allow fixed-offset stack reads */
914cb781 2106 if (!tnum_is_const(reg->var_off)) {
f1174f77
EC
2107 char tn_buf[48];
2108
914cb781 2109 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 2110 verbose(env, "invalid variable stack read R%d var_off=%s\n",
f1174f77 2111 regno, tn_buf);
ea25f914 2112 return -EACCES;
f1174f77 2113 }
914cb781 2114 off = reg->off + reg->var_off.value;
17a52670 2115 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
9fd29c08 2116 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
61bd5218 2117 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
17a52670
AS
2118 regno, off, access_size);
2119 return -EACCES;
2120 }
2121
435faee1
DB
2122 if (meta && meta->raw_mode) {
2123 meta->access_size = access_size;
2124 meta->regno = regno;
2125 return 0;
2126 }
2127
17a52670 2128 for (i = 0; i < access_size; i++) {
cc2b14d5
AS
2129 u8 *stype;
2130
638f5b90
AS
2131 slot = -(off + i) - 1;
2132 spi = slot / BPF_REG_SIZE;
cc2b14d5
AS
2133 if (state->allocated_stack <= slot)
2134 goto err;
2135 stype = &state->stack[spi].slot_type[slot % BPF_REG_SIZE];
2136 if (*stype == STACK_MISC)
2137 goto mark;
2138 if (*stype == STACK_ZERO) {
2139 /* helper can write anything into the stack */
2140 *stype = STACK_MISC;
2141 goto mark;
17a52670 2142 }
cc2b14d5
AS
2143err:
2144 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
2145 off, i, access_size);
2146 return -EACCES;
2147mark:
2148 /* reading any byte out of 8-byte 'spill_slot' will cause
2149 * the whole slot to be marked as 'read'
2150 */
679c782d
EC
2151 mark_reg_read(env, &state->stack[spi].spilled_ptr,
2152 state->stack[spi].spilled_ptr.parent);
17a52670 2153 }
f4d7e40a 2154 return update_stack_depth(env, state, off);
17a52670
AS
2155}
2156
06c1c049
GB
2157static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
2158 int access_size, bool zero_size_allowed,
2159 struct bpf_call_arg_meta *meta)
2160{
638f5b90 2161 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
06c1c049 2162
f1174f77 2163 switch (reg->type) {
06c1c049 2164 case PTR_TO_PACKET:
de8f3a83 2165 case PTR_TO_PACKET_META:
9fd29c08
YS
2166 return check_packet_access(env, regno, reg->off, access_size,
2167 zero_size_allowed);
06c1c049 2168 case PTR_TO_MAP_VALUE:
9fd29c08
YS
2169 return check_map_access(env, regno, reg->off, access_size,
2170 zero_size_allowed);
f1174f77 2171 default: /* scalar_value|ptr_to_stack or invalid ptr */
06c1c049
GB
2172 return check_stack_boundary(env, regno, access_size,
2173 zero_size_allowed, meta);
2174 }
2175}
2176
90133415
DB
2177static bool arg_type_is_mem_ptr(enum bpf_arg_type type)
2178{
2179 return type == ARG_PTR_TO_MEM ||
2180 type == ARG_PTR_TO_MEM_OR_NULL ||
2181 type == ARG_PTR_TO_UNINIT_MEM;
2182}
2183
2184static bool arg_type_is_mem_size(enum bpf_arg_type type)
2185{
2186 return type == ARG_CONST_SIZE ||
2187 type == ARG_CONST_SIZE_OR_ZERO;
2188}
2189
58e2af8b 2190static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
33ff9823
DB
2191 enum bpf_arg_type arg_type,
2192 struct bpf_call_arg_meta *meta)
17a52670 2193{
638f5b90 2194 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
6841de8b 2195 enum bpf_reg_type expected_type, type = reg->type;
17a52670
AS
2196 int err = 0;
2197
80f1d68c 2198 if (arg_type == ARG_DONTCARE)
17a52670
AS
2199 return 0;
2200
dc503a8a
EC
2201 err = check_reg_arg(env, regno, SRC_OP);
2202 if (err)
2203 return err;
17a52670 2204
1be7f75d
AS
2205 if (arg_type == ARG_ANYTHING) {
2206 if (is_pointer_value(env, regno)) {
61bd5218
JK
2207 verbose(env, "R%d leaks addr into helper function\n",
2208 regno);
1be7f75d
AS
2209 return -EACCES;
2210 }
80f1d68c 2211 return 0;
1be7f75d 2212 }
80f1d68c 2213
de8f3a83 2214 if (type_is_pkt_pointer(type) &&
3a0af8fd 2215 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
61bd5218 2216 verbose(env, "helper access to the packet is not allowed\n");
6841de8b
AS
2217 return -EACCES;
2218 }
2219
8e2fe1d9 2220 if (arg_type == ARG_PTR_TO_MAP_KEY ||
2ea864c5
MV
2221 arg_type == ARG_PTR_TO_MAP_VALUE ||
2222 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE) {
17a52670 2223 expected_type = PTR_TO_STACK;
d71962f3 2224 if (!type_is_pkt_pointer(type) && type != PTR_TO_MAP_VALUE &&
de8f3a83 2225 type != expected_type)
6841de8b 2226 goto err_type;
39f19ebb
AS
2227 } else if (arg_type == ARG_CONST_SIZE ||
2228 arg_type == ARG_CONST_SIZE_OR_ZERO) {
f1174f77
EC
2229 expected_type = SCALAR_VALUE;
2230 if (type != expected_type)
6841de8b 2231 goto err_type;
17a52670
AS
2232 } else if (arg_type == ARG_CONST_MAP_PTR) {
2233 expected_type = CONST_PTR_TO_MAP;
6841de8b
AS
2234 if (type != expected_type)
2235 goto err_type;
608cd71a
AS
2236 } else if (arg_type == ARG_PTR_TO_CTX) {
2237 expected_type = PTR_TO_CTX;
6841de8b
AS
2238 if (type != expected_type)
2239 goto err_type;
58990d1f
DB
2240 err = check_ctx_reg(env, reg, regno);
2241 if (err < 0)
2242 return err;
c64b7983
JS
2243 } else if (arg_type == ARG_PTR_TO_SOCKET) {
2244 expected_type = PTR_TO_SOCKET;
2245 if (type != expected_type)
2246 goto err_type;
fd978bf7
JS
2247 if (meta->ptr_id || !reg->id) {
2248 verbose(env, "verifier internal error: mismatched references meta=%d, reg=%d\n",
2249 meta->ptr_id, reg->id);
2250 return -EFAULT;
2251 }
2252 meta->ptr_id = reg->id;
90133415 2253 } else if (arg_type_is_mem_ptr(arg_type)) {
8e2fe1d9
DB
2254 expected_type = PTR_TO_STACK;
2255 /* One exception here. In case function allows for NULL to be
f1174f77 2256 * passed in as argument, it's a SCALAR_VALUE type. Final test
8e2fe1d9
DB
2257 * happens during stack boundary checking.
2258 */
914cb781 2259 if (register_is_null(reg) &&
db1ac496 2260 arg_type == ARG_PTR_TO_MEM_OR_NULL)
6841de8b 2261 /* final test in check_stack_boundary() */;
de8f3a83
DB
2262 else if (!type_is_pkt_pointer(type) &&
2263 type != PTR_TO_MAP_VALUE &&
f1174f77 2264 type != expected_type)
6841de8b 2265 goto err_type;
39f19ebb 2266 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
17a52670 2267 } else {
61bd5218 2268 verbose(env, "unsupported arg_type %d\n", arg_type);
17a52670
AS
2269 return -EFAULT;
2270 }
2271
17a52670
AS
2272 if (arg_type == ARG_CONST_MAP_PTR) {
2273 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
33ff9823 2274 meta->map_ptr = reg->map_ptr;
17a52670
AS
2275 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
2276 /* bpf_map_xxx(..., map_ptr, ..., key) call:
2277 * check that [key, key + map->key_size) are within
2278 * stack limits and initialized
2279 */
33ff9823 2280 if (!meta->map_ptr) {
17a52670
AS
2281 /* in function declaration map_ptr must come before
2282 * map_key, so that it's verified and known before
2283 * we have to check map_key here. Otherwise it means
2284 * that kernel subsystem misconfigured verifier
2285 */
61bd5218 2286 verbose(env, "invalid map_ptr to access map->key\n");
17a52670
AS
2287 return -EACCES;
2288 }
d71962f3
PC
2289 err = check_helper_mem_access(env, regno,
2290 meta->map_ptr->key_size, false,
2291 NULL);
2ea864c5
MV
2292 } else if (arg_type == ARG_PTR_TO_MAP_VALUE ||
2293 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE) {
17a52670
AS
2294 /* bpf_map_xxx(..., map_ptr, ..., value) call:
2295 * check [value, value + map->value_size) validity
2296 */
33ff9823 2297 if (!meta->map_ptr) {
17a52670 2298 /* kernel subsystem misconfigured verifier */
61bd5218 2299 verbose(env, "invalid map_ptr to access map->value\n");
17a52670
AS
2300 return -EACCES;
2301 }
2ea864c5 2302 meta->raw_mode = (arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE);
d71962f3
PC
2303 err = check_helper_mem_access(env, regno,
2304 meta->map_ptr->value_size, false,
2ea864c5 2305 meta);
90133415 2306 } else if (arg_type_is_mem_size(arg_type)) {
39f19ebb 2307 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
17a52670 2308
849fa506
YS
2309 /* remember the mem_size which may be used later
2310 * to refine return values.
2311 */
2312 meta->msize_smax_value = reg->smax_value;
2313 meta->msize_umax_value = reg->umax_value;
2314
f1174f77
EC
2315 /* The register is SCALAR_VALUE; the access check
2316 * happens using its boundaries.
06c1c049 2317 */
f1174f77 2318 if (!tnum_is_const(reg->var_off))
06c1c049
GB
2319 /* For unprivileged variable accesses, disable raw
2320 * mode so that the program is required to
2321 * initialize all the memory that the helper could
2322 * just partially fill up.
2323 */
2324 meta = NULL;
2325
b03c9f9f 2326 if (reg->smin_value < 0) {
61bd5218 2327 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
f1174f77
EC
2328 regno);
2329 return -EACCES;
2330 }
06c1c049 2331
b03c9f9f 2332 if (reg->umin_value == 0) {
f1174f77
EC
2333 err = check_helper_mem_access(env, regno - 1, 0,
2334 zero_size_allowed,
2335 meta);
06c1c049
GB
2336 if (err)
2337 return err;
06c1c049 2338 }
f1174f77 2339
b03c9f9f 2340 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
61bd5218 2341 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
f1174f77
EC
2342 regno);
2343 return -EACCES;
2344 }
2345 err = check_helper_mem_access(env, regno - 1,
b03c9f9f 2346 reg->umax_value,
f1174f77 2347 zero_size_allowed, meta);
17a52670
AS
2348 }
2349
2350 return err;
6841de8b 2351err_type:
61bd5218 2352 verbose(env, "R%d type=%s expected=%s\n", regno,
6841de8b
AS
2353 reg_type_str[type], reg_type_str[expected_type]);
2354 return -EACCES;
17a52670
AS
2355}
2356
61bd5218
JK
2357static int check_map_func_compatibility(struct bpf_verifier_env *env,
2358 struct bpf_map *map, int func_id)
35578d79 2359{
35578d79
KX
2360 if (!map)
2361 return 0;
2362
6aff67c8
AS
2363 /* We need a two way check, first is from map perspective ... */
2364 switch (map->map_type) {
2365 case BPF_MAP_TYPE_PROG_ARRAY:
2366 if (func_id != BPF_FUNC_tail_call)
2367 goto error;
2368 break;
2369 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
2370 if (func_id != BPF_FUNC_perf_event_read &&
908432ca
YS
2371 func_id != BPF_FUNC_perf_event_output &&
2372 func_id != BPF_FUNC_perf_event_read_value)
6aff67c8
AS
2373 goto error;
2374 break;
2375 case BPF_MAP_TYPE_STACK_TRACE:
2376 if (func_id != BPF_FUNC_get_stackid)
2377 goto error;
2378 break;
4ed8ec52 2379 case BPF_MAP_TYPE_CGROUP_ARRAY:
60747ef4 2380 if (func_id != BPF_FUNC_skb_under_cgroup &&
60d20f91 2381 func_id != BPF_FUNC_current_task_under_cgroup)
4a482f34
MKL
2382 goto error;
2383 break;
cd339431 2384 case BPF_MAP_TYPE_CGROUP_STORAGE:
b741f163 2385 case BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE:
cd339431
RG
2386 if (func_id != BPF_FUNC_get_local_storage)
2387 goto error;
2388 break;
546ac1ff
JF
2389 /* devmap returns a pointer to a live net_device ifindex that we cannot
2390 * allow to be modified from bpf side. So do not allow lookup elements
2391 * for now.
2392 */
2393 case BPF_MAP_TYPE_DEVMAP:
2ddf71e2 2394 if (func_id != BPF_FUNC_redirect_map)
546ac1ff
JF
2395 goto error;
2396 break;
fbfc504a
BT
2397 /* Restrict bpf side of cpumap and xskmap, open when use-cases
2398 * appear.
2399 */
6710e112 2400 case BPF_MAP_TYPE_CPUMAP:
fbfc504a 2401 case BPF_MAP_TYPE_XSKMAP:
6710e112
JDB
2402 if (func_id != BPF_FUNC_redirect_map)
2403 goto error;
2404 break;
56f668df 2405 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
bcc6b1b7 2406 case BPF_MAP_TYPE_HASH_OF_MAPS:
56f668df
MKL
2407 if (func_id != BPF_FUNC_map_lookup_elem)
2408 goto error;
16a43625 2409 break;
174a79ff
JF
2410 case BPF_MAP_TYPE_SOCKMAP:
2411 if (func_id != BPF_FUNC_sk_redirect_map &&
2412 func_id != BPF_FUNC_sock_map_update &&
4f738adb
JF
2413 func_id != BPF_FUNC_map_delete_elem &&
2414 func_id != BPF_FUNC_msg_redirect_map)
174a79ff
JF
2415 goto error;
2416 break;
81110384
JF
2417 case BPF_MAP_TYPE_SOCKHASH:
2418 if (func_id != BPF_FUNC_sk_redirect_hash &&
2419 func_id != BPF_FUNC_sock_hash_update &&
2420 func_id != BPF_FUNC_map_delete_elem &&
2421 func_id != BPF_FUNC_msg_redirect_hash)
2422 goto error;
2423 break;
2dbb9b9e
MKL
2424 case BPF_MAP_TYPE_REUSEPORT_SOCKARRAY:
2425 if (func_id != BPF_FUNC_sk_select_reuseport)
2426 goto error;
2427 break;
f1a2e44a
MV
2428 case BPF_MAP_TYPE_QUEUE:
2429 case BPF_MAP_TYPE_STACK:
2430 if (func_id != BPF_FUNC_map_peek_elem &&
2431 func_id != BPF_FUNC_map_pop_elem &&
2432 func_id != BPF_FUNC_map_push_elem)
2433 goto error;
2434 break;
6aff67c8
AS
2435 default:
2436 break;
2437 }
2438
2439 /* ... and second from the function itself. */
2440 switch (func_id) {
2441 case BPF_FUNC_tail_call:
2442 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
2443 goto error;
f910cefa 2444 if (env->subprog_cnt > 1) {
f4d7e40a
AS
2445 verbose(env, "tail_calls are not allowed in programs with bpf-to-bpf calls\n");
2446 return -EINVAL;
2447 }
6aff67c8
AS
2448 break;
2449 case BPF_FUNC_perf_event_read:
2450 case BPF_FUNC_perf_event_output:
908432ca 2451 case BPF_FUNC_perf_event_read_value:
6aff67c8
AS
2452 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
2453 goto error;
2454 break;
2455 case BPF_FUNC_get_stackid:
2456 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
2457 goto error;
2458 break;
60d20f91 2459 case BPF_FUNC_current_task_under_cgroup:
747ea55e 2460 case BPF_FUNC_skb_under_cgroup:
4a482f34
MKL
2461 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
2462 goto error;
2463 break;
97f91a7c 2464 case BPF_FUNC_redirect_map:
9c270af3 2465 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
fbfc504a
BT
2466 map->map_type != BPF_MAP_TYPE_CPUMAP &&
2467 map->map_type != BPF_MAP_TYPE_XSKMAP)
97f91a7c
JF
2468 goto error;
2469 break;
174a79ff 2470 case BPF_FUNC_sk_redirect_map:
4f738adb 2471 case BPF_FUNC_msg_redirect_map:
81110384 2472 case BPF_FUNC_sock_map_update:
174a79ff
JF
2473 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
2474 goto error;
2475 break;
81110384
JF
2476 case BPF_FUNC_sk_redirect_hash:
2477 case BPF_FUNC_msg_redirect_hash:
2478 case BPF_FUNC_sock_hash_update:
2479 if (map->map_type != BPF_MAP_TYPE_SOCKHASH)
174a79ff
JF
2480 goto error;
2481 break;
cd339431 2482 case BPF_FUNC_get_local_storage:
b741f163
RG
2483 if (map->map_type != BPF_MAP_TYPE_CGROUP_STORAGE &&
2484 map->map_type != BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE)
cd339431
RG
2485 goto error;
2486 break;
2dbb9b9e
MKL
2487 case BPF_FUNC_sk_select_reuseport:
2488 if (map->map_type != BPF_MAP_TYPE_REUSEPORT_SOCKARRAY)
2489 goto error;
2490 break;
f1a2e44a
MV
2491 case BPF_FUNC_map_peek_elem:
2492 case BPF_FUNC_map_pop_elem:
2493 case BPF_FUNC_map_push_elem:
2494 if (map->map_type != BPF_MAP_TYPE_QUEUE &&
2495 map->map_type != BPF_MAP_TYPE_STACK)
2496 goto error;
2497 break;
6aff67c8
AS
2498 default:
2499 break;
35578d79
KX
2500 }
2501
2502 return 0;
6aff67c8 2503error:
61bd5218 2504 verbose(env, "cannot pass map_type %d into func %s#%d\n",
ebb676da 2505 map->map_type, func_id_name(func_id), func_id);
6aff67c8 2506 return -EINVAL;
35578d79
KX
2507}
2508
90133415 2509static bool check_raw_mode_ok(const struct bpf_func_proto *fn)
435faee1
DB
2510{
2511 int count = 0;
2512
39f19ebb 2513 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 2514 count++;
39f19ebb 2515 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 2516 count++;
39f19ebb 2517 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 2518 count++;
39f19ebb 2519 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 2520 count++;
39f19ebb 2521 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
435faee1
DB
2522 count++;
2523
90133415
DB
2524 /* We only support one arg being in raw mode at the moment,
2525 * which is sufficient for the helper functions we have
2526 * right now.
2527 */
2528 return count <= 1;
2529}
2530
2531static bool check_args_pair_invalid(enum bpf_arg_type arg_curr,
2532 enum bpf_arg_type arg_next)
2533{
2534 return (arg_type_is_mem_ptr(arg_curr) &&
2535 !arg_type_is_mem_size(arg_next)) ||
2536 (!arg_type_is_mem_ptr(arg_curr) &&
2537 arg_type_is_mem_size(arg_next));
2538}
2539
2540static bool check_arg_pair_ok(const struct bpf_func_proto *fn)
2541{
2542 /* bpf_xxx(..., buf, len) call will access 'len'
2543 * bytes from memory 'buf'. Both arg types need
2544 * to be paired, so make sure there's no buggy
2545 * helper function specification.
2546 */
2547 if (arg_type_is_mem_size(fn->arg1_type) ||
2548 arg_type_is_mem_ptr(fn->arg5_type) ||
2549 check_args_pair_invalid(fn->arg1_type, fn->arg2_type) ||
2550 check_args_pair_invalid(fn->arg2_type, fn->arg3_type) ||
2551 check_args_pair_invalid(fn->arg3_type, fn->arg4_type) ||
2552 check_args_pair_invalid(fn->arg4_type, fn->arg5_type))
2553 return false;
2554
2555 return true;
2556}
2557
fd978bf7
JS
2558static bool check_refcount_ok(const struct bpf_func_proto *fn)
2559{
2560 int count = 0;
2561
2562 if (arg_type_is_refcounted(fn->arg1_type))
2563 count++;
2564 if (arg_type_is_refcounted(fn->arg2_type))
2565 count++;
2566 if (arg_type_is_refcounted(fn->arg3_type))
2567 count++;
2568 if (arg_type_is_refcounted(fn->arg4_type))
2569 count++;
2570 if (arg_type_is_refcounted(fn->arg5_type))
2571 count++;
2572
2573 /* We only support one arg being unreferenced at the moment,
2574 * which is sufficient for the helper functions we have right now.
2575 */
2576 return count <= 1;
2577}
2578
90133415
DB
2579static int check_func_proto(const struct bpf_func_proto *fn)
2580{
2581 return check_raw_mode_ok(fn) &&
fd978bf7
JS
2582 check_arg_pair_ok(fn) &&
2583 check_refcount_ok(fn) ? 0 : -EINVAL;
435faee1
DB
2584}
2585
de8f3a83
DB
2586/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
2587 * are now invalid, so turn them into unknown SCALAR_VALUE.
f1174f77 2588 */
f4d7e40a
AS
2589static void __clear_all_pkt_pointers(struct bpf_verifier_env *env,
2590 struct bpf_func_state *state)
969bf05e 2591{
58e2af8b 2592 struct bpf_reg_state *regs = state->regs, *reg;
969bf05e
AS
2593 int i;
2594
2595 for (i = 0; i < MAX_BPF_REG; i++)
de8f3a83 2596 if (reg_is_pkt_pointer_any(&regs[i]))
61bd5218 2597 mark_reg_unknown(env, regs, i);
969bf05e 2598
f3709f69
JS
2599 bpf_for_each_spilled_reg(i, state, reg) {
2600 if (!reg)
969bf05e 2601 continue;
de8f3a83
DB
2602 if (reg_is_pkt_pointer_any(reg))
2603 __mark_reg_unknown(reg);
969bf05e
AS
2604 }
2605}
2606
f4d7e40a
AS
2607static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
2608{
2609 struct bpf_verifier_state *vstate = env->cur_state;
2610 int i;
2611
2612 for (i = 0; i <= vstate->curframe; i++)
2613 __clear_all_pkt_pointers(env, vstate->frame[i]);
2614}
2615
fd978bf7
JS
2616static void release_reg_references(struct bpf_verifier_env *env,
2617 struct bpf_func_state *state, int id)
2618{
2619 struct bpf_reg_state *regs = state->regs, *reg;
2620 int i;
2621
2622 for (i = 0; i < MAX_BPF_REG; i++)
2623 if (regs[i].id == id)
2624 mark_reg_unknown(env, regs, i);
2625
2626 bpf_for_each_spilled_reg(i, state, reg) {
2627 if (!reg)
2628 continue;
2629 if (reg_is_refcounted(reg) && reg->id == id)
2630 __mark_reg_unknown(reg);
2631 }
2632}
2633
2634/* The pointer with the specified id has released its reference to kernel
2635 * resources. Identify all copies of the same pointer and clear the reference.
2636 */
2637static int release_reference(struct bpf_verifier_env *env,
2638 struct bpf_call_arg_meta *meta)
2639{
2640 struct bpf_verifier_state *vstate = env->cur_state;
2641 int i;
2642
2643 for (i = 0; i <= vstate->curframe; i++)
2644 release_reg_references(env, vstate->frame[i], meta->ptr_id);
2645
2646 return release_reference_state(env, meta->ptr_id);
2647}
2648
f4d7e40a
AS
2649static int check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
2650 int *insn_idx)
2651{
2652 struct bpf_verifier_state *state = env->cur_state;
2653 struct bpf_func_state *caller, *callee;
fd978bf7 2654 int i, err, subprog, target_insn;
f4d7e40a 2655
aada9ce6 2656 if (state->curframe + 1 >= MAX_CALL_FRAMES) {
f4d7e40a 2657 verbose(env, "the call stack of %d frames is too deep\n",
aada9ce6 2658 state->curframe + 2);
f4d7e40a
AS
2659 return -E2BIG;
2660 }
2661
2662 target_insn = *insn_idx + insn->imm;
2663 subprog = find_subprog(env, target_insn + 1);
2664 if (subprog < 0) {
2665 verbose(env, "verifier bug. No program starts at insn %d\n",
2666 target_insn + 1);
2667 return -EFAULT;
2668 }
2669
2670 caller = state->frame[state->curframe];
2671 if (state->frame[state->curframe + 1]) {
2672 verbose(env, "verifier bug. Frame %d already allocated\n",
2673 state->curframe + 1);
2674 return -EFAULT;
2675 }
2676
2677 callee = kzalloc(sizeof(*callee), GFP_KERNEL);
2678 if (!callee)
2679 return -ENOMEM;
2680 state->frame[state->curframe + 1] = callee;
2681
2682 /* callee cannot access r0, r6 - r9 for reading and has to write
2683 * into its own stack before reading from it.
2684 * callee can read/write into caller's stack
2685 */
2686 init_func_state(env, callee,
2687 /* remember the callsite, it will be used by bpf_exit */
2688 *insn_idx /* callsite */,
2689 state->curframe + 1 /* frameno within this callchain */,
f910cefa 2690 subprog /* subprog number within this prog */);
f4d7e40a 2691
fd978bf7
JS
2692 /* Transfer references to the callee */
2693 err = transfer_reference_state(callee, caller);
2694 if (err)
2695 return err;
2696
679c782d
EC
2697 /* copy r1 - r5 args that callee can access. The copy includes parent
2698 * pointers, which connects us up to the liveness chain
2699 */
f4d7e40a
AS
2700 for (i = BPF_REG_1; i <= BPF_REG_5; i++)
2701 callee->regs[i] = caller->regs[i];
2702
679c782d 2703 /* after the call registers r0 - r5 were scratched */
f4d7e40a
AS
2704 for (i = 0; i < CALLER_SAVED_REGS; i++) {
2705 mark_reg_not_init(env, caller->regs, caller_saved[i]);
2706 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
2707 }
2708
2709 /* only increment it after check_reg_arg() finished */
2710 state->curframe++;
2711
2712 /* and go analyze first insn of the callee */
2713 *insn_idx = target_insn;
2714
2715 if (env->log.level) {
2716 verbose(env, "caller:\n");
2717 print_verifier_state(env, caller);
2718 verbose(env, "callee:\n");
2719 print_verifier_state(env, callee);
2720 }
2721 return 0;
2722}
2723
2724static int prepare_func_exit(struct bpf_verifier_env *env, int *insn_idx)
2725{
2726 struct bpf_verifier_state *state = env->cur_state;
2727 struct bpf_func_state *caller, *callee;
2728 struct bpf_reg_state *r0;
fd978bf7 2729 int err;
f4d7e40a
AS
2730
2731 callee = state->frame[state->curframe];
2732 r0 = &callee->regs[BPF_REG_0];
2733 if (r0->type == PTR_TO_STACK) {
2734 /* technically it's ok to return caller's stack pointer
2735 * (or caller's caller's pointer) back to the caller,
2736 * since these pointers are valid. Only current stack
2737 * pointer will be invalid as soon as function exits,
2738 * but let's be conservative
2739 */
2740 verbose(env, "cannot return stack pointer to the caller\n");
2741 return -EINVAL;
2742 }
2743
2744 state->curframe--;
2745 caller = state->frame[state->curframe];
2746 /* return to the caller whatever r0 had in the callee */
2747 caller->regs[BPF_REG_0] = *r0;
2748
fd978bf7
JS
2749 /* Transfer references to the caller */
2750 err = transfer_reference_state(caller, callee);
2751 if (err)
2752 return err;
2753
f4d7e40a
AS
2754 *insn_idx = callee->callsite + 1;
2755 if (env->log.level) {
2756 verbose(env, "returning from callee:\n");
2757 print_verifier_state(env, callee);
2758 verbose(env, "to caller at %d:\n", *insn_idx);
2759 print_verifier_state(env, caller);
2760 }
2761 /* clear everything in the callee */
2762 free_func_state(callee);
2763 state->frame[state->curframe + 1] = NULL;
2764 return 0;
2765}
2766
849fa506
YS
2767static void do_refine_retval_range(struct bpf_reg_state *regs, int ret_type,
2768 int func_id,
2769 struct bpf_call_arg_meta *meta)
2770{
2771 struct bpf_reg_state *ret_reg = &regs[BPF_REG_0];
2772
2773 if (ret_type != RET_INTEGER ||
2774 (func_id != BPF_FUNC_get_stack &&
2775 func_id != BPF_FUNC_probe_read_str))
2776 return;
2777
2778 ret_reg->smax_value = meta->msize_smax_value;
2779 ret_reg->umax_value = meta->msize_umax_value;
2780 __reg_deduce_bounds(ret_reg);
2781 __reg_bound_offset(ret_reg);
2782}
2783
c93552c4
DB
2784static int
2785record_func_map(struct bpf_verifier_env *env, struct bpf_call_arg_meta *meta,
2786 int func_id, int insn_idx)
2787{
2788 struct bpf_insn_aux_data *aux = &env->insn_aux_data[insn_idx];
2789
2790 if (func_id != BPF_FUNC_tail_call &&
09772d92
DB
2791 func_id != BPF_FUNC_map_lookup_elem &&
2792 func_id != BPF_FUNC_map_update_elem &&
f1a2e44a
MV
2793 func_id != BPF_FUNC_map_delete_elem &&
2794 func_id != BPF_FUNC_map_push_elem &&
2795 func_id != BPF_FUNC_map_pop_elem &&
2796 func_id != BPF_FUNC_map_peek_elem)
c93552c4 2797 return 0;
09772d92 2798
c93552c4
DB
2799 if (meta->map_ptr == NULL) {
2800 verbose(env, "kernel subsystem misconfigured verifier\n");
2801 return -EINVAL;
2802 }
2803
2804 if (!BPF_MAP_PTR(aux->map_state))
2805 bpf_map_ptr_store(aux, meta->map_ptr,
2806 meta->map_ptr->unpriv_array);
2807 else if (BPF_MAP_PTR(aux->map_state) != meta->map_ptr)
2808 bpf_map_ptr_store(aux, BPF_MAP_PTR_POISON,
2809 meta->map_ptr->unpriv_array);
2810 return 0;
2811}
2812
fd978bf7
JS
2813static int check_reference_leak(struct bpf_verifier_env *env)
2814{
2815 struct bpf_func_state *state = cur_func(env);
2816 int i;
2817
2818 for (i = 0; i < state->acquired_refs; i++) {
2819 verbose(env, "Unreleased reference id=%d alloc_insn=%d\n",
2820 state->refs[i].id, state->refs[i].insn_idx);
2821 }
2822 return state->acquired_refs ? -EINVAL : 0;
2823}
2824
f4d7e40a 2825static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
17a52670 2826{
17a52670 2827 const struct bpf_func_proto *fn = NULL;
638f5b90 2828 struct bpf_reg_state *regs;
33ff9823 2829 struct bpf_call_arg_meta meta;
969bf05e 2830 bool changes_data;
17a52670
AS
2831 int i, err;
2832
2833 /* find function prototype */
2834 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
61bd5218
JK
2835 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
2836 func_id);
17a52670
AS
2837 return -EINVAL;
2838 }
2839
00176a34 2840 if (env->ops->get_func_proto)
5e43f899 2841 fn = env->ops->get_func_proto(func_id, env->prog);
17a52670 2842 if (!fn) {
61bd5218
JK
2843 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
2844 func_id);
17a52670
AS
2845 return -EINVAL;
2846 }
2847
2848 /* eBPF programs must be GPL compatible to use GPL-ed functions */
24701ece 2849 if (!env->prog->gpl_compatible && fn->gpl_only) {
3fe2867c 2850 verbose(env, "cannot call GPL-restricted function from non-GPL compatible program\n");
17a52670
AS
2851 return -EINVAL;
2852 }
2853
04514d13 2854 /* With LD_ABS/IND some JITs save/restore skb from r1. */
17bedab2 2855 changes_data = bpf_helper_changes_pkt_data(fn->func);
04514d13
DB
2856 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
2857 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
2858 func_id_name(func_id), func_id);
2859 return -EINVAL;
2860 }
969bf05e 2861
33ff9823 2862 memset(&meta, 0, sizeof(meta));
36bbef52 2863 meta.pkt_access = fn->pkt_access;
33ff9823 2864
90133415 2865 err = check_func_proto(fn);
435faee1 2866 if (err) {
61bd5218 2867 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
ebb676da 2868 func_id_name(func_id), func_id);
435faee1
DB
2869 return err;
2870 }
2871
17a52670 2872 /* check args */
33ff9823 2873 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
17a52670
AS
2874 if (err)
2875 return err;
33ff9823 2876 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
17a52670
AS
2877 if (err)
2878 return err;
33ff9823 2879 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
17a52670
AS
2880 if (err)
2881 return err;
33ff9823 2882 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
17a52670
AS
2883 if (err)
2884 return err;
33ff9823 2885 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
17a52670
AS
2886 if (err)
2887 return err;
2888
c93552c4
DB
2889 err = record_func_map(env, &meta, func_id, insn_idx);
2890 if (err)
2891 return err;
2892
435faee1
DB
2893 /* Mark slots with STACK_MISC in case of raw mode, stack offset
2894 * is inferred from register state.
2895 */
2896 for (i = 0; i < meta.access_size; i++) {
ca369602
DB
2897 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B,
2898 BPF_WRITE, -1, false);
435faee1
DB
2899 if (err)
2900 return err;
2901 }
2902
fd978bf7
JS
2903 if (func_id == BPF_FUNC_tail_call) {
2904 err = check_reference_leak(env);
2905 if (err) {
2906 verbose(env, "tail_call would lead to reference leak\n");
2907 return err;
2908 }
2909 } else if (is_release_function(func_id)) {
2910 err = release_reference(env, &meta);
2911 if (err)
2912 return err;
2913 }
2914
638f5b90 2915 regs = cur_regs(env);
cd339431
RG
2916
2917 /* check that flags argument in get_local_storage(map, flags) is 0,
2918 * this is required because get_local_storage() can't return an error.
2919 */
2920 if (func_id == BPF_FUNC_get_local_storage &&
2921 !register_is_null(&regs[BPF_REG_2])) {
2922 verbose(env, "get_local_storage() doesn't support non-zero flags\n");
2923 return -EINVAL;
2924 }
2925
17a52670 2926 /* reset caller saved regs */
dc503a8a 2927 for (i = 0; i < CALLER_SAVED_REGS; i++) {
61bd5218 2928 mark_reg_not_init(env, regs, caller_saved[i]);
dc503a8a
EC
2929 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
2930 }
17a52670 2931
dc503a8a 2932 /* update return register (already marked as written above) */
17a52670 2933 if (fn->ret_type == RET_INTEGER) {
f1174f77 2934 /* sets type to SCALAR_VALUE */
61bd5218 2935 mark_reg_unknown(env, regs, BPF_REG_0);
17a52670
AS
2936 } else if (fn->ret_type == RET_VOID) {
2937 regs[BPF_REG_0].type = NOT_INIT;
3e6a4b3e
RG
2938 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL ||
2939 fn->ret_type == RET_PTR_TO_MAP_VALUE) {
f1174f77 2940 /* There is no offset yet applied, variable or fixed */
61bd5218 2941 mark_reg_known_zero(env, regs, BPF_REG_0);
17a52670
AS
2942 /* remember map_ptr, so that check_map_access()
2943 * can check 'value_size' boundary of memory access
2944 * to map element returned from bpf_map_lookup_elem()
2945 */
33ff9823 2946 if (meta.map_ptr == NULL) {
61bd5218
JK
2947 verbose(env,
2948 "kernel subsystem misconfigured verifier\n");
17a52670
AS
2949 return -EINVAL;
2950 }
33ff9823 2951 regs[BPF_REG_0].map_ptr = meta.map_ptr;
4d31f301
DB
2952 if (fn->ret_type == RET_PTR_TO_MAP_VALUE) {
2953 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE;
2954 } else {
2955 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
2956 regs[BPF_REG_0].id = ++env->id_gen;
2957 }
c64b7983 2958 } else if (fn->ret_type == RET_PTR_TO_SOCKET_OR_NULL) {
fd978bf7
JS
2959 int id = acquire_reference_state(env, insn_idx);
2960 if (id < 0)
2961 return id;
c64b7983
JS
2962 mark_reg_known_zero(env, regs, BPF_REG_0);
2963 regs[BPF_REG_0].type = PTR_TO_SOCKET_OR_NULL;
fd978bf7 2964 regs[BPF_REG_0].id = id;
17a52670 2965 } else {
61bd5218 2966 verbose(env, "unknown return type %d of func %s#%d\n",
ebb676da 2967 fn->ret_type, func_id_name(func_id), func_id);
17a52670
AS
2968 return -EINVAL;
2969 }
04fd61ab 2970
849fa506
YS
2971 do_refine_retval_range(regs, fn->ret_type, func_id, &meta);
2972
61bd5218 2973 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
35578d79
KX
2974 if (err)
2975 return err;
04fd61ab 2976
c195651e
YS
2977 if (func_id == BPF_FUNC_get_stack && !env->prog->has_callchain_buf) {
2978 const char *err_str;
2979
2980#ifdef CONFIG_PERF_EVENTS
2981 err = get_callchain_buffers(sysctl_perf_event_max_stack);
2982 err_str = "cannot get callchain buffer for func %s#%d\n";
2983#else
2984 err = -ENOTSUPP;
2985 err_str = "func %s#%d not supported without CONFIG_PERF_EVENTS\n";
2986#endif
2987 if (err) {
2988 verbose(env, err_str, func_id_name(func_id), func_id);
2989 return err;
2990 }
2991
2992 env->prog->has_callchain_buf = true;
2993 }
2994
969bf05e
AS
2995 if (changes_data)
2996 clear_all_pkt_pointers(env);
2997 return 0;
2998}
2999
b03c9f9f
EC
3000static bool signed_add_overflows(s64 a, s64 b)
3001{
3002 /* Do the add in u64, where overflow is well-defined */
3003 s64 res = (s64)((u64)a + (u64)b);
3004
3005 if (b < 0)
3006 return res > a;
3007 return res < a;
3008}
3009
3010static bool signed_sub_overflows(s64 a, s64 b)
3011{
3012 /* Do the sub in u64, where overflow is well-defined */
3013 s64 res = (s64)((u64)a - (u64)b);
3014
3015 if (b < 0)
3016 return res < a;
3017 return res > a;
969bf05e
AS
3018}
3019
bb7f0f98
AS
3020static bool check_reg_sane_offset(struct bpf_verifier_env *env,
3021 const struct bpf_reg_state *reg,
3022 enum bpf_reg_type type)
3023{
3024 bool known = tnum_is_const(reg->var_off);
3025 s64 val = reg->var_off.value;
3026 s64 smin = reg->smin_value;
3027
3028 if (known && (val >= BPF_MAX_VAR_OFF || val <= -BPF_MAX_VAR_OFF)) {
3029 verbose(env, "math between %s pointer and %lld is not allowed\n",
3030 reg_type_str[type], val);
3031 return false;
3032 }
3033
3034 if (reg->off >= BPF_MAX_VAR_OFF || reg->off <= -BPF_MAX_VAR_OFF) {
3035 verbose(env, "%s pointer offset %d is not allowed\n",
3036 reg_type_str[type], reg->off);
3037 return false;
3038 }
3039
3040 if (smin == S64_MIN) {
3041 verbose(env, "math between %s pointer and register with unbounded min value is not allowed\n",
3042 reg_type_str[type]);
3043 return false;
3044 }
3045
3046 if (smin >= BPF_MAX_VAR_OFF || smin <= -BPF_MAX_VAR_OFF) {
3047 verbose(env, "value %lld makes %s pointer be out of bounds\n",
3048 smin, reg_type_str[type]);
3049 return false;
3050 }
3051
3052 return true;
3053}
3054
f1174f77 3055/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
f1174f77
EC
3056 * Caller should also handle BPF_MOV case separately.
3057 * If we return -EACCES, caller may want to try again treating pointer as a
3058 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
3059 */
3060static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
3061 struct bpf_insn *insn,
3062 const struct bpf_reg_state *ptr_reg,
3063 const struct bpf_reg_state *off_reg)
969bf05e 3064{
f4d7e40a
AS
3065 struct bpf_verifier_state *vstate = env->cur_state;
3066 struct bpf_func_state *state = vstate->frame[vstate->curframe];
3067 struct bpf_reg_state *regs = state->regs, *dst_reg;
f1174f77 3068 bool known = tnum_is_const(off_reg->var_off);
b03c9f9f
EC
3069 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
3070 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
3071 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
3072 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
969bf05e 3073 u8 opcode = BPF_OP(insn->code);
f1174f77 3074 u32 dst = insn->dst_reg;
969bf05e 3075
f1174f77 3076 dst_reg = &regs[dst];
969bf05e 3077
6f16101e
DB
3078 if ((known && (smin_val != smax_val || umin_val != umax_val)) ||
3079 smin_val > smax_val || umin_val > umax_val) {
3080 /* Taint dst register if offset had invalid bounds derived from
3081 * e.g. dead branches.
3082 */
3083 __mark_reg_unknown(dst_reg);
3084 return 0;
f1174f77
EC
3085 }
3086
3087 if (BPF_CLASS(insn->code) != BPF_ALU64) {
3088 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
82abbf8d
AS
3089 verbose(env,
3090 "R%d 32-bit pointer arithmetic prohibited\n",
3091 dst);
f1174f77 3092 return -EACCES;
969bf05e
AS
3093 }
3094
aad2eeaf
JS
3095 switch (ptr_reg->type) {
3096 case PTR_TO_MAP_VALUE_OR_NULL:
3097 verbose(env, "R%d pointer arithmetic on %s prohibited, null-check it first\n",
3098 dst, reg_type_str[ptr_reg->type]);
f1174f77 3099 return -EACCES;
aad2eeaf
JS
3100 case CONST_PTR_TO_MAP:
3101 case PTR_TO_PACKET_END:
c64b7983
JS
3102 case PTR_TO_SOCKET:
3103 case PTR_TO_SOCKET_OR_NULL:
aad2eeaf
JS
3104 verbose(env, "R%d pointer arithmetic on %s prohibited\n",
3105 dst, reg_type_str[ptr_reg->type]);
f1174f77 3106 return -EACCES;
aad2eeaf
JS
3107 default:
3108 break;
f1174f77
EC
3109 }
3110
3111 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
3112 * The id may be overwritten later if we create a new variable offset.
969bf05e 3113 */
f1174f77
EC
3114 dst_reg->type = ptr_reg->type;
3115 dst_reg->id = ptr_reg->id;
969bf05e 3116
bb7f0f98
AS
3117 if (!check_reg_sane_offset(env, off_reg, ptr_reg->type) ||
3118 !check_reg_sane_offset(env, ptr_reg, ptr_reg->type))
3119 return -EINVAL;
3120
f1174f77
EC
3121 switch (opcode) {
3122 case BPF_ADD:
3123 /* We can take a fixed offset as long as it doesn't overflow
3124 * the s32 'off' field
969bf05e 3125 */
b03c9f9f
EC
3126 if (known && (ptr_reg->off + smin_val ==
3127 (s64)(s32)(ptr_reg->off + smin_val))) {
f1174f77 3128 /* pointer += K. Accumulate it into fixed offset */
b03c9f9f
EC
3129 dst_reg->smin_value = smin_ptr;
3130 dst_reg->smax_value = smax_ptr;
3131 dst_reg->umin_value = umin_ptr;
3132 dst_reg->umax_value = umax_ptr;
f1174f77 3133 dst_reg->var_off = ptr_reg->var_off;
b03c9f9f 3134 dst_reg->off = ptr_reg->off + smin_val;
0962590e 3135 dst_reg->raw = ptr_reg->raw;
f1174f77
EC
3136 break;
3137 }
f1174f77
EC
3138 /* A new variable offset is created. Note that off_reg->off
3139 * == 0, since it's a scalar.
3140 * dst_reg gets the pointer type and since some positive
3141 * integer value was added to the pointer, give it a new 'id'
3142 * if it's a PTR_TO_PACKET.
3143 * this creates a new 'base' pointer, off_reg (variable) gets
3144 * added into the variable offset, and we copy the fixed offset
3145 * from ptr_reg.
969bf05e 3146 */
b03c9f9f
EC
3147 if (signed_add_overflows(smin_ptr, smin_val) ||
3148 signed_add_overflows(smax_ptr, smax_val)) {
3149 dst_reg->smin_value = S64_MIN;
3150 dst_reg->smax_value = S64_MAX;
3151 } else {
3152 dst_reg->smin_value = smin_ptr + smin_val;
3153 dst_reg->smax_value = smax_ptr + smax_val;
3154 }
3155 if (umin_ptr + umin_val < umin_ptr ||
3156 umax_ptr + umax_val < umax_ptr) {
3157 dst_reg->umin_value = 0;
3158 dst_reg->umax_value = U64_MAX;
3159 } else {
3160 dst_reg->umin_value = umin_ptr + umin_val;
3161 dst_reg->umax_value = umax_ptr + umax_val;
3162 }
f1174f77
EC
3163 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
3164 dst_reg->off = ptr_reg->off;
0962590e 3165 dst_reg->raw = ptr_reg->raw;
de8f3a83 3166 if (reg_is_pkt_pointer(ptr_reg)) {
f1174f77
EC
3167 dst_reg->id = ++env->id_gen;
3168 /* something was added to pkt_ptr, set range to zero */
0962590e 3169 dst_reg->raw = 0;
f1174f77
EC
3170 }
3171 break;
3172 case BPF_SUB:
3173 if (dst_reg == off_reg) {
3174 /* scalar -= pointer. Creates an unknown scalar */
82abbf8d
AS
3175 verbose(env, "R%d tried to subtract pointer from scalar\n",
3176 dst);
f1174f77
EC
3177 return -EACCES;
3178 }
3179 /* We don't allow subtraction from FP, because (according to
3180 * test_verifier.c test "invalid fp arithmetic", JITs might not
3181 * be able to deal with it.
969bf05e 3182 */
f1174f77 3183 if (ptr_reg->type == PTR_TO_STACK) {
82abbf8d
AS
3184 verbose(env, "R%d subtraction from stack pointer prohibited\n",
3185 dst);
f1174f77
EC
3186 return -EACCES;
3187 }
b03c9f9f
EC
3188 if (known && (ptr_reg->off - smin_val ==
3189 (s64)(s32)(ptr_reg->off - smin_val))) {
f1174f77 3190 /* pointer -= K. Subtract it from fixed offset */
b03c9f9f
EC
3191 dst_reg->smin_value = smin_ptr;
3192 dst_reg->smax_value = smax_ptr;
3193 dst_reg->umin_value = umin_ptr;
3194 dst_reg->umax_value = umax_ptr;
f1174f77
EC
3195 dst_reg->var_off = ptr_reg->var_off;
3196 dst_reg->id = ptr_reg->id;
b03c9f9f 3197 dst_reg->off = ptr_reg->off - smin_val;
0962590e 3198 dst_reg->raw = ptr_reg->raw;
f1174f77
EC
3199 break;
3200 }
f1174f77
EC
3201 /* A new variable offset is created. If the subtrahend is known
3202 * nonnegative, then any reg->range we had before is still good.
969bf05e 3203 */
b03c9f9f
EC
3204 if (signed_sub_overflows(smin_ptr, smax_val) ||
3205 signed_sub_overflows(smax_ptr, smin_val)) {
3206 /* Overflow possible, we know nothing */
3207 dst_reg->smin_value = S64_MIN;
3208 dst_reg->smax_value = S64_MAX;
3209 } else {
3210 dst_reg->smin_value = smin_ptr - smax_val;
3211 dst_reg->smax_value = smax_ptr - smin_val;
3212 }
3213 if (umin_ptr < umax_val) {
3214 /* Overflow possible, we know nothing */
3215 dst_reg->umin_value = 0;
3216 dst_reg->umax_value = U64_MAX;
3217 } else {
3218 /* Cannot overflow (as long as bounds are consistent) */
3219 dst_reg->umin_value = umin_ptr - umax_val;
3220 dst_reg->umax_value = umax_ptr - umin_val;
3221 }
f1174f77
EC
3222 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
3223 dst_reg->off = ptr_reg->off;
0962590e 3224 dst_reg->raw = ptr_reg->raw;
de8f3a83 3225 if (reg_is_pkt_pointer(ptr_reg)) {
f1174f77
EC
3226 dst_reg->id = ++env->id_gen;
3227 /* something was added to pkt_ptr, set range to zero */
b03c9f9f 3228 if (smin_val < 0)
0962590e 3229 dst_reg->raw = 0;
43188702 3230 }
f1174f77
EC
3231 break;
3232 case BPF_AND:
3233 case BPF_OR:
3234 case BPF_XOR:
82abbf8d
AS
3235 /* bitwise ops on pointers are troublesome, prohibit. */
3236 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
3237 dst, bpf_alu_string[opcode >> 4]);
f1174f77
EC
3238 return -EACCES;
3239 default:
3240 /* other operators (e.g. MUL,LSH) produce non-pointer results */
82abbf8d
AS
3241 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
3242 dst, bpf_alu_string[opcode >> 4]);
f1174f77 3243 return -EACCES;
43188702
JF
3244 }
3245
bb7f0f98
AS
3246 if (!check_reg_sane_offset(env, dst_reg, ptr_reg->type))
3247 return -EINVAL;
3248
b03c9f9f
EC
3249 __update_reg_bounds(dst_reg);
3250 __reg_deduce_bounds(dst_reg);
3251 __reg_bound_offset(dst_reg);
43188702
JF
3252 return 0;
3253}
3254
468f6eaf
JH
3255/* WARNING: This function does calculations on 64-bit values, but the actual
3256 * execution may occur on 32-bit values. Therefore, things like bitshifts
3257 * need extra checks in the 32-bit case.
3258 */
f1174f77
EC
3259static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
3260 struct bpf_insn *insn,
3261 struct bpf_reg_state *dst_reg,
3262 struct bpf_reg_state src_reg)
969bf05e 3263{
638f5b90 3264 struct bpf_reg_state *regs = cur_regs(env);
48461135 3265 u8 opcode = BPF_OP(insn->code);
f1174f77 3266 bool src_known, dst_known;
b03c9f9f
EC
3267 s64 smin_val, smax_val;
3268 u64 umin_val, umax_val;
468f6eaf 3269 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
48461135 3270
b799207e
JH
3271 if (insn_bitness == 32) {
3272 /* Relevant for 32-bit RSH: Information can propagate towards
3273 * LSB, so it isn't sufficient to only truncate the output to
3274 * 32 bits.
3275 */
3276 coerce_reg_to_size(dst_reg, 4);
3277 coerce_reg_to_size(&src_reg, 4);
3278 }
3279
b03c9f9f
EC
3280 smin_val = src_reg.smin_value;
3281 smax_val = src_reg.smax_value;
3282 umin_val = src_reg.umin_value;
3283 umax_val = src_reg.umax_value;
f1174f77
EC
3284 src_known = tnum_is_const(src_reg.var_off);
3285 dst_known = tnum_is_const(dst_reg->var_off);
f23cc643 3286
6f16101e
DB
3287 if ((src_known && (smin_val != smax_val || umin_val != umax_val)) ||
3288 smin_val > smax_val || umin_val > umax_val) {
3289 /* Taint dst register if offset had invalid bounds derived from
3290 * e.g. dead branches.
3291 */
3292 __mark_reg_unknown(dst_reg);
3293 return 0;
3294 }
3295
bb7f0f98
AS
3296 if (!src_known &&
3297 opcode != BPF_ADD && opcode != BPF_SUB && opcode != BPF_AND) {
3298 __mark_reg_unknown(dst_reg);
3299 return 0;
3300 }
3301
48461135
JB
3302 switch (opcode) {
3303 case BPF_ADD:
b03c9f9f
EC
3304 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
3305 signed_add_overflows(dst_reg->smax_value, smax_val)) {
3306 dst_reg->smin_value = S64_MIN;
3307 dst_reg->smax_value = S64_MAX;
3308 } else {
3309 dst_reg->smin_value += smin_val;
3310 dst_reg->smax_value += smax_val;
3311 }
3312 if (dst_reg->umin_value + umin_val < umin_val ||
3313 dst_reg->umax_value + umax_val < umax_val) {
3314 dst_reg->umin_value = 0;
3315 dst_reg->umax_value = U64_MAX;
3316 } else {
3317 dst_reg->umin_value += umin_val;
3318 dst_reg->umax_value += umax_val;
3319 }
f1174f77 3320 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
48461135
JB
3321 break;
3322 case BPF_SUB:
b03c9f9f
EC
3323 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
3324 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
3325 /* Overflow possible, we know nothing */
3326 dst_reg->smin_value = S64_MIN;
3327 dst_reg->smax_value = S64_MAX;
3328 } else {
3329 dst_reg->smin_value -= smax_val;
3330 dst_reg->smax_value -= smin_val;
3331 }
3332 if (dst_reg->umin_value < umax_val) {
3333 /* Overflow possible, we know nothing */
3334 dst_reg->umin_value = 0;
3335 dst_reg->umax_value = U64_MAX;
3336 } else {
3337 /* Cannot overflow (as long as bounds are consistent) */
3338 dst_reg->umin_value -= umax_val;
3339 dst_reg->umax_value -= umin_val;
3340 }
f1174f77 3341 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
48461135
JB
3342 break;
3343 case BPF_MUL:
b03c9f9f
EC
3344 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
3345 if (smin_val < 0 || dst_reg->smin_value < 0) {
f1174f77 3346 /* Ain't nobody got time to multiply that sign */
b03c9f9f
EC
3347 __mark_reg_unbounded(dst_reg);
3348 __update_reg_bounds(dst_reg);
f1174f77
EC
3349 break;
3350 }
b03c9f9f
EC
3351 /* Both values are positive, so we can work with unsigned and
3352 * copy the result to signed (unless it exceeds S64_MAX).
f1174f77 3353 */
b03c9f9f
EC
3354 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
3355 /* Potential overflow, we know nothing */
3356 __mark_reg_unbounded(dst_reg);
3357 /* (except what we can learn from the var_off) */
3358 __update_reg_bounds(dst_reg);
3359 break;
3360 }
3361 dst_reg->umin_value *= umin_val;
3362 dst_reg->umax_value *= umax_val;
3363 if (dst_reg->umax_value > S64_MAX) {
3364 /* Overflow possible, we know nothing */
3365 dst_reg->smin_value = S64_MIN;
3366 dst_reg->smax_value = S64_MAX;
3367 } else {
3368 dst_reg->smin_value = dst_reg->umin_value;
3369 dst_reg->smax_value = dst_reg->umax_value;
3370 }
48461135
JB
3371 break;
3372 case BPF_AND:
f1174f77 3373 if (src_known && dst_known) {
b03c9f9f
EC
3374 __mark_reg_known(dst_reg, dst_reg->var_off.value &
3375 src_reg.var_off.value);
f1174f77
EC
3376 break;
3377 }
b03c9f9f
EC
3378 /* We get our minimum from the var_off, since that's inherently
3379 * bitwise. Our maximum is the minimum of the operands' maxima.
f23cc643 3380 */
f1174f77 3381 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
b03c9f9f
EC
3382 dst_reg->umin_value = dst_reg->var_off.value;
3383 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
3384 if (dst_reg->smin_value < 0 || smin_val < 0) {
3385 /* Lose signed bounds when ANDing negative numbers,
3386 * ain't nobody got time for that.
3387 */
3388 dst_reg->smin_value = S64_MIN;
3389 dst_reg->smax_value = S64_MAX;
3390 } else {
3391 /* ANDing two positives gives a positive, so safe to
3392 * cast result into s64.
3393 */
3394 dst_reg->smin_value = dst_reg->umin_value;
3395 dst_reg->smax_value = dst_reg->umax_value;
3396 }
3397 /* We may learn something more from the var_off */
3398 __update_reg_bounds(dst_reg);
f1174f77
EC
3399 break;
3400 case BPF_OR:
3401 if (src_known && dst_known) {
b03c9f9f
EC
3402 __mark_reg_known(dst_reg, dst_reg->var_off.value |
3403 src_reg.var_off.value);
f1174f77
EC
3404 break;
3405 }
b03c9f9f
EC
3406 /* We get our maximum from the var_off, and our minimum is the
3407 * maximum of the operands' minima
f1174f77
EC
3408 */
3409 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
b03c9f9f
EC
3410 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
3411 dst_reg->umax_value = dst_reg->var_off.value |
3412 dst_reg->var_off.mask;
3413 if (dst_reg->smin_value < 0 || smin_val < 0) {
3414 /* Lose signed bounds when ORing negative numbers,
3415 * ain't nobody got time for that.
3416 */
3417 dst_reg->smin_value = S64_MIN;
3418 dst_reg->smax_value = S64_MAX;
f1174f77 3419 } else {
b03c9f9f
EC
3420 /* ORing two positives gives a positive, so safe to
3421 * cast result into s64.
3422 */
3423 dst_reg->smin_value = dst_reg->umin_value;
3424 dst_reg->smax_value = dst_reg->umax_value;
f1174f77 3425 }
b03c9f9f
EC
3426 /* We may learn something more from the var_off */
3427 __update_reg_bounds(dst_reg);
48461135
JB
3428 break;
3429 case BPF_LSH:
468f6eaf
JH
3430 if (umax_val >= insn_bitness) {
3431 /* Shifts greater than 31 or 63 are undefined.
3432 * This includes shifts by a negative number.
b03c9f9f 3433 */
61bd5218 3434 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77
EC
3435 break;
3436 }
b03c9f9f
EC
3437 /* We lose all sign bit information (except what we can pick
3438 * up from var_off)
48461135 3439 */
b03c9f9f
EC
3440 dst_reg->smin_value = S64_MIN;
3441 dst_reg->smax_value = S64_MAX;
3442 /* If we might shift our top bit out, then we know nothing */
3443 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
3444 dst_reg->umin_value = 0;
3445 dst_reg->umax_value = U64_MAX;
d1174416 3446 } else {
b03c9f9f
EC
3447 dst_reg->umin_value <<= umin_val;
3448 dst_reg->umax_value <<= umax_val;
d1174416 3449 }
afbe1a5b 3450 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
b03c9f9f
EC
3451 /* We may learn something more from the var_off */
3452 __update_reg_bounds(dst_reg);
48461135
JB
3453 break;
3454 case BPF_RSH:
468f6eaf
JH
3455 if (umax_val >= insn_bitness) {
3456 /* Shifts greater than 31 or 63 are undefined.
3457 * This includes shifts by a negative number.
b03c9f9f 3458 */
61bd5218 3459 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77
EC
3460 break;
3461 }
4374f256
EC
3462 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
3463 * be negative, then either:
3464 * 1) src_reg might be zero, so the sign bit of the result is
3465 * unknown, so we lose our signed bounds
3466 * 2) it's known negative, thus the unsigned bounds capture the
3467 * signed bounds
3468 * 3) the signed bounds cross zero, so they tell us nothing
3469 * about the result
3470 * If the value in dst_reg is known nonnegative, then again the
3471 * unsigned bounts capture the signed bounds.
3472 * Thus, in all cases it suffices to blow away our signed bounds
3473 * and rely on inferring new ones from the unsigned bounds and
3474 * var_off of the result.
3475 */
3476 dst_reg->smin_value = S64_MIN;
3477 dst_reg->smax_value = S64_MAX;
afbe1a5b 3478 dst_reg->var_off = tnum_rshift(dst_reg->var_off, umin_val);
b03c9f9f
EC
3479 dst_reg->umin_value >>= umax_val;
3480 dst_reg->umax_value >>= umin_val;
3481 /* We may learn something more from the var_off */
3482 __update_reg_bounds(dst_reg);
48461135 3483 break;
9cbe1f5a
YS
3484 case BPF_ARSH:
3485 if (umax_val >= insn_bitness) {
3486 /* Shifts greater than 31 or 63 are undefined.
3487 * This includes shifts by a negative number.
3488 */
3489 mark_reg_unknown(env, regs, insn->dst_reg);
3490 break;
3491 }
3492
3493 /* Upon reaching here, src_known is true and
3494 * umax_val is equal to umin_val.
3495 */
3496 dst_reg->smin_value >>= umin_val;
3497 dst_reg->smax_value >>= umin_val;
3498 dst_reg->var_off = tnum_arshift(dst_reg->var_off, umin_val);
3499
3500 /* blow away the dst_reg umin_value/umax_value and rely on
3501 * dst_reg var_off to refine the result.
3502 */
3503 dst_reg->umin_value = 0;
3504 dst_reg->umax_value = U64_MAX;
3505 __update_reg_bounds(dst_reg);
3506 break;
48461135 3507 default:
61bd5218 3508 mark_reg_unknown(env, regs, insn->dst_reg);
48461135
JB
3509 break;
3510 }
3511
468f6eaf
JH
3512 if (BPF_CLASS(insn->code) != BPF_ALU64) {
3513 /* 32-bit ALU ops are (32,32)->32 */
3514 coerce_reg_to_size(dst_reg, 4);
468f6eaf
JH
3515 }
3516
b03c9f9f
EC
3517 __reg_deduce_bounds(dst_reg);
3518 __reg_bound_offset(dst_reg);
f1174f77
EC
3519 return 0;
3520}
3521
3522/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
3523 * and var_off.
3524 */
3525static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
3526 struct bpf_insn *insn)
3527{
f4d7e40a
AS
3528 struct bpf_verifier_state *vstate = env->cur_state;
3529 struct bpf_func_state *state = vstate->frame[vstate->curframe];
3530 struct bpf_reg_state *regs = state->regs, *dst_reg, *src_reg;
f1174f77
EC
3531 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
3532 u8 opcode = BPF_OP(insn->code);
f1174f77
EC
3533
3534 dst_reg = &regs[insn->dst_reg];
f1174f77
EC
3535 src_reg = NULL;
3536 if (dst_reg->type != SCALAR_VALUE)
3537 ptr_reg = dst_reg;
3538 if (BPF_SRC(insn->code) == BPF_X) {
3539 src_reg = &regs[insn->src_reg];
f1174f77
EC
3540 if (src_reg->type != SCALAR_VALUE) {
3541 if (dst_reg->type != SCALAR_VALUE) {
3542 /* Combining two pointers by any ALU op yields
82abbf8d
AS
3543 * an arbitrary scalar. Disallow all math except
3544 * pointer subtraction
f1174f77 3545 */
dd066823 3546 if (opcode == BPF_SUB && env->allow_ptr_leaks) {
82abbf8d
AS
3547 mark_reg_unknown(env, regs, insn->dst_reg);
3548 return 0;
f1174f77 3549 }
82abbf8d
AS
3550 verbose(env, "R%d pointer %s pointer prohibited\n",
3551 insn->dst_reg,
3552 bpf_alu_string[opcode >> 4]);
3553 return -EACCES;
f1174f77
EC
3554 } else {
3555 /* scalar += pointer
3556 * This is legal, but we have to reverse our
3557 * src/dest handling in computing the range
3558 */
82abbf8d
AS
3559 return adjust_ptr_min_max_vals(env, insn,
3560 src_reg, dst_reg);
f1174f77
EC
3561 }
3562 } else if (ptr_reg) {
3563 /* pointer += scalar */
82abbf8d
AS
3564 return adjust_ptr_min_max_vals(env, insn,
3565 dst_reg, src_reg);
f1174f77
EC
3566 }
3567 } else {
3568 /* Pretend the src is a reg with a known value, since we only
3569 * need to be able to read from this state.
3570 */
3571 off_reg.type = SCALAR_VALUE;
b03c9f9f 3572 __mark_reg_known(&off_reg, insn->imm);
f1174f77 3573 src_reg = &off_reg;
82abbf8d
AS
3574 if (ptr_reg) /* pointer += K */
3575 return adjust_ptr_min_max_vals(env, insn,
3576 ptr_reg, src_reg);
f1174f77
EC
3577 }
3578
3579 /* Got here implies adding two SCALAR_VALUEs */
3580 if (WARN_ON_ONCE(ptr_reg)) {
f4d7e40a 3581 print_verifier_state(env, state);
61bd5218 3582 verbose(env, "verifier internal error: unexpected ptr_reg\n");
f1174f77
EC
3583 return -EINVAL;
3584 }
3585 if (WARN_ON(!src_reg)) {
f4d7e40a 3586 print_verifier_state(env, state);
61bd5218 3587 verbose(env, "verifier internal error: no src_reg\n");
f1174f77
EC
3588 return -EINVAL;
3589 }
3590 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
48461135
JB
3591}
3592
17a52670 3593/* check validity of 32-bit and 64-bit arithmetic operations */
58e2af8b 3594static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 3595{
638f5b90 3596 struct bpf_reg_state *regs = cur_regs(env);
17a52670
AS
3597 u8 opcode = BPF_OP(insn->code);
3598 int err;
3599
3600 if (opcode == BPF_END || opcode == BPF_NEG) {
3601 if (opcode == BPF_NEG) {
3602 if (BPF_SRC(insn->code) != 0 ||
3603 insn->src_reg != BPF_REG_0 ||
3604 insn->off != 0 || insn->imm != 0) {
61bd5218 3605 verbose(env, "BPF_NEG uses reserved fields\n");
17a52670
AS
3606 return -EINVAL;
3607 }
3608 } else {
3609 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
e67b8a68
EC
3610 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
3611 BPF_CLASS(insn->code) == BPF_ALU64) {
61bd5218 3612 verbose(env, "BPF_END uses reserved fields\n");
17a52670
AS
3613 return -EINVAL;
3614 }
3615 }
3616
3617 /* check src operand */
dc503a8a 3618 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
3619 if (err)
3620 return err;
3621
1be7f75d 3622 if (is_pointer_value(env, insn->dst_reg)) {
61bd5218 3623 verbose(env, "R%d pointer arithmetic prohibited\n",
1be7f75d
AS
3624 insn->dst_reg);
3625 return -EACCES;
3626 }
3627
17a52670 3628 /* check dest operand */
dc503a8a 3629 err = check_reg_arg(env, insn->dst_reg, DST_OP);
17a52670
AS
3630 if (err)
3631 return err;
3632
3633 } else if (opcode == BPF_MOV) {
3634
3635 if (BPF_SRC(insn->code) == BPF_X) {
3636 if (insn->imm != 0 || insn->off != 0) {
61bd5218 3637 verbose(env, "BPF_MOV uses reserved fields\n");
17a52670
AS
3638 return -EINVAL;
3639 }
3640
3641 /* check src operand */
dc503a8a 3642 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
3643 if (err)
3644 return err;
3645 } else {
3646 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
61bd5218 3647 verbose(env, "BPF_MOV uses reserved fields\n");
17a52670
AS
3648 return -EINVAL;
3649 }
3650 }
3651
fbeb1603
AF
3652 /* check dest operand, mark as required later */
3653 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
17a52670
AS
3654 if (err)
3655 return err;
3656
3657 if (BPF_SRC(insn->code) == BPF_X) {
e434b8cd
JW
3658 struct bpf_reg_state *src_reg = regs + insn->src_reg;
3659 struct bpf_reg_state *dst_reg = regs + insn->dst_reg;
3660
17a52670
AS
3661 if (BPF_CLASS(insn->code) == BPF_ALU64) {
3662 /* case: R1 = R2
3663 * copy register state to dest reg
3664 */
e434b8cd
JW
3665 *dst_reg = *src_reg;
3666 dst_reg->live |= REG_LIVE_WRITTEN;
17a52670 3667 } else {
f1174f77 3668 /* R1 = (u32) R2 */
1be7f75d 3669 if (is_pointer_value(env, insn->src_reg)) {
61bd5218
JK
3670 verbose(env,
3671 "R%d partial copy of pointer\n",
1be7f75d
AS
3672 insn->src_reg);
3673 return -EACCES;
e434b8cd
JW
3674 } else if (src_reg->type == SCALAR_VALUE) {
3675 *dst_reg = *src_reg;
3676 dst_reg->live |= REG_LIVE_WRITTEN;
3677 } else {
3678 mark_reg_unknown(env, regs,
3679 insn->dst_reg);
1be7f75d 3680 }
e434b8cd 3681 coerce_reg_to_size(dst_reg, 4);
17a52670
AS
3682 }
3683 } else {
3684 /* case: R = imm
3685 * remember the value we stored into this reg
3686 */
fbeb1603
AF
3687 /* clear any state __mark_reg_known doesn't set */
3688 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77 3689 regs[insn->dst_reg].type = SCALAR_VALUE;
95a762e2
JH
3690 if (BPF_CLASS(insn->code) == BPF_ALU64) {
3691 __mark_reg_known(regs + insn->dst_reg,
3692 insn->imm);
3693 } else {
3694 __mark_reg_known(regs + insn->dst_reg,
3695 (u32)insn->imm);
3696 }
17a52670
AS
3697 }
3698
3699 } else if (opcode > BPF_END) {
61bd5218 3700 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
17a52670
AS
3701 return -EINVAL;
3702
3703 } else { /* all other ALU ops: and, sub, xor, add, ... */
3704
17a52670
AS
3705 if (BPF_SRC(insn->code) == BPF_X) {
3706 if (insn->imm != 0 || insn->off != 0) {
61bd5218 3707 verbose(env, "BPF_ALU uses reserved fields\n");
17a52670
AS
3708 return -EINVAL;
3709 }
3710 /* check src1 operand */
dc503a8a 3711 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
3712 if (err)
3713 return err;
3714 } else {
3715 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
61bd5218 3716 verbose(env, "BPF_ALU uses reserved fields\n");
17a52670
AS
3717 return -EINVAL;
3718 }
3719 }
3720
3721 /* check src2 operand */
dc503a8a 3722 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
3723 if (err)
3724 return err;
3725
3726 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
3727 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
61bd5218 3728 verbose(env, "div by zero\n");
17a52670
AS
3729 return -EINVAL;
3730 }
3731
229394e8
RV
3732 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
3733 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
3734 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
3735
3736 if (insn->imm < 0 || insn->imm >= size) {
61bd5218 3737 verbose(env, "invalid shift %d\n", insn->imm);
229394e8
RV
3738 return -EINVAL;
3739 }
3740 }
3741
1a0dc1ac 3742 /* check dest operand */
dc503a8a 3743 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
1a0dc1ac
AS
3744 if (err)
3745 return err;
3746
f1174f77 3747 return adjust_reg_min_max_vals(env, insn);
17a52670
AS
3748 }
3749
3750 return 0;
3751}
3752
f4d7e40a 3753static void find_good_pkt_pointers(struct bpf_verifier_state *vstate,
de8f3a83 3754 struct bpf_reg_state *dst_reg,
f8ddadc4 3755 enum bpf_reg_type type,
fb2a311a 3756 bool range_right_open)
969bf05e 3757{
f4d7e40a 3758 struct bpf_func_state *state = vstate->frame[vstate->curframe];
58e2af8b 3759 struct bpf_reg_state *regs = state->regs, *reg;
fb2a311a 3760 u16 new_range;
f4d7e40a 3761 int i, j;
2d2be8ca 3762
fb2a311a
DB
3763 if (dst_reg->off < 0 ||
3764 (dst_reg->off == 0 && range_right_open))
f1174f77
EC
3765 /* This doesn't give us any range */
3766 return;
3767
b03c9f9f
EC
3768 if (dst_reg->umax_value > MAX_PACKET_OFF ||
3769 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
f1174f77
EC
3770 /* Risk of overflow. For instance, ptr + (1<<63) may be less
3771 * than pkt_end, but that's because it's also less than pkt.
3772 */
3773 return;
3774
fb2a311a
DB
3775 new_range = dst_reg->off;
3776 if (range_right_open)
3777 new_range--;
3778
3779 /* Examples for register markings:
2d2be8ca 3780 *
fb2a311a 3781 * pkt_data in dst register:
2d2be8ca
DB
3782 *
3783 * r2 = r3;
3784 * r2 += 8;
3785 * if (r2 > pkt_end) goto <handle exception>
3786 * <access okay>
3787 *
b4e432f1
DB
3788 * r2 = r3;
3789 * r2 += 8;
3790 * if (r2 < pkt_end) goto <access okay>
3791 * <handle exception>
3792 *
2d2be8ca
DB
3793 * Where:
3794 * r2 == dst_reg, pkt_end == src_reg
3795 * r2=pkt(id=n,off=8,r=0)
3796 * r3=pkt(id=n,off=0,r=0)
3797 *
fb2a311a 3798 * pkt_data in src register:
2d2be8ca
DB
3799 *
3800 * r2 = r3;
3801 * r2 += 8;
3802 * if (pkt_end >= r2) goto <access okay>
3803 * <handle exception>
3804 *
b4e432f1
DB
3805 * r2 = r3;
3806 * r2 += 8;
3807 * if (pkt_end <= r2) goto <handle exception>
3808 * <access okay>
3809 *
2d2be8ca
DB
3810 * Where:
3811 * pkt_end == dst_reg, r2 == src_reg
3812 * r2=pkt(id=n,off=8,r=0)
3813 * r3=pkt(id=n,off=0,r=0)
3814 *
3815 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
fb2a311a
DB
3816 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
3817 * and [r3, r3 + 8-1) respectively is safe to access depending on
3818 * the check.
969bf05e 3819 */
2d2be8ca 3820
f1174f77
EC
3821 /* If our ids match, then we must have the same max_value. And we
3822 * don't care about the other reg's fixed offset, since if it's too big
3823 * the range won't allow anything.
3824 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
3825 */
969bf05e 3826 for (i = 0; i < MAX_BPF_REG; i++)
de8f3a83 3827 if (regs[i].type == type && regs[i].id == dst_reg->id)
b1977682 3828 /* keep the maximum range already checked */
fb2a311a 3829 regs[i].range = max(regs[i].range, new_range);
969bf05e 3830
f4d7e40a
AS
3831 for (j = 0; j <= vstate->curframe; j++) {
3832 state = vstate->frame[j];
f3709f69
JS
3833 bpf_for_each_spilled_reg(i, state, reg) {
3834 if (!reg)
f4d7e40a 3835 continue;
f4d7e40a
AS
3836 if (reg->type == type && reg->id == dst_reg->id)
3837 reg->range = max(reg->range, new_range);
3838 }
969bf05e
AS
3839 }
3840}
3841
4f7b3e82
AS
3842/* compute branch direction of the expression "if (reg opcode val) goto target;"
3843 * and return:
3844 * 1 - branch will be taken and "goto target" will be executed
3845 * 0 - branch will not be taken and fall-through to next insn
3846 * -1 - unknown. Example: "if (reg < 5)" is unknown when register value range [0,10]
3847 */
3848static int is_branch_taken(struct bpf_reg_state *reg, u64 val, u8 opcode)
3849{
3850 if (__is_pointer_value(false, reg))
3851 return -1;
3852
3853 switch (opcode) {
3854 case BPF_JEQ:
3855 if (tnum_is_const(reg->var_off))
3856 return !!tnum_equals_const(reg->var_off, val);
3857 break;
3858 case BPF_JNE:
3859 if (tnum_is_const(reg->var_off))
3860 return !tnum_equals_const(reg->var_off, val);
3861 break;
3862 case BPF_JGT:
3863 if (reg->umin_value > val)
3864 return 1;
3865 else if (reg->umax_value <= val)
3866 return 0;
3867 break;
3868 case BPF_JSGT:
3869 if (reg->smin_value > (s64)val)
3870 return 1;
3871 else if (reg->smax_value < (s64)val)
3872 return 0;
3873 break;
3874 case BPF_JLT:
3875 if (reg->umax_value < val)
3876 return 1;
3877 else if (reg->umin_value >= val)
3878 return 0;
3879 break;
3880 case BPF_JSLT:
3881 if (reg->smax_value < (s64)val)
3882 return 1;
3883 else if (reg->smin_value >= (s64)val)
3884 return 0;
3885 break;
3886 case BPF_JGE:
3887 if (reg->umin_value >= val)
3888 return 1;
3889 else if (reg->umax_value < val)
3890 return 0;
3891 break;
3892 case BPF_JSGE:
3893 if (reg->smin_value >= (s64)val)
3894 return 1;
3895 else if (reg->smax_value < (s64)val)
3896 return 0;
3897 break;
3898 case BPF_JLE:
3899 if (reg->umax_value <= val)
3900 return 1;
3901 else if (reg->umin_value > val)
3902 return 0;
3903 break;
3904 case BPF_JSLE:
3905 if (reg->smax_value <= (s64)val)
3906 return 1;
3907 else if (reg->smin_value > (s64)val)
3908 return 0;
3909 break;
3910 }
3911
3912 return -1;
3913}
3914
48461135
JB
3915/* Adjusts the register min/max values in the case that the dst_reg is the
3916 * variable register that we are working on, and src_reg is a constant or we're
3917 * simply doing a BPF_K check.
f1174f77 3918 * In JEQ/JNE cases we also adjust the var_off values.
48461135
JB
3919 */
3920static void reg_set_min_max(struct bpf_reg_state *true_reg,
3921 struct bpf_reg_state *false_reg, u64 val,
3922 u8 opcode)
3923{
f1174f77
EC
3924 /* If the dst_reg is a pointer, we can't learn anything about its
3925 * variable offset from the compare (unless src_reg were a pointer into
3926 * the same object, but we don't bother with that.
3927 * Since false_reg and true_reg have the same type by construction, we
3928 * only need to check one of them for pointerness.
3929 */
3930 if (__is_pointer_value(false, false_reg))
3931 return;
4cabc5b1 3932
48461135
JB
3933 switch (opcode) {
3934 case BPF_JEQ:
3935 /* If this is false then we know nothing Jon Snow, but if it is
3936 * true then we know for sure.
3937 */
b03c9f9f 3938 __mark_reg_known(true_reg, val);
48461135
JB
3939 break;
3940 case BPF_JNE:
3941 /* If this is true we know nothing Jon Snow, but if it is false
3942 * we know the value for sure;
3943 */
b03c9f9f 3944 __mark_reg_known(false_reg, val);
48461135
JB
3945 break;
3946 case BPF_JGT:
b03c9f9f
EC
3947 false_reg->umax_value = min(false_reg->umax_value, val);
3948 true_reg->umin_value = max(true_reg->umin_value, val + 1);
3949 break;
48461135 3950 case BPF_JSGT:
b03c9f9f
EC
3951 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
3952 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
48461135 3953 break;
b4e432f1
DB
3954 case BPF_JLT:
3955 false_reg->umin_value = max(false_reg->umin_value, val);
3956 true_reg->umax_value = min(true_reg->umax_value, val - 1);
3957 break;
3958 case BPF_JSLT:
3959 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
3960 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
3961 break;
48461135 3962 case BPF_JGE:
b03c9f9f
EC
3963 false_reg->umax_value = min(false_reg->umax_value, val - 1);
3964 true_reg->umin_value = max(true_reg->umin_value, val);
3965 break;
48461135 3966 case BPF_JSGE:
b03c9f9f
EC
3967 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
3968 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
48461135 3969 break;
b4e432f1
DB
3970 case BPF_JLE:
3971 false_reg->umin_value = max(false_reg->umin_value, val + 1);
3972 true_reg->umax_value = min(true_reg->umax_value, val);
3973 break;
3974 case BPF_JSLE:
3975 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
3976 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
3977 break;
48461135
JB
3978 default:
3979 break;
3980 }
3981
b03c9f9f
EC
3982 __reg_deduce_bounds(false_reg);
3983 __reg_deduce_bounds(true_reg);
3984 /* We might have learned some bits from the bounds. */
3985 __reg_bound_offset(false_reg);
3986 __reg_bound_offset(true_reg);
3987 /* Intersecting with the old var_off might have improved our bounds
3988 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3989 * then new var_off is (0; 0x7f...fc) which improves our umax.
3990 */
3991 __update_reg_bounds(false_reg);
3992 __update_reg_bounds(true_reg);
48461135
JB
3993}
3994
f1174f77
EC
3995/* Same as above, but for the case that dst_reg holds a constant and src_reg is
3996 * the variable reg.
48461135
JB
3997 */
3998static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
3999 struct bpf_reg_state *false_reg, u64 val,
4000 u8 opcode)
4001{
f1174f77
EC
4002 if (__is_pointer_value(false, false_reg))
4003 return;
4cabc5b1 4004
48461135
JB
4005 switch (opcode) {
4006 case BPF_JEQ:
4007 /* If this is false then we know nothing Jon Snow, but if it is
4008 * true then we know for sure.
4009 */
b03c9f9f 4010 __mark_reg_known(true_reg, val);
48461135
JB
4011 break;
4012 case BPF_JNE:
4013 /* If this is true we know nothing Jon Snow, but if it is false
4014 * we know the value for sure;
4015 */
b03c9f9f 4016 __mark_reg_known(false_reg, val);
48461135
JB
4017 break;
4018 case BPF_JGT:
b03c9f9f
EC
4019 true_reg->umax_value = min(true_reg->umax_value, val - 1);
4020 false_reg->umin_value = max(false_reg->umin_value, val);
4021 break;
48461135 4022 case BPF_JSGT:
b03c9f9f
EC
4023 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
4024 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
48461135 4025 break;
b4e432f1
DB
4026 case BPF_JLT:
4027 true_reg->umin_value = max(true_reg->umin_value, val + 1);
4028 false_reg->umax_value = min(false_reg->umax_value, val);
4029 break;
4030 case BPF_JSLT:
4031 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
4032 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
4033 break;
48461135 4034 case BPF_JGE:
b03c9f9f
EC
4035 true_reg->umax_value = min(true_reg->umax_value, val);
4036 false_reg->umin_value = max(false_reg->umin_value, val + 1);
4037 break;
48461135 4038 case BPF_JSGE:
b03c9f9f
EC
4039 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
4040 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
48461135 4041 break;
b4e432f1
DB
4042 case BPF_JLE:
4043 true_reg->umin_value = max(true_reg->umin_value, val);
4044 false_reg->umax_value = min(false_reg->umax_value, val - 1);
4045 break;
4046 case BPF_JSLE:
4047 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
4048 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
4049 break;
48461135
JB
4050 default:
4051 break;
4052 }
4053
b03c9f9f
EC
4054 __reg_deduce_bounds(false_reg);
4055 __reg_deduce_bounds(true_reg);
4056 /* We might have learned some bits from the bounds. */
4057 __reg_bound_offset(false_reg);
4058 __reg_bound_offset(true_reg);
4059 /* Intersecting with the old var_off might have improved our bounds
4060 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
4061 * then new var_off is (0; 0x7f...fc) which improves our umax.
4062 */
4063 __update_reg_bounds(false_reg);
4064 __update_reg_bounds(true_reg);
f1174f77
EC
4065}
4066
4067/* Regs are known to be equal, so intersect their min/max/var_off */
4068static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
4069 struct bpf_reg_state *dst_reg)
4070{
b03c9f9f
EC
4071 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
4072 dst_reg->umin_value);
4073 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
4074 dst_reg->umax_value);
4075 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
4076 dst_reg->smin_value);
4077 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
4078 dst_reg->smax_value);
f1174f77
EC
4079 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
4080 dst_reg->var_off);
b03c9f9f
EC
4081 /* We might have learned new bounds from the var_off. */
4082 __update_reg_bounds(src_reg);
4083 __update_reg_bounds(dst_reg);
4084 /* We might have learned something about the sign bit. */
4085 __reg_deduce_bounds(src_reg);
4086 __reg_deduce_bounds(dst_reg);
4087 /* We might have learned some bits from the bounds. */
4088 __reg_bound_offset(src_reg);
4089 __reg_bound_offset(dst_reg);
4090 /* Intersecting with the old var_off might have improved our bounds
4091 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
4092 * then new var_off is (0; 0x7f...fc) which improves our umax.
4093 */
4094 __update_reg_bounds(src_reg);
4095 __update_reg_bounds(dst_reg);
f1174f77
EC
4096}
4097
4098static void reg_combine_min_max(struct bpf_reg_state *true_src,
4099 struct bpf_reg_state *true_dst,
4100 struct bpf_reg_state *false_src,
4101 struct bpf_reg_state *false_dst,
4102 u8 opcode)
4103{
4104 switch (opcode) {
4105 case BPF_JEQ:
4106 __reg_combine_min_max(true_src, true_dst);
4107 break;
4108 case BPF_JNE:
4109 __reg_combine_min_max(false_src, false_dst);
b03c9f9f 4110 break;
4cabc5b1 4111 }
48461135
JB
4112}
4113
fd978bf7
JS
4114static void mark_ptr_or_null_reg(struct bpf_func_state *state,
4115 struct bpf_reg_state *reg, u32 id,
840b9615 4116 bool is_null)
57a09bf0 4117{
840b9615 4118 if (reg_type_may_be_null(reg->type) && reg->id == id) {
f1174f77
EC
4119 /* Old offset (both fixed and variable parts) should
4120 * have been known-zero, because we don't allow pointer
4121 * arithmetic on pointers that might be NULL.
4122 */
b03c9f9f
EC
4123 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
4124 !tnum_equals_const(reg->var_off, 0) ||
f1174f77 4125 reg->off)) {
b03c9f9f
EC
4126 __mark_reg_known_zero(reg);
4127 reg->off = 0;
f1174f77
EC
4128 }
4129 if (is_null) {
4130 reg->type = SCALAR_VALUE;
840b9615
JS
4131 } else if (reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
4132 if (reg->map_ptr->inner_map_meta) {
4133 reg->type = CONST_PTR_TO_MAP;
4134 reg->map_ptr = reg->map_ptr->inner_map_meta;
4135 } else {
4136 reg->type = PTR_TO_MAP_VALUE;
4137 }
c64b7983
JS
4138 } else if (reg->type == PTR_TO_SOCKET_OR_NULL) {
4139 reg->type = PTR_TO_SOCKET;
56f668df 4140 }
fd978bf7
JS
4141 if (is_null || !reg_is_refcounted(reg)) {
4142 /* We don't need id from this point onwards anymore,
4143 * thus we should better reset it, so that state
4144 * pruning has chances to take effect.
4145 */
4146 reg->id = 0;
56f668df 4147 }
57a09bf0
TG
4148 }
4149}
4150
4151/* The logic is similar to find_good_pkt_pointers(), both could eventually
4152 * be folded together at some point.
4153 */
840b9615
JS
4154static void mark_ptr_or_null_regs(struct bpf_verifier_state *vstate, u32 regno,
4155 bool is_null)
57a09bf0 4156{
f4d7e40a 4157 struct bpf_func_state *state = vstate->frame[vstate->curframe];
f3709f69 4158 struct bpf_reg_state *reg, *regs = state->regs;
a08dd0da 4159 u32 id = regs[regno].id;
f4d7e40a 4160 int i, j;
57a09bf0 4161
fd978bf7
JS
4162 if (reg_is_refcounted_or_null(&regs[regno]) && is_null)
4163 __release_reference_state(state, id);
4164
57a09bf0 4165 for (i = 0; i < MAX_BPF_REG; i++)
fd978bf7 4166 mark_ptr_or_null_reg(state, &regs[i], id, is_null);
57a09bf0 4167
f4d7e40a
AS
4168 for (j = 0; j <= vstate->curframe; j++) {
4169 state = vstate->frame[j];
f3709f69
JS
4170 bpf_for_each_spilled_reg(i, state, reg) {
4171 if (!reg)
f4d7e40a 4172 continue;
fd978bf7 4173 mark_ptr_or_null_reg(state, reg, id, is_null);
f4d7e40a 4174 }
57a09bf0
TG
4175 }
4176}
4177
5beca081
DB
4178static bool try_match_pkt_pointers(const struct bpf_insn *insn,
4179 struct bpf_reg_state *dst_reg,
4180 struct bpf_reg_state *src_reg,
4181 struct bpf_verifier_state *this_branch,
4182 struct bpf_verifier_state *other_branch)
4183{
4184 if (BPF_SRC(insn->code) != BPF_X)
4185 return false;
4186
4187 switch (BPF_OP(insn->code)) {
4188 case BPF_JGT:
4189 if ((dst_reg->type == PTR_TO_PACKET &&
4190 src_reg->type == PTR_TO_PACKET_END) ||
4191 (dst_reg->type == PTR_TO_PACKET_META &&
4192 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
4193 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
4194 find_good_pkt_pointers(this_branch, dst_reg,
4195 dst_reg->type, false);
4196 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
4197 src_reg->type == PTR_TO_PACKET) ||
4198 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
4199 src_reg->type == PTR_TO_PACKET_META)) {
4200 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
4201 find_good_pkt_pointers(other_branch, src_reg,
4202 src_reg->type, true);
4203 } else {
4204 return false;
4205 }
4206 break;
4207 case BPF_JLT:
4208 if ((dst_reg->type == PTR_TO_PACKET &&
4209 src_reg->type == PTR_TO_PACKET_END) ||
4210 (dst_reg->type == PTR_TO_PACKET_META &&
4211 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
4212 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
4213 find_good_pkt_pointers(other_branch, dst_reg,
4214 dst_reg->type, true);
4215 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
4216 src_reg->type == PTR_TO_PACKET) ||
4217 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
4218 src_reg->type == PTR_TO_PACKET_META)) {
4219 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
4220 find_good_pkt_pointers(this_branch, src_reg,
4221 src_reg->type, false);
4222 } else {
4223 return false;
4224 }
4225 break;
4226 case BPF_JGE:
4227 if ((dst_reg->type == PTR_TO_PACKET &&
4228 src_reg->type == PTR_TO_PACKET_END) ||
4229 (dst_reg->type == PTR_TO_PACKET_META &&
4230 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
4231 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
4232 find_good_pkt_pointers(this_branch, dst_reg,
4233 dst_reg->type, true);
4234 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
4235 src_reg->type == PTR_TO_PACKET) ||
4236 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
4237 src_reg->type == PTR_TO_PACKET_META)) {
4238 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
4239 find_good_pkt_pointers(other_branch, src_reg,
4240 src_reg->type, false);
4241 } else {
4242 return false;
4243 }
4244 break;
4245 case BPF_JLE:
4246 if ((dst_reg->type == PTR_TO_PACKET &&
4247 src_reg->type == PTR_TO_PACKET_END) ||
4248 (dst_reg->type == PTR_TO_PACKET_META &&
4249 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
4250 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
4251 find_good_pkt_pointers(other_branch, dst_reg,
4252 dst_reg->type, false);
4253 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
4254 src_reg->type == PTR_TO_PACKET) ||
4255 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
4256 src_reg->type == PTR_TO_PACKET_META)) {
4257 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
4258 find_good_pkt_pointers(this_branch, src_reg,
4259 src_reg->type, true);
4260 } else {
4261 return false;
4262 }
4263 break;
4264 default:
4265 return false;
4266 }
4267
4268 return true;
4269}
4270
58e2af8b 4271static int check_cond_jmp_op(struct bpf_verifier_env *env,
17a52670
AS
4272 struct bpf_insn *insn, int *insn_idx)
4273{
f4d7e40a
AS
4274 struct bpf_verifier_state *this_branch = env->cur_state;
4275 struct bpf_verifier_state *other_branch;
4276 struct bpf_reg_state *regs = this_branch->frame[this_branch->curframe]->regs;
4277 struct bpf_reg_state *dst_reg, *other_branch_regs;
17a52670
AS
4278 u8 opcode = BPF_OP(insn->code);
4279 int err;
4280
b4e432f1 4281 if (opcode > BPF_JSLE) {
61bd5218 4282 verbose(env, "invalid BPF_JMP opcode %x\n", opcode);
17a52670
AS
4283 return -EINVAL;
4284 }
4285
4286 if (BPF_SRC(insn->code) == BPF_X) {
4287 if (insn->imm != 0) {
61bd5218 4288 verbose(env, "BPF_JMP uses reserved fields\n");
17a52670
AS
4289 return -EINVAL;
4290 }
4291
4292 /* check src1 operand */
dc503a8a 4293 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
4294 if (err)
4295 return err;
1be7f75d
AS
4296
4297 if (is_pointer_value(env, insn->src_reg)) {
61bd5218 4298 verbose(env, "R%d pointer comparison prohibited\n",
1be7f75d
AS
4299 insn->src_reg);
4300 return -EACCES;
4301 }
17a52670
AS
4302 } else {
4303 if (insn->src_reg != BPF_REG_0) {
61bd5218 4304 verbose(env, "BPF_JMP uses reserved fields\n");
17a52670
AS
4305 return -EINVAL;
4306 }
4307 }
4308
4309 /* check src2 operand */
dc503a8a 4310 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
4311 if (err)
4312 return err;
4313
1a0dc1ac
AS
4314 dst_reg = &regs[insn->dst_reg];
4315
4f7b3e82
AS
4316 if (BPF_SRC(insn->code) == BPF_K) {
4317 int pred = is_branch_taken(dst_reg, insn->imm, opcode);
4318
4319 if (pred == 1) {
4320 /* only follow the goto, ignore fall-through */
17a52670
AS
4321 *insn_idx += insn->off;
4322 return 0;
4f7b3e82
AS
4323 } else if (pred == 0) {
4324 /* only follow fall-through branch, since
17a52670
AS
4325 * that's where the program will go
4326 */
4327 return 0;
4328 }
4329 }
4330
4331 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
4332 if (!other_branch)
4333 return -EFAULT;
f4d7e40a 4334 other_branch_regs = other_branch->frame[other_branch->curframe]->regs;
17a52670 4335
48461135
JB
4336 /* detect if we are comparing against a constant value so we can adjust
4337 * our min/max values for our dst register.
f1174f77
EC
4338 * this is only legit if both are scalars (or pointers to the same
4339 * object, I suppose, but we don't support that right now), because
4340 * otherwise the different base pointers mean the offsets aren't
4341 * comparable.
48461135
JB
4342 */
4343 if (BPF_SRC(insn->code) == BPF_X) {
f1174f77
EC
4344 if (dst_reg->type == SCALAR_VALUE &&
4345 regs[insn->src_reg].type == SCALAR_VALUE) {
4346 if (tnum_is_const(regs[insn->src_reg].var_off))
f4d7e40a 4347 reg_set_min_max(&other_branch_regs[insn->dst_reg],
f1174f77
EC
4348 dst_reg, regs[insn->src_reg].var_off.value,
4349 opcode);
4350 else if (tnum_is_const(dst_reg->var_off))
f4d7e40a 4351 reg_set_min_max_inv(&other_branch_regs[insn->src_reg],
f1174f77
EC
4352 &regs[insn->src_reg],
4353 dst_reg->var_off.value, opcode);
4354 else if (opcode == BPF_JEQ || opcode == BPF_JNE)
4355 /* Comparing for equality, we can combine knowledge */
f4d7e40a
AS
4356 reg_combine_min_max(&other_branch_regs[insn->src_reg],
4357 &other_branch_regs[insn->dst_reg],
f1174f77
EC
4358 &regs[insn->src_reg],
4359 &regs[insn->dst_reg], opcode);
4360 }
4361 } else if (dst_reg->type == SCALAR_VALUE) {
f4d7e40a 4362 reg_set_min_max(&other_branch_regs[insn->dst_reg],
48461135
JB
4363 dst_reg, insn->imm, opcode);
4364 }
4365
58e2af8b 4366 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
17a52670 4367 if (BPF_SRC(insn->code) == BPF_K &&
1a0dc1ac 4368 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
840b9615
JS
4369 reg_type_may_be_null(dst_reg->type)) {
4370 /* Mark all identical registers in each branch as either
57a09bf0
TG
4371 * safe or unknown depending R == 0 or R != 0 conditional.
4372 */
840b9615
JS
4373 mark_ptr_or_null_regs(this_branch, insn->dst_reg,
4374 opcode == BPF_JNE);
4375 mark_ptr_or_null_regs(other_branch, insn->dst_reg,
4376 opcode == BPF_JEQ);
5beca081
DB
4377 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
4378 this_branch, other_branch) &&
4379 is_pointer_value(env, insn->dst_reg)) {
61bd5218
JK
4380 verbose(env, "R%d pointer comparison prohibited\n",
4381 insn->dst_reg);
1be7f75d 4382 return -EACCES;
17a52670 4383 }
61bd5218 4384 if (env->log.level)
f4d7e40a 4385 print_verifier_state(env, this_branch->frame[this_branch->curframe]);
17a52670
AS
4386 return 0;
4387}
4388
0246e64d
AS
4389/* return the map pointer stored inside BPF_LD_IMM64 instruction */
4390static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
4391{
4392 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
4393
4394 return (struct bpf_map *) (unsigned long) imm64;
4395}
4396
17a52670 4397/* verify BPF_LD_IMM64 instruction */
58e2af8b 4398static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 4399{
638f5b90 4400 struct bpf_reg_state *regs = cur_regs(env);
17a52670
AS
4401 int err;
4402
4403 if (BPF_SIZE(insn->code) != BPF_DW) {
61bd5218 4404 verbose(env, "invalid BPF_LD_IMM insn\n");
17a52670
AS
4405 return -EINVAL;
4406 }
4407 if (insn->off != 0) {
61bd5218 4408 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
17a52670
AS
4409 return -EINVAL;
4410 }
4411
dc503a8a 4412 err = check_reg_arg(env, insn->dst_reg, DST_OP);
17a52670
AS
4413 if (err)
4414 return err;
4415
6b173873 4416 if (insn->src_reg == 0) {
6b173873
JK
4417 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
4418
f1174f77 4419 regs[insn->dst_reg].type = SCALAR_VALUE;
b03c9f9f 4420 __mark_reg_known(&regs[insn->dst_reg], imm);
17a52670 4421 return 0;
6b173873 4422 }
17a52670
AS
4423
4424 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
4425 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
4426
4427 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
4428 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
4429 return 0;
4430}
4431
96be4325
DB
4432static bool may_access_skb(enum bpf_prog_type type)
4433{
4434 switch (type) {
4435 case BPF_PROG_TYPE_SOCKET_FILTER:
4436 case BPF_PROG_TYPE_SCHED_CLS:
94caee8c 4437 case BPF_PROG_TYPE_SCHED_ACT:
96be4325
DB
4438 return true;
4439 default:
4440 return false;
4441 }
4442}
4443
ddd872bc
AS
4444/* verify safety of LD_ABS|LD_IND instructions:
4445 * - they can only appear in the programs where ctx == skb
4446 * - since they are wrappers of function calls, they scratch R1-R5 registers,
4447 * preserve R6-R9, and store return value into R0
4448 *
4449 * Implicit input:
4450 * ctx == skb == R6 == CTX
4451 *
4452 * Explicit input:
4453 * SRC == any register
4454 * IMM == 32-bit immediate
4455 *
4456 * Output:
4457 * R0 - 8/16/32-bit skb data converted to cpu endianness
4458 */
58e2af8b 4459static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
ddd872bc 4460{
638f5b90 4461 struct bpf_reg_state *regs = cur_regs(env);
ddd872bc 4462 u8 mode = BPF_MODE(insn->code);
ddd872bc
AS
4463 int i, err;
4464
24701ece 4465 if (!may_access_skb(env->prog->type)) {
61bd5218 4466 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
ddd872bc
AS
4467 return -EINVAL;
4468 }
4469
e0cea7ce
DB
4470 if (!env->ops->gen_ld_abs) {
4471 verbose(env, "bpf verifier is misconfigured\n");
4472 return -EINVAL;
4473 }
4474
f910cefa 4475 if (env->subprog_cnt > 1) {
f4d7e40a
AS
4476 /* when program has LD_ABS insn JITs and interpreter assume
4477 * that r1 == ctx == skb which is not the case for callees
4478 * that can have arbitrary arguments. It's problematic
4479 * for main prog as well since JITs would need to analyze
4480 * all functions in order to make proper register save/restore
4481 * decisions in the main prog. Hence disallow LD_ABS with calls
4482 */
4483 verbose(env, "BPF_LD_[ABS|IND] instructions cannot be mixed with bpf-to-bpf calls\n");
4484 return -EINVAL;
4485 }
4486
ddd872bc 4487 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
d82bccc6 4488 BPF_SIZE(insn->code) == BPF_DW ||
ddd872bc 4489 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
61bd5218 4490 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
ddd872bc
AS
4491 return -EINVAL;
4492 }
4493
4494 /* check whether implicit source operand (register R6) is readable */
dc503a8a 4495 err = check_reg_arg(env, BPF_REG_6, SRC_OP);
ddd872bc
AS
4496 if (err)
4497 return err;
4498
fd978bf7
JS
4499 /* Disallow usage of BPF_LD_[ABS|IND] with reference tracking, as
4500 * gen_ld_abs() may terminate the program at runtime, leading to
4501 * reference leak.
4502 */
4503 err = check_reference_leak(env);
4504 if (err) {
4505 verbose(env, "BPF_LD_[ABS|IND] cannot be mixed with socket references\n");
4506 return err;
4507 }
4508
ddd872bc 4509 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
61bd5218
JK
4510 verbose(env,
4511 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
ddd872bc
AS
4512 return -EINVAL;
4513 }
4514
4515 if (mode == BPF_IND) {
4516 /* check explicit source operand */
dc503a8a 4517 err = check_reg_arg(env, insn->src_reg, SRC_OP);
ddd872bc
AS
4518 if (err)
4519 return err;
4520 }
4521
4522 /* reset caller saved regs to unreadable */
dc503a8a 4523 for (i = 0; i < CALLER_SAVED_REGS; i++) {
61bd5218 4524 mark_reg_not_init(env, regs, caller_saved[i]);
dc503a8a
EC
4525 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
4526 }
ddd872bc
AS
4527
4528 /* mark destination R0 register as readable, since it contains
dc503a8a
EC
4529 * the value fetched from the packet.
4530 * Already marked as written above.
ddd872bc 4531 */
61bd5218 4532 mark_reg_unknown(env, regs, BPF_REG_0);
ddd872bc
AS
4533 return 0;
4534}
4535
390ee7e2
AS
4536static int check_return_code(struct bpf_verifier_env *env)
4537{
4538 struct bpf_reg_state *reg;
4539 struct tnum range = tnum_range(0, 1);
4540
4541 switch (env->prog->type) {
4542 case BPF_PROG_TYPE_CGROUP_SKB:
4543 case BPF_PROG_TYPE_CGROUP_SOCK:
4fbac77d 4544 case BPF_PROG_TYPE_CGROUP_SOCK_ADDR:
390ee7e2 4545 case BPF_PROG_TYPE_SOCK_OPS:
ebc614f6 4546 case BPF_PROG_TYPE_CGROUP_DEVICE:
390ee7e2
AS
4547 break;
4548 default:
4549 return 0;
4550 }
4551
638f5b90 4552 reg = cur_regs(env) + BPF_REG_0;
390ee7e2 4553 if (reg->type != SCALAR_VALUE) {
61bd5218 4554 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
390ee7e2
AS
4555 reg_type_str[reg->type]);
4556 return -EINVAL;
4557 }
4558
4559 if (!tnum_in(range, reg->var_off)) {
61bd5218 4560 verbose(env, "At program exit the register R0 ");
390ee7e2
AS
4561 if (!tnum_is_unknown(reg->var_off)) {
4562 char tn_buf[48];
4563
4564 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 4565 verbose(env, "has value %s", tn_buf);
390ee7e2 4566 } else {
61bd5218 4567 verbose(env, "has unknown scalar value");
390ee7e2 4568 }
61bd5218 4569 verbose(env, " should have been 0 or 1\n");
390ee7e2
AS
4570 return -EINVAL;
4571 }
4572 return 0;
4573}
4574
475fb78f
AS
4575/* non-recursive DFS pseudo code
4576 * 1 procedure DFS-iterative(G,v):
4577 * 2 label v as discovered
4578 * 3 let S be a stack
4579 * 4 S.push(v)
4580 * 5 while S is not empty
4581 * 6 t <- S.pop()
4582 * 7 if t is what we're looking for:
4583 * 8 return t
4584 * 9 for all edges e in G.adjacentEdges(t) do
4585 * 10 if edge e is already labelled
4586 * 11 continue with the next edge
4587 * 12 w <- G.adjacentVertex(t,e)
4588 * 13 if vertex w is not discovered and not explored
4589 * 14 label e as tree-edge
4590 * 15 label w as discovered
4591 * 16 S.push(w)
4592 * 17 continue at 5
4593 * 18 else if vertex w is discovered
4594 * 19 label e as back-edge
4595 * 20 else
4596 * 21 // vertex w is explored
4597 * 22 label e as forward- or cross-edge
4598 * 23 label t as explored
4599 * 24 S.pop()
4600 *
4601 * convention:
4602 * 0x10 - discovered
4603 * 0x11 - discovered and fall-through edge labelled
4604 * 0x12 - discovered and fall-through and branch edges labelled
4605 * 0x20 - explored
4606 */
4607
4608enum {
4609 DISCOVERED = 0x10,
4610 EXPLORED = 0x20,
4611 FALLTHROUGH = 1,
4612 BRANCH = 2,
4613};
4614
58e2af8b 4615#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
f1bca824 4616
475fb78f
AS
4617static int *insn_stack; /* stack of insns to process */
4618static int cur_stack; /* current stack index */
4619static int *insn_state;
4620
4621/* t, w, e - match pseudo-code above:
4622 * t - index of current instruction
4623 * w - next instruction
4624 * e - edge
4625 */
58e2af8b 4626static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
475fb78f
AS
4627{
4628 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
4629 return 0;
4630
4631 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
4632 return 0;
4633
4634 if (w < 0 || w >= env->prog->len) {
d9762e84 4635 verbose_linfo(env, t, "%d: ", t);
61bd5218 4636 verbose(env, "jump out of range from insn %d to %d\n", t, w);
475fb78f
AS
4637 return -EINVAL;
4638 }
4639
f1bca824
AS
4640 if (e == BRANCH)
4641 /* mark branch target for state pruning */
4642 env->explored_states[w] = STATE_LIST_MARK;
4643
475fb78f
AS
4644 if (insn_state[w] == 0) {
4645 /* tree-edge */
4646 insn_state[t] = DISCOVERED | e;
4647 insn_state[w] = DISCOVERED;
4648 if (cur_stack >= env->prog->len)
4649 return -E2BIG;
4650 insn_stack[cur_stack++] = w;
4651 return 1;
4652 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
d9762e84
MKL
4653 verbose_linfo(env, t, "%d: ", t);
4654 verbose_linfo(env, w, "%d: ", w);
61bd5218 4655 verbose(env, "back-edge from insn %d to %d\n", t, w);
475fb78f
AS
4656 return -EINVAL;
4657 } else if (insn_state[w] == EXPLORED) {
4658 /* forward- or cross-edge */
4659 insn_state[t] = DISCOVERED | e;
4660 } else {
61bd5218 4661 verbose(env, "insn state internal bug\n");
475fb78f
AS
4662 return -EFAULT;
4663 }
4664 return 0;
4665}
4666
4667/* non-recursive depth-first-search to detect loops in BPF program
4668 * loop == back-edge in directed graph
4669 */
58e2af8b 4670static int check_cfg(struct bpf_verifier_env *env)
475fb78f
AS
4671{
4672 struct bpf_insn *insns = env->prog->insnsi;
4673 int insn_cnt = env->prog->len;
4674 int ret = 0;
4675 int i, t;
4676
4677 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
4678 if (!insn_state)
4679 return -ENOMEM;
4680
4681 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
4682 if (!insn_stack) {
4683 kfree(insn_state);
4684 return -ENOMEM;
4685 }
4686
4687 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
4688 insn_stack[0] = 0; /* 0 is the first instruction */
4689 cur_stack = 1;
4690
4691peek_stack:
4692 if (cur_stack == 0)
4693 goto check_state;
4694 t = insn_stack[cur_stack - 1];
4695
4696 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
4697 u8 opcode = BPF_OP(insns[t].code);
4698
4699 if (opcode == BPF_EXIT) {
4700 goto mark_explored;
4701 } else if (opcode == BPF_CALL) {
4702 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4703 if (ret == 1)
4704 goto peek_stack;
4705 else if (ret < 0)
4706 goto err_free;
07016151
DB
4707 if (t + 1 < insn_cnt)
4708 env->explored_states[t + 1] = STATE_LIST_MARK;
cc8b0b92
AS
4709 if (insns[t].src_reg == BPF_PSEUDO_CALL) {
4710 env->explored_states[t] = STATE_LIST_MARK;
4711 ret = push_insn(t, t + insns[t].imm + 1, BRANCH, env);
4712 if (ret == 1)
4713 goto peek_stack;
4714 else if (ret < 0)
4715 goto err_free;
4716 }
475fb78f
AS
4717 } else if (opcode == BPF_JA) {
4718 if (BPF_SRC(insns[t].code) != BPF_K) {
4719 ret = -EINVAL;
4720 goto err_free;
4721 }
4722 /* unconditional jump with single edge */
4723 ret = push_insn(t, t + insns[t].off + 1,
4724 FALLTHROUGH, env);
4725 if (ret == 1)
4726 goto peek_stack;
4727 else if (ret < 0)
4728 goto err_free;
f1bca824
AS
4729 /* tell verifier to check for equivalent states
4730 * after every call and jump
4731 */
c3de6317
AS
4732 if (t + 1 < insn_cnt)
4733 env->explored_states[t + 1] = STATE_LIST_MARK;
475fb78f
AS
4734 } else {
4735 /* conditional jump with two edges */
3c2ce60b 4736 env->explored_states[t] = STATE_LIST_MARK;
475fb78f
AS
4737 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4738 if (ret == 1)
4739 goto peek_stack;
4740 else if (ret < 0)
4741 goto err_free;
4742
4743 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
4744 if (ret == 1)
4745 goto peek_stack;
4746 else if (ret < 0)
4747 goto err_free;
4748 }
4749 } else {
4750 /* all other non-branch instructions with single
4751 * fall-through edge
4752 */
4753 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4754 if (ret == 1)
4755 goto peek_stack;
4756 else if (ret < 0)
4757 goto err_free;
4758 }
4759
4760mark_explored:
4761 insn_state[t] = EXPLORED;
4762 if (cur_stack-- <= 0) {
61bd5218 4763 verbose(env, "pop stack internal bug\n");
475fb78f
AS
4764 ret = -EFAULT;
4765 goto err_free;
4766 }
4767 goto peek_stack;
4768
4769check_state:
4770 for (i = 0; i < insn_cnt; i++) {
4771 if (insn_state[i] != EXPLORED) {
61bd5218 4772 verbose(env, "unreachable insn %d\n", i);
475fb78f
AS
4773 ret = -EINVAL;
4774 goto err_free;
4775 }
4776 }
4777 ret = 0; /* cfg looks good */
4778
4779err_free:
4780 kfree(insn_state);
4781 kfree(insn_stack);
4782 return ret;
4783}
4784
838e9690
YS
4785/* The minimum supported BTF func info size */
4786#define MIN_BPF_FUNCINFO_SIZE 8
4787#define MAX_FUNCINFO_REC_SIZE 252
4788
c454a46b
MKL
4789static int check_btf_func(struct bpf_verifier_env *env,
4790 const union bpf_attr *attr,
4791 union bpf_attr __user *uattr)
838e9690
YS
4792{
4793 u32 i, nfuncs, urec_size, min_size, prev_offset;
4794 u32 krec_size = sizeof(struct bpf_func_info);
c454a46b 4795 struct bpf_func_info *krecord;
838e9690 4796 const struct btf_type *type;
c454a46b
MKL
4797 struct bpf_prog *prog;
4798 const struct btf *btf;
838e9690 4799 void __user *urecord;
838e9690
YS
4800 int ret = 0;
4801
4802 nfuncs = attr->func_info_cnt;
4803 if (!nfuncs)
4804 return 0;
4805
4806 if (nfuncs != env->subprog_cnt) {
4807 verbose(env, "number of funcs in func_info doesn't match number of subprogs\n");
4808 return -EINVAL;
4809 }
4810
4811 urec_size = attr->func_info_rec_size;
4812 if (urec_size < MIN_BPF_FUNCINFO_SIZE ||
4813 urec_size > MAX_FUNCINFO_REC_SIZE ||
4814 urec_size % sizeof(u32)) {
4815 verbose(env, "invalid func info rec size %u\n", urec_size);
4816 return -EINVAL;
4817 }
4818
c454a46b
MKL
4819 prog = env->prog;
4820 btf = prog->aux->btf;
838e9690
YS
4821
4822 urecord = u64_to_user_ptr(attr->func_info);
4823 min_size = min_t(u32, krec_size, urec_size);
4824
ba64e7d8 4825 krecord = kvcalloc(nfuncs, krec_size, GFP_KERNEL | __GFP_NOWARN);
c454a46b
MKL
4826 if (!krecord)
4827 return -ENOMEM;
ba64e7d8 4828
838e9690
YS
4829 for (i = 0; i < nfuncs; i++) {
4830 ret = bpf_check_uarg_tail_zero(urecord, krec_size, urec_size);
4831 if (ret) {
4832 if (ret == -E2BIG) {
4833 verbose(env, "nonzero tailing record in func info");
4834 /* set the size kernel expects so loader can zero
4835 * out the rest of the record.
4836 */
4837 if (put_user(min_size, &uattr->func_info_rec_size))
4838 ret = -EFAULT;
4839 }
c454a46b 4840 goto err_free;
838e9690
YS
4841 }
4842
ba64e7d8 4843 if (copy_from_user(&krecord[i], urecord, min_size)) {
838e9690 4844 ret = -EFAULT;
c454a46b 4845 goto err_free;
838e9690
YS
4846 }
4847
d30d42e0 4848 /* check insn_off */
838e9690 4849 if (i == 0) {
d30d42e0 4850 if (krecord[i].insn_off) {
838e9690 4851 verbose(env,
d30d42e0
MKL
4852 "nonzero insn_off %u for the first func info record",
4853 krecord[i].insn_off);
838e9690 4854 ret = -EINVAL;
c454a46b 4855 goto err_free;
838e9690 4856 }
d30d42e0 4857 } else if (krecord[i].insn_off <= prev_offset) {
838e9690
YS
4858 verbose(env,
4859 "same or smaller insn offset (%u) than previous func info record (%u)",
d30d42e0 4860 krecord[i].insn_off, prev_offset);
838e9690 4861 ret = -EINVAL;
c454a46b 4862 goto err_free;
838e9690
YS
4863 }
4864
d30d42e0 4865 if (env->subprog_info[i].start != krecord[i].insn_off) {
838e9690
YS
4866 verbose(env, "func_info BTF section doesn't match subprog layout in BPF program\n");
4867 ret = -EINVAL;
c454a46b 4868 goto err_free;
838e9690
YS
4869 }
4870
4871 /* check type_id */
ba64e7d8 4872 type = btf_type_by_id(btf, krecord[i].type_id);
838e9690
YS
4873 if (!type || BTF_INFO_KIND(type->info) != BTF_KIND_FUNC) {
4874 verbose(env, "invalid type id %d in func info",
ba64e7d8 4875 krecord[i].type_id);
838e9690 4876 ret = -EINVAL;
c454a46b 4877 goto err_free;
838e9690
YS
4878 }
4879
d30d42e0 4880 prev_offset = krecord[i].insn_off;
838e9690
YS
4881 urecord += urec_size;
4882 }
4883
ba64e7d8
YS
4884 prog->aux->func_info = krecord;
4885 prog->aux->func_info_cnt = nfuncs;
838e9690
YS
4886 return 0;
4887
c454a46b 4888err_free:
ba64e7d8 4889 kvfree(krecord);
838e9690
YS
4890 return ret;
4891}
4892
ba64e7d8
YS
4893static void adjust_btf_func(struct bpf_verifier_env *env)
4894{
4895 int i;
4896
4897 if (!env->prog->aux->func_info)
4898 return;
4899
4900 for (i = 0; i < env->subprog_cnt; i++)
d30d42e0 4901 env->prog->aux->func_info[i].insn_off = env->subprog_info[i].start;
ba64e7d8
YS
4902}
4903
c454a46b
MKL
4904#define MIN_BPF_LINEINFO_SIZE (offsetof(struct bpf_line_info, line_col) + \
4905 sizeof(((struct bpf_line_info *)(0))->line_col))
4906#define MAX_LINEINFO_REC_SIZE MAX_FUNCINFO_REC_SIZE
4907
4908static int check_btf_line(struct bpf_verifier_env *env,
4909 const union bpf_attr *attr,
4910 union bpf_attr __user *uattr)
4911{
4912 u32 i, s, nr_linfo, ncopy, expected_size, rec_size, prev_offset = 0;
4913 struct bpf_subprog_info *sub;
4914 struct bpf_line_info *linfo;
4915 struct bpf_prog *prog;
4916 const struct btf *btf;
4917 void __user *ulinfo;
4918 int err;
4919
4920 nr_linfo = attr->line_info_cnt;
4921 if (!nr_linfo)
4922 return 0;
4923
4924 rec_size = attr->line_info_rec_size;
4925 if (rec_size < MIN_BPF_LINEINFO_SIZE ||
4926 rec_size > MAX_LINEINFO_REC_SIZE ||
4927 rec_size & (sizeof(u32) - 1))
4928 return -EINVAL;
4929
4930 /* Need to zero it in case the userspace may
4931 * pass in a smaller bpf_line_info object.
4932 */
4933 linfo = kvcalloc(nr_linfo, sizeof(struct bpf_line_info),
4934 GFP_KERNEL | __GFP_NOWARN);
4935 if (!linfo)
4936 return -ENOMEM;
4937
4938 prog = env->prog;
4939 btf = prog->aux->btf;
4940
4941 s = 0;
4942 sub = env->subprog_info;
4943 ulinfo = u64_to_user_ptr(attr->line_info);
4944 expected_size = sizeof(struct bpf_line_info);
4945 ncopy = min_t(u32, expected_size, rec_size);
4946 for (i = 0; i < nr_linfo; i++) {
4947 err = bpf_check_uarg_tail_zero(ulinfo, expected_size, rec_size);
4948 if (err) {
4949 if (err == -E2BIG) {
4950 verbose(env, "nonzero tailing record in line_info");
4951 if (put_user(expected_size,
4952 &uattr->line_info_rec_size))
4953 err = -EFAULT;
4954 }
4955 goto err_free;
4956 }
4957
4958 if (copy_from_user(&linfo[i], ulinfo, ncopy)) {
4959 err = -EFAULT;
4960 goto err_free;
4961 }
4962
4963 /*
4964 * Check insn_off to ensure
4965 * 1) strictly increasing AND
4966 * 2) bounded by prog->len
4967 *
4968 * The linfo[0].insn_off == 0 check logically falls into
4969 * the later "missing bpf_line_info for func..." case
4970 * because the first linfo[0].insn_off must be the
4971 * first sub also and the first sub must have
4972 * subprog_info[0].start == 0.
4973 */
4974 if ((i && linfo[i].insn_off <= prev_offset) ||
4975 linfo[i].insn_off >= prog->len) {
4976 verbose(env, "Invalid line_info[%u].insn_off:%u (prev_offset:%u prog->len:%u)\n",
4977 i, linfo[i].insn_off, prev_offset,
4978 prog->len);
4979 err = -EINVAL;
4980 goto err_free;
4981 }
4982
fdbaa0be
MKL
4983 if (!prog->insnsi[linfo[i].insn_off].code) {
4984 verbose(env,
4985 "Invalid insn code at line_info[%u].insn_off\n",
4986 i);
4987 err = -EINVAL;
4988 goto err_free;
4989 }
4990
23127b33
MKL
4991 if (!btf_name_by_offset(btf, linfo[i].line_off) ||
4992 !btf_name_by_offset(btf, linfo[i].file_name_off)) {
c454a46b
MKL
4993 verbose(env, "Invalid line_info[%u].line_off or .file_name_off\n", i);
4994 err = -EINVAL;
4995 goto err_free;
4996 }
4997
4998 if (s != env->subprog_cnt) {
4999 if (linfo[i].insn_off == sub[s].start) {
5000 sub[s].linfo_idx = i;
5001 s++;
5002 } else if (sub[s].start < linfo[i].insn_off) {
5003 verbose(env, "missing bpf_line_info for func#%u\n", s);
5004 err = -EINVAL;
5005 goto err_free;
5006 }
5007 }
5008
5009 prev_offset = linfo[i].insn_off;
5010 ulinfo += rec_size;
5011 }
5012
5013 if (s != env->subprog_cnt) {
5014 verbose(env, "missing bpf_line_info for %u funcs starting from func#%u\n",
5015 env->subprog_cnt - s, s);
5016 err = -EINVAL;
5017 goto err_free;
5018 }
5019
5020 prog->aux->linfo = linfo;
5021 prog->aux->nr_linfo = nr_linfo;
5022
5023 return 0;
5024
5025err_free:
5026 kvfree(linfo);
5027 return err;
5028}
5029
5030static int check_btf_info(struct bpf_verifier_env *env,
5031 const union bpf_attr *attr,
5032 union bpf_attr __user *uattr)
5033{
5034 struct btf *btf;
5035 int err;
5036
5037 if (!attr->func_info_cnt && !attr->line_info_cnt)
5038 return 0;
5039
5040 btf = btf_get_by_fd(attr->prog_btf_fd);
5041 if (IS_ERR(btf))
5042 return PTR_ERR(btf);
5043 env->prog->aux->btf = btf;
5044
5045 err = check_btf_func(env, attr, uattr);
5046 if (err)
5047 return err;
5048
5049 err = check_btf_line(env, attr, uattr);
5050 if (err)
5051 return err;
5052
5053 return 0;
ba64e7d8
YS
5054}
5055
f1174f77
EC
5056/* check %cur's range satisfies %old's */
5057static bool range_within(struct bpf_reg_state *old,
5058 struct bpf_reg_state *cur)
5059{
b03c9f9f
EC
5060 return old->umin_value <= cur->umin_value &&
5061 old->umax_value >= cur->umax_value &&
5062 old->smin_value <= cur->smin_value &&
5063 old->smax_value >= cur->smax_value;
f1174f77
EC
5064}
5065
5066/* Maximum number of register states that can exist at once */
5067#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
5068struct idpair {
5069 u32 old;
5070 u32 cur;
5071};
5072
5073/* If in the old state two registers had the same id, then they need to have
5074 * the same id in the new state as well. But that id could be different from
5075 * the old state, so we need to track the mapping from old to new ids.
5076 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
5077 * regs with old id 5 must also have new id 9 for the new state to be safe. But
5078 * regs with a different old id could still have new id 9, we don't care about
5079 * that.
5080 * So we look through our idmap to see if this old id has been seen before. If
5081 * so, we require the new id to match; otherwise, we add the id pair to the map.
969bf05e 5082 */
f1174f77 5083static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
969bf05e 5084{
f1174f77 5085 unsigned int i;
969bf05e 5086
f1174f77
EC
5087 for (i = 0; i < ID_MAP_SIZE; i++) {
5088 if (!idmap[i].old) {
5089 /* Reached an empty slot; haven't seen this id before */
5090 idmap[i].old = old_id;
5091 idmap[i].cur = cur_id;
5092 return true;
5093 }
5094 if (idmap[i].old == old_id)
5095 return idmap[i].cur == cur_id;
5096 }
5097 /* We ran out of idmap slots, which should be impossible */
5098 WARN_ON_ONCE(1);
5099 return false;
5100}
5101
9242b5f5
AS
5102static void clean_func_state(struct bpf_verifier_env *env,
5103 struct bpf_func_state *st)
5104{
5105 enum bpf_reg_liveness live;
5106 int i, j;
5107
5108 for (i = 0; i < BPF_REG_FP; i++) {
5109 live = st->regs[i].live;
5110 /* liveness must not touch this register anymore */
5111 st->regs[i].live |= REG_LIVE_DONE;
5112 if (!(live & REG_LIVE_READ))
5113 /* since the register is unused, clear its state
5114 * to make further comparison simpler
5115 */
5116 __mark_reg_not_init(&st->regs[i]);
5117 }
5118
5119 for (i = 0; i < st->allocated_stack / BPF_REG_SIZE; i++) {
5120 live = st->stack[i].spilled_ptr.live;
5121 /* liveness must not touch this stack slot anymore */
5122 st->stack[i].spilled_ptr.live |= REG_LIVE_DONE;
5123 if (!(live & REG_LIVE_READ)) {
5124 __mark_reg_not_init(&st->stack[i].spilled_ptr);
5125 for (j = 0; j < BPF_REG_SIZE; j++)
5126 st->stack[i].slot_type[j] = STACK_INVALID;
5127 }
5128 }
5129}
5130
5131static void clean_verifier_state(struct bpf_verifier_env *env,
5132 struct bpf_verifier_state *st)
5133{
5134 int i;
5135
5136 if (st->frame[0]->regs[0].live & REG_LIVE_DONE)
5137 /* all regs in this state in all frames were already marked */
5138 return;
5139
5140 for (i = 0; i <= st->curframe; i++)
5141 clean_func_state(env, st->frame[i]);
5142}
5143
5144/* the parentage chains form a tree.
5145 * the verifier states are added to state lists at given insn and
5146 * pushed into state stack for future exploration.
5147 * when the verifier reaches bpf_exit insn some of the verifer states
5148 * stored in the state lists have their final liveness state already,
5149 * but a lot of states will get revised from liveness point of view when
5150 * the verifier explores other branches.
5151 * Example:
5152 * 1: r0 = 1
5153 * 2: if r1 == 100 goto pc+1
5154 * 3: r0 = 2
5155 * 4: exit
5156 * when the verifier reaches exit insn the register r0 in the state list of
5157 * insn 2 will be seen as !REG_LIVE_READ. Then the verifier pops the other_branch
5158 * of insn 2 and goes exploring further. At the insn 4 it will walk the
5159 * parentage chain from insn 4 into insn 2 and will mark r0 as REG_LIVE_READ.
5160 *
5161 * Since the verifier pushes the branch states as it sees them while exploring
5162 * the program the condition of walking the branch instruction for the second
5163 * time means that all states below this branch were already explored and
5164 * their final liveness markes are already propagated.
5165 * Hence when the verifier completes the search of state list in is_state_visited()
5166 * we can call this clean_live_states() function to mark all liveness states
5167 * as REG_LIVE_DONE to indicate that 'parent' pointers of 'struct bpf_reg_state'
5168 * will not be used.
5169 * This function also clears the registers and stack for states that !READ
5170 * to simplify state merging.
5171 *
5172 * Important note here that walking the same branch instruction in the callee
5173 * doesn't meant that the states are DONE. The verifier has to compare
5174 * the callsites
5175 */
5176static void clean_live_states(struct bpf_verifier_env *env, int insn,
5177 struct bpf_verifier_state *cur)
5178{
5179 struct bpf_verifier_state_list *sl;
5180 int i;
5181
5182 sl = env->explored_states[insn];
5183 if (!sl)
5184 return;
5185
5186 while (sl != STATE_LIST_MARK) {
5187 if (sl->state.curframe != cur->curframe)
5188 goto next;
5189 for (i = 0; i <= cur->curframe; i++)
5190 if (sl->state.frame[i]->callsite != cur->frame[i]->callsite)
5191 goto next;
5192 clean_verifier_state(env, &sl->state);
5193next:
5194 sl = sl->next;
5195 }
5196}
5197
f1174f77 5198/* Returns true if (rold safe implies rcur safe) */
1b688a19
EC
5199static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
5200 struct idpair *idmap)
f1174f77 5201{
f4d7e40a
AS
5202 bool equal;
5203
dc503a8a
EC
5204 if (!(rold->live & REG_LIVE_READ))
5205 /* explored state didn't use this */
5206 return true;
5207
679c782d 5208 equal = memcmp(rold, rcur, offsetof(struct bpf_reg_state, parent)) == 0;
f4d7e40a
AS
5209
5210 if (rold->type == PTR_TO_STACK)
5211 /* two stack pointers are equal only if they're pointing to
5212 * the same stack frame, since fp-8 in foo != fp-8 in bar
5213 */
5214 return equal && rold->frameno == rcur->frameno;
5215
5216 if (equal)
969bf05e
AS
5217 return true;
5218
f1174f77
EC
5219 if (rold->type == NOT_INIT)
5220 /* explored state can't have used this */
969bf05e 5221 return true;
f1174f77
EC
5222 if (rcur->type == NOT_INIT)
5223 return false;
5224 switch (rold->type) {
5225 case SCALAR_VALUE:
5226 if (rcur->type == SCALAR_VALUE) {
5227 /* new val must satisfy old val knowledge */
5228 return range_within(rold, rcur) &&
5229 tnum_in(rold->var_off, rcur->var_off);
5230 } else {
179d1c56
JH
5231 /* We're trying to use a pointer in place of a scalar.
5232 * Even if the scalar was unbounded, this could lead to
5233 * pointer leaks because scalars are allowed to leak
5234 * while pointers are not. We could make this safe in
5235 * special cases if root is calling us, but it's
5236 * probably not worth the hassle.
f1174f77 5237 */
179d1c56 5238 return false;
f1174f77
EC
5239 }
5240 case PTR_TO_MAP_VALUE:
1b688a19
EC
5241 /* If the new min/max/var_off satisfy the old ones and
5242 * everything else matches, we are OK.
5243 * We don't care about the 'id' value, because nothing
5244 * uses it for PTR_TO_MAP_VALUE (only for ..._OR_NULL)
5245 */
5246 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
5247 range_within(rold, rcur) &&
5248 tnum_in(rold->var_off, rcur->var_off);
f1174f77
EC
5249 case PTR_TO_MAP_VALUE_OR_NULL:
5250 /* a PTR_TO_MAP_VALUE could be safe to use as a
5251 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
5252 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
5253 * checked, doing so could have affected others with the same
5254 * id, and we can't check for that because we lost the id when
5255 * we converted to a PTR_TO_MAP_VALUE.
5256 */
5257 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
5258 return false;
5259 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
5260 return false;
5261 /* Check our ids match any regs they're supposed to */
5262 return check_ids(rold->id, rcur->id, idmap);
de8f3a83 5263 case PTR_TO_PACKET_META:
f1174f77 5264 case PTR_TO_PACKET:
de8f3a83 5265 if (rcur->type != rold->type)
f1174f77
EC
5266 return false;
5267 /* We must have at least as much range as the old ptr
5268 * did, so that any accesses which were safe before are
5269 * still safe. This is true even if old range < old off,
5270 * since someone could have accessed through (ptr - k), or
5271 * even done ptr -= k in a register, to get a safe access.
5272 */
5273 if (rold->range > rcur->range)
5274 return false;
5275 /* If the offsets don't match, we can't trust our alignment;
5276 * nor can we be sure that we won't fall out of range.
5277 */
5278 if (rold->off != rcur->off)
5279 return false;
5280 /* id relations must be preserved */
5281 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
5282 return false;
5283 /* new val must satisfy old val knowledge */
5284 return range_within(rold, rcur) &&
5285 tnum_in(rold->var_off, rcur->var_off);
5286 case PTR_TO_CTX:
5287 case CONST_PTR_TO_MAP:
f1174f77 5288 case PTR_TO_PACKET_END:
d58e468b 5289 case PTR_TO_FLOW_KEYS:
c64b7983
JS
5290 case PTR_TO_SOCKET:
5291 case PTR_TO_SOCKET_OR_NULL:
f1174f77
EC
5292 /* Only valid matches are exact, which memcmp() above
5293 * would have accepted
5294 */
5295 default:
5296 /* Don't know what's going on, just say it's not safe */
5297 return false;
5298 }
969bf05e 5299
f1174f77
EC
5300 /* Shouldn't get here; if we do, say it's not safe */
5301 WARN_ON_ONCE(1);
969bf05e
AS
5302 return false;
5303}
5304
f4d7e40a
AS
5305static bool stacksafe(struct bpf_func_state *old,
5306 struct bpf_func_state *cur,
638f5b90
AS
5307 struct idpair *idmap)
5308{
5309 int i, spi;
5310
638f5b90
AS
5311 /* walk slots of the explored stack and ignore any additional
5312 * slots in the current stack, since explored(safe) state
5313 * didn't use them
5314 */
5315 for (i = 0; i < old->allocated_stack; i++) {
5316 spi = i / BPF_REG_SIZE;
5317
b233920c
AS
5318 if (!(old->stack[spi].spilled_ptr.live & REG_LIVE_READ)) {
5319 i += BPF_REG_SIZE - 1;
cc2b14d5 5320 /* explored state didn't use this */
fd05e57b 5321 continue;
b233920c 5322 }
cc2b14d5 5323
638f5b90
AS
5324 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
5325 continue;
19e2dbb7
AS
5326
5327 /* explored stack has more populated slots than current stack
5328 * and these slots were used
5329 */
5330 if (i >= cur->allocated_stack)
5331 return false;
5332
cc2b14d5
AS
5333 /* if old state was safe with misc data in the stack
5334 * it will be safe with zero-initialized stack.
5335 * The opposite is not true
5336 */
5337 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_MISC &&
5338 cur->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_ZERO)
5339 continue;
638f5b90
AS
5340 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
5341 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
5342 /* Ex: old explored (safe) state has STACK_SPILL in
5343 * this stack slot, but current has has STACK_MISC ->
5344 * this verifier states are not equivalent,
5345 * return false to continue verification of this path
5346 */
5347 return false;
5348 if (i % BPF_REG_SIZE)
5349 continue;
5350 if (old->stack[spi].slot_type[0] != STACK_SPILL)
5351 continue;
5352 if (!regsafe(&old->stack[spi].spilled_ptr,
5353 &cur->stack[spi].spilled_ptr,
5354 idmap))
5355 /* when explored and current stack slot are both storing
5356 * spilled registers, check that stored pointers types
5357 * are the same as well.
5358 * Ex: explored safe path could have stored
5359 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
5360 * but current path has stored:
5361 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
5362 * such verifier states are not equivalent.
5363 * return false to continue verification of this path
5364 */
5365 return false;
5366 }
5367 return true;
5368}
5369
fd978bf7
JS
5370static bool refsafe(struct bpf_func_state *old, struct bpf_func_state *cur)
5371{
5372 if (old->acquired_refs != cur->acquired_refs)
5373 return false;
5374 return !memcmp(old->refs, cur->refs,
5375 sizeof(*old->refs) * old->acquired_refs);
5376}
5377
f1bca824
AS
5378/* compare two verifier states
5379 *
5380 * all states stored in state_list are known to be valid, since
5381 * verifier reached 'bpf_exit' instruction through them
5382 *
5383 * this function is called when verifier exploring different branches of
5384 * execution popped from the state stack. If it sees an old state that has
5385 * more strict register state and more strict stack state then this execution
5386 * branch doesn't need to be explored further, since verifier already
5387 * concluded that more strict state leads to valid finish.
5388 *
5389 * Therefore two states are equivalent if register state is more conservative
5390 * and explored stack state is more conservative than the current one.
5391 * Example:
5392 * explored current
5393 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
5394 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
5395 *
5396 * In other words if current stack state (one being explored) has more
5397 * valid slots than old one that already passed validation, it means
5398 * the verifier can stop exploring and conclude that current state is valid too
5399 *
5400 * Similarly with registers. If explored state has register type as invalid
5401 * whereas register type in current state is meaningful, it means that
5402 * the current state will reach 'bpf_exit' instruction safely
5403 */
f4d7e40a
AS
5404static bool func_states_equal(struct bpf_func_state *old,
5405 struct bpf_func_state *cur)
f1bca824 5406{
f1174f77
EC
5407 struct idpair *idmap;
5408 bool ret = false;
f1bca824
AS
5409 int i;
5410
f1174f77
EC
5411 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
5412 /* If we failed to allocate the idmap, just say it's not safe */
5413 if (!idmap)
1a0dc1ac 5414 return false;
f1174f77
EC
5415
5416 for (i = 0; i < MAX_BPF_REG; i++) {
1b688a19 5417 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
f1174f77 5418 goto out_free;
f1bca824
AS
5419 }
5420
638f5b90
AS
5421 if (!stacksafe(old, cur, idmap))
5422 goto out_free;
fd978bf7
JS
5423
5424 if (!refsafe(old, cur))
5425 goto out_free;
f1174f77
EC
5426 ret = true;
5427out_free:
5428 kfree(idmap);
5429 return ret;
f1bca824
AS
5430}
5431
f4d7e40a
AS
5432static bool states_equal(struct bpf_verifier_env *env,
5433 struct bpf_verifier_state *old,
5434 struct bpf_verifier_state *cur)
5435{
5436 int i;
5437
5438 if (old->curframe != cur->curframe)
5439 return false;
5440
5441 /* for states to be equal callsites have to be the same
5442 * and all frame states need to be equivalent
5443 */
5444 for (i = 0; i <= old->curframe; i++) {
5445 if (old->frame[i]->callsite != cur->frame[i]->callsite)
5446 return false;
5447 if (!func_states_equal(old->frame[i], cur->frame[i]))
5448 return false;
5449 }
5450 return true;
5451}
5452
8e9cd9ce 5453/* A write screens off any subsequent reads; but write marks come from the
f4d7e40a
AS
5454 * straight-line code between a state and its parent. When we arrive at an
5455 * equivalent state (jump target or such) we didn't arrive by the straight-line
5456 * code, so read marks in the state must propagate to the parent regardless
5457 * of the state's write marks. That's what 'parent == state->parent' comparison
679c782d 5458 * in mark_reg_read() is for.
8e9cd9ce 5459 */
f4d7e40a
AS
5460static int propagate_liveness(struct bpf_verifier_env *env,
5461 const struct bpf_verifier_state *vstate,
5462 struct bpf_verifier_state *vparent)
dc503a8a 5463{
f4d7e40a
AS
5464 int i, frame, err = 0;
5465 struct bpf_func_state *state, *parent;
dc503a8a 5466
f4d7e40a
AS
5467 if (vparent->curframe != vstate->curframe) {
5468 WARN(1, "propagate_live: parent frame %d current frame %d\n",
5469 vparent->curframe, vstate->curframe);
5470 return -EFAULT;
5471 }
dc503a8a
EC
5472 /* Propagate read liveness of registers... */
5473 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
5474 /* We don't need to worry about FP liveness because it's read-only */
5475 for (i = 0; i < BPF_REG_FP; i++) {
f4d7e40a 5476 if (vparent->frame[vparent->curframe]->regs[i].live & REG_LIVE_READ)
63f45f84 5477 continue;
f4d7e40a 5478 if (vstate->frame[vstate->curframe]->regs[i].live & REG_LIVE_READ) {
679c782d
EC
5479 err = mark_reg_read(env, &vstate->frame[vstate->curframe]->regs[i],
5480 &vparent->frame[vstate->curframe]->regs[i]);
f4d7e40a
AS
5481 if (err)
5482 return err;
dc503a8a
EC
5483 }
5484 }
f4d7e40a 5485
dc503a8a 5486 /* ... and stack slots */
f4d7e40a
AS
5487 for (frame = 0; frame <= vstate->curframe; frame++) {
5488 state = vstate->frame[frame];
5489 parent = vparent->frame[frame];
5490 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
5491 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
f4d7e40a
AS
5492 if (parent->stack[i].spilled_ptr.live & REG_LIVE_READ)
5493 continue;
5494 if (state->stack[i].spilled_ptr.live & REG_LIVE_READ)
679c782d
EC
5495 mark_reg_read(env, &state->stack[i].spilled_ptr,
5496 &parent->stack[i].spilled_ptr);
dc503a8a
EC
5497 }
5498 }
f4d7e40a 5499 return err;
dc503a8a
EC
5500}
5501
58e2af8b 5502static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
f1bca824 5503{
58e2af8b
JK
5504 struct bpf_verifier_state_list *new_sl;
5505 struct bpf_verifier_state_list *sl;
679c782d 5506 struct bpf_verifier_state *cur = env->cur_state, *new;
ceefbc96 5507 int i, j, err, states_cnt = 0;
f1bca824
AS
5508
5509 sl = env->explored_states[insn_idx];
5510 if (!sl)
5511 /* this 'insn_idx' instruction wasn't marked, so we will not
5512 * be doing state search here
5513 */
5514 return 0;
5515
9242b5f5
AS
5516 clean_live_states(env, insn_idx, cur);
5517
f1bca824 5518 while (sl != STATE_LIST_MARK) {
638f5b90 5519 if (states_equal(env, &sl->state, cur)) {
f1bca824 5520 /* reached equivalent register/stack state,
dc503a8a
EC
5521 * prune the search.
5522 * Registers read by the continuation are read by us.
8e9cd9ce
EC
5523 * If we have any write marks in env->cur_state, they
5524 * will prevent corresponding reads in the continuation
5525 * from reaching our parent (an explored_state). Our
5526 * own state will get the read marks recorded, but
5527 * they'll be immediately forgotten as we're pruning
5528 * this state and will pop a new one.
f1bca824 5529 */
f4d7e40a
AS
5530 err = propagate_liveness(env, &sl->state, cur);
5531 if (err)
5532 return err;
f1bca824 5533 return 1;
dc503a8a 5534 }
f1bca824 5535 sl = sl->next;
ceefbc96 5536 states_cnt++;
f1bca824
AS
5537 }
5538
ceefbc96
AS
5539 if (!env->allow_ptr_leaks && states_cnt > BPF_COMPLEXITY_LIMIT_STATES)
5540 return 0;
5541
f1bca824
AS
5542 /* there were no equivalent states, remember current one.
5543 * technically the current state is not proven to be safe yet,
f4d7e40a
AS
5544 * but it will either reach outer most bpf_exit (which means it's safe)
5545 * or it will be rejected. Since there are no loops, we won't be
5546 * seeing this tuple (frame[0].callsite, frame[1].callsite, .. insn_idx)
5547 * again on the way to bpf_exit
f1bca824 5548 */
638f5b90 5549 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
f1bca824
AS
5550 if (!new_sl)
5551 return -ENOMEM;
5552
5553 /* add new state to the head of linked list */
679c782d
EC
5554 new = &new_sl->state;
5555 err = copy_verifier_state(new, cur);
1969db47 5556 if (err) {
679c782d 5557 free_verifier_state(new, false);
1969db47
AS
5558 kfree(new_sl);
5559 return err;
5560 }
f1bca824
AS
5561 new_sl->next = env->explored_states[insn_idx];
5562 env->explored_states[insn_idx] = new_sl;
dc503a8a 5563 /* connect new state to parentage chain */
679c782d
EC
5564 for (i = 0; i < BPF_REG_FP; i++)
5565 cur_regs(env)[i].parent = &new->frame[new->curframe]->regs[i];
8e9cd9ce
EC
5566 /* clear write marks in current state: the writes we did are not writes
5567 * our child did, so they don't screen off its reads from us.
5568 * (There are no read marks in current state, because reads always mark
5569 * their parent and current state never has children yet. Only
5570 * explored_states can get read marks.)
5571 */
dc503a8a 5572 for (i = 0; i < BPF_REG_FP; i++)
f4d7e40a
AS
5573 cur->frame[cur->curframe]->regs[i].live = REG_LIVE_NONE;
5574
5575 /* all stack frames are accessible from callee, clear them all */
5576 for (j = 0; j <= cur->curframe; j++) {
5577 struct bpf_func_state *frame = cur->frame[j];
679c782d 5578 struct bpf_func_state *newframe = new->frame[j];
f4d7e40a 5579
679c782d 5580 for (i = 0; i < frame->allocated_stack / BPF_REG_SIZE; i++) {
cc2b14d5 5581 frame->stack[i].spilled_ptr.live = REG_LIVE_NONE;
679c782d
EC
5582 frame->stack[i].spilled_ptr.parent =
5583 &newframe->stack[i].spilled_ptr;
5584 }
f4d7e40a 5585 }
f1bca824
AS
5586 return 0;
5587}
5588
c64b7983
JS
5589/* Return true if it's OK to have the same insn return a different type. */
5590static bool reg_type_mismatch_ok(enum bpf_reg_type type)
5591{
5592 switch (type) {
5593 case PTR_TO_CTX:
5594 case PTR_TO_SOCKET:
5595 case PTR_TO_SOCKET_OR_NULL:
5596 return false;
5597 default:
5598 return true;
5599 }
5600}
5601
5602/* If an instruction was previously used with particular pointer types, then we
5603 * need to be careful to avoid cases such as the below, where it may be ok
5604 * for one branch accessing the pointer, but not ok for the other branch:
5605 *
5606 * R1 = sock_ptr
5607 * goto X;
5608 * ...
5609 * R1 = some_other_valid_ptr;
5610 * goto X;
5611 * ...
5612 * R2 = *(u32 *)(R1 + 0);
5613 */
5614static bool reg_type_mismatch(enum bpf_reg_type src, enum bpf_reg_type prev)
5615{
5616 return src != prev && (!reg_type_mismatch_ok(src) ||
5617 !reg_type_mismatch_ok(prev));
5618}
5619
58e2af8b 5620static int do_check(struct bpf_verifier_env *env)
17a52670 5621{
638f5b90 5622 struct bpf_verifier_state *state;
17a52670 5623 struct bpf_insn *insns = env->prog->insnsi;
638f5b90 5624 struct bpf_reg_state *regs;
f4d7e40a 5625 int insn_cnt = env->prog->len, i;
17a52670
AS
5626 int insn_idx, prev_insn_idx = 0;
5627 int insn_processed = 0;
5628 bool do_print_state = false;
5629
d9762e84
MKL
5630 env->prev_linfo = NULL;
5631
638f5b90
AS
5632 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
5633 if (!state)
5634 return -ENOMEM;
f4d7e40a 5635 state->curframe = 0;
f4d7e40a
AS
5636 state->frame[0] = kzalloc(sizeof(struct bpf_func_state), GFP_KERNEL);
5637 if (!state->frame[0]) {
5638 kfree(state);
5639 return -ENOMEM;
5640 }
5641 env->cur_state = state;
5642 init_func_state(env, state->frame[0],
5643 BPF_MAIN_FUNC /* callsite */,
5644 0 /* frameno */,
5645 0 /* subprogno, zero == main subprog */);
17a52670
AS
5646 insn_idx = 0;
5647 for (;;) {
5648 struct bpf_insn *insn;
5649 u8 class;
5650 int err;
5651
5652 if (insn_idx >= insn_cnt) {
61bd5218 5653 verbose(env, "invalid insn idx %d insn_cnt %d\n",
17a52670
AS
5654 insn_idx, insn_cnt);
5655 return -EFAULT;
5656 }
5657
5658 insn = &insns[insn_idx];
5659 class = BPF_CLASS(insn->code);
5660
07016151 5661 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
61bd5218
JK
5662 verbose(env,
5663 "BPF program is too large. Processed %d insn\n",
17a52670
AS
5664 insn_processed);
5665 return -E2BIG;
5666 }
5667
f1bca824
AS
5668 err = is_state_visited(env, insn_idx);
5669 if (err < 0)
5670 return err;
5671 if (err == 1) {
5672 /* found equivalent state, can prune the search */
61bd5218 5673 if (env->log.level) {
f1bca824 5674 if (do_print_state)
61bd5218 5675 verbose(env, "\nfrom %d to %d: safe\n",
f1bca824
AS
5676 prev_insn_idx, insn_idx);
5677 else
61bd5218 5678 verbose(env, "%d: safe\n", insn_idx);
f1bca824
AS
5679 }
5680 goto process_bpf_exit;
5681 }
5682
c3494801
AS
5683 if (signal_pending(current))
5684 return -EAGAIN;
5685
3c2ce60b
DB
5686 if (need_resched())
5687 cond_resched();
5688
61bd5218
JK
5689 if (env->log.level > 1 || (env->log.level && do_print_state)) {
5690 if (env->log.level > 1)
5691 verbose(env, "%d:", insn_idx);
c5fc9692 5692 else
61bd5218 5693 verbose(env, "\nfrom %d to %d:",
c5fc9692 5694 prev_insn_idx, insn_idx);
f4d7e40a 5695 print_verifier_state(env, state->frame[state->curframe]);
17a52670
AS
5696 do_print_state = false;
5697 }
5698
61bd5218 5699 if (env->log.level) {
7105e828
DB
5700 const struct bpf_insn_cbs cbs = {
5701 .cb_print = verbose,
abe08840 5702 .private_data = env,
7105e828
DB
5703 };
5704
d9762e84 5705 verbose_linfo(env, insn_idx, "; ");
61bd5218 5706 verbose(env, "%d: ", insn_idx);
abe08840 5707 print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
17a52670
AS
5708 }
5709
cae1927c
JK
5710 if (bpf_prog_is_dev_bound(env->prog->aux)) {
5711 err = bpf_prog_offload_verify_insn(env, insn_idx,
5712 prev_insn_idx);
5713 if (err)
5714 return err;
5715 }
13a27dfc 5716
638f5b90 5717 regs = cur_regs(env);
c131187d 5718 env->insn_aux_data[insn_idx].seen = true;
fd978bf7 5719
17a52670 5720 if (class == BPF_ALU || class == BPF_ALU64) {
1be7f75d 5721 err = check_alu_op(env, insn);
17a52670
AS
5722 if (err)
5723 return err;
5724
5725 } else if (class == BPF_LDX) {
3df126f3 5726 enum bpf_reg_type *prev_src_type, src_reg_type;
9bac3d6d
AS
5727
5728 /* check for reserved fields is already done */
5729
17a52670 5730 /* check src operand */
dc503a8a 5731 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
5732 if (err)
5733 return err;
5734
dc503a8a 5735 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
17a52670
AS
5736 if (err)
5737 return err;
5738
725f9dcd
AS
5739 src_reg_type = regs[insn->src_reg].type;
5740
17a52670
AS
5741 /* check that memory (src_reg + off) is readable,
5742 * the state of dst_reg will be updated by this func
5743 */
31fd8581 5744 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
17a52670 5745 BPF_SIZE(insn->code), BPF_READ,
ca369602 5746 insn->dst_reg, false);
17a52670
AS
5747 if (err)
5748 return err;
5749
3df126f3
JK
5750 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
5751
5752 if (*prev_src_type == NOT_INIT) {
9bac3d6d
AS
5753 /* saw a valid insn
5754 * dst_reg = *(u32 *)(src_reg + off)
3df126f3 5755 * save type to validate intersecting paths
9bac3d6d 5756 */
3df126f3 5757 *prev_src_type = src_reg_type;
9bac3d6d 5758
c64b7983 5759 } else if (reg_type_mismatch(src_reg_type, *prev_src_type)) {
9bac3d6d
AS
5760 /* ABuser program is trying to use the same insn
5761 * dst_reg = *(u32*) (src_reg + off)
5762 * with different pointer types:
5763 * src_reg == ctx in one branch and
5764 * src_reg == stack|map in some other branch.
5765 * Reject it.
5766 */
61bd5218 5767 verbose(env, "same insn cannot be used with different pointers\n");
9bac3d6d
AS
5768 return -EINVAL;
5769 }
5770
17a52670 5771 } else if (class == BPF_STX) {
3df126f3 5772 enum bpf_reg_type *prev_dst_type, dst_reg_type;
d691f9e8 5773
17a52670 5774 if (BPF_MODE(insn->code) == BPF_XADD) {
31fd8581 5775 err = check_xadd(env, insn_idx, insn);
17a52670
AS
5776 if (err)
5777 return err;
5778 insn_idx++;
5779 continue;
5780 }
5781
17a52670 5782 /* check src1 operand */
dc503a8a 5783 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
5784 if (err)
5785 return err;
5786 /* check src2 operand */
dc503a8a 5787 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
5788 if (err)
5789 return err;
5790
d691f9e8
AS
5791 dst_reg_type = regs[insn->dst_reg].type;
5792
17a52670 5793 /* check that memory (dst_reg + off) is writeable */
31fd8581 5794 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
17a52670 5795 BPF_SIZE(insn->code), BPF_WRITE,
ca369602 5796 insn->src_reg, false);
17a52670
AS
5797 if (err)
5798 return err;
5799
3df126f3
JK
5800 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
5801
5802 if (*prev_dst_type == NOT_INIT) {
5803 *prev_dst_type = dst_reg_type;
c64b7983 5804 } else if (reg_type_mismatch(dst_reg_type, *prev_dst_type)) {
61bd5218 5805 verbose(env, "same insn cannot be used with different pointers\n");
d691f9e8
AS
5806 return -EINVAL;
5807 }
5808
17a52670
AS
5809 } else if (class == BPF_ST) {
5810 if (BPF_MODE(insn->code) != BPF_MEM ||
5811 insn->src_reg != BPF_REG_0) {
61bd5218 5812 verbose(env, "BPF_ST uses reserved fields\n");
17a52670
AS
5813 return -EINVAL;
5814 }
5815 /* check src operand */
dc503a8a 5816 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
5817 if (err)
5818 return err;
5819
f37a8cb8 5820 if (is_ctx_reg(env, insn->dst_reg)) {
9d2be44a 5821 verbose(env, "BPF_ST stores into R%d %s is not allowed\n",
2a159c6f
DB
5822 insn->dst_reg,
5823 reg_type_str[reg_state(env, insn->dst_reg)->type]);
f37a8cb8
DB
5824 return -EACCES;
5825 }
5826
17a52670 5827 /* check that memory (dst_reg + off) is writeable */
31fd8581 5828 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
17a52670 5829 BPF_SIZE(insn->code), BPF_WRITE,
ca369602 5830 -1, false);
17a52670
AS
5831 if (err)
5832 return err;
5833
5834 } else if (class == BPF_JMP) {
5835 u8 opcode = BPF_OP(insn->code);
5836
5837 if (opcode == BPF_CALL) {
5838 if (BPF_SRC(insn->code) != BPF_K ||
5839 insn->off != 0 ||
f4d7e40a
AS
5840 (insn->src_reg != BPF_REG_0 &&
5841 insn->src_reg != BPF_PSEUDO_CALL) ||
17a52670 5842 insn->dst_reg != BPF_REG_0) {
61bd5218 5843 verbose(env, "BPF_CALL uses reserved fields\n");
17a52670
AS
5844 return -EINVAL;
5845 }
5846
f4d7e40a
AS
5847 if (insn->src_reg == BPF_PSEUDO_CALL)
5848 err = check_func_call(env, insn, &insn_idx);
5849 else
5850 err = check_helper_call(env, insn->imm, insn_idx);
17a52670
AS
5851 if (err)
5852 return err;
5853
5854 } else if (opcode == BPF_JA) {
5855 if (BPF_SRC(insn->code) != BPF_K ||
5856 insn->imm != 0 ||
5857 insn->src_reg != BPF_REG_0 ||
5858 insn->dst_reg != BPF_REG_0) {
61bd5218 5859 verbose(env, "BPF_JA uses reserved fields\n");
17a52670
AS
5860 return -EINVAL;
5861 }
5862
5863 insn_idx += insn->off + 1;
5864 continue;
5865
5866 } else if (opcode == BPF_EXIT) {
5867 if (BPF_SRC(insn->code) != BPF_K ||
5868 insn->imm != 0 ||
5869 insn->src_reg != BPF_REG_0 ||
5870 insn->dst_reg != BPF_REG_0) {
61bd5218 5871 verbose(env, "BPF_EXIT uses reserved fields\n");
17a52670
AS
5872 return -EINVAL;
5873 }
5874
f4d7e40a
AS
5875 if (state->curframe) {
5876 /* exit from nested function */
5877 prev_insn_idx = insn_idx;
5878 err = prepare_func_exit(env, &insn_idx);
5879 if (err)
5880 return err;
5881 do_print_state = true;
5882 continue;
5883 }
5884
fd978bf7
JS
5885 err = check_reference_leak(env);
5886 if (err)
5887 return err;
5888
17a52670
AS
5889 /* eBPF calling convetion is such that R0 is used
5890 * to return the value from eBPF program.
5891 * Make sure that it's readable at this time
5892 * of bpf_exit, which means that program wrote
5893 * something into it earlier
5894 */
dc503a8a 5895 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
17a52670
AS
5896 if (err)
5897 return err;
5898
1be7f75d 5899 if (is_pointer_value(env, BPF_REG_0)) {
61bd5218 5900 verbose(env, "R0 leaks addr as return value\n");
1be7f75d
AS
5901 return -EACCES;
5902 }
5903
390ee7e2
AS
5904 err = check_return_code(env);
5905 if (err)
5906 return err;
f1bca824 5907process_bpf_exit:
638f5b90
AS
5908 err = pop_stack(env, &prev_insn_idx, &insn_idx);
5909 if (err < 0) {
5910 if (err != -ENOENT)
5911 return err;
17a52670
AS
5912 break;
5913 } else {
5914 do_print_state = true;
5915 continue;
5916 }
5917 } else {
5918 err = check_cond_jmp_op(env, insn, &insn_idx);
5919 if (err)
5920 return err;
5921 }
5922 } else if (class == BPF_LD) {
5923 u8 mode = BPF_MODE(insn->code);
5924
5925 if (mode == BPF_ABS || mode == BPF_IND) {
ddd872bc
AS
5926 err = check_ld_abs(env, insn);
5927 if (err)
5928 return err;
5929
17a52670
AS
5930 } else if (mode == BPF_IMM) {
5931 err = check_ld_imm(env, insn);
5932 if (err)
5933 return err;
5934
5935 insn_idx++;
c131187d 5936 env->insn_aux_data[insn_idx].seen = true;
17a52670 5937 } else {
61bd5218 5938 verbose(env, "invalid BPF_LD mode\n");
17a52670
AS
5939 return -EINVAL;
5940 }
5941 } else {
61bd5218 5942 verbose(env, "unknown insn class %d\n", class);
17a52670
AS
5943 return -EINVAL;
5944 }
5945
5946 insn_idx++;
5947 }
5948
4bd95f4b
DB
5949 verbose(env, "processed %d insns (limit %d), stack depth ",
5950 insn_processed, BPF_COMPLEXITY_LIMIT_INSNS);
f910cefa 5951 for (i = 0; i < env->subprog_cnt; i++) {
9c8105bd 5952 u32 depth = env->subprog_info[i].stack_depth;
f4d7e40a
AS
5953
5954 verbose(env, "%d", depth);
f910cefa 5955 if (i + 1 < env->subprog_cnt)
f4d7e40a
AS
5956 verbose(env, "+");
5957 }
5958 verbose(env, "\n");
9c8105bd 5959 env->prog->aux->stack_depth = env->subprog_info[0].stack_depth;
17a52670
AS
5960 return 0;
5961}
5962
56f668df
MKL
5963static int check_map_prealloc(struct bpf_map *map)
5964{
5965 return (map->map_type != BPF_MAP_TYPE_HASH &&
bcc6b1b7
MKL
5966 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
5967 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
56f668df
MKL
5968 !(map->map_flags & BPF_F_NO_PREALLOC);
5969}
5970
61bd5218
JK
5971static int check_map_prog_compatibility(struct bpf_verifier_env *env,
5972 struct bpf_map *map,
fdc15d38
AS
5973 struct bpf_prog *prog)
5974
5975{
56f668df
MKL
5976 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
5977 * preallocated hash maps, since doing memory allocation
5978 * in overflow_handler can crash depending on where nmi got
5979 * triggered.
5980 */
5981 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
5982 if (!check_map_prealloc(map)) {
61bd5218 5983 verbose(env, "perf_event programs can only use preallocated hash map\n");
56f668df
MKL
5984 return -EINVAL;
5985 }
5986 if (map->inner_map_meta &&
5987 !check_map_prealloc(map->inner_map_meta)) {
61bd5218 5988 verbose(env, "perf_event programs can only use preallocated inner hash map\n");
56f668df
MKL
5989 return -EINVAL;
5990 }
fdc15d38 5991 }
a3884572
JK
5992
5993 if ((bpf_prog_is_dev_bound(prog->aux) || bpf_map_is_dev_bound(map)) &&
09728266 5994 !bpf_offload_prog_map_match(prog, map)) {
a3884572
JK
5995 verbose(env, "offload device mismatch between prog and map\n");
5996 return -EINVAL;
5997 }
5998
fdc15d38
AS
5999 return 0;
6000}
6001
b741f163
RG
6002static bool bpf_map_is_cgroup_storage(struct bpf_map *map)
6003{
6004 return (map->map_type == BPF_MAP_TYPE_CGROUP_STORAGE ||
6005 map->map_type == BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE);
6006}
6007
0246e64d
AS
6008/* look for pseudo eBPF instructions that access map FDs and
6009 * replace them with actual map pointers
6010 */
58e2af8b 6011static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
0246e64d
AS
6012{
6013 struct bpf_insn *insn = env->prog->insnsi;
6014 int insn_cnt = env->prog->len;
fdc15d38 6015 int i, j, err;
0246e64d 6016
f1f7714e 6017 err = bpf_prog_calc_tag(env->prog);
aafe6ae9
DB
6018 if (err)
6019 return err;
6020
0246e64d 6021 for (i = 0; i < insn_cnt; i++, insn++) {
9bac3d6d 6022 if (BPF_CLASS(insn->code) == BPF_LDX &&
d691f9e8 6023 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
61bd5218 6024 verbose(env, "BPF_LDX uses reserved fields\n");
9bac3d6d
AS
6025 return -EINVAL;
6026 }
6027
d691f9e8
AS
6028 if (BPF_CLASS(insn->code) == BPF_STX &&
6029 ((BPF_MODE(insn->code) != BPF_MEM &&
6030 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
61bd5218 6031 verbose(env, "BPF_STX uses reserved fields\n");
d691f9e8
AS
6032 return -EINVAL;
6033 }
6034
0246e64d
AS
6035 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
6036 struct bpf_map *map;
6037 struct fd f;
6038
6039 if (i == insn_cnt - 1 || insn[1].code != 0 ||
6040 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
6041 insn[1].off != 0) {
61bd5218 6042 verbose(env, "invalid bpf_ld_imm64 insn\n");
0246e64d
AS
6043 return -EINVAL;
6044 }
6045
6046 if (insn->src_reg == 0)
6047 /* valid generic load 64-bit imm */
6048 goto next_insn;
6049
6050 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
61bd5218
JK
6051 verbose(env,
6052 "unrecognized bpf_ld_imm64 insn\n");
0246e64d
AS
6053 return -EINVAL;
6054 }
6055
6056 f = fdget(insn->imm);
c2101297 6057 map = __bpf_map_get(f);
0246e64d 6058 if (IS_ERR(map)) {
61bd5218 6059 verbose(env, "fd %d is not pointing to valid bpf_map\n",
0246e64d 6060 insn->imm);
0246e64d
AS
6061 return PTR_ERR(map);
6062 }
6063
61bd5218 6064 err = check_map_prog_compatibility(env, map, env->prog);
fdc15d38
AS
6065 if (err) {
6066 fdput(f);
6067 return err;
6068 }
6069
0246e64d
AS
6070 /* store map pointer inside BPF_LD_IMM64 instruction */
6071 insn[0].imm = (u32) (unsigned long) map;
6072 insn[1].imm = ((u64) (unsigned long) map) >> 32;
6073
6074 /* check whether we recorded this map already */
6075 for (j = 0; j < env->used_map_cnt; j++)
6076 if (env->used_maps[j] == map) {
6077 fdput(f);
6078 goto next_insn;
6079 }
6080
6081 if (env->used_map_cnt >= MAX_USED_MAPS) {
6082 fdput(f);
6083 return -E2BIG;
6084 }
6085
0246e64d
AS
6086 /* hold the map. If the program is rejected by verifier,
6087 * the map will be released by release_maps() or it
6088 * will be used by the valid program until it's unloaded
ab7f5bf0 6089 * and all maps are released in free_used_maps()
0246e64d 6090 */
92117d84
AS
6091 map = bpf_map_inc(map, false);
6092 if (IS_ERR(map)) {
6093 fdput(f);
6094 return PTR_ERR(map);
6095 }
6096 env->used_maps[env->used_map_cnt++] = map;
6097
b741f163 6098 if (bpf_map_is_cgroup_storage(map) &&
de9cbbaa 6099 bpf_cgroup_storage_assign(env->prog, map)) {
b741f163 6100 verbose(env, "only one cgroup storage of each type is allowed\n");
de9cbbaa
RG
6101 fdput(f);
6102 return -EBUSY;
6103 }
6104
0246e64d
AS
6105 fdput(f);
6106next_insn:
6107 insn++;
6108 i++;
5e581dad
DB
6109 continue;
6110 }
6111
6112 /* Basic sanity check before we invest more work here. */
6113 if (!bpf_opcode_in_insntable(insn->code)) {
6114 verbose(env, "unknown opcode %02x\n", insn->code);
6115 return -EINVAL;
0246e64d
AS
6116 }
6117 }
6118
6119 /* now all pseudo BPF_LD_IMM64 instructions load valid
6120 * 'struct bpf_map *' into a register instead of user map_fd.
6121 * These pointers will be used later by verifier to validate map access.
6122 */
6123 return 0;
6124}
6125
6126/* drop refcnt of maps used by the rejected program */
58e2af8b 6127static void release_maps(struct bpf_verifier_env *env)
0246e64d 6128{
8bad74f9 6129 enum bpf_cgroup_storage_type stype;
0246e64d
AS
6130 int i;
6131
8bad74f9
RG
6132 for_each_cgroup_storage_type(stype) {
6133 if (!env->prog->aux->cgroup_storage[stype])
6134 continue;
de9cbbaa 6135 bpf_cgroup_storage_release(env->prog,
8bad74f9
RG
6136 env->prog->aux->cgroup_storage[stype]);
6137 }
de9cbbaa 6138
0246e64d
AS
6139 for (i = 0; i < env->used_map_cnt; i++)
6140 bpf_map_put(env->used_maps[i]);
6141}
6142
6143/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
58e2af8b 6144static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
0246e64d
AS
6145{
6146 struct bpf_insn *insn = env->prog->insnsi;
6147 int insn_cnt = env->prog->len;
6148 int i;
6149
6150 for (i = 0; i < insn_cnt; i++, insn++)
6151 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
6152 insn->src_reg = 0;
6153}
6154
8041902d
AS
6155/* single env->prog->insni[off] instruction was replaced with the range
6156 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
6157 * [0, off) and [off, end) to new locations, so the patched range stays zero
6158 */
6159static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
6160 u32 off, u32 cnt)
6161{
6162 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
c131187d 6163 int i;
8041902d
AS
6164
6165 if (cnt == 1)
6166 return 0;
fad953ce
KC
6167 new_data = vzalloc(array_size(prog_len,
6168 sizeof(struct bpf_insn_aux_data)));
8041902d
AS
6169 if (!new_data)
6170 return -ENOMEM;
6171 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
6172 memcpy(new_data + off + cnt - 1, old_data + off,
6173 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
c131187d
AS
6174 for (i = off; i < off + cnt - 1; i++)
6175 new_data[i].seen = true;
8041902d
AS
6176 env->insn_aux_data = new_data;
6177 vfree(old_data);
6178 return 0;
6179}
6180
cc8b0b92
AS
6181static void adjust_subprog_starts(struct bpf_verifier_env *env, u32 off, u32 len)
6182{
6183 int i;
6184
6185 if (len == 1)
6186 return;
4cb3d99c
JW
6187 /* NOTE: fake 'exit' subprog should be updated as well. */
6188 for (i = 0; i <= env->subprog_cnt; i++) {
afd59424 6189 if (env->subprog_info[i].start <= off)
cc8b0b92 6190 continue;
9c8105bd 6191 env->subprog_info[i].start += len - 1;
cc8b0b92
AS
6192 }
6193}
6194
8041902d
AS
6195static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
6196 const struct bpf_insn *patch, u32 len)
6197{
6198 struct bpf_prog *new_prog;
6199
6200 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
6201 if (!new_prog)
6202 return NULL;
6203 if (adjust_insn_aux_data(env, new_prog->len, off, len))
6204 return NULL;
cc8b0b92 6205 adjust_subprog_starts(env, off, len);
8041902d
AS
6206 return new_prog;
6207}
6208
2a5418a1
DB
6209/* The verifier does more data flow analysis than llvm and will not
6210 * explore branches that are dead at run time. Malicious programs can
6211 * have dead code too. Therefore replace all dead at-run-time code
6212 * with 'ja -1'.
6213 *
6214 * Just nops are not optimal, e.g. if they would sit at the end of the
6215 * program and through another bug we would manage to jump there, then
6216 * we'd execute beyond program memory otherwise. Returning exception
6217 * code also wouldn't work since we can have subprogs where the dead
6218 * code could be located.
c131187d
AS
6219 */
6220static void sanitize_dead_code(struct bpf_verifier_env *env)
6221{
6222 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
2a5418a1 6223 struct bpf_insn trap = BPF_JMP_IMM(BPF_JA, 0, 0, -1);
c131187d
AS
6224 struct bpf_insn *insn = env->prog->insnsi;
6225 const int insn_cnt = env->prog->len;
6226 int i;
6227
6228 for (i = 0; i < insn_cnt; i++) {
6229 if (aux_data[i].seen)
6230 continue;
2a5418a1 6231 memcpy(insn + i, &trap, sizeof(trap));
c131187d
AS
6232 }
6233}
6234
c64b7983
JS
6235/* convert load instructions that access fields of a context type into a
6236 * sequence of instructions that access fields of the underlying structure:
6237 * struct __sk_buff -> struct sk_buff
6238 * struct bpf_sock_ops -> struct sock
9bac3d6d 6239 */
58e2af8b 6240static int convert_ctx_accesses(struct bpf_verifier_env *env)
9bac3d6d 6241{
00176a34 6242 const struct bpf_verifier_ops *ops = env->ops;
f96da094 6243 int i, cnt, size, ctx_field_size, delta = 0;
3df126f3 6244 const int insn_cnt = env->prog->len;
36bbef52 6245 struct bpf_insn insn_buf[16], *insn;
46f53a65 6246 u32 target_size, size_default, off;
9bac3d6d 6247 struct bpf_prog *new_prog;
d691f9e8 6248 enum bpf_access_type type;
f96da094 6249 bool is_narrower_load;
9bac3d6d 6250
b09928b9
DB
6251 if (ops->gen_prologue || env->seen_direct_write) {
6252 if (!ops->gen_prologue) {
6253 verbose(env, "bpf verifier is misconfigured\n");
6254 return -EINVAL;
6255 }
36bbef52
DB
6256 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
6257 env->prog);
6258 if (cnt >= ARRAY_SIZE(insn_buf)) {
61bd5218 6259 verbose(env, "bpf verifier is misconfigured\n");
36bbef52
DB
6260 return -EINVAL;
6261 } else if (cnt) {
8041902d 6262 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
36bbef52
DB
6263 if (!new_prog)
6264 return -ENOMEM;
8041902d 6265
36bbef52 6266 env->prog = new_prog;
3df126f3 6267 delta += cnt - 1;
36bbef52
DB
6268 }
6269 }
6270
c64b7983 6271 if (bpf_prog_is_dev_bound(env->prog->aux))
9bac3d6d
AS
6272 return 0;
6273
3df126f3 6274 insn = env->prog->insnsi + delta;
36bbef52 6275
9bac3d6d 6276 for (i = 0; i < insn_cnt; i++, insn++) {
c64b7983
JS
6277 bpf_convert_ctx_access_t convert_ctx_access;
6278
62c7989b
DB
6279 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
6280 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
6281 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
ea2e7ce5 6282 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
d691f9e8 6283 type = BPF_READ;
62c7989b
DB
6284 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
6285 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
6286 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
ea2e7ce5 6287 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
d691f9e8
AS
6288 type = BPF_WRITE;
6289 else
9bac3d6d
AS
6290 continue;
6291
af86ca4e
AS
6292 if (type == BPF_WRITE &&
6293 env->insn_aux_data[i + delta].sanitize_stack_off) {
6294 struct bpf_insn patch[] = {
6295 /* Sanitize suspicious stack slot with zero.
6296 * There are no memory dependencies for this store,
6297 * since it's only using frame pointer and immediate
6298 * constant of zero
6299 */
6300 BPF_ST_MEM(BPF_DW, BPF_REG_FP,
6301 env->insn_aux_data[i + delta].sanitize_stack_off,
6302 0),
6303 /* the original STX instruction will immediately
6304 * overwrite the same stack slot with appropriate value
6305 */
6306 *insn,
6307 };
6308
6309 cnt = ARRAY_SIZE(patch);
6310 new_prog = bpf_patch_insn_data(env, i + delta, patch, cnt);
6311 if (!new_prog)
6312 return -ENOMEM;
6313
6314 delta += cnt - 1;
6315 env->prog = new_prog;
6316 insn = new_prog->insnsi + i + delta;
6317 continue;
6318 }
6319
c64b7983
JS
6320 switch (env->insn_aux_data[i + delta].ptr_type) {
6321 case PTR_TO_CTX:
6322 if (!ops->convert_ctx_access)
6323 continue;
6324 convert_ctx_access = ops->convert_ctx_access;
6325 break;
6326 case PTR_TO_SOCKET:
6327 convert_ctx_access = bpf_sock_convert_ctx_access;
6328 break;
6329 default:
9bac3d6d 6330 continue;
c64b7983 6331 }
9bac3d6d 6332
31fd8581 6333 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
f96da094 6334 size = BPF_LDST_BYTES(insn);
31fd8581
YS
6335
6336 /* If the read access is a narrower load of the field,
6337 * convert to a 4/8-byte load, to minimum program type specific
6338 * convert_ctx_access changes. If conversion is successful,
6339 * we will apply proper mask to the result.
6340 */
f96da094 6341 is_narrower_load = size < ctx_field_size;
46f53a65
AI
6342 size_default = bpf_ctx_off_adjust_machine(ctx_field_size);
6343 off = insn->off;
31fd8581 6344 if (is_narrower_load) {
f96da094
DB
6345 u8 size_code;
6346
6347 if (type == BPF_WRITE) {
61bd5218 6348 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
f96da094
DB
6349 return -EINVAL;
6350 }
31fd8581 6351
f96da094 6352 size_code = BPF_H;
31fd8581
YS
6353 if (ctx_field_size == 4)
6354 size_code = BPF_W;
6355 else if (ctx_field_size == 8)
6356 size_code = BPF_DW;
f96da094 6357
bc23105c 6358 insn->off = off & ~(size_default - 1);
31fd8581
YS
6359 insn->code = BPF_LDX | BPF_MEM | size_code;
6360 }
f96da094
DB
6361
6362 target_size = 0;
c64b7983
JS
6363 cnt = convert_ctx_access(type, insn, insn_buf, env->prog,
6364 &target_size);
f96da094
DB
6365 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
6366 (ctx_field_size && !target_size)) {
61bd5218 6367 verbose(env, "bpf verifier is misconfigured\n");
9bac3d6d
AS
6368 return -EINVAL;
6369 }
f96da094
DB
6370
6371 if (is_narrower_load && size < target_size) {
46f53a65
AI
6372 u8 shift = (off & (size_default - 1)) * 8;
6373
6374 if (ctx_field_size <= 4) {
6375 if (shift)
6376 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_RSH,
6377 insn->dst_reg,
6378 shift);
31fd8581 6379 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
f96da094 6380 (1 << size * 8) - 1);
46f53a65
AI
6381 } else {
6382 if (shift)
6383 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_RSH,
6384 insn->dst_reg,
6385 shift);
31fd8581 6386 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
f96da094 6387 (1 << size * 8) - 1);
46f53a65 6388 }
31fd8581 6389 }
9bac3d6d 6390
8041902d 6391 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
9bac3d6d
AS
6392 if (!new_prog)
6393 return -ENOMEM;
6394
3df126f3 6395 delta += cnt - 1;
9bac3d6d
AS
6396
6397 /* keep walking new program and skip insns we just inserted */
6398 env->prog = new_prog;
3df126f3 6399 insn = new_prog->insnsi + i + delta;
9bac3d6d
AS
6400 }
6401
6402 return 0;
6403}
6404
1c2a088a
AS
6405static int jit_subprogs(struct bpf_verifier_env *env)
6406{
6407 struct bpf_prog *prog = env->prog, **func, *tmp;
6408 int i, j, subprog_start, subprog_end = 0, len, subprog;
7105e828 6409 struct bpf_insn *insn;
1c2a088a 6410 void *old_bpf_func;
c454a46b 6411 int err;
1c2a088a 6412
f910cefa 6413 if (env->subprog_cnt <= 1)
1c2a088a
AS
6414 return 0;
6415
7105e828 6416 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
1c2a088a
AS
6417 if (insn->code != (BPF_JMP | BPF_CALL) ||
6418 insn->src_reg != BPF_PSEUDO_CALL)
6419 continue;
c7a89784
DB
6420 /* Upon error here we cannot fall back to interpreter but
6421 * need a hard reject of the program. Thus -EFAULT is
6422 * propagated in any case.
6423 */
1c2a088a
AS
6424 subprog = find_subprog(env, i + insn->imm + 1);
6425 if (subprog < 0) {
6426 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
6427 i + insn->imm + 1);
6428 return -EFAULT;
6429 }
6430 /* temporarily remember subprog id inside insn instead of
6431 * aux_data, since next loop will split up all insns into funcs
6432 */
f910cefa 6433 insn->off = subprog;
1c2a088a
AS
6434 /* remember original imm in case JIT fails and fallback
6435 * to interpreter will be needed
6436 */
6437 env->insn_aux_data[i].call_imm = insn->imm;
6438 /* point imm to __bpf_call_base+1 from JITs point of view */
6439 insn->imm = 1;
6440 }
6441
c454a46b
MKL
6442 err = bpf_prog_alloc_jited_linfo(prog);
6443 if (err)
6444 goto out_undo_insn;
6445
6446 err = -ENOMEM;
6396bb22 6447 func = kcalloc(env->subprog_cnt, sizeof(prog), GFP_KERNEL);
1c2a088a 6448 if (!func)
c7a89784 6449 goto out_undo_insn;
1c2a088a 6450
f910cefa 6451 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a 6452 subprog_start = subprog_end;
4cb3d99c 6453 subprog_end = env->subprog_info[i + 1].start;
1c2a088a
AS
6454
6455 len = subprog_end - subprog_start;
6456 func[i] = bpf_prog_alloc(bpf_prog_size(len), GFP_USER);
6457 if (!func[i])
6458 goto out_free;
6459 memcpy(func[i]->insnsi, &prog->insnsi[subprog_start],
6460 len * sizeof(struct bpf_insn));
4f74d809 6461 func[i]->type = prog->type;
1c2a088a 6462 func[i]->len = len;
4f74d809
DB
6463 if (bpf_prog_calc_tag(func[i]))
6464 goto out_free;
1c2a088a 6465 func[i]->is_func = 1;
ba64e7d8
YS
6466 func[i]->aux->func_idx = i;
6467 /* the btf and func_info will be freed only at prog->aux */
6468 func[i]->aux->btf = prog->aux->btf;
6469 func[i]->aux->func_info = prog->aux->func_info;
6470
1c2a088a
AS
6471 /* Use bpf_prog_F_tag to indicate functions in stack traces.
6472 * Long term would need debug info to populate names
6473 */
6474 func[i]->aux->name[0] = 'F';
9c8105bd 6475 func[i]->aux->stack_depth = env->subprog_info[i].stack_depth;
1c2a088a 6476 func[i]->jit_requested = 1;
c454a46b
MKL
6477 func[i]->aux->linfo = prog->aux->linfo;
6478 func[i]->aux->nr_linfo = prog->aux->nr_linfo;
6479 func[i]->aux->jited_linfo = prog->aux->jited_linfo;
6480 func[i]->aux->linfo_idx = env->subprog_info[i].linfo_idx;
1c2a088a
AS
6481 func[i] = bpf_int_jit_compile(func[i]);
6482 if (!func[i]->jited) {
6483 err = -ENOTSUPP;
6484 goto out_free;
6485 }
6486 cond_resched();
6487 }
6488 /* at this point all bpf functions were successfully JITed
6489 * now populate all bpf_calls with correct addresses and
6490 * run last pass of JIT
6491 */
f910cefa 6492 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
6493 insn = func[i]->insnsi;
6494 for (j = 0; j < func[i]->len; j++, insn++) {
6495 if (insn->code != (BPF_JMP | BPF_CALL) ||
6496 insn->src_reg != BPF_PSEUDO_CALL)
6497 continue;
6498 subprog = insn->off;
1c2a088a
AS
6499 insn->imm = (u64 (*)(u64, u64, u64, u64, u64))
6500 func[subprog]->bpf_func -
6501 __bpf_call_base;
6502 }
2162fed4
SD
6503
6504 /* we use the aux data to keep a list of the start addresses
6505 * of the JITed images for each function in the program
6506 *
6507 * for some architectures, such as powerpc64, the imm field
6508 * might not be large enough to hold the offset of the start
6509 * address of the callee's JITed image from __bpf_call_base
6510 *
6511 * in such cases, we can lookup the start address of a callee
6512 * by using its subprog id, available from the off field of
6513 * the call instruction, as an index for this list
6514 */
6515 func[i]->aux->func = func;
6516 func[i]->aux->func_cnt = env->subprog_cnt;
1c2a088a 6517 }
f910cefa 6518 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
6519 old_bpf_func = func[i]->bpf_func;
6520 tmp = bpf_int_jit_compile(func[i]);
6521 if (tmp != func[i] || func[i]->bpf_func != old_bpf_func) {
6522 verbose(env, "JIT doesn't support bpf-to-bpf calls\n");
c7a89784 6523 err = -ENOTSUPP;
1c2a088a
AS
6524 goto out_free;
6525 }
6526 cond_resched();
6527 }
6528
6529 /* finally lock prog and jit images for all functions and
6530 * populate kallsysm
6531 */
f910cefa 6532 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
6533 bpf_prog_lock_ro(func[i]);
6534 bpf_prog_kallsyms_add(func[i]);
6535 }
7105e828
DB
6536
6537 /* Last step: make now unused interpreter insns from main
6538 * prog consistent for later dump requests, so they can
6539 * later look the same as if they were interpreted only.
6540 */
6541 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
7105e828
DB
6542 if (insn->code != (BPF_JMP | BPF_CALL) ||
6543 insn->src_reg != BPF_PSEUDO_CALL)
6544 continue;
6545 insn->off = env->insn_aux_data[i].call_imm;
6546 subprog = find_subprog(env, i + insn->off + 1);
dbecd738 6547 insn->imm = subprog;
7105e828
DB
6548 }
6549
1c2a088a
AS
6550 prog->jited = 1;
6551 prog->bpf_func = func[0]->bpf_func;
6552 prog->aux->func = func;
f910cefa 6553 prog->aux->func_cnt = env->subprog_cnt;
c454a46b 6554 bpf_prog_free_unused_jited_linfo(prog);
1c2a088a
AS
6555 return 0;
6556out_free:
f910cefa 6557 for (i = 0; i < env->subprog_cnt; i++)
1c2a088a
AS
6558 if (func[i])
6559 bpf_jit_free(func[i]);
6560 kfree(func);
c7a89784 6561out_undo_insn:
1c2a088a
AS
6562 /* cleanup main prog to be interpreted */
6563 prog->jit_requested = 0;
6564 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
6565 if (insn->code != (BPF_JMP | BPF_CALL) ||
6566 insn->src_reg != BPF_PSEUDO_CALL)
6567 continue;
6568 insn->off = 0;
6569 insn->imm = env->insn_aux_data[i].call_imm;
6570 }
c454a46b 6571 bpf_prog_free_jited_linfo(prog);
1c2a088a
AS
6572 return err;
6573}
6574
1ea47e01
AS
6575static int fixup_call_args(struct bpf_verifier_env *env)
6576{
19d28fbd 6577#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
6578 struct bpf_prog *prog = env->prog;
6579 struct bpf_insn *insn = prog->insnsi;
6580 int i, depth;
19d28fbd 6581#endif
e4052d06 6582 int err = 0;
1ea47e01 6583
e4052d06
QM
6584 if (env->prog->jit_requested &&
6585 !bpf_prog_is_dev_bound(env->prog->aux)) {
19d28fbd
DM
6586 err = jit_subprogs(env);
6587 if (err == 0)
1c2a088a 6588 return 0;
c7a89784
DB
6589 if (err == -EFAULT)
6590 return err;
19d28fbd
DM
6591 }
6592#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
6593 for (i = 0; i < prog->len; i++, insn++) {
6594 if (insn->code != (BPF_JMP | BPF_CALL) ||
6595 insn->src_reg != BPF_PSEUDO_CALL)
6596 continue;
6597 depth = get_callee_stack_depth(env, insn, i);
6598 if (depth < 0)
6599 return depth;
6600 bpf_patch_call_args(insn, depth);
6601 }
19d28fbd
DM
6602 err = 0;
6603#endif
6604 return err;
1ea47e01
AS
6605}
6606
79741b3b 6607/* fixup insn->imm field of bpf_call instructions
81ed18ab 6608 * and inline eligible helpers as explicit sequence of BPF instructions
e245c5c6
AS
6609 *
6610 * this function is called after eBPF program passed verification
6611 */
79741b3b 6612static int fixup_bpf_calls(struct bpf_verifier_env *env)
e245c5c6 6613{
79741b3b
AS
6614 struct bpf_prog *prog = env->prog;
6615 struct bpf_insn *insn = prog->insnsi;
e245c5c6 6616 const struct bpf_func_proto *fn;
79741b3b 6617 const int insn_cnt = prog->len;
09772d92 6618 const struct bpf_map_ops *ops;
c93552c4 6619 struct bpf_insn_aux_data *aux;
81ed18ab
AS
6620 struct bpf_insn insn_buf[16];
6621 struct bpf_prog *new_prog;
6622 struct bpf_map *map_ptr;
6623 int i, cnt, delta = 0;
e245c5c6 6624
79741b3b 6625 for (i = 0; i < insn_cnt; i++, insn++) {
f6b1b3bf
DB
6626 if (insn->code == (BPF_ALU64 | BPF_MOD | BPF_X) ||
6627 insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
6628 insn->code == (BPF_ALU | BPF_MOD | BPF_X) ||
68fda450 6629 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
f6b1b3bf
DB
6630 bool is64 = BPF_CLASS(insn->code) == BPF_ALU64;
6631 struct bpf_insn mask_and_div[] = {
6632 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
6633 /* Rx div 0 -> 0 */
6634 BPF_JMP_IMM(BPF_JNE, insn->src_reg, 0, 2),
6635 BPF_ALU32_REG(BPF_XOR, insn->dst_reg, insn->dst_reg),
6636 BPF_JMP_IMM(BPF_JA, 0, 0, 1),
6637 *insn,
6638 };
6639 struct bpf_insn mask_and_mod[] = {
6640 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
6641 /* Rx mod 0 -> Rx */
6642 BPF_JMP_IMM(BPF_JEQ, insn->src_reg, 0, 1),
6643 *insn,
6644 };
6645 struct bpf_insn *patchlet;
6646
6647 if (insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
6648 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
6649 patchlet = mask_and_div + (is64 ? 1 : 0);
6650 cnt = ARRAY_SIZE(mask_and_div) - (is64 ? 1 : 0);
6651 } else {
6652 patchlet = mask_and_mod + (is64 ? 1 : 0);
6653 cnt = ARRAY_SIZE(mask_and_mod) - (is64 ? 1 : 0);
6654 }
6655
6656 new_prog = bpf_patch_insn_data(env, i + delta, patchlet, cnt);
68fda450
AS
6657 if (!new_prog)
6658 return -ENOMEM;
6659
6660 delta += cnt - 1;
6661 env->prog = prog = new_prog;
6662 insn = new_prog->insnsi + i + delta;
6663 continue;
6664 }
6665
e0cea7ce
DB
6666 if (BPF_CLASS(insn->code) == BPF_LD &&
6667 (BPF_MODE(insn->code) == BPF_ABS ||
6668 BPF_MODE(insn->code) == BPF_IND)) {
6669 cnt = env->ops->gen_ld_abs(insn, insn_buf);
6670 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
6671 verbose(env, "bpf verifier is misconfigured\n");
6672 return -EINVAL;
6673 }
6674
6675 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
6676 if (!new_prog)
6677 return -ENOMEM;
6678
6679 delta += cnt - 1;
6680 env->prog = prog = new_prog;
6681 insn = new_prog->insnsi + i + delta;
6682 continue;
6683 }
6684
79741b3b
AS
6685 if (insn->code != (BPF_JMP | BPF_CALL))
6686 continue;
cc8b0b92
AS
6687 if (insn->src_reg == BPF_PSEUDO_CALL)
6688 continue;
e245c5c6 6689
79741b3b
AS
6690 if (insn->imm == BPF_FUNC_get_route_realm)
6691 prog->dst_needed = 1;
6692 if (insn->imm == BPF_FUNC_get_prandom_u32)
6693 bpf_user_rnd_init_once();
9802d865
JB
6694 if (insn->imm == BPF_FUNC_override_return)
6695 prog->kprobe_override = 1;
79741b3b 6696 if (insn->imm == BPF_FUNC_tail_call) {
7b9f6da1
DM
6697 /* If we tail call into other programs, we
6698 * cannot make any assumptions since they can
6699 * be replaced dynamically during runtime in
6700 * the program array.
6701 */
6702 prog->cb_access = 1;
80a58d02 6703 env->prog->aux->stack_depth = MAX_BPF_STACK;
e647815a 6704 env->prog->aux->max_pkt_offset = MAX_PACKET_OFF;
7b9f6da1 6705
79741b3b
AS
6706 /* mark bpf_tail_call as different opcode to avoid
6707 * conditional branch in the interpeter for every normal
6708 * call and to prevent accidental JITing by JIT compiler
6709 * that doesn't support bpf_tail_call yet
e245c5c6 6710 */
79741b3b 6711 insn->imm = 0;
71189fa9 6712 insn->code = BPF_JMP | BPF_TAIL_CALL;
b2157399 6713
c93552c4
DB
6714 aux = &env->insn_aux_data[i + delta];
6715 if (!bpf_map_ptr_unpriv(aux))
6716 continue;
6717
b2157399
AS
6718 /* instead of changing every JIT dealing with tail_call
6719 * emit two extra insns:
6720 * if (index >= max_entries) goto out;
6721 * index &= array->index_mask;
6722 * to avoid out-of-bounds cpu speculation
6723 */
c93552c4 6724 if (bpf_map_ptr_poisoned(aux)) {
40950343 6725 verbose(env, "tail_call abusing map_ptr\n");
b2157399
AS
6726 return -EINVAL;
6727 }
c93552c4
DB
6728
6729 map_ptr = BPF_MAP_PTR(aux->map_state);
b2157399
AS
6730 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
6731 map_ptr->max_entries, 2);
6732 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
6733 container_of(map_ptr,
6734 struct bpf_array,
6735 map)->index_mask);
6736 insn_buf[2] = *insn;
6737 cnt = 3;
6738 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
6739 if (!new_prog)
6740 return -ENOMEM;
6741
6742 delta += cnt - 1;
6743 env->prog = prog = new_prog;
6744 insn = new_prog->insnsi + i + delta;
79741b3b
AS
6745 continue;
6746 }
e245c5c6 6747
89c63074 6748 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
09772d92
DB
6749 * and other inlining handlers are currently limited to 64 bit
6750 * only.
89c63074 6751 */
60b58afc 6752 if (prog->jit_requested && BITS_PER_LONG == 64 &&
09772d92
DB
6753 (insn->imm == BPF_FUNC_map_lookup_elem ||
6754 insn->imm == BPF_FUNC_map_update_elem ||
84430d42
DB
6755 insn->imm == BPF_FUNC_map_delete_elem ||
6756 insn->imm == BPF_FUNC_map_push_elem ||
6757 insn->imm == BPF_FUNC_map_pop_elem ||
6758 insn->imm == BPF_FUNC_map_peek_elem)) {
c93552c4
DB
6759 aux = &env->insn_aux_data[i + delta];
6760 if (bpf_map_ptr_poisoned(aux))
6761 goto patch_call_imm;
6762
6763 map_ptr = BPF_MAP_PTR(aux->map_state);
09772d92
DB
6764 ops = map_ptr->ops;
6765 if (insn->imm == BPF_FUNC_map_lookup_elem &&
6766 ops->map_gen_lookup) {
6767 cnt = ops->map_gen_lookup(map_ptr, insn_buf);
6768 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
6769 verbose(env, "bpf verifier is misconfigured\n");
6770 return -EINVAL;
6771 }
81ed18ab 6772
09772d92
DB
6773 new_prog = bpf_patch_insn_data(env, i + delta,
6774 insn_buf, cnt);
6775 if (!new_prog)
6776 return -ENOMEM;
81ed18ab 6777
09772d92
DB
6778 delta += cnt - 1;
6779 env->prog = prog = new_prog;
6780 insn = new_prog->insnsi + i + delta;
6781 continue;
6782 }
81ed18ab 6783
09772d92
DB
6784 BUILD_BUG_ON(!__same_type(ops->map_lookup_elem,
6785 (void *(*)(struct bpf_map *map, void *key))NULL));
6786 BUILD_BUG_ON(!__same_type(ops->map_delete_elem,
6787 (int (*)(struct bpf_map *map, void *key))NULL));
6788 BUILD_BUG_ON(!__same_type(ops->map_update_elem,
6789 (int (*)(struct bpf_map *map, void *key, void *value,
6790 u64 flags))NULL));
84430d42
DB
6791 BUILD_BUG_ON(!__same_type(ops->map_push_elem,
6792 (int (*)(struct bpf_map *map, void *value,
6793 u64 flags))NULL));
6794 BUILD_BUG_ON(!__same_type(ops->map_pop_elem,
6795 (int (*)(struct bpf_map *map, void *value))NULL));
6796 BUILD_BUG_ON(!__same_type(ops->map_peek_elem,
6797 (int (*)(struct bpf_map *map, void *value))NULL));
6798
09772d92
DB
6799 switch (insn->imm) {
6800 case BPF_FUNC_map_lookup_elem:
6801 insn->imm = BPF_CAST_CALL(ops->map_lookup_elem) -
6802 __bpf_call_base;
6803 continue;
6804 case BPF_FUNC_map_update_elem:
6805 insn->imm = BPF_CAST_CALL(ops->map_update_elem) -
6806 __bpf_call_base;
6807 continue;
6808 case BPF_FUNC_map_delete_elem:
6809 insn->imm = BPF_CAST_CALL(ops->map_delete_elem) -
6810 __bpf_call_base;
6811 continue;
84430d42
DB
6812 case BPF_FUNC_map_push_elem:
6813 insn->imm = BPF_CAST_CALL(ops->map_push_elem) -
6814 __bpf_call_base;
6815 continue;
6816 case BPF_FUNC_map_pop_elem:
6817 insn->imm = BPF_CAST_CALL(ops->map_pop_elem) -
6818 __bpf_call_base;
6819 continue;
6820 case BPF_FUNC_map_peek_elem:
6821 insn->imm = BPF_CAST_CALL(ops->map_peek_elem) -
6822 __bpf_call_base;
6823 continue;
09772d92 6824 }
81ed18ab 6825
09772d92 6826 goto patch_call_imm;
81ed18ab
AS
6827 }
6828
6829patch_call_imm:
5e43f899 6830 fn = env->ops->get_func_proto(insn->imm, env->prog);
79741b3b
AS
6831 /* all functions that have prototype and verifier allowed
6832 * programs to call them, must be real in-kernel functions
6833 */
6834 if (!fn->func) {
61bd5218
JK
6835 verbose(env,
6836 "kernel subsystem misconfigured func %s#%d\n",
79741b3b
AS
6837 func_id_name(insn->imm), insn->imm);
6838 return -EFAULT;
e245c5c6 6839 }
79741b3b 6840 insn->imm = fn->func - __bpf_call_base;
e245c5c6 6841 }
e245c5c6 6842
79741b3b
AS
6843 return 0;
6844}
e245c5c6 6845
58e2af8b 6846static void free_states(struct bpf_verifier_env *env)
f1bca824 6847{
58e2af8b 6848 struct bpf_verifier_state_list *sl, *sln;
f1bca824
AS
6849 int i;
6850
6851 if (!env->explored_states)
6852 return;
6853
6854 for (i = 0; i < env->prog->len; i++) {
6855 sl = env->explored_states[i];
6856
6857 if (sl)
6858 while (sl != STATE_LIST_MARK) {
6859 sln = sl->next;
1969db47 6860 free_verifier_state(&sl->state, false);
f1bca824
AS
6861 kfree(sl);
6862 sl = sln;
6863 }
6864 }
6865
6866 kfree(env->explored_states);
6867}
6868
838e9690
YS
6869int bpf_check(struct bpf_prog **prog, union bpf_attr *attr,
6870 union bpf_attr __user *uattr)
51580e79 6871{
58e2af8b 6872 struct bpf_verifier_env *env;
b9193c1b 6873 struct bpf_verifier_log *log;
51580e79
AS
6874 int ret = -EINVAL;
6875
eba0c929
AB
6876 /* no program is valid */
6877 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
6878 return -EINVAL;
6879
58e2af8b 6880 /* 'struct bpf_verifier_env' can be global, but since it's not small,
cbd35700
AS
6881 * allocate/free it every time bpf_check() is called
6882 */
58e2af8b 6883 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
cbd35700
AS
6884 if (!env)
6885 return -ENOMEM;
61bd5218 6886 log = &env->log;
cbd35700 6887
fad953ce
KC
6888 env->insn_aux_data =
6889 vzalloc(array_size(sizeof(struct bpf_insn_aux_data),
6890 (*prog)->len));
3df126f3
JK
6891 ret = -ENOMEM;
6892 if (!env->insn_aux_data)
6893 goto err_free_env;
9bac3d6d 6894 env->prog = *prog;
00176a34 6895 env->ops = bpf_verifier_ops[env->prog->type];
0246e64d 6896
cbd35700
AS
6897 /* grab the mutex to protect few globals used by verifier */
6898 mutex_lock(&bpf_verifier_lock);
6899
6900 if (attr->log_level || attr->log_buf || attr->log_size) {
6901 /* user requested verbose verifier output
6902 * and supplied buffer to store the verification trace
6903 */
e7bf8249
JK
6904 log->level = attr->log_level;
6905 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
6906 log->len_total = attr->log_size;
cbd35700
AS
6907
6908 ret = -EINVAL;
e7bf8249
JK
6909 /* log attributes have to be sane */
6910 if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 ||
6911 !log->level || !log->ubuf)
3df126f3 6912 goto err_unlock;
cbd35700 6913 }
1ad2f583
DB
6914
6915 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
6916 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
e07b98d9 6917 env->strict_alignment = true;
e9ee9efc
DM
6918 if (attr->prog_flags & BPF_F_ANY_ALIGNMENT)
6919 env->strict_alignment = false;
cbd35700 6920
f4e3ec0d
JK
6921 ret = replace_map_fd_with_map_ptr(env);
6922 if (ret < 0)
6923 goto skip_full_check;
6924
cae1927c 6925 if (bpf_prog_is_dev_bound(env->prog->aux)) {
a40a2632 6926 ret = bpf_prog_offload_verifier_prep(env->prog);
ab3f0063 6927 if (ret)
f4e3ec0d 6928 goto skip_full_check;
ab3f0063
JK
6929 }
6930
9bac3d6d 6931 env->explored_states = kcalloc(env->prog->len,
58e2af8b 6932 sizeof(struct bpf_verifier_state_list *),
f1bca824
AS
6933 GFP_USER);
6934 ret = -ENOMEM;
6935 if (!env->explored_states)
6936 goto skip_full_check;
6937
cc8b0b92
AS
6938 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
6939
d9762e84 6940 ret = check_subprogs(env);
475fb78f
AS
6941 if (ret < 0)
6942 goto skip_full_check;
6943
c454a46b 6944 ret = check_btf_info(env, attr, uattr);
838e9690
YS
6945 if (ret < 0)
6946 goto skip_full_check;
6947
d9762e84
MKL
6948 ret = check_cfg(env);
6949 if (ret < 0)
6950 goto skip_full_check;
6951
17a52670 6952 ret = do_check(env);
8c01c4f8
CG
6953 if (env->cur_state) {
6954 free_verifier_state(env->cur_state, true);
6955 env->cur_state = NULL;
6956 }
cbd35700 6957
c941ce9c
QM
6958 if (ret == 0 && bpf_prog_is_dev_bound(env->prog->aux))
6959 ret = bpf_prog_offload_finalize(env);
6960
0246e64d 6961skip_full_check:
638f5b90 6962 while (!pop_stack(env, NULL, NULL));
f1bca824 6963 free_states(env);
0246e64d 6964
c131187d
AS
6965 if (ret == 0)
6966 sanitize_dead_code(env);
6967
70a87ffe
AS
6968 if (ret == 0)
6969 ret = check_max_stack_depth(env);
6970
9bac3d6d
AS
6971 if (ret == 0)
6972 /* program is valid, convert *(u32*)(ctx + off) accesses */
6973 ret = convert_ctx_accesses(env);
6974
e245c5c6 6975 if (ret == 0)
79741b3b 6976 ret = fixup_bpf_calls(env);
e245c5c6 6977
1ea47e01
AS
6978 if (ret == 0)
6979 ret = fixup_call_args(env);
6980
a2a7d570 6981 if (log->level && bpf_verifier_log_full(log))
cbd35700 6982 ret = -ENOSPC;
a2a7d570 6983 if (log->level && !log->ubuf) {
cbd35700 6984 ret = -EFAULT;
a2a7d570 6985 goto err_release_maps;
cbd35700
AS
6986 }
6987
0246e64d
AS
6988 if (ret == 0 && env->used_map_cnt) {
6989 /* if program passed verifier, update used_maps in bpf_prog_info */
9bac3d6d
AS
6990 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
6991 sizeof(env->used_maps[0]),
6992 GFP_KERNEL);
0246e64d 6993
9bac3d6d 6994 if (!env->prog->aux->used_maps) {
0246e64d 6995 ret = -ENOMEM;
a2a7d570 6996 goto err_release_maps;
0246e64d
AS
6997 }
6998
9bac3d6d 6999 memcpy(env->prog->aux->used_maps, env->used_maps,
0246e64d 7000 sizeof(env->used_maps[0]) * env->used_map_cnt);
9bac3d6d 7001 env->prog->aux->used_map_cnt = env->used_map_cnt;
0246e64d
AS
7002
7003 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
7004 * bpf_ld_imm64 instructions
7005 */
7006 convert_pseudo_ld_imm64(env);
7007 }
cbd35700 7008
ba64e7d8
YS
7009 if (ret == 0)
7010 adjust_btf_func(env);
7011
a2a7d570 7012err_release_maps:
9bac3d6d 7013 if (!env->prog->aux->used_maps)
0246e64d 7014 /* if we didn't copy map pointers into bpf_prog_info, release
ab7f5bf0 7015 * them now. Otherwise free_used_maps() will release them.
0246e64d
AS
7016 */
7017 release_maps(env);
9bac3d6d 7018 *prog = env->prog;
3df126f3 7019err_unlock:
cbd35700 7020 mutex_unlock(&bpf_verifier_lock);
3df126f3
JK
7021 vfree(env->insn_aux_data);
7022err_free_env:
7023 kfree(env);
51580e79
AS
7024 return ret;
7025}