Commit | Line | Data |
---|---|---|
e9be9d5e MS |
1 | /* |
2 | * | |
3 | * Copyright (C) 2011 Novell Inc. | |
4 | * | |
5 | * This program is free software; you can redistribute it and/or modify it | |
6 | * under the terms of the GNU General Public License version 2 as published by | |
7 | * the Free Software Foundation. | |
8 | */ | |
9 | ||
fb5bb2c3 | 10 | #include <linux/module.h> |
e9be9d5e MS |
11 | #include <linux/fs.h> |
12 | #include <linux/slab.h> | |
13 | #include <linux/file.h> | |
14 | #include <linux/splice.h> | |
15 | #include <linux/xattr.h> | |
16 | #include <linux/security.h> | |
17 | #include <linux/uaccess.h> | |
174cd4b1 | 18 | #include <linux/sched/signal.h> |
5b825c3a | 19 | #include <linux/cred.h> |
e9be9d5e | 20 | #include <linux/namei.h> |
fb5bb2c3 DH |
21 | #include <linux/fdtable.h> |
22 | #include <linux/ratelimit.h> | |
3a1e819b | 23 | #include <linux/exportfs.h> |
e9be9d5e | 24 | #include "overlayfs.h" |
d8514d8e | 25 | #include "ovl_entry.h" |
e9be9d5e MS |
26 | |
27 | #define OVL_COPY_UP_CHUNK_SIZE (1 << 20) | |
28 | ||
fb5bb2c3 DH |
29 | static bool __read_mostly ovl_check_copy_up; |
30 | module_param_named(check_copy_up, ovl_check_copy_up, bool, | |
31 | S_IWUSR | S_IRUGO); | |
32 | MODULE_PARM_DESC(ovl_check_copy_up, | |
33 | "Warn on copy-up when causing process also has a R/O fd open"); | |
34 | ||
35 | static int ovl_check_fd(const void *data, struct file *f, unsigned int fd) | |
36 | { | |
37 | const struct dentry *dentry = data; | |
38 | ||
45063097 | 39 | if (file_inode(f) == d_inode(dentry)) |
fb5bb2c3 DH |
40 | pr_warn_ratelimited("overlayfs: Warning: Copying up %pD, but open R/O on fd %u which will cease to be coherent [pid=%d %s]\n", |
41 | f, fd, current->pid, current->comm); | |
42 | return 0; | |
43 | } | |
44 | ||
45 | /* | |
46 | * Check the fds open by this process and warn if something like the following | |
47 | * scenario is about to occur: | |
48 | * | |
49 | * fd1 = open("foo", O_RDONLY); | |
50 | * fd2 = open("foo", O_RDWR); | |
51 | */ | |
52 | static void ovl_do_check_copy_up(struct dentry *dentry) | |
53 | { | |
54 | if (ovl_check_copy_up) | |
55 | iterate_fd(current->files, 0, ovl_check_fd, dentry); | |
56 | } | |
57 | ||
e9be9d5e MS |
58 | int ovl_copy_xattr(struct dentry *old, struct dentry *new) |
59 | { | |
e4ad29fa VC |
60 | ssize_t list_size, size, value_size = 0; |
61 | char *buf, *name, *value = NULL; | |
62 | int uninitialized_var(error); | |
8b326c61 | 63 | size_t slen; |
e9be9d5e | 64 | |
5d6c3191 AG |
65 | if (!(old->d_inode->i_opflags & IOP_XATTR) || |
66 | !(new->d_inode->i_opflags & IOP_XATTR)) | |
e9be9d5e MS |
67 | return 0; |
68 | ||
69 | list_size = vfs_listxattr(old, NULL, 0); | |
70 | if (list_size <= 0) { | |
71 | if (list_size == -EOPNOTSUPP) | |
72 | return 0; | |
73 | return list_size; | |
74 | } | |
75 | ||
76 | buf = kzalloc(list_size, GFP_KERNEL); | |
77 | if (!buf) | |
78 | return -ENOMEM; | |
79 | ||
e9be9d5e MS |
80 | list_size = vfs_listxattr(old, buf, list_size); |
81 | if (list_size <= 0) { | |
82 | error = list_size; | |
e4ad29fa | 83 | goto out; |
e9be9d5e MS |
84 | } |
85 | ||
8b326c61 MS |
86 | for (name = buf; list_size; name += slen) { |
87 | slen = strnlen(name, list_size) + 1; | |
88 | ||
89 | /* underlying fs providing us with an broken xattr list? */ | |
90 | if (WARN_ON(slen > list_size)) { | |
91 | error = -EIO; | |
92 | break; | |
93 | } | |
94 | list_size -= slen; | |
95 | ||
0956254a MS |
96 | if (ovl_is_private_xattr(name)) |
97 | continue; | |
e4ad29fa VC |
98 | retry: |
99 | size = vfs_getxattr(old, name, value, value_size); | |
100 | if (size == -ERANGE) | |
101 | size = vfs_getxattr(old, name, NULL, 0); | |
102 | ||
97daf8b9 | 103 | if (size < 0) { |
e9be9d5e | 104 | error = size; |
e4ad29fa | 105 | break; |
e9be9d5e | 106 | } |
e4ad29fa VC |
107 | |
108 | if (size > value_size) { | |
109 | void *new; | |
110 | ||
111 | new = krealloc(value, size, GFP_KERNEL); | |
112 | if (!new) { | |
113 | error = -ENOMEM; | |
114 | break; | |
115 | } | |
116 | value = new; | |
117 | value_size = size; | |
118 | goto retry; | |
119 | } | |
120 | ||
121ab822 VG |
121 | error = security_inode_copy_up_xattr(name); |
122 | if (error < 0 && error != -EOPNOTSUPP) | |
123 | break; | |
124 | if (error == 1) { | |
125 | error = 0; | |
126 | continue; /* Discard */ | |
127 | } | |
e9be9d5e MS |
128 | error = vfs_setxattr(new, name, value, size, 0); |
129 | if (error) | |
e4ad29fa | 130 | break; |
e9be9d5e | 131 | } |
e9be9d5e MS |
132 | kfree(value); |
133 | out: | |
134 | kfree(buf); | |
135 | return error; | |
136 | } | |
137 | ||
138 | static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len) | |
139 | { | |
140 | struct file *old_file; | |
141 | struct file *new_file; | |
142 | loff_t old_pos = 0; | |
143 | loff_t new_pos = 0; | |
144 | int error = 0; | |
145 | ||
146 | if (len == 0) | |
147 | return 0; | |
148 | ||
0480334f | 149 | old_file = ovl_path_open(old, O_LARGEFILE | O_RDONLY); |
e9be9d5e MS |
150 | if (IS_ERR(old_file)) |
151 | return PTR_ERR(old_file); | |
152 | ||
0480334f | 153 | new_file = ovl_path_open(new, O_LARGEFILE | O_WRONLY); |
e9be9d5e MS |
154 | if (IS_ERR(new_file)) { |
155 | error = PTR_ERR(new_file); | |
156 | goto out_fput; | |
157 | } | |
158 | ||
2ea98466 AG |
159 | /* Try to use clone_file_range to clone up within the same fs */ |
160 | error = vfs_clone_file_range(old_file, 0, new_file, 0, len); | |
161 | if (!error) | |
162 | goto out; | |
163 | /* Couldn't clone, so now we try to copy the data */ | |
164 | error = 0; | |
165 | ||
e9be9d5e MS |
166 | /* FIXME: copy up sparse files efficiently */ |
167 | while (len) { | |
168 | size_t this_len = OVL_COPY_UP_CHUNK_SIZE; | |
169 | long bytes; | |
170 | ||
171 | if (len < this_len) | |
172 | this_len = len; | |
173 | ||
174 | if (signal_pending_state(TASK_KILLABLE, current)) { | |
175 | error = -EINTR; | |
176 | break; | |
177 | } | |
178 | ||
179 | bytes = do_splice_direct(old_file, &old_pos, | |
180 | new_file, &new_pos, | |
181 | this_len, SPLICE_F_MOVE); | |
182 | if (bytes <= 0) { | |
183 | error = bytes; | |
184 | break; | |
185 | } | |
186 | WARN_ON(old_pos != new_pos); | |
187 | ||
188 | len -= bytes; | |
189 | } | |
2ea98466 | 190 | out: |
641089c1 MS |
191 | if (!error) |
192 | error = vfs_fsync(new_file, 0); | |
e9be9d5e MS |
193 | fput(new_file); |
194 | out_fput: | |
195 | fput(old_file); | |
196 | return error; | |
197 | } | |
198 | ||
e9be9d5e MS |
199 | static int ovl_set_timestamps(struct dentry *upperdentry, struct kstat *stat) |
200 | { | |
201 | struct iattr attr = { | |
202 | .ia_valid = | |
203 | ATTR_ATIME | ATTR_MTIME | ATTR_ATIME_SET | ATTR_MTIME_SET, | |
204 | .ia_atime = stat->atime, | |
205 | .ia_mtime = stat->mtime, | |
206 | }; | |
207 | ||
208 | return notify_change(upperdentry, &attr, NULL); | |
209 | } | |
210 | ||
211 | int ovl_set_attr(struct dentry *upperdentry, struct kstat *stat) | |
212 | { | |
213 | int err = 0; | |
214 | ||
215 | if (!S_ISLNK(stat->mode)) { | |
216 | struct iattr attr = { | |
217 | .ia_valid = ATTR_MODE, | |
218 | .ia_mode = stat->mode, | |
219 | }; | |
220 | err = notify_change(upperdentry, &attr, NULL); | |
221 | } | |
222 | if (!err) { | |
223 | struct iattr attr = { | |
224 | .ia_valid = ATTR_UID | ATTR_GID, | |
225 | .ia_uid = stat->uid, | |
226 | .ia_gid = stat->gid, | |
227 | }; | |
228 | err = notify_change(upperdentry, &attr, NULL); | |
229 | } | |
230 | if (!err) | |
231 | ovl_set_timestamps(upperdentry, stat); | |
232 | ||
233 | return err; | |
e9be9d5e MS |
234 | } |
235 | ||
3a1e819b AG |
236 | static struct ovl_fh *ovl_encode_fh(struct dentry *lower, uuid_be *uuid) |
237 | { | |
238 | struct ovl_fh *fh; | |
239 | int fh_type, fh_len, dwords; | |
240 | void *buf; | |
241 | int buflen = MAX_HANDLE_SZ; | |
242 | ||
243 | buf = kmalloc(buflen, GFP_TEMPORARY); | |
244 | if (!buf) | |
245 | return ERR_PTR(-ENOMEM); | |
246 | ||
247 | /* | |
248 | * We encode a non-connectable file handle for non-dir, because we | |
249 | * only need to find the lower inode number and we don't want to pay | |
250 | * the price or reconnecting the dentry. | |
251 | */ | |
252 | dwords = buflen >> 2; | |
253 | fh_type = exportfs_encode_fh(lower, buf, &dwords, 0); | |
254 | buflen = (dwords << 2); | |
255 | ||
256 | fh = ERR_PTR(-EIO); | |
257 | if (WARN_ON(fh_type < 0) || | |
258 | WARN_ON(buflen > MAX_HANDLE_SZ) || | |
259 | WARN_ON(fh_type == FILEID_INVALID)) | |
260 | goto out; | |
261 | ||
262 | BUILD_BUG_ON(MAX_HANDLE_SZ + offsetof(struct ovl_fh, fid) > 255); | |
263 | fh_len = offsetof(struct ovl_fh, fid) + buflen; | |
264 | fh = kmalloc(fh_len, GFP_KERNEL); | |
265 | if (!fh) { | |
266 | fh = ERR_PTR(-ENOMEM); | |
267 | goto out; | |
268 | } | |
269 | ||
270 | fh->version = OVL_FH_VERSION; | |
271 | fh->magic = OVL_FH_MAGIC; | |
272 | fh->type = fh_type; | |
273 | fh->flags = OVL_FH_FLAG_CPU_ENDIAN; | |
274 | fh->len = fh_len; | |
275 | fh->uuid = *uuid; | |
276 | memcpy(fh->fid, buf, buflen); | |
277 | ||
278 | out: | |
279 | kfree(buf); | |
280 | return fh; | |
281 | } | |
282 | ||
283 | static int ovl_set_origin(struct dentry *dentry, struct dentry *lower, | |
284 | struct dentry *upper) | |
285 | { | |
286 | struct super_block *sb = lower->d_sb; | |
287 | uuid_be *uuid = (uuid_be *) &sb->s_uuid; | |
288 | const struct ovl_fh *fh = NULL; | |
289 | int err; | |
290 | ||
291 | /* | |
292 | * When lower layer doesn't support export operations store a 'null' fh, | |
293 | * so we can use the overlay.origin xattr to distignuish between a copy | |
294 | * up and a pure upper inode. | |
295 | */ | |
296 | if (sb->s_export_op && sb->s_export_op->fh_to_dentry && | |
297 | uuid_be_cmp(*uuid, NULL_UUID_BE)) { | |
298 | fh = ovl_encode_fh(lower, uuid); | |
299 | if (IS_ERR(fh)) | |
300 | return PTR_ERR(fh); | |
301 | } | |
302 | ||
303 | err = ovl_do_setxattr(upper, OVL_XATTR_ORIGIN, fh, fh ? fh->len : 0, 0); | |
304 | kfree(fh); | |
305 | ||
306 | return err; | |
307 | } | |
308 | ||
e9be9d5e MS |
309 | static int ovl_copy_up_locked(struct dentry *workdir, struct dentry *upperdir, |
310 | struct dentry *dentry, struct path *lowerpath, | |
42f269b9 | 311 | struct kstat *stat, const char *link, |
d8514d8e | 312 | struct kstat *pstat, bool tmpfile) |
e9be9d5e MS |
313 | { |
314 | struct inode *wdir = workdir->d_inode; | |
315 | struct inode *udir = upperdir->d_inode; | |
316 | struct dentry *newdentry = NULL; | |
317 | struct dentry *upper = NULL; | |
42f269b9 | 318 | struct dentry *temp = NULL; |
e9be9d5e | 319 | int err; |
d8ad8b49 VG |
320 | const struct cred *old_creds = NULL; |
321 | struct cred *new_creds = NULL; | |
32a3d848 AV |
322 | struct cattr cattr = { |
323 | /* Can't properly set mode on creation because of the umask */ | |
324 | .mode = stat->mode & S_IFMT, | |
325 | .rdev = stat->rdev, | |
326 | .link = link | |
327 | }; | |
e9be9d5e | 328 | |
e9be9d5e MS |
329 | upper = lookup_one_len(dentry->d_name.name, upperdir, |
330 | dentry->d_name.len); | |
331 | err = PTR_ERR(upper); | |
332 | if (IS_ERR(upper)) | |
42f269b9 | 333 | goto out; |
e9be9d5e | 334 | |
d8ad8b49 VG |
335 | err = security_inode_copy_up(dentry, &new_creds); |
336 | if (err < 0) | |
42f269b9 | 337 | goto out1; |
d8ad8b49 VG |
338 | |
339 | if (new_creds) | |
340 | old_creds = override_creds(new_creds); | |
341 | ||
d8514d8e AG |
342 | if (tmpfile) |
343 | temp = ovl_do_tmpfile(upperdir, stat->mode); | |
344 | else | |
345 | temp = ovl_lookup_temp(workdir, dentry); | |
d8514d8e | 346 | err = 0; |
8137ae26 AG |
347 | if (IS_ERR(temp)) { |
348 | err = PTR_ERR(temp); | |
349 | temp = NULL; | |
350 | } | |
351 | ||
352 | if (!err && !tmpfile) | |
d8514d8e | 353 | err = ovl_create_real(wdir, temp, &cattr, NULL, true); |
d8ad8b49 VG |
354 | |
355 | if (new_creds) { | |
356 | revert_creds(old_creds); | |
357 | put_cred(new_creds); | |
358 | } | |
359 | ||
e9be9d5e MS |
360 | if (err) |
361 | goto out2; | |
362 | ||
363 | if (S_ISREG(stat->mode)) { | |
364 | struct path upperpath; | |
f134f244 | 365 | |
e9be9d5e MS |
366 | ovl_path_upper(dentry, &upperpath); |
367 | BUG_ON(upperpath.dentry != NULL); | |
42f269b9 | 368 | upperpath.dentry = temp; |
e9be9d5e | 369 | |
01ad3eb8 AG |
370 | if (tmpfile) { |
371 | inode_unlock(udir); | |
372 | err = ovl_copy_up_data(lowerpath, &upperpath, | |
373 | stat->size); | |
374 | inode_lock_nested(udir, I_MUTEX_PARENT); | |
375 | } else { | |
376 | err = ovl_copy_up_data(lowerpath, &upperpath, | |
377 | stat->size); | |
378 | } | |
e9be9d5e | 379 | |
e9be9d5e MS |
380 | if (err) |
381 | goto out_cleanup; | |
382 | } | |
383 | ||
42f269b9 | 384 | err = ovl_copy_xattr(lowerpath->dentry, temp); |
e9be9d5e MS |
385 | if (err) |
386 | goto out_cleanup; | |
387 | ||
42f269b9 AG |
388 | inode_lock(temp->d_inode); |
389 | err = ovl_set_attr(temp, stat); | |
390 | inode_unlock(temp->d_inode); | |
e9be9d5e MS |
391 | if (err) |
392 | goto out_cleanup; | |
393 | ||
3a1e819b AG |
394 | /* |
395 | * Store identifier of lower inode in upper inode xattr to | |
396 | * allow lookup of the copy up origin inode. | |
397 | */ | |
398 | err = ovl_set_origin(dentry, lowerpath->dentry, temp); | |
399 | if (err) | |
400 | goto out_cleanup; | |
401 | ||
d8514d8e AG |
402 | if (tmpfile) |
403 | err = ovl_do_link(temp, udir, upper, true); | |
404 | else | |
405 | err = ovl_do_rename(wdir, temp, udir, upper, 0); | |
e9be9d5e MS |
406 | if (err) |
407 | goto out_cleanup; | |
408 | ||
d8514d8e | 409 | newdentry = dget(tmpfile ? upper : temp); |
e9be9d5e | 410 | ovl_dentry_update(dentry, newdentry); |
39b681f8 | 411 | ovl_inode_update(d_inode(dentry), d_inode(newdentry)); |
42f269b9 AG |
412 | |
413 | /* Restore timestamps on parent (best effort) */ | |
414 | ovl_set_timestamps(upperdir, pstat); | |
e9be9d5e | 415 | out2: |
42f269b9 | 416 | dput(temp); |
e9be9d5e | 417 | out1: |
42f269b9 | 418 | dput(upper); |
e9be9d5e MS |
419 | out: |
420 | return err; | |
421 | ||
422 | out_cleanup: | |
d8514d8e AG |
423 | if (!tmpfile) |
424 | ovl_cleanup(wdir, temp); | |
ab79efab | 425 | goto out2; |
e9be9d5e MS |
426 | } |
427 | ||
428 | /* | |
429 | * Copy up a single dentry | |
430 | * | |
a6c60655 MS |
431 | * All renames start with copy up of source if necessary. The actual |
432 | * rename will only proceed once the copy up was successful. Copy up uses | |
433 | * upper parent i_mutex for exclusion. Since rename can change d_parent it | |
434 | * is possible that the copy up will lock the old parent. At that point | |
435 | * the file will have already been copied up anyway. | |
e9be9d5e | 436 | */ |
9aba6521 AG |
437 | static int ovl_copy_up_one(struct dentry *parent, struct dentry *dentry, |
438 | struct path *lowerpath, struct kstat *stat) | |
e9be9d5e | 439 | { |
7764235b | 440 | DEFINE_DELAYED_CALL(done); |
e9be9d5e MS |
441 | struct dentry *workdir = ovl_workdir(dentry); |
442 | int err; | |
443 | struct kstat pstat; | |
444 | struct path parentpath; | |
7764235b | 445 | struct dentry *lowerdentry = lowerpath->dentry; |
e9be9d5e | 446 | struct dentry *upperdir; |
7764235b | 447 | const char *link = NULL; |
d8514d8e | 448 | struct ovl_fs *ofs = dentry->d_sb->s_fs_info; |
e9be9d5e | 449 | |
cc6f67bc MS |
450 | if (WARN_ON(!workdir)) |
451 | return -EROFS; | |
452 | ||
7764235b | 453 | ovl_do_check_copy_up(lowerdentry); |
fb5bb2c3 | 454 | |
e9be9d5e MS |
455 | ovl_path_upper(parent, &parentpath); |
456 | upperdir = parentpath.dentry; | |
457 | ||
a528d35e DH |
458 | err = vfs_getattr(&parentpath, &pstat, |
459 | STATX_ATIME | STATX_MTIME, AT_STATX_SYNC_AS_STAT); | |
e9be9d5e MS |
460 | if (err) |
461 | return err; | |
462 | ||
463 | if (S_ISLNK(stat->mode)) { | |
7764235b | 464 | link = vfs_get_link(lowerdentry, &done); |
e9be9d5e MS |
465 | if (IS_ERR(link)) |
466 | return PTR_ERR(link); | |
467 | } | |
468 | ||
01ad3eb8 AG |
469 | /* Should we copyup with O_TMPFILE or with workdir? */ |
470 | if (S_ISREG(stat->mode) && ofs->tmpfile) { | |
471 | err = ovl_copy_up_start(dentry); | |
472 | /* err < 0: interrupted, err > 0: raced with another copy-up */ | |
473 | if (unlikely(err)) { | |
474 | pr_debug("ovl_copy_up_start(%pd2) = %i\n", dentry, err); | |
475 | if (err > 0) | |
476 | err = 0; | |
477 | goto out_done; | |
478 | } | |
479 | ||
480 | inode_lock_nested(upperdir->d_inode, I_MUTEX_PARENT); | |
481 | err = ovl_copy_up_locked(workdir, upperdir, dentry, lowerpath, | |
482 | stat, link, &pstat, true); | |
483 | inode_unlock(upperdir->d_inode); | |
484 | ovl_copy_up_end(dentry); | |
485 | goto out_done; | |
486 | } | |
487 | ||
e9be9d5e MS |
488 | err = -EIO; |
489 | if (lock_rename(workdir, upperdir) != NULL) { | |
490 | pr_err("overlayfs: failed to lock workdir+upperdir\n"); | |
491 | goto out_unlock; | |
492 | } | |
a6c60655 | 493 | if (ovl_dentry_upper(dentry)) { |
0f7ff2da | 494 | /* Raced with another copy-up? Nothing to do, then... */ |
e9be9d5e | 495 | err = 0; |
0f7ff2da | 496 | goto out_unlock; |
e9be9d5e MS |
497 | } |
498 | ||
499 | err = ovl_copy_up_locked(workdir, upperdir, dentry, lowerpath, | |
01ad3eb8 | 500 | stat, link, &pstat, false); |
e9be9d5e MS |
501 | out_unlock: |
502 | unlock_rename(workdir, upperdir); | |
01ad3eb8 | 503 | out_done: |
7764235b | 504 | do_delayed_call(&done); |
e9be9d5e MS |
505 | |
506 | return err; | |
507 | } | |
508 | ||
9aba6521 | 509 | int ovl_copy_up_flags(struct dentry *dentry, int flags) |
e9be9d5e | 510 | { |
8eac98b8 VG |
511 | int err = 0; |
512 | const struct cred *old_cred = ovl_override_creds(dentry->d_sb); | |
e9be9d5e | 513 | |
e9be9d5e MS |
514 | while (!err) { |
515 | struct dentry *next; | |
516 | struct dentry *parent; | |
517 | struct path lowerpath; | |
518 | struct kstat stat; | |
519 | enum ovl_path_type type = ovl_path_type(dentry); | |
520 | ||
1afaba1e | 521 | if (OVL_TYPE_UPPER(type)) |
e9be9d5e MS |
522 | break; |
523 | ||
524 | next = dget(dentry); | |
525 | /* find the topmost dentry not yet copied up */ | |
526 | for (;;) { | |
527 | parent = dget_parent(next); | |
528 | ||
529 | type = ovl_path_type(parent); | |
1afaba1e | 530 | if (OVL_TYPE_UPPER(type)) |
e9be9d5e MS |
531 | break; |
532 | ||
533 | dput(next); | |
534 | next = parent; | |
535 | } | |
536 | ||
537 | ovl_path_lower(next, &lowerpath); | |
a528d35e DH |
538 | err = vfs_getattr(&lowerpath, &stat, |
539 | STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT); | |
9aba6521 AG |
540 | /* maybe truncate regular file. this has no effect on dirs */ |
541 | if (flags & O_TRUNC) | |
542 | stat.size = 0; | |
e9be9d5e | 543 | if (!err) |
0f7ff2da | 544 | err = ovl_copy_up_one(parent, next, &lowerpath, &stat); |
e9be9d5e MS |
545 | |
546 | dput(parent); | |
547 | dput(next); | |
548 | } | |
8eac98b8 | 549 | revert_creds(old_cred); |
e9be9d5e MS |
550 | |
551 | return err; | |
552 | } | |
9aba6521 AG |
553 | |
554 | int ovl_copy_up(struct dentry *dentry) | |
555 | { | |
556 | return ovl_copy_up_flags(dentry, 0); | |
557 | } |