[linux-2.6-block.git] / fs / hfsplus / attributes.c

// SPDX-License-Identifier: GPL-2.0
/*
 * linux/fs/hfsplus/attributes.c
 *
 * Vyacheslav Dubeyko <slava@dubeyko.com>
 *
 * Handling of records in attributes tree
 */

#include "hfsplus_fs.h"
#include "hfsplus_raw.h"

static struct kmem_cache *hfsplus_attr_tree_cachep;

int __init hfsplus_create_attr_tree_cache(void)
{
	if (hfsplus_attr_tree_cachep)
		return -EEXIST;

	hfsplus_attr_tree_cachep =
		kmem_cache_create("hfsplus_attr_cache",
			sizeof(hfsplus_attr_entry), 0,
			SLAB_HWCACHE_ALIGN, NULL);
	if (!hfsplus_attr_tree_cachep)
		return -ENOMEM;

	return 0;
}

void hfsplus_destroy_attr_tree_cache(void)
{
	kmem_cache_destroy(hfsplus_attr_tree_cachep);
}

int hfsplus_attr_bin_cmp_key(const hfsplus_btree_key *k1,
				const hfsplus_btree_key *k2)
{
	__be32 k1_cnid, k2_cnid;

	k1_cnid = k1->attr.cnid;
	k2_cnid = k2->attr.cnid;
	if (k1_cnid != k2_cnid)
		return be32_to_cpu(k1_cnid) < be32_to_cpu(k2_cnid) ? -1 : 1;

	return hfsplus_strcmp(
			(const struct hfsplus_unistr *)&k1->attr.key_name,
			(const struct hfsplus_unistr *)&k2->attr.key_name);
}

int hfsplus_attr_build_key(struct super_block *sb, hfsplus_btree_key *key,
			u32 cnid, const char *name)
{
	int len;

	memset(key, 0, sizeof(struct hfsplus_attr_key));
	key->attr.cnid = cpu_to_be32(cnid);
	if (name) {
		int res = hfsplus_asc2uni(sb,
				(struct hfsplus_unistr *)&key->attr.key_name,
				HFSPLUS_ATTR_MAX_STRLEN, name, strlen(name));
		if (res)
			return res;
		len = be16_to_cpu(key->attr.key_name.length);
	} else {
		key->attr.key_name.length = 0;
		len = 0;
	}

	/* The length of the key, as stored in key_len field, does not include
	 * the size of the key_len field itself.
	 * So, offsetof(hfsplus_attr_key, key_name) is a trick because
	 * it takes into consideration key_len field (__be16) of
	 * hfsplus_attr_key structure instead of length field (__be16) of
	 * hfsplus_attr_unistr structure.
	 */
	key->key_len =
		cpu_to_be16(offsetof(struct hfsplus_attr_key, key_name) +
				2 * len);

	return 0;
}

hfsplus_attr_entry *hfsplus_alloc_attr_entry(void)
{
	return kmem_cache_alloc(hfsplus_attr_tree_cachep, GFP_KERNEL);
}

void hfsplus_destroy_attr_entry(hfsplus_attr_entry *entry)
{
	if (entry)
		kmem_cache_free(hfsplus_attr_tree_cachep, entry);
}

#define HFSPLUS_INVALID_ATTR_RECORD -1

static int hfsplus_attr_build_record(hfsplus_attr_entry *entry, int record_type,
				u32 cnid, const void *value, size_t size)
{
	if (record_type == HFSPLUS_ATTR_FORK_DATA) {
		/*
		 * Mac OS X supports only inline data attributes.
		 * Do nothing
		 */
		memset(entry, 0, sizeof(*entry));
		return sizeof(struct hfsplus_attr_fork_data);
	} else if (record_type == HFSPLUS_ATTR_EXTENTS) {
		/*
		 * Mac OS X supports only inline data attributes.
		 * Do nothing.
		 */
		memset(entry, 0, sizeof(*entry));
		return sizeof(struct hfsplus_attr_extents);
	} else if (record_type == HFSPLUS_ATTR_INLINE_DATA) {
		u16 len;

		memset(entry, 0, sizeof(struct hfsplus_attr_inline_data));
		entry->inline_data.record_type = cpu_to_be32(record_type);
		if (size <= HFSPLUS_MAX_INLINE_DATA_SIZE)
			len = size;
		else
			return HFSPLUS_INVALID_ATTR_RECORD;
		entry->inline_data.length = cpu_to_be16(len);
		memcpy(entry->inline_data.raw_bytes, value, len);
		/*
		 * Align len on two-byte boundary.
		 * It needs to add pad byte if we have odd len.
		 */
		len = round_up(len, 2);
		return offsetof(struct hfsplus_attr_inline_data, raw_bytes) +
					len;
	} else /* invalid input */
		memset(entry, 0, sizeof(*entry));

	return HFSPLUS_INVALID_ATTR_RECORD;
}

int hfsplus_find_attr(struct super_block *sb, u32 cnid,
			const char *name, struct hfs_find_data *fd)
{
	int err = 0;

	hfs_dbg(ATTR_MOD, "find_attr: %s,%d\n", name ? name : NULL, cnid);

	if (!HFSPLUS_SB(sb)->attr_tree) {
		pr_err("attributes file doesn't exist\n");
		return -EINVAL;
	}

	if (name) {
		err = hfsplus_attr_build_key(sb, fd->search_key, cnid, name);
		if (err)
			goto failed_find_attr;
		err = hfs_brec_find(fd, hfs_find_rec_by_key);
		if (err)
			goto failed_find_attr;
	} else {
		err = hfsplus_attr_build_key(sb, fd->search_key, cnid, NULL);
		if (err)
			goto failed_find_attr;
		err = hfs_brec_find(fd, hfs_find_1st_rec_by_cnid);
		if (err)
			goto failed_find_attr;
	}

failed_find_attr:
	return err;
}

int hfsplus_attr_exists(struct inode *inode, const char *name)
{
	int err = 0;
	struct super_block *sb = inode->i_sb;
	struct hfs_find_data fd;

	if (!HFSPLUS_SB(sb)->attr_tree)
		return 0;

	err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
	if (err)
		return 0;

	err = hfsplus_find_attr(sb, inode->i_ino, name, &fd);
	if (err)
		goto attr_not_found;

	hfs_find_exit(&fd);
	return 1;

attr_not_found:
	hfs_find_exit(&fd);
	return 0;
}

int hfsplus_create_attr(struct inode *inode,
				const char *name,
				const void *value, size_t size)
{
	struct super_block *sb = inode->i_sb;
	struct hfs_find_data fd;
	hfsplus_attr_entry *entry_ptr;
	int entry_size;
	int err;

	hfs_dbg(ATTR_MOD, "create_attr: %s,%ld\n",
		name ? name : NULL, inode->i_ino);

	if (!HFSPLUS_SB(sb)->attr_tree) {
		pr_err("attributes file doesn't exist\n");
		return -EINVAL;
	}

	entry_ptr = hfsplus_alloc_attr_entry();
	if (!entry_ptr)
		return -ENOMEM;

	err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
	if (err)
		goto failed_init_create_attr;

	if (name) {
		err = hfsplus_attr_build_key(sb, fd.search_key,
						inode->i_ino, name);
		if (err)
			goto failed_create_attr;
	} else {
		err = -EINVAL;
		goto failed_create_attr;
	}

	/* Mac OS X supports only inline data attributes. */
	entry_size = hfsplus_attr_build_record(entry_ptr,
					HFSPLUS_ATTR_INLINE_DATA,
					inode->i_ino,
					value, size);
	if (entry_size == HFSPLUS_INVALID_ATTR_RECORD) {
		err = -EINVAL;
		goto failed_create_attr;
	}

	err = hfs_brec_find(&fd, hfs_find_rec_by_key);
	if (err != -ENOENT) {
		if (!err)
			err = -EEXIST;
		goto failed_create_attr;
	}

	err = hfs_brec_insert(&fd, entry_ptr, entry_size);
	if (err)
		goto failed_create_attr;

	hfsplus_mark_inode_dirty(inode, HFSPLUS_I_ATTR_DIRTY);

failed_create_attr:
	hfs_find_exit(&fd);

failed_init_create_attr:
	hfsplus_destroy_attr_entry(entry_ptr);
	return err;
}

static int __hfsplus_delete_attr(struct inode *inode, u32 cnid,
					struct hfs_find_data *fd)
{
	int err = 0;
	__be32 found_cnid, record_type;

	hfs_bnode_read(fd->bnode, &found_cnid,
			fd->keyoffset +
			offsetof(struct hfsplus_attr_key, cnid),
			sizeof(__be32));
	if (cnid != be32_to_cpu(found_cnid))
		return -ENOENT;

	hfs_bnode_read(fd->bnode, &record_type,
			fd->entryoffset, sizeof(record_type));

	switch (be32_to_cpu(record_type)) {
	case HFSPLUS_ATTR_INLINE_DATA:
		/* All is OK. Do nothing. */
		break;
	case HFSPLUS_ATTR_FORK_DATA:
	case HFSPLUS_ATTR_EXTENTS:
		pr_err("only inline data xattr are supported\n");
		return -EOPNOTSUPP;
	default:
		pr_err("invalid extended attribute record\n");
		return -ENOENT;
	}

	err = hfs_brec_remove(fd);
	if (err)
		return err;

	hfsplus_mark_inode_dirty(inode, HFSPLUS_I_ATTR_DIRTY);
	return err;
}

int hfsplus_delete_attr(struct inode *inode, const char *name)
{
	int err = 0;
	struct super_block *sb = inode->i_sb;
	struct hfs_find_data fd;

	hfs_dbg(ATTR_MOD, "delete_attr: %s,%ld\n",
		name ? name : NULL, inode->i_ino);

	if (!HFSPLUS_SB(sb)->attr_tree) {
		pr_err("attributes file doesn't exist\n");
		return -EINVAL;
	}

	err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
	if (err)
		return err;

	if (name) {
		err = hfsplus_attr_build_key(sb, fd.search_key,
						inode->i_ino, name);
		if (err)
			goto out;
	} else {
		pr_err("invalid extended attribute name\n");
		err = -EINVAL;
		goto out;
	}

	err = hfs_brec_find(&fd, hfs_find_rec_by_key);
	if (err)
		goto out;

	err = __hfsplus_delete_attr(inode, inode->i_ino, &fd);
	if (err)
		goto out;

out:
	hfs_find_exit(&fd);
	return err;
}

int hfsplus_delete_all_attrs(struct inode *dir, u32 cnid)
{
	int err = 0;
	struct hfs_find_data fd;

	hfs_dbg(ATTR_MOD, "delete_all_attrs: %d\n", cnid);

	if (!HFSPLUS_SB(dir->i_sb)->attr_tree) {
		pr_err("attributes file doesn't exist\n");
		return -EINVAL;
	}

	err = hfs_find_init(HFSPLUS_SB(dir->i_sb)->attr_tree, &fd);
	if (err)
		return err;

	for (;;) {
		err = hfsplus_find_attr(dir->i_sb, cnid, NULL, &fd);
		if (err) {
			if (err != -ENOENT)
				pr_err("xattr search failed\n");
			goto end_delete_all;
		}

		err = __hfsplus_delete_attr(dir, cnid, &fd);
		if (err)
			goto end_delete_all;
	}

end_delete_all:
	hfs_find_exit(&fd);
	return err;
}
Commit	Line	Data
b2441318	1	// SPDX-License-Identifier: GPL-2.0
3e05ca20 VD	2	/*
	3	* linux/fs/hfsplus/attributes.c
	4	*
	5	* Vyacheslav Dubeyko <slava@dubeyko.com>
	6	*
	7	* Handling of records in attributes tree
	8	*/
	9
	10	#include "hfsplus_fs.h"
	11	#include "hfsplus_raw.h"
	12
	13	static struct kmem_cache *hfsplus_attr_tree_cachep;
	14
c11e614d	15	int __init hfsplus_create_attr_tree_cache(void)
3e05ca20 VD	16	{
	17	if (hfsplus_attr_tree_cachep)
	18	return -EEXIST;
	19
	20	hfsplus_attr_tree_cachep =
	21	kmem_cache_create("hfsplus_attr_cache",
	22	sizeof(hfsplus_attr_entry), 0,
	23	SLAB_HWCACHE_ALIGN, NULL);
	24	if (!hfsplus_attr_tree_cachep)
	25	return -ENOMEM;
	26
	27	return 0;
	28	}
	29
	30	void hfsplus_destroy_attr_tree_cache(void)
	31	{
	32	kmem_cache_destroy(hfsplus_attr_tree_cachep);
	33	}
	34
	35	int hfsplus_attr_bin_cmp_key(const hfsplus_btree_key *k1,
	36	const hfsplus_btree_key *k2)
	37	{
	38	__be32 k1_cnid, k2_cnid;
	39
	40	k1_cnid = k1->attr.cnid;
	41	k2_cnid = k2->attr.cnid;
	42	if (k1_cnid != k2_cnid)
	43	return be32_to_cpu(k1_cnid) < be32_to_cpu(k2_cnid) ? -1 : 1;
	44
	45	return hfsplus_strcmp(
	46	(const struct hfsplus_unistr *)&k1->attr.key_name,
	47	(const struct hfsplus_unistr *)&k2->attr.key_name);
	48	}
	49
	50	int hfsplus_attr_build_key(struct super_block sb, hfsplus_btree_key key,
	51	u32 cnid, const char *name)
	52	{
	53	int len;
	54
	55	memset(key, 0, sizeof(struct hfsplus_attr_key));
	56	key->attr.cnid = cpu_to_be32(cnid);
	57	if (name) {
bf29e886	58	int res = hfsplus_asc2uni(sb,
3e05ca20	59	(struct hfsplus_unistr *)&key->attr.key_name,
bf29e886 HTL	60	HFSPLUS_ATTR_MAX_STRLEN, name, strlen(name));
	61	if (res)
	62	return res;
3e05ca20 VD	63	len = be16_to_cpu(key->attr.key_name.length);
	64	} else {
	65	key->attr.key_name.length = 0;
	66	len = 0;
	67	}
	68
	69	/* The length of the key, as stored in key_len field, does not include
	70	* the size of the key_len field itself.
	71	* So, offsetof(hfsplus_attr_key, key_name) is a trick because
	72	* it takes into consideration key_len field (__be16) of
	73	* hfsplus_attr_key structure instead of length field (__be16) of
	74	* hfsplus_attr_unistr structure.
	75	*/
	76	key->key_len =
	77	cpu_to_be16(offsetof(struct hfsplus_attr_key, key_name) +
	78	2 * len);
	79
	80	return 0;
	81	}
	82
3e05ca20 VD	83	hfsplus_attr_entry *hfsplus_alloc_attr_entry(void)
	84	{
	85	return kmem_cache_alloc(hfsplus_attr_tree_cachep, GFP_KERNEL);
	86	}
	87
	88	void hfsplus_destroy_attr_entry(hfsplus_attr_entry *entry)
	89	{
	90	if (entry)
	91	kmem_cache_free(hfsplus_attr_tree_cachep, entry);
	92	}
	93
	94	#define HFSPLUS_INVALID_ATTR_RECORD -1
	95
	96	static int hfsplus_attr_build_record(hfsplus_attr_entry *entry, int record_type,
	97	u32 cnid, const void *value, size_t size)
	98	{
	99	if (record_type == HFSPLUS_ATTR_FORK_DATA) {
	100	/*
	101	* Mac OS X supports only inline data attributes.
	102	* Do nothing
	103	*/
	104	memset(entry, 0, sizeof(*entry));
	105	return sizeof(struct hfsplus_attr_fork_data);
	106	} else if (record_type == HFSPLUS_ATTR_EXTENTS) {
	107	/*
	108	* Mac OS X supports only inline data attributes.
	109	* Do nothing.
	110	*/
	111	memset(entry, 0, sizeof(*entry));
	112	return sizeof(struct hfsplus_attr_extents);
	113	} else if (record_type == HFSPLUS_ATTR_INLINE_DATA) {
	114	u16 len;
	115
	116	memset(entry, 0, sizeof(struct hfsplus_attr_inline_data));
	117	entry->inline_data.record_type = cpu_to_be32(record_type);
	118	if (size <= HFSPLUS_MAX_INLINE_DATA_SIZE)
	119	len = size;
	120	else
	121	return HFSPLUS_INVALID_ATTR_RECORD;
	122	entry->inline_data.length = cpu_to_be16(len);
	123	memcpy(entry->inline_data.raw_bytes, value, len);
	124	/*
	125	* Align len on two-byte boundary.
	126	* It needs to add pad byte if we have odd len.
	127	*/
	128	len = round_up(len, 2);
	129	return offsetof(struct hfsplus_attr_inline_data, raw_bytes) +
	130	len;
	131	} else /* invalid input */
	132	memset(entry, 0, sizeof(*entry));
	133
	134	return HFSPLUS_INVALID_ATTR_RECORD;
	135	}
	136
	137	int hfsplus_find_attr(struct super_block *sb, u32 cnid,
	138	const char name, struct hfs_find_data fd)
	139	{
	140	int err = 0;
	141
c2b3e1f7	142	hfs_dbg(ATTR_MOD, "find_attr: %s,%d\n", name ? name : NULL, cnid);
3e05ca20 VD	143
3e05ca20 VD	144	if (!HFSPLUS_SB(sb)->attr_tree) {
d6142673	145	pr_err("attributes file doesn't exist\n");
3e05ca20 VD	146	return -EINVAL;
	147	}
	148
	149	if (name) {
	150	err = hfsplus_attr_build_key(sb, fd->search_key, cnid, name);
	151	if (err)
	152	goto failed_find_attr;
	153	err = hfs_brec_find(fd, hfs_find_rec_by_key);
	154	if (err)
	155	goto failed_find_attr;
	156	} else {
	157	err = hfsplus_attr_build_key(sb, fd->search_key, cnid, NULL);
	158	if (err)
	159	goto failed_find_attr;
	160	err = hfs_brec_find(fd, hfs_find_1st_rec_by_cnid);
	161	if (err)
	162	goto failed_find_attr;
	163	}
	164
	165	failed_find_attr:
	166	return err;
	167	}
	168
	169	int hfsplus_attr_exists(struct inode inode, const char name)
	170	{
	171	int err = 0;
	172	struct super_block *sb = inode->i_sb;
	173	struct hfs_find_data fd;
	174
	175	if (!HFSPLUS_SB(sb)->attr_tree)
	176	return 0;
	177
	178	err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
	179	if (err)
	180	return 0;
	181
	182	err = hfsplus_find_attr(sb, inode->i_ino, name, &fd);
	183	if (err)
	184	goto attr_not_found;
	185
	186	hfs_find_exit(&fd);
	187	return 1;
	188
	189	attr_not_found:
	190	hfs_find_exit(&fd);
	191	return 0;
	192	}
	193
	194	int hfsplus_create_attr(struct inode *inode,
	195	const char *name,
	196	const void *value, size_t size)
	197	{
	198	struct super_block *sb = inode->i_sb;
	199	struct hfs_find_data fd;
	200	hfsplus_attr_entry *entry_ptr;
	201	int entry_size;
	202	int err;
	203
c2b3e1f7	204	hfs_dbg(ATTR_MOD, "create_attr: %s,%ld\n",
3e05ca20 VD	205	name ? name : NULL, inode->i_ino);
	206
	207	if (!HFSPLUS_SB(sb)->attr_tree) {
d6142673	208	pr_err("attributes file doesn't exist\n");
3e05ca20 VD	209	return -EINVAL;
	210	}
	211
	212	entry_ptr = hfsplus_alloc_attr_entry();
	213	if (!entry_ptr)
	214	return -ENOMEM;
	215
	216	err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
	217	if (err)
	218	goto failed_init_create_attr;
	219
	220	if (name) {
	221	err = hfsplus_attr_build_key(sb, fd.search_key,
	222	inode->i_ino, name);
	223	if (err)
	224	goto failed_create_attr;
	225	} else {
	226	err = -EINVAL;
	227	goto failed_create_attr;
	228	}
	229
	230	/* Mac OS X supports only inline data attributes. */
	231	entry_size = hfsplus_attr_build_record(entry_ptr,
	232	HFSPLUS_ATTR_INLINE_DATA,
	233	inode->i_ino,
	234	value, size);
	235	if (entry_size == HFSPLUS_INVALID_ATTR_RECORD) {
	236	err = -EINVAL;
	237	goto failed_create_attr;
	238	}
	239
	240	err = hfs_brec_find(&fd, hfs_find_rec_by_key);
	241	if (err != -ENOENT) {
	242	if (!err)
	243	err = -EEXIST;
	244	goto failed_create_attr;
	245	}
	246
	247	err = hfs_brec_insert(&fd, entry_ptr, entry_size);
	248	if (err)
	249	goto failed_create_attr;
	250
	251	hfsplus_mark_inode_dirty(inode, HFSPLUS_I_ATTR_DIRTY);
	252
	253	failed_create_attr:
	254	hfs_find_exit(&fd);
	255
	256	failed_init_create_attr:
	257	hfsplus_destroy_attr_entry(entry_ptr);
	258	return err;
	259	}
	260
	261	static int __hfsplus_delete_attr(struct inode *inode, u32 cnid,
	262	struct hfs_find_data *fd)
	263	{
	264	int err = 0;
	265	__be32 found_cnid, record_type;
	266
	267	hfs_bnode_read(fd->bnode, &found_cnid,
	268	fd->keyoffset +
	269	offsetof(struct hfsplus_attr_key, cnid),
	270	sizeof(__be32));
	271	if (cnid != be32_to_cpu(found_cnid))
	272	return -ENOENT;
273
274	hfs_bnode_read(fd->bnode, &record_type,
275	fd->entryoffset, sizeof(record_type));
276
277	switch (be32_to_cpu(record_type)) {
278	case HFSPLUS_ATTR_INLINE_DATA:
279	/* All is OK. Do nothing. */
280	break;
281	case HFSPLUS_ATTR_FORK_DATA:
282	case HFSPLUS_ATTR_EXTENTS:
d6142673	283	pr_err("only inline data xattr are supported\n");
3e05ca20 VD	284	return -EOPNOTSUPP;
3e05ca20 VD	285	default:
d6142673	286	pr_err("invalid extended attribute record\n");
3e05ca20 VD	287	return -ENOENT;
	288	}
	289
	290	err = hfs_brec_remove(fd);
	291	if (err)
	292	return err;
	293
	294	hfsplus_mark_inode_dirty(inode, HFSPLUS_I_ATTR_DIRTY);
	295	return err;
	296	}
	297
	298	int hfsplus_delete_attr(struct inode inode, const char name)
	299	{
	300	int err = 0;
	301	struct super_block *sb = inode->i_sb;
	302	struct hfs_find_data fd;
	303
c2b3e1f7	304	hfs_dbg(ATTR_MOD, "delete_attr: %s,%ld\n",
3e05ca20 VD	305	name ? name : NULL, inode->i_ino);
	306
	307	if (!HFSPLUS_SB(sb)->attr_tree) {
d6142673	308	pr_err("attributes file doesn't exist\n");
3e05ca20 VD	309	return -EINVAL;
	310	}
	311
	312	err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
	313	if (err)
	314	return err;
	315
	316	if (name) {
	317	err = hfsplus_attr_build_key(sb, fd.search_key,
	318	inode->i_ino, name);
	319	if (err)
	320	goto out;
	321	} else {
d6142673	322	pr_err("invalid extended attribute name\n");
3e05ca20 VD	323	err = -EINVAL;
	324	goto out;
	325	}
	326
	327	err = hfs_brec_find(&fd, hfs_find_rec_by_key);
	328	if (err)
	329	goto out;
	330
	331	err = __hfsplus_delete_attr(inode, inode->i_ino, &fd);
	332	if (err)
	333	goto out;
	334
	335	out:
	336	hfs_find_exit(&fd);
	337	return err;
	338	}
	339
	340	int hfsplus_delete_all_attrs(struct inode *dir, u32 cnid)
	341	{
	342	int err = 0;
	343	struct hfs_find_data fd;
	344
c2b3e1f7	345	hfs_dbg(ATTR_MOD, "delete_all_attrs: %d\n", cnid);
3e05ca20 VD	346
3e05ca20 VD	347	if (!HFSPLUS_SB(dir->i_sb)->attr_tree) {
d6142673	348	pr_err("attributes file doesn't exist\n");
3e05ca20 VD	349	return -EINVAL;
	350	}
	351
	352	err = hfs_find_init(HFSPLUS_SB(dir->i_sb)->attr_tree, &fd);
	353	if (err)
	354	return err;
	355
	356	for (;;) {
	357	err = hfsplus_find_attr(dir->i_sb, cnid, NULL, &fd);
	358	if (err) {
	359	if (err != -ENOENT)
d6142673	360	pr_err("xattr search failed\n");
3e05ca20 VD	361	goto end_delete_all;
	362	}
	363
	364	err = __hfsplus_delete_attr(dir, cnid, &fd);
	365	if (err)
	366	goto end_delete_all;
	367	}
	368
	369	end_delete_all:
	370	hfs_find_exit(&fd);
	371	return err;
	372	}