[linux-2.6-block.git] / fs / afs / vl_rotate.c

// SPDX-License-Identifier: GPL-2.0-or-later
/* Handle vlserver selection and rotation.
 *
 * Copyright (C) 2018 Red Hat, Inc. All Rights Reserved.
 * Written by David Howells (dhowells@redhat.com)
 */

#include <linux/kernel.h>
#include <linux/sched.h>
#include <linux/sched/signal.h>
#include "internal.h"
#include "afs_vl.h"

/*
 * Begin an operation on a volume location server.
 */
bool afs_begin_vlserver_operation(struct afs_vl_cursor *vc, struct afs_cell *cell,
				  struct key *key)
{
	memset(vc, 0, sizeof(*vc));
	vc->cell = cell;
	vc->key = key;
	vc->error = -EDESTADDRREQ;
	vc->ac.error = SHRT_MAX;

	if (signal_pending(current)) {
		vc->error = -EINTR;
		vc->flags |= AFS_VL_CURSOR_STOP;
		return false;
	}

	return true;
}

/*
 * Begin iteration through a server list, starting with the last used server if
 * possible, or the last recorded good server if not.
 */
static bool afs_start_vl_iteration(struct afs_vl_cursor *vc)
{
	struct afs_cell *cell = vc->cell;
	unsigned int dns_lookup_count;

	if (cell->dns_source == DNS_RECORD_UNAVAILABLE ||
	    cell->dns_expiry <= ktime_get_real_seconds()) {
		dns_lookup_count = smp_load_acquire(&cell->dns_lookup_count);
		set_bit(AFS_CELL_FL_DO_LOOKUP, &cell->flags);
		queue_work(afs_wq, &cell->manager);

		if (cell->dns_source == DNS_RECORD_UNAVAILABLE) {
			if (wait_var_event_interruptible(
				    &cell->dns_lookup_count,
				    smp_load_acquire(&cell->dns_lookup_count)
				    != dns_lookup_count) < 0) {
				vc->error = -ERESTARTSYS;
				return false;
			}
		}

		/* Status load is ordered after lookup counter load */
		if (cell->dns_source == DNS_RECORD_UNAVAILABLE) {
			vc->error = -EDESTADDRREQ;
			return false;
		}
	}

	read_lock(&cell->vl_servers_lock);
	vc->server_list = afs_get_vlserverlist(
		rcu_dereference_protected(cell->vl_servers,
					  lockdep_is_held(&cell->vl_servers_lock)));
	read_unlock(&cell->vl_servers_lock);
	if (!vc->server_list->nr_servers)
		return false;

	vc->untried = (1UL << vc->server_list->nr_servers) - 1;
	vc->index = -1;
	return true;
}

/*
 * Select the vlserver to use.  May be called multiple times to rotate
 * through the vlservers.
 */
bool afs_select_vlserver(struct afs_vl_cursor *vc)
{
	struct afs_addr_list *alist;
	struct afs_vlserver *vlserver;
	struct afs_error e;
	u32 rtt;
	int error = vc->ac.error, i;

	_enter("%lx[%d],%lx[%d],%d,%d",
	       vc->untried, vc->index,
	       vc->ac.tried, vc->ac.index,
	       error, vc->ac.abort_code);

	if (vc->flags & AFS_VL_CURSOR_STOP) {
		_leave(" = f [stopped]");
		return false;
	}

	vc->nr_iterations++;

	/* Evaluate the result of the previous operation, if there was one. */
	switch (error) {
	case SHRT_MAX:
		goto start;

	default:
	case 0:
		/* Success or local failure.  Stop. */
		vc->error = error;
		vc->flags |= AFS_VL_CURSOR_STOP;
		_leave(" = f [okay/local %d]", vc->ac.error);
		return false;

	case -ECONNABORTED:
		/* The far side rejected the operation on some grounds.  This
		 * might involve the server being busy or the volume having been moved.
		 */
		switch (vc->ac.abort_code) {
		case AFSVL_IO:
		case AFSVL_BADVOLOPER:
		case AFSVL_NOMEM:
			/* The server went weird. */
			vc->error = -EREMOTEIO;
			//write_lock(&vc->cell->vl_servers_lock);
			//vc->server_list->weird_mask |= 1 << vc->index;
			//write_unlock(&vc->cell->vl_servers_lock);
			goto next_server;

		default:
			vc->error = afs_abort_to_error(vc->ac.abort_code);
			goto failed;
		}

	case -ERFKILL:
	case -EADDRNOTAVAIL:
	case -ENETUNREACH:
	case -EHOSTUNREACH:
	case -EHOSTDOWN:
	case -ECONNREFUSED:
	case -ETIMEDOUT:
	case -ETIME:
		_debug("no conn %d", error);
		vc->error = error;
		goto iterate_address;

	case -ECONNRESET:
		_debug("call reset");
		vc->error = error;
		vc->flags |= AFS_VL_CURSOR_RETRY;
		goto next_server;

	case -EOPNOTSUPP:
		_debug("notsupp");
		goto next_server;
	}

restart_from_beginning:
	_debug("restart");
	afs_end_cursor(&vc->ac);
	afs_put_vlserverlist(vc->cell->net, vc->server_list);
	vc->server_list = NULL;
	if (vc->flags & AFS_VL_CURSOR_RETRIED)
		goto failed;
	vc->flags |= AFS_VL_CURSOR_RETRIED;
start:
	_debug("start");

	if (!afs_start_vl_iteration(vc))
		goto failed;

	error = afs_send_vl_probes(vc->cell->net, vc->key, vc->server_list);
	if (error < 0)
		goto failed_set_error;

pick_server:
	_debug("pick [%lx]", vc->untried);

	error = afs_wait_for_vl_probes(vc->server_list, vc->untried);
	if (error < 0)
		goto failed_set_error;

	/* Pick the untried server with the lowest RTT. */
	vc->index = vc->server_list->preferred;
	if (test_bit(vc->index, &vc->untried))
		goto selected_server;

	vc->index = -1;
	rtt = U32_MAX;
	for (i = 0; i < vc->server_list->nr_servers; i++) {
		struct afs_vlserver *s = vc->server_list->servers[i].server;

		if (!test_bit(i, &vc->untried) || !s->probe.responded)
			continue;
		if (s->probe.rtt < rtt) {
			vc->index = i;
			rtt = s->probe.rtt;
		}
	}

	if (vc->index == -1)
		goto no_more_servers;

selected_server:
	_debug("use %d", vc->index);
	__clear_bit(vc->index, &vc->untried);

	/* We're starting on a different vlserver from the list.  We need to
	 * check it, find its address list and probe its capabilities before we
	 * use it.
	 */
	ASSERTCMP(vc->ac.alist, ==, NULL);
	vlserver = vc->server_list->servers[vc->index].server;
	vc->server = vlserver;

	_debug("USING VLSERVER: %s", vlserver->name);

	read_lock(&vlserver->lock);
	alist = rcu_dereference_protected(vlserver->addresses,
					  lockdep_is_held(&vlserver->lock));
	afs_get_addrlist(alist);
	read_unlock(&vlserver->lock);

	memset(&vc->ac, 0, sizeof(vc->ac));

	if (!vc->ac.alist)
		vc->ac.alist = alist;
	else
		afs_put_addrlist(alist);

	vc->ac.index = -1;

iterate_address:
	ASSERT(vc->ac.alist);
	/* Iterate over the current server's address list to try and find an
	 * address on which it will respond to us.
	 */
	if (!afs_iterate_addresses(&vc->ac))
		goto next_server;

	_debug("VL address %d/%d", vc->ac.index, vc->ac.alist->nr_addrs);

	_leave(" = t %pISpc", &vc->ac.alist->addrs[vc->ac.index].transport);
	return true;

next_server:
	_debug("next");
	afs_end_cursor(&vc->ac);
	goto pick_server;

no_more_servers:
	/* That's all the servers poked to no good effect.  Try again if some
	 * of them were busy.
	 */
	if (vc->flags & AFS_VL_CURSOR_RETRY)
		goto restart_from_beginning;

	e.error = -EDESTADDRREQ;
	e.responded = false;
	for (i = 0; i < vc->server_list->nr_servers; i++) {
		struct afs_vlserver *s = vc->server_list->servers[i].server;

		afs_prioritise_error(&e, READ_ONCE(s->probe.error),
				     s->probe.abort_code);
	}

failed_set_error:
	vc->error = error;
failed:
	vc->flags |= AFS_VL_CURSOR_STOP;
	afs_end_cursor(&vc->ac);
	_leave(" = f [failed %d]", vc->error);
	return false;
}

/*
 * Dump cursor state in the case of the error being EDESTADDRREQ.
 */
static void afs_vl_dump_edestaddrreq(const struct afs_vl_cursor *vc)
{
	static int count;
	int i;

	if (!IS_ENABLED(CONFIG_AFS_DEBUG_CURSOR) || count > 3)
		return;
	count++;

	rcu_read_lock();
	pr_notice("EDESTADDR occurred\n");
	pr_notice("VC: ut=%lx ix=%u ni=%hu fl=%hx err=%hd\n",
		  vc->untried, vc->index, vc->nr_iterations, vc->flags, vc->error);

	if (vc->server_list) {
		const struct afs_vlserver_list *sl = vc->server_list;
		pr_notice("VC: SL nr=%u ix=%u\n",
			  sl->nr_servers, sl->index);
		for (i = 0; i < sl->nr_servers; i++) {
			const struct afs_vlserver *s = sl->servers[i].server;
			pr_notice("VC: server %s+%hu fl=%lx E=%hd\n",
				  s->name, s->port, s->flags, s->probe.error);
			if (s->addresses) {
				const struct afs_addr_list *a =
					rcu_dereference(s->addresses);
				pr_notice("VC:  - nr=%u/%u/%u pf=%u\n",
					  a->nr_ipv4, a->nr_addrs, a->max_addrs,
					  a->preferred);
				pr_notice("VC:  - R=%lx F=%lx\n",
					  a->responded, a->failed);
				if (a == vc->ac.alist)
					pr_notice("VC:  - current\n");
			}
		}
	}

	pr_notice("AC: t=%lx ax=%u ac=%d er=%d r=%u ni=%u\n",
		  vc->ac.tried, vc->ac.index, vc->ac.abort_code, vc->ac.error,
		  vc->ac.responded, vc->ac.nr_iterations);
	rcu_read_unlock();
}

/*
 * Tidy up a volume location server cursor and unlock the vnode.
 */
int afs_end_vlserver_operation(struct afs_vl_cursor *vc)
{
	struct afs_net *net = vc->cell->net;

	if (vc->error == -EDESTADDRREQ ||
	    vc->error == -EADDRNOTAVAIL ||
	    vc->error == -ENETUNREACH ||
	    vc->error == -EHOSTUNREACH)
		afs_vl_dump_edestaddrreq(vc);

	afs_end_cursor(&vc->ac);
	afs_put_vlserverlist(net, vc->server_list);

	if (vc->error == -ECONNABORTED)
		vc->error = afs_abort_to_error(vc->ac.abort_code);

	return vc->error;
}
Commit	Line	Data
b4d0d230	1	// SPDX-License-Identifier: GPL-2.0-or-later
0a5143f2 DH	2	/* Handle vlserver selection and rotation.
	3	*
	4	* Copyright (C) 2018 Red Hat, Inc. All Rights Reserved.
	5	* Written by David Howells (dhowells@redhat.com)
0a5143f2 DH	6	*/
	7
	8	#include <linux/kernel.h>
	9	#include <linux/sched.h>
	10	#include <linux/sched/signal.h>
	11	#include "internal.h"
	12	#include "afs_vl.h"
	13
	14	/*
	15	* Begin an operation on a volume location server.
	16	*/
	17	bool afs_begin_vlserver_operation(struct afs_vl_cursor vc, struct afs_cell cell,
	18	struct key *key)
	19	{
	20	memset(vc, 0, sizeof(*vc));
	21	vc->cell = cell;
	22	vc->key = key;
	23	vc->error = -EDESTADDRREQ;
	24	vc->ac.error = SHRT_MAX;
	25
	26	if (signal_pending(current)) {
	27	vc->error = -EINTR;
	28	vc->flags \|= AFS_VL_CURSOR_STOP;
	29	return false;
	30	}
	31
	32	return true;
	33	}
	34
	35	/*
	36	* Begin iteration through a server list, starting with the last used server if
	37	* possible, or the last recorded good server if not.
	38	*/
	39	static bool afs_start_vl_iteration(struct afs_vl_cursor *vc)
	40	{
	41	struct afs_cell *cell = vc->cell;
d5c32c89	42	unsigned int dns_lookup_count;
0a5143f2	43
d5c32c89 DH	44	if (cell->dns_source == DNS_RECORD_UNAVAILABLE \|\|
	45	cell->dns_expiry <= ktime_get_real_seconds()) {
	46	dns_lookup_count = smp_load_acquire(&cell->dns_lookup_count);
	47	set_bit(AFS_CELL_FL_DO_LOOKUP, &cell->flags);
	48	queue_work(afs_wq, &cell->manager);
	49
	50	if (cell->dns_source == DNS_RECORD_UNAVAILABLE) {
	51	if (wait_var_event_interruptible(
	52	&cell->dns_lookup_count,
	53	smp_load_acquire(&cell->dns_lookup_count)
	54	!= dns_lookup_count) < 0) {
	55	vc->error = -ERESTARTSYS;
	56	return false;
	57	}
	58	}
	59
	60	/* Status load is ordered after lookup counter load */
	61	if (cell->dns_source == DNS_RECORD_UNAVAILABLE) {
	62	vc->error = -EDESTADDRREQ;
	63	return false;
	64	}
0a5143f2 DH	65	}
	66
	67	read_lock(&cell->vl_servers_lock);
	68	vc->server_list = afs_get_vlserverlist(
	69	rcu_dereference_protected(cell->vl_servers,
	70	lockdep_is_held(&cell->vl_servers_lock)));
	71	read_unlock(&cell->vl_servers_lock);
ca1cbbdc	72	if (!vc->server_list->nr_servers)
0a5143f2 DH	73	return false;
0a5143f2 DH	74
3bf0fb6f DH	75	vc->untried = (1UL << vc->server_list->nr_servers) - 1;
3bf0fb6f DH	76	vc->index = -1;
0a5143f2 DH	77	return true;
	78	}
	79
	80	/*
	81	* Select the vlserver to use. May be called multiple times to rotate
	82	* through the vlservers.
	83	*/
	84	bool afs_select_vlserver(struct afs_vl_cursor *vc)
	85	{
	86	struct afs_addr_list *alist;
	87	struct afs_vlserver *vlserver;
4584ae96	88	struct afs_error e;
3bf0fb6f	89	u32 rtt;
4584ae96	90	int error = vc->ac.error, i;
0a5143f2	91
3bf0fb6f DH	92	_enter("%lx[%d],%lx[%d],%d,%d",
	93	vc->untried, vc->index,
	94	vc->ac.tried, vc->ac.index,
0a5143f2 DH	95	error, vc->ac.abort_code);
	96
	97	if (vc->flags & AFS_VL_CURSOR_STOP) {
	98	_leave(" = f [stopped]");
	99	return false;
	100	}
	101
744bcd71 DH	102	vc->nr_iterations++;
744bcd71 DH	103
0a5143f2 DH	104	/* Evaluate the result of the previous operation, if there was one. */
	105	switch (error) {
	106	case SHRT_MAX:
	107	goto start;
	108
	109	default:
	110	case 0:
	111	/* Success or local failure. Stop. */
	112	vc->error = error;
	113	vc->flags \|= AFS_VL_CURSOR_STOP;
	114	_leave(" = f [okay/local %d]", vc->ac.error);
	115	return false;
	116
	117	case -ECONNABORTED:
	118	/* The far side rejected the operation on some grounds. This
	119	* might involve the server being busy or the volume having been moved.
	120	*/
	121	switch (vc->ac.abort_code) {
	122	case AFSVL_IO:
	123	case AFSVL_BADVOLOPER:
	124	case AFSVL_NOMEM:
	125	/* The server went weird. */
	126	vc->error = -EREMOTEIO;
	127	//write_lock(&vc->cell->vl_servers_lock);
	128	//vc->server_list->weird_mask \|= 1 << vc->index;
	129	//write_unlock(&vc->cell->vl_servers_lock);
	130	goto next_server;
	131
	132	default:
	133	vc->error = afs_abort_to_error(vc->ac.abort_code);
	134	goto failed;
	135	}
	136
4584ae96 DH	137	case -ERFKILL:
4584ae96 DH	138	case -EADDRNOTAVAIL:
0a5143f2 DH	139	case -ENETUNREACH:
0a5143f2 DH	140	case -EHOSTUNREACH:
4584ae96	141	case -EHOSTDOWN:
0a5143f2 DH	142	case -ECONNREFUSED:
	143	case -ETIMEDOUT:
	144	case -ETIME:
	145	_debug("no conn %d", error);
	146	vc->error = error;
	147	goto iterate_address;
	148
	149	case -ECONNRESET:
	150	_debug("call reset");
	151	vc->error = error;
	152	vc->flags \|= AFS_VL_CURSOR_RETRY;
	153	goto next_server;
6dfdf536 DH	154
	155	case -EOPNOTSUPP:
	156	_debug("notsupp");
	157	goto next_server;
0a5143f2 DH	158	}
	159
	160	restart_from_beginning:
	161	_debug("restart");
	162	afs_end_cursor(&vc->ac);
	163	afs_put_vlserverlist(vc->cell->net, vc->server_list);
	164	vc->server_list = NULL;
	165	if (vc->flags & AFS_VL_CURSOR_RETRIED)
	166	goto failed;
	167	vc->flags \|= AFS_VL_CURSOR_RETRIED;
	168	start:
	169	_debug("start");
	170
0a5143f2 DH	171	if (!afs_start_vl_iteration(vc))
	172	goto failed;
	173
3bf0fb6f DH	174	error = afs_send_vl_probes(vc->cell->net, vc->key, vc->server_list);
	175	if (error < 0)
	176	goto failed_set_error;
	177
	178	pick_server:
	179	_debug("pick [%lx]", vc->untried);
	180
	181	error = afs_wait_for_vl_probes(vc->server_list, vc->untried);
	182	if (error < 0)
	183	goto failed_set_error;
	184
	185	/* Pick the untried server with the lowest RTT. */
	186	vc->index = vc->server_list->preferred;
	187	if (test_bit(vc->index, &vc->untried))
	188	goto selected_server;
	189
	190	vc->index = -1;
	191	rtt = U32_MAX;
	192	for (i = 0; i < vc->server_list->nr_servers; i++) {
	193	struct afs_vlserver *s = vc->server_list->servers[i].server;
	194
	195	if (!test_bit(i, &vc->untried) \|\| !s->probe.responded)
	196	continue;
	197	if (s->probe.rtt < rtt) {
	198	vc->index = i;
	199	rtt = s->probe.rtt;
	200	}
	201	}
	202
	203	if (vc->index == -1)
	204	goto no_more_servers;
	205
	206	selected_server:
	207	_debug("use %d", vc->index);
	208	__clear_bit(vc->index, &vc->untried);
	209
0a5143f2 DH	210	/* We're starting on a different vlserver from the list. We need to
	211	* check it, find its address list and probe its capabilities before we
	212	* use it.
	213	*/
	214	ASSERTCMP(vc->ac.alist, ==, NULL);
	215	vlserver = vc->server_list->servers[vc->index].server;
3bf0fb6f	216	vc->server = vlserver;
0a5143f2 DH	217
	218	_debug("USING VLSERVER: %s", vlserver->name);
	219
	220	read_lock(&vlserver->lock);
	221	alist = rcu_dereference_protected(vlserver->addresses,
	222	lockdep_is_held(&vlserver->lock));
	223	afs_get_addrlist(alist);
	224	read_unlock(&vlserver->lock);
	225
	226	memset(&vc->ac, 0, sizeof(vc->ac));
	227
0a5143f2 DH	228	if (!vc->ac.alist)
	229	vc->ac.alist = alist;
	230	else
	231	afs_put_addrlist(alist);
	232
3bf0fb6f	233	vc->ac.index = -1;
0a5143f2 DH	234
	235	iterate_address:
	236	ASSERT(vc->ac.alist);
0a5143f2 DH	237	/* Iterate over the current server's address list to try and find an
	238	* address on which it will respond to us.
	239	*/
	240	if (!afs_iterate_addresses(&vc->ac))
	241	goto next_server;
	242
3bf0fb6f DH	243	_debug("VL address %d/%d", vc->ac.index, vc->ac.alist->nr_addrs);
3bf0fb6f DH	244
2feeaf84	245	_leave(" = t %pISpc", &vc->ac.alist->addrs[vc->ac.index].transport);
0a5143f2 DH	246	return true;
	247
	248	next_server:
	249	_debug("next");
	250	afs_end_cursor(&vc->ac);
3bf0fb6f	251	goto pick_server;
0a5143f2	252
3bf0fb6f	253	no_more_servers:
0a5143f2 DH	254	/* That's all the servers poked to no good effect. Try again if some
	255	* of them were busy.
	256	*/
	257	if (vc->flags & AFS_VL_CURSOR_RETRY)
	258	goto restart_from_beginning;
	259
4584ae96 DH	260	e.error = -EDESTADDRREQ;
4584ae96 DH	261	e.responded = false;
3bf0fb6f DH	262	for (i = 0; i < vc->server_list->nr_servers; i++) {
3bf0fb6f DH	263	struct afs_vlserver *s = vc->server_list->servers[i].server;
3bf0fb6f	264
4584ae96 DH	265	afs_prioritise_error(&e, READ_ONCE(s->probe.error),
4584ae96 DH	266	s->probe.abort_code);
3bf0fb6f DH	267	}
3bf0fb6f DH	268
3bf0fb6f DH	269	failed_set_error:
3bf0fb6f DH	270	vc->error = error;
0a5143f2 DH	271	failed:
	272	vc->flags \|= AFS_VL_CURSOR_STOP;
	273	afs_end_cursor(&vc->ac);
	274	_leave(" = f [failed %d]", vc->error);
	275	return false;
	276	}
	277
744bcd71 DH	278	/*
	279	* Dump cursor state in the case of the error being EDESTADDRREQ.
	280	*/
	281	static void afs_vl_dump_edestaddrreq(const struct afs_vl_cursor *vc)
	282	{
	283	static int count;
	284	int i;
	285
	286	if (!IS_ENABLED(CONFIG_AFS_DEBUG_CURSOR) \|\| count > 3)
	287	return;
	288	count++;
	289
	290	rcu_read_lock();
	291	pr_notice("EDESTADDR occurred\n");
3bf0fb6f DH	292	pr_notice("VC: ut=%lx ix=%u ni=%hu fl=%hx err=%hd\n",
3bf0fb6f DH	293	vc->untried, vc->index, vc->nr_iterations, vc->flags, vc->error);
744bcd71 DH	294
	295	if (vc->server_list) {
	296	const struct afs_vlserver_list *sl = vc->server_list;
	297	pr_notice("VC: SL nr=%u ix=%u\n",
	298	sl->nr_servers, sl->index);
	299	for (i = 0; i < sl->nr_servers; i++) {
	300	const struct afs_vlserver *s = sl->servers[i].server;
3bf0fb6f DH	301	pr_notice("VC: server %s+%hu fl=%lx E=%hd\n",
3bf0fb6f DH	302	s->name, s->port, s->flags, s->probe.error);
744bcd71 DH	303	if (s->addresses) {
	304	const struct afs_addr_list *a =
	305	rcu_dereference(s->addresses);
3bf0fb6f	306	pr_notice("VC: - nr=%u/%u/%u pf=%u\n",
744bcd71	307	a->nr_ipv4, a->nr_addrs, a->max_addrs,
3bf0fb6f	308	a->preferred);
be59167c DH	309	pr_notice("VC: - R=%lx F=%lx\n",
be59167c DH	310	a->responded, a->failed);
744bcd71 DH	311	if (a == vc->ac.alist)
	312	pr_notice("VC: - current\n");
	313	}
	314	}
	315	}
	316
3bf0fb6f DH	317	pr_notice("AC: t=%lx ax=%u ac=%d er=%d r=%u ni=%u\n",
	318	vc->ac.tried, vc->ac.index, vc->ac.abort_code, vc->ac.error,
	319	vc->ac.responded, vc->ac.nr_iterations);
744bcd71 DH	320	rcu_read_unlock();
	321	}
	322
0a5143f2 DH	323	/*
	324	* Tidy up a volume location server cursor and unlock the vnode.
	325	*/
	326	int afs_end_vlserver_operation(struct afs_vl_cursor *vc)
	327	{
	328	struct afs_net *net = vc->cell->net;
	329
744bcd71	330	if (vc->error == -EDESTADDRREQ \|\|
4584ae96	331	vc->error == -EADDRNOTAVAIL \|\|
744bcd71 DH	332	vc->error == -ENETUNREACH \|\|
	333	vc->error == -EHOSTUNREACH)
	334	afs_vl_dump_edestaddrreq(vc);
	335
0a5143f2 DH	336	afs_end_cursor(&vc->ac);
	337	afs_put_vlserverlist(net, vc->server_list);
	338
	339	if (vc->error == -ECONNABORTED)
	340	vc->error = afs_abort_to_error(vc->ac.abort_code);
	341
	342	return vc->error;
	343	}