projects / linux-block.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
bonding: remove bond->lock from bond_arp_rcv
[linux-block.git] / drivers / net / bonding / bond_options.c
CommitLineData
72be35fe
JP		 1/*
2 * drivers/net/bond/bond_options.c - bonding options
3 * Copyright (c) 2013 Jiri Pirko <jiri@resnulli.us>
eecdaa6e 4 * Copyright (c) 2013 Scott Feldman <sfeldma@cumulusnetworks.com>
72be35fe
JP		 5 *
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation; either version 2 of the License, or
9 * (at your option) any later version.
10 */
11
12#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
13
14#include <linux/errno.h>
15#include <linux/if.h>
d9e32b21
JP		 16#include <linux/netdevice.h>
17#include <linux/rwlock.h>
18#include <linux/rcupdate.h>
09117362 19#include <linux/ctype.h>
4fb0ef58 20#include <linux/inet.h>
72be35fe
JP		 21#include "bonding.h"
22
2b3798d5
NA		 23static struct bond_opt_value bond_mode_tbl[] = {
24 { "balance-rr", BOND_MODE_ROUNDROBIN, BOND_VALFLAG_DEFAULT},
25 { "active-backup", BOND_MODE_ACTIVEBACKUP, 0},
26 { "balance-xor", BOND_MODE_XOR, 0},
27 { "broadcast", BOND_MODE_BROADCAST, 0},
28 { "802.3ad", BOND_MODE_8023AD, 0},
29 { "balance-tlb", BOND_MODE_TLB, 0},
30 { "balance-alb", BOND_MODE_ALB, 0},
31 { NULL, -1, 0},
32};
33
aa59d851
NA		 34static struct bond_opt_value bond_pps_tbl[] = {
35 { "default", 1, BOND_VALFLAG_DEFAULT},
36 { "maxval", USHRT_MAX, BOND_VALFLAG_MAX},
37 { NULL, -1, 0},
38};
39
a4b32ce7
NA		 40static struct bond_opt_value bond_xmit_hashtype_tbl[] = {
41 { "layer2", BOND_XMIT_POLICY_LAYER2, BOND_VALFLAG_DEFAULT},
42 { "layer3+4", BOND_XMIT_POLICY_LAYER34, 0},
43 { "layer2+3", BOND_XMIT_POLICY_LAYER23, 0},
44 { "encap2+3", BOND_XMIT_POLICY_ENCAP23, 0},
45 { "encap3+4", BOND_XMIT_POLICY_ENCAP34, 0},
46 { NULL, -1, 0},
47};
48
16228881
NA		 49static struct bond_opt_value bond_arp_validate_tbl[] = {
50 { "none", BOND_ARP_VALIDATE_NONE, BOND_VALFLAG_DEFAULT},
51 { "active", BOND_ARP_VALIDATE_ACTIVE, 0},
52 { "backup", BOND_ARP_VALIDATE_BACKUP, 0},
53 { "all", BOND_ARP_VALIDATE_ALL, 0},
54 { NULL, -1, 0},
55};
56
edf36b24
NA		 57static struct bond_opt_value bond_arp_all_targets_tbl[] = {
58 { "any", BOND_ARP_TARGETS_ANY, BOND_VALFLAG_DEFAULT},
59 { "all", BOND_ARP_TARGETS_ALL, 0},
60 { NULL, -1, 0},
61};
62
1df6b6aa
NA		 63static struct bond_opt_value bond_fail_over_mac_tbl[] = {
64 { "none", BOND_FOM_NONE, BOND_VALFLAG_DEFAULT},
65 { "active", BOND_FOM_ACTIVE, 0},
66 { "follow", BOND_FOM_FOLLOW, 0},
67 { NULL, -1, 0},
68};
69
7bdb04ed
NA		 70static struct bond_opt_value bond_intmax_tbl[] = {
71 { "off", 0, BOND_VALFLAG_DEFAULT},
72 { "maxval", INT_MAX, BOND_VALFLAG_MAX},
73};
74
d3131de7
NA		 75static struct bond_opt_value bond_lacp_rate_tbl[] = {
76 { "slow", AD_LACP_SLOW, 0},
77 { "fast", AD_LACP_FAST, 0},
78 { NULL, -1, 0},
79};
80
9e5f5eeb
NA		 81static struct bond_opt_value bond_ad_select_tbl[] = {
82 { "stable", BOND_AD_STABLE, BOND_VALFLAG_DEFAULT},
83 { "bandwidth", BOND_AD_BANDWIDTH, 0},
84 { "count", BOND_AD_COUNT, 0},
85 { NULL, -1, 0},
86};
87
ef56becb
NA		 88static struct bond_opt_value bond_num_peer_notif_tbl[] = {
89 { "off", 0, 0},
90 { "maxval", 255, BOND_VALFLAG_MAX},
91 { "default", 1, BOND_VALFLAG_DEFAULT},
92 { NULL, -1, 0}
93};
94
388d3a6d
NA		 95static struct bond_opt_value bond_primary_reselect_tbl[] = {
96 { "always", BOND_PRI_RESELECT_ALWAYS, BOND_VALFLAG_DEFAULT},
97 { "better", BOND_PRI_RESELECT_BETTER, 0},
98 { "failure", BOND_PRI_RESELECT_FAILURE, 0},
99 { NULL, -1},
100};
101
0fff0608
NA		 102static struct bond_opt_value bond_use_carrier_tbl[] = {
103 { "off", 0, 0},
104 { "on", 1, BOND_VALFLAG_DEFAULT},
105 { NULL, -1, 0}
106};
107
3df01162
NA		 108static struct bond_opt_value bond_all_slaves_active_tbl[] = {
109 { "off", 0, BOND_VALFLAG_DEFAULT},
110 { "on", 1, 0},
111 { NULL, -1, 0}
112};
113
105c8fb6
NA		 114static struct bond_opt_value bond_resend_igmp_tbl[] = {
115 { "off", 0, 0},
116 { "maxval", 255, BOND_VALFLAG_MAX},
117 { "default", 1, BOND_VALFLAG_DEFAULT},
118 { NULL, -1, 0}
119};
120
4325b374
NA		 121static struct bond_opt_value bond_lp_interval_tbl[] = {
122 { "minval", 1, BOND_VALFLAG_MIN | BOND_VALFLAG_DEFAULT},
123 { "maxval", INT_MAX, BOND_VALFLAG_MAX},
124};
125
09117362 126static struct bond_option bond_opts[] = {
2b3798d5
NA		 127 [BOND_OPT_MODE] = {
128 .id = BOND_OPT_MODE,
129 .name = "mode",
130 .desc = "bond device mode",
131 .flags = BOND_OPTFLAG_NOSLAVES | BOND_OPTFLAG_IFDOWN,
132 .values = bond_mode_tbl,
133 .set = bond_option_mode_set
134 },
aa59d851
NA		 135 [BOND_OPT_PACKETS_PER_SLAVE] = {
136 .id = BOND_OPT_PACKETS_PER_SLAVE,
137 .name = "packets_per_slave",
138 .desc = "Packets to send per slave in RR mode",
139 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ROUNDROBIN)),
140 .values = bond_pps_tbl,
141 .set = bond_option_pps_set
142 },
a4b32ce7
NA		 143 [BOND_OPT_XMIT_HASH] = {
144 .id = BOND_OPT_XMIT_HASH,
145 .name = "xmit_hash_policy",
146 .desc = "balance-xor and 802.3ad hashing method",
147 .values = bond_xmit_hashtype_tbl,
148 .set = bond_option_xmit_hash_policy_set
149 },
16228881
NA		 150 [BOND_OPT_ARP_VALIDATE] = {
151 .id = BOND_OPT_ARP_VALIDATE,
152 .name = "arp_validate",
153 .desc = "validate src/dst of ARP probes",
154 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP)),
155 .values = bond_arp_validate_tbl,
156 .set = bond_option_arp_validate_set
157 },
edf36b24
NA		 158 [BOND_OPT_ARP_ALL_TARGETS] = {
159 .id = BOND_OPT_ARP_ALL_TARGETS,
160 .name = "arp_all_targets",
161 .desc = "fail on any/all arp targets timeout",
162 .values = bond_arp_all_targets_tbl,
163 .set = bond_option_arp_all_targets_set
164 },
1df6b6aa
NA		 165 [BOND_OPT_FAIL_OVER_MAC] = {
166 .id = BOND_OPT_FAIL_OVER_MAC,
167 .name = "fail_over_mac",
168 .desc = "For active-backup, do not set all slaves to the same MAC",
169 .flags = BOND_OPTFLAG_NOSLAVES,
170 .values = bond_fail_over_mac_tbl,
171 .set = bond_option_fail_over_mac_set
172 },
7bdb04ed
NA		 173 [BOND_OPT_ARP_INTERVAL] = {
174 .id = BOND_OPT_ARP_INTERVAL,
175 .name = "arp_interval",
176 .desc = "arp interval in milliseconds",
177 .unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
178 BIT(BOND_MODE_ALB),
179 .values = bond_intmax_tbl,
180 .set = bond_option_arp_interval_set
181 },
4fb0ef58
NA		 182 [BOND_OPT_ARP_TARGETS] = {
183 .id = BOND_OPT_ARP_TARGETS,
184 .name = "arp_ip_target",
185 .desc = "arp targets in n.n.n.n form",
186 .flags = BOND_OPTFLAG_RAWVAL,
187 .set = bond_option_arp_ip_targets_set
188 },
25a9b54a
NA		 189 [BOND_OPT_DOWNDELAY] = {
190 .id = BOND_OPT_DOWNDELAY,
191 .name = "downdelay",
192 .desc = "Delay before considering link down, in milliseconds",
193 .values = bond_intmax_tbl,
194 .set = bond_option_downdelay_set
195 },
e4994612
NA		 196 [BOND_OPT_UPDELAY] = {
197 .id = BOND_OPT_UPDELAY,
198 .name = "updelay",
199 .desc = "Delay before considering link up, in milliseconds",
200 .values = bond_intmax_tbl,
201 .set = bond_option_updelay_set
202 },
d3131de7
NA		 203 [BOND_OPT_LACP_RATE] = {
204 .id = BOND_OPT_LACP_RATE,
205 .name = "lacp_rate",
206 .desc = "LACPDU tx rate to request from 802.3ad partner",
207 .flags = BOND_OPTFLAG_IFDOWN,
208 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)),
209 .values = bond_lacp_rate_tbl,
210 .set = bond_option_lacp_rate_set
211 },
633ddc9e
NA		 212 [BOND_OPT_MINLINKS] = {
213 .id = BOND_OPT_MINLINKS,
214 .name = "min_links",
215 .desc = "Minimum number of available links before turning on carrier",
216 .values = bond_intmax_tbl,
217 .set = bond_option_min_links_set
218 },
9e5f5eeb
NA		 219 [BOND_OPT_AD_SELECT] = {
220 .id = BOND_OPT_AD_SELECT,
221 .name = "ad_select",
222 .desc = "803.ad aggregation selection logic",
223 .flags = BOND_OPTFLAG_IFDOWN,
224 .values = bond_ad_select_tbl,
225 .set = bond_option_ad_select_set
226 },
ef56becb
NA		 227 [BOND_OPT_NUM_PEER_NOTIF] = {
228 .id = BOND_OPT_NUM_PEER_NOTIF,
229 .name = "num_unsol_na",
230 .desc = "Number of peer notifications to send on failover event",
231 .values = bond_num_peer_notif_tbl,
232 .set = bond_option_num_peer_notif_set
233 },
b98d9c66
NA		 234 [BOND_OPT_MIIMON] = {
235 .id = BOND_OPT_MIIMON,
236 .name = "miimon",
237 .desc = "Link check interval in milliseconds",
238 .values = bond_intmax_tbl,
239 .set = bond_option_miimon_set
240 },
180222f0
NA		 241 [BOND_OPT_PRIMARY] = {
242 .id = BOND_OPT_PRIMARY,
243 .name = "primary",
244 .desc = "Primary network device to use",
245 .flags = BOND_OPTFLAG_RAWVAL,
246 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
247 BIT(BOND_MODE_TLB) |
248 BIT(BOND_MODE_ALB)),
249 .set = bond_option_primary_set
250 },
388d3a6d
NA		 251 [BOND_OPT_PRIMARY_RESELECT] = {
252 .id = BOND_OPT_PRIMARY_RESELECT,
253 .name = "primary_reselect",
254 .desc = "Reselect primary slave once it comes up",
255 .values = bond_primary_reselect_tbl,
256 .set = bond_option_primary_reselect_set
257 },
0fff0608
NA		 258 [BOND_OPT_USE_CARRIER] = {
259 .id = BOND_OPT_USE_CARRIER,
260 .name = "use_carrier",
261 .desc = "Use netif_carrier_ok (vs MII ioctls) in miimon",
262 .values = bond_use_carrier_tbl,
263 .set = bond_option_use_carrier_set
264 },
d1fbd3ed
NA		 265 [BOND_OPT_ACTIVE_SLAVE] = {
266 .id = BOND_OPT_ACTIVE_SLAVE,
267 .name = "active_slave",
268 .desc = "Currently active slave",
269 .flags = BOND_OPTFLAG_RAWVAL,
270 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
271 BIT(BOND_MODE_TLB) |
272 BIT(BOND_MODE_ALB)),
273 .set = bond_option_active_slave_set
274 },
24089ba1
NA		 275 [BOND_OPT_QUEUE_ID] = {
276 .id = BOND_OPT_QUEUE_ID,
277 .name = "queue_id",
278 .desc = "Set queue id of a slave",
279 .flags = BOND_OPTFLAG_RAWVAL,
280 .set = bond_option_queue_id_set
281 },
3df01162
NA		 282 [BOND_OPT_ALL_SLAVES_ACTIVE] = {
283 .id = BOND_OPT_ALL_SLAVES_ACTIVE,
284 .name = "all_slaves_active",
285 .desc = "Keep all frames received on an interface by setting active flag for all slaves",
286 .values = bond_all_slaves_active_tbl,
287 .set = bond_option_all_slaves_active_set
288 },
105c8fb6
NA		 289 [BOND_OPT_RESEND_IGMP] = {
290 .id = BOND_OPT_RESEND_IGMP,
291 .name = "resend_igmp",
292 .desc = "Number of IGMP membership reports to send on link failure",
293 .values = bond_resend_igmp_tbl,
294 .set = bond_option_resend_igmp_set
295 },
4325b374
NA		 296 [BOND_OPT_LP_INTERVAL] = {
297 .id = BOND_OPT_LP_INTERVAL,
298 .name = "lp_interval",
299 .desc = "The number of seconds between instances where the bonding driver sends learning packets to each slave's peer switch",
300 .values = bond_lp_interval_tbl,
301 .set = bond_option_lp_interval_set
302 },
0e2e5b66
NA		 303 [BOND_OPT_SLAVES] = {
304 .id = BOND_OPT_SLAVES,
305 .name = "slaves",
306 .desc = "Slave membership management",
307 .flags = BOND_OPTFLAG_RAWVAL,
308 .set = bond_option_slaves_set
309 },
09117362
NA		 310 { }
311};
312
313/* Searches for a value in opt's values[] table */
314struct bond_opt_value *bond_opt_get_val(unsigned int option, u64 val)
315{
316 struct bond_option *opt;
317 int i;
318
319 opt = bond_opt_get(option);
320 if (WARN_ON(!opt))
321 return NULL;
322 for (i = 0; opt->values && opt->values[i].string; i++)
323 if (opt->values[i].value == val)
324 return &opt->values[i];
325
326 return NULL;
327}
328
329/* Searches for a value in opt's values[] table which matches the flagmask */
330static struct bond_opt_value *bond_opt_get_flags(const struct bond_option *opt,
331 u32 flagmask)
332{
333 int i;
334
335 for (i = 0; opt->values && opt->values[i].string; i++)
336 if (opt->values[i].flags & flagmask)
337 return &opt->values[i];
338
339 return NULL;
340}
341
342/* If maxval is missing then there's no range to check. In case minval is
343 * missing then it's considered to be 0.
344 */
345static bool bond_opt_check_range(const struct bond_option *opt, u64 val)
346{
347 struct bond_opt_value *minval, *maxval;
348
349 minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
350 maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
351 if (!maxval || (minval && val < minval->value) || val > maxval->value)
352 return false;
353
354 return true;
355}
356
357/**
358 * bond_opt_parse - parse option value
359 * @opt: the option to parse against
360 * @val: value to parse
361 *
362 * This function tries to extract the value from @val and check if it's
363 * a possible match for the option and returns NULL if a match isn't found,
364 * or the struct_opt_value that matched. It also strips the new line from
365 * @val->string if it's present.
366 */
367struct bond_opt_value *bond_opt_parse(const struct bond_option *opt,
368 struct bond_opt_value *val)
369{
370 char *p, valstr[BOND_OPT_MAX_NAMELEN + 1] = { 0, };
371 struct bond_opt_value *tbl, *ret = NULL;
372 bool checkval;
373 int i, rv;
374
375 /* No parsing if the option wants a raw val */
376 if (opt->flags & BOND_OPTFLAG_RAWVAL)
377 return val;
378
379 tbl = opt->values;
380 if (!tbl)
381 goto out;
382
383 /* ULLONG_MAX is used to bypass string processing */
384 checkval = val->value != ULLONG_MAX;
385 if (!checkval) {
386 if (!val->string)
387 goto out;
388 p = strchr(val->string, '\n');
389 if (p)
390 *p = '\0';
391 for (p = val->string; *p; p++)
392 if (!(isdigit(*p) || isspace(*p)))
393 break;
394 /* The following code extracts the string to match or the value
395 * and sets checkval appropriately
396 */
397 if (*p) {
398 rv = sscanf(val->string, "%32s", valstr);
399 } else {
400 rv = sscanf(val->string, "%llu", &val->value);
401 checkval = true;
402 }
403 if (!rv)
404 goto out;
405 }
406
407 for (i = 0; tbl[i].string; i++) {
408 /* Check for exact match */
409 if (checkval) {
410 if (val->value == tbl[i].value)
411 ret = &tbl[i];
412 } else {
413 if (!strcmp(valstr, "default") &&
414 (tbl[i].flags & BOND_VALFLAG_DEFAULT))
415 ret = &tbl[i];
416
417 if (!strcmp(valstr, tbl[i].string))
418 ret = &tbl[i];
419 }
420 /* Found an exact match */
421 if (ret)
422 goto out;
423 }
424 /* Possible range match */
425 if (checkval && bond_opt_check_range(opt, val->value))
426 ret = val;
427out:
428 return ret;
429}
430
431/* Check opt's dependencies against bond mode and currently set options */
432static int bond_opt_check_deps(struct bonding *bond,
433 const struct bond_option *opt)
434{
435 struct bond_params *params = &bond->params;
436
437 if (test_bit(params->mode, &opt->unsuppmodes))
438 return -EACCES;
439 if ((opt->flags & BOND_OPTFLAG_NOSLAVES) && bond_has_slaves(bond))
440 return -ENOTEMPTY;
441 if ((opt->flags & BOND_OPTFLAG_IFDOWN) && (bond->dev->flags & IFF_UP))
442 return -EBUSY;
443
444 return 0;
445}
446
447static void bond_opt_dep_print(struct bonding *bond,
448 const struct bond_option *opt)
449{
2b3798d5 450 struct bond_opt_value *modeval;
09117362
NA		 451 struct bond_params *params;
452
453 params = &bond->params;
2b3798d5 454 modeval = bond_opt_get_val(BOND_OPT_MODE, params->mode);
09117362 455 if (test_bit(params->mode, &opt->unsuppmodes))
2b3798d5
NA		 456 pr_err("%s: option %s: mode dependency failed, not supported in mode %s(%llu)\n",
457 bond->dev->name, opt->name,
458 modeval->string, modeval->value);
09117362
NA		 459}
460
461static void bond_opt_error_interpret(struct bonding *bond,
462 const struct bond_option *opt,
463 int error, struct bond_opt_value *val)
464{
465 struct bond_opt_value *minval, *maxval;
466 char *p;
467
468 switch (error) {
469 case -EINVAL:
470 if (val) {
471 if (val->string) {
472 /* sometimes RAWVAL opts may have new lines */
473 p = strchr(val->string, '\n');
474 if (p)
475 *p = '\0';
90194264 476 pr_err("%s: option %s: invalid value (%s)\n",
09117362
NA		 477 bond->dev->name, opt->name, val->string);
478 } else {
90194264 479 pr_err("%s: option %s: invalid value (%llu)\n",
09117362
NA		 480 bond->dev->name, opt->name, val->value);
481 }
482 }
483 minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
484 maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
485 if (!maxval)
486 break;
90194264 487 pr_err("%s: option %s: allowed values %llu - %llu\n",
09117362
NA		 488 bond->dev->name, opt->name, minval ? minval->value : 0,
489 maxval->value);
490 break;
491 case -EACCES:
492 bond_opt_dep_print(bond, opt);
493 break;
494 case -ENOTEMPTY:
90194264 495 pr_err("%s: option %s: unable to set because the bond device has slaves\n",
09117362
NA		 496 bond->dev->name, opt->name);
497 break;
498 case -EBUSY:
90194264 499 pr_err("%s: option %s: unable to set because the bond device is up\n",
09117362
NA		 500 bond->dev->name, opt->name);
501 break;
502 default:
503 break;
504 }
505}
506
507/**
508 * __bond_opt_set - set a bonding option
509 * @bond: target bond device
510 * @option: option to set
511 * @val: value to set it to
512 *
513 * This function is used to change the bond's option value, it can be
514 * used for both enabling/changing an option and for disabling it. RTNL lock
515 * must be obtained before calling this function.
516 */
517int __bond_opt_set(struct bonding *bond,
518 unsigned int option, struct bond_opt_value *val)
519{
520 struct bond_opt_value *retval = NULL;
521 const struct bond_option *opt;
522 int ret = -ENOENT;
523
524 ASSERT_RTNL();
525
526 opt = bond_opt_get(option);
527 if (WARN_ON(!val) || WARN_ON(!opt))
528 goto out;
529 ret = bond_opt_check_deps(bond, opt);
530 if (ret)
531 goto out;
532 retval = bond_opt_parse(opt, val);
533 if (!retval) {
534 ret = -EINVAL;
535 goto out;
536 }
537 ret = opt->set(bond, retval);
538out:
539 if (ret)
540 bond_opt_error_interpret(bond, opt, ret, val);
541
542 return ret;
543}
544
545/**
546 * bond_opt_tryset_rtnl - try to acquire rtnl and call __bond_opt_set
547 * @bond: target bond device
548 * @option: option to set
549 * @buf: value to set it to
550 *
551 * This function tries to acquire RTNL without blocking and if successful
552 * calls __bond_opt_set. It is mainly used for sysfs option manipulation.
553 */
554int bond_opt_tryset_rtnl(struct bonding *bond, unsigned int option, char *buf)
555{
556 struct bond_opt_value optval;
557 int ret;
558
559 if (!rtnl_trylock())
560 return restart_syscall();
561 bond_opt_initstr(&optval, buf);
562 ret = __bond_opt_set(bond, option, &optval);
563 rtnl_unlock();
564
565 return ret;
566}
567
568/**
569 * bond_opt_get - get a pointer to an option
570 * @option: option for which to return a pointer
571 *
572 * This function checks if option is valid and if so returns a pointer
573 * to its entry in the bond_opts[] option array.
574 */
575struct bond_option *bond_opt_get(unsigned int option)
576{
577 if (!BOND_OPT_VALID(option))
578 return NULL;
579
580 return &bond_opts[option];
581}
582
2b3798d5 583int bond_option_mode_set(struct bonding *bond, struct bond_opt_value *newval)
72be35fe 584{
2b3798d5 585 if (BOND_NO_USES_ARP(newval->value) && bond->params.arp_interval) {
fe9d04af 586 pr_info("%s: %s mode is incompatible with arp monitoring, start mii monitoring\n",
2b3798d5 587 bond->dev->name, newval->string);
fe9d04af 588 /* disable arp monitoring */
589 bond->params.arp_interval = 0;
590 /* set miimon to default value */
591 bond->params.miimon = BOND_DEFAULT_MIIMON;
90194264 592 pr_info("%s: Setting MII monitoring interval to %d\n",
fe9d04af 593 bond->dev->name, bond->params.miimon);
72be35fe
JP		 594 }
595
596 /* don't cache arp_validate between modes */
597 bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
2b3798d5
NA		 598 bond->params.mode = newval->value;
599
72be35fe
JP		 600 return 0;
601}
d9e32b21 602
752d48b5
JP		 603static struct net_device *__bond_option_active_slave_get(struct bonding *bond,
604 struct slave *slave)
605{
606 return USES_PRIMARY(bond->params.mode) && slave ? slave->dev : NULL;
607}
608
609struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond)
610{
611 struct slave *slave = rcu_dereference(bond->curr_active_slave);
612
613 return __bond_option_active_slave_get(bond, slave);
614}
615
616struct net_device *bond_option_active_slave_get(struct bonding *bond)
617{
618 return __bond_option_active_slave_get(bond, bond->curr_active_slave);
619}
620
d9e32b21 621int bond_option_active_slave_set(struct bonding *bond,
d1fbd3ed 622 struct bond_opt_value *newval)
d9e32b21 623{
d1fbd3ed
NA		 624 char ifname[IFNAMSIZ] = { 0, };
625 struct net_device *slave_dev;
d9e32b21
JP		 626 int ret = 0;
627
d1fbd3ed
NA		 628 sscanf(newval->string, "%15s", ifname); /* IFNAMSIZ */
629 if (!strlen(ifname) || newval->string[0] == '\n') {
630 slave_dev = NULL;
631 } else {
632 slave_dev = __dev_get_by_name(dev_net(bond->dev), ifname);
633 if (!slave_dev)
634 return -ENODEV;
635 }
636
d9e32b21
JP		 637 if (slave_dev) {
638 if (!netif_is_bond_slave(slave_dev)) {
90194264 639 pr_err("Device %s is not bonding slave\n",
d9e32b21
JP		 640 slave_dev->name);
641 return -EINVAL;
642 }
643
644 if (bond->dev != netdev_master_upper_dev_get(slave_dev)) {
90194264 645 pr_err("%s: Device %s is not our slave\n",
d9e32b21
JP		 646 bond->dev->name, slave_dev->name);
647 return -EINVAL;
648 }
649 }
650
d9e32b21 651 block_netpoll_tx();
d9e32b21
JP		 652 write_lock_bh(&bond->curr_slave_lock);
653
654 /* check to see if we are clearing active */
655 if (!slave_dev) {
90194264 656 pr_info("%s: Clearing current active slave\n", bond->dev->name);
d9e32b21
JP		 657 rcu_assign_pointer(bond->curr_active_slave, NULL);
658 bond_select_active_slave(bond);
659 } else {
660 struct slave *old_active = bond->curr_active_slave;
661 struct slave *new_active = bond_slave_get_rtnl(slave_dev);
662
663 BUG_ON(!new_active);
664
665 if (new_active == old_active) {
666 /* do nothing */
90194264 667 pr_info("%s: %s is already the current active slave\n",
d9e32b21
JP		 668 bond->dev->name, new_active->dev->name);
669 } else {
670 if (old_active && (new_active->link == BOND_LINK_UP) &&
671 IS_UP(new_active->dev)) {
90194264 672 pr_info("%s: Setting %s as active slave\n",
d9e32b21
JP		 673 bond->dev->name, new_active->dev->name);
674 bond_change_active_slave(bond, new_active);
675 } else {
90194264 676 pr_err("%s: Could not set %s as active slave; either %s is down or the link is down\n",
d9e32b21
JP		 677 bond->dev->name, new_active->dev->name,
678 new_active->dev->name);
679 ret = -EINVAL;
680 }
681 }
682 }
683
684 write_unlock_bh(&bond->curr_slave_lock);
d9e32b21 685 unblock_netpoll_tx();
d1fbd3ed 686
d9e32b21
JP		 687 return ret;
688}
eecdaa6e 689
b98d9c66 690int bond_option_miimon_set(struct bonding *bond, struct bond_opt_value *newval)
eecdaa6e 691{
90194264 692 pr_info("%s: Setting MII monitoring interval to %llu\n",
b98d9c66
NA		 693 bond->dev->name, newval->value);
694 bond->params.miimon = newval->value;
eecdaa6e 695 if (bond->params.updelay)
90194264 696 pr_info("%s: Note: Updating updelay (to %d) since it is a multiple of the miimon value\n",
eecdaa6e 697 bond->dev->name,
698 bond->params.updelay * bond->params.miimon);
699 if (bond->params.downdelay)
90194264 700 pr_info("%s: Note: Updating downdelay (to %d) since it is a multiple of the miimon value\n",
eecdaa6e 701 bond->dev->name,
702 bond->params.downdelay * bond->params.miimon);
b98d9c66 703 if (newval->value && bond->params.arp_interval) {
90194264 704 pr_info("%s: MII monitoring cannot be used with ARP monitoring - disabling ARP monitoring...\n",
eecdaa6e 705 bond->dev->name);
706 bond->params.arp_interval = 0;
707 if (bond->params.arp_validate)
708 bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
709 }
710 if (bond->dev->flags & IFF_UP) {
711 /* If the interface is up, we may need to fire off
712 * the MII timer. If the interface is down, the
713 * timer will get fired off when the open function
714 * is called.
715 */
b98d9c66 716 if (!newval->value) {
eecdaa6e 717 cancel_delayed_work_sync(&bond->mii_work);
718 } else {
719 cancel_delayed_work_sync(&bond->arp_work);
720 queue_delayed_work(bond->wq, &bond->mii_work, 0);
721 }
722 }
b98d9c66 723
eecdaa6e 724 return 0;
725}
25852e29 726
e4994612 727int bond_option_updelay_set(struct bonding *bond, struct bond_opt_value *newval)
25852e29 728{
0681a282
NA		 729 int value = newval->value;
730
e4994612 731 if (!bond->params.miimon) {
25852e29 732 pr_err("%s: Unable to set up delay as MII monitoring is disabled\n",
733 bond->dev->name);
734 return -EPERM;
735 }
0681a282
NA		 736 if ((value % bond->params.miimon) != 0) {
737 pr_warn("%s: Warning: up delay (%d) is not a multiple of miimon (%d), updelay rounded to %d ms\n",
738 bond->dev->name, value,
e4994612 739 bond->params.miimon,
0681a282 740 (value / bond->params.miimon) *
e4994612 741 bond->params.miimon);
25852e29 742 }
0681a282 743 bond->params.updelay = value / bond->params.miimon;
90194264
JP		 744 pr_info("%s: Setting up delay to %d\n",
745 bond->dev->name, bond->params.updelay * bond->params.miimon);
25852e29 746
747 return 0;
748}
c7461f9b 749
25a9b54a
NA		 750int bond_option_downdelay_set(struct bonding *bond,
751 struct bond_opt_value *newval)
c7461f9b 752{
0681a282
NA		 753 int value = newval->value;
754
25a9b54a 755 if (!bond->params.miimon) {
c7461f9b 756 pr_err("%s: Unable to set down delay as MII monitoring is disabled\n",
757 bond->dev->name);
758 return -EPERM;
759 }
0681a282
NA		 760 if ((value % bond->params.miimon) != 0) {
761 pr_warn("%s: Warning: down delay (%d) is not a multiple of miimon (%d), delay rounded to %d ms\n",
762 bond->dev->name, value,
25a9b54a 763 bond->params.miimon,
0681a282 764 (value / bond->params.miimon) *
25a9b54a 765 bond->params.miimon);
c7461f9b 766 }
0681a282 767 bond->params.downdelay = value / bond->params.miimon;
90194264
JP		 768 pr_info("%s: Setting down delay to %d\n",
769 bond->dev->name, bond->params.downdelay * bond->params.miimon);
c7461f9b 770
771 return 0;
772}
9f53e14e 773
0fff0608
NA		 774int bond_option_use_carrier_set(struct bonding *bond,
775 struct bond_opt_value *newval)
9f53e14e 776{
90194264 777 pr_info("%s: Setting use_carrier to %llu\n",
0fff0608
NA		 778 bond->dev->name, newval->value);
779 bond->params.use_carrier = newval->value;
9f53e14e 780
781 return 0;
782}
06151dbc 783
7bdb04ed
NA		 784int bond_option_arp_interval_set(struct bonding *bond,
785 struct bond_opt_value *newval)
06151dbc 786{
90194264 787 pr_info("%s: Setting ARP monitoring interval to %llu\n",
7bdb04ed
NA		 788 bond->dev->name, newval->value);
789 bond->params.arp_interval = newval->value;
790 if (newval->value) {
06151dbc 791 if (bond->params.miimon) {
90194264 792 pr_info("%s: ARP monitoring cannot be used with MII monitoring. %s Disabling MII monitoring\n",
06151dbc 793 bond->dev->name, bond->dev->name);
794 bond->params.miimon = 0;
795 }
796 if (!bond->params.arp_targets[0])
90194264 797 pr_info("%s: ARP monitoring has been set up, but no ARP targets have been specified\n",
06151dbc 798 bond->dev->name);
799 }
800 if (bond->dev->flags & IFF_UP) {
801 /* If the interface is up, we may need to fire off
802 * the ARP timer. If the interface is down, the
803 * timer will get fired off when the open function
804 * is called.
805 */
7bdb04ed 806 if (!newval->value) {
06151dbc 807 if (bond->params.arp_validate)
808 bond->recv_probe = NULL;
809 cancel_delayed_work_sync(&bond->arp_work);
810 } else {
811 /* arp_validate can be set only in active-backup mode */
812 if (bond->params.arp_validate)
813 bond->recv_probe = bond_arp_rcv;
814 cancel_delayed_work_sync(&bond->mii_work);
815 queue_delayed_work(bond->wq, &bond->arp_work, 0);
816 }
817 }
818
819 return 0;
820}
7f28fa10 821
822static void _bond_options_arp_ip_target_set(struct bonding *bond, int slot,
823 __be32 target,
824 unsigned long last_rx)
825{
826 __be32 *targets = bond->params.arp_targets;
827 struct list_head *iter;
828 struct slave *slave;
829
830 if (slot >= 0 && slot < BOND_MAX_ARP_TARGETS) {
831 bond_for_each_slave(bond, slave, iter)
832 slave->target_last_arp_rx[slot] = last_rx;
833 targets[slot] = target;
834 }
835}
836
837static int _bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
838{
839 __be32 *targets = bond->params.arp_targets;
840 int ind;
841
842 if (IS_IP_TARGET_UNUSABLE_ADDRESS(target)) {
843 pr_err("%s: invalid ARP target %pI4 specified for addition\n",
844 bond->dev->name, &target);
845 return -EINVAL;
846 }
847
848 if (bond_get_targets_ip(targets, target) != -1) { /* dup */
849 pr_err("%s: ARP target %pI4 is already present\n",
850 bond->dev->name, &target);
851 return -EINVAL;
852 }
853
854 ind = bond_get_targets_ip(targets, 0); /* first free slot */
855 if (ind == -1) {
90194264 856 pr_err("%s: ARP target table is full!\n", bond->dev->name);
7f28fa10 857 return -EINVAL;
858 }
859
90194264 860 pr_info("%s: Adding ARP target %pI4\n", bond->dev->name, &target);
7f28fa10 861
862 _bond_options_arp_ip_target_set(bond, ind, target, jiffies);
863
864 return 0;
865}
866
867int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
868{
869 int ret;
870
871 /* not to race with bond_arp_rcv */
872 write_lock_bh(&bond->lock);
873 ret = _bond_option_arp_ip_target_add(bond, target);
874 write_unlock_bh(&bond->lock);
875
876 return ret;
877}
878
879int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target)
880{
881 __be32 *targets = bond->params.arp_targets;
882 struct list_head *iter;
883 struct slave *slave;
884 unsigned long *targets_rx;
885 int ind, i;
886
887 if (IS_IP_TARGET_UNUSABLE_ADDRESS(target)) {
888 pr_err("%s: invalid ARP target %pI4 specified for removal\n",
889 bond->dev->name, &target);
890 return -EINVAL;
891 }
892
893 ind = bond_get_targets_ip(targets, target);
894 if (ind == -1) {
90194264 895 pr_err("%s: unable to remove nonexistent ARP target %pI4\n",
7f28fa10 896 bond->dev->name, &target);
897 return -EINVAL;
898 }
899
900 if (ind == 0 && !targets[1] && bond->params.arp_interval)
90194264 901 pr_warn("%s: Removing last arp target with arp_interval on\n",
7f28fa10 902 bond->dev->name);
903
90194264 904 pr_info("%s: Removing ARP target %pI4\n", bond->dev->name, &target);
7f28fa10 905
906 /* not to race with bond_arp_rcv */
907 write_lock_bh(&bond->lock);
908
909 bond_for_each_slave(bond, slave, iter) {
910 targets_rx = slave->target_last_arp_rx;
911 for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
912 targets_rx[i] = targets_rx[i+1];
913 targets_rx[i] = 0;
914 }
915 for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
916 targets[i] = targets[i+1];
917 targets[i] = 0;
918
919 write_unlock_bh(&bond->lock);
920
921 return 0;
922}
923
4fb0ef58 924void bond_option_arp_ip_targets_clear(struct bonding *bond)
7f28fa10 925{
4fb0ef58 926 int i;
7f28fa10 927
928 /* not to race with bond_arp_rcv */
929 write_lock_bh(&bond->lock);
7f28fa10 930 for (i = 0; i < BOND_MAX_ARP_TARGETS; i++)
931 _bond_options_arp_ip_target_set(bond, i, 0, 0);
4fb0ef58
NA		 932 write_unlock_bh(&bond->lock);
933}
7f28fa10 934
4fb0ef58
NA		 935int bond_option_arp_ip_targets_set(struct bonding *bond,
936 struct bond_opt_value *newval)
937{
938 int ret = -EPERM;
939 __be32 target;
940
941 if (newval->string) {
942 if (!in4_pton(newval->string+1, -1, (u8 *)&target, -1, NULL)) {
943 pr_err("%s: invalid ARP target %pI4 specified\n",
944 bond->dev->name, &target);
945 return ret;
946 }
947 if (newval->string[0] == '+')
948 ret = bond_option_arp_ip_target_add(bond, target);
949 else if (newval->string[0] == '-')
950 ret = bond_option_arp_ip_target_rem(bond, target);
951 else
90194264 952 pr_err("no command found in arp_ip_targets file for bond %s - use +<addr> or -<addr>\n",
4fb0ef58
NA		 953 bond->dev->name);
954 } else {
955 target = newval->value;
956 ret = bond_option_arp_ip_target_add(bond, target);
7f28fa10 957 }
958
7f28fa10 959 return ret;
960}
29c49482 961
16228881
NA		 962int bond_option_arp_validate_set(struct bonding *bond,
963 struct bond_opt_value *newval)
29c49482 964{
90194264 965 pr_info("%s: Setting arp_validate to %s (%llu)\n",
16228881 966 bond->dev->name, newval->string, newval->value);
29c49482 967
968 if (bond->dev->flags & IFF_UP) {
16228881 969 if (!newval->value)
29c49482 970 bond->recv_probe = NULL;
971 else if (bond->params.arp_interval)
972 bond->recv_probe = bond_arp_rcv;
973 }
16228881 974 bond->params.arp_validate = newval->value;
29c49482 975
976 return 0;
977}
d5c84254 978
edf36b24
NA		 979int bond_option_arp_all_targets_set(struct bonding *bond,
980 struct bond_opt_value *newval)
d5c84254 981{
90194264 982 pr_info("%s: Setting arp_all_targets to %s (%llu)\n",
edf36b24
NA		 983 bond->dev->name, newval->string, newval->value);
984 bond->params.arp_all_targets = newval->value;
d5c84254 985
986 return 0;
987}
0a98a0d1 988
180222f0 989int bond_option_primary_set(struct bonding *bond, struct bond_opt_value *newval)
0a98a0d1 990{
180222f0 991 char *p, *primary = newval->string;
0a98a0d1 992 struct list_head *iter;
993 struct slave *slave;
0a98a0d1 994
995 block_netpoll_tx();
996 read_lock(&bond->lock);
997 write_lock_bh(&bond->curr_slave_lock);
998
180222f0
NA		 999 p = strchr(primary, '\n');
1000 if (p)
1001 *p = '\0';
0a98a0d1 1002 /* check to see if we are clearing primary */
1003 if (!strlen(primary)) {
90194264 1004 pr_info("%s: Setting primary slave to None\n", bond->dev->name);
0a98a0d1 1005 bond->primary_slave = NULL;
1006 memset(bond->params.primary, 0, sizeof(bond->params.primary));
1007 bond_select_active_slave(bond);
1008 goto out;
1009 }
1010
1011 bond_for_each_slave(bond, slave, iter) {
1012 if (strncmp(slave->dev->name, primary, IFNAMSIZ) == 0) {
90194264 1013 pr_info("%s: Setting %s as primary slave\n",
0a98a0d1 1014 bond->dev->name, slave->dev->name);
1015 bond->primary_slave = slave;
1016 strcpy(bond->params.primary, slave->dev->name);
1017 bond_select_active_slave(bond);
1018 goto out;
1019 }
1020 }
1021
c59ab673 1022 if (bond->primary_slave) {
90194264 1023 pr_info("%s: Setting primary slave to None\n", bond->dev->name);
c59ab673 1024 bond->primary_slave = NULL;
1025 bond_select_active_slave(bond);
1026 }
0a98a0d1 1027 strncpy(bond->params.primary, primary, IFNAMSIZ);
1028 bond->params.primary[IFNAMSIZ - 1] = 0;
1029
90194264 1030 pr_info("%s: Recording %s as primary, but it has not been enslaved to %s yet\n",
0a98a0d1 1031 bond->dev->name, primary, bond->dev->name);
1032
1033out:
1034 write_unlock_bh(&bond->curr_slave_lock);
1035 read_unlock(&bond->lock);
1036 unblock_netpoll_tx();
1037
180222f0 1038 return 0;
0a98a0d1 1039}
8a41ae44 1040
388d3a6d
NA		 1041int bond_option_primary_reselect_set(struct bonding *bond,
1042 struct bond_opt_value *newval)
8a41ae44 1043{
90194264 1044 pr_info("%s: Setting primary_reselect to %s (%llu)\n",
388d3a6d
NA		 1045 bond->dev->name, newval->string, newval->value);
1046 bond->params.primary_reselect = newval->value;
8a41ae44 1047
1048 block_netpoll_tx();
1049 write_lock_bh(&bond->curr_slave_lock);
1050 bond_select_active_slave(bond);
1051 write_unlock_bh(&bond->curr_slave_lock);
1052 unblock_netpoll_tx();
1053
1054 return 0;
1055}
89901972 1056
1df6b6aa
NA		 1057int bond_option_fail_over_mac_set(struct bonding *bond,
1058 struct bond_opt_value *newval)
89901972 1059{
90194264 1060 pr_info("%s: Setting fail_over_mac to %s (%llu)\n",
1df6b6aa
NA		 1061 bond->dev->name, newval->string, newval->value);
1062 bond->params.fail_over_mac = newval->value;
89901972 1063
1064 return 0;
1065}
f70161c6 1066
a4b32ce7
NA		 1067int bond_option_xmit_hash_policy_set(struct bonding *bond,
1068 struct bond_opt_value *newval)
f70161c6 1069{
90194264 1070 pr_info("%s: Setting xmit hash policy to %s (%llu)\n",
a4b32ce7
NA		 1071 bond->dev->name, newval->string, newval->value);
1072 bond->params.xmit_policy = newval->value;
f70161c6 1073
1074 return 0;
1075}
d8838de7 1076
105c8fb6
NA		 1077int bond_option_resend_igmp_set(struct bonding *bond,
1078 struct bond_opt_value *newval)
d8838de7 1079{
90194264 1080 pr_info("%s: Setting resend_igmp to %llu\n",
105c8fb6
NA		 1081 bond->dev->name, newval->value);
1082 bond->params.resend_igmp = newval->value;
d8838de7 1083
1084 return 0;
1085}
2c9839c1 1086
ef56becb
NA		 1087int bond_option_num_peer_notif_set(struct bonding *bond,
1088 struct bond_opt_value *newval)
2c9839c1 1089{
ef56becb
NA		 1090 bond->params.num_peer_notif = newval->value;
1091
2c9839c1 1092 return 0;
1093}
1cc0b1e3 1094
1095int bond_option_all_slaves_active_set(struct bonding *bond,
3df01162 1096 struct bond_opt_value *newval)
1cc0b1e3 1097{
1098 struct list_head *iter;
1099 struct slave *slave;
1100
3df01162 1101 if (newval->value == bond->params.all_slaves_active)
1cc0b1e3 1102 return 0;
3df01162 1103 bond->params.all_slaves_active = newval->value;
1cc0b1e3 1104 bond_for_each_slave(bond, slave, iter) {
1105 if (!bond_is_active_slave(slave)) {
3df01162 1106 if (newval->value)
1cc0b1e3 1107 slave->inactive = 0;
1108 else
1109 slave->inactive = 1;
1110 }
1111 }
1112
1113 return 0;
1114}
7d101008 1115
633ddc9e
NA		 1116int bond_option_min_links_set(struct bonding *bond,
1117 struct bond_opt_value *newval)
7d101008 1118{
633ddc9e
NA		 1119 pr_info("%s: Setting min links value to %llu\n",
1120 bond->dev->name, newval->value);
1121 bond->params.min_links = newval->value;
7d101008 1122
1123 return 0;
1124}
8d836d09 1125
4325b374
NA		 1126int bond_option_lp_interval_set(struct bonding *bond,
1127 struct bond_opt_value *newval)
8d836d09 1128{
4325b374 1129 bond->params.lp_interval = newval->value;
8d836d09 1130
1131 return 0;
1132}
c13ab3ff 1133
aa59d851 1134int bond_option_pps_set(struct bonding *bond, struct bond_opt_value *newval)
c13ab3ff 1135{
aa59d851
NA		 1136 bond->params.packets_per_slave = newval->value;
1137 if (newval->value > 0) {
809fa972 1138 bond->params.reciprocal_packets_per_slave =
aa59d851 1139 reciprocal_value(newval->value);
809fa972
HFS		 1140 } else {
1141 /* reciprocal_packets_per_slave is unused if
1142 * packets_per_slave is 0 or 1, just initialize it
1143 */
1144 bond->params.reciprocal_packets_per_slave =
1145 (struct reciprocal_value) { 0 };
1146 }
c13ab3ff 1147
1148 return 0;
1149}
998e40bb 1150
d3131de7
NA		 1151int bond_option_lacp_rate_set(struct bonding *bond,
1152 struct bond_opt_value *newval)
998e40bb 1153{
90194264 1154 pr_info("%s: Setting LACP rate to %s (%llu)\n",
d3131de7
NA		 1155 bond->dev->name, newval->string, newval->value);
1156 bond->params.lacp_fast = newval->value;
3243c47b 1157 bond_3ad_update_lacp_rate(bond);
998e40bb 1158
1159 return 0;
1160}
ec029fac 1161
9e5f5eeb
NA		 1162int bond_option_ad_select_set(struct bonding *bond,
1163 struct bond_opt_value *newval)
ec029fac 1164{
90194264 1165 pr_info("%s: Setting ad_select to %s (%llu)\n",
9e5f5eeb
NA		 1166 bond->dev->name, newval->string, newval->value);
1167 bond->params.ad_select = newval->value;
ec029fac 1168
1169 return 0;
1170}
24089ba1
NA		 1171
1172int bond_option_queue_id_set(struct bonding *bond,
1173 struct bond_opt_value *newval)
1174{
1175 struct slave *slave, *update_slave;
1176 struct net_device *sdev;
1177 struct list_head *iter;
1178 char *delim;
1179 int ret = 0;
1180 u16 qid;
1181
1182 /* delim will point to queue id if successful */
1183 delim = strchr(newval->string, ':');
1184 if (!delim)
1185 goto err_no_cmd;
1186
1187 /* Terminate string that points to device name and bump it
1188 * up one, so we can read the queue id there.
1189 */
1190 *delim = '\0';
1191 if (sscanf(++delim, "%hd\n", &qid) != 1)
1192 goto err_no_cmd;
1193
1194 /* Check buffer length, valid ifname and queue id */
c313c89e 1195 if (!dev_valid_name(newval->string) ||
24089ba1
NA		 1196 qid > bond->dev->real_num_tx_queues)
1197 goto err_no_cmd;
1198
1199 /* Get the pointer to that interface if it exists */
1200 sdev = __dev_get_by_name(dev_net(bond->dev), newval->string);
1201 if (!sdev)
1202 goto err_no_cmd;
1203
1204 /* Search for thes slave and check for duplicate qids */
1205 update_slave = NULL;
1206 bond_for_each_slave(bond, slave, iter) {
1207 if (sdev == slave->dev)
1208 /* We don't need to check the matching
1209 * slave for dups, since we're overwriting it
1210 */
1211 update_slave = slave;
1212 else if (qid && qid == slave->queue_id) {
1213 goto err_no_cmd;
1214 }
1215 }
1216
1217 if (!update_slave)
1218 goto err_no_cmd;
1219
1220 /* Actually set the qids for the slave */
1221 update_slave->queue_id = qid;
1222
1223out:
1224 return ret;
1225
1226err_no_cmd:
90194264 1227 pr_info("invalid input for queue_id set for %s\n", bond->dev->name);
24089ba1
NA		 1228 ret = -EPERM;
1229 goto out;
1230
1231}
0e2e5b66
NA		 1232
1233int bond_option_slaves_set(struct bonding *bond, struct bond_opt_value *newval)
1234{
1235 char command[IFNAMSIZ + 1] = { 0, };
1236 struct net_device *dev;
1237 char *ifname;
1238 int ret;
1239
1240 sscanf(newval->string, "%16s", command); /* IFNAMSIZ*/
1241 ifname = command + 1;
1242 if ((strlen(command) <= 1) ||
1243 !dev_valid_name(ifname))
1244 goto err_no_cmd;
1245
1246 dev = __dev_get_by_name(dev_net(bond->dev), ifname);
1247 if (!dev) {
90194264 1248 pr_info("%s: interface %s does not exist!\n",
0e2e5b66
NA		 1249 bond->dev->name, ifname);
1250 ret = -ENODEV;
1251 goto out;
1252 }
1253
1254 switch (command[0]) {
1255 case '+':
90194264 1256 pr_info("%s: Adding slave %s\n", bond->dev->name, dev->name);
0e2e5b66
NA		 1257 ret = bond_enslave(bond->dev, dev);
1258 break;
1259
1260 case '-':
90194264 1261 pr_info("%s: Removing slave %s\n", bond->dev->name, dev->name);
0e2e5b66
NA		 1262 ret = bond_release(bond->dev, dev);
1263 break;
1264
1265 default:
1266 goto err_no_cmd;
1267 }
1268
1269out:
1270 return ret;
1271
1272err_no_cmd:
90194264 1273 pr_err("no command found in slaves file for bond %s - use +ifname or -ifname\n",
0e2e5b66
NA		 1274 bond->dev->name);
1275 ret = -EPERM;
1276 goto out;
1277}
Linux 6.x block layer and io_uring tree(s)