drm/i915: Save user requested plane coordinates only on success
[linux-block.git] / drivers / gpu / drm / i915 / intel_sprite.c
CommitLineData
b840d907
JB
1/*
2 * Copyright © 2011 Intel Corporation
3 *
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
10 *
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
13 * Software.
14 *
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21 * SOFTWARE.
22 *
23 * Authors:
24 * Jesse Barnes <jbarnes@virtuousgeek.org>
25 *
26 * New plane/sprite handling.
27 *
28 * The older chips had a separate interface for programming plane related
29 * registers; newer ones are much simpler and we can use the new DRM plane
30 * support.
31 */
760285e7
DH
32#include <drm/drmP.h>
33#include <drm/drm_crtc.h>
34#include <drm/drm_fourcc.h>
1731693a 35#include <drm/drm_rect.h>
b840d907 36#include "intel_drv.h"
760285e7 37#include <drm/i915_drm.h>
b840d907
JB
38#include "i915_drv.h"
39
7f1f3851 40static void
b39d53f6
VS
41vlv_update_plane(struct drm_plane *dplane, struct drm_crtc *crtc,
42 struct drm_framebuffer *fb,
7f1f3851
JB
43 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
44 unsigned int crtc_w, unsigned int crtc_h,
45 uint32_t x, uint32_t y,
46 uint32_t src_w, uint32_t src_h)
47{
48 struct drm_device *dev = dplane->dev;
49 struct drm_i915_private *dev_priv = dev->dev_private;
50 struct intel_plane *intel_plane = to_intel_plane(dplane);
51 int pipe = intel_plane->pipe;
52 int plane = intel_plane->plane;
53 u32 sprctl;
54 unsigned long sprsurf_offset, linear_offset;
55 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
56
57 sprctl = I915_READ(SPCNTR(pipe, plane));
58
59 /* Mask out pixel format bits in case we change it */
60 sprctl &= ~SP_PIXFORMAT_MASK;
61 sprctl &= ~SP_YUV_BYTE_ORDER_MASK;
62 sprctl &= ~SP_TILED;
63
64 switch (fb->pixel_format) {
65 case DRM_FORMAT_YUYV:
66 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
67 break;
68 case DRM_FORMAT_YVYU:
69 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
70 break;
71 case DRM_FORMAT_UYVY:
72 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
73 break;
74 case DRM_FORMAT_VYUY:
75 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
76 break;
77 case DRM_FORMAT_RGB565:
78 sprctl |= SP_FORMAT_BGR565;
79 break;
80 case DRM_FORMAT_XRGB8888:
81 sprctl |= SP_FORMAT_BGRX8888;
82 break;
83 case DRM_FORMAT_ARGB8888:
84 sprctl |= SP_FORMAT_BGRA8888;
85 break;
86 case DRM_FORMAT_XBGR2101010:
87 sprctl |= SP_FORMAT_RGBX1010102;
88 break;
89 case DRM_FORMAT_ABGR2101010:
90 sprctl |= SP_FORMAT_RGBA1010102;
91 break;
92 case DRM_FORMAT_XBGR8888:
93 sprctl |= SP_FORMAT_RGBX8888;
94 break;
95 case DRM_FORMAT_ABGR8888:
96 sprctl |= SP_FORMAT_RGBA8888;
97 break;
98 default:
99 /*
100 * If we get here one of the upper layers failed to filter
101 * out the unsupported plane formats
102 */
103 BUG();
104 break;
105 }
106
107 if (obj->tiling_mode != I915_TILING_NONE)
108 sprctl |= SP_TILED;
109
110 sprctl |= SP_ENABLE;
111
adf3d35e 112 intel_update_sprite_watermarks(dplane, crtc, src_w, pixel_size, true,
67ca28f3
VS
113 src_w != crtc_w || src_h != crtc_h);
114
7f1f3851
JB
115 /* Sizes are 0 based */
116 src_w--;
117 src_h--;
118 crtc_w--;
119 crtc_h--;
120
7f1f3851
JB
121 I915_WRITE(SPSTRIDE(pipe, plane), fb->pitches[0]);
122 I915_WRITE(SPPOS(pipe, plane), (crtc_y << 16) | crtc_x);
123
124 linear_offset = y * fb->pitches[0] + x * pixel_size;
125 sprsurf_offset = intel_gen4_compute_page_offset(&x, &y,
126 obj->tiling_mode,
127 pixel_size,
128 fb->pitches[0]);
129 linear_offset -= sprsurf_offset;
130
131 if (obj->tiling_mode != I915_TILING_NONE)
132 I915_WRITE(SPTILEOFF(pipe, plane), (y << 16) | x);
133 else
134 I915_WRITE(SPLINOFF(pipe, plane), linear_offset);
135
136 I915_WRITE(SPSIZE(pipe, plane), (crtc_h << 16) | crtc_w);
137 I915_WRITE(SPCNTR(pipe, plane), sprctl);
f343c5f6 138 I915_MODIFY_DISPBASE(SPSURF(pipe, plane), i915_gem_obj_ggtt_offset(obj) +
7f1f3851
JB
139 sprsurf_offset);
140 POSTING_READ(SPSURF(pipe, plane));
141}
142
143static void
b39d53f6 144vlv_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
7f1f3851
JB
145{
146 struct drm_device *dev = dplane->dev;
147 struct drm_i915_private *dev_priv = dev->dev_private;
148 struct intel_plane *intel_plane = to_intel_plane(dplane);
149 int pipe = intel_plane->pipe;
150 int plane = intel_plane->plane;
151
152 I915_WRITE(SPCNTR(pipe, plane), I915_READ(SPCNTR(pipe, plane)) &
153 ~SP_ENABLE);
154 /* Activate double buffered register update */
155 I915_MODIFY_DISPBASE(SPSURF(pipe, plane), 0);
156 POSTING_READ(SPSURF(pipe, plane));
a95fd8ca
VS
157
158 intel_update_sprite_watermarks(dplane, crtc, 0, 0, false, false);
7f1f3851
JB
159}
160
161static int
162vlv_update_colorkey(struct drm_plane *dplane,
163 struct drm_intel_sprite_colorkey *key)
164{
165 struct drm_device *dev = dplane->dev;
166 struct drm_i915_private *dev_priv = dev->dev_private;
167 struct intel_plane *intel_plane = to_intel_plane(dplane);
168 int pipe = intel_plane->pipe;
169 int plane = intel_plane->plane;
170 u32 sprctl;
171
172 if (key->flags & I915_SET_COLORKEY_DESTINATION)
173 return -EINVAL;
174
175 I915_WRITE(SPKEYMINVAL(pipe, plane), key->min_value);
176 I915_WRITE(SPKEYMAXVAL(pipe, plane), key->max_value);
177 I915_WRITE(SPKEYMSK(pipe, plane), key->channel_mask);
178
179 sprctl = I915_READ(SPCNTR(pipe, plane));
180 sprctl &= ~SP_SOURCE_KEY;
181 if (key->flags & I915_SET_COLORKEY_SOURCE)
182 sprctl |= SP_SOURCE_KEY;
183 I915_WRITE(SPCNTR(pipe, plane), sprctl);
184
185 POSTING_READ(SPKEYMSK(pipe, plane));
186
187 return 0;
188}
189
190static void
191vlv_get_colorkey(struct drm_plane *dplane,
192 struct drm_intel_sprite_colorkey *key)
193{
194 struct drm_device *dev = dplane->dev;
195 struct drm_i915_private *dev_priv = dev->dev_private;
196 struct intel_plane *intel_plane = to_intel_plane(dplane);
197 int pipe = intel_plane->pipe;
198 int plane = intel_plane->plane;
199 u32 sprctl;
200
201 key->min_value = I915_READ(SPKEYMINVAL(pipe, plane));
202 key->max_value = I915_READ(SPKEYMAXVAL(pipe, plane));
203 key->channel_mask = I915_READ(SPKEYMSK(pipe, plane));
204
205 sprctl = I915_READ(SPCNTR(pipe, plane));
206 if (sprctl & SP_SOURCE_KEY)
207 key->flags = I915_SET_COLORKEY_SOURCE;
208 else
209 key->flags = I915_SET_COLORKEY_NONE;
210}
211
b840d907 212static void
b39d53f6
VS
213ivb_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
214 struct drm_framebuffer *fb,
b840d907
JB
215 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
216 unsigned int crtc_w, unsigned int crtc_h,
217 uint32_t x, uint32_t y,
218 uint32_t src_w, uint32_t src_h)
219{
220 struct drm_device *dev = plane->dev;
221 struct drm_i915_private *dev_priv = dev->dev_private;
222 struct intel_plane *intel_plane = to_intel_plane(plane);
223 int pipe = intel_plane->pipe;
224 u32 sprctl, sprscale = 0;
5a35e99e 225 unsigned long sprsurf_offset, linear_offset;
2bd3c3cb 226 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
2c6602df 227 bool scaling_was_enabled = dev_priv->sprite_scaling_enabled;
b840d907
JB
228
229 sprctl = I915_READ(SPRCTL(pipe));
230
231 /* Mask out pixel format bits in case we change it */
232 sprctl &= ~SPRITE_PIXFORMAT_MASK;
233 sprctl &= ~SPRITE_RGB_ORDER_RGBX;
234 sprctl &= ~SPRITE_YUV_BYTE_ORDER_MASK;
e86fe0d3 235 sprctl &= ~SPRITE_TILED;
b840d907
JB
236
237 switch (fb->pixel_format) {
238 case DRM_FORMAT_XBGR8888:
5ee36913 239 sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
b840d907
JB
240 break;
241 case DRM_FORMAT_XRGB8888:
5ee36913 242 sprctl |= SPRITE_FORMAT_RGBX888;
b840d907
JB
243 break;
244 case DRM_FORMAT_YUYV:
245 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
b840d907
JB
246 break;
247 case DRM_FORMAT_YVYU:
248 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
b840d907
JB
249 break;
250 case DRM_FORMAT_UYVY:
251 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
b840d907
JB
252 break;
253 case DRM_FORMAT_VYUY:
254 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
b840d907
JB
255 break;
256 default:
28d491df 257 BUG();
b840d907
JB
258 }
259
260 if (obj->tiling_mode != I915_TILING_NONE)
261 sprctl |= SPRITE_TILED;
262
1f5d76db
PZ
263 if (IS_HASWELL(dev))
264 sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
265 else
266 sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
267
b840d907
JB
268 sprctl |= SPRITE_ENABLE;
269
86d3efce
VS
270 if (IS_HASWELL(dev))
271 sprctl |= SPRITE_PIPE_CSC_ENABLE;
272
adf3d35e 273 intel_update_sprite_watermarks(plane, crtc, src_w, pixel_size, true,
67ca28f3
VS
274 src_w != crtc_w || src_h != crtc_h);
275
b840d907
JB
276 /* Sizes are 0 based */
277 src_w--;
278 src_h--;
279 crtc_w--;
280 crtc_h--;
281
b840d907
JB
282 /*
283 * IVB workaround: must disable low power watermarks for at least
284 * one frame before enabling scaling. LP watermarks can be re-enabled
285 * when scaling is disabled.
286 */
287 if (crtc_w != src_w || crtc_h != src_h) {
2c6602df
VS
288 dev_priv->sprite_scaling_enabled |= 1 << pipe;
289
290 if (!scaling_was_enabled) {
46ba614c 291 intel_update_watermarks(crtc);
828ed3e1
CW
292 intel_wait_for_vblank(dev, pipe);
293 }
b840d907 294 sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;
2c6602df
VS
295 } else
296 dev_priv->sprite_scaling_enabled &= ~(1 << pipe);
b840d907
JB
297
298 I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
299 I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);
c54173a8 300
ca320ac4 301 linear_offset = y * fb->pitches[0] + x * pixel_size;
5a35e99e 302 sprsurf_offset =
bc752862
CW
303 intel_gen4_compute_page_offset(&x, &y, obj->tiling_mode,
304 pixel_size, fb->pitches[0]);
5a35e99e
DL
305 linear_offset -= sprsurf_offset;
306
307 /* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
308 * register */
309 if (IS_HASWELL(dev))
c54173a8 310 I915_WRITE(SPROFFSET(pipe), (y << 16) | x);
5a35e99e 311 else if (obj->tiling_mode != I915_TILING_NONE)
b840d907 312 I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
5a35e99e
DL
313 else
314 I915_WRITE(SPRLINOFF(pipe), linear_offset);
c54173a8 315
b840d907 316 I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
2d354c34
DL
317 if (intel_plane->can_scale)
318 I915_WRITE(SPRSCALE(pipe), sprscale);
b840d907 319 I915_WRITE(SPRCTL(pipe), sprctl);
f343c5f6
BW
320 I915_MODIFY_DISPBASE(SPRSURF(pipe),
321 i915_gem_obj_ggtt_offset(obj) + sprsurf_offset);
b840d907 322 POSTING_READ(SPRSURF(pipe));
2c6602df
VS
323
324 /* potentially re-enable LP watermarks */
325 if (scaling_was_enabled && !dev_priv->sprite_scaling_enabled)
46ba614c 326 intel_update_watermarks(crtc);
b840d907
JB
327}
328
329static void
b39d53f6 330ivb_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
b840d907
JB
331{
332 struct drm_device *dev = plane->dev;
333 struct drm_i915_private *dev_priv = dev->dev_private;
334 struct intel_plane *intel_plane = to_intel_plane(plane);
335 int pipe = intel_plane->pipe;
2c6602df 336 bool scaling_was_enabled = dev_priv->sprite_scaling_enabled;
b840d907
JB
337
338 I915_WRITE(SPRCTL(pipe), I915_READ(SPRCTL(pipe)) & ~SPRITE_ENABLE);
339 /* Can't leave the scaler enabled... */
2d354c34
DL
340 if (intel_plane->can_scale)
341 I915_WRITE(SPRSCALE(pipe), 0);
b840d907 342 /* Activate double buffered register update */
446f2545 343 I915_MODIFY_DISPBASE(SPRSURF(pipe), 0);
b840d907 344 POSTING_READ(SPRSURF(pipe));
828ed3e1 345
2c6602df
VS
346 dev_priv->sprite_scaling_enabled &= ~(1 << pipe);
347
adf3d35e 348 intel_update_sprite_watermarks(plane, crtc, 0, 0, false, false);
4c4ff43a 349
2c6602df
VS
350 /* potentially re-enable LP watermarks */
351 if (scaling_was_enabled && !dev_priv->sprite_scaling_enabled)
46ba614c 352 intel_update_watermarks(crtc);
b840d907
JB
353}
354
8ea30864
JB
355static int
356ivb_update_colorkey(struct drm_plane *plane,
357 struct drm_intel_sprite_colorkey *key)
358{
359 struct drm_device *dev = plane->dev;
360 struct drm_i915_private *dev_priv = dev->dev_private;
361 struct intel_plane *intel_plane;
362 u32 sprctl;
363 int ret = 0;
364
365 intel_plane = to_intel_plane(plane);
366
367 I915_WRITE(SPRKEYVAL(intel_plane->pipe), key->min_value);
368 I915_WRITE(SPRKEYMAX(intel_plane->pipe), key->max_value);
369 I915_WRITE(SPRKEYMSK(intel_plane->pipe), key->channel_mask);
370
371 sprctl = I915_READ(SPRCTL(intel_plane->pipe));
372 sprctl &= ~(SPRITE_SOURCE_KEY | SPRITE_DEST_KEY);
373 if (key->flags & I915_SET_COLORKEY_DESTINATION)
374 sprctl |= SPRITE_DEST_KEY;
375 else if (key->flags & I915_SET_COLORKEY_SOURCE)
376 sprctl |= SPRITE_SOURCE_KEY;
377 I915_WRITE(SPRCTL(intel_plane->pipe), sprctl);
378
379 POSTING_READ(SPRKEYMSK(intel_plane->pipe));
380
381 return ret;
382}
383
384static void
385ivb_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
386{
387 struct drm_device *dev = plane->dev;
388 struct drm_i915_private *dev_priv = dev->dev_private;
389 struct intel_plane *intel_plane;
390 u32 sprctl;
391
392 intel_plane = to_intel_plane(plane);
393
394 key->min_value = I915_READ(SPRKEYVAL(intel_plane->pipe));
395 key->max_value = I915_READ(SPRKEYMAX(intel_plane->pipe));
396 key->channel_mask = I915_READ(SPRKEYMSK(intel_plane->pipe));
397 key->flags = 0;
398
399 sprctl = I915_READ(SPRCTL(intel_plane->pipe));
400
401 if (sprctl & SPRITE_DEST_KEY)
402 key->flags = I915_SET_COLORKEY_DESTINATION;
403 else if (sprctl & SPRITE_SOURCE_KEY)
404 key->flags = I915_SET_COLORKEY_SOURCE;
405 else
406 key->flags = I915_SET_COLORKEY_NONE;
407}
408
b840d907 409static void
b39d53f6
VS
410ilk_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
411 struct drm_framebuffer *fb,
b840d907
JB
412 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
413 unsigned int crtc_w, unsigned int crtc_h,
414 uint32_t x, uint32_t y,
415 uint32_t src_w, uint32_t src_h)
416{
417 struct drm_device *dev = plane->dev;
418 struct drm_i915_private *dev_priv = dev->dev_private;
419 struct intel_plane *intel_plane = to_intel_plane(plane);
2bd3c3cb 420 int pipe = intel_plane->pipe;
5a35e99e 421 unsigned long dvssurf_offset, linear_offset;
8aaa81a1 422 u32 dvscntr, dvsscale;
2bd3c3cb 423 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
b840d907
JB
424
425 dvscntr = I915_READ(DVSCNTR(pipe));
426
427 /* Mask out pixel format bits in case we change it */
428 dvscntr &= ~DVS_PIXFORMAT_MASK;
ab2f9df1 429 dvscntr &= ~DVS_RGB_ORDER_XBGR;
b840d907 430 dvscntr &= ~DVS_YUV_BYTE_ORDER_MASK;
79626523 431 dvscntr &= ~DVS_TILED;
b840d907
JB
432
433 switch (fb->pixel_format) {
434 case DRM_FORMAT_XBGR8888:
ab2f9df1 435 dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
b840d907
JB
436 break;
437 case DRM_FORMAT_XRGB8888:
ab2f9df1 438 dvscntr |= DVS_FORMAT_RGBX888;
b840d907
JB
439 break;
440 case DRM_FORMAT_YUYV:
441 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
b840d907
JB
442 break;
443 case DRM_FORMAT_YVYU:
444 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
b840d907
JB
445 break;
446 case DRM_FORMAT_UYVY:
447 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
b840d907
JB
448 break;
449 case DRM_FORMAT_VYUY:
450 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
b840d907
JB
451 break;
452 default:
28d491df 453 BUG();
b840d907
JB
454 }
455
456 if (obj->tiling_mode != I915_TILING_NONE)
457 dvscntr |= DVS_TILED;
458
d1686ae3
CW
459 if (IS_GEN6(dev))
460 dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
b840d907
JB
461 dvscntr |= DVS_ENABLE;
462
adf3d35e 463 intel_update_sprite_watermarks(plane, crtc, src_w, pixel_size, true,
67ca28f3
VS
464 src_w != crtc_w || src_h != crtc_h);
465
b840d907
JB
466 /* Sizes are 0 based */
467 src_w--;
468 src_h--;
469 crtc_w--;
470 crtc_h--;
471
8aaa81a1
CW
472 dvsscale = 0;
473 if (IS_GEN5(dev) || crtc_w != src_w || crtc_h != src_h)
b840d907
JB
474 dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;
475
476 I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
477 I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);
5a35e99e 478
ca320ac4 479 linear_offset = y * fb->pitches[0] + x * pixel_size;
5a35e99e 480 dvssurf_offset =
bc752862
CW
481 intel_gen4_compute_page_offset(&x, &y, obj->tiling_mode,
482 pixel_size, fb->pitches[0]);
5a35e99e
DL
483 linear_offset -= dvssurf_offset;
484
485 if (obj->tiling_mode != I915_TILING_NONE)
b840d907 486 I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
5a35e99e
DL
487 else
488 I915_WRITE(DVSLINOFF(pipe), linear_offset);
b840d907 489
b840d907
JB
490 I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
491 I915_WRITE(DVSSCALE(pipe), dvsscale);
492 I915_WRITE(DVSCNTR(pipe), dvscntr);
f343c5f6
BW
493 I915_MODIFY_DISPBASE(DVSSURF(pipe),
494 i915_gem_obj_ggtt_offset(obj) + dvssurf_offset);
b840d907
JB
495 POSTING_READ(DVSSURF(pipe));
496}
497
498static void
b39d53f6 499ilk_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
b840d907
JB
500{
501 struct drm_device *dev = plane->dev;
502 struct drm_i915_private *dev_priv = dev->dev_private;
503 struct intel_plane *intel_plane = to_intel_plane(plane);
504 int pipe = intel_plane->pipe;
505
506 I915_WRITE(DVSCNTR(pipe), I915_READ(DVSCNTR(pipe)) & ~DVS_ENABLE);
507 /* Disable the scaler */
508 I915_WRITE(DVSSCALE(pipe), 0);
509 /* Flush double buffered register updates */
446f2545 510 I915_MODIFY_DISPBASE(DVSSURF(pipe), 0);
b840d907 511 POSTING_READ(DVSSURF(pipe));
a95fd8ca
VS
512
513 intel_update_sprite_watermarks(plane, crtc, 0, 0, false, false);
b840d907
JB
514}
515
175bd420
JB
516static void
517intel_enable_primary(struct drm_crtc *crtc)
518{
519 struct drm_device *dev = crtc->dev;
520 struct drm_i915_private *dev_priv = dev->dev_private;
521 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
522 int reg = DSPCNTR(intel_crtc->plane);
523
93314b5b
CW
524 if (!intel_crtc->primary_disabled)
525 return;
526
527 intel_crtc->primary_disabled = false;
82284b6b
VS
528
529 mutex_lock(&dev->struct_mutex);
93314b5b 530 intel_update_fbc(dev);
82284b6b 531 mutex_unlock(&dev->struct_mutex);
93314b5b 532
175bd420
JB
533 I915_WRITE(reg, I915_READ(reg) | DISPLAY_PLANE_ENABLE);
534}
535
536static void
537intel_disable_primary(struct drm_crtc *crtc)
538{
539 struct drm_device *dev = crtc->dev;
540 struct drm_i915_private *dev_priv = dev->dev_private;
541 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
542 int reg = DSPCNTR(intel_crtc->plane);
543
93314b5b
CW
544 if (intel_crtc->primary_disabled)
545 return;
546
175bd420 547 I915_WRITE(reg, I915_READ(reg) & ~DISPLAY_PLANE_ENABLE);
93314b5b
CW
548
549 intel_crtc->primary_disabled = true;
82284b6b
VS
550
551 mutex_lock(&dev->struct_mutex);
93314b5b 552 intel_update_fbc(dev);
82284b6b 553 mutex_unlock(&dev->struct_mutex);
175bd420
JB
554}
555
8ea30864 556static int
d1686ae3 557ilk_update_colorkey(struct drm_plane *plane,
8ea30864
JB
558 struct drm_intel_sprite_colorkey *key)
559{
560 struct drm_device *dev = plane->dev;
561 struct drm_i915_private *dev_priv = dev->dev_private;
562 struct intel_plane *intel_plane;
563 u32 dvscntr;
564 int ret = 0;
565
566 intel_plane = to_intel_plane(plane);
567
568 I915_WRITE(DVSKEYVAL(intel_plane->pipe), key->min_value);
569 I915_WRITE(DVSKEYMAX(intel_plane->pipe), key->max_value);
570 I915_WRITE(DVSKEYMSK(intel_plane->pipe), key->channel_mask);
571
572 dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
573 dvscntr &= ~(DVS_SOURCE_KEY | DVS_DEST_KEY);
574 if (key->flags & I915_SET_COLORKEY_DESTINATION)
575 dvscntr |= DVS_DEST_KEY;
576 else if (key->flags & I915_SET_COLORKEY_SOURCE)
577 dvscntr |= DVS_SOURCE_KEY;
578 I915_WRITE(DVSCNTR(intel_plane->pipe), dvscntr);
579
580 POSTING_READ(DVSKEYMSK(intel_plane->pipe));
581
582 return ret;
583}
584
585static void
d1686ae3 586ilk_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
8ea30864
JB
587{
588 struct drm_device *dev = plane->dev;
589 struct drm_i915_private *dev_priv = dev->dev_private;
590 struct intel_plane *intel_plane;
591 u32 dvscntr;
592
593 intel_plane = to_intel_plane(plane);
594
595 key->min_value = I915_READ(DVSKEYVAL(intel_plane->pipe));
596 key->max_value = I915_READ(DVSKEYMAX(intel_plane->pipe));
597 key->channel_mask = I915_READ(DVSKEYMSK(intel_plane->pipe));
598 key->flags = 0;
599
600 dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
601
602 if (dvscntr & DVS_DEST_KEY)
603 key->flags = I915_SET_COLORKEY_DESTINATION;
604 else if (dvscntr & DVS_SOURCE_KEY)
605 key->flags = I915_SET_COLORKEY_SOURCE;
606 else
607 key->flags = I915_SET_COLORKEY_NONE;
608}
609
1731693a
VS
610static bool
611format_is_yuv(uint32_t format)
612{
613 switch (format) {
614 case DRM_FORMAT_YUYV:
615 case DRM_FORMAT_UYVY:
616 case DRM_FORMAT_VYUY:
617 case DRM_FORMAT_YVYU:
618 return true;
619 default:
620 return false;
621 }
622}
623
b840d907
JB
624static int
625intel_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
626 struct drm_framebuffer *fb, int crtc_x, int crtc_y,
627 unsigned int crtc_w, unsigned int crtc_h,
628 uint32_t src_x, uint32_t src_y,
629 uint32_t src_w, uint32_t src_h)
630{
631 struct drm_device *dev = plane->dev;
b840d907
JB
632 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
633 struct intel_plane *intel_plane = to_intel_plane(plane);
2afd9efd
VS
634 struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
635 struct drm_i915_gem_object *obj = intel_fb->obj;
636 struct drm_i915_gem_object *old_obj = intel_plane->obj;
637 int ret;
b840d907 638 bool disable_primary = false;
1731693a
VS
639 bool visible;
640 int hscale, vscale;
641 int max_scale, min_scale;
642 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
643 struct drm_rect src = {
644 /* sample coordinates in 16.16 fixed point */
645 .x1 = src_x,
646 .x2 = src_x + src_w,
647 .y1 = src_y,
648 .y2 = src_y + src_h,
649 };
650 struct drm_rect dst = {
651 /* integer pixels */
652 .x1 = crtc_x,
653 .x2 = crtc_x + crtc_w,
654 .y1 = crtc_y,
655 .y2 = crtc_y + crtc_h,
656 };
657 const struct drm_rect clip = {
03c5b25f
VS
658 .x2 = intel_crtc->active ? intel_crtc->config.pipe_src_w : 0,
659 .y2 = intel_crtc->active ? intel_crtc->config.pipe_src_h : 0,
1731693a 660 };
098ebd6b
VS
661 const struct {
662 int crtc_x, crtc_y;
663 unsigned int crtc_w, crtc_h;
664 uint32_t src_x, src_y, src_w, src_h;
665 } orig = {
666 .crtc_x = crtc_x,
667 .crtc_y = crtc_y,
668 .crtc_w = crtc_w,
669 .crtc_h = crtc_h,
670 .src_x = src_x,
671 .src_y = src_y,
672 .src_w = src_w,
673 .src_h = src_h,
674 };
5e1bac2f 675
1731693a
VS
676 /* Don't modify another pipe's plane */
677 if (intel_plane->pipe != intel_crtc->pipe) {
678 DRM_DEBUG_KMS("Wrong plane <-> crtc mapping\n");
b840d907 679 return -EINVAL;
1731693a 680 }
b840d907 681
1731693a
VS
682 /* FIXME check all gen limits */
683 if (fb->width < 3 || fb->height < 3 || fb->pitches[0] > 16384) {
684 DRM_DEBUG_KMS("Unsuitable framebuffer for plane\n");
b840d907 685 return -EINVAL;
1731693a 686 }
b840d907 687
94c6419e
DL
688 /* Sprite planes can be linear or x-tiled surfaces */
689 switch (obj->tiling_mode) {
690 case I915_TILING_NONE:
691 case I915_TILING_X:
692 break;
693 default:
1731693a 694 DRM_DEBUG_KMS("Unsupported tiling mode\n");
94c6419e
DL
695 return -EINVAL;
696 }
697
3c3686cd
VS
698 /*
699 * FIXME the following code does a bunch of fuzzy adjustments to the
700 * coordinates and sizes. We probably need some way to decide whether
701 * more strict checking should be done instead.
702 */
1731693a
VS
703 max_scale = intel_plane->max_downscale << 16;
704 min_scale = intel_plane->can_scale ? 1 : (1 << 16);
705
3c3686cd
VS
706 hscale = drm_rect_calc_hscale_relaxed(&src, &dst, min_scale, max_scale);
707 BUG_ON(hscale < 0);
1731693a 708
3c3686cd
VS
709 vscale = drm_rect_calc_vscale_relaxed(&src, &dst, min_scale, max_scale);
710 BUG_ON(vscale < 0);
b840d907 711
1731693a 712 visible = drm_rect_clip_scaled(&src, &dst, &clip, hscale, vscale);
b840d907 713
1731693a
VS
714 crtc_x = dst.x1;
715 crtc_y = dst.y1;
716 crtc_w = drm_rect_width(&dst);
717 crtc_h = drm_rect_height(&dst);
2d354c34 718
1731693a 719 if (visible) {
3c3686cd
VS
720 /* check again in case clipping clamped the results */
721 hscale = drm_rect_calc_hscale(&src, &dst, min_scale, max_scale);
722 if (hscale < 0) {
723 DRM_DEBUG_KMS("Horizontal scaling factor out of limits\n");
724 drm_rect_debug_print(&src, true);
725 drm_rect_debug_print(&dst, false);
726
727 return hscale;
728 }
729
730 vscale = drm_rect_calc_vscale(&src, &dst, min_scale, max_scale);
731 if (vscale < 0) {
732 DRM_DEBUG_KMS("Vertical scaling factor out of limits\n");
733 drm_rect_debug_print(&src, true);
734 drm_rect_debug_print(&dst, false);
735
736 return vscale;
737 }
738
1731693a
VS
739 /* Make the source viewport size an exact multiple of the scaling factors. */
740 drm_rect_adjust_size(&src,
741 drm_rect_width(&dst) * hscale - drm_rect_width(&src),
742 drm_rect_height(&dst) * vscale - drm_rect_height(&src));
743
744 /* sanity check to make sure the src viewport wasn't enlarged */
745 WARN_ON(src.x1 < (int) src_x ||
746 src.y1 < (int) src_y ||
747 src.x2 > (int) (src_x + src_w) ||
748 src.y2 > (int) (src_y + src_h));
749
750 /*
751 * Hardware doesn't handle subpixel coordinates.
752 * Adjust to (macro)pixel boundary, but be careful not to
753 * increase the source viewport size, because that could
754 * push the downscaling factor out of bounds.
1731693a
VS
755 */
756 src_x = src.x1 >> 16;
757 src_w = drm_rect_width(&src) >> 16;
758 src_y = src.y1 >> 16;
759 src_h = drm_rect_height(&src) >> 16;
760
761 if (format_is_yuv(fb->pixel_format)) {
762 src_x &= ~1;
763 src_w &= ~1;
764
765 /*
766 * Must keep src and dst the
767 * same if we can't scale.
768 */
769 if (!intel_plane->can_scale)
770 crtc_w &= ~1;
771
772 if (crtc_w == 0)
773 visible = false;
774 }
775 }
776
777 /* Check size restrictions when scaling */
778 if (visible && (src_w != crtc_w || src_h != crtc_h)) {
779 unsigned int width_bytes;
780
781 WARN_ON(!intel_plane->can_scale);
782
783 /* FIXME interlacing min height is 6 */
784
785 if (crtc_w < 3 || crtc_h < 3)
786 visible = false;
787
788 if (src_w < 3 || src_h < 3)
789 visible = false;
790
791 width_bytes = ((src_x * pixel_size) & 63) + src_w * pixel_size;
792
793 if (src_w > 2048 || src_h > 2048 ||
794 width_bytes > 4096 || fb->pitches[0] > 4096) {
795 DRM_DEBUG_KMS("Source dimensions exceed hardware limits\n");
796 return -EINVAL;
797 }
798 }
799
800 dst.x1 = crtc_x;
801 dst.x2 = crtc_x + crtc_w;
802 dst.y1 = crtc_y;
803 dst.y2 = crtc_y + crtc_h;
b840d907
JB
804
805 /*
806 * If the sprite is completely covering the primary plane,
807 * we can disable the primary and save power.
808 */
1731693a 809 disable_primary = drm_rect_equals(&dst, &clip);
03c5b25f 810 WARN_ON(disable_primary && !visible && intel_crtc->active);
b840d907
JB
811
812 mutex_lock(&dev->struct_mutex);
813
693db184
CW
814 /* Note that this will apply the VT-d workaround for scanouts,
815 * which is more restrictive than required for sprites. (The
816 * primary plane requires 256KiB alignment with 64 PTE padding,
817 * the sprite planes only require 128KiB alignment and 32 PTE padding.
818 */
b840d907 819 ret = intel_pin_and_fence_fb_obj(dev, obj, NULL);
82284b6b
VS
820
821 mutex_unlock(&dev->struct_mutex);
822
00c2064b 823 if (ret)
82284b6b 824 return ret;
b840d907 825
098ebd6b
VS
826 intel_plane->crtc_x = orig.crtc_x;
827 intel_plane->crtc_y = orig.crtc_y;
828 intel_plane->crtc_w = orig.crtc_w;
829 intel_plane->crtc_h = orig.crtc_h;
830 intel_plane->src_x = orig.src_x;
831 intel_plane->src_y = orig.src_y;
832 intel_plane->src_w = orig.src_w;
833 intel_plane->src_h = orig.src_h;
b840d907
JB
834 intel_plane->obj = obj;
835
03c5b25f
VS
836 if (intel_crtc->active) {
837 /*
838 * Be sure to re-enable the primary before the sprite is no longer
839 * covering it fully.
840 */
841 if (!disable_primary)
842 intel_enable_primary(crtc);
843
844 if (visible)
845 intel_plane->update_plane(plane, crtc, fb, obj,
846 crtc_x, crtc_y, crtc_w, crtc_h,
847 src_x, src_y, src_w, src_h);
848 else
849 intel_plane->disable_plane(plane, crtc);
850
851 if (disable_primary)
852 intel_disable_primary(crtc);
853 }
175bd420 854
b840d907
JB
855 /* Unpin old obj after new one is active to avoid ugliness */
856 if (old_obj) {
857 /*
858 * It's fairly common to simply update the position of
859 * an existing object. In that case, we don't need to
860 * wait for vblank to avoid ugliness, we only need to
861 * do the pin & ref bookkeeping.
862 */
82284b6b 863 if (old_obj != obj && intel_crtc->active)
2afd9efd 864 intel_wait_for_vblank(dev, intel_crtc->pipe);
82284b6b
VS
865
866 mutex_lock(&dev->struct_mutex);
1690e1eb 867 intel_unpin_fb_obj(old_obj);
82284b6b 868 mutex_unlock(&dev->struct_mutex);
b840d907
JB
869 }
870
82284b6b 871 return 0;
b840d907
JB
872}
873
874static int
875intel_disable_plane(struct drm_plane *plane)
876{
877 struct drm_device *dev = plane->dev;
878 struct intel_plane *intel_plane = to_intel_plane(plane);
03c5b25f 879 struct intel_crtc *intel_crtc;
b840d907 880
88a94a58
VS
881 if (!plane->fb)
882 return 0;
883
884 if (WARN_ON(!plane->crtc))
885 return -EINVAL;
886
03c5b25f
VS
887 intel_crtc = to_intel_crtc(plane->crtc);
888
889 if (intel_crtc->active) {
890 intel_enable_primary(plane->crtc);
891 intel_plane->disable_plane(plane, plane->crtc);
892 }
b840d907 893
5f3fb46b
VS
894 if (intel_plane->obj) {
895 if (intel_crtc->active)
896 intel_wait_for_vblank(dev, intel_plane->pipe);
c626d317 897
5f3fb46b
VS
898 mutex_lock(&dev->struct_mutex);
899 intel_unpin_fb_obj(intel_plane->obj);
900 mutex_unlock(&dev->struct_mutex);
82284b6b 901
5f3fb46b
VS
902 intel_plane->obj = NULL;
903 }
b840d907 904
5f3fb46b 905 return 0;
b840d907
JB
906}
907
908static void intel_destroy_plane(struct drm_plane *plane)
909{
910 struct intel_plane *intel_plane = to_intel_plane(plane);
911 intel_disable_plane(plane);
912 drm_plane_cleanup(plane);
913 kfree(intel_plane);
914}
915
8ea30864
JB
916int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
917 struct drm_file *file_priv)
918{
919 struct drm_intel_sprite_colorkey *set = data;
8ea30864
JB
920 struct drm_mode_object *obj;
921 struct drm_plane *plane;
922 struct intel_plane *intel_plane;
923 int ret = 0;
924
1cff8f6b
DV
925 if (!drm_core_check_feature(dev, DRIVER_MODESET))
926 return -ENODEV;
8ea30864
JB
927
928 /* Make sure we don't try to enable both src & dest simultaneously */
929 if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
930 return -EINVAL;
931
a0e99e68 932 drm_modeset_lock_all(dev);
8ea30864
JB
933
934 obj = drm_mode_object_find(dev, set->plane_id, DRM_MODE_OBJECT_PLANE);
935 if (!obj) {
936 ret = -EINVAL;
937 goto out_unlock;
938 }
939
940 plane = obj_to_plane(obj);
941 intel_plane = to_intel_plane(plane);
942 ret = intel_plane->update_colorkey(plane, set);
943
944out_unlock:
a0e99e68 945 drm_modeset_unlock_all(dev);
8ea30864
JB
946 return ret;
947}
948
949int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
950 struct drm_file *file_priv)
951{
952 struct drm_intel_sprite_colorkey *get = data;
8ea30864
JB
953 struct drm_mode_object *obj;
954 struct drm_plane *plane;
955 struct intel_plane *intel_plane;
956 int ret = 0;
957
1cff8f6b
DV
958 if (!drm_core_check_feature(dev, DRIVER_MODESET))
959 return -ENODEV;
8ea30864 960
a0e99e68 961 drm_modeset_lock_all(dev);
8ea30864
JB
962
963 obj = drm_mode_object_find(dev, get->plane_id, DRM_MODE_OBJECT_PLANE);
964 if (!obj) {
965 ret = -EINVAL;
966 goto out_unlock;
967 }
968
969 plane = obj_to_plane(obj);
970 intel_plane = to_intel_plane(plane);
971 intel_plane->get_colorkey(plane, get);
972
973out_unlock:
a0e99e68 974 drm_modeset_unlock_all(dev);
8ea30864
JB
975 return ret;
976}
977
5e1bac2f
JB
978void intel_plane_restore(struct drm_plane *plane)
979{
980 struct intel_plane *intel_plane = to_intel_plane(plane);
981
982 if (!plane->crtc || !plane->fb)
983 return;
984
985 intel_update_plane(plane, plane->crtc, plane->fb,
986 intel_plane->crtc_x, intel_plane->crtc_y,
987 intel_plane->crtc_w, intel_plane->crtc_h,
988 intel_plane->src_x, intel_plane->src_y,
989 intel_plane->src_w, intel_plane->src_h);
990}
991
bb53d4ae
VS
992void intel_plane_disable(struct drm_plane *plane)
993{
994 if (!plane->crtc || !plane->fb)
995 return;
996
997 intel_disable_plane(plane);
998}
999
b840d907
JB
1000static const struct drm_plane_funcs intel_plane_funcs = {
1001 .update_plane = intel_update_plane,
1002 .disable_plane = intel_disable_plane,
1003 .destroy = intel_destroy_plane,
1004};
1005
d1686ae3
CW
1006static uint32_t ilk_plane_formats[] = {
1007 DRM_FORMAT_XRGB8888,
1008 DRM_FORMAT_YUYV,
1009 DRM_FORMAT_YVYU,
1010 DRM_FORMAT_UYVY,
1011 DRM_FORMAT_VYUY,
1012};
1013
b840d907
JB
1014static uint32_t snb_plane_formats[] = {
1015 DRM_FORMAT_XBGR8888,
1016 DRM_FORMAT_XRGB8888,
1017 DRM_FORMAT_YUYV,
1018 DRM_FORMAT_YVYU,
1019 DRM_FORMAT_UYVY,
1020 DRM_FORMAT_VYUY,
1021};
1022
7f1f3851
JB
1023static uint32_t vlv_plane_formats[] = {
1024 DRM_FORMAT_RGB565,
1025 DRM_FORMAT_ABGR8888,
1026 DRM_FORMAT_ARGB8888,
1027 DRM_FORMAT_XBGR8888,
1028 DRM_FORMAT_XRGB8888,
1029 DRM_FORMAT_XBGR2101010,
1030 DRM_FORMAT_ABGR2101010,
1031 DRM_FORMAT_YUYV,
1032 DRM_FORMAT_YVYU,
1033 DRM_FORMAT_UYVY,
1034 DRM_FORMAT_VYUY,
1035};
1036
b840d907 1037int
7f1f3851 1038intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
b840d907
JB
1039{
1040 struct intel_plane *intel_plane;
1041 unsigned long possible_crtcs;
d1686ae3
CW
1042 const uint32_t *plane_formats;
1043 int num_plane_formats;
b840d907
JB
1044 int ret;
1045
d1686ae3 1046 if (INTEL_INFO(dev)->gen < 5)
b840d907 1047 return -ENODEV;
b840d907 1048
b14c5679 1049 intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL);
b840d907
JB
1050 if (!intel_plane)
1051 return -ENOMEM;
1052
d1686ae3
CW
1053 switch (INTEL_INFO(dev)->gen) {
1054 case 5:
1055 case 6:
2d354c34 1056 intel_plane->can_scale = true;
b840d907 1057 intel_plane->max_downscale = 16;
d1686ae3
CW
1058 intel_plane->update_plane = ilk_update_plane;
1059 intel_plane->disable_plane = ilk_disable_plane;
1060 intel_plane->update_colorkey = ilk_update_colorkey;
1061 intel_plane->get_colorkey = ilk_get_colorkey;
1062
1063 if (IS_GEN6(dev)) {
1064 plane_formats = snb_plane_formats;
1065 num_plane_formats = ARRAY_SIZE(snb_plane_formats);
1066 } else {
1067 plane_formats = ilk_plane_formats;
1068 num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
1069 }
1070 break;
1071
1072 case 7:
d49f7091 1073 if (IS_IVYBRIDGE(dev)) {
2d354c34 1074 intel_plane->can_scale = true;
d49f7091
DL
1075 intel_plane->max_downscale = 2;
1076 } else {
1077 intel_plane->can_scale = false;
1078 intel_plane->max_downscale = 1;
1079 }
7f1f3851
JB
1080
1081 if (IS_VALLEYVIEW(dev)) {
7f1f3851
JB
1082 intel_plane->update_plane = vlv_update_plane;
1083 intel_plane->disable_plane = vlv_disable_plane;
1084 intel_plane->update_colorkey = vlv_update_colorkey;
1085 intel_plane->get_colorkey = vlv_get_colorkey;
1086
1087 plane_formats = vlv_plane_formats;
1088 num_plane_formats = ARRAY_SIZE(vlv_plane_formats);
1089 } else {
7f1f3851
JB
1090 intel_plane->update_plane = ivb_update_plane;
1091 intel_plane->disable_plane = ivb_disable_plane;
1092 intel_plane->update_colorkey = ivb_update_colorkey;
1093 intel_plane->get_colorkey = ivb_get_colorkey;
1094
1095 plane_formats = snb_plane_formats;
1096 num_plane_formats = ARRAY_SIZE(snb_plane_formats);
1097 }
d1686ae3
CW
1098 break;
1099
1100 default:
a8b0bbab 1101 kfree(intel_plane);
d1686ae3 1102 return -ENODEV;
b840d907
JB
1103 }
1104
1105 intel_plane->pipe = pipe;
7f1f3851 1106 intel_plane->plane = plane;
b840d907
JB
1107 possible_crtcs = (1 << pipe);
1108 ret = drm_plane_init(dev, &intel_plane->base, possible_crtcs,
d1686ae3
CW
1109 &intel_plane_funcs,
1110 plane_formats, num_plane_formats,
1111 false);
b840d907
JB
1112 if (ret)
1113 kfree(intel_plane);
1114
1115 return ret;
1116}