Commit | Line | Data |
---|---|---|
77c5f5d2 MCC |
1 | /* |
2 | * GHES/EDAC Linux driver | |
3 | * | |
4 | * This file may be distributed under the terms of the GNU General Public | |
5 | * License version 2. | |
6 | * | |
37e59f87 | 7 | * Copyright (c) 2013 by Mauro Carvalho Chehab |
77c5f5d2 MCC |
8 | * |
9 | * Red Hat Inc. http://www.redhat.com | |
10 | */ | |
11 | ||
d2a68566 MCC |
12 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt |
13 | ||
77c5f5d2 MCC |
14 | #include <acpi/ghes.h> |
15 | #include <linux/edac.h> | |
32fa1f53 | 16 | #include <linux/dmi.h> |
78d88e8a | 17 | #include "edac_module.h" |
8ae8f50a | 18 | #include <ras/ras_event.h> |
77c5f5d2 | 19 | |
77c5f5d2 MCC |
20 | struct ghes_edac_pvt { |
21 | struct list_head list; | |
22 | struct ghes *ghes; | |
23 | struct mem_ctl_info *mci; | |
689c9cd8 MCC |
24 | |
25 | /* Buffers for the error handling routine */ | |
8ae8f50a | 26 | char detail_location[240]; |
689c9cd8 MCC |
27 | char other_detail[160]; |
28 | char msg[80]; | |
77c5f5d2 MCC |
29 | }; |
30 | ||
31 | static LIST_HEAD(ghes_reglist); | |
32 | static DEFINE_MUTEX(ghes_edac_lock); | |
33 | static int ghes_edac_mc_num; | |
34 | ||
d2a68566 | 35 | |
32fa1f53 MCC |
36 | /* Memory Device - Type 17 of SMBIOS spec */ |
37 | struct memdev_dmi_entry { | |
38 | u8 type; | |
39 | u8 length; | |
40 | u16 handle; | |
41 | u16 phys_mem_array_handle; | |
42 | u16 mem_err_info_handle; | |
43 | u16 total_width; | |
44 | u16 data_width; | |
45 | u16 size; | |
46 | u8 form_factor; | |
47 | u8 device_set; | |
48 | u8 device_locator; | |
49 | u8 bank_locator; | |
50 | u8 memory_type; | |
51 | u16 type_detail; | |
52 | u16 speed; | |
53 | u8 manufacturer; | |
54 | u8 serial_number; | |
55 | u8 asset_tag; | |
56 | u8 part_number; | |
57 | u8 attributes; | |
58 | u32 extended_size; | |
59 | u16 conf_mem_clk_speed; | |
60 | } __attribute__((__packed__)); | |
61 | ||
62 | struct ghes_edac_dimm_fill { | |
63 | struct mem_ctl_info *mci; | |
64 | unsigned count; | |
65 | }; | |
66 | ||
32fa1f53 MCC |
67 | static void ghes_edac_count_dimms(const struct dmi_header *dh, void *arg) |
68 | { | |
69 | int *num_dimm = arg; | |
70 | ||
71 | if (dh->type == DMI_ENTRY_MEM_DEVICE) | |
72 | (*num_dimm)++; | |
73 | } | |
74 | ||
75 | static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg) | |
76 | { | |
77 | struct ghes_edac_dimm_fill *dimm_fill = arg; | |
78 | struct mem_ctl_info *mci = dimm_fill->mci; | |
79 | ||
80 | if (dh->type == DMI_ENTRY_MEM_DEVICE) { | |
81 | struct memdev_dmi_entry *entry = (struct memdev_dmi_entry *)dh; | |
82 | struct dimm_info *dimm = EDAC_DIMM_PTR(mci->layers, mci->dimms, | |
83 | mci->n_layers, | |
84 | dimm_fill->count, 0, 0); | |
85 | ||
86 | if (entry->size == 0xffff) { | |
d2a68566 MCC |
87 | pr_info("Can't get DIMM%i size\n", |
88 | dimm_fill->count); | |
32fa1f53 MCC |
89 | dimm->nr_pages = MiB_TO_PAGES(32);/* Unknown */ |
90 | } else if (entry->size == 0x7fff) { | |
91 | dimm->nr_pages = MiB_TO_PAGES(entry->extended_size); | |
92 | } else { | |
93 | if (entry->size & 1 << 15) | |
94 | dimm->nr_pages = MiB_TO_PAGES((entry->size & | |
95 | 0x7fff) << 10); | |
96 | else | |
97 | dimm->nr_pages = MiB_TO_PAGES(entry->size); | |
98 | } | |
99 | ||
100 | switch (entry->memory_type) { | |
101 | case 0x12: | |
102 | if (entry->type_detail & 1 << 13) | |
103 | dimm->mtype = MEM_RDDR; | |
104 | else | |
105 | dimm->mtype = MEM_DDR; | |
106 | break; | |
107 | case 0x13: | |
108 | if (entry->type_detail & 1 << 13) | |
109 | dimm->mtype = MEM_RDDR2; | |
110 | else | |
111 | dimm->mtype = MEM_DDR2; | |
112 | break; | |
113 | case 0x14: | |
114 | dimm->mtype = MEM_FB_DDR2; | |
115 | break; | |
116 | case 0x18: | |
117 | if (entry->type_detail & 1 << 13) | |
118 | dimm->mtype = MEM_RDDR3; | |
119 | else | |
120 | dimm->mtype = MEM_DDR3; | |
121 | break; | |
122 | default: | |
123 | if (entry->type_detail & 1 << 6) | |
124 | dimm->mtype = MEM_RMBS; | |
125 | else if ((entry->type_detail & ((1 << 7) | (1 << 13))) | |
126 | == ((1 << 7) | (1 << 13))) | |
127 | dimm->mtype = MEM_RDR; | |
128 | else if (entry->type_detail & 1 << 7) | |
129 | dimm->mtype = MEM_SDR; | |
130 | else if (entry->type_detail & 1 << 9) | |
131 | dimm->mtype = MEM_EDO; | |
132 | else | |
133 | dimm->mtype = MEM_UNKNOWN; | |
134 | } | |
135 | ||
136 | /* | |
137 | * Actually, we can only detect if the memory has bits for | |
138 | * checksum or not | |
139 | */ | |
140 | if (entry->total_width == entry->data_width) | |
141 | dimm->edac_mode = EDAC_NONE; | |
142 | else | |
143 | dimm->edac_mode = EDAC_SECDED; | |
144 | ||
145 | dimm->dtype = DEV_UNKNOWN; | |
146 | dimm->grain = 128; /* Likely, worse case */ | |
147 | ||
148 | /* | |
149 | * FIXME: It shouldn't be hard to also fill the DIMM labels | |
150 | */ | |
151 | ||
152 | if (dimm->nr_pages) { | |
d2a68566 | 153 | edac_dbg(1, "DIMM%i: %s size = %d MB%s\n", |
58a9c251 | 154 | dimm_fill->count, edac_mem_types[dimm->mtype], |
32fa1f53 MCC |
155 | PAGES_TO_MiB(dimm->nr_pages), |
156 | (dimm->edac_mode != EDAC_NONE) ? "(ECC)" : ""); | |
d2a68566 | 157 | edac_dbg(2, "\ttype %d, detail 0x%02x, width %d(total %d)\n", |
32fa1f53 MCC |
158 | entry->memory_type, entry->type_detail, |
159 | entry->total_width, entry->data_width); | |
160 | } | |
161 | ||
162 | dimm_fill->count++; | |
163 | } | |
164 | } | |
165 | ||
77c5f5d2 | 166 | void ghes_edac_report_mem_error(struct ghes *ghes, int sev, |
f04c62a7 | 167 | struct cper_sec_mem_err *mem_err) |
77c5f5d2 | 168 | { |
f04c62a7 MCC |
169 | enum hw_event_mc_err_type type; |
170 | struct edac_raw_error_desc *e; | |
171 | struct mem_ctl_info *mci; | |
172 | struct ghes_edac_pvt *pvt = NULL; | |
689c9cd8 | 173 | char *p; |
8ae8f50a | 174 | u8 grain_bits; |
f04c62a7 MCC |
175 | |
176 | list_for_each_entry(pvt, &ghes_reglist, list) { | |
177 | if (ghes == pvt->ghes) | |
178 | break; | |
179 | } | |
180 | if (!pvt) { | |
181 | pr_err("Internal error: Can't find EDAC structure\n"); | |
182 | return; | |
183 | } | |
184 | mci = pvt->mci; | |
185 | e = &mci->error_desc; | |
186 | ||
187 | /* Cleans the error report buffer */ | |
188 | memset(e, 0, sizeof (*e)); | |
189 | e->error_count = 1; | |
689c9cd8 MCC |
190 | strcpy(e->label, "unknown label"); |
191 | e->msg = pvt->msg; | |
192 | e->other_detail = pvt->other_detail; | |
193 | e->top_layer = -1; | |
194 | e->mid_layer = -1; | |
195 | e->low_layer = -1; | |
196 | *pvt->other_detail = '\0'; | |
197 | *pvt->msg = '\0'; | |
f04c62a7 MCC |
198 | |
199 | switch (sev) { | |
200 | case GHES_SEV_CORRECTED: | |
201 | type = HW_EVENT_ERR_CORRECTED; | |
202 | break; | |
203 | case GHES_SEV_RECOVERABLE: | |
204 | type = HW_EVENT_ERR_UNCORRECTED; | |
205 | break; | |
206 | case GHES_SEV_PANIC: | |
207 | type = HW_EVENT_ERR_FATAL; | |
208 | break; | |
209 | default: | |
210 | case GHES_SEV_NO: | |
211 | type = HW_EVENT_ERR_INFO; | |
212 | } | |
213 | ||
689c9cd8 MCC |
214 | edac_dbg(1, "error validation_bits: 0x%08llx\n", |
215 | (long long)mem_err->validation_bits); | |
216 | ||
217 | /* Error type, mapped on e->msg */ | |
218 | if (mem_err->validation_bits & CPER_MEM_VALID_ERROR_TYPE) { | |
219 | p = pvt->msg; | |
220 | switch (mem_err->error_type) { | |
221 | case 0: | |
222 | p += sprintf(p, "Unknown"); | |
223 | break; | |
224 | case 1: | |
225 | p += sprintf(p, "No error"); | |
226 | break; | |
227 | case 2: | |
228 | p += sprintf(p, "Single-bit ECC"); | |
229 | break; | |
230 | case 3: | |
231 | p += sprintf(p, "Multi-bit ECC"); | |
232 | break; | |
233 | case 4: | |
234 | p += sprintf(p, "Single-symbol ChipKill ECC"); | |
235 | break; | |
236 | case 5: | |
237 | p += sprintf(p, "Multi-symbol ChipKill ECC"); | |
238 | break; | |
239 | case 6: | |
240 | p += sprintf(p, "Master abort"); | |
241 | break; | |
242 | case 7: | |
243 | p += sprintf(p, "Target abort"); | |
244 | break; | |
245 | case 8: | |
246 | p += sprintf(p, "Parity Error"); | |
247 | break; | |
248 | case 9: | |
249 | p += sprintf(p, "Watchdog timeout"); | |
250 | break; | |
251 | case 10: | |
252 | p += sprintf(p, "Invalid address"); | |
253 | break; | |
254 | case 11: | |
255 | p += sprintf(p, "Mirror Broken"); | |
256 | break; | |
257 | case 12: | |
258 | p += sprintf(p, "Memory Sparing"); | |
259 | break; | |
260 | case 13: | |
261 | p += sprintf(p, "Scrub corrected error"); | |
262 | break; | |
263 | case 14: | |
264 | p += sprintf(p, "Scrub uncorrected error"); | |
265 | break; | |
266 | case 15: | |
267 | p += sprintf(p, "Physical Memory Map-out event"); | |
268 | break; | |
269 | default: | |
270 | p += sprintf(p, "reserved error (%d)", | |
271 | mem_err->error_type); | |
272 | } | |
273 | } else { | |
274 | strcpy(pvt->msg, "unknown error"); | |
275 | } | |
276 | ||
277 | /* Error address */ | |
147de147 | 278 | if (mem_err->validation_bits & CPER_MEM_VALID_PA) { |
689c9cd8 MCC |
279 | e->page_frame_number = mem_err->physical_addr >> PAGE_SHIFT; |
280 | e->offset_in_page = mem_err->physical_addr & ~PAGE_MASK; | |
281 | } | |
282 | ||
283 | /* Error grain */ | |
147de147 | 284 | if (mem_err->validation_bits & CPER_MEM_VALID_PA_MASK) |
689c9cd8 | 285 | e->grain = ~(mem_err->physical_addr_mask & ~PAGE_MASK); |
689c9cd8 MCC |
286 | |
287 | /* Memory error location, mapped on e->location */ | |
288 | p = e->location; | |
289 | if (mem_err->validation_bits & CPER_MEM_VALID_NODE) | |
290 | p += sprintf(p, "node:%d ", mem_err->node); | |
291 | if (mem_err->validation_bits & CPER_MEM_VALID_CARD) | |
292 | p += sprintf(p, "card:%d ", mem_err->card); | |
293 | if (mem_err->validation_bits & CPER_MEM_VALID_MODULE) | |
294 | p += sprintf(p, "module:%d ", mem_err->module); | |
56507694 CG |
295 | if (mem_err->validation_bits & CPER_MEM_VALID_RANK_NUMBER) |
296 | p += sprintf(p, "rank:%d ", mem_err->rank); | |
689c9cd8 MCC |
297 | if (mem_err->validation_bits & CPER_MEM_VALID_BANK) |
298 | p += sprintf(p, "bank:%d ", mem_err->bank); | |
299 | if (mem_err->validation_bits & CPER_MEM_VALID_ROW) | |
300 | p += sprintf(p, "row:%d ", mem_err->row); | |
301 | if (mem_err->validation_bits & CPER_MEM_VALID_COLUMN) | |
302 | p += sprintf(p, "col:%d ", mem_err->column); | |
303 | if (mem_err->validation_bits & CPER_MEM_VALID_BIT_POSITION) | |
304 | p += sprintf(p, "bit_pos:%d ", mem_err->bit_pos); | |
56507694 CG |
305 | if (mem_err->validation_bits & CPER_MEM_VALID_MODULE_HANDLE) { |
306 | const char *bank = NULL, *device = NULL; | |
307 | dmi_memdev_name(mem_err->mem_dev_handle, &bank, &device); | |
308 | if (bank != NULL && device != NULL) | |
309 | p += sprintf(p, "DIMM location:%s %s ", bank, device); | |
310 | else | |
311 | p += sprintf(p, "DIMM DMI handle: 0x%.4x ", | |
312 | mem_err->mem_dev_handle); | |
313 | } | |
689c9cd8 MCC |
314 | if (p > e->location) |
315 | *(p - 1) = '\0'; | |
316 | ||
317 | /* All other fields are mapped on e->other_detail */ | |
318 | p = pvt->other_detail; | |
319 | if (mem_err->validation_bits & CPER_MEM_VALID_ERROR_STATUS) { | |
320 | u64 status = mem_err->error_status; | |
321 | ||
322 | p += sprintf(p, "status(0x%016llx): ", (long long)status); | |
323 | switch ((status >> 8) & 0xff) { | |
324 | case 1: | |
325 | p += sprintf(p, "Error detected internal to the component "); | |
326 | break; | |
327 | case 16: | |
328 | p += sprintf(p, "Error detected in the bus "); | |
329 | break; | |
330 | case 4: | |
331 | p += sprintf(p, "Storage error in DRAM memory "); | |
332 | break; | |
333 | case 5: | |
334 | p += sprintf(p, "Storage error in TLB "); | |
335 | break; | |
336 | case 6: | |
337 | p += sprintf(p, "Storage error in cache "); | |
338 | break; | |
339 | case 7: | |
340 | p += sprintf(p, "Error in one or more functional units "); | |
341 | break; | |
342 | case 8: | |
343 | p += sprintf(p, "component failed self test "); | |
344 | break; | |
345 | case 9: | |
346 | p += sprintf(p, "Overflow or undervalue of internal queue "); | |
347 | break; | |
348 | case 17: | |
349 | p += sprintf(p, "Virtual address not found on IO-TLB or IO-PDIR "); | |
350 | break; | |
351 | case 18: | |
352 | p += sprintf(p, "Improper access error "); | |
353 | break; | |
354 | case 19: | |
355 | p += sprintf(p, "Access to a memory address which is not mapped to any component "); | |
356 | break; | |
357 | case 20: | |
358 | p += sprintf(p, "Loss of Lockstep "); | |
359 | break; | |
360 | case 21: | |
361 | p += sprintf(p, "Response not associated with a request "); | |
362 | break; | |
363 | case 22: | |
364 | p += sprintf(p, "Bus parity error - must also set the A, C, or D Bits "); | |
365 | break; | |
366 | case 23: | |
367 | p += sprintf(p, "Detection of a PATH_ERROR "); | |
368 | break; | |
369 | case 25: | |
370 | p += sprintf(p, "Bus operation timeout "); | |
371 | break; | |
372 | case 26: | |
373 | p += sprintf(p, "A read was issued to data that has been poisoned "); | |
374 | break; | |
375 | default: | |
376 | p += sprintf(p, "reserved "); | |
377 | break; | |
378 | } | |
379 | } | |
380 | if (mem_err->validation_bits & CPER_MEM_VALID_REQUESTOR_ID) | |
381 | p += sprintf(p, "requestorID: 0x%016llx ", | |
382 | (long long)mem_err->requestor_id); | |
383 | if (mem_err->validation_bits & CPER_MEM_VALID_RESPONDER_ID) | |
384 | p += sprintf(p, "responderID: 0x%016llx ", | |
385 | (long long)mem_err->responder_id); | |
386 | if (mem_err->validation_bits & CPER_MEM_VALID_TARGET_ID) | |
387 | p += sprintf(p, "targetID: 0x%016llx ", | |
388 | (long long)mem_err->responder_id); | |
389 | if (p > pvt->other_detail) | |
390 | *(p - 1) = '\0'; | |
f04c62a7 | 391 | |
8ae8f50a MCC |
392 | /* Generate the trace event */ |
393 | grain_bits = fls_long(e->grain); | |
665aa8cd DC |
394 | snprintf(pvt->detail_location, sizeof(pvt->detail_location), |
395 | "APEI location: %s %s", e->location, e->other_detail); | |
8ae8f50a MCC |
396 | trace_mc_event(type, e->msg, e->label, e->error_count, |
397 | mci->mc_idx, e->top_layer, e->mid_layer, e->low_layer, | |
990995ba | 398 | (e->page_frame_number << PAGE_SHIFT) | e->offset_in_page, |
8ae8f50a MCC |
399 | grain_bits, e->syndrome, pvt->detail_location); |
400 | ||
401 | /* Report the error via EDAC API */ | |
f04c62a7 | 402 | edac_raw_mc_handle_error(type, mci, e); |
77c5f5d2 | 403 | } |
77c5f5d2 MCC |
404 | |
405 | int ghes_edac_register(struct ghes *ghes, struct device *dev) | |
406 | { | |
32fa1f53 MCC |
407 | bool fake = false; |
408 | int rc, num_dimm = 0; | |
77c5f5d2 MCC |
409 | struct mem_ctl_info *mci; |
410 | struct edac_mc_layer layers[1]; | |
77c5f5d2 | 411 | struct ghes_edac_pvt *pvt; |
32fa1f53 MCC |
412 | struct ghes_edac_dimm_fill dimm_fill; |
413 | ||
414 | /* Get the number of DIMMs */ | |
415 | dmi_walk(ghes_edac_count_dimms, &num_dimm); | |
416 | ||
417 | /* Check if we've got a bogus BIOS */ | |
418 | if (num_dimm == 0) { | |
419 | fake = true; | |
420 | num_dimm = 1; | |
421 | } | |
77c5f5d2 MCC |
422 | |
423 | layers[0].type = EDAC_MC_LAYER_ALL_MEM; | |
32fa1f53 | 424 | layers[0].size = num_dimm; |
77c5f5d2 MCC |
425 | layers[0].is_virt_csrow = true; |
426 | ||
427 | /* | |
428 | * We need to serialize edac_mc_alloc() and edac_mc_add_mc(), | |
429 | * to avoid duplicated memory controller numbers | |
430 | */ | |
431 | mutex_lock(&ghes_edac_lock); | |
432 | mci = edac_mc_alloc(ghes_edac_mc_num, ARRAY_SIZE(layers), layers, | |
433 | sizeof(*pvt)); | |
434 | if (!mci) { | |
d2a68566 | 435 | pr_info("Can't allocate memory for EDAC data\n"); |
77c5f5d2 MCC |
436 | mutex_unlock(&ghes_edac_lock); |
437 | return -ENOMEM; | |
438 | } | |
439 | ||
440 | pvt = mci->pvt_info; | |
441 | memset(pvt, 0, sizeof(*pvt)); | |
f04c62a7 | 442 | list_add_tail(&pvt->list, &ghes_reglist); |
77c5f5d2 MCC |
443 | pvt->ghes = ghes; |
444 | pvt->mci = mci; | |
445 | mci->pdev = dev; | |
446 | ||
447 | mci->mtype_cap = MEM_FLAG_EMPTY; | |
448 | mci->edac_ctl_cap = EDAC_FLAG_NONE; | |
449 | mci->edac_cap = EDAC_FLAG_NONE; | |
450 | mci->mod_name = "ghes_edac.c"; | |
77c5f5d2 MCC |
451 | mci->ctl_name = "ghes_edac"; |
452 | mci->dev_name = "ghes"; | |
453 | ||
d2a68566 MCC |
454 | if (!ghes_edac_mc_num) { |
455 | if (!fake) { | |
456 | pr_info("This EDAC driver relies on BIOS to enumerate memory and get error reports.\n"); | |
457 | pr_info("Unfortunately, not all BIOSes reflect the memory layout correctly.\n"); | |
458 | pr_info("So, the end result of using this driver varies from vendor to vendor.\n"); | |
459 | pr_info("If you find incorrect reports, please contact your hardware vendor\n"); | |
460 | pr_info("to correct its BIOS.\n"); | |
461 | pr_info("This system has %d DIMM sockets.\n", | |
462 | num_dimm); | |
463 | } else { | |
464 | pr_info("This system has a very crappy BIOS: It doesn't even list the DIMMS.\n"); | |
465 | pr_info("Its SMBIOS info is wrong. It is doubtful that the error report would\n"); | |
466 | pr_info("work on such system. Use this driver with caution\n"); | |
467 | } | |
468 | } | |
469 | ||
32fa1f53 | 470 | if (!fake) { |
5ee726db MCC |
471 | /* |
472 | * Fill DIMM info from DMI for the memory controller #0 | |
473 | * | |
474 | * Keep it in blank for the other memory controllers, as | |
475 | * there's no reliable way to properly credit each DIMM to | |
476 | * the memory controller, as different BIOSes fill the | |
477 | * DMI bank location fields on different ways | |
478 | */ | |
479 | if (!ghes_edac_mc_num) { | |
480 | dimm_fill.count = 0; | |
481 | dimm_fill.mci = mci; | |
482 | dmi_walk(ghes_edac_dmidecode, &dimm_fill); | |
483 | } | |
32fa1f53 MCC |
484 | } else { |
485 | struct dimm_info *dimm = EDAC_DIMM_PTR(mci->layers, mci->dimms, | |
486 | mci->n_layers, 0, 0, 0); | |
77c5f5d2 | 487 | |
d2a68566 | 488 | dimm->nr_pages = 1; |
32fa1f53 MCC |
489 | dimm->grain = 128; |
490 | dimm->mtype = MEM_UNKNOWN; | |
491 | dimm->dtype = DEV_UNKNOWN; | |
492 | dimm->edac_mode = EDAC_SECDED; | |
493 | } | |
77c5f5d2 MCC |
494 | |
495 | rc = edac_mc_add_mc(mci); | |
496 | if (rc < 0) { | |
d2a68566 | 497 | pr_info("Can't register at EDAC core\n"); |
77c5f5d2 MCC |
498 | edac_mc_free(mci); |
499 | mutex_unlock(&ghes_edac_lock); | |
500 | return -ENODEV; | |
501 | } | |
502 | ||
503 | ghes_edac_mc_num++; | |
504 | mutex_unlock(&ghes_edac_lock); | |
505 | return 0; | |
506 | } | |
77c5f5d2 MCC |
507 | |
508 | void ghes_edac_unregister(struct ghes *ghes) | |
509 | { | |
510 | struct mem_ctl_info *mci; | |
5dae92a7 | 511 | struct ghes_edac_pvt *pvt, *tmp; |
77c5f5d2 | 512 | |
5dae92a7 | 513 | list_for_each_entry_safe(pvt, tmp, &ghes_reglist, list) { |
77c5f5d2 MCC |
514 | if (ghes == pvt->ghes) { |
515 | mci = pvt->mci; | |
516 | edac_mc_del_mc(mci->pdev); | |
517 | edac_mc_free(mci); | |
518 | list_del(&pvt->list); | |
519 | } | |
520 | } | |
521 | } |