Commit | Line | Data |
---|---|---|
9f8f2064 JA |
1 | #include <stdio.h> |
2 | #include <string.h> | |
9f8f2064 JA |
3 | #include <sys/types.h> |
4 | #include <sys/stat.h> | |
036a1599 | 5 | #include <sys/sysmacros.h> |
9f8f2064 JA |
6 | #include <dirent.h> |
7 | #include <libgen.h> | |
4f37732a BVA |
8 | #ifdef CONFIG_VALGRIND_DEV |
9 | #include <valgrind/drd.h> | |
10 | #else | |
11 | #define DRD_IGNORE_VAR(x) do { } while (0) | |
12 | #endif | |
9f8f2064 JA |
13 | |
14 | #include "fio.h" | |
c97bd0fa | 15 | #include "smalloc.h" |
7c9b1bce | 16 | #include "diskutil.h" |
a39fb9ea | 17 | #include "helper_thread.h" |
9f8f2064 JA |
18 | |
19 | static int last_majdev, last_mindev; | |
c97bd0fa | 20 | static struct disk_util *last_du; |
9f8f2064 | 21 | |
971caeb1 | 22 | static struct fio_sem *disk_util_sem; |
9ec7779f | 23 | |
2db4ecca JA |
24 | static struct disk_util *__init_per_file_disk_util(struct thread_data *td, |
25 | int majdev, int mindev, char *path); | |
26 | ||
c97bd0fa JA |
27 | static void disk_util_free(struct disk_util *du) |
28 | { | |
29 | if (du == last_du) | |
30 | last_du = NULL; | |
31 | ||
b8d541d5 JA |
32 | while (!flist_empty(&du->slaves)) { |
33 | struct disk_util *slave; | |
34 | ||
9342d5f8 | 35 | slave = flist_first_entry(&du->slaves, struct disk_util, slavelist); |
b8d541d5 JA |
36 | flist_del(&slave->slavelist); |
37 | slave->users--; | |
38 | } | |
93bcfd20 | 39 | |
971caeb1 | 40 | fio_sem_remove(du->lock); |
2a20eebc | 41 | free(du->sysfs_root); |
c97bd0fa JA |
42 | sfree(du); |
43 | } | |
44 | ||
9f8f2064 JA |
45 | static int get_io_ticks(struct disk_util *du, struct disk_util_stat *dus) |
46 | { | |
47 | unsigned in_flight; | |
d09a64a0 | 48 | unsigned long long sectors[2]; |
9f8f2064 JA |
49 | char line[256]; |
50 | FILE *f; | |
51 | char *p; | |
5ec10eaa | 52 | int ret; |
9f8f2064 | 53 | |
cd991b9e JA |
54 | dprint(FD_DISKUTIL, "open stat file: %s\n", du->path); |
55 | ||
9f8f2064 JA |
56 | f = fopen(du->path, "r"); |
57 | if (!f) | |
58 | return 1; | |
59 | ||
60 | p = fgets(line, sizeof(line), f); | |
61 | if (!p) { | |
62 | fclose(f); | |
63 | return 1; | |
64 | } | |
65 | ||
cd991b9e JA |
66 | dprint(FD_DISKUTIL, "%s: %s", du->path, p); |
67 | ||
504bc961 JA |
68 | ret = sscanf(p, "%llu %llu %llu %llu %llu %llu %llu %llu %u %llu %llu\n", |
69 | (unsigned long long *) &dus->s.ios[0], | |
70 | (unsigned long long *) &dus->s.merges[0], | |
71 | §ors[0], | |
72 | (unsigned long long *) &dus->s.ticks[0], | |
73 | (unsigned long long *) &dus->s.ios[1], | |
74 | (unsigned long long *) &dus->s.merges[1], | |
75 | §ors[1], | |
76 | (unsigned long long *) &dus->s.ticks[1], | |
77 | &in_flight, | |
78 | (unsigned long long *) &dus->s.io_ticks, | |
79 | (unsigned long long *) &dus->s.time_in_queue); | |
9f8f2064 | 80 | fclose(f); |
cd991b9e | 81 | dprint(FD_DISKUTIL, "%s: stat read ok? %d\n", du->path, ret == 1); |
a3b4cf7d JA |
82 | dus->s.sectors[0] = sectors[0]; |
83 | dus->s.sectors[1] = sectors[1]; | |
cd991b9e | 84 | return ret != 11; |
9f8f2064 JA |
85 | } |
86 | ||
87 | static void update_io_tick_disk(struct disk_util *du) | |
88 | { | |
89 | struct disk_util_stat __dus, *dus, *ldus; | |
8b6a404c | 90 | struct timespec t; |
9f8f2064 | 91 | |
c97bd0fa JA |
92 | if (!du->users) |
93 | return; | |
90b97ac3 JA |
94 | if (get_io_ticks(du, &__dus)) |
95 | return; | |
9f8f2064 JA |
96 | |
97 | dus = &du->dus; | |
98 | ldus = &du->last_dus; | |
99 | ||
a3b4cf7d JA |
100 | dus->s.sectors[0] += (__dus.s.sectors[0] - ldus->s.sectors[0]); |
101 | dus->s.sectors[1] += (__dus.s.sectors[1] - ldus->s.sectors[1]); | |
102 | dus->s.ios[0] += (__dus.s.ios[0] - ldus->s.ios[0]); | |
103 | dus->s.ios[1] += (__dus.s.ios[1] - ldus->s.ios[1]); | |
104 | dus->s.merges[0] += (__dus.s.merges[0] - ldus->s.merges[0]); | |
105 | dus->s.merges[1] += (__dus.s.merges[1] - ldus->s.merges[1]); | |
106 | dus->s.ticks[0] += (__dus.s.ticks[0] - ldus->s.ticks[0]); | |
107 | dus->s.ticks[1] += (__dus.s.ticks[1] - ldus->s.ticks[1]); | |
108 | dus->s.io_ticks += (__dus.s.io_ticks - ldus->s.io_ticks); | |
109 | dus->s.time_in_queue += (__dus.s.time_in_queue - ldus->s.time_in_queue); | |
9f8f2064 JA |
110 | |
111 | fio_gettime(&t, NULL); | |
a3b4cf7d | 112 | dus->s.msec += mtime_since(&du->time, &t); |
9f8f2064 | 113 | memcpy(&du->time, &t, sizeof(t)); |
a3b4cf7d | 114 | memcpy(&ldus->s, &__dus.s, sizeof(__dus.s)); |
9f8f2064 JA |
115 | } |
116 | ||
9ec7779f | 117 | int update_io_ticks(void) |
9f8f2064 | 118 | { |
01743ee1 | 119 | struct flist_head *entry; |
9f8f2064 | 120 | struct disk_util *du; |
9ec7779f | 121 | int ret = 0; |
9f8f2064 | 122 | |
cd991b9e JA |
123 | dprint(FD_DISKUTIL, "update io ticks\n"); |
124 | ||
971caeb1 | 125 | fio_sem_down(disk_util_sem); |
9ec7779f | 126 | |
a47591e4 | 127 | if (!helper_should_exit()) { |
9ec7779f JA |
128 | flist_for_each(entry, &disk_list) { |
129 | du = flist_entry(entry, struct disk_util, list); | |
130 | update_io_tick_disk(du); | |
131 | } | |
132 | } else | |
133 | ret = 1; | |
134 | ||
971caeb1 | 135 | fio_sem_up(disk_util_sem); |
9ec7779f | 136 | return ret; |
9f8f2064 JA |
137 | } |
138 | ||
e11c410c | 139 | static struct disk_util *disk_util_exists(int major, int minor) |
9f8f2064 | 140 | { |
01743ee1 | 141 | struct flist_head *entry; |
9f8f2064 JA |
142 | struct disk_util *du; |
143 | ||
971caeb1 | 144 | fio_sem_down(disk_util_sem); |
9ec7779f | 145 | |
01743ee1 JA |
146 | flist_for_each(entry, &disk_list) { |
147 | du = flist_entry(entry, struct disk_util, list); | |
9f8f2064 | 148 | |
9ec7779f | 149 | if (major == du->major && minor == du->minor) { |
971caeb1 | 150 | fio_sem_up(disk_util_sem); |
e11c410c | 151 | return du; |
9ec7779f | 152 | } |
9f8f2064 JA |
153 | } |
154 | ||
971caeb1 | 155 | fio_sem_up(disk_util_sem); |
e11c410c | 156 | return NULL; |
9f8f2064 JA |
157 | } |
158 | ||
67423013 ST |
159 | static int get_device_numbers(char *file_name, int *maj, int *min) |
160 | { | |
161 | struct stat st; | |
162 | int majdev, mindev; | |
163 | char tempname[PATH_MAX], *p; | |
164 | ||
165 | if (!lstat(file_name, &st)) { | |
166 | if (S_ISBLK(st.st_mode)) { | |
167 | majdev = major(st.st_rdev); | |
168 | mindev = minor(st.st_rdev); | |
38297555 ES |
169 | } else if (S_ISCHR(st.st_mode) || |
170 | S_ISFIFO(st.st_mode)) { | |
67423013 | 171 | return -1; |
38297555 | 172 | } else { |
67423013 ST |
173 | majdev = major(st.st_dev); |
174 | mindev = minor(st.st_dev); | |
175 | } | |
176 | } else { | |
177 | /* | |
178 | * must be a file, open "." in that path | |
179 | */ | |
59f94d26 | 180 | snprintf(tempname, FIO_ARRAY_SIZE(tempname), "%s", file_name); |
67423013 ST |
181 | p = dirname(tempname); |
182 | if (stat(p, &st)) { | |
183 | perror("disk util stat"); | |
184 | return -1; | |
185 | } | |
186 | ||
187 | majdev = major(st.st_dev); | |
188 | mindev = minor(st.st_dev); | |
189 | } | |
190 | ||
191 | *min = mindev; | |
192 | *maj = majdev; | |
193 | ||
194 | return 0; | |
195 | } | |
196 | ||
197 | static int read_block_dev_entry(char *path, int *maj, int *min) | |
198 | { | |
199 | char line[256], *p; | |
200 | FILE *f; | |
201 | ||
202 | f = fopen(path, "r"); | |
203 | if (!f) { | |
204 | perror("open path"); | |
205 | return 1; | |
206 | } | |
207 | ||
208 | p = fgets(line, sizeof(line), f); | |
209 | fclose(f); | |
210 | ||
211 | if (!p) | |
212 | return 1; | |
213 | ||
214 | if (sscanf(p, "%u:%u", maj, min) != 2) | |
215 | return 1; | |
216 | ||
217 | return 0; | |
218 | } | |
219 | ||
67423013 | 220 | static void find_add_disk_slaves(struct thread_data *td, char *path, |
2db4ecca | 221 | struct disk_util *masterdu) |
67423013 ST |
222 | { |
223 | DIR *dirhandle = NULL; | |
224 | struct dirent *dirent = NULL; | |
225 | char slavesdir[PATH_MAX], temppath[PATH_MAX], slavepath[PATH_MAX]; | |
226 | struct disk_util *slavedu = NULL; | |
227 | int majdev, mindev; | |
228 | ssize_t linklen; | |
229 | ||
2db4ecca | 230 | sprintf(slavesdir, "%s/%s", path, "slaves"); |
67423013 ST |
231 | dirhandle = opendir(slavesdir); |
232 | if (!dirhandle) | |
233 | return; | |
234 | ||
235 | while ((dirent = readdir(dirhandle)) != NULL) { | |
2db4ecca JA |
236 | if (!strcmp(dirent->d_name, ".") || |
237 | !strcmp(dirent->d_name, "..")) | |
67423013 ST |
238 | continue; |
239 | ||
b4d2bc70 BVA |
240 | nowarn_snprintf(temppath, sizeof(temppath), "%s/%s", slavesdir, |
241 | dirent->d_name); | |
67423013 ST |
242 | /* Can we always assume that the slaves device entries |
243 | * are links to the real directories for the slave | |
244 | * devices? | |
245 | */ | |
976406b8 | 246 | linklen = readlink(temppath, slavepath, PATH_MAX - 1); |
81286ecd | 247 | if (linklen < 0) { |
67423013 | 248 | perror("readlink() for slave device."); |
f0cc675f | 249 | closedir(dirhandle); |
67423013 ST |
250 | return; |
251 | } | |
2db4ecca | 252 | slavepath[linklen] = '\0'; |
67423013 | 253 | |
b4d2bc70 BVA |
254 | nowarn_snprintf(temppath, sizeof(temppath), "%s/%s/dev", |
255 | slavesdir, slavepath); | |
75d5519d | 256 | if (access(temppath, F_OK) != 0) |
b4d2bc70 BVA |
257 | nowarn_snprintf(temppath, sizeof(temppath), |
258 | "%s/%s/device/dev", slavesdir, | |
259 | slavepath); | |
67423013 | 260 | if (read_block_dev_entry(temppath, &majdev, &mindev)) { |
81286ecd | 261 | perror("Error getting slave device numbers"); |
f0cc675f | 262 | closedir(dirhandle); |
67423013 ST |
263 | return; |
264 | } | |
265 | ||
b06de82e AB |
266 | /* |
267 | * See if this maj,min already exists | |
268 | */ | |
269 | slavedu = disk_util_exists(majdev, mindev); | |
270 | if (slavedu) | |
271 | continue; | |
272 | ||
b4d2bc70 BVA |
273 | nowarn_snprintf(temppath, sizeof(temppath), "%s/%s", slavesdir, |
274 | slavepath); | |
67423013 ST |
275 | __init_per_file_disk_util(td, majdev, mindev, temppath); |
276 | slavedu = disk_util_exists(majdev, mindev); | |
277 | ||
278 | /* Should probably use an assert here. slavedu should | |
279 | * always be present at this point. */ | |
b8d541d5 JA |
280 | if (slavedu) { |
281 | slavedu->users++; | |
67423013 | 282 | flist_add_tail(&slavedu->slavelist, &masterdu->slaves); |
b8d541d5 | 283 | } |
67423013 ST |
284 | } |
285 | ||
286 | closedir(dirhandle); | |
67423013 ST |
287 | } |
288 | ||
b8fefc2b | 289 | static struct disk_util *disk_util_add(struct thread_data *td, int majdev, |
c97bd0fa | 290 | int mindev, char *path) |
9f8f2064 JA |
291 | { |
292 | struct disk_util *du, *__du; | |
01743ee1 | 293 | struct flist_head *entry; |
4b919f77 | 294 | int l; |
9f8f2064 | 295 | |
cd991b9e JA |
296 | dprint(FD_DISKUTIL, "add maj/min %d/%d: %s\n", majdev, mindev, path); |
297 | ||
c97bd0fa | 298 | du = smalloc(sizeof(*du)); |
81b3c86f | 299 | if (!du) |
fba5c5ff | 300 | return NULL; |
fba5c5ff | 301 | |
4f37732a | 302 | DRD_IGNORE_VAR(du->users); |
9f8f2064 | 303 | memset(du, 0, sizeof(*du)); |
01743ee1 | 304 | INIT_FLIST_HEAD(&du->list); |
4b919f77 KR |
305 | l = snprintf(du->path, sizeof(du->path), "%s/stat", path); |
306 | if (l < 0 || l >= sizeof(du->path)) { | |
307 | log_err("constructed path \"%.100s[...]/stat\" larger than buffer (%zu bytes)\n", | |
308 | path, sizeof(du->path) - 1); | |
309 | sfree(du); | |
310 | return NULL; | |
311 | } | |
59f94d26 | 312 | snprintf((char *) du->dus.name, FIO_ARRAY_SIZE(du->dus.name), "%s", |
36833fb0 | 313 | basename(path)); |
2a20eebc | 314 | du->sysfs_root = strdup(path); |
9f8f2064 JA |
315 | du->major = majdev; |
316 | du->minor = mindev; | |
67423013 ST |
317 | INIT_FLIST_HEAD(&du->slavelist); |
318 | INIT_FLIST_HEAD(&du->slaves); | |
971caeb1 | 319 | du->lock = fio_sem_init(FIO_SEM_UNLOCKED); |
c97bd0fa | 320 | du->users = 0; |
9f8f2064 | 321 | |
971caeb1 | 322 | fio_sem_down(disk_util_sem); |
9ec7779f | 323 | |
01743ee1 JA |
324 | flist_for_each(entry, &disk_list) { |
325 | __du = flist_entry(entry, struct disk_util, list); | |
9f8f2064 | 326 | |
d09a64a0 | 327 | dprint(FD_DISKUTIL, "found %s in list\n", __du->dus.name); |
cd991b9e | 328 | |
d09a64a0 | 329 | if (!strcmp((char *) du->dus.name, (char *) __du->dus.name)) { |
c97bd0fa | 330 | disk_util_free(du); |
971caeb1 | 331 | fio_sem_up(disk_util_sem); |
c97bd0fa | 332 | return __du; |
9f8f2064 JA |
333 | } |
334 | } | |
335 | ||
d09a64a0 | 336 | dprint(FD_DISKUTIL, "add %s to list\n", du->dus.name); |
cd991b9e | 337 | |
9f8f2064 JA |
338 | fio_gettime(&du->time, NULL); |
339 | get_io_ticks(du, &du->last_dus); | |
340 | ||
01743ee1 | 341 | flist_add_tail(&du->list, &disk_list); |
971caeb1 | 342 | fio_sem_up(disk_util_sem); |
9ec7779f | 343 | |
67423013 | 344 | find_add_disk_slaves(td, path, du); |
c97bd0fa | 345 | return du; |
9f8f2064 JA |
346 | } |
347 | ||
348 | static int check_dev_match(int majdev, int mindev, char *path) | |
349 | { | |
350 | int major, minor; | |
9f8f2064 | 351 | |
67423013 | 352 | if (read_block_dev_entry(path, &major, &minor)) |
9f8f2064 | 353 | return 1; |
9f8f2064 | 354 | |
c97bd0fa | 355 | if (majdev == major && mindev == minor) |
9f8f2064 | 356 | return 0; |
9f8f2064 | 357 | |
9f8f2064 JA |
358 | return 1; |
359 | } | |
360 | ||
ac0be2ac | 361 | static int find_block_dir(int majdev, int mindev, char *path, int link_ok) |
9f8f2064 JA |
362 | { |
363 | struct dirent *dir; | |
364 | struct stat st; | |
365 | int found = 0; | |
366 | DIR *D; | |
367 | ||
368 | D = opendir(path); | |
369 | if (!D) | |
370 | return 0; | |
371 | ||
372 | while ((dir = readdir(D)) != NULL) { | |
5ccdfd74 | 373 | char full_path[257]; |
9f8f2064 JA |
374 | |
375 | if (!strcmp(dir->d_name, ".") || !strcmp(dir->d_name, "..")) | |
376 | continue; | |
377 | ||
22497370 | 378 | sprintf(full_path, "%s/%s", path, dir->d_name); |
9f8f2064 JA |
379 | |
380 | if (!strcmp(dir->d_name, "dev")) { | |
381 | if (!check_dev_match(majdev, mindev, full_path)) { | |
382 | found = 1; | |
383 | break; | |
384 | } | |
385 | } | |
386 | ||
ac0be2ac JA |
387 | if (link_ok) { |
388 | if (stat(full_path, &st) == -1) { | |
389 | perror("stat"); | |
390 | break; | |
391 | } | |
392 | } else { | |
393 | if (lstat(full_path, &st) == -1) { | |
394 | perror("stat"); | |
395 | break; | |
396 | } | |
9f8f2064 JA |
397 | } |
398 | ||
399 | if (!S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode)) | |
400 | continue; | |
401 | ||
ac0be2ac | 402 | found = find_block_dir(majdev, mindev, full_path, 0); |
9f8f2064 JA |
403 | if (found) { |
404 | strcpy(path, full_path); | |
405 | break; | |
406 | } | |
407 | } | |
408 | ||
409 | closedir(D); | |
410 | return found; | |
411 | } | |
412 | ||
c97bd0fa JA |
413 | static struct disk_util *__init_per_file_disk_util(struct thread_data *td, |
414 | int majdev, int mindev, | |
415 | char *path) | |
9f8f2064 JA |
416 | { |
417 | struct stat st; | |
67423013 | 418 | char tmp[PATH_MAX]; |
9f8f2064 JA |
419 | char *p; |
420 | ||
67423013 ST |
421 | /* |
422 | * If there's a ../queue/ directory there, we are inside a partition. | |
423 | * Check if that is the case and jump back. For loop/md/dm etc we | |
424 | * are already in the right spot. | |
425 | */ | |
426 | sprintf(tmp, "%s/../queue", path); | |
427 | if (!stat(tmp, &st)) { | |
428 | p = dirname(path); | |
429 | sprintf(tmp, "%s/queue", p); | |
430 | if (stat(tmp, &st)) { | |
431 | log_err("unknown sysfs layout\n"); | |
c97bd0fa | 432 | return NULL; |
9f8f2064 | 433 | } |
59f94d26 | 434 | snprintf(tmp, FIO_ARRAY_SIZE(tmp), "%s", p); |
67423013 | 435 | sprintf(path, "%s", tmp); |
9f8f2064 JA |
436 | } |
437 | ||
c97bd0fa | 438 | return disk_util_add(td, majdev, mindev, path); |
67423013 ST |
439 | } |
440 | ||
c97bd0fa JA |
441 | static struct disk_util *init_per_file_disk_util(struct thread_data *td, |
442 | char *filename) | |
67423013 ST |
443 | { |
444 | ||
445 | char foo[PATH_MAX]; | |
446 | struct disk_util *du; | |
447 | int mindev, majdev; | |
448 | ||
c97bd0fa JA |
449 | if (get_device_numbers(filename, &majdev, &mindev)) |
450 | return NULL; | |
67423013 ST |
451 | |
452 | dprint(FD_DISKUTIL, "%s belongs to maj/min %d/%d\n", filename, majdev, | |
453 | mindev); | |
cd991b9e | 454 | |
e11c410c | 455 | du = disk_util_exists(majdev, mindev); |
bd4d9bdc | 456 | if (du) |
c97bd0fa | 457 | return du; |
9f8f2064 JA |
458 | |
459 | /* | |
460 | * for an fs without a device, we will repeatedly stat through | |
461 | * sysfs which can take oodles of time for thousands of files. so | |
462 | * cache the last lookup and compare with that before going through | |
463 | * everything again. | |
464 | */ | |
465 | if (mindev == last_mindev && majdev == last_majdev) | |
c97bd0fa | 466 | return last_du; |
9f8f2064 JA |
467 | |
468 | last_mindev = mindev; | |
469 | last_majdev = majdev; | |
5ec10eaa | 470 | |
9f8f2064 | 471 | sprintf(foo, "/sys/block"); |
ac0be2ac | 472 | if (!find_block_dir(majdev, mindev, foo, 1)) |
c97bd0fa | 473 | return NULL; |
9f8f2064 | 474 | |
c97bd0fa | 475 | return __init_per_file_disk_util(td, majdev, mindev, foo); |
67423013 | 476 | } |
9f8f2064 | 477 | |
c97bd0fa JA |
478 | static struct disk_util *__init_disk_util(struct thread_data *td, |
479 | struct fio_file *f) | |
67423013 ST |
480 | { |
481 | return init_per_file_disk_util(td, f->file_name); | |
9f8f2064 JA |
482 | } |
483 | ||
484 | void init_disk_util(struct thread_data *td) | |
485 | { | |
486 | struct fio_file *f; | |
487 | unsigned int i; | |
488 | ||
489 | if (!td->o.do_disk_util || | |
9b87f09b | 490 | td_ioengine_flagged(td, FIO_DISKLESSIO | FIO_NODISKUTIL)) |
9f8f2064 JA |
491 | return; |
492 | ||
493 | for_each_file(td, f, i) | |
c97bd0fa | 494 | f->du = __init_disk_util(td, f); |
9f8f2064 JA |
495 | } |
496 | ||
27357187 | 497 | void disk_util_prune_entries(void) |
d09a64a0 | 498 | { |
971caeb1 | 499 | fio_sem_down(disk_util_sem); |
9ec7779f | 500 | |
d09a64a0 | 501 | while (!flist_empty(&disk_list)) { |
27357187 JA |
502 | struct disk_util *du; |
503 | ||
9342d5f8 | 504 | du = flist_first_entry(&disk_list, struct disk_util, list); |
d09a64a0 JA |
505 | flist_del(&du->list); |
506 | disk_util_free(du); | |
507 | } | |
043b74b9 | 508 | |
d09a64a0 | 509 | last_majdev = last_mindev = -1; |
971caeb1 BVA |
510 | fio_sem_up(disk_util_sem); |
511 | fio_sem_remove(disk_util_sem); | |
d09a64a0 JA |
512 | } |
513 | ||
9ec7779f JA |
514 | void setup_disk_util(void) |
515 | { | |
971caeb1 | 516 | disk_util_sem = fio_sem_init(FIO_SEM_UNLOCKED); |
9f8f2064 | 517 | } |