Documentation/process/howto.rst: add a missing cross-reference
[linux-2.6-block.git] / Documentation / process / howto.rst
CommitLineData
d36cc9d0 1HOWTO do Linux kernel development
022e04d6 2=================================
d36cc9d0
GKH
3
4This is the be-all, end-all document on this topic. It contains
5instructions on how to become a Linux kernel developer and how to learn
6to work with the Linux kernel development community. It tries to not
7contain anything related to the technical aspects of kernel programming,
8but will help point you in the right direction for that.
9
10If anything in this document becomes out of date, please send in patches
11to the maintainer of this file, who is listed at the bottom of the
12document.
13
14
15Introduction
16------------
17
18So, you want to learn how to become a Linux kernel developer? Or you
19have been told by your manager, "Go write a Linux driver for this
20device." This document's goal is to teach you everything you need to
21know to achieve this by describing the process you need to go through,
22and hints on how to work with the community. It will also try to
23explain some of the reasons why the community works like it does.
24
25The kernel is written mostly in C, with some architecture-dependent
26parts written in assembly. A good understanding of C is required for
27kernel development. Assembly (any architecture) is not required unless
28you plan to do low-level development for that architecture. Though they
29are not a good substitute for a solid C education and/or years of
30experience, the following books are good for, if anything, reference:
022e04d6 31
d36cc9d0
GKH
32 - "The C Programming Language" by Kernighan and Ritchie [Prentice Hall]
33 - "Practical C Programming" by Steve Oualline [O'Reilly]
4de0ca81 34 - "C: A Reference Manual" by Harbison and Steele [Prentice Hall]
d36cc9d0
GKH
35
36The kernel is written using GNU C and the GNU toolchain. While it
37adheres to the ISO C89 standard, it uses a number of extensions that are
38not featured in the standard. The kernel is a freestanding C
39environment, with no reliance on the standard C library, so some
40portions of the C standard are not supported. Arbitrary long long
41divisions and floating point are not allowed. It can sometimes be
42difficult to understand the assumptions the kernel has on the toolchain
43and the extensions that it uses, and unfortunately there is no
44definitive reference for them. Please check the gcc info pages (`info
45gcc`) for some information on them.
46
47Please remember that you are trying to learn how to work with the
48existing development community. It is a diverse group of people, with
49high standards for coding, style and procedure. These standards have
50been created over time based on what they have found to work best for
51such a large and geographically dispersed team. Try to learn as much as
52possible about these standards ahead of time, as they are well
53documented; do not expect people to adapt to you or your company's way
54of doing things.
55
56
57Legal Issues
58------------
59
60The Linux kernel source code is released under the GPL. Please see the
61file, COPYING, in the main directory of the source tree, for details on
62the license. If you have further questions about the license, please
63contact a lawyer, and do not ask on the Linux kernel mailing list. The
64people on the mailing lists are not lawyers, and you should not rely on
65their statements on legal matters.
66
67For common questions and answers about the GPL, please see:
022e04d6 68
f1eebe92 69 https://www.gnu.org/licenses/gpl-faq.html
d36cc9d0
GKH
70
71
72Documentation
ce655081 73-------------
d36cc9d0
GKH
74
75The Linux kernel source tree has a large range of documents that are
76invaluable for learning how to interact with the kernel community. When
77new features are added to the kernel, it is recommended that new
78documentation files are also added which explain how to use the feature.
79When a kernel change causes the interface that the kernel exposes to
80userspace to change, it is recommended that you send the information or
81a patch to the manual pages explaining the change to the manual pages
09b05f5e
MK
82maintainer at mtk.manpages@gmail.com, and CC the list
83linux-api@vger.kernel.org.
d36cc9d0
GKH
84
85Here is a list of files that are in the kernel source tree that are
86required reading:
022e04d6 87
dad05139 88 :ref:`Documentation/admin-guide/README.rst <readme>`
d36cc9d0
GKH
89 This file gives a short background on the Linux kernel and describes
90 what is necessary to do to configure and build the kernel. People
91 who are new to the kernel should start here.
92
8c27ceff 93 :ref:`Documentation/process/changes.rst <changes>`
d36cc9d0
GKH
94 This file gives a list of the minimum levels of various software
95 packages that are necessary to build and run the kernel
96 successfully.
97
8c27ceff 98 :ref:`Documentation/process/coding-style.rst <codingstyle>`
d36cc9d0
GKH
99 This describes the Linux kernel coding style, and some of the
100 rationale behind it. All new code is expected to follow the
101 guidelines in this document. Most maintainers will only accept
102 patches if these rules are followed, and many people will only
103 review code if it is in the proper style.
104
8c27ceff 105 :ref:`Documentation/process/submitting-patches.rst <submittingpatches>` and :ref:`Documentation/process/submitting-drivers.rst <submittingdrivers>`
d36cc9d0
GKH
106 These files describe in explicit detail how to successfully create
107 and send a patch, including (but not limited to):
022e04d6 108
d36cc9d0
GKH
109 - Email contents
110 - Email format
111 - Who to send it to
022e04d6 112
d36cc9d0
GKH
113 Following these rules will not guarantee success (as all patches are
114 subject to scrutiny for content and style), but not following them
115 will almost always prevent it.
116
117 Other excellent descriptions of how to create patches properly are:
022e04d6 118
d36cc9d0 119 "The Perfect Patch"
f1eebe92 120 https://www.ozlabs.org/~akpm/stuff/tpp.txt
022e04d6 121
d36cc9d0
GKH
122 "Linux kernel patch submission format"
123 http://linux.yyz.us/patch-format.html
124
8c27ceff 125 :ref:`Documentation/process/stable-api-nonsense.rst <stable_api_nonsense>`
d36cc9d0
GKH
126 This file describes the rationale behind the conscious decision to
127 not have a stable API within the kernel, including things like:
022e04d6 128
d36cc9d0
GKH
129 - Subsystem shim-layers (for compatibility?)
130 - Driver portability between Operating Systems.
131 - Mitigating rapid change within the kernel source tree (or
132 preventing rapid change)
022e04d6 133
d36cc9d0
GKH
134 This document is crucial for understanding the Linux development
135 philosophy and is very important for people moving to Linux from
136 development on other Operating Systems.
137
8c27ceff 138 :ref:`Documentation/admin-guide/security-bugs.rst <securitybugs>`
d36cc9d0
GKH
139 If you feel you have found a security problem in the Linux kernel,
140 please follow the steps in this document to help notify the kernel
141 developers, and help solve the issue.
142
8c27ceff 143 :ref:`Documentation/process/management-style.rst <managementstyle>`
d36cc9d0
GKH
144 This document describes how Linux kernel maintainers operate and the
145 shared ethos behind their methodologies. This is important reading
146 for anyone new to kernel development (or anyone simply curious about
147 it), as it resolves a lot of common misconceptions and confusion
148 about the unique behavior of kernel maintainers.
149
8c27ceff 150 :ref:`Documentation/process/stable-kernel-rules.rst <stable_kernel_rules>`
d36cc9d0
GKH
151 This file describes the rules on how the stable kernel releases
152 happen, and what to do if you want to get a change into one of these
153 releases.
154
8c27ceff 155 :ref:`Documentation/process/kernel-docs.rst <kernel_docs>`
d36cc9d0
GKH
156 A list of external documentation that pertains to kernel
157 development. Please consult this list if you do not find what you
158 are looking for within the in-kernel documentation.
159
8c27ceff 160 :ref:`Documentation/process/applying-patches.rst <applying_patches>`
d36cc9d0
GKH
161 A good introduction describing exactly what a patch is and how to
162 apply it to the different development branches of the kernel.
163
164The kernel also has a large number of documents that can be
43fb67a5
MCC
165automatically generated from the source code itself or from
166ReStructuredText markups (ReST), like this one. This includes a
d36cc9d0 167full description of the in-kernel API, and rules on how to handle
43fb67a5
MCC
168locking properly.
169
1b49ecf2 170All such documents can be generated as PDF or HTML by running::
022e04d6 171
d36cc9d0 172 make pdfdocs
d36cc9d0 173 make htmldocs
022e04d6 174
d36cc9d0
GKH
175respectively from the main kernel source directory.
176
43fb67a5 177The documents that uses ReST markup will be generated at Documentation/output.
1b49ecf2 178They can also be generated on LaTeX and ePub formats with::
43fb67a5
MCC
179
180 make latexdocs
181 make epubdocs
182
d36cc9d0
GKH
183Becoming A Kernel Developer
184---------------------------
185
186If you do not know anything about Linux kernel development, you should
187look at the Linux KernelNewbies project:
022e04d6 188
f1eebe92 189 https://kernelnewbies.org
022e04d6 190
d36cc9d0
GKH
191It consists of a helpful mailing list where you can ask almost any type
192of basic kernel development question (make sure to search the archives
193first, before asking something that has already been answered in the
194past.) It also has an IRC channel that you can use to ask questions in
195real-time, and a lot of helpful documentation that is useful for
196learning about Linux kernel development.
197
198The website has basic information about code organization, subsystems,
199and current projects (both in-tree and out-of-tree). It also describes
200some basic logistical information, like how to compile a kernel and
201apply a patch.
202
203If you do not know where you want to start, but you want to look for
204some task to start doing to join into the kernel development community,
205go to the Linux Kernel Janitor's project:
022e04d6 206
f1eebe92 207 https://kernelnewbies.org/KernelJanitors
022e04d6 208
d36cc9d0
GKH
209It is a great place to start. It describes a list of relatively simple
210problems that need to be cleaned up and fixed within the Linux kernel
211source tree. Working with the developers in charge of this project, you
212will learn the basics of getting your patch into the Linux kernel tree,
213and possibly be pointed in the direction of what to go work on next, if
214you do not already have an idea.
215
d36cc9d0
GKH
216Before making any actual modifications to the Linux kernel code, it is
217imperative to understand how the code in question works. For this
218purpose, nothing is better than reading through it directly (most tricky
219bits are commented well), perhaps even with the help of specialized
220tools. One such tool that is particularly recommended is the Linux
221Cross-Reference project, which is able to present source code in a
222self-referential, indexed webpage format. An excellent up-to-date
223repository of the kernel code may be found at:
022e04d6 224
1d12554f 225 http://lxr.free-electrons.com/
d36cc9d0
GKH
226
227
228The development process
229-----------------------
230
231Linux kernel development process currently consists of a few different
232main kernel "branches" and lots of different subsystem-specific kernel
233branches. These different branches are:
022e04d6 234
e4144fe5
MC
235 - main 4.x kernel tree
236 - 4.x.y -stable kernel tree
237 - 4.x -git kernel patches
d36cc9d0 238 - subsystem specific kernel trees and patches
e4144fe5 239 - the 4.x -next kernel tree for integration tests
d36cc9d0 240
e4144fe5 2414.x kernel tree
d80b9d2a
SP
242~~~~~~~~~~~~~~~
243
e4144fe5 2444.x kernels are maintained by Linus Torvalds, and can be found on
f1eebe92 245https://kernel.org in the pub/linux/kernel/v4.x/ directory. Its development
d36cc9d0 246process is as follows:
022e04d6 247
d36cc9d0
GKH
248 - As soon as a new kernel is released a two weeks window is open,
249 during this period of time maintainers can submit big diffs to
250 Linus, usually the patches that have already been included in the
c607cf0c 251 -next kernel for a few weeks. The preferred way to submit big changes
d36cc9d0 252 is using git (the kernel's source management tool, more information
f1eebe92 253 can be found at https://git-scm.com/) but plain patches are also just
d36cc9d0 254 fine.
388f9b20
DC
255 - After two weeks a -rc1 kernel is released and the focus is on making the
256 new kernel as rock solid as possible. Most of the patches at this point
257 should fix a regression. Bugs that have always existed are not
258 regressions, so only push these kinds of fixes if they are important.
259 Please note that a whole new driver (or filesystem) might be accepted
260 after -rc1 because there is no risk of causing regressions with such a
261 change as long as the change is self-contained and does not affect areas
262 outside of the code that is being added. git can be used to send
263 patches to Linus after -rc1 is released, but the patches need to also be
264 sent to a public mailing list for review.
d36cc9d0
GKH
265 - A new -rc is released whenever Linus deems the current git tree to
266 be in a reasonably sane state adequate for testing. The goal is to
267 release a new -rc kernel every week.
268 - Process continues until the kernel is considered "ready", the
269 process should last around 6 weeks.
270
271It is worth mentioning what Andrew Morton wrote on the linux-kernel
272mailing list about kernel releases:
022e04d6 273
34fed7e7 274 *"Nobody knows when a kernel will be released, because it's
d36cc9d0 275 released according to perceived bug status, not according to a
34fed7e7 276 preconceived timeline."*
d36cc9d0 277
e4144fe5 2784.x.y -stable kernel tree
d80b9d2a
SP
279~~~~~~~~~~~~~~~~~~~~~~~~~
280
591bfc6b 281Kernels with 3-part versions are -stable kernels. They contain
d36cc9d0 282relatively small and critical fixes for security problems or significant
e4144fe5 283regressions discovered in a given 4.x kernel.
d36cc9d0
GKH
284
285This is the recommended branch for users who want the most recent stable
286kernel and are not interested in helping test development/experimental
287versions.
288
e4144fe5 289If no 4.x.y kernel is available, then the highest numbered 4.x
d36cc9d0
GKH
290kernel is the current stable kernel.
291
e4144fe5 2924.x.y are maintained by the "stable" team <stable@vger.kernel.org>, and
2eb7f204 293are released as needs dictate. The normal release period is approximately
0fe8a3ce
JC
294two weeks, but it can be longer if there are no pressing problems. A
295security-related problem, instead, can cause a release to happen almost
296instantly.
d36cc9d0 297
8c27ceff 298The file Documentation/process/stable-kernel-rules.rst in the kernel tree
d36cc9d0
GKH
299documents what kinds of changes are acceptable for the -stable tree, and
300how the release process works.
301
e4144fe5 3024.x -git patches
d80b9d2a
SP
303~~~~~~~~~~~~~~~~
304
d36cc9d0
GKH
305These are daily snapshots of Linus' kernel tree which are managed in a
306git repository (hence the name.) These patches are usually released
307daily and represent the current state of Linus' tree. They are more
308experimental than -rc kernels since they are generated automatically
309without even a cursory glance to see if they are sane.
310
d36cc9d0 311Subsystem Specific kernel trees and patches
d80b9d2a
SP
312~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
313
c607cf0c
SR
314The maintainers of the various kernel subsystems --- and also many
315kernel subsystem developers --- expose their current state of
316development in source repositories. That way, others can see what is
317happening in the different areas of the kernel. In areas where
318development is rapid, a developer may be asked to base his submissions
319onto such a subsystem kernel tree so that conflicts between the
320submission and other already ongoing work are avoided.
321
322Most of these repositories are git trees, but there are also other SCMs
323in use, or patch queues being published as quilt series. Addresses of
324these subsystem repositories are listed in the MAINTAINERS file. Many
f1eebe92 325of them can be browsed at https://git.kernel.org/.
c607cf0c
SR
326
327Before a proposed patch is committed to such a subsystem tree, it is
328subject to review which primarily happens on mailing lists (see the
329respective section below). For several kernel subsystems, this review
330process is tracked with the tool patchwork. Patchwork offers a web
331interface which shows patch postings, any comments on a patch or
332revisions to it, and maintainers can mark patches as under review,
333accepted, or rejected. Most of these patchwork sites are listed at
f1eebe92 334https://patchwork.kernel.org/.
c607cf0c 335
e4144fe5 3364.x -next kernel tree for integration tests
d80b9d2a
SP
337~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
338
e4144fe5 339Before updates from subsystem trees are merged into the mainline 4.x
c607cf0c
SR
340tree, they need to be integration-tested. For this purpose, a special
341testing repository exists into which virtually all subsystem trees are
342pulled on an almost daily basis:
022e04d6 343
f1eebe92 344 https://git.kernel.org/?p=linux/kernel/git/next/linux-next.git
c607cf0c
SR
345
346This way, the -next kernel gives a summary outlook onto what will be
347expected to go into the mainline kernel at the next merge period.
348Adventurous testers are very welcome to runtime-test the -next kernel.
d36cc9d0 349
8a465c32 350
d36cc9d0
GKH
351Bug Reporting
352-------------
353
f1eebe92 354https://bugzilla.kernel.org is where the Linux kernel developers track kernel
d36cc9d0
GKH
355bugs. Users are encouraged to report all bugs that they find in this
356tool. For details on how to use the kernel bugzilla, please see:
022e04d6 357
f1eebe92 358 https://bugzilla.kernel.org/page.cgi?id=faq.html
d36cc9d0 359
8c27ceff 360The file admin-guide/reporting-bugs.rst in the main kernel source directory has a good
d36cc9d0
GKH
361template for how to report a possible kernel bug, and details what kind
362of information is needed by the kernel developers to help track down the
363problem.
364
365
3f271008
DC
366Managing bug reports
367--------------------
368
369One of the best ways to put into practice your hacking skills is by fixing
370bugs reported by other people. Not only you will help to make the kernel
371more stable, you'll learn to fix real world problems and you will improve
372your skills, and other developers will be aware of your presence. Fixing
4db29c17 373bugs is one of the best ways to get merits among other developers, because
3f271008
DC
374not many people like wasting time fixing other people's bugs.
375
f1eebe92 376To work in the already reported bug reports, go to https://bugzilla.kernel.org.
3f271008
DC
377
378
d36cc9d0
GKH
379Mailing lists
380-------------
381
382As some of the above documents describe, the majority of the core kernel
383developers participate on the Linux Kernel Mailing list. Details on how
384to subscribe and unsubscribe from the list can be found at:
022e04d6 385
d36cc9d0 386 http://vger.kernel.org/vger-lists.html#linux-kernel
022e04d6 387
d36cc9d0
GKH
388There are archives of the mailing list on the web in many different
389places. Use a search engine to find these archives. For example:
022e04d6 390
d36cc9d0 391 http://dir.gmane.org/gmane.linux.kernel
022e04d6 392
d36cc9d0
GKH
393It is highly recommended that you search the archives about the topic
394you want to bring up, before you post it to the list. A lot of things
395already discussed in detail are only recorded at the mailing list
396archives.
397
398Most of the individual kernel subsystems also have their own separate
399mailing list where they do their development efforts. See the
400MAINTAINERS file for a list of what these lists are for the different
401groups.
402
403Many of the lists are hosted on kernel.org. Information on them can be
404found at:
022e04d6 405
d36cc9d0
GKH
406 http://vger.kernel.org/vger-lists.html
407
408Please remember to follow good behavioral habits when using the lists.
409Though a bit cheesy, the following URL has some simple guidelines for
410interacting with the list (or any list):
022e04d6 411
d36cc9d0
GKH
412 http://www.albion.com/netiquette/
413
414If multiple people respond to your mail, the CC: list of recipients may
415get pretty large. Don't remove anybody from the CC: list without a good
416reason, or don't reply only to the list address. Get used to receiving the
417mail twice, one from the sender and the one from the list, and don't try
418to tune that by adding fancy mail-headers, people will not like it.
419
420Remember to keep the context and the attribution of your replies intact,
421keep the "John Kernelhacker wrote ...:" lines at the top of your reply, and
422add your statements between the individual quoted sections instead of
423writing at the top of the mail.
424
425If you add patches to your mail, make sure they are plain readable text
8c27ceff 426as stated in Documentation/process/submitting-patches.rst.
34fed7e7
MCC
427Kernel developers don't want to deal with
428attachments or compressed patches; they may want to comment on
429individual lines of your patch, which works only that way. Make sure you
430use a mail program that does not mangle spaces and tab characters. A
431good first test is to send the mail to yourself and try to apply your
432own patch by yourself. If that doesn't work, get your mail program fixed
433or change it until it works.
d36cc9d0
GKH
434
435Above all, please remember to show respect to other subscribers.
436
437
438Working with the community
439--------------------------
440
441The goal of the kernel community is to provide the best possible kernel
442there is. When you submit a patch for acceptance, it will be reviewed
443on its technical merits and those alone. So, what should you be
444expecting?
022e04d6 445
d36cc9d0
GKH
446 - criticism
447 - comments
448 - requests for change
449 - requests for justification
450 - silence
451
452Remember, this is part of getting your patch into the kernel. You have
453to be able to take criticism and comments about your patches, evaluate
454them at a technical level and either rework your patches or provide
455clear and concise reasoning as to why those changes should not be made.
456If there are no responses to your posting, wait a few days and try
457again, sometimes things get lost in the huge volume.
458
459What should you not do?
022e04d6 460
d36cc9d0
GKH
461 - expect your patch to be accepted without question
462 - become defensive
463 - ignore comments
464 - resubmit the patch without making any of the requested changes
465
466In a community that is looking for the best technical solution possible,
467there will always be differing opinions on how beneficial a patch is.
468You have to be cooperative, and willing to adapt your idea to fit within
469the kernel. Or at least be willing to prove your idea is worth it.
470Remember, being wrong is acceptable as long as you are willing to work
471toward a solution that is right.
472
473It is normal that the answers to your first patch might simply be a list
34fed7e7
MCC
474of a dozen things you should correct. This does **not** imply that your
475patch will not be accepted, and it is **not** meant against you
d36cc9d0
GKH
476personally. Simply correct all issues raised against your patch and
477resend it.
478
479
480Differences between the kernel community and corporate structures
481-----------------------------------------------------------------
482
483The kernel community works differently than most traditional corporate
484development environments. Here are a list of things that you can try to
106f9d93 485do to avoid problems:
022e04d6 486
d36cc9d0 487 Good things to say regarding your proposed changes:
022e04d6 488
d36cc9d0
GKH
489 - "This solves multiple problems."
490 - "This deletes 2000 lines of code."
491 - "Here is a patch that explains what I am trying to describe."
492 - "I tested it on 5 different architectures..."
493 - "Here is a series of small patches that..."
494 - "This increases performance on typical machines..."
495
496 Bad things you should avoid saying:
022e04d6 497
d36cc9d0
GKH
498 - "We did it this way in AIX/ptx/Solaris, so therefore it must be
499 good..."
500 - "I've being doing this for 20 years, so..."
501 - "This is required for my company to make money"
502 - "This is for our Enterprise product line."
503 - "Here is my 1000 page design document that describes my idea"
504 - "I've been working on this for 6 months..."
505 - "Here's a 5000 line patch that..."
506 - "I rewrote all of the current mess, and here it is..."
507 - "I have a deadline, and this patch needs to be applied now."
508
509Another way the kernel community is different than most traditional
510software engineering work environments is the faceless nature of
511interaction. One benefit of using email and irc as the primary forms of
512communication is the lack of discrimination based on gender or race.
513The Linux kernel work environment is accepting of women and minorities
514because all you are is an email address. The international aspect also
515helps to level the playing field because you can't guess gender based on
516a person's name. A man may be named Andrea and a woman may be named Pat.
517Most women who have worked in the Linux kernel and have expressed an
518opinion have had positive experiences.
519
520The language barrier can cause problems for some people who are not
521comfortable with English. A good grasp of the language can be needed in
522order to get ideas across properly on mailing lists, so it is
523recommended that you check your emails to make sure they make sense in
524English before sending them.
525
526
527Break up your changes
528---------------------
529
530The Linux kernel community does not gladly accept large chunks of code
531dropped on it all at once. The changes need to be properly introduced,
532discussed, and broken up into tiny, individual portions. This is almost
533the exact opposite of what companies are used to doing. Your proposal
534should also be introduced very early in the development process, so that
535you can receive feedback on what you are doing. It also lets the
536community feel that you are working with them, and not simply using them
537as a dumping ground for your feature. However, don't send 50 emails at
538one time to a mailing list, your patch series should be smaller than
539that almost all of the time.
540
541The reasons for breaking things up are the following:
542
5431) Small patches increase the likelihood that your patches will be
544 applied, since they don't take much time or effort to verify for
545 correctness. A 5 line patch can be applied by a maintainer with
546 barely a second glance. However, a 500 line patch may take hours to
547 review for correctness (the time it takes is exponentially
548 proportional to the size of the patch, or something).
549
550 Small patches also make it very easy to debug when something goes
551 wrong. It's much easier to back out patches one by one than it is
552 to dissect a very large patch after it's been applied (and broken
553 something).
554
5552) It's important not only to send small patches, but also to rewrite
556 and simplify (or simply re-order) patches before submitting them.
557
558Here is an analogy from kernel developer Al Viro:
022e04d6 559
34fed7e7 560 *"Think of a teacher grading homework from a math student. The
d36cc9d0
GKH
561 teacher does not want to see the student's trials and errors
562 before they came up with the solution. They want to see the
563 cleanest, most elegant answer. A good student knows this, and
564 would never submit her intermediate work before the final
34fed7e7 565 solution.*
d36cc9d0 566
34fed7e7 567 *The same is true of kernel development. The maintainers and
d36cc9d0
GKH
568 reviewers do not want to see the thought process behind the
569 solution to the problem one is solving. They want to see a
34fed7e7 570 simple and elegant solution."*
d36cc9d0
GKH
571
572It may be challenging to keep the balance between presenting an elegant
573solution and working together with the community and discussing your
574unfinished work. Therefore it is good to get early in the process to
575get feedback to improve your work, but also keep your changes in small
576chunks that they may get already accepted, even when your whole task is
577not ready for inclusion now.
578
579Also realize that it is not acceptable to send patches for inclusion
580that are unfinished and will be "fixed up later."
581
582
583Justify your change
584-------------------
585
586Along with breaking up your patches, it is very important for you to let
587the Linux community know why they should add this change. New features
588must be justified as being needed and useful.
589
590
591Document your change
592--------------------
593
594When sending in your patches, pay special attention to what you say in
595the text in your email. This information will become the ChangeLog
596information for the patch, and will be preserved for everyone to see for
597all time. It should describe the patch completely, containing:
022e04d6 598
d36cc9d0
GKH
599 - why the change is necessary
600 - the overall design approach in the patch
601 - implementation details
602 - testing results
603
604For more details on what this should all look like, please see the
605ChangeLog section of the document:
022e04d6 606
d36cc9d0 607 "The Perfect Patch"
937d9f55 608 http://www.ozlabs.org/~akpm/stuff/tpp.txt
d36cc9d0
GKH
609
610
d36cc9d0
GKH
611All of these things are sometimes very hard to do. It can take years to
612perfect these practices (if at all). It's a continuous process of
613improvement that requires a lot of patience and determination. But
614don't give up, it's possible. Many have done it before, and each had to
615start exactly where you are now.
616
617
618
619
620----------
022e04d6 621
5bd982ed 622Thanks to Paolo Ciarrocchi who allowed the "Development Process"
f1eebe92 623(https://lwn.net/Articles/94386/) section
d36cc9d0
GKH
624to be based on text he had written, and to Randy Dunlap and Gerrit
625Huizenga for some of the list of things you should and should not say.
626Also thanks to Pat Mochel, Hanna Linder, Randy Dunlap, Kay Sievers,
627Vojtech Pavlik, Jan Kara, Josh Boyer, Kees Cook, Andrew Morton, Andi
628Kleen, Vadim Lobanov, Jesper Juhl, Adrian Bunk, Keri Harris, Frans Pop,
629David A. Wheeler, Junio Hamano, Michael Kerrisk, and Alex Shepard for
630their review, comments, and contributions. Without their help, this
631document would not have been possible.
632
633
634
635Maintainer: Greg Kroah-Hartman <greg@kroah.com>