summaryrefslogtreecommitdiff
path: root/file.h
diff options
context:
space:
mode:
authorDennis Zhou <dennis@kernel.org>2018-10-02 22:14:50 -0400
committerJens Axboe <axboe@kernel.dk>2018-10-03 09:22:54 -0600
commit6aaf98e90b4f65b3ab28d073dc820e924832df5f (patch)
treed4e7a2439ff1304c4449c34f40ce72db7851983e /file.h
parent8ea203d36bf65f60ce16967d9cc9857c0778b216 (diff)
Revert "blktrace: support for non-512b sector sizes"
This reverts commit 26e616d054f238bf6b7ada351e17b72fdfbbb8e0. An issue appeared when replaying blktraces using fio on non-512b sector size devices where fio would report the following when replaying a trace back on the same device. fio: io_u error on file /dev/sdb: No space left on device: This turns out to be due to a match of how blktrace exports trace information and how fio interprets it. The kernel considers all IO to be relative to 512b sectors, so the sector offset is always in these units. However, when replaying fio was adapting to the hardware sector. This caused offset calculation issues resulting in the above error. Reverting this keeps fio more in line with expectations, but will force users who want to have fio run workloads be cognizant of aligning IO properly when running on specific media to get expected performance. Reported-by: Vernon Miller <vwm@fb.com> Signed-off-by: Dennis Zhou <dennis@kernel.org> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'file.h')
-rw-r--r--file.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/file.h b/file.h
index 446a1fb..e50c0f9 100644
--- a/file.h
+++ b/file.h
@@ -89,7 +89,6 @@ struct fio_file {
*/
unsigned int major, minor;
int fileno;
- unsigned long long bs;
char *file_name;
/*