From: Guenter Roeck Date: Wed, 10 Apr 2019 16:27:51 +0000 (-0700) Subject: watchdog: imx_sc_wdt: Use 'dev' instead of dereferencing it repeatedly X-Git-Tag: for-linus-20190516~7^2~43 X-Git-Url: https://git.kernel.dk/?p=linux-2.6-block.git;a=commitdiff_plain;h=01022e3390498fffebfd67f4a813bfaadc66b741 watchdog: imx_sc_wdt: Use 'dev' instead of dereferencing it repeatedly Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Signed-off-by: Guenter Roeck Acked-by: Shawn Guo Signed-off-by: Wim Van Sebroeck --- diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c index 86c2722f2a09..d154f66e659a 100644 --- a/drivers/watchdog/imx_sc_wdt.c +++ b/drivers/watchdog/imx_sc_wdt.c @@ -101,10 +101,11 @@ static const struct watchdog_info imx_sc_wdt_info = { static int imx_sc_wdt_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct watchdog_device *imx_sc_wdd; int ret; - imx_sc_wdd = devm_kzalloc(&pdev->dev, sizeof(*imx_sc_wdd), GFP_KERNEL); + imx_sc_wdd = devm_kzalloc(dev, sizeof(*imx_sc_wdd), GFP_KERNEL); if (!imx_sc_wdd) return -ENOMEM; @@ -114,19 +115,19 @@ static int imx_sc_wdt_probe(struct platform_device *pdev) imx_sc_wdd->ops = &imx_sc_wdt_ops; imx_sc_wdd->min_timeout = 1; imx_sc_wdd->max_timeout = MAX_TIMEOUT; - imx_sc_wdd->parent = &pdev->dev; + imx_sc_wdd->parent = dev; imx_sc_wdd->timeout = DEFAULT_TIMEOUT; - ret = watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); + ret = watchdog_init_timeout(imx_sc_wdd, 0, dev); if (ret) - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n"); + dev_warn(dev, "Failed to set timeout value, using default\n"); watchdog_stop_on_reboot(imx_sc_wdd); watchdog_stop_on_unregister(imx_sc_wdd); - ret = devm_watchdog_register_device(&pdev->dev, imx_sc_wdd); + ret = devm_watchdog_register_device(dev, imx_sc_wdd); if (ret) { - dev_err(&pdev->dev, "Failed to register watchdog device\n"); + dev_err(dev, "Failed to register watchdog device\n"); return ret; }