Input: elan_i2c_smbus - cast sizeof to int for comparison
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 1 Aug 2018 22:57:43 +0000 (15:57 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 1 Aug 2018 23:05:55 +0000 (16:05 -0700)
commitce1d6f22fa69287f877aca37e275c776ed6e6eb5
tree57219e88517ae70ccbad12da8268422e09a34c81
parent384cf4285b34e08917e3e66603382f2b0c4f6e1b
Input: elan_i2c_smbus - cast sizeof to int for comparison

Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result.  i2c_smbus_read_block_data can return the
result of i2c_smbus_xfer, whih can return a negative error code.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
int x;
expression e,e1;
identifier f;
@@

*x = f(...);
... when != x = e1
    when != if (x < 0 || ...) { ... return ...; }
*x < sizeof(e)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/elan_i2c_smbus.c