ALSA: usb-audio: Fix incorrect NULL check in create_yamaha_midi_quirk()
authorTakashi Iwai <tiwai@suse.de>
Wed, 13 Nov 2019 11:12:59 +0000 (12:12 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 14 Nov 2019 11:09:06 +0000 (12:09 +0100)
commitcc9dbfa9707868fb0ca864c05e0c42d3f4d15cf2
treedac8f56c68b2c1eae9feb51e12c8a37509cf2688
parentf5cdc9d4003a2f66ea57b3edd3e04acc2b1a4439
ALSA: usb-audio: Fix incorrect NULL check in create_yamaha_midi_quirk()

The commit 60849562a5db ("ALSA: usb-audio: Fix possible NULL
dereference at create_yamaha_midi_quirk()") added NULL checks in
create_yamaha_midi_quirk(), but there was an overlook.  The code
allows one of either injd or outjd is NULL, but the second if check
made returning -ENODEV if any of them is NULL.  Fix it in a proper
form.

Fixes: 60849562a5db ("ALSA: usb-audio: Fix possible NULL dereference at create_yamaha_midi_quirk()")
Reported-by: Pavel Machek <pavel@denx.de>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191113111259.24123-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/quirks.c