sched/rt: Hide the push_irq_work_func() declaration
authorArnd Bergmann <arnd@arndb.de>
Thu, 12 Nov 2015 16:19:58 +0000 (17:19 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 23 Nov 2015 08:25:08 +0000 (09:25 +0100)
commit89b411081d70fe3772efa4665279293269c1150d
tree2de97cb74b2a7c3dae368d274c071750478a9042
parent1ec218373b8ebda821aec00bb156a9c94fad9cd4
sched/rt: Hide the push_irq_work_func() declaration

The push_irq_work_func() function is conditionally defined only
when both CONFIG_SMP and HAVE_RT_PUSH_IPI are defined, but the
forward declaration remains visibile without HAVE_RT_PUSH_IPI,
causing a gcc warning in ARM64 allnoconfig:

  kernel/sched/rt.c:68:13: warning: 'push_irq_work_func' declared 'static' but never defined [-Wunused-function]

This changes the code to use the same condition for both the
declaration and the function definition, which gets rid of the
warning.

As Peter Zijlstra, we can possibly get rid of the whole HAVE_RT_PUSH_IPI
thing after:

  8053871d0f7f ("smp: Fix smp_call_function_single_async() locking")

Until that is done, this patch can be used to avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: b6366f048e0c ("sched/rt: Use IPI to trigger RT task push migration instead of pulling")
Link: http://lkml.kernel.org/r/3828565.oKfGk7yNIT@wuerfel
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/rt.c