x86: Use lockdep to assert IRQs are disabled/enabled
authorFrederic Weisbecker <frederic@kernel.org>
Mon, 6 Nov 2017 15:01:23 +0000 (16:01 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 8 Nov 2017 10:13:50 +0000 (11:13 +0100)
commit7a10e2a9190628a4024ea394ce7bd641ae40ffd1
treee87b2bec06bfc28654d4ba7848b2ed91e65a67bd
parent83efcbd028ad3aec36b5a3882cfa32490c135df7
x86: Use lockdep to assert IRQs are disabled/enabled

Use lockdep to check that IRQs are enabled or disabled as expected. This
way the sanity check only shows overhead when concurrency correctness
debug code is enabled.

It also makes no more sense to fix the IRQ flags when a bug is detected
as the assertion is now pure config-dependent debugging. And to quote
Peter Zijlstra:

The whole if !disabled, disable logic is uber paranoid programming,
but I don't think we've ever seen that WARN trigger, and if it does
(and then burns the kernel) we at least know what happend.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: David S . Miller <davem@davemloft.net>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/1509980490-4285-8-git-send-email-frederic@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/entry/common.c
arch/x86/kernel/smpboot.c