gfs2: avoid uninitialized variable warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 26 Jan 2016 18:08:10 +0000 (13:08 -0500)
committerBob Peterson <rpeterso@redhat.com>
Tue, 15 Mar 2016 14:46:11 +0000 (10:46 -0400)
commit67893f12e5374bbcaaffbc6e570acbc2714ea884
tree74911bb5323cafb2e8efde1de51f44bd6b65bec1
parent7508abc4bdac43dc87d2fdd31527063f72da7020
gfs2: avoid uninitialized variable warning

We get a bogus warning about a potential uninitialized variable
use in gfs2, because the compiler does not figure out that we
never use the leaf number if get_leaf_nr() returns an error:

fs/gfs2/dir.c: In function 'get_first_leaf':
fs/gfs2/dir.c:802:9: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized]
fs/gfs2/dir.c: In function 'dir_split_leaf':
fs/gfs2/dir.c:1021:8: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized]

Changing the 'if (!error)' to 'if (!IS_ERR_VALUE(error))' is
sufficient to let gcc understand that this is exactly the same
condition as in IS_ERR() so it can optimize the code path enough
to understand it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/dir.c