drm/i915: Check crtc->active in intel_crtc_disable_planes
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 7 Jul 2015 09:15:46 +0000 (11:15 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 8 Jul 2015 14:42:25 +0000 (16:42 +0200)
commit63fef06ada94172d7b4295fc205441bafd8f8fb3
tree884573d104c4c79f2f1276a83fe83bf0a1f66038
parent2c3d99845eb7b1e9f3d2863099bc5a25c8461d3f
drm/i915: Check crtc->active in intel_crtc_disable_planes

This was lost in

commit ce22dba92de22e951dee2ff89937a39754d2dd91
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Tue Apr 21 17:12:56 2015 +0300

    drm/i915: Move toggling planes out of crtc enable/disable.

and we still need that crtc->active check since the overall modeset
flow doesn't yet take dpms state into account properly. Fixes WARNING
backtraces on at least bdw/hsw due to the ips disabling code being
upset about being run on a switched-off pipe.

We don't need a corresponding change on the enable side since with the
old setCrtc semantics we always force-enable the pipe after a modeset.
And the dpms function intel_crtc_control already checks for ->active.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c