hpfs: fix remount failure when there are no options changed
authorMikulas Patocka <mikulas@twibright.com>
Tue, 24 May 2016 20:47:00 +0000 (22:47 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 28 May 2016 23:50:24 +0000 (16:50 -0700)
commit44d51706b4685f965cd32acde3fe0fcc1e6198e8
tree0fbaa756897dc731957ae2efbbeab862836789b2
parent4029632c344142e0e92da3ff4937cd41bd647bb4
hpfs: fix remount failure when there are no options changed

Commit ce657611baf9 ("hpfs: kstrdup() out of memory handling") checks if
the kstrdup function returns NULL due to out-of-memory condition.

However, if we are remounting a filesystem with no change to
filesystem-specific options, the parameter data is NULL.  In this case,
kstrdup returns NULL (because it was passed NULL parameter), although no
out of memory condition exists.  The mount syscall then fails with
ENOMEM.

This patch fixes the bug.  We fail with ENOMEM only if data is non-NULL.

The patch also changes the call to replace_mount_options - if we didn't
pass any filesystem-specific options, we don't call
replace_mount_options (thus we don't erase existing reported options).

Fixes: ce657611baf9 ("hpfs: kstrdup() out of memory handling")
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/hpfs/super.c