metag/uaccess: Check access_ok in strncpy_from_user
authorJames Hogan <james.hogan@imgtec.com>
Tue, 2 May 2017 18:41:06 +0000 (19:41 +0100)
committerJames Hogan <james.hogan@imgtec.com>
Tue, 2 May 2017 20:11:32 +0000 (21:11 +0100)
commit3a158a62da0673db918b53ac1440845a5b64fd90
tree6ba8e4c284d1caf5dbbc2a813dc6b214d6e097d5
parent8a8b56638bcac4e64cccc88bf95a0f9f4b19a2fb
metag/uaccess: Check access_ok in strncpy_from_user

The metag implementation of strncpy_from_user() doesn't validate the src
pointer, which could allow reading of arbitrary kernel memory. Add a
short access_ok() check to prevent that.

Its still possible for it to read across the user/kernel boundary, but
it will invariably reach a NUL character after only 9 bytes, leaking
only a static kernel address being loaded into D0Re0 at the beginning of
__start, which is acceptable for the immediate fix.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: linux-metag@vger.kernel.org
Cc: stable@vger.kernel.org
arch/metag/include/asm/uaccess.h