media: gspca_kinect: cast sizeof to int for comparison
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 1 Jul 2018 17:32:05 +0000 (13:32 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 25 Jul 2018 12:35:12 +0000 (08:35 -0400)
commit2e3134caf63694bf1dbb2e68829871e14d543613
tree55db564e291bf8ef073c902ae49fb2a05f408038
parent5a1a2f63d840dc2631505b607e11ff65ac1b7d3c
media: gspca_kinect: cast sizeof to int for comparison

Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result.  kinect_read returns the result of
usb_control_msg, which can return a negtive error code.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
int x;
expression e,e1;
identifier f;
@@

*x = f(...);
... when != x = e1
    when != if (x < 0 || ...) { ... return ...; }
*x < sizeof(e)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/gspca/kinect.c