bpf: fix uapi bpf_prog_info fields alignment
authorBaruch Siach <baruch@tkos.co.il>
Fri, 28 Jun 2019 04:08:45 +0000 (07:08 +0300)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 28 Jun 2019 23:35:46 +0000 (01:35 +0200)
commit0472301a28f6cf53a6bc5783e48a2d0bbff4682f
tree98eb7f12ed6a1a6918c463da4a84238db5d0224f
parent75672dda27bd00109a84cd975c17949ad9c45663
bpf: fix uapi bpf_prog_info fields alignment

Merge commit 1c8c5a9d38f60 ("Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat
applications") by taking the gpl_compatible 1-bit field definition from
commit b85fab0e67b162 ("bpf: Add gpl_compatible flag to struct
bpf_prog_info") as is. That breaks architectures with 16-bit alignment
like m68k. Add 31-bit pad after gpl_compatible to restore alignment of
following fields.

Thanks to Dmitry V. Levin his analysis of this bug history.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Song Liu <songliubraving@fb.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
include/uapi/linux/bpf.h
tools/include/uapi/linux/bpf.h