rhashtable: Fix sleeping inside RCU critical section in walk_stop
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 23 Mar 2015 22:53:17 +0000 (09:53 +1100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2015 02:16:07 +0000 (22:16 -0400)
commitba7c95ea3870fe7b847466d39a049ab6f156aa2c
tree8fed9deb6a4a0c1f52634ff0bd07fb6a0edb8dde
parentce046c568cbfb4734583131086f88cfe993c01d0
rhashtable: Fix sleeping inside RCU critical section in walk_stop

The commit 963ecbd41a1026d99ec7537c050867428c397b89 ("rhashtable:
Fix use-after-free in rhashtable_walk_stop") fixed a real bug
but created another one because we may end up sleeping inside an
RCU critical section.

This patch fixes it properly by replacing the mutex with a spin
lock that specifically protects the walker lists.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/rhashtable.h
lib/rhashtable.c