userns: Don't allow setgroups until a gid mapping has been setablished
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 6 Dec 2014 00:01:11 +0000 (18:01 -0600)
committerEric W. Biederman <ebiederm@xmission.com>
Tue, 9 Dec 2014 22:58:40 +0000 (16:58 -0600)
commit273d2c67c3e179adb1e74f403d1e9a06e3f841b5
tree500bf14c930ea5c1db4c40dec54d95a00085552c
parent0542f17bf2c1f2430d368f44c8fcf2f82ec9e53e
userns: Don't allow setgroups until a gid mapping has been setablished

setgroups is unique in not needing a valid mapping before it can be called,
in the case of setgroups(0, NULL) which drops all supplemental groups.

The design of the user namespace assumes that CAP_SETGID can not actually
be used until a gid mapping is established.  Therefore add a helper function
to see if the user namespace gid mapping has been established and call
that function in the setgroups permission check.

This is part of the fix for CVE-2014-8989, being able to drop groups
without privilege using user namespaces.

Cc: stable@vger.kernel.org
Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
include/linux/user_namespace.h
kernel/groups.c
kernel/user_namespace.c