sched: Fix a race between __kthread_bind() and sched_setaffinity()
authorPeter Zijlstra <peterz@infradead.org>
Fri, 15 May 2015 15:43:34 +0000 (17:43 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 12 Aug 2015 10:06:09 +0000 (12:06 +0200)
commit25834c73f93af7f0712c98ca4593691592e6b360
tree5da4f7c4da2a85ba6458a4de234da5e3d0a0c27a
parent7855a35ac07a350e2cd26f09568a6d8e372be358
sched: Fix a race between __kthread_bind() and sched_setaffinity()

Because sched_setscheduler() checks p->flags & PF_NO_SETAFFINITY
without locks, a caller might observe an old value and race with the
set_cpus_allowed_ptr() call from __kthread_bind() and effectively undo
it:

__kthread_bind()
  do_set_cpus_allowed()
<SYSCALL>
  sched_setaffinity()
    if (p->flags & PF_NO_SETAFFINITIY)
    set_cpus_allowed_ptr()
  p->flags |= PF_NO_SETAFFINITY

Fix the bug by putting everything under the regular scheduler locks.

This also closes a hole in the serialization of task_struct::{nr_,}cpus_allowed.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dedekind1@gmail.com
Cc: juri.lelli@arm.com
Cc: mgorman@suse.de
Cc: riel@redhat.com
Cc: rostedt@goodmis.org
Link: http://lkml.kernel.org/r/20150515154833.545640346@infradead.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/kthread.h
include/linux/sched.h
kernel/kthread.c
kernel/sched/core.c
kernel/workqueue.c