perf: Fix perf_event_comm() vs. exec() assumption
authorPeter Zijlstra <peterz@infradead.org>
Wed, 21 May 2014 15:32:19 +0000 (17:32 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 6 Jun 2014 05:54:02 +0000 (07:54 +0200)
commite041e328c4b41e1db79bfe5ba9992c2ed771ad19
tree88f8689160ae586c728e6ef665cc4c580c116ba9
parent22c91aa23547a4363fd2a9ffddde95c899ac8aa0
perf: Fix perf_event_comm() vs. exec() assumption

perf_event_comm() assumes that set_task_comm() is only called on
exec(), and in particular that its only called on current.

Neither are true, as Dave reported a WARN triggered by set_task_comm()
being called on !current.

Separate the exec() hook from the comm hook.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/20140521153219.GH5226@laptop.programming.kicks-ass.net
[ Build fix. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
fs/exec.c
include/linux/perf_event.h
kernel/events/core.c