From b6c019832ebb67143da7c4880873572e008563e8 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Tue, 25 Sep 2018 19:44:35 -0600 Subject: [PATCH] parse: fix minval checking For values that allow negative min values, don't cast to an uint. Fixes: 5d2788d5b798 ("parse: fix min/max val checking for FIO_OPT_INT") Signed-off-by: Jens Axboe --- parse.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/parse.c b/parse.c index 9a20d0c7..84d112dc 100644 --- a/parse.c +++ b/parse.c @@ -512,11 +512,8 @@ static bool val_too_large(const struct fio_option *o, unsigned long long val, if (!o->maxval) return false; - if (is_uint) { - unsigned int uint_val = val; - - return uint_val > o->maxval; - } + if (is_uint) + return (unsigned int) val > o->maxval; return val > o->maxval; } @@ -527,11 +524,8 @@ static bool val_too_small(const struct fio_option *o, unsigned long long val, if (!o->minval) return false; - if (is_uint) { - unsigned int uint_val = val; - - return uint_val < o->minval; - } + if (is_uint) + return (int) val < o->minval; return val < o->minval; } -- 2.25.1