From: Jens Axboe <axboe@kernel.dk>
Date: Fri, 16 Nov 2018 01:56:12 +0000 (-0700)
Subject: io_u: fall through to unlock path in case of error
X-Git-Tag: fio-3.13~112
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=ee5e08ad08efd44cb62ea37bf865c2848a47b581

io_u: fall through to unlock path in case of error

Doesn't really matter since we're exiting anyway, but let's
do this right.

Fixes: d28174f0189c ("workqueue: ensure we see deferred error for IOs")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/io_u.c b/io_u.c
index d28d368f..1604ff84 100644
--- a/io_u.c
+++ b/io_u.c
@@ -1559,9 +1559,8 @@ again:
 		assert(!(td->flags & TD_F_CHILD));
 		ret = pthread_cond_wait(&td->free_cond, &td->io_u_lock);
 		assert(ret == 0);
-		if (td->error)
-			return NULL;
-		goto again;
+		if (!td->error)
+			goto again;
 	}
 
 	if (needs_lock)