iolog: convert drop warning to fio_did_warn()
authorJens Axboe <axboe@kernel.dk>
Mon, 12 Feb 2018 17:19:18 +0000 (10:19 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 12 Feb 2018 17:19:18 +0000 (10:19 -0700)
Signed-off-by: Jens Axboe <axboe@kernel.dk>
debug.h
iolog.c

diff --git a/debug.h b/debug.h
index 84d6fafd89c83bd4e9fad37ef0dc0c796e0f5018..a2b6fa67307deb75ccaeb72223871cdfc6e75aac 100644 (file)
--- a/debug.h
+++ b/debug.h
@@ -43,6 +43,7 @@ enum {
        FIO_WARN_ROOT_FLUSH     = 1,
        FIO_WARN_VERIFY_BUF     = 2,
        FIO_WARN_ZONED_BUG      = 4,
+       FIO_WARN_IOLOG_DROP     = 8,
 };
 
 #ifdef FIO_INC_DEBUG
diff --git a/iolog.c b/iolog.c
index 760d7b0a43d97962bb7d065c6e464c7b89a7f5f5..34e74a80a2f9ed2c278d6835f172acf650a4a9f9 100644 (file)
--- a/iolog.c
+++ b/iolog.c
@@ -1141,8 +1141,6 @@ size_t log_chunk_sizes(struct io_log *log)
 
 #ifdef CONFIG_ZLIB
 
-static bool warned_on_drop;
-
 static void iolog_put_deferred(struct io_log *log, void *ptr)
 {
        if (!ptr)
@@ -1152,10 +1150,8 @@ static void iolog_put_deferred(struct io_log *log, void *ptr)
        if (log->deferred < IOLOG_MAX_DEFER) {
                log->deferred_items[log->deferred] = ptr;
                log->deferred++;
-       } else if (!warned_on_drop) {
+       } else if (!fio_did_warn(FIO_WARN_IOLOG_DROP))
                log_err("fio: had to drop log entry free\n");
-               warned_on_drop = true;
-       }
        pthread_mutex_unlock(&log->deferred_free_lock);
 }