bpf: run bpf programs with preemption disabled
authorAlexei Starovoitov <ast@kernel.org>
Tue, 29 Jan 2019 02:43:34 +0000 (18:43 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 31 Jan 2019 22:14:55 +0000 (23:14 +0100)
commit6cab5e90ab2bd323c9f3811b6c70a4687df51e27
tree0fc39a3f8010ea54edab9f8d70014b447ccb6bd2
parent1bb54c4071f585ebef56ce8fdfe6026fa2cbcddd
bpf: run bpf programs with preemption disabled

Disabled preemption is necessary for proper access to per-cpu maps
from BPF programs.

But the sender side of socket filters didn't have preemption disabled:
unix_dgram_sendmsg->sk_filter->sk_filter_trim_cap->bpf_prog_run_save_cb->BPF_PROG_RUN

and a combination of af_packet with tun device didn't disable either:
tpacket_snd->packet_direct_xmit->packet_pick_tx_queue->ndo_select_queue->
  tun_select_queue->tun_ebpf_select_queue->bpf_prog_run_clear_cb->BPF_PROG_RUN

Disable preemption before executing BPF programs (both classic and extended).

Reported-by: Jann Horn <jannh@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
include/linux/filter.h
kernel/bpf/cgroup.c