From: Julia Lawall <julia@diku.dk>
Date: Tue, 28 Jul 2009 15:54:58 +0000 (+0200)
Subject: fs/romfs: correct error-handling code
X-Git-Tag: v2.6.32-rc1~58^2~7
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=88a0a53d702b1fa39ed9e631939d2dbd92dfe486;p=linux-2.6-block.git

fs/romfs: correct error-handling code

romfs_fill_super() assumes that romfs_iget() returns NULL when
it fails.  romfs_iget() actually returns ERR_PTR(-ve) in that
case...

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/romfs/super.c b/fs/romfs/super.c
index 47f132df0c3f..c117fa80d1e9 100644
--- a/fs/romfs/super.c
+++ b/fs/romfs/super.c
@@ -528,7 +528,7 @@ static int romfs_fill_super(struct super_block *sb, void *data, int silent)
 	pos = (ROMFH_SIZE + len + 1 + ROMFH_PAD) & ROMFH_MASK;
 
 	root = romfs_iget(sb, pos);
-	if (!root)
+	if (IS_ERR(root))
 		goto error;
 
 	sb->s_root = d_alloc_root(root);