From: Richard Weinberger Date: Sun, 12 Apr 2015 22:52:38 +0000 (+0200) Subject: netfilter: Fix format string of nfnetlink_queue proc file X-Git-Tag: v4.1-rc1~128^2~18 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=6b46f7b7e97e58a23fd96c3bfc1efee9da3d1a3d;p=linux-2.6-block.git netfilter: Fix format string of nfnetlink_queue proc file The printed values are all of type unsigned integer, therefore use %u instead of %d. Otherwise an user can face negative values. Fixes: $ cat /proc/net/netfilter/nfnetlink_queue 0 29508 278 2 65531 0 2004213241 -2129885586 1 1 -27747 0 2 65531 0 0 0 1 2 -27748 0 2 65531 0 0 0 1 Signed-off-by: Richard Weinberger Acked-by: Pablo Neira Ayuso Signed-off-by: David S. Miller --- diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c index 49267f8e33b1..0b98c7420239 100644 --- a/net/netfilter/nfnetlink_queue_core.c +++ b/net/netfilter/nfnetlink_queue_core.c @@ -1251,7 +1251,7 @@ static int seq_show(struct seq_file *s, void *v) { const struct nfqnl_instance *inst = v; - seq_printf(s, "%5d %6d %5d %1d %5d %5d %5d %8d %2d\n", + seq_printf(s, "%5u %6u %5u %1u %5u %5u %5u %8u %2d\n", inst->queue_num, inst->peer_portid, inst->queue_total, inst->copy_mode, inst->copy_range,