From: Viresh Kumar Date: Tue, 22 Oct 2019 10:17:57 +0000 (+0530) Subject: cpufreq: Clarify the comment in cpufreq_set_policy() X-Git-Tag: for-linus-20191205~94^2~3^2~2^2~2^2~1 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;ds=sidebyside;h=737ffb27f2f1a8fe6644cac535486f7f25bbf6cb;p=linux-2.6-block.git cpufreq: Clarify the comment in cpufreq_set_policy() One of the responsibility of the ->verify() callback is to make sure that the policy's min frequency is <= max frequency as this isn't guaranteed by the QoS framework which gave us those values. Update the comment in cpufreq_set_policy() to clarify that. Suggested-by: Rafael J. Wysocki Signed-off-by: Viresh Kumar [ rjw: Minor changes of the new comment ] Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 48a224a6b178..dd1628192310 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2385,7 +2385,10 @@ int cpufreq_set_policy(struct cpufreq_policy *policy, new_policy->min = freq_qos_read_value(&policy->constraints, FREQ_QOS_MIN); new_policy->max = freq_qos_read_value(&policy->constraints, FREQ_QOS_MAX); - /* verify the cpu speed can be set within this limit */ + /* + * Verify that the CPU speed can be set within these limits and make sure + * that min <= max. + */ ret = cpufreq_driver->verify(new_policy); if (ret) return ret;