staging: lustre: llite: fix ifnullfree.cocci warnings
authorkbuild test robot <fengguang.wu@intel.com>
Thu, 30 Apr 2015 16:21:55 +0000 (00:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Apr 2015 20:27:38 +0000 (22:27 +0200)
drivers/staging/lustre/lustre/llite/dir.c:1440:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/dir.c

index 0f5d57cb149ad865cd740e23018875644d638ed3..f17154aaa3297cf28bc09bdddfec3429bc41bc87 100644 (file)
@@ -1436,8 +1436,7 @@ lmv_out_free:
                        goto free_lmv;
                }
 free_lmv:
-               if (tmp)
-                       kfree(tmp);
+               kfree(tmp);
                return rc;
        }
        case LL_IOC_REMOVE_ENTRY: {