media: vcodec: fix ptr_ret.cocci warnings
authorFengguang Wu <fengguang.wu@intel.com>
Wed, 11 Apr 2018 21:14:39 +0000 (17:14 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 9 May 2018 19:58:30 +0000 (15:58 -0400)
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1087:1-3: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 648a9576932a ("media: vcodec: fix error return value from mtk_jpeg_clk_init()")

CC: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c

index af17aaa21f5840d9443771977f204acf089679e2..328e8f650d9b9a47273731f1c4a19cb2bd15868e 100644 (file)
@@ -1084,10 +1084,7 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
                return PTR_ERR(jpeg->clk_jdec);
 
        jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
-       if (IS_ERR(jpeg->clk_jdec_smi))
-               return PTR_ERR(jpeg->clk_jdec_smi);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(jpeg->clk_jdec_smi);
 }
 
 static int mtk_jpeg_probe(struct platform_device *pdev)