ext4: ext4_mkdir should dirty dir_block with newly created directory inode
authorDarrick J. Wong <djwong@us.ibm.com>
Wed, 31 Aug 2011 16:00:51 +0000 (12:00 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 31 Aug 2011 16:00:51 +0000 (12:00 -0400)
ext4_mkdir calls ext4_handle_dirty_metadata with dir_block and the inode "dir".
Unfortunately, dir_block belongs to the newly created directory (which is
"inode"), not the parent directory (which is "dir").  Fix the incorrect
association.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/namei.c

index 09f930b7a785075c8a0d32b98d6f76016e9be4e7..f0abe4323136284a630ad053b7ce04c88576f3da 100644 (file)
@@ -1862,7 +1862,7 @@ retry:
        ext4_set_de_type(dir->i_sb, de, S_IFDIR);
        inode->i_nlink = 2;
        BUFFER_TRACE(dir_block, "call ext4_handle_dirty_metadata");
-       err = ext4_handle_dirty_metadata(handle, dir, dir_block);
+       err = ext4_handle_dirty_metadata(handle, inode, dir_block);
        if (err)
                goto out_clear_inode;
        err = ext4_mark_inode_dirty(handle, inode);