ceph: d_obtain_{alias,root}(ERR_PTR(...)) will do the right thing
authorAl Viro <viro@zeniv.linux.org.uk>
Wed, 20 Dec 2023 05:20:54 +0000 (05:20 +0000)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 15 Jan 2024 14:40:51 +0000 (15:40 +0100)
Clean up the code.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/export.c

index 726af69d4d62cd7341c0c1aefa46fd553f89ec47..a79f163ae4ed2ce1962289478b348c53a338a8c0 100644 (file)
@@ -286,8 +286,6 @@ static struct dentry *__snapfh_to_dentry(struct super_block *sb,
                doutc(cl, "%llx.%llx parent %llx hash %x err=%d", vino.ino,
                      vino.snap, sfh->parent_ino, sfh->hash, err);
        }
-       if (IS_ERR(inode))
-               return ERR_CAST(inode);
        /* see comments in ceph_get_parent() */
        return unlinked ? d_obtain_root(inode) : d_obtain_alias(inode);
 }