[PATCH] Generic infrastructure for acls
authorAndreas Gruenbacher <agruen@suse.de>
Fri, 29 Sep 2006 09:01:34 +0000 (02:01 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 29 Sep 2006 16:18:24 +0000 (09:18 -0700)
The patches solve the following problem: We want to grant access to devices
based on who is logged in from where, etc.  This includes switching back and
forth between multiple user sessions, etc.

Using ACLs to define device access for logged-in users gives us all the
flexibility we need in order to fully solve the problem.

Device special files nowadays usually live on tmpfs, hence tmpfs ACLs.

Different distros have come up with solutions that solve the problem to
different degrees: SUSE uses a resource manager which tracks login sessions
and sets ACLs on device inodes as appropriate.  RedHat uses pam_console, which
changes the primary file ownership to the logged-in user.  Others use a set of
groups that users must be in in order to be granted the appropriate accesses.

The freedesktop.org project plans to implement a combination of a
console-tracker and a HAL-device-list based solution to grant access to
devices to users, and more distros will likely follow this approach.

These patches have first been posted here on 2 February 2005, and again
on 8 January 2006. We have been shipping them in SLES9 and SLES10 with
no problems reported.  The previous submission is archived here:

   http://lkml.org/lkml/2006/1/8/229
   http://lkml.org/lkml/2006/1/8/230
   http://lkml.org/lkml/2006/1/8/231

This patch:

Add some infrastructure for access control lists on in-memory
filesystems such as tmpfs.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/Kconfig
fs/Makefile
fs/generic_acl.c [new file with mode: 0644]
include/linux/generic_acl.h [new file with mode: 0644]

index d311198bba439d812421331e7aea06a5046aa176..deb9eec9f6ee78494770eebbc8dbb836e0abf1ee 100644 (file)
@@ -1940,6 +1940,10 @@ config 9P_FS
 
          If unsure, say N.
 
+config GENERIC_ACL
+       bool
+       select FS_POSIX_ACL
+
 endmenu
 
 menu "Partition Types"
index 89135428a539184580b2b0305ec46f6e7d5bfa86..46b8cfe497b2206e66fd986617e5b554116174a9 100644 (file)
@@ -35,6 +35,7 @@ obj-$(CONFIG_BINFMT_FLAT)     += binfmt_flat.o
 obj-$(CONFIG_FS_MBCACHE)       += mbcache.o
 obj-$(CONFIG_FS_POSIX_ACL)     += posix_acl.o xattr_acl.o
 obj-$(CONFIG_NFS_COMMON)       += nfs_common/
+obj-$(CONFIG_GENERIC_ACL)      += generic_acl.o
 
 obj-$(CONFIG_QUOTA)            += dquot.o
 obj-$(CONFIG_QFMT_V1)          += quota_v1.o
diff --git a/fs/generic_acl.c b/fs/generic_acl.c
new file mode 100644 (file)
index 0000000..9ccb789
--- /dev/null
@@ -0,0 +1,197 @@
+/*
+ * fs/generic_acl.c
+ *
+ * (C) 2005 Andreas Gruenbacher <agruen@suse.de>
+ *
+ * This file is released under the GPL.
+ */
+
+#include <linux/sched.h>
+#include <linux/fs.h>
+#include <linux/generic_acl.h>
+
+/**
+ * generic_acl_list  -  Generic xattr_handler->list() operation
+ * @ops:       Filesystem specific getacl and setacl callbacks
+ */
+size_t
+generic_acl_list(struct inode *inode, struct generic_acl_operations *ops,
+                int type, char *list, size_t list_size)
+{
+       struct posix_acl *acl;
+       const char *name;
+       size_t size;
+
+       acl = ops->getacl(inode, type);
+       if (!acl)
+               return 0;
+       posix_acl_release(acl);
+
+       switch(type) {
+               case ACL_TYPE_ACCESS:
+                       name = POSIX_ACL_XATTR_ACCESS;
+                       break;
+
+               case ACL_TYPE_DEFAULT:
+                       name = POSIX_ACL_XATTR_DEFAULT;
+                       break;
+
+               default:
+                       return 0;
+       }
+       size = strlen(name) + 1;
+       if (list && size <= list_size)
+               memcpy(list, name, size);
+       return size;
+}
+
+/**
+ * generic_acl_get  -  Generic xattr_handler->get() operation
+ * @ops:       Filesystem specific getacl and setacl callbacks
+ */
+int
+generic_acl_get(struct inode *inode, struct generic_acl_operations *ops,
+               int type, void *buffer, size_t size)
+{
+       struct posix_acl *acl;
+       int error;
+
+       acl = ops->getacl(inode, type);
+       if (!acl)
+               return -ENODATA;
+       error = posix_acl_to_xattr(acl, buffer, size);
+       posix_acl_release(acl);
+
+       return error;
+}
+
+/**
+ * generic_acl_set  -  Generic xattr_handler->set() operation
+ * @ops:       Filesystem specific getacl and setacl callbacks
+ */
+int
+generic_acl_set(struct inode *inode, struct generic_acl_operations *ops,
+               int type, const void *value, size_t size)
+{
+       struct posix_acl *acl = NULL;
+       int error;
+
+       if (S_ISLNK(inode->i_mode))
+               return -EOPNOTSUPP;
+       if (current->fsuid != inode->i_uid && !capable(CAP_FOWNER))
+               return -EPERM;
+       if (value) {
+               acl = posix_acl_from_xattr(value, size);
+               if (IS_ERR(acl))
+                       return PTR_ERR(acl);
+       }
+       if (acl) {
+               mode_t mode;
+
+               error = posix_acl_valid(acl);
+               if (error)
+                       goto failed;
+               switch(type) {
+                       case ACL_TYPE_ACCESS:
+                               mode = inode->i_mode;
+                               error = posix_acl_equiv_mode(acl, &mode);
+                               if (error < 0)
+                                       goto failed;
+                               inode->i_mode = mode;
+                               if (error == 0) {
+                                       posix_acl_release(acl);
+                                       acl = NULL;
+                               }
+                               break;
+
+                       case ACL_TYPE_DEFAULT:
+                               if (!S_ISDIR(inode->i_mode)) {
+                                       error = -EINVAL;
+                                       goto failed;
+                               }
+                               break;
+               }
+       }
+       ops->setacl(inode, type, acl);
+       error = 0;
+failed:
+       posix_acl_release(acl);
+       return error;
+}
+
+/**
+ * generic_acl_init  -  Take care of acl inheritance at @inode create time
+ * @ops:       Filesystem specific getacl and setacl callbacks
+ *
+ * Files created inside a directory with a default ACL inherit the
+ * directory's default ACL.
+ */
+int
+generic_acl_init(struct inode *inode, struct inode *dir,
+                struct generic_acl_operations *ops)
+{
+       struct posix_acl *acl = NULL;
+       mode_t mode = inode->i_mode;
+       int error;
+
+       inode->i_mode = mode & ~current->fs->umask;
+       if (!S_ISLNK(inode->i_mode))
+               acl = ops->getacl(dir, ACL_TYPE_DEFAULT);
+       if (acl) {
+               struct posix_acl *clone;
+
+               if (S_ISDIR(inode->i_mode)) {
+                       clone = posix_acl_clone(acl, GFP_KERNEL);
+                       error = -ENOMEM;
+                       if (!clone)
+                               goto cleanup;
+                       ops->setacl(inode, ACL_TYPE_DEFAULT, clone);
+                       posix_acl_release(clone);
+               }
+               clone = posix_acl_clone(acl, GFP_KERNEL);
+               error = -ENOMEM;
+               if (!clone)
+                       goto cleanup;
+               error = posix_acl_create_masq(clone, &mode);
+               if (error >= 0) {
+                       inode->i_mode = mode;
+                       if (error > 0)
+                               ops->setacl(inode, ACL_TYPE_ACCESS, clone);
+               }
+               posix_acl_release(clone);
+       }
+       error = 0;
+
+cleanup:
+       posix_acl_release(acl);
+       return error;
+}
+
+/**
+ * generic_acl_chmod  -  change the access acl of @inode upon chmod()
+ * @ops:       FIlesystem specific getacl and setacl callbacks
+ *
+ * A chmod also changes the permissions of the owner, group/mask, and
+ * other ACL entries.
+ */
+int
+generic_acl_chmod(struct inode *inode, struct generic_acl_operations *ops)
+{
+       struct posix_acl *acl, *clone;
+       int error = 0;
+
+       if (S_ISLNK(inode->i_mode))
+               return -EOPNOTSUPP;
+       acl = ops->getacl(inode, ACL_TYPE_ACCESS);
+       if (acl) {
+               clone = posix_acl_clone(acl, GFP_KERNEL);
+               posix_acl_release(acl);
+               if (!clone)
+                       return -ENOMEM;
+               error = posix_acl_chmod_masq(clone, inode->i_mode);
+               if (!error)
+                       ops->setacl(inode, ACL_TYPE_ACCESS, clone);
+               posix_acl_release(clone);
+       }
+       return error;
+}
diff --git a/include/linux/generic_acl.h b/include/linux/generic_acl.h
new file mode 100644 (file)
index 0000000..80764f4
--- /dev/null
@@ -0,0 +1,36 @@
+/*
+ * fs/generic_acl.c
+ *
+ * (C) 2005 Andreas Gruenbacher <agruen@suse.de>
+ *
+ * This file is released under the GPL.
+ */
+
+#ifndef GENERIC_ACL_H
+#define GENERIC_ACL_H
+
+#include <linux/posix_acl.h>
+#include <linux/posix_acl_xattr.h>
+
+/**
+ * struct generic_acl_operations  -  filesystem operations
+ *
+ * Filesystems must make these operations available to the generic
+ * operations.
+ */
+struct generic_acl_operations {
+       struct posix_acl *(*getacl)(struct inode *, int);
+       void (*setacl)(struct inode *, int, struct posix_acl *);
+};
+
+size_t generic_acl_list(struct inode *, struct generic_acl_operations *, int,
+                       char *, size_t);
+int generic_acl_get(struct inode *, struct generic_acl_operations *, int,
+                   void *, size_t);
+int generic_acl_set(struct inode *, struct generic_acl_operations *, int,
+                   const void *, size_t);
+int generic_acl_init(struct inode *, struct inode *,
+                    struct generic_acl_operations *);
+int generic_acl_chmod(struct inode *, struct generic_acl_operations *);
+
+#endif